Time  Nick             Message
22:04 koha-jenkins     Project Koha_19.05_D9 build #234: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/234/
21:59 koha-jenkins     Project Koha_19.05_D8 build #240: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/240/
21:59 tuxayo           !bang
21:59 tuxayo           >_<
21:58 koha-jenkins     Project Koha_19.05_U18 build #236: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/236/
21:53 tuxayo           Yay finally caught up with release maintenance of 19.05 :)
20:34 oleonard         ...but I think I've got it
20:33 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 normal, P3, ---, oleonard, ASSIGNED , Actions button on Search results from Z39.50 is displayed incorrectly
20:33 oleonard         tuxayo: Fighting with Bug 25702
20:24 tuxayo           oleonard: fighting with the OPAC bootstrap migration?
20:20 davidnind        Marie-Luce: your more than welcome!
20:03 caroline_catlady davidnind++
20:01 Marie-Luce       thanks davidnind for this gitlab introduction
20:00 koha-jenkins     Project Koha_19.05_U18 build #235: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/235/
20:00 wahanui          Congratulations!
20:00 koha-jenkins     Yippee, build fixed!
19:59 koha-jenkins     Project Koha_19.05_D9 build #233: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/233/
19:53 koha-jenkins     Project Koha_19.05_D8 build #239: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/239/
19:33 oleonard         I'm doing the coding version of swimming through molasses
19:00 koha-jenkins     Project Koha_20.05_D9 build #6: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_20.05_D9/6/
18:14 * oleonard       wonders why his Z3950 results sometimes contain a bunch of empty lines
17:36 koha-jenkins     Project Koha_19.11_D9 build #168: FIXED in 1 hr 9 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/168/
17:36 wahanui          Congratulations!
17:36 koha-jenkins     Yippee, build fixed!
17:13 koha-jenkins     Project Koha_19.11_U18 build #168: FIXED in 45 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/168/
17:13 wahanui          Congratulations!
17:13 koha-jenkins     Yippee, build fixed!
17:03 koha-jenkins     Project Koha_19.11_D8 build #171: FIXED in 36 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/171/
17:03 wahanui          Congratulations!
17:03 koha-jenkins     Yippee, build fixed!
16:34 koha-jenkins     Project Koha_19.11_D10 build #14: STILL FAILING in 6 min 55 sec: https://jenkins.koha-community.org/job/Koha_19.11_D10/14/
15:11 reiveune         bye
14:47 tuxayo           Hey the continuous integration is looking pretty good now :)
14:47 tuxayo           Joubu++ for the diagnostic
14:46 koha-jenkins     Project Koha_Master_D9 build #1366: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1366/
14:46 tuxayo           Ok, I'll use that to show the difference between the old and the new bug.
14:45 tuxayo           hooooo
14:45 Joubu            the method in t::lib::Dates deals with that comparaison correctly
14:45 Joubu            we assume there are both init in the same second, but that's wrong
14:45 Joubu            tuxayo: it's the comparaison of 2 datetimes that have not been init at the same time
14:43 koha-jenkins     Project Koha_Master_D10 build #267: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D10/267/
14:43 koha-jenkins     Project Koha_Master_D9_MDB_Latest build #324: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/324/
14:42 tuxayo           *a two major version jump
14:42 tuxayo           That's two major versions.
14:42 tuxayo           wynn1212: You might want to check if there are gotchas when migrating a database from MariaDB 10.1 to MariaDB 10.3
14:40 wynn1212         Thank you tuxayo! I'll now start to upgrade my debain 9 to debian 10.
14:40 tuxayo           ^^"
14:40 ashimema         I'm baffled.. so much of Koha::Calendar is basically a repeat of C4::Calendar!
14:39 tuxayo           yep
14:39 wynn1212         So after I upgrade to debian 10. And the mariaDB version is greater than 10.2.4. Then it's safe to remove DBMS auto increment fix script right?
14:39 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 minor, P5 - low, ---, chris, NEW , Charges/Fees.t is failing randomly
14:39 tuxayo           Joubu: about the bug similar to bug 24417, is the source the use of dt_from_string() or is()?
14:37 tuxayo           And have a backup anyway. It's a major upgrade after all
14:37 tuxayo           wynn1212: just double check that your mariadb is the right version
14:36 Joubu            It must be fixed
14:35 wynn1212         So is it "Safe" to leave DBMS auto increment fix script  or better to remove it when upgrade to debian 10?
14:30 wynn1212         And It says the problem was fix on mariadb 10.2.4. debian 9 has mariadb 10.1.44 and debian 10 has mariadb 10.3.22.
14:29 tuxayo           Thanks for clearing the confusion.
14:28 tuxayo           Joubu: indeed there was something about the DBMS version, I missed the appropriate section when jumping around the page
14:26 wynn1212         Yes. I follow this guide and also using the Multiple instances fix from this guide.
14:25 Joubu            wynn1212: check the wiki page, there are the DBMS versions on it - https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix
14:24 wynn1212         When I setting up koha 19.05 on debian 9. I experience data corruption because of this
14:23 wynn1212         I follow this https://github.com/KohaAloha/koha-mysql-init
14:23 tuxayo           *shouldn't change
14:22 tuxayo           wait, the DBMS should change anything I think. The problem it still there so the fix will be useful (IIUC)
14:22 tuxayo           wynn1212: is you fix this?    init-file=/var/lib/mysql/init-file_koha_fix.sql
14:20 tuxayo           *it might
14:20 tuxayo           wynn1212: will your DBMS change? (I might impact that)
14:20 wynn1212         Hi! Before upgrade form debian 9 to 10. Do I need to remove "DBMS auto increment fix" before upgrade to debian 10?
14:12 koha-jenkins     Project Koha_Master_D8 build #900: STILL UNSTABLE in 1 hr 3 min: https://jenkins.koha-community.org/job/Koha_Master_D8/900/
13:58 koha-jenkins     Project Koha_Master_D9_My8 build #348: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/348/
13:55 koha-jenkins     Project Koha_Master_D11 build #15: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D11/15/
13:48 koha-jenkins     Project Koha_Master_U18 build #819: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_Master_U18/819/
13:37 tcohen           and maybe tests should start with an unpopulated DB as well
13:37 tcohen           I like the second goal, Joubu
13:33 wynn1212         Also. Mine is currently the test server. But it will be production server after 1~2 month.
13:31 wynn1212         So. Is it safe to upgrade to debain 10 form debian 9 if I installed 20.05.00? Because from now my koha has been upgraded to 20.05.00  on my debian 9 server.
13:27 Joubu            tcohen: 2 things: 1. it won't alter the other DB (like we have tests that don't clean up), and 2. have the installer process tested (that need to drop and create the DB entirely to start from scratch)
13:26 Joubu            you can still install 20.05.00 on a test server if you have one
13:25 Joubu            wynn1212: yes it is, but I would recommend you to wait one more month and install 20.05.01 which will contain several bug fixes
13:21 tcohen           what is the importance of running the test suite on a separate database?
13:21 wynn1212         When I upgrade from koha 19.11 to koha 20.05
13:20 wynn1212         Just a small questions. Is it safe to upgrade from debian 9 to 10 with koha 20.05 installed?
13:15 did              khall: IIRC there's some permissions tests which fail as root because they can delete files
13:12 * khall          will ask tcohen about it
13:12 khall            Joubu I always just run them as root in ktd, which has always worked because it has all the correct environment variables set. For this however, running as root failes, but running as kohadev-koha works
13:12 Joubu            I did not know they passed with root :)
13:11 Joubu            khall: I always run the tests inside a koha-shell
13:10 khall            Joubu is there a particular reason you must be logged in via koha-shell instead of being root for koha-testing-docker?
13:09 koha-jenkins     Project Koha_Master_D10 build #266: FIXED in 1 hr 12 min: https://jenkins.koha-community.org/job/Koha_Master_D10/266/
13:09 wahanui          Congratulations!
13:09 koha-jenkins     Yippee, build fixed!
13:09 koha-jenkins     Project Koha_Master_D10_Deps build #7: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D10_Deps/7/
13:08 koha-jenkins     Project Koha_Master_U20 build #17: SUCCESS in 49 min: https://jenkins.koha-community.org/job/Koha_Master_U20/17/
13:08 khall            Joubu good thinking, I did not!
13:05 * tuxayo         runs to the grocery store, BBL
13:04 Joubu            khall: are you sure you restart_all and launch the test in kshell?
13:04 tcohen           morning
13:04 tuxayo           Ok! :D
13:03 Joubu            tuxayo: and add a patch ;)
13:03 Joubu            tuxayo: yes
13:03 Joubu            I have just retested following the 3 steps and it passes
13:03 tuxayo           Joubu: thanks, should I open another bug?
13:03 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Run tests on a separate database
13:03 Joubu            khall: weird error you got on bug 19821
12:58 Joubu            tuxayo: I let you a comment on 24417
12:57 Joubu            tuxayo: around?
12:54 koha-jenkins     Project Koha_Master_D9 build #1365: FIXED in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1365/
12:54 wahanui          Congratulations!
12:54 koha-jenkins     Yippee, build fixed!
12:50 Joubu            indeed
12:49 wynn1212         that folder is already exist. I guess it's for <zebra_lockdir>
12:48 Joubu            you will need to create the /var/lock/koha I guess
12:48 wynn1212         Thanks Joubu!
12:48 Joubu            if you really want to get rid of the warning, create a /var/lock/koha/$INSTANCE (replace $INSTANCE by your Koha instance name) and add <lockdir>/var/lock/koha/$INSTANCE</lockdir> to your koha-conf file
12:48 caroline         I searched the wiki and didn't find anything on koha-conf, should we add a page for that?
12:47 caroline         thx Joubu++ :)
12:47 Joubu            The lockdir is used by cronjob scripts, if the config does not have a lockdir entry, a temporary files will be used instead
12:46 Joubu            wynn1212: the warning is not blocker, you can safely ignore it.
12:46 caroline         wynn1212: like Joubu said, you may need to add a <lockdir> entry
12:46 wynn1212         Hi caroline!  I can only found <zebra_lockdir> in my koha-conf.xml
12:45 Joubu            you certainly will need to create the config entry actually
12:44 caroline         wynn1212: open your koha-conf.xml file and change the directory in the <lockdir> entry
12:44 wynn1212         Hi ashimema! did  you mean post koha-conf.xml configuration file or?
12:39 ashimema         bbiab
12:39 ashimema         koha-conf.xml wynn1212
12:39 ashimema         fancy a walk now
12:39 ashimema         anywho.. food for thought.. I'll comment on the bug later
12:39 ashimema         hense my patches so far just sticking with H1 in the top nav ;)
12:38 wynn1212         How too fix this issue?
12:38 ashimema         indeed
12:38 wynn1212         Hi! I upgraded my koha version from 19.11 to 20.05. When I go to System Information. I get this warning:"You are missing the <lockdir> entry in your koha-conf.xml file. Please add it, pointing to your koha instance's lock dir"
12:38 oleonard         I think it requires some research
12:37 ashimema         'Welcome, User X' on the right side of the main page when logged in
12:36 ashimema         like.. 'Refine search' on the search results page
12:36 oleonard         What do you mean by nav blocks?
12:36 ashimema         you should only have one h1 per page
12:36 magnuse          +1
12:36 ashimema         but then what are the nav blocks ?
12:36 ashimema         totally agree oleonard
12:35 oleonard         ashimema my instinct is to say that h1 should always be the heading that begins maincontent
12:35 ashimema         feels like we shouldn't be using headings for the 'title' of nav blocks at all
12:34 ashimema         I'm not suggesting removing it.. but moving it to the relevant element.. problem is.. I'm not sure which ends up the most relevant ..
12:34 oleonard         caroline: Currently h1 is in the global header include, it's styled to show the Koha logo
12:34 caroline         ah ok! sorry I didn't catch the first part of the conversation :)
12:34 ashimema         h1 is indeed very important for screen readers.. that's where the conversation stems from caroline ;)
12:33 ashimema         right nwo we have h1 top, h2 for block headings + the maincontent then h3 etc beneath any h2's
12:33 caroline         isn't h1 important for screen readers and accessibility?
12:33 ashimema         I wasn't entirely sure how the h2 headings we already have for lots of navigational stuff should/would work
12:33 oleonard         :)
12:32 ashimema         and
12:32 ashimema         then I realised that would mean going through every template in Koha and updating the headings..
12:32 ashimema         about the h1 level.. I initially thought why not remove it... but...
12:32 * magnuse        thinks oleonard will win in the end
12:31 wahanui          hi oleopard
12:31 ashimema         hi oleonard
12:31 * oleonard       has been fighting with this interface for too many years
12:30 * caroline       now has the pokemon theme song stuck in her head
12:30 caroline         Can't catch em all (unlike pokemon)
12:24 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 trivial, P5 - low, ---, oleonard, Pushed to master , Menu for Action menubutton in dataTables like MARC frameworks page separated from the button
12:24 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 normal, P3, ---, oleonard, ASSIGNED , Actions button on Search results from Z39.50 is displayed incorrectly
12:24 oleonard         Ugh... Bug 25702 seems to be caused by Bug 25282, but apparently none of our QA testing revealed it...
12:18 huginn           News from kohagit: Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5ae7554667a209962a169f3a3b1d4b5b4beb398c>
12:18 huginn           News from kohagit: Bug 25557: Correct basket.pl column config <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=79f7879303724aa1ae69db8c3f2ea5aa34148dc5>
12:18 huginn           News from kohagit: Bug 25492: Your Account Menu button does nothing on mobile devices <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9ac43fd97b58120560a33e26509d5acc712c97fb>
12:18 huginn           News from kohagit: Bug 17842: UTF-8 encode ISO2709 MARC download from cart <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=13ec430eccd52413e756c88f90a370787842cbc2>
12:18 huginn           News from kohagit: Bug 25634: Warn if koha-shell returns non-zero in koha-foreach <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4c548cb08f3f3013778da71d47745f48b6adffd8>
12:18 huginn           News from kohagit: Bug 17842: Simplify the code <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=74c7530e3dacd7a1df9ed72d031bc1a5b7063142>
12:18 huginn           News from kohagit: Bug 25651: Fix modification of authorised value <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4d003ad9cd5a0967f3235d687340a8b75d36acd3>
12:18 huginn           News from kohagit: Bug 25653: Update tab selector to use 'active' and include all options <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4365b64403ba9492650e2e1733ccad8772dcdfc2>
12:18 huginn           News from kohagit: Bug 25677: Checkbox options for EDI accounts cannot be enabled <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4714b08f7270b86c62d9e32ce8f14d3afb08f37e>
12:18 huginn           News from kohagit: Bug 14543: (QA follow-up) Add missing filter <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=369a4e39b48456be4376292f724a787ef0b6667e>
12:18 huginn           News from kohagit: Bug 25693: Set correct permissions on logdir after an upgrade <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88cd45b0903ae7cfd8939045e60ffc7b0361e16c>
12:18 huginn           News from kohagit: Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e239e13bc9663dc3d4a43f125761165875b08876>
12:18 huginn           News from kohagit: Bug 25707: (QA follow-up) Clearer message about what's going on <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f32825ae26aa443a1fde2c8884852e4298d96916>
11:51 ashimema         probably not a good time for mtj ?
11:49 ashimema         I also imagine a plain hashref is likely to be less heavy on memory compared to a Set object.. but that's just a feeling.. not evidence at all
11:49 ashimema         comparing a DateTime::Set->contains call to a hashref lookup.. pretty obvious which is most likely to win
11:48 ashimema         I don't think I really needed to do that comparison.. but hey
11:48 ashimema         hashref       16995927/s       370467%            --
11:48 ashimema         DateTime::Set     4586/s            --         -100%
11:48 ashimema         Rate DateTime::Set       hashref
11:38 kohaputti        if the library has the books in transfer state but in a room accessible for patrons then some of the patrons might go pick up those books and checkout them even though they were supposed to be transferred to another branch
11:36 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 normal, P5 - low, ---, koha-bugs, NEW , SIP should not allow to check out an item in transfer because of a hold to another patron
11:36 kohaputti        on transfer item being able to be checked out causes at least a problem with bug 25690
11:36 kohaputti        would it be reasonable to make koha force ending transfer before it can be checked out to a patron?
11:13 oleonard         That datatables.js file is a collection of DataTables customizations
11:12 TimothyAlexis_   Oh I see, it's part of the datatables plugin for jQuery...
11:11 TimothyAlexis_   Where is this fnAddFilters function? :/
11:11 TimothyAlexis_   specifically this part: my_table.fnAddFilters("filter", 500);
11:11 TimothyAlexis_   Does anyone here know how this works? https://wiki.koha-community.org/wiki/DataTables_HowTo#Adding_by-column_filtering
10:58 ashimema         I'm just writing a script for that now
10:58 ashimema         yeah.. benchmarking is good
10:58 ashimema         :)
10:55 wahanui          eythian: i'm not following you...
10:55 eythian          wahanui used to have a factoid about that very situation, I'm sure.
10:55 cait1            eythian: I feel you ... have to do slides
10:53 oleonard         o/
10:51 eythian          https://gitlab.com/eythian/tracker if you're interested, it has a video :)
10:51 eythian          remember to benchmark. I have a little project I'm doing for myself at the moment that contains a loop that can run hundreds of thousands of times. I went through a few iterations of naive "this'll surely make it faster" type things, only to find that usually it made no difference except for making things harder to read.
10:48 ashimema         the more i look at this module the more little optimisations I see :(
10:48 ashimema         haha
10:48 ashimema         have fun
10:48 ashimema         haha
10:47 eythian          oh wait, it's lunch time. More procrastination possible.
10:47 * eythian        stops procrastinating on writing a billing auditing system.
10:35 ashimema         indeed
10:34 eythian          Then make sure you somehow trigger that to be rebuilt if the holiday schedule is changed, that's probably the hardest part :)
10:34 ashimema         indeed
10:33 eythian          "date" here is just a yyyy-MM-dd string.
10:33 ashimema         if I can get that far I will ;)
10:33 ashimema         indeed
10:33 eythian          give each open day a number, starting whenever, ignoring the days you don't want to count. Put those into an array indexed by their number. Also have a reverse index so you can find the number for a date easily. Then just do lookups and subtraction?
10:32 Joubu            ys
10:32 Joubu            ashimema: why not comparing strings? It's what's done for single_holida
10:28 ashimema         my brain hasn't worked out how to remove iterations yet.. but if we can use a lighter dates object that gives us all we need still.. then it's still a win
10:27 ashimema         we deffo need really solid tests... but I think we mostly do for that module now :)
10:27 ashimema         so for fines.. the iterations can grow very very fast.. ;)
10:26 ashimema         will do
10:26 Joubu            cc me on the reports
10:26 ashimema         right now.. when calculating a date using the calendar, for a 30 day loan for example, the best case scenario is we iterate 30 + n (where n is the number of closed days we meet along the way).. each iteration instantiates a DateTime object 1 + n times per holiday
10:26 Joubu            ashimema: I am happy to help on that one. Keep me in touch :)
10:21 ashimema         next_open_day, prev_open_day etc can all be updated to not instantiate DT's
10:21 eythian          easy to precompute that for, say, 10 years worth.
10:20 Joubu            that's why we need DT for exception_holidays
10:20 Joubu            264     my $dow = $localdt->day_of_week;
10:20 ashimema         then working backwards
10:20 ashimema         it's the first step to being able to just pass Y,M,T to is_holiday instead of a full DT object.
10:19 ashimema         take a look at 'is_holiday'.. that is similarly taking a DT object and then in most cases using the ymd strings for comparison (except in this exception_holdiays case.. which is why I want to remove DateTime::Set
10:19 Joubu            try to replace that, then copy what's done for single_holiday to exception_holiday
10:18 ashimema         indeed Joubu.. that's one place.
10:18 ashimema         it's the module as a whole that gets me
10:18 eythian          We also do a lot of date operations on strings, too, to avoid a pile of DateTime stuff.
10:18 Joubu            the ymd can be built from $year, $month, $day
10:18 Joubu            yes, that seems wrong :)
10:18 Joubu            123                 push @ymd_arr, $dt->ymd('');
10:17 Joubu            122                 )->truncate( to => 'day' );
10:17 Joubu            121                     time_zone => 'floating',
10:17 Joubu            120                     year      => $year,
10:17 Joubu            119                     month     => $month,
10:17 Joubu            118                     day       => $day,
10:17 Joubu            117                 my $dt = DateTime->new(
10:17 ashimema         eythian
10:17 ashimema         totally agree euthian
10:17 ashimema         the issue I see is simply how much we instantiate DT objects just to do a single comparison and then throw it away again.. especially when we end up not using the DT comparison methods but instead do simple string comparisons from formatted strings coming from the DT object
10:16 eythian          It depends where your slowness is, but if there's stuff that can be done ahead of time, rather than being done over and over at runtime, it can help.
10:16 cait1            eythian: sounds interesting - there was a proposed calendar rewrite that added this to a table i think - i'd like it much better if it was only in a hash
10:15 Joubu            precompute?
10:14 eythian          I haven't looked at your cases, but one thing we do for dates is precompute the next several years worth on process start and chuck that into a hash, which then gives us extremely fast date operations.
10:14 Joubu            I am pretty sure our whole Koha::Calendar can be replaced with another module in cpan
10:14 ashimema         I'm talking about the internal logic here cait
10:14 cait1            single holidays and exception should be treated differently, one is a holiday and the other is not? :)
10:13 magnuse          ashimema++ Joubu++
10:13 Joubu            there is also Date::Calendar
10:10 ashimema         I shall benchmark it ;)
10:09 ashimema         for reference
10:09 ashimema         also, https://www.perl.com/article/148/2015/2/2/Time-Moment-can-save-time/
10:09 ashimema         I'm saying for Koha::Calendar in certain well tested area's we could give a pretty big performance boost
10:08 ashimema         I'm not saying remove DT entirely
10:08 Joubu            but yeah, if you have plenty of time available, go for it ;)
10:08 Joubu            and we rely quite a lot on DT
10:08 Joubu            I would not move away from that stability
10:08 Joubu            well, we had enough trouble to make our date handling a bit stable
10:07 ashimema         example
10:07 ashimema         http://blogs.perl.org/users/chansen/2014/08/timemoment-vs-datetime.html
10:07 ashimema         this would be a first step to swapping out DateTime for a more performance time library
10:06 ashimema         DateTime instantiations is
10:06 ashimema         but...
10:06 ashimema         no.. well I've not directly tested it yet
10:06 Joubu            unless ::Set->contains is super slow?
10:05 Joubu            you won't get much differences, only on the first hit when the cache is not populated yet
10:05 Joubu            but really, it's cached anyway
10:04 ashimema         awesome.. I'll add a report and do it.
10:04 ashimema         I was literally just looking at that bug :)
10:03 ashimema         haha..
10:03 Joubu            So yes, it would make sense to replace it for exception_holidays as well
10:03 Joubu            ashimema: The ::Set for single_holidays has been removed on 5d256e6b4b4045ca6845292e19707dd087a9db1b
10:01 Joubu            they are DT init anyway
10:01 ashimema         also.. DateTime instantiation = slow.. so lots and lots of needless instantiations seems daft
10:01 ashimema         and.. personally I like the hashcheck version.. as much as it's a little more code at our end.. it's super clear and doesn't require the use of yet another dependency without really using most of the dependencies functionality..
10:00 ashimema         exactly.. they in effect do the exact same thing in the end
09:59 Joubu            ashimema: I don't understand why there are 2 different ways
09:59 magnuse          nasty librarieses...
09:58 ashimema         yes.. they did roll forward lots of due dates.. but those already overdue before the lockdown were not.. and they want to properly calculate fines for thme
09:57 ashimema         Covid has raised it's head again.. libraries are looking at re-opening and have set massive periods of closed dates.. so the fines jobs are taking forever to run
09:56 ashimema         reason I ask, is I can see a route forward to swapping out DateTime for Time::Moment in this module.. which.. considering we do massive numbers of iterations inside here.. could lead to a pretty big performance boost
09:56 TimothyAlexis_   Would there be a standard Koha way to achieve that?
09:56 ashimema         just cash a hashref and check keys rather than using an entire object when we really only use one method from it in one place
09:55 ashimema         but we could easily enough do the same as we do for single_holidays
09:55 TimothyAlexis_   Adding a button that filters on the 'canrenew' boolean.
09:55 Joubu            we need it there. How would we replace it?
09:55 ashimema         indeed
09:55 Joubu            ashimema: 259     if ( $self->exception_holidays->contains($localdt) ) {
09:54 * ashimema       is looking into a few bugs around the performance of Koha::Calendar
09:54 TimothyAlexis_   We have some borrowers with hundreds of checked out items and want to allow them to filter that column.
09:54 ashimema         it's used once inside Koha::Calendar.. but I'm not really sure why single_holidays and exception_holidays are treated differently
09:54 kohaputti        I probs don't have time to look into those before my summer holidays so letting you know
09:54 ashimema         wondering if you might support dropping DateTime::Set ?
09:53 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 enhancement, P5 - low, ---, lari.taskula, Needs Signoff , Koha::CirculationRules->set_rules should handle scopes per rule
09:53 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114 enhancement, P5 - low, ---, lari.taskula, Needs Signoff , Remove duplicated logic from GetLoanLength()
09:53 kohaputti        there are few nice patches for refactoring koha circulation code that needs sign-off, e.g. Bug 25114 and Bug 25112
09:53 TimothyAlexis_   In the table #checkoutst there is a column for details about renewal.
09:53 Joubu            yes
09:52 TimothyAlexis_   Hello, I am wondering if there perhaps is already an easy way to achieve this. Looking at opac-user.pl and opac-user.tt and thinking about jQuery DataTables, perhaps there is.
09:51 ashimema         Joubu around?
09:09 cait1            I was pretty sure it was not on the bugs list.. but a normal one. But also the first reports appears to be jajm?
09:07 cait1            too hectic this morning
09:06 cait1            lol sorry,wrong link
09:06 cait1            [off] http://koha.1045719.n5.nabble.com/Bug-24986-New-Maximum-row-size-reached-soon-for-borrowers-and-deletedborrowers-td6073929.html#a6089555 magnuse
08:43 ashimema         :)
08:36 eythian          hi
08:11 marcelr          ashimema: still testing on the row size
08:03 cait1            or let me, but remind me of the bug number
08:03 cait1            google the error?
08:03 cait1            googleß
08:03 ashimema         Well.. we should definitely normalise addresses.. that's been on my list for years
08:03 cait1            i am not sure, i't been a bit ago
08:01 ashimema         Oh really.m I must have misread.. I thought you'd said you had some extra fields.
07:50 magnuse          cait1: any idea when or what list?
07:45 cait1            borrowers is for sure our biggest table column wise rigtht now - it hink items might be getting clsoe
07:45 cait1            not only magnuse has seen it
07:45 cait1            we had a report of this bug on the mailing list too a while ago
07:40 magnuse          i am doing some extra digging to try an find an old backup
07:37 magnuse          ashimema: the live instance where i saw it had no custom columns
07:32 ashimema         I don't think you'll produce it on a community install.. sounds like it's really only run into when people have added lots of their own custom columns to the table
07:30 ashimema         if we don't feel it warrants the quick fix then I can work on a 1:n in a medium term as an alternative instead of a followup
07:29 ashimema         but was happy with Joubu's patch as an interim
07:29 ashimema         I agree we should move it to 1:n really
07:22 Joubu            yes we could. I am not considering this a priority however
07:21 marcelr          we should probably put addresses separately and allow 1:n
07:20 marcelr          Good question, I suppose that this one is an exception though
07:19 Joubu            it seems to be the correct things to do but, is that enough? Do we have other tables that will reach the limit soon?
07:19 marcelr          ok will have a try with it a bit
07:19 Joubu            then confirm that the change fixes it
07:19 Joubu            I really would like to recreate the problem on a production DB
07:18 Joubu            I am not convinced
07:18 marcelr          Or are you convinced already?
07:18 marcelr          Joubu would you like me to test the varchar thing ? Row size..
07:17 Joubu            hi marcelr :)
07:08 marcelr          hi Joubu
07:04 huginn           Joubu: The operation succeeded.
07:04 Joubu            @later tell tcohen koha_es_1 exited with code 137
07:04 huginn           Joubu: The operation succeeded.
07:04 Joubu            @later tell tcohen certainly related on Master_D9 #1364 - es_1  [2020-06-11T18:35:24,996][o.e.x.m.p.NativeController] [HT4FDd8] Native controller process has stopped - no new native processes can be started
07:04 Joubu            hum?
07:04 wahanui          i already had it that way, huginn.
07:04 huginn           Joubu: Error: The command "info" is available in the Factoids and RSS plugins.  Please specify the plugin whose command you wish to call by using its name as a command before "info".
07:04 Joubu            @later tell tcohen certainly related on Master_D9 #1364 - es_1         | [2020-06-11T18:35:24,996][INFO ][o.e.x.m.p.NativeController] [HT4FDd8] Native controller process has stopped - no new native processes can be started
07:02 huginn           Joubu: The operation succeeded.
07:02 Joubu            @later tell tcohen OOM on docker_4, see 19.11_D9 run #167
06:56 wahanui          que tal, alex_a
06:56 alex_a           Bonjour
06:56 cait             good morning all!
06:47 marcelr          hi reiveune
06:39 reiveune         hello
06:25 marcelr          tcohen++ # koha-docker !
06:25 marcelr          hi #koha
05:24 dcook            I sometimes think I must be the only person who sees 3:30pm on a Friday and wishes he had more time... heh
03:45 huginn           Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 new feature, P1 - high, ---, aleisha, Needs Signoff , Recalls for Koha
03:45 aleisha          hey team, i would love to get bug 19532 in this next release!
03:03 koha-jenkins     Project Koha_19.11_D8 build #169: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/169/
02:51 koha-jenkins     Project Koha_19.05_U18 build #234: UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/234/
02:36 koha-jenkins     Project Koha_19.11_D9 build #166: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/166/
02:26 koha-jenkins     Project Koha_19.11_U18 build #166: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/166/
02:12 koha-jenkins     Project Koha_19.11_D8 build #168: SUCCESS in 53 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/168/
02:07 koha-jenkins     Project Koha_19.05_D9 build #232: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/232/
01:52 koha-jenkins     Project Koha_19.05_D8 build #238: SUCCESS in 29 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/238/
01:43 koha-jenkins     Project Koha_19.05_U18 build #233: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/233/
01:23 koha-jenkins     Project Koha_19.11_U18 build #165: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/165/
01:23 koha-jenkins     Project Koha_19.11_D9 build #165: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/165/
01:18 koha-jenkins     Project Koha_19.11_D8 build #167: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/167/
00:40 koha-jenkins     Project Koha_19.05_U18 build #232: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/232/
00:38 koha-jenkins     Project Koha_19.05_D9 build #231: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/231/
00:32 koha-jenkins     Project Koha_19.05_D8 build #237: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/237/
00:10 koha-jenkins     Project Koha_19.11_D9 build #164: SUCCESS in 1 hr 10 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/164/