Time Nick Message 00:00 koha-jenkins Yippee, build fixed! 00:00 wahanui Congratulations! 00:00 koha-jenkins Project Koha_19.05_D8 build #203: FIXED in 25 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/203/ 00:33 koha-jenkins Project Koha_19.11_D9 build #143: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/143/ 00:37 koha-jenkins Yippee, build fixed! 00:37 wahanui Congratulations! 00:37 koha-jenkins Project Koha_19.11_U18 build #142: FIXED in 51 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/142/ 01:04 koha-jenkins Project Koha_19.05_U18 build #202: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/202/ 06:34 reiveune hello 06:35 dersmon hi everyone 06:54 dersmon are there any plans to support http://www.loc.gov/marc/bibliographic/bd882.html when merging? 06:58 alex_a Bonjour 08:25 dersmon i am trying to call https://<domain>/api/v1/.html but get an 403, my admin settings: basic auth: active, restpublicAPI: active, using my normal admin credentials in basic auth does not work 08:25 dersmon what am i missing? ;) 08:29 Joubu Are you using the latest master? We pushed bug 25327 recently 08:29 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 minor, P5 - low, ---, tomascohen, Pushed to master , Cannot access API spec 08:32 dersmon ah - no i am currently on 19.05.05.000 08:33 Joubu you should not need the bugfix from 25327 then 08:57 dersmon there is normally no further setup required for the rest api? 09:00 Joubu dersmon: try with a superlibrarian account and call a list route (like GET /api/v1/patrons) 09:00 ashimema mornin' #koha 09:00 Joubu if you still get an error, check the Koha log file, you may find something relevant there (but not sure you you will see something else that "not authorized") 09:00 Joubu morning ashimema 09:01 dersmon ah, now i get 09:01 dersmon { "error": "Something went wrong, check the logs." } 09:01 dersmon :D 09:02 dersmon [Tue May 12 11:02:01.310949 2020] [cgi:error] [pid 9526] [client 10.201.0.120:55532] AH01215: [Tue May 12 11:02:01 2020] app.pl: Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 180.: /usr/share/koha/api/v1/app.pl 09:03 Joubu that's just a warning 09:06 Joubu dersmon: seeing something else? 09:06 dersmon not concerning the patrons call 09:07 dersmon but there is also: [Tue May 12 10:58:11.106830 2020] [authz_core:error] [pid 8614] [client 10.201.0.120:55490] AH01630: client denied by server configuration: /usr/share/koha/api/v1/.html 09:07 Joubu that's coming from your apache config I'd say 09:07 dersmon let me recheck, maybe that was a call without basic auth 09:08 Joubu https://httpd.apache.org/docs/current/mod/mod_authz_core.html 09:38 dersmon the /api route is configured in apache-shared-opac.conf 09:54 Joubu dersmon: my feeling is that you have a special config that relies on the authz_core 09:54 Joubu apache mod 09:54 Joubu grep "authz_core" in your apache config files 10:05 ashimema bug 24378 10:05 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378 trivial, P5 - low, ---, katrin.fischer, Passed QA , Change wording on AUTO_RENEWALS notice in updatedatabase 10:05 ashimema am I right in thinking I need to apply the same change to all the languages files 10:08 cait1 it shoudl be done 10:08 cait1 bug 23787 deals with the template files 10:08 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 normal, P5 - low, ---, andrew, Passed QA , Add AUTO_RENEWALS in sample_notices.sql 10:08 cait1 that's why i noted somewhere they go together 10:08 ashimema ok.. 10:09 ashimema they do indeed.. but they seemed to be in reverse order 10:09 ashimema all good 10:09 cait1 yeah that could be 10:23 huginn News from kohagit: Bug 24185: Add mentorship <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7dc2aa28b711fa1e488173e78bba2dd92e9c8237> 10:23 huginn News from kohagit: Bug 24027: Add Mentorship lines <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=18acb9a0d542d5b93cc85d25dd10cfb22e38bc3c> 10:23 huginn News from kohagit: Bug 25184: (RM follow-up) Make DB update idempotent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f248063ee557af6d19afc17f4801213287e76b95> 10:23 huginn News from kohagit: Bug 24378: DBRev 19.12.00.088 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=12dfbe7f037dae1c4825de53932a10c29e7b3852> 10:23 huginn News from kohagit: Bug 25418: (QA follow-up) Raise size of input box <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=98c98df95500e7c899385926be466c5c88308fd3> 10:23 huginn News from kohagit: Bug 24378: (QA follow-up) fix minor issues <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3f9fc43a71c92d5394955efce9e2108c83894f79> 10:23 huginn News from kohagit: Bug 25421: Update POD <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=312efadd315fb8b0c1d2a952aab672f77f60672a> 10:23 huginn News from kohagit: Bug 24378: (follow-up) Format due date as due date <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cf0a6f48202d3a2c5170db2afb658c47bacce03f> 10:23 huginn News from kohagit: Bug 25409: Add missing "Required" text and "required" classes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=643309499aeaafc7da33abf6c2c52b13ab9321bd> 10:23 huginn News from kohagit: Bug 25421: Make ->pickup_locations only return an arrayref <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f1e9fe75080b9a02c49730cbdb341cf09ca9826> 10:23 huginn News from kohagit: Bug 25421: Remove use of Koha::Libraries->pickup_locations <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6aeeae3e707d449403ad08914acfdb6b7a1e831f> 10:23 huginn News from kohagit: Bug 22437: (follow-up) Move deletion of merge requests to DelAuthority <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=278df89bb5f86c8f7369405a8aa5d4a32b739643> 10:23 huginn News from kohagit: Bug 25418: (bug 25133 follow-up) Display due date with hours <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5d26407e4d1b5a8d5b42c67c8649b55a2ecab9d4> 10:23 huginn News from kohagit: Bug 25342: Unit test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1eae01fa14602c32f0e2de925b60b5f3a2b83db1> 10:23 huginn News from kohagit: Bug 25409: Add missing "required" class to template <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6c95f7154856b03b53d620642417ca8179c12377> 10:23 huginn News from kohagit: Bug 25342: Force ES id as string <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2a804074030ef02f58ba708db26192ff44fc61cd> 10:23 huginn News from kohagit: Bug 24378: Database update to rewrite notice if left unchanged <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d5fa69df93e5efda3d7ab87dbf90e822b006876c> 10:23 huginn News from kohagit: Bug 22437: Add test case to Merge.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6b85d1b073bf2f29c9c604a627f15aff7aad12ab> 10:23 huginn News from kohagit: Bug 22437: Delete older merge requests at new merge time <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=891307f29be27113475b1605a558799ab9874c01> 10:23 huginn News from kohagit: Bug 24378: Change wording of auto_renewals notice in updatedatabase <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eba7a32df59093b02a5f707b06f636a85be465f7> 10:26 cait1 has someone seen: UPLERR_CANNOT_WRITE" 10:26 cait1 ? 10:26 cait1 in our 18.11 installations we can't upload files 10:26 * kohaputti apparently became a mentor (as per the commit messages) :) 10:26 ashimema :) 10:26 ashimema yup 10:27 ashimema you got mentioned as a great help by Nugged.. so I added you in :) 10:27 ashimema credit where credit is due :) 10:27 kohaputti yeah, I've been working with nugged 10:27 Joubu cait1: check permissions 10:27 ashimema :D 10:27 cait1 Joubu: which and where? 10:27 cait1 we fond nothing more in the logs and at the moment i am a little lost where to start 10:28 Joubu where the files are uploaded 10:28 ashimema ownership and permissions for the upload directory.. which is usually mentioned in koha-conf cait1 10:28 cait1 aha 10:29 cait1 possible this was new/changed between 17.11 and 18.11? 10:29 cait1 i guess 10:29 ashimema erm.. pass 10:30 cait1 looking atkoha-conf now - thx for the hint! 10:30 ashimema :) 10:31 cait1 <upload_path></upload_path> 10:31 Joubu so /tmp is used 10:31 Joubu or any others tmp paths defined 10:32 ashimema systemd does funky things with tmp cait.. that's why upload_path was introduced I believe 10:32 ashimema easiest fix I know of is to defined a suitable one and set the permissions on it yourself 10:33 cait1 that was from the default one 10:33 cait1 but I guess we might be missing the entry 10:33 cait1 when you update - we don't change koha-conf.xml, do we? I usually don't deal with that part 10:49 huginn News from kohagit: Bug 15253: Remove specific logging output <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=61718c5c57ff4d17992624126dc2edbadb394d74> 10:49 huginn News from kohagit: Bug 25279: (QA follow-up) Use .escapeHtml <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8771232293cf6e9a1aed77b5e8f9dbaceb8590a2> 10:49 huginn News from kohagit: Bug 24823: (QA follow-up) Fix deletion and POD <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=74ff965734dc069ffa18b0158ef07fcef664d118> 10:49 huginn News from kohagit: Bug 25279: Replace encodeURI with encodeURIComponent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=daaabc21302421653e17dce33e280a0d5e8b8d3a> 10:49 huginn News from kohagit: Bug 25279: URI-escape city_id in links <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e3aa4ddf6106b4e0ed3f4b441681c3a911c36d1a> 10:49 huginn News from kohagit: Bug 13547: (QA follow-up) Add basic tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ff15008d20430079fe8bbad51df1709f6663cc7a> 10:49 huginn News from kohagit: Bug 13547: (follow-up) Improve POD for template plugin <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=10c642cb008a7aba563002f800afb96d03c91efc> 10:49 huginn News from kohagit: Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8cb408cf15663dfc68762d0d1bb8f746b9bfa00d> 10:49 huginn News from kohagit: Bug 15253: Convert all tabs into 4 spaces in affected files <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b47e18637d58faa20e40e991845e10fac53305f0> 10:49 huginn News from kohagit: Bug 15253: Log trapped errors as log level 'warn' instead of 'error' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=46c9d97cfd8d3010386a483bfc147b75d1d58707> 10:49 huginn News from kohagit: Bug 15253: Rename syslog() to siplog() <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ec5ffbd059f5d9534ebd586fbb4278854c3bb285> 10:49 huginn News from kohagit: Bug 15253: Add log4perl conf updates for Debian packages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2c43e95e0cd108d0a4722f4c96215c278e762fc1> 10:49 huginn News from kohagit: Bug 13547: (follow-up) Item field 'Materials specified' would be useful to see in... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2bb243bb6283b6deab82b8d7744ceb288e32e9a2> 10:49 huginn News from kohagit: Bug 24823: Remove unused parameters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d9bfbefaaf72f7827279204f5867cdcfcb0ab16d> 10:49 huginn News from kohagit: Bug 24823: Fix spelling error and remove last of Catmandu <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=419d158c7f4c3034c332e4ab6e8d4e3b14f19c5b> 10:49 huginn News from kohagit: Bug 24823: Drop Catmandu dependency <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6dac19f1e27db98b0f03f940576f1bf6bb69cf74> 10:49 huginn News from kohagit: Bug 13547: Add item field 3 (Materials specified) to the OPAC holdings table <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=660edd0524477641c074fd7b083ba977d26fe6f5> 10:49 huginn News from kohagit: Bug 22970: Allow to change homebranch in batch add course reserves <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0ef02cea4a2a2b247127a6b02352f84f9e9b3ea9> 10:49 huginn News from kohagit: Bug 15253: Move subs to a new module, allow unit tests to function <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4bc14ef0523a942e6723c8e68372d9ffe45621f2> 10:49 huginn News from kohagit: Bug 15253: Add Koha::Logger based logging for SIP2 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=315f544cdc4b17912a12e41b90615d54babba705> 10:50 Joubu ashimema: seen my comment on bug 15253? 10:50 wahanui I haven't seen 'my', Joubu 10:50 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 enhancement, P5 - low, ---, kyle, Pushed to master , Add Koha::Logger based logging for SIP2 10:51 ashimema yeah.. I was going to task tcohen and mtj with ensuring log files are correct for packages :) 10:51 ashimema thanks for getting that one over the line.. I think we can improve upon it next cycle but this is a good step in the right direction I feel. 11:00 koha-jenkins Project Koha_Master_D9_MDB_Latest build #286: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/286/ 11:02 koha-jenkins Project Koha_Master_D8 build #863: UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/863/ 11:36 koha-jenkins Project Koha_Master_D9 build #1327: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1327/ 11:57 koha-jenkins Project Koha_Master_U18 build #779: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U18/779/ 12:19 cait1 oleonard: I was wondering if bug 25462 could be a css issue? 12:19 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 enhancement, P5 - low, ---, david.roberts, Needs Signoff , Shelving location should be on a new line in holdings table 12:25 * oleonard snaps awake 12:31 Joubu ashimema: could you consider bug 25070 for 20.05? It will help 20.05 Rmaint to backport patches 12:31 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Include files to display address and contact must be refactored 12:31 Joubu (and it's awesome) 12:40 ashimema Well.. I've just caught up on the queue and was about to send a mail with string freeze announcement and some slightly updated dates.. once Jenkins is happy 12:40 ashimema So.. if it's very nearly there.. I can hold off on that for later today and take a look 12:41 ashimema Could be the last string changing enhancement 12:41 ashimema Got anyone lined up to QA it.. wasn't Cait on the case 12:42 kohaputti has anybody build any tools for getting forked koha db back to correspond the community schema? I will have fun times with this if not :D 12:44 Joubu ashimema: no string changes expected 12:44 ashimema awesome 12:45 Joubu it was more about pushing an enh after the feature freeze 12:45 ashimema then go for it :) 12:45 ashimema as you say.. pushing it now will aid future backports 12:46 oleonard You don't have to squint too hard to see it as a bug fix 12:46 Joubu kohaputti: can you detail? 12:46 Joubu oleonard: heh indeed 12:46 kohaputti I have bunch of installations with https://github.com/KohaSuomi/Koha/ that has tons of db schema changes. Now I want to use KC koha for those installations. Looking for the best way to do that. 12:47 kohaputti KC = Koha Community 12:47 huginn News from kohagit: Bug 25417: (QA follow-up) Add integration test for AddReturn <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5bff65dd7a76f69d3cfb91c5e4806b3618edf3b3> 12:47 huginn News from kohagit: Bug 25417: (QA follow-up) Restore 'fixing' of fines <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b84e00f7e2f8c8b05c798ee08a1fee203903c27> 12:47 huginn News from kohagit: Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=49d2756f7be4815e7e93874710241506d6a3f9fc> 12:47 huginn News from kohagit: Bug 25417: Prevent negative debit amount on backdating returns <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=53349e8000d7073220fedb48bcd910abec7a592b> 12:47 huginn News from kohagit: Bug 25417: Add unit test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2c9a322486e003e9f36d48fa72a5dd27b6ebcad9> 12:47 ashimema could be a fun task kohaputti.. not sure how you could generalise that.. it'll need a script writing specifically for your changes I imagine 12:48 kohaputti My best plan for now I just run some pre-sql and after-sql scripts before and after updatedatabase.pl 12:48 Joubu insert the structure, dump it, then diff? 12:49 kohaputti Joubu, yeah something like that, and then deal with also the changes for data even if the schema would be the same 12:50 kohaputti will let you know how it progresses! :) 12:52 Joubu kohaputti: a diff of the kohastructure.sql should give you almost a direct answer. Unless your fork did not update it when a DB structure change happened. 12:52 koha-jenkins Project Koha_Master_D9_My8 build #311: UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/311/ 12:53 kohaputti Joubu, the fork cherry-picks db schema changes from multiple koha versions... 12:54 koha-jenkins Project Koha_Master_D10 build #227: STILL UNSTABLE in 1 hr 17 min: https://jenkins.koha-community.org/job/Koha_Master_D10/227/ 12:55 Joubu then the kohastructure.sql should be kept up-to-date with the DB structure, and a simple git diff should give you the answer 12:55 Joubu sorry if I missed something obvious ;) 12:57 kohaputti the issue is I cannot diff it to a certain koha version since the kohastructure.sql comes from multiple different versions, so I'm planning to rollback to the original version it started from and then upgrade. Most of the db structure changes are not used by the installations I manage. 13:00 cait1 kohaputti: not that I am not happy to hear you want to use KC koha, but why the change of heart? just interested 13:05 kohaputti cait1, I think everybody has had all along the goal to use KC Koha but there has been just so many features missing in the past, now for (mostly academic) libraries that is not the case. There are still other (public) libraries in finland and I don't think KC will provide for those libraries all they need so they will have to carry quite many things still in a fork. Somebody who manages the public library Kohas in Finland could comment on 13:05 kohaputti their plans better. 13:07 oleonard kohaputti I'm surprised to hear that it's the public libraries who think Koha lacks functionality they need, usually I hear the opposite 13:08 cait1 it might be local services like overdrive in the US? 13:09 cait1 i think htat's the case here too, we also have a feature heavy fork for public libraires (LMSCloud) 13:09 cait1 I think a big part of it is services for local providers 13:09 kohaputti oleonard, the academic libraries just started using koha around 1 year ago (on average) recently so there are not so many external dependencies that could have been developed over time. Public libraries have been using koha already for many years 13:09 kohaputti s/koha/koha-suomi koha fork/ 13:10 kohaputti now that there is the plugin system for rest api that helps a lot 13:14 kohaputti (and I mean here the academic libraries that we are managing currently, some of the academic libraries use different ILS) 13:16 cait1 kohaputti: keeping fingers crossed for your task - you are not the first to come backf rom forking, but i believe it's not always fun 13:17 kohaputti cait1, thanks :) 13:24 koha-jenkins Project Koha_Master_D8 build #864: STILL UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D8/864/ 13:46 koha-jenkins Project Koha_Master_D9_MDB_Latest build #287: STILL UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/287/ 14:00 koha-jenkins Project Koha_Master_D9 build #1328: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1328/ 14:38 koha-jenkins Project Koha_Master_D9_My8 build #312: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/312/ 14:40 koha-jenkins Project Koha_Master_U18 build #780: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_U18/780/ 14:51 reiveune bye 15:56 koha-jenkins Project Koha_Master_D10 build #228: STILL UNSTABLE in 1 hr 17 min: https://jenkins.koha-community.org/job/Koha_Master_D10/228/ 16:01 caroline comments/suggestions are welcome https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual#.3D.3E_New_writers.2C_start_here.21_.3C.3D 16:48 ashimema Nice with Caroline 16:48 ashimema s/with/work 17:14 koha-jenkins Project Koha_Master_D10 build #229: STILL UNSTABLE in 1 hr 17 min: https://jenkins.koha-community.org/job/Koha_Master_D10/229/ 17:52 tuxayo IIRC if I want to use the overdue process to restrict an account, I need to set this up in the notices triggers and then run this 17:52 tuxayo misc/cronjobs/overdue_notices.pl 17:52 tuxayo Is that all? 17:57 * cait waves 17:58 caroline afaik yes, that's how 17:59 caroline there's also a syspref to remove the restriction if the overdues are returned 18:00 tuxayo o/ caroline 18:00 tuxayo o/ cait 18:00 tuxayo > there's also a syspref to remove the restriction if the overdues are returned 18:00 tuxayo That's what I'm trying to test ^^ 18:00 tuxayo bug 24413 18:00 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 normal, P5 - low, ---, jonathan.druart, Needs Signoff , MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues 18:01 tuxayo > Is that all? 18:01 tuxayo Hum. Maybe I'm missing something. My patron isn't restricted. I'll check the branches 18:10 tuxayo hum, it's not a timing issue. (having to match the exact number of overdue days setup in the UI) 18:10 * tuxayo tries to remember other gotchas 18:25 cait are your restrictions o fthe right type? 18:25 cait ah 18:25 cait you are stuck on getting restricted? 18:27 cait when you run the overdues cron job, run it with -t 18:27 cait that will make it use the configuration you set up in the notice triggers, othewiese it might not work 18:27 cait but you need to match the delay 18:27 ashimema . 18:27 cait so say you got an item overdue yesterday, set the delay of the first trigger to 1 and restrict and then run the job 18:27 cait and make sure it#s not a holiday 18:27 cait tuxayo ^ 18:28 tuxayo > are your restrictions o fthe right type? 18:28 tuxayo What is a type of restriction? 18:29 cait we have 3 different ones 18:29 cait you are looking for OVERDUE i think 18:29 tuxayo > you are stuck on getting restricted? 18:29 tuxayo No, on the contrary, justice isn't enforced! 18:29 cait we have... SUSPEND 18:29 cait MANUAL 18:29 cait and... the one that is from fines in dayss, i forgot the code for this one 18:30 cait the patch description asks for the one set by the overdue_notices job 18:30 tuxayo /cgi-bin/koha/tools/overduerules.pl is the right place to configure that right?And then I run the cronjob 18:30 cait yes 18:30 tuxayo overdue_notices.pl without any params. 18:30 cait no with -t 18:31 cait otherwise the triggers are not used 18:31 cait (triggers set in overduerules) 18:34 tuxayo > otherwise the triggers are not used 18:34 tuxayo nor notifications nor restrictions work without -t? (and thus the overdue matching the exact delay) 18:34 tuxayo I though without -t it would send notifications and restrict but on the whole range of overdue days. Not only on the exact one. 18:36 cait i only ever used it with -t 18:36 cait how would it know when to restrict? 18:36 cait you set that up on the overduerules 18:36 cait maybe it can be done with a parameter to the cron too, i don#t know about that 18:38 tuxayo > how would it know when to restrict? 18:38 tuxayo I think it's like to be ran once a week and restrict at one all the people late, something like that. But indeed, using -t everyday seems much more common. 18:38 tuxayo misc/cronjobs/overdue_notices.pl -list-all 18:38 tuxayo => nothing 18:38 tuxayo That's the issue >_< 18:39 tuxayo My felon patron is somehow under the radar 18:40 cait i think there are possible other ways to do it, but ont common here 18:40 cait what is the dely you had? 18:40 cait and where is your -t? 18:40 cait and ist_all i tihn just influences what goes into the notice 18:41 cait -v might tell yo umore 18:41 tuxayo > what is the dely you had? 18:41 tuxayo 1 18:42 tuxayo > and where is your -t? 18:42 tuxayo overdue_notices.pl -list-all -t 18:42 tuxayo still empty 18:42 tuxayo > and ist_all i tihn just influences what goes into the notice 18:42 tuxayo hum, maybe 18:42 tuxayo https://perldoc.koha-community.org/misc/cronjobs/overdue_notices.html 18:43 cait when is your item overdue? 18:43 cait is today a holiday in your calendar? 18:47 cait caroline++ # nice email :) 18:49 tuxayo > when is your item overdue? 18:49 tuxayo Now it's two days ago. (testing different things) 18:49 tuxayo 1st rule: 1 day => restrict 18:50 tuxayo 2nd rule: 2 days => restrict 18:50 tuxayo 3nd rule: 3 days => restrict 18:50 tuxayo In case it was an off by one issue. 18:50 tuxayo The 3 rules are on the default library and also on the patron's library. 18:50 tuxayo > is today a holiday in your calendar? 18:50 tuxayo hm, let me check. 18:56 tuxayo No holiday now. I removed the Sunday closure because when I started to test with 2 days overdue I forgot that sunday might be an issue. 18:56 tuxayo My patron's crime still goes unpunished. 18:57 cait does any ontice get generated? 18:57 cait in other words, is only the restriction missing or the notice too? 18:57 cait does your patron have an email address? 19:01 tuxayo Ok. I'll try to set up the actual notice part and not only the restriction part. (it shouldn't be necessary right?) 19:04 cait it's the notices script... 19:04 cait i never tried to restrict without a ontice 19:04 cait i think they are tied 19:07 tuxayo I forgot what's is the DB table that should be populated if a notice has been generated. 19:07 cait messagequeue 19:08 tuxayo Oh right thanks 19:12 tuxayo Ok, I'm starting to get thing in there :D 19:12 tuxayo after I add triggers for email on default library. (weird, it's the patron's library that should matter right?) 19:13 tuxayo And my patron is restricted! 🎉🎉🎉 19:13 tuxayo cait++ 19:13 tuxayo No I have to understand why it finally worked ^^" 19:13 tuxayo *Now 19:15 tuxayo Notices are quite a wormhole. Thanks again cait, that will definitely be helpful to know how use this part of Koha. 19:21 cait definietley... a worm hole 19:21 cait add fines and it gets even worse 19:23 tuxayo There can be triggers for fees? Where are they? 19:28 cait basically ciruculation rules 19:28 cait thee are just double as many catches 19:29 tuxayo oh right >< 20:59 cait docs_team++ 21:00 caroline did we get new subscribers? 21:00 caroline team mates rather 21:01 davidnind caroline: I'm working through the merge requests later today, apologies that I didn't manage to get this done over the weekend 21:01 cait caroline: not only 1 - 4 21:01 davidnind yeah - lots of people have added themselves to the team for 20.11! 21:01 caroline no worries, I haven't been able to work on it for the last month, so I can't really blame you! 21:01 caroline woohoo! 21:02 caroline I see jzairo made her first commit too! 21:02 cait davidnind: i am missing your name... hope you will still be around? 21:04 davidnind there are several merge requests from jzairo to process, which is great! 21:04 davidnind cait: intend to be, just procrastinating as usual! 21:04 * cait is relieved :) 21:04 caroline me too! :) 21:04 davidnind I might actually do some documentation this time 21:05 cait you did like a gazillion of sign offs this ccyle 21:06 cait if that is you procrastinating... it works for me :) 21:06 davidnind my bad, there is one from jzairo, several from Kelly and Holly to merge though - something to do this evening! 21:06 caroline He is now know as David "Bug Wrangler" Nind 21:06 davidnind hehe 21:07 cait :) 21:07 davidnind :-D better start my day job now, see you all later! 21:08 cait have a good day! 21:09 davidnind have a good evening/night!