Time Nick Message 07:12 * paxed squints at checkouts.js 07:15 paxed copy-paste coding, best coding 07:15 ashimema[m] Checkouts.js is somewhat cryptic 07:17 paxed already submitted bug 24783 and while doing that, noticed there's couple places with straight up copypasted functions, in issues-table and relatives-issues-table 07:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24783 minor, P5 - low, ---, koha-bugs, NEW , Untranslatable strings in checkouts.js 07:19 ashimema[m] It would be lovely to clean it up at some point... Wish my JS was a tad better, I'm underskilled there really. 07:20 paxed anyone run a duplicate code detector on koha? ;) 07:21 ashimema[m] Also.. if your submitting strings for us, remember you can do it inline now.. were about to deprecate the rule for splitting it out into string includes 07:21 ashimema[m] I doubt it.. at least not for a long time 07:21 paxed i know about the inline stuff 07:22 paxed been waiting for it, tbh 07:23 ashimema[m] Coolios 07:23 ashimema[m] Just making sure before you plowed time into it doing it the hard way. 07:24 paxed thanks 07:35 reiveune hello 07:54 alex_a Bonjour 08:03 ashimema[m] Morning 08:07 magnuse o/ 09:24 huginn News from kohagit: Bug 23975: (QA follow-up) Add another plugin source <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3c9cc044ce9c2e8b37b98be5584b0b120940a183> 09:24 huginn News from kohagit: Bug 23975: (QA follow-up) Add missing TT filters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=21170c635cbdcb2d0b0ba2c4bb81f35c7cf58dab> 09:24 huginn News from kohagit: Bug 23975: (QA follow-up) Search button style and functionality <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c46dc0fadca08721b7e3e2909c1bbb13a8061ffe> 09:24 huginn News from kohagit: Bug 23975: (QA follow-up) Fix styling of install buttons <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=10cdbb9fde7529445d00fbe4f225d9aab2b25227> 09:24 huginn News from kohagit: Bug 17532: Make koha-shell propagate the error code <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ab94a12ee46c511b5c09326d37925081996f89aa> 09:24 huginn News from kohagit: Bug 23975: (follow-up) Don't rely on save_to being present <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=553627f12c388576af34af12b3867ea61ea5f03a> 09:24 huginn News from kohagit: Bug 23975: Add 'Install' support for github results <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f1dc82d70bb60de7dcccbb224cac8142054910b8> 09:24 huginn News from kohagit: Bug 24615: Make object.search helper also order by embedded columns <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ef1d49efb5d40ad3d620bc3b8472fb33edf5a475> 09:24 huginn News from kohagit: Bug 24502: (follow-up) Add all 3 query parameters in api definition <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=863f129a58f2ed850b0195fe956b9951f12ae94b> 09:24 huginn News from kohagit: Bug 24502: object.search also filter by prefetched columns <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=755d82015d78d4d0c8d33770e93db9bdd63cd587> 09:24 huginn News from kohagit: Bug 23975: Add ability to search and install plugins from GitHub <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7809a9fdd8c908e216844e906d58671c69a9e20e> 09:33 magnuse wow, bug 23975! 09:33 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 enhancement, P5 - low, ---, kyle, Pushed to master , Add ability to search and install plugins from GitHub 09:38 magnuse kia ora andreashm 09:45 ashimema[m] See the caveat note I just added on that one magnuse.. 09:45 ashimema[m] I really want it to serve as inspiration and spur some devs on to work on the followup bugs I've requested of it.. 09:46 ashimema[m] we need a way to sign plugin releases and validate those signatures on installation.. 09:46 ashimema[m] and gitlab support would be great.. 09:46 paxed and moving the plugin metadata out of the plugin code 09:47 ashimema[m] and really I'd like to switch from using ByWater, Theke and PTFS-E as examples in the config to using the community gitlab instead and adopting a couple of plugins to start us off 09:47 ashimema[m] yup.. thats on the wish list too paxed 09:47 paxed *nod* 09:47 ashimema[m] it's working out the 'how' as much as anything.. and furthering the guidelines for writing a plugin 09:48 paxed and we need more plugin hooks in the code itself ;) 09:48 ashimema[m] I'm thinking a metadata.yaml or something sitting at the top of the repo which on release gets packaged up, but also uploaded alongside the kpz along with a .asc signature file or some such 09:49 ashimema[m] expertise sought 09:49 ashimema[m] agreed on that front too 09:49 ashimema[m] one plugin I'm keen for community to adopt and improve is the recalls one from bywater.. 09:50 ashimema[m] right now it really doesn't play nice with packages due to its reliance on carefully timed cronjobs.. we should add some hooks to existing cron tasks to allow for pluging in before and after certain runs.. like the fines and overdues jobs. 09:51 cait or... we could integrate the recalls functionality 09:51 paxed i've done a couple plugin-related bugs, waiting for SO... 09:51 cait but there is also a bug for cronjobs for plugins somewhere 09:51 paxed bug 20897 09:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897 enhancement, P5 - low, ---, pasi.kallinen, Signed Off , Add generic cronjob to run plugins with a 'cronjob' method 09:58 koha-jenkins Project Koha_Master_D10 build #104: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D10/104/ 10:08 siju hi 10:09 siju I installed the debian package on MX Linux and got the following error 10:10 siju Reading package lists... Done Building dependency tree Reading state information... Done Suggested packages: letsencrypt The following NEW packages will be installed: koha-common 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 0 B/32.0 MB of archives. After this operation, 468 MB of additional disk space will be used. Preconfiguring packages ... Selecting previously unselected package koha-common. (Reading database ... 3290 10:10 siju how to troubleshoot 10:10 paxed your text got cut off after "Reading database", i suggest you use https://pastebin.com/ or similar 10:15 koha-jenkins Project Koha_Master_U18 build #648: STILL UNSTABLE in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U18/648/ 10:21 koha-jenkins Project Koha_Master_D9_My8 build #183: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/183/ 10:26 koha-jenkins Project Koha_Master_D8 build #729: STILL UNSTABLE in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D8/729/ 10:39 huginn News from kohagit: Bug 24757: (RM follow-up) Restore test count <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bd9960a2d209bbcf9a23d0a5b1ade4ccb77ec2ca> 10:39 huginn News from kohagit: Bug 24756: Catch two failed to load-variations in Security.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=292f56260592a124a28e98103b243696344bd5a0> 11:05 koha-jenkins Project Koha_Master_D9_MDB_Latest build #159: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/159/ 11:15 koha-jenkins Project Koha_Master_D9 build #1187: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1187/ 11:17 koha-jenkins Project Koha_Master_U18 build #649: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_U18/649/ 11:25 kohaputti We are using a fork of older version of koha and there was a bug with automatic renewals that it didn't work on the day before leap year day (28.2.2020). So just wondering if somebody else still had this bug with latest Koha version. 11:44 koha-jenkins Project Koha_Master_D8 build #730: STILL UNSTABLE in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D8/730/ 11:48 tcohen morning 11:51 koha-jenkins Project Koha_Master_D10 build #105: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D10/105/ 11:52 ashimema[m] morning tcohen 11:58 tcohen about the plugin install from repos feature, the theke repo isn't even maintained he, we will work on using the gitlab one for this testing purposes 11:59 tcohen ashimema[m] maybe we should add a 'source' column to the plugins 11:59 tcohen so we know where it's been installed from 12:01 ashimema[m] doesn't the 'Organization' column basically fullfil that? 12:02 ashimema[m] glad this is already getting people thinking.. that was the plan :) 12:02 ashimema[m] mwahaha 12:02 ashimema[m] lets polish it before release and get the followup bugs through 12:10 koha-jenkins Project Koha_Master_D9_My8 build #184: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/184/ 12:19 koha-jenkins Project Koha_Master_D9_MDB_Latest build #160: STILL UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/160/ 12:40 koha-jenkins Project Koha_Master_D9 build #1188: STILL UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1188/ 12:41 oleonard Hi #koha 12:59 oleonard Anyone around who could test the holds to pull report? 12:59 oleonard I'm getting nothing from it in master, and an error in the log 13:07 cait What's the error? 13:07 cait cannot test right now :( 13:08 oleonard ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'n_rules.categorycode IS NULL) WHERE reserves.found IS NULL AND reserveda' at line 36 13:17 oleonard Actually that's not right, that's the mysql error I get when I try to run the query directly, and there was a copy-paste error. 13:18 oleonard DBD::mysql::st fetchrow_hashref failed: fetch() without execute() 13:18 oleonard ...which I assume simply means, the query failed 13:25 cait hm 13:26 cait oh 13:26 cait or there s a missing line due to a rebase 13:26 cait trying to fetch before execute 13:43 Joubu /query kidclamp Hi Nick, are you around? 13:43 Joubu :) 14:09 oleonard On to the next error... When specifying an external XSLT file, "XSLT::Base: Could not create file parser context for file "https://static.myacpl.org/public/xslt/MARC21slim2OPACResults.xsl": No such file or directory at /kohadevbox/koha/Koha/XSLT/Base.pm line 331." 14:13 caroline hello all! 14:13 Joubu oleonard: maybe bug 23290 14:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23290 major, P5 - low, ---, m.de.rooy, Pushed to master , XSLT system preferences allow administrators to exploit XML and XSLT vulnerabilities 14:26 ashimema[m] I'm stuck on the recent failing selenium test I'm afraid Joubu.. looks like we're populating extra test data or something to me.. but I've not manage to narrow down from where it's getting populated 14:30 Joubu will take a look 14:30 ashimema[m] thanks dude 14:31 tcohen Joubu++ 14:43 corilynn is that how to get kidclamp to sign off on patches, add him as a cc? 14:43 vfernandes anyone with the following problem: the edit labels form appear with incorrect selected values 14:43 vfernandes ? 14:45 kidclamp lots of reminding, cc doesn't hurt 14:45 oleonard And by cc he means credit card payments 14:45 corilynn lol 14:46 kidclamp $$$$ 14:46 corilynn dolla dolla bills, ya'll 14:47 oleonard I should start a Patreon and only sign off patches from my top subscribers 14:51 oleonard After you 'reset-all' what is the superlibrarian login? 14:52 Joubu koha/koha I think 14:53 oleonard Yes, thanks Joubu 15:04 huginn News from kohagit: Bug 23355: DBRev 19.12.00.033 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ab0f1df0c1ec652f59a3978ec1414129b7251cf3> 15:04 huginn News from kohagit: Bug 23534: Fix selenium tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e2adf9f28cc59b578fc68549bca3f0f901265ab6> 15:04 huginn News from kohagit: Bug 23355: (QA follow-up) Add a modal confirm to the cashup action <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3252c8d2ddaf30c2bb7270dda5863a022abc3adb> 15:04 huginn News from kohagit: Bug 23355: Rename staff_id for manager_id <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dd44efbc847b7909cd2dbc9f57dc43e918ce0985> 15:04 huginn News from kohagit: Bug 23355: (QA follow-up) Missing koha_object(s)_class definitions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d6684f13fc65f0e84c386d47196826de5c65fdda> 15:04 huginn News from kohagit: Bug 23355: (QA follow-up) Add missing TT filters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a1d89f8b889c0cc5f538c4edc2081a7739d848c7> 15:04 huginn News from kohagit: Bug 23355: License fixes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d3015f84e3ec15eb8b21f45e06b7c96183e0ed75> 15:04 huginn News from kohagit: Bug 23355: Add register details page <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fcb545b4aed7d46daec23cddde192bbeb2eb380f> 15:04 huginn News from kohagit: Bug 23355: Split tests for Line vs Lines <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=16b3a163741227c21eaa842d7e2fdce0774f619d> 15:04 huginn News from kohagit: Bug 23355: Add CASHUP actions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=747531e8dec58acf37b739a0d8d8b04060a17111> 15:04 huginn News from kohagit: Bug 23355: [DO NOT PUSH] DBIC Classes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5cf1e85191cda1ba5515011be18ba296d06df896> 15:04 huginn News from kohagit: Bug 23355: Add cashup permissions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4d2037914c0481ef5fb5908a3cd3b59304b43ad2> 15:04 huginn News from kohagit: Bug 23355: Link cash_register_actions to cash_registers by foreign key <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=39ebdb4ea226d9e78bf1a774495022e85ffb1fd6> 15:04 huginn News from kohagit: Bug 23355: Add accountline deletion test <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8781527637451dbf02b58f5eb441e0fda6496774> 15:04 huginn News from kohagit: Bug 23355: Add cash_register_actions table <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=239ac3303c25ea25b41373ccba66b47968eefcd9> 15:04 Joubu oleonard: bug 23536 comment 8 - Are not you mistaken categorycode vs category_type? 15:04 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 minor, P5 - low, ---, oleonard, Pushed to master , Remove obsolete category markup from patron entry 15:05 oleonard I certainly hope not! 15:05 Joubu members/memberentry.pl: 'categoryname' => $patron_category->description, 15:06 Joubu hum, maybe me then, way before your patch 15:06 Joubu I will dig a bit 15:39 koha-jenkins Project Koha_Master_D9 build #1189: STILL UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1189/ 15:40 oleonard Can anyone confirm that setting OPACXSLTResultsDisplay to an external URL doesn't work? 15:42 oleonard I think I shouldn't be trying to debug anything today 15:50 reiveune bye 15:52 koha-jenkins Project Koha_Master_D10 build #106: STILL UNSTABLE in 47 min: https://jenkins.koha-community.org/job/Koha_Master_D10/106/ 16:00 koha-jenkins Project Koha_Master_U18 build #650: STILL UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U18/650/ 16:15 koha-jenkins Project Koha_Master_D9_My8 build #185: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/185/ 16:19 ashimema[m] oops.. I forgot to rename a DO NOT PUSH 16:19 ashimema[m] annoying 16:26 koha-jenkins Project Koha_Master_D8 build #731: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/731/ 16:54 koha-jenkins Project Koha_Master_D9_MDB_Latest build #161: STILL UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/161/ 17:04 huginn News from kohagit: Bug 23355: (RM follow-up) Remove reintroduced relationship <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f7630d746947b82b40098be4cbac266e4a494553> 17:04 huginn News from kohagit: Bug 23355: (RM follow-up) Add DROP statement for cash_register_actions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bdefa101078c597ed7664937e2c8e1c8c3643836> 17:10 corilynn olenard, can you comment on bug 24709 when you have a moment? 17:10 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 enhancement, P5 - low, ---, carnold, In Discussion , Advanced editor - show space after delimiter visually 17:20 oleonard corilynn: I'm not sure I'm doing the right thing to trigger the new behavior 17:21 corilynn so, add a delimiter by doing control-D and then a letter, and then a space 17:22 corilynn (in a field greater than 010) 17:45 koha-jenkins Project Koha_Master_D9 build #1190: STILL UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1190/ 17:55 koha-jenkins Yippee, build fixed! 17:55 koha-jenkins Project Koha_Master_U18 build #651: FIXED in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U18/651/ 17:57 koha-jenkins Project Koha_Master_D10 build #107: STILL UNSTABLE in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D10/107/ 18:23 koha-jenkins Yippee, build fixed! 18:23 koha-jenkins Project Koha_Master_D9_My8 build #186: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/186/ 18:35 koha-jenkins Project Koha_Master_D8 build #732: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/732/ 18:45 koha-jenkins Project Koha_Master_D9_MDB_Latest build #162: STILL UNSTABLE in 49 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/162/ 19:02 oleonard corilynn still around? 19:06 corilynn am now oleonard 19:06 oleonard corilynn: I agree with cait that the green background for the space after delimiter doesn't seem like the right choice 19:06 corilynn ok, wanna recommend a color? orange? 19:07 corilynn purple? 19:07 oleonard I'm curious whether you think the highlight has to be different than the one we have for double spaces. 19:07 corilynn green with purple polka-dots 19:07 corilynn I do think, yes 19:08 corilynn next thing in the lineup is spellcheck, BTW 19:10 oleonard In the lineup of features to add? 19:10 corilynn lineup of things my boss has requested, yes 19:16 lisettelatah Office does blue underline for at least some grammar errors. 19:20 corilynn We'd like this to be a bit more prominent than underline, as it's an insidious problem and common for people converting from OCLC 19:20 corilynn I can highlight blue 19:21 corilynn oleonard?? 19:25 oleonard How about "border: 2px dotted #FF3D33" ? 19:55 corilynn is it obvious? 20:00 * oleonard will leave that for the reader to decide 20:02 corilynn the reader is drowning 20:02 corilynn it's the reader's last day before going on the road for a month 21:37 lukeG When we use Amazon cover images are we allowed to remove the link that goes to that Amazon page on the OPAC? Or is that part of the deal with the devil? 21:46 caroline I think you can, but I don't think you're allowed ;)