Time Nick Message
19:05 kidclamp w
19:05 kidclamp ah, got it no
19:04 kidclamp I do not recreate
19:00 oleonard I believe all you need is to have AmazonCoverImages turned off
18:59 kidclamp the bug first
18:59 oleonard The bug, or the QA tool error kidclamp?
18:59 kidclamp oleonard:
18:58 kidclamp how do I recreate it Owen?
18:50 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 major, P3, ---, oleonard, Needs Signoff , JavaScript error on staff client catalog search results page
18:50 oleonard Bug 24713
18:42 ashimema[m] New one on me
18:20 oleonard anyone seen this error from the QA tool before? Attempt to reload Koha/Template/Plugin/Biblio.pm aborted.
18:09 koha-jenkins Project Koha_Master_D9 build #1177: STILL UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1177/
18:00 ashimema[m] Woop, woop... We have lift off for D10!
17:54 koha-jenkins Project Koha_Master_D10 build #95: NOW UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D10/95/
17:16 koha-jenkins Project Koha_Master_D9 build #1176: STILL UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1176/
17:10 oleonard And then my chat client crashed
17:08 oleonard Hello I am back
16:58 ashimema[m] mtj around?
16:49 koha-jenkins Project Koha_Master_D10 build #94: STILL FAILING in 7 min 28 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/94/
16:34 koha-jenkins Project Koha_Master_U18 build #638: FIXED in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U18/638/
16:34 koha-jenkins Yippee, build fixed!
16:07 koha-jenkins Project Koha_Master_D8 build #717: FIXED in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D8/717/
16:07 koha-jenkins Yippee, build fixed!
16:02 reiveune bye
15:54 koha-jenkins Project Koha_Master_D9 build #1175: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1175/
15:40 koha-jenkins Project Koha_Master_D10 build #93: STILL FAILING in 5 min 58 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/93/
15:39 koha-jenkins Project Koha_Master_D9_My8 build #175: FIXED in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/175/
15:38 koha-jenkins Yippee, build fixed!
15:34 koha-jenkins Project Koha_Master_D9_MDB_Latest build #151: FIXED in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/151/
15:34 koha-jenkins Yippee, build fixed!
15:15 huginn ashimema[m]: The operation succeeded.
15:15 ashimema[m] @later tell mtj just spotted that D10 only builds on your node.. is that right?
15:08 koha-jenkins Project Koha_Master_D8 build #716: UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D8/716/
15:00 koha-jenkins Project Koha_Master_U18 build #637: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_U18/637/
14:51 cait marcelr++ thx
14:44 koha-jenkins Project Koha_Master_D9 build #1174: UNSTABLE in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1174/
14:37 huginn News from kohagit: Bug 24661: (RM follow-up) Check lang is defined <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b2651484ed73fbfb178c82ef31f5bd89740e1589>
14:37 huginn News from kohagit: Bug 23290: (RM follow-up) Correction to copyright statement <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ba4fb0fdeec33dea91316b220ba24bd6b7b6d9a8>
14:35 koha-jenkins Project Koha_Master_D9_My8 build #174: UNSTABLE in 48 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/174/
14:23 koha-jenkins Project Koha_Master_D9_MDB_Latest build #150: UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/150/
13:52 koha-jenkins Project Koha_Master_D8 build #715: FIXED in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D8/715/
13:52 koha-jenkins Yippee, build fixed!
13:45 huginn News from kohagit: Bug 23290: XSLT system preferences allow administrators to exploit XML and XSLT vulne... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=322fbf151b0e5bd0f2e68a6d7e8157d1aa12910d>
13:45 huginn News from kohagit: Bug 23290: Rename XSLT_Handler <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9ae9e5aade44c508e2fa0ed0fdc22f4db636ae50>
13:45 huginn News from kohagit: Bug 23290: Introduce Koha::XSLT::Security <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=269c0bf2174afbee272aaf9b74571a4c04641bbf>
13:45 huginn News from kohagit: Bug 23290: Apply the changes in Security to Base now <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7baa8d349c40d444f917396e5762165b358a26b9>
13:45 huginn News from kohagit: Bug 23290: Allow enabling expand_entities <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f6bb3eb4787ce2208347b3b066392ee1bf2432cf>
13:45 huginn News from kohagit: Bug 23290: Add test Koha/XSLT/Security.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=801693096c6024099c5fb251d56fcf36509127e5>
13:45 huginn News from kohagit: Bug 23290: Add test for write_net <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=404fbeee729f624c1b3b7d2bfb02f9d538e4319f>
13:45 huginn News from kohagit: Bug 23290: (follow-up) Replace warning_like by warnings_like <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=306ed2fb6f49b79139a346c70f253509af29c7af>
13:45 huginn News from kohagit: Bug 23290: (follow-up) Disable expand_entities unless explicitly enabled <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a69df1fe611ebc3d77692bc3d1c1c52ec6d79a90>
13:45 huginn News from kohagit: Bug 23290: (QA follow-up) Rename option to expand_entities_unsafe <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a01e5132c15d4a7241a9926b326566248367881f>
13:45 huginn News from kohagit: Bug 22522: Add support for current Mojolicious and related packages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7a4dc6c8ed1d21343fc101366e1d299bcd92fb45>
13:45 huginn News from kohagit: Bug 22522: Fix route typo <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2061132e457b85f780a5b77f5272db6b707ad7ea>
13:45 huginn News from kohagit: Bug 22522: Fix several REST API tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d7407055a891e723c7840739ff277b699668a56d>
13:31 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Koha::Library needs a method for obtaining the inbound email address
13:31 ashimema[m] bug 22823
13:30 ashimema[m] soooo many places pass from_address needlessly :(
13:30 ashimema[m] grr..
13:28 ere or "delimiter" in https://www.loc.gov/marc/specifications/specrecstruc.html
13:27 ere magnuse: That's the field start character in ISO2709, so I wouldn't be surprised if it caused trouble.
13:21 magnuse anyone else seen Koha misbehave because of this unicode char in field 009? "U+001F : <control-001F> (INFORMATION SEPARATOR ONE) {unit separator (US)}"
12:44 koha-jenkins Project Koha_Master_D9 build #1173: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1173/
12:32 * oleonard should take more days off
12:32 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 enhancement, P5 - low, ---, oleonard, Pushed to master , Convert opacheader system preference to news block
12:32 oleonard Oh dang, Bug 22880 was pushed while I was out for a day!
12:30 koha-jenkins Project Koha_Master_D9_My8 build #173: FIXED in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/173/
12:30 koha-jenkins Yippee, build fixed!
12:28 koha-jenkins Project Koha_Master_D8 build #714: UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D8/714/
12:24 oleonard Hi #koha
12:09 koha-jenkins Project Koha_Master_U18 build #636: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_U18/636/
11:54 koha-jenkins Project Koha_Master_D9_MDB_Latest build #149: SUCCESS in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/149/
11:34 koha-jenkins Project Koha_Master_D9 build #1172: FIXED in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1172/
11:34 koha-jenkins Yippee, build fixed!
11:32 koha-jenkins Project Koha_Master_D8 build #713: FIXED in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D8/713/
11:32 koha-jenkins Yippee, build fixed!
11:08 huginn News from kohagit: Bug 23777: (follow-up) Use To.json in results.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=884ab0d98e54d3a9f5229e2d21fd234dddf298b0>
11:06 * ashimema[m] hopes cait will find the time to test the set of trivials I'm adding for her at the moment regards emails
10:53 mtj ...'file ./core' seemed to think it was a perl executable, (i deleted the file already :/ )
10:52 mtj np, i can do
10:52 Joubu Or I can do it, if you want me to
10:51 Joubu mtj: could you add it to all master jobs?
10:51 Joubu well, failing, but not on this test
10:51 Joubu mtj: D9 was passing prior to your change I think :)
10:48 mtj 00:00:02.838 Removing docker-compose.mariadb_latest.yml
10:48 mtj 00:00:02.838 Removing core
10:48 mtj 00:00:02.838 Removing 1.png
10:48 mtj 00:00:02.757 + git clean -f
10:48 ashimema[m] teamwork++
10:48 mtj https://jenkins.koha-community.org/job/Koha_Master_D9/1172/console
10:48 mtj i experimented here.. it seems to work ok..
10:47 Joubu we could indeed do that
10:47 mtj ..the build needs to run a 'git clean -f' before it starts, it remove any files from the previous job
10:47 Joubu The next question is: can you remove it? :)
10:46 Joubu mtj: what is its content?
10:45 mtj hi Joubu, i think the core file comes from a crashed ./perl
10:43 koha-jenkins Project Koha_Master_D9 build #1171: ABORTED in 8 min 23 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/1171/
10:34 koha-jenkins Project Koha_Master_D9 build #1170: ABORTED in 13 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1170/
10:21 koha-jenkins Project Koha_Master_D9 build #1169: ABORTED in 4 min 37 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/1169/
10:01 cait hidelostitems
10:01 cait tying to determin if it leaves holes in the result list or not
10:01 cait hm does someone know if the 'don't show lost items in OPAC' feature uses Zebra is is moe similar to opachiddenitems?
09:53 huginn Joubu: The operation succeeded.
09:53 Joubu @later tell mtj we have something weird happening on Docker_1 and Docker_3, a new test xt/find-license-problems is failing on a "./core" file that is at the root of the Koha src (but not in our git repo). Any ideas where does it come from?
09:53 ashimema[m] especially peoples personal addresses.
09:53 ashimema[m] It's just plain bad practice to mascarade as someone else in my opinion
09:52 cait but yeah, it gets increasingly difficult and you will probably not now why it didn't work or not notice
09:52 cait ashimema[m]: it used to work... will stell with more permissive mail servers
09:49 Joubu mtj[m]: are you around?
09:45 ashimema[m] that's never going to work.. pretending to be a patron sending mails..
09:45 ashimema[m] my biggest complaint is we currenty sometimes pass in patron email address as the from_address..
09:45 ashimema[m] and work at it from that direction.. then once we're knee deep in the work we can make a more informed decision as to whether we actually need to ever pass in from_address or not ;)
09:44 ashimema[m] that's why I decided to add the reply_address field ;)
09:43 cait well they usually are if reply to is in use
09:43 cait and both could be set differently
09:43 cait also - don't we need both in the emails?
09:43 ashimema[m] I'll forge ahead
09:43 ashimema[m] no worries
09:43 cait are we differentiating between libraries to patrons/external people and to the library there?
09:43 cait not sure my brain is up to it right now, deep into migrations things
09:42 cait hm
09:40 ashimema[m] sound like a plan cait?
09:40 ashimema[m] so I decided to add a reply_address into the message_queue table and we can work through one place at a time moving to using that field instead and then finally deprecate and remove passing in from_address directly.
09:39 ashimema[m] but then I looked at how after from_address is passed as that route scared me..
09:38 ashimema[m] The simplest approach i thought about was to simply never use the passed from_address as the from_address.. rather using as the reply_to address instead.. and let the branch handling code that already exists pull the from_address
09:28 cait yep
09:28 ashimema[m] those are the culprits
09:28 ashimema[m] I'll just grep through 'from_address' and 'to_address'
09:27 ashimema[m] all good..
09:27 cait there is a new one for suggestions to be sent to the library i think
09:27 cait but it's 18.11 so misisng new ones maybe
09:27 cait checking my branch
09:27 ashimema[m] I know exactly what you mean.. I just need help finding all the cases ;)
09:27 cait holeplaced and overdues for patrons with no emails come to mind
09:27 ashimema[m] bug 22823 introduced a method in Koha::Library to do the right thing.
09:27 ashimema[m] but I only found two cases so far...
09:27 ashimema[m] yeah.. I'm trying to catch those cait..
09:27 cait because of the whole 'email must be in the domain of mailserver thing'
09:26 ashimema[m] morning eythian
09:26 cait branchemail in our setup is a noreply, and replyto is the actual address of the library
09:26 ashimema[m] have you reported more similar bugs to the above two.. I've not found them but would be happy to help move them along if you wanted to build a bit of a tree to help me keep track of them all
09:26 cait ashimema[m]: there are emails to the branh library address (branchemail) that won't work for us
09:26 eythian hi
09:25 ashimema[m] not entirely sure what you mean by you ahve a patch for reply-to...
09:25 ashimema[m] I'm working on the second bug at the moment
09:25 ashimema[m] I think we can start.. so long as it's baby steps ;)
09:24 cait so it's too late already? ;)
09:23 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 normal, P5 - low, ---, martin.renvoize, NEW , Patron notes about item email notification fallback order is incorrect
09:23 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Koha::Library needs a method for obtaining the incoming email address
09:23 ashimema[m] see bug 22823 and bug 22821 cait
09:19 cait but maybe we shoud not start yet another clean-up project now :)
09:17 cait HOLDPLACED for example
09:17 cait as they sent to branchemail... which is a noreply one in our setting
09:17 cait i have to patch them all to reply-to-address
09:16 cait I am more worried ab ut the emails sent to the library
09:16 cait some emails cannot be sent from a branh
09:16 cait we could have a variable branch or global instead
09:13 ashimema[m] right now it's easy to introduce issues
09:13 ashimema[m] then use one and only one piece of code to do the fallback through branchemail, kohaadminemail that happens so often
09:12 * ashimema[m] sort of wants to take out the ability to add from_address at the EnqueueLetter stage..
09:11 cait ashimema[m]: after we fundet work it was supposed to be consistent... apart from emails that go to the library
09:10 cait fridolin++ :)
09:10 davidnind fridolin++
09:09 ashimema[m] haha.. tell me about it mate ;)
09:03 fridolin ashimema[m]: yes it is, 2 children is a lot of fun but also a lot of work ;)
09:00 ashimema[m] hi fridolin.. hope all is going well for you :)
08:59 ashimema[m] wow we're inconsistent with from addresses for emails :(
08:53 Joubu thanks kohaputti
08:51 kohaputti Joubu, great job fixing the circulation rule perf issue! :)
07:39 magnuse bonjour reiveune et #koha
07:39 reiveune hello
06:20 fridolin works very well
06:19 * fridolin actually at Madagascar with Orange 4G internet
06:19 fridolin i start my coming back ;)
06:19 fridolin hi there