Time Nick Message 22:18 cait good night all 22:18 cait hm, no late mailing list writing... i just invented a new name... 19:35 cait oops 19:26 kidclamp it did :-) 19:16 cait oh, we recently changed the button - (add to basket) - I tested, hope I didn't break things 18:28 * kidclamp goes to git blame oleonard 18:28 kidclamp heh 18:28 * oleonard hides 18:28 oleonard Yeah kidclamp same. Only with the single "add to basket" button, not with the split button. 18:27 caroline_catlady I see the modal 18:27 kidclamp clicking 'add to basket' nothing is happening for me - no error, but no modal 18:27 caroline_catlady oh sorry, add TO an empty basket... I read add an empty basket 18:26 oleonard kidclamp: Using which method? 18:25 caroline_catlady I shouldn't? 18:25 caroline_catlady yes 18:25 kidclamp you=anyone :-) 18:24 kidclamp on master 18:24 kidclamp can you add to an empty basket from booksellers.pl ? 16:45 oleonard I don't think it lasted long 16:45 ashimema I hadn't spotted it was out 16:45 ashimema oh.. i see 16:44 oleonard ashimema: gmcharlt keeping us up to date on the wiki outage 16:43 ashimema what did I miss? 16:42 oleonard ;) 16:42 oleonard gmcharlt++ 16:39 oleonard gmcharlt_++ 16:36 cait i'll probably forget 16:36 wizzyrea :thumbsup: 16:36 cait beter send me an email :) 16:33 huginn ashimema: The operation succeeded. 16:33 ashimema @later tell cait could you look at my final comment on bug 23260 and let me know if you agree with my plan of action there 16:29 caroline_catlady hello everyone! 16:25 reiveune bye 16:25 ashimema cait around? 16:25 ashimema agreed :) 16:24 Joubu The good thing is that we anticipated the new MariaDB and MySQL versions, so we should be safe on that side. 16:21 ashimema I really really want to say we support buster asap 16:21 ashimema no worries.. hopefully it'll all be in hand vrey shortly.. 16:20 wizzyrea thanks ashimema 16:20 Joubu just saying.. 16:20 Joubu did: this code is quite dirty, you should not use it as an example. 16:18 did Joubu: ok I have to change Check_page1, I was hoping for some kind of magic :) 16:17 oleonard did: Without looking at the code I'm guessing you'll need to define a custom event to trigger validation of the first set of fields 16:16 did oleonard: adding 'class="required" required="required"' attributed doesn't work, in my understanding because it's a two panels form, ,next buton isn't a 'form put' and in the second pane fields from the first pane are ignored because they are hidden . 16:15 * ashimema hopes tcohen might find a moment to QA that one.. and I'll get poking mtj again for the packaging side of it.. which I've lost track of again 16:15 JesseM Hi all 16:14 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 is not accessible. 16:14 ashimema bug 22522 is the major one 16:14 wizzyrea ty for the intel 16:13 wizzyrea naw 16:13 ashimema it's an annoyance. 16:13 * ashimema hopes he didn't sound too harsh there.. 16:13 ashimema but yeah.. I'm betting there are bugs we've not spotted yet as we're not running the test suit against it yet 16:13 wizzyrea the bugs for this are in the tracker? 16:13 wizzyrea hmm yeah no 16:13 ashimema the most serious bug is a security bug with Mojolicious versions wizzyrea.. if you've got the rest api disabled you're probably mostly safe 16:12 ashimema I've been pestering people to help get that situation remidied.. mtj has been busting a gut on the packaging side for me. 16:12 ashimema so it's entirely not tested right now ;) 16:12 ashimema those all lead to an inability to run it against the test suit 16:12 Joubu did: If you are looking for the jQuery validation plugin, see oleonard link. If you are looking for an example about our own subscription-add.tt view, see the bug I posted. 16:12 ashimema packaging issues 16:11 ashimema security issues caused by dependancies 16:11 ashimema dependancies 16:11 wizzyrea ok are there bugs 16:11 ashimema lots 16:11 wahanui the issue is too... thi swould have been better as several bugs 16:11 wizzyrea what's the issue? 16:11 ashimema Buster is not yet supported wizzyrea 16:10 wizzyrea hi, has anyone had any problems with Buster? 16:10 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 major, P5 - low, ---, jonathan.druart, Pushed to oldstable , Problems when linking a subscription to a non-existing biblionumber 16:10 Joubu did: have a look at the patch from bug 21232 16:09 oleonard did: Have you seen the documentation for the jQuery validation plugin we use? https://jqueryvalidation.org/ 16:08 did Joubu: If I want to validate required fields in the first panel before moving to the second panel 16:07 ashimema I'll post a followup in the moment with a comment as to what we're expecting in the test 16:06 Joubu ashimema: let me double check 16:06 ashimema this comes back to spec to me.. we need clarification on exactly what should be anonymised.. i would say 'items_last_borrower' and 'checkouts' anonymization should really match 16:06 Joubu ashimema: let me dou 16:06 did Joubu: when more than one panel in one form. ie serials/subscription-add.tt 16:06 Joubu did: I am not sure what you are talking about, can you be more specific? 16:06 ashimema talljoy around? 16:04 did Joubu: looking for guidance with jquery form best practices in koha. 16:04 ashimema i.e. the return value is the number of 'issues' deleted.. we ignore the 'items_last_borrowers' rows 16:03 ashimema the number you updated was wrong then.. should be '4' 16:03 did Joubu: hi 16:03 ashimema ohh.. 16:01 Joubu kohaputti: yes sure 16:01 Joubu + "itemnumber.withdrawn" => 0, 16:01 Joubu + "itemnumber.itemlost" => 0, 16:01 Joubu + "itemnumber.damaged" => 0, 16:01 Joubu + $patron->_result->items_last_borrowers->search( 16:01 kohaputti just commented on the bug 16:01 kohaputti Joubu, can you add my signed-off-by to the commits? 16:01 Joubu ashimema: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98044 16:01 kohaputti :) 16:00 Joubu kohaputti: a pastis then, or whatever you would like! 16:00 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 enhancement, P5 - low, ---, agustinmoyano, Failed QA , Anonymize (remove) patron data from items_last_borrower 16:00 ashimema this is regarding the failing test on bug 23260 16:00 * kohaputti don't drink beer 16:00 ashimema Joubu.. am i going mad.. i don't see any code anywhere that strips out withdrawn, lost and damanged items from the anonymise selection .. 15:59 ashimema nice work guys! 15:58 ashimema :) 15:57 Joubu kohaputti: I owe you (at least) one beer, in Marseille ;) 15:57 cait kohaputti++ 15:56 kohaputti I guess it is Passed QA time!! :) 15:56 kohaputti ok, if you think so I couldn't find anything else related by quickly checking (thought there is a huge list of warnings related to other things) 15:55 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 normal, P5 - low, ---, jonathan.druart, RESOLVED FIXED, use strict for all modules 15:55 Joubu I think they are more related to bug 24217, we turned "strict" on for that module recently. 15:53 kohaputti they are related to circulation rules but I'm not sure if they were there before 15:53 kohaputti Use of uninitialized value in numeric eq (==) at /home/koha/kohaclone/C4/Overdues.pm line 271. 15:53 Joubu kohaputti: if they are new warnings they should be fixed 15:52 kohaputti Use of uninitialized value in numeric gt (>) at /home/koha/kohaclone/C4/Circulation.pm line 2297. 15:51 wizzyrea that users can do themselves. Like koha-email-enable but in the interface 15:50 kohaputti just a sec and I will give examples 15:50 kohaputti when I run the tests there is bunch 15:50 wizzyrea my kingdom for the ability to set a flag in the DB for "yes send mail" and "no don't send mail" 15:50 Joubu which ones? 15:49 kohaputti ashimema, Joubu what's your take on the warnings? 15:49 kohaputti I would really like to give this already a passed qa but one thing I noticed is that there is bunch of warnings now because we are doing string comparisons on undef rules 15:48 kohaputti Joubu, ok, all tests are then good. I also would be okay with the current onboarding script since it is just defaults that the user is supposed to change anyways. 15:46 Joubu kohaputti: ^ they all pass (now). I've just pushed another follow-up for holds.t 15:45 pastebot Someone at 127.0.0.1 pasted "api tests with 18936" (42 lines) at http://paste.koha-community.org/18814 15:43 kohaputti Joubu, thank you! if the tests pass then I think we are only left with checking the onboarding script 15:42 Joubu I am running the api tests 15:42 Joubu kohaputti: cherry-picked and pushed 15:40 kohaputti Joubu, there is one test fix waiting for you to cherry-pick. However, I'm not able to run all the REST API endpoint tests due to the authentication bug so I don't know if any of those test are failing because of this refactoring. 15:18 kohaputti it is not super critical since it is just the defaults that the user can change 15:18 Joubu I got caught by something else 15:17 Joubu nope 15:17 kohaputti Joubu, did you check the onboarding script? 15:17 kohaputti aah, now I see. Maybe it was my browser cache or I forgot to refresh the repo 15:17 Joubu I force pushed 15:16 kohaputti I don't see any changes 15:16 kohaputti Joubu, hmm, which branch / remote? 15:15 Joubu kohaputti: I have adjusted the misc4dev data this morning 14:48 koha-jenkins Project Koha_Master_D9_My8 build #128: NOW UNSTABLE in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/128/ 14:46 koha-jenkins Project Koha_Master_U18 build #589: NOW UNSTABLE in 55 min: https://jenkins.koha-community.org/job/Koha_Master_U18/589/ 14:41 koha-jenkins Project Koha_19.05_D9 build #107: FIXED in 48 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/107/ 14:41 wahanui Congratulations! 14:41 koha-jenkins Yippee, build fixed! 14:40 ashimema just spitballing ;) 14:40 ashimema I'm happy with it 14:40 ashimema indeed 14:39 Joubu if you write "Bug4242-sutff", it won't work, indeed :) 14:39 Joubu the substitution part should deal with most of the cases 14:38 ashimema the only issue I could see with your update is catching a case where the bug xxxx is malformed 14:37 Joubu what this PR suggests :) 14:37 Joubu or nothing at all and assuming that we want the X last commits matching Bug XXXXX 14:37 ashimema I like the option of a number 14:37 cait i like the number bit :) 14:36 Joubu ashimema: yes but it seems easier to provide a number :) 14:35 oleonard Hi rhamby, sallyf 14:33 ashimema I've also wondered at times if we could teach the qa tools standard git synax for ranges 14:33 ashimema not a bad idea Joubu 14:32 koha-jenkins Project Koha_19.11_U18 build #40: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/40/ 14:31 Joubu tcohen, ashimema, kidclamp, others: what about this change? https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/15 13:43 * oleonard brb 13:43 koha-jenkins Project Koha_19.11_D8 build #43: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_19.11_D8/43/ 13:43 wahanui Congratulations! 13:43 koha-jenkins Yippee, build fixed! 13:42 ashimema :D 13:41 koha-jenkins Project Koha_19.11_D9 build #42: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_19.11_D9/42/ 13:29 koha-jenkins Project Koha_19.11_U18 build #39: STILL UNSTABLE in 58 min: https://jenkins.koha-community.org/job/Koha_19.11_U18/39/ 13:27 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 normal, P5 - low, ---, jonathan.druart, Signed Off , Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value 13:27 ashimema anyone around to QA Joubu's followup on bug 21466? 13:10 magnuse ooh, a signoff-bot! 13:09 AnnaBoten Error: "I" is not a valid command. 13:09 oleonard AnnaBoten: I shan't play your game until you sign off on at least one (1) patch 13:08 wahanui *click* 13:08 AnnaBoten \_o< quack! 13:07 koha-jenkins Project Koha_19.05_D9 build #106: NOW UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/106/ 13:04 koha-jenkins Project Koha_19.05_D8 build #107: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/107/ 13:02 AnnaBoten kidclamp took the lead for the week over oleonard with 63 points. 13:02 AnnaBoten oleonard took the lead for the week over kidclamp with 19 points. 13:02 AnnaBoten Best time: tcohen with 287.30 seconds 13:02 AnnaBoten [('tcohen', 2), ('kidclamp', 1)] 13:02 AnnaBoten \_x< tcohen: 2 (1400.18 seconds) 13:02 tcohen !bang 12:39 koha-jenkins Project Koha_Master_U18 build #588: FAILURE in 1 min 8 sec: https://jenkins.koha-community.org/job/Koha_Master_U18/588/ 12:39 wahanui oops, slipped over 12:39 AnnaBoten \_o< quack! 12:38 koha-jenkins Project Koha_Master_D9_My8 build #127: FAILURE in 8 min 29 sec: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/127/ 12:38 tcohen Joubu++ # follow-up 12:38 AnnaBoten \_x< tcohen: 1 (287.30 seconds) 12:38 tcohen !bang 12:33 wahanui !bang 12:33 AnnaBoten \_o< quack! 12:31 oleonard Hi all 12:28 kidclamp morning 12:28 AnnaBoten \_x< kidclamp: 1 (50075.49 seconds) 12:28 kidclamp !bang 12:27 koha-jenkins Project Koha_Master_D9 build #1118: FIXED in 52 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1118/ 12:27 wahanui Congratulations! 12:27 koha-jenkins Yippee, build fixed! 12:02 koha-jenkins Project Koha_Master_D8 build #661: NOW UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D8/661/ 11:44 ashimema yeah.. sorry I couldnt' remember 11:44 wahanui translations are high on the agenda but no-one has stepped forward to fund them and the code was significantly more complex to add at the time of original submission 11:44 ashimema oh, translations 11:43 ashimema ? 11:43 magnuse cait++ ashimema++ for trying 11:41 koha-jenkins Project Koha_Master_D9_MDB_Latest build #105: STILL UNSTABLE in 53 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/105/ 11:23 koha-jenkins Project Koha_Master_D8 build #660: STILL FAILING in 18 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/660/ 11:18 koha-jenkins Project Koha_Master_D8 build #659: STILL FAILING in 17 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/659/ 11:17 koha-jenkins Project Koha_Master_D8 build #658: FAILURE in 19 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/658/ 10:59 ashimema it vaguely rings a bell but I can't remember the bug I'm afraid 10:58 cait we broke the transltaion scripts soemwhat recently 10:58 cait ashimema: do you remember? 10:57 cait hm acually that's too old 10:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21895 blocker, P5 - low, ---, julian.maurice, CLOSED FIXED, Translations fail on upgrade to 18.11.00 (package installation) 10:57 cait magnuse: i think i was thinking of bug 21895 10:46 koha-jenkins Project Koha_19.11_D8 build #42: ABORTED in 40 sec: https://jenkins.koha-community.org/job/Koha_19.11_D8/42/ 10:46 koha-jenkins Project Koha_19.05_U18 build #108: ABORTED in 23 sec: https://jenkins.koha-community.org/job/Koha_19.05_U18/108/ 10:46 koha-jenkins Project Koha_Master_D9_My8 build #126: ABORTED in 15 sec: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/126/ 10:46 koha-jenkins Project Koha_Master_U18 build #587: ABORTED in 13 min: https://jenkins.koha-community.org/job/Koha_Master_U18/587/ 10:46 koha-jenkins Project Koha_19.11_D9 build #41: ABORTED in 12 sec: https://jenkins.koha-community.org/job/Koha_19.11_D9/41/ 10:46 koha-jenkins Project Koha_Master_D9 build #1117: ABORTED in 14 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1117/ 10:45 koha-jenkins Project Koha_19.05_D8 build #106: ABORTED in 14 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/106/ 10:45 koha-jenkins Project Koha_19.11_U18 build #38: ABORTED in 5 min 10 sec: https://jenkins.koha-community.org/job/Koha_19.11_U18/38/ 10:40 koha-jenkins Project Koha_19.05_D9 build #105: FAILURE in 8 min 23 sec: https://jenkins.koha-community.org/job/Koha_19.05_D9/105/ 10:22 tcohen morning 10:14 magnuse it looks like the koha upgrade upgraded the templates/installed the translation, but running koha-translate later gives the error 10:12 cait fixed too, but maybe a side effect? 10:11 cait i seem to remember a bug that broke the translation script... recently 10:08 magnuse gotta get some lunch, though 10:08 magnuse yup 10:06 ashimema weird 10:02 magnuse a swedish librari is reporting that after upgrading from 19.05 to 19.11, running "sudo koha-translate --install sv-SE" gives "unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 245". i can't for the life of me see why koha-translate would trigger that error from C4::Context. Anyone got any clues? 09:47 huginn ashimema: The operation succeeded. 09:47 ashimema @later tell mtj I can see you added libarray-utils-perl to the community repo, but for some reason it's still not getting installed.. wondering if I've missed something somewhere regarding how these things get triggered at install? 09:46 cait ashimema: thx! 09:33 ashimema cait.. i added the discussed 'cookie' keyword to bugzilla 09:31 ashimema not a bad idea 09:25 cait ? :) 09:25 cait a section: read before update 09:25 cait thx for signing off - davidnind++ 09:06 davidnind cait: thanks for fixing, signed-off properly now! 09:01 ashimema It's a hard call... I don't have the spare tuits to work on it further myself 09:00 ashimema Yeah.. it's a pain.. we can't always rely on people reading release notes before they upgrade 09:00 marcelr s 09:00 marcelr if only they read it ;) yes we should add release note 08:58 cait and we could provide an sql report or script to find these cases before updating 08:58 cait ashimema: pointed out that people always shoudl do a backup before updating... 08:58 cait one other idea i had was putting it in the release notes 08:57 cait yeah we just discussed this 08:56 marcelr ashimema tested 4 production dbs, so it may not be likely but you never know 08:56 marcelr cait: 21901 is about broken links to subscriptions or biblios, theoretically present 08:38 cait good morning ashimema and #koha 08:35 ashimema morning #koha 07:43 wahanui que tal, reiveune 07:43 reiveune hello 07:41 marcelr hi #koha 07:40 alex_a Bonjour