Time Nick Message 06:45 marcelr hi #koha 06:56 reiveune hello 06:56 wahanui bonjour, reiveune 07:00 kohaputti ashimema, in case you are not already aware: the database upgrade from Bug 22445 seems to be incorrect (I just added a comment on the bug report with the error log) 07:00 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 new feature, P5 - low, ---, jonathan.druart, Pushed to master , Ability to define a URL for custom cover images 07:01 kohaputti s/incorrect/"explodes"/ :D 07:10 ashimema Grr, that's yet another dB version we're not testing against 07:10 ashimema I'll add it to the list and take a look this morning 07:35 * magnuse waves 07:35 marcelr hi magnuse 07:35 kohaputti ashimema, I misread the error, it seems to be actually from another bug, Bug 23049 07:35 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 enhancement, P5 - low, ---, martin.renvoize, Pushed to master , Replace MANUAL_INV authorised value with a dedicated table 07:37 marcelr mysql 5.7 not tested too ? 07:41 magnuse hiya marcelr 07:53 ashimema Until a couple of weeks ago only 5.5 was tested at all.. no Maria and no varying versions 07:54 ashimema I don't think we actually have a test than runs through upgrades either to be honest. 07:57 marcelr its becoming a problem 07:57 ashimema indeed 07:58 ashimema think I'm going to spend some of this morning attempting to write a test for updatedatabase 07:58 alex_a Bonjour 07:58 marcelr hi alex_a 07:58 ashimema and add test runs against 5.6 and 5.7 to jenkins 07:58 marcelr ashimema++ 07:58 ashimema whilst I'm at it, perhaps it's also time to bite the bullet and test 10.2, and 10.4 too 07:59 alex_a hello marcelr 07:59 alex_a hello ashimema 07:59 marcelr ashimema: im running 10.4 in production 07:59 ashimema morning alex_a 07:59 ashimema mysql8 fails an absolutely huge number of tests at the moment :( 07:59 ashimema https://jenkins.koha-community.org/ 08:00 marcelr i guess we should be moving mysql to maria 08:00 marcelr just like our debian 08:00 ashimema 540 failures! 08:00 ashimema https://jenkins.koha-community.org/job/Koha_Master_D9_My8/ 08:00 marcelr huge 08:01 ashimema well the debian 10 one is a packaging issue mostly 08:01 ashimema I think once we've done that d10 should be a bit better.. though I do suspect a few things to fix 08:01 ashimema not in the least the api's 08:01 marcelr its crashing at the start already often 08:02 ashimema yeah.. but that's because we're trying to install a D8 package on D10.. we don't have a D10 package yet 08:02 ashimema so.. all our dependancies are out of whack 08:02 marcelr yeah it makes no sense now 08:03 ashimema I also learnt yesterday that there is no mechanism in Koha as yet to pin a dependancy.. so if you're not doing speial measures outside of normal operation you will be running with whatever the latest version of a module is in your distro (or whatever you've grabbed from cpan)... that's a terrible idea when it comes to really fast moving projects like mojo and openapi that regularly add breaking changes. 08:08 ashimema fix pushed kohaputti 08:08 huginn News from kohagit: Bug 23049: (RM follow-up) remove 'IGNORE' from ALTER TABLE <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1a8de78c20ef05d7b11c5d97724643bc98c4354e> 08:12 ashimema I have no idea how to go about writing a test for updatedatabase.pl 08:12 ashimema the more i think about it the harder it seems 08:12 marcelr ashimema: times comes to refactor that script 08:12 marcelr its just way too long 08:12 marcelr we tried it already a few times 08:12 ashimema it is indeed far too long 08:12 marcelr but every time we ended up keeping it 08:13 * ashimema liked DBIx::Class::DeploymentHandler in a project he wrote a while back.. but it uses Moose :( 08:13 marcelr yeah we should go to deploy too ;) 08:14 marcelr we have a lot of unfinished projects in our codebase 08:14 ashimema the atomicupdate stuff is fairly nice.. we could probably adapt that someone to work through files in a certain order.. meaning at the very least that each update gets a small self contained file instead of a chunk in updatedatabase. 08:15 marcelr script per release or so 08:15 ashimema I don't think we should use DeploymentHandler in koha.. as much as I like it.. it's too heavy for Koha as is.. 08:15 ashimema but we could be inspired by the structure of the updates it creates.. 08:15 ashimema I also like that it's can be used to write your updates for you :) 08:16 marcelr you're close to writing a patch :) 08:16 ashimema I used to write my DB changes into the dbic classes.. then run a dh script and it spat out sql agnostic upgrade, downgrade and deploy scripts for me :) 08:17 ashimema I still had to be a little careful and test them but in general it "just worked" :) 08:18 ashimema we already have sql fairy as a dependancy and that does all the really heavy lifting 08:19 marcelr well we need some more agnostic upgrading at least 08:20 marcelr the fix should be on the other report ? 08:20 ashimema probably 08:20 wahanui i guess probably is too hard. 08:20 * ashimema needs more coffee 08:20 marcelr too long on the qa team 08:20 ashimema haha. 08:20 ashimema we need more qaers like you :) 08:21 marcelr hmm i want my patches in 08:21 ashimema how do you try to promote them? 08:21 marcelr i actually dont and that is the problem 08:22 ashimema I've not really seen many of yours coming through.. actually wasn't aware you had any/many in the queue? 08:22 marcelr i wrote very little lately because the process is annoying 08:22 marcelr begging until a signoff etc 08:22 ashimema yeah.. let cait and I know of any that feel stalled or that you're excited about.. we can give them a little nudge.. I really like her weekly emails for that 08:23 ashimema mmm, I am trying to improve that 08:23 ashimema but this last cycle was especially bad.. as hard as I tried I got vrey little back.. 08:23 marcelr my list of things to rebase at upgrade time is growing since i didnt submit them anymore 08:23 ashimema I think the big players were all hugely busy :( 08:24 * ashimema would like to see biblibre doing more so and qa again 08:24 marcelr yeah 08:24 ashimema the dashboard stats are worrying :( 08:24 ashimema the same 4 or 5 individuals are at the top of every list :( 08:25 ashimema it's lovely to see we have a few key core people keen and continuing.. but it doesn't make for great prospects :( 08:25 marcelr no the group is too small 08:26 ashimema and when one of them has to drop off for a while due to other commitments.. we really really notice it.. (Joubu absent last cycle was huge) 08:26 marcelr too much supporting companies.. do no community work 08:26 marcelr forgot the quotes 08:26 ashimema the other thing I'd really like to see is the rations of patches submitted to signoffs done improved for a few people 08:27 marcelr 50-50 ! 08:27 ashimema Rijks Museum - 24:125 08:28 marcelr these figures are old 08:28 Joubu I always say that but, 1 patch != 1 patch 08:28 marcelr dashboard does not refresh them or so 08:28 Joubu if you are asking that, people will focus on easy SO 08:28 ashimema they're over the 19.11 cycle 08:28 marcelr or no dashboard Joubu ? 08:29 ashimema easy SO is better than No SO ;) 08:29 ashimema it's a start Joubu 😉 ? 08:29 marcelr imo many SO are too easy SO's 08:29 ashimema then perhaps we could add a weighting in later to encourage people to bite off the harder ones 08:29 Joubu do not focus on numbers :) 08:29 ashimema I know I always tried to do a mix when I was doing more QA 08:30 ashimema PTFS-Europe 340:1344 08:30 marcelr yeah RM signoff 08:31 ashimema if we don't focus on number Joubu how do we spot bad patturns ;) 08:31 marcelr the ratio will give you at least an idea 08:33 ashimema SO counts SO and QA doesn't it in that context Joubu..? 08:33 * ashimema should just look at the code. 08:36 Joubu marcelr: yes, 1 SO == 1 SO by line. It's different from the number of bugs you signed off 08:36 Joubu 1 Signed-off-by line* 08:36 ashimema so in reality.. as our process requires submission + signoff + qa.. then the ratios should generally be aiming for 1:2 08:37 ashimema that way devs would be testing and qaing as much as they're writing and thus be able to expect the same back (to some level) 08:38 ashimema I've found the easiest way to get things moving is to partner up with people for the process.. but that has it's own problems of introducing biases we're trying to avoid 08:39 marcelr there is always discussion about this, but never a solution imo 08:39 * ashimema also thinks we support too many versions and as such spread ourselves a little thin.. it's getting harder and harder to find rmaints 08:40 marcelr the "big three" should give us three RMaints 08:40 marcelr not saying who are these big three ;) 08:41 marcelr well at least bywater already did 08:42 ashimema we are "big" I assume.. but we actually only have 3 devs 08:42 marcelr lol 08:42 marcelr you are very big, since you gave us a continuing RM ! 08:42 ashimema and I'm actually also the team manager so not really full time on dev 08:43 marcelr but the 19.11 RMaint is the most important 08:43 marcelr now 08:44 ashimema mmm. stable rmaint tends to set a precident and take the lead for the others.. 08:45 ashimema I felt stable RMaint was in many ways harder than being RM and also more important.. the code you're releasing each month gets into peoples hands much quicker 08:45 marcelr yeah i agree, a bad stable RMaint can blow up things 08:45 ashimema I'm worried for next cycle :( 08:46 koha-jenkins Project Koha_Master_D9 build #994: UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9/994/ 08:46 marcelr Joubu: do you want to comment the TLS stuff on bug 22587 ? 08:46 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22587 enhancement, P5 - low, ---, koha-bugs, RESOLVED DUPLICATE, Test 08:46 marcelr oops bug 22857 08:46 ashimema I've not got anyone in mind to approach to do it.. I keep trying to think of someone but failing.. it's another case of pulling from the same small pool of people.. pulling someone in to rmaint duties means they'll have less time for qa duties.. 08:46 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 major, P5 - low, ---, jonathan.druart, BLOCKED , Entries missing in koha-conf.xml 08:47 marcelr same problem ashimema 08:47 marcelr like above 08:48 marcelr maybe move a bywater qaer to rmaint ? 08:48 marcelr get someone from new zealand in rmaint again ? 08:49 Joubu marcelr: so we should remove the TLS things from the conf, that's it? 08:49 marcelr add them in comments i mean ? 08:49 marcelr no blocker 08:50 ashimema I like them being there.. but perhaps commented by default? 08:50 marcelr it should work uncommented too, but is just ugly 08:50 ashimema I don't understand that code well enough though to be honest 08:50 koha-jenkins Project Koha_Master_U18 build #463: STILL UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/463/ 08:50 ashimema cool.. 08:50 marcelr my preference it also to comment them 08:51 ashimema grr.. those two tests are a pain.. they fail at random I believe and I've not gotten to the bottom of why yet 08:51 ashimema any thoughts on why AdditionalFields would come back in a different order on U18 Joubu? 08:52 ashimema the db query doesn't explicitly set an order... but I would it's the same DB backend in both D9 and U18.. so why it only fails on U18 is anyone's guess 08:52 koha-jenkins Project Koha_Master_D8 build #525: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D8/525/ 08:52 Joubu does it only fai on U18? 08:53 Joubu fail 08:53 ashimema yup 08:53 ashimema well.. at least so far 08:55 Joubu we should not need to specify the order, results should be returned depending on their order in DB 08:55 ashimema exactly 08:57 koha-jenkins Project Koha_Master_D10 build #87: STILL FAILING in 6 min 58 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/87/ 09:01 ashimema it's a very odd failure.. pretty consistent though that one.. always fails on U18 at the momet 09:13 koha-jenkins Project Koha_Master_D9_My8 build #6: STILL UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/6/ 09:23 eythian hi 09:23 wahanui bidet, eythian 09:24 magnuse kia ora eythian 09:33 huginn News from kohagit: Bug 23994: Fix random failure from AdditionalFields.t (U18) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f464191ffcca26d65c158c37f21216cee8aa227> 09:43 sev_q Bonjour #Koha ! 09:44 magnuse hiya sev_q 09:45 sev_q Hi @magnuses 10:12 koha-jenkins Yippee, build fixed! 10:12 wahanui Congratulations! 10:12 koha-jenkins Project Koha_Master_D9 build #995: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9/995/ 10:13 magnuse woohoo! 10:13 koha-jenkins Project Koha_Master_D10 build #88: ABORTED in 1 min 47 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/88/ 10:14 magnuse nooo 10:15 ashimema I aborted it.. until we have a package for that one it's going to just keep being noisy and failing 10:15 ashimema I've disabled it for now 10:15 * ashimema wants Mirko back 10:16 koha-jenkins Project Koha_Master_D9_My8 build #7: ABORTED in 2 min 42 sec: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/7/ 10:16 ashimema snap 10:17 koha-jenkins Yippee, build fixed! 10:17 wahanui Congratulations! 10:17 koha-jenkins Project Koha_Master_U18 build #464: FIXED in 42 min: https://jenkins.koha-community.org/job/Koha_Master_U18/464/ 10:17 ashimema 🎊 10:17 koha-jenkins Project Koha_Master_D8 build #526: STILL UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D8/526/ 10:18 ashimema booo 10:21 magnuse indeed 10:26 marcelr woke up again 10:38 ashimema we just found mor differences between maria and mysql check constraints marcelr 10:39 ashimema bug 23995 10:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 normal, P5 - low, ---, martin.renvoize, Passed QA , Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. 10:39 ashimema the caveat in mysql's implimentation kinda makes them somewhat worthless 10:40 marcelr even more.. 10:41 marcelr hmm 10:41 marcelr why do you "support" them mysql? 10:41 marcelr they have an obscure idea of supporting 10:41 ashimema indeed 10:54 Joubu bug 24000 is available, I just got 23999 :) 10:54 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 could not be retrieved: InvalidBugId 11:03 marcelr got him Joubu 11:03 marcelr will find a bug for it 11:03 marcelr that should not be too hard 11:04 ashimema lol 11:04 ashimema you guys are funny 11:05 Joubu bug 24000 11:05 wahanui somebody said bug 24000 was available, I just got 23999 :) 11:05 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 trivial, P5 - low, ---, m.de.rooy, NEW , working title 11:12 marcelr bug 24000 update 11:12 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 trivial, P5 - low, ---, m.de.rooy, Signed Off , Koha::Item::Search::Field does not return 1 11:13 marcelr did you write that one Joubu :) 11:13 ashimema haha, nice 11:14 * ashimema casually wonders what bug number we would be at if we hadn't had to restart during the liblime fiasco 11:19 Joubu same ashimema I think, they have been copied 11:20 ashimema oh.. cool :) 11:20 lari do we have some kind of agreement on whether api endpoints such as one for messages table should be under its own /messages endpoint or under /patron/{patron_id} ? 11:20 lari i suppose there are many cases that could be either way 11:21 lari /patron/{patron_id}/messages * 11:21 lari i saw that accountlines are under patron 11:23 lari if they are under patron then the ability to list becomes limited 11:24 ashimema the patron one did make sense as at the time an accountline was always linked to a patron.. (and only one patron).. and as such is a sub-object of patrons.. 11:24 huginn News from kohagit: Bug 23997: Escape z3950servers.rank as it's a new MySQL 8 kw <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5ebf75ecd07f99b5d8bb56edc9b1758d262a30c1> 11:24 huginn News from kohagit: Bug 23995: Remove CHECK constraints from kohastructure <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0d2cc574d1c8ac00cebd91816277c75a461eef3b> 11:25 ashimema but.. with the introduction of anonymous payments I'm doing soon it'll make less sense :( 11:25 ashimema messages wise I'm not close enough.. gut feeling says it could be under /patrons as you say. 11:25 ashimema tcohen is closest to the api's at the moment. 11:26 lari we could also have both 11:27 lari i'll ask on the mailing list 11:27 ashimema indeed 11:37 * andreashm waves 11:46 tcohen lari: we tend to POST PATCH and PUT against the patron's one, and leave the /messages one to search, build tables, etc 11:47 lari tcohen: exactly, that makes sense 11:47 lari but for example accountlines doesnt have such endpoint for listing? 11:49 ashimema I suppose you could well want accountlines not filtered by their patron.. 11:49 ashimema at which point /patrons/{patron_id}/accountlines makes no sense at all 11:49 lari yeah for example listing accountlines of today or whatever 11:49 lari anyways i wrote to koha-devel 11:49 ashimema :) 11:50 * andreashm reads back. 11:50 andreashm ashimema: anonymous payments? 11:51 ashimema bug 13985 11:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 enhancement, P5 - low, ---, martin.renvoize, NEW , Cash Management - Koha as 'Point of Sale' 11:51 * andreashm has finally gotten around to start working on the stuff from the account-workshop in Marseille 11:51 ashimema bug 23354 in particular 11:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 new feature, P5 - low, ---, martin.renvoize, Needs Signoff , Add a 'Pay' screen to allow anonymous payments in a POS fashion 11:51 magnuse andreashm++ 11:52 ashimema i.e. someone should be able to walk into the library and buy, for example, a pencil without needing to present their library card 11:52 ashimema libraries in the UK are certianly diversifying and starting to sell stuff and not require full on membership for such sales. 11:53 ashimema I should rebase those patches.. but I've sort of set them on hold whilst we get 19.11 out of the way 11:53 ashimema I would have loved the whole set to go in within this release.. but alas it wasn't to be. 11:53 * andreashm is struggling with why Koha should be used for that use case. But just leaves it. =) 11:54 ashimema bug 23442 is really nice too 11:54 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 enhancement, P5 - low, ---, koha-bugs, NEW , Add a 'refund' workflow to the POS feature 11:54 ashimema maybe it's a very UK thing.. I'm sure the US do it too though... 11:55 ashimema the majority of public libraries here are really keen for such a feature 11:55 andreashm Oh we sell some stuff too (but less now than a few years ago). It's just not handled in the ILS: 11:55 andreashm As long as its separate from patrons accountlines, all is well. =) 11:56 ashimema it's been really holding us back in sales.. even though we've had such a facility backported for best part of 5 years already for some customers 11:56 ashimema fair enough.. 11:56 ashimema our libraries are keen to have one system and not have to jump out into another system to work a till 11:56 andreashm But just curious, how do you report etc on that stuff? Wouldn't it have been better to assign a patron as "sales" are something? 11:57 * andreashm didn't look to closely. Maybe you alreadydo. 11:57 ashimema it's mostly reported against the cash register or branch 11:57 andreashm Ah, alright 11:57 ashimema they want all 'transactions' in a branch/till at the end of the day 11:57 andreashm makes sense 11:57 ashimema bug 23355 does a chunk of that 11:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 new feature, P5 - low, ---, martin.renvoize, Needs Signoff , Add 'cashup' process to the accounts system 11:58 ashimema the feature as a whole is big.. hense I spread it out over about 20 bugs over 3 releases so far 11:59 Joubu ashimema: I am tackling bug 24002 11:59 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 normal, P5 - low, ---, jonathan.druart, ASSIGNED , Test suite is failing on MySQL 8 11:59 ashimema anyone your neck of the woods fancy signing up for the next release team andreashm ? 11:59 ashimema be nice to have another name on the bugwranglers, docs or qa teams ;) 11:59 ashimema or a topic expert if you guys are interesting in any particular area's at the moment 12:00 andreashm Not that I know. I'll spread the word. 12:00 magnuse a little heads up on the swedish slack would be cool 12:00 ashimema oh, thanks Joubu 12:00 * andreashm is looking a bit at Website maintainer role. 12:00 ashimema thanks :) 12:00 andreashm That webstie is in need of a face-lift 12:01 andreashm website 12:01 ashimema swedish slack? 12:01 andreashm Yup, we have a Swedish Koha Slack for the user group 12:01 ashimema ooh.. that would be cool 12:01 ashimema it's been wizzyrea's domain for years but I'm sure she wouldn't be adverse to a change :) 12:01 andreashm Need to discuss in the organization before I promise anything though. But we have been discussing how to give back to the community. 12:02 ashimema in slack land we have a few shared channel between companies these days.. helps grabbing individuals attention sometimes and is easier to share code snippets and the likes 12:02 ashimema I'm sure you'de be welcome in the mix 12:03 andreashm =) 12:04 koha-jenkins Project Koha_Master_D9_My8 build #8: FAILURE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/8/ 12:05 koha-jenkins Project Koha_Master_U18 build #465: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U18/465/ 12:15 * magnuse uses Rocket.Chat for company internal communications 12:16 * eythian finds the idea of making people use a proprietary system to talk with others about a free software system to be very weird. 12:16 ashimema I'd love to not be using Slack.. 12:16 ashimema but it's where we're at :( 12:17 eythian I ought to have a look into rocket.chat. There's also mattermost. 12:17 magnuse yup 12:17 ashimema I use matrix here but it's just not reliable enough yet 12:17 magnuse Rocket seems very solid so far 12:17 ashimema and we didn't fancy hosting another of our own systems.. we'de rather concentrate our resources on koha et al.. 12:18 magnuse i have tried to automate pushing rss feeds into rocket via hubot without too much success so far, though 12:19 ashimema slack is expensive, but it falls under the 'just works' camp 12:19 * andreashm likes Slack 12:19 ashimema there's too many darn options again 12:19 andreashm Tried Mattermost etc, but always only seems a step down 12:19 eythian it's a step up in not being proprietary though :) 12:21 ashimema maybe one day I will pursaude them to swap again 12:23 ashimema wasn't ryver also open at one point.. looks decidably closed now 12:23 magnuse in itself, i would say rocket is on par with slack, but integrations are easier in slack 12:25 ashimema do you self host magnuse, or outsource it? 12:25 magnuse self host 12:25 magnuse https://rocket.chat/docs/installation/manual-installation/debian/ 12:29 ashimema does it allow federation? 12:29 ashimema right now the thing I think we'd miss the most is the federated chat.. being able to setup a share between companies 12:30 magnuse hm, not sure 12:33 magnuse https://rocket.chat/docs/administrator-guides/federation/ 12:39 ashimema nice :) 12:41 ashimema second question.. do you have to login to use rocket.chat or is there an open option to let anon users into certain channels I wonder? 12:47 magnuse ashimema: https://rocket.chat/docs/administrator-guides/account-settings/ Allow anonymous read: Setting this to true will allow people to use the chat without having to create an account or log in. Anonymous users will be only allowed to read messages on public channels. 12:47 magnuse Allow anonymous write: This will allow Anonymous users to post messages on public channels. 12:47 koha-jenkins Project Koha_Master_D9 build #996: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D9/996/ 12:49 ashimema interesting 12:49 ashimema very interseting 12:49 koha-jenkins Project Koha_Master_D8 build #527: STILL UNSTABLE in 45 min: https://jenkins.koha-community.org/job/Koha_Master_D8/527/ 12:58 huginn News from kohagit: Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bd30a17d3bc0040460543ced27140690f50d27f0> 12:58 huginn News from kohagit: Bug 23949: Add z3950 directory to koha-common.install <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=832086ad7237c04ba6bc978ab786f8ce0a4f5d40> 12:58 huginn News from kohagit: Bug 5365: Make more clear how to reopen a basket in a basket group <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b687c60b27fa5a813b148bd5730b2d8278062ad5> 12:58 huginn News from kohagit: Bug 23949: Update documentation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2fc80e71e2bac4e0881f79eb712c0f62f5e68986> 12:58 huginn News from kohagit: Bug 22857: Sync koha-conf.xml files <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eaf4b79c32a6f173db8177b8ee365ec10f4532a6> 12:58 huginn News from kohagit: Bug 23933: (bug 10132 follow-up) Fix commit_file.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0eb9edbf229bdbde02ff65e5f955fb18cf0cc7db> 12:58 huginn News from kohagit: Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=56d87af81ac2bda6d1cf0b42807484982a45e1c4> 12:58 huginn News from kohagit: Bug 23398: Disable the XML import/export format for biblio framework <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ed45a4f333fb9f6569d150410ef99d8ffe13f54c> 12:58 huginn News from kohagit: Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=aae3dfe1232d8df452c7e677c6fa443017fb0417> 12:58 huginn News from kohagit: Bug 23847: Fix custom item search fields if subfield is '0' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a74f1dabe23bdcc17b68c8053fcf868d62f9231e> 13:18 magnuse have fun #koha! 13:19 ashimema :) 13:20 andreashm hehe 13:37 koha-jenkins Project Koha_Master_D9 build #997: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9/997/ 13:42 koha-jenkins Project Koha_Master_U18 build #466: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_Master_U18/466/ 13:43 koha-jenkins Project Koha_Master_D8 build #528: STILL UNSTABLE in 45 min: https://jenkins.koha-community.org/job/Koha_Master_D8/528/ 13:48 * oleonard_ glares at oleonard 13:53 Joubu ashimema: bug 24002 I'd like to see if it fixes the selenium tests 13:53 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Test suite is failing on MySQL 8 13:54 ashimema ok.. let me have a funt 13:54 ashimema punt.. even 13:55 oleonard_ It's all funt and games until the test suite fails on MySQL 8. 13:59 * ashimema forgot to pull in the latest docker build 13:59 ashimema trying again with your misc4dev fiexes 14:09 ashimema so far the selenium tests are looking good Joubu 14:09 ashimema I decided to just run all of them :) 14:10 Joubu yes they were passing for me without the patches but failing on jenkins 14:10 ashimema this is with MySQL 8.. I didn't spot the Jenkins failure 14:11 ashimema well.. they all pass with M8 and D9 for me here 14:11 ashimema with your patches.. 14:11 ashimema I'll give them a punt without the patches.. varify it 14:16 koha-jenkins Project Koha_Master_D9_My8 build #9: NOW UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/9/ 14:19 caroline_crazycatlady Good morning! 14:21 ashimema I can replicate the explosion and confirm your fix does indeed fix it Joubu :) 14:22 ashimema Looking at what you did.. do we need an DB updates to try and catch any stray bad dates.. or should those all be gone already 14:26 Joubu I think we dealt with that already 14:27 Joubu not really actually, only for borrowers.* date columns 14:51 Joubu sev_q: Salut Séverine 14:53 koha-jenkins Project Koha_19.05_U18 build #52: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/52/ 14:53 koha-jenkins Project Koha_19.05_D9 build #53: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/53/ 14:56 koha-jenkins Project Koha_19.05_D8 build #51: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/51/ 16:04 koha-jenkins Project Koha_19.05_D9 build #54: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/54/ 16:05 koha-jenkins Project Koha_19.05_U18 build #53: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/53/ 16:06 koha-jenkins Project Koha_19.05_D8 build #52: SUCCESS in 42 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/52/ 16:16 sev_q Hello Joubu ! 16:17 tcohen lari: we still need to add /account_lines 16:17 lari tcohen can you check Bug 24003 16:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 enhancement, P5 - low, ---, lari.taskula, Needs Signoff , REST API basic auth lacks C4::Context->userenv 16:17 lari I was trying to write rest tests but they kept failing due to this 16:19 lari Or, rather a new endpoint for exposing the messages table was failing 16:19 lari Because it adds messages.manager_id via userenv 16:20 tcohen why do you want to use userenv? 16:20 tcohen :-D 16:20 tcohen that' would fail if not cookie-based auth 16:20 lari Check Koha::Patron::Message->new, it's using userenv for what i mentioned above 16:20 tcohen we have the logged patron in $c->stash('koha.user'); 16:21 tcohen lari: ok, lets fix Koha::Patron::Messae 16:21 tcohen he 16:24 lari So we shouldnt rely on userenv alone in any of our models? 16:24 ashimema correct 16:25 lari Oki, then let's do that tcohen :) 16:28 lari I thought userenv is something we always expect to have 16:28 tcohen It makes sense on the controllers 16:28 tcohen no in the Koha::Object-based classes IMHO 16:28 tcohen and Mojo has another way of doing the same 16:28 tcohen the stash 16:32 sev_q bye bye #koha ! 16:43 koha-jenkins Yippee, build fixed! 16:43 wahanui Congratulations! 16:43 koha-jenkins Project Koha_19.05_U18 build #54: FIXED in 35 min: https://jenkins.koha-community.org/job/Koha_19.05_U18/54/ 16:48 koha-jenkins Project Koha_19.05_D9 build #55: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/55/ 16:49 tcohen lari: where's the code? 16:49 wahanui the code is bad but exists, so I copied it.. really? :D 16:51 koha-jenkins Project Koha_19.05_D8 build #53: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_19.05_D8/53/ 17:01 reiveune bye 20:47 lari tcohen on my dev machine 20:47 lari I'll send it next week 20:48 lari Bug 23998 20:48 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 new feature, P5 - low, ---, lari.taskula, ASSIGNED , Messages REST API 21:52 caroline_catlady have a good weekend everyone!