Time Nick Message 06:20 huginn News from kohagit: Bug 17084: Automatic debian/control updates <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c0b911c2d740951b2722a0f484b3848fd679ac25> 06:31 koha-jenkins Project Koha_Master_D10 build #66: STILL FAILING in 6 min 36 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/66/ 06:33 koha-jenkins Project Koha_Master_U18 build #438: STILL FAILING in 8 min 13 sec: https://jenkins.koha-community.org/job/Koha_Master_U18/438/ 06:33 marcelr hi #koha 06:35 koha-jenkins Project Koha_Master_D9 build #966: STILL FAILING in 4 min 13 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/966/ 06:45 koha-jenkins Project Koha_Master_D8 build #500: STILL FAILING in 22 min: https://jenkins.koha-community.org/job/Koha_Master_D8/500/ 06:49 ashimema just triggering a build of testing-docker and then the tests should start passing again 07:02 ashimema still hoping to QA bug 18958 marcelr ? 07:02 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 major, P5 - low, ---, kyle, Signed Off , If patron has multiple record level holds on one record transferring first hold causes next hold to become item level 07:03 marcelr hi ashimema 07:03 * ashimema isn't up to speed on it, but is slowly trying to work through Majors that look like they're not getting the attention they need 07:03 ashimema morning :) 07:03 marcelr might have a look 07:03 ashimema no worries.. I just didn't want to step on toes 07:03 marcelr np 07:05 marcelr ashimema: hey i see that i am the qa contact 07:06 marcelr still having some backlog in my bugzilla mail folder 07:06 marcelr the oldest is 03-2019 07:07 marcelr ;) 07:09 ashimema lol 07:09 ashimema my bz folder only ever seems to grow ;) 07:09 ashimema so I know the feeling 07:10 ashimema think we need a few global bug squashing days 07:11 ashimema or maybe I should spend a month touring next cycle and sitting next to a different QA person each week :P 07:35 marcelr ashimema: i am still having serious doubts about that patch set 07:35 ashimema which one? 07:35 wahanui somebody said which one was that 07:36 marcelr the holds one 07:36 ashimema 18958? 07:36 marcelr 18958 07:36 marcelr just looking at the code, it does not feel good 07:36 marcelr back then and still now 07:37 * ashimema hasn't looked in detail yet, but I trust your feeling 07:37 marcelr code is removed after the else block and inserted in the else branch 07:37 ashimema lets revisit it early next cycle.. I get the feeling it's been around a while 07:37 marcelr patch 2017 07:38 ashimema indeed 07:38 marcelr but let me still chew a bit longer 07:38 marcelr but i guess it is no longer a rc candidate 07:39 ashimema well.. as it's a 'major bug' then if you had a change of heart and decided you were happy with it then it could slip in.. we're in slush rather than hard freeze.. 07:40 ashimema but I get the feeling you're not going to have such a change of thought... what would be nice would be to have some selenium tests or something.. 07:40 ashimema I don't like that the main change here is in the controller and is entirely untested as far as I can tell 07:40 ashimema holds is a scary area 07:45 marcelr hi khall: bit sad to tell you that i just fqaed your patch ;) 07:46 ashimema good comment :) 07:48 marcelr ok if i am in holds now, i pick bug 21944 now 07:48 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 major, P5 - low, ---, nick, Signed Off , Fix waiting holds at wrong location bug 07:49 ashimema cool 07:49 koha-jenkins Project Koha_Master_D9 build #967: STILL FAILING in 5 min 13 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/967/ 07:49 ashimema I'd entirely forgotten about that one 07:50 ashimema :(.. I need tcohen.. Jenkins should have passed that time :( 07:51 marcelr hmm ashimema a test stumbles over the accounttype constraint.. what is the current view on that ? 07:52 ashimema which test? 07:52 marcelr Circulation.t 07:52 ashimema to me it highlights a bug.. I'm happy to take a look with an aim to fixing it. 07:52 marcelr Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2077. 07:55 marcelr well it also fails without that patch 07:55 marcelr FORGIVEN ? 07:56 ashimema interesting.. 07:56 ashimema sounds like it's a bug of it's own.. 07:56 ashimema I'll run up a mariadb and try to replicate it.. 07:56 ashimema I bet it's crept in since the account stuff was pushed 07:57 ashimema leave it with me.. I'll replicate it and report it as it's own bug 07:57 ashimema good catch 07:57 marcelr hmm could be my data too now somehow 07:57 marcelr i am going to a new fresh db 07:58 * ashimema wants the D10 tests to start building properly.. then we'll actually be regularly testing against a modern DBMS 07:58 ashimema need Mirko's expert hands to get the packages happy for D10 still 07:59 marcelr never see him here anymore 07:59 ashimema he's available on email.. but never here :( 07:59 marcelr @seen drojf 07:59 huginn marcelr: drojf was last seen in #koha 48 weeks, 2 days, 12 hours, 44 minutes, and 41 seconds ago: <drojf> -s 07:59 ashimema we could do with a new packaging manager really whilst he's busy.. but it's a complex role :( 08:03 marcelr Circulation.t passes on a fresh db 08:04 ashimema :) 08:04 marcelr so now we will never know.. :) 08:05 ashimema now I'm really confused 08:06 ashimema in the nightlies libnet-netmask-perl is listed in koha-perldeps and the build deps... 08:06 ashimema yet it's not being installed 08:06 ashimema hense the current failures 08:06 marcelr netmask sounds serious 08:07 ashimema it's required for Kyles recent proxy fixes 08:07 ashimema nice little patchset which allows one to whitelist proxies 08:08 ashimema bug 23068 if you're interested 08:08 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 enhancement, P5 - low, ---, kyle, Pushed to master , Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy 08:12 marcelr saw that one in a glance 08:14 ashimema aha.. now I see it 08:15 ashimema it takes two nights to add a depenacy to the packages.. 08:16 ashimema 1) push a patch that adds it to PerlDependancies.pm, 2) Nightly build script will spot the additional dependancy and add it to debian/control and post a patch to bugzilla for that, 3) Push that patch to the repository, 4) Nightly build script will now build the package listing that dependancy, 5) the tests should pass again.. 08:16 ashimema wish there was a way for me to trigger that package build 08:17 ashimema I can hack it into koha-testing-docker to get the current tests passing.. but that's perilous in the future if I forget to remove it again.. workarounds.. yuk 08:18 marcelr ok just be patient 08:33 ashimema indeed 08:49 huginn News from kohagit: Bug 23860: Update tests to new style <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4fd52650bcb2f8a549ea55d22aadeeac7202d19d> 08:49 huginn News from kohagit: Bug 23860: Make the patrons endpoint add the Location header <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=abf530ddbf1897c6fc798f6fa94d643b55823d44> 08:49 huginn News from kohagit: Bug 23860: Regression tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e1179b27e0ef7912364bc46ddf845b63443ef338> 08:49 huginn News from kohagit: Bug 23859: Update tests to new style <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7f1f52f2e52705eacb428916a209d4c05bd9fd9d> 08:49 huginn News from kohagit: Bug 23859: Make POST add the Location header on cities endpoint <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4de24b70e5d5cd2a4c5808509b6b47855a409dac> 08:49 huginn News from kohagit: Bug 23859: Regression tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bd7a012c524a7eb89283aabb1fefa956e47b79ee> 08:54 koha-jenkins Project Koha_Master_D8 build #501: ABORTED in 1 min 16 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/501/ 08:54 koha-jenkins Project Koha_Master_U18 build #439: STILL FAILING in 4 min 22 sec: https://jenkins.koha-community.org/job/Koha_Master_U18/439/ 08:54 koha-jenkins Project Koha_Master_D10 build #67: ABORTED in 4 min 27 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/67/ 08:54 koha-jenkins Project Koha_Master_D9 build #968: ABORTED in 16 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/968/ 08:59 koha-jenkins Project Koha_Master_D10 build #68: STILL FAILING in 3 min 59 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/68/ 08:59 huginn News from kohagit: Bug 22814: Make patron names on holds modal consistent (second check-in) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4764c439f9e19e0b1a88a7503e2bb502dbd3b7ac> 08:59 huginn News from kohagit: Bug 21824: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ddedd7b4266975d49e41481b8129f3efc5b0dfd> 08:59 huginn News from kohagit: Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatte... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1bb3ed4f5b8ab81072dac85f41744c8f08c92477> 08:59 huginn News from kohagit: Bug 21824: Add ability to format dates in various formats in templates <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=67d6c469a98ec5b39dabfb6c38feaf560727fc6e> 08:59 koha-jenkins Project Koha_Master_U18 build #440: STILL FAILING in 4 min 31 sec: https://jenkins.koha-community.org/job/Koha_Master_U18/440/ 09:05 magnuse D9 wins, with 16 seconds! 09:17 ashimema lol 09:19 * andreashm waves 09:21 koha-jenkins Project Koha_Master_D8 build #502: STILL FAILING in 23 min: https://jenkins.koha-community.org/job/Koha_Master_D8/502/ 09:33 qalbaqali Hi guys, need some help in removing koha from my ubuntu system. 09:34 qalbaqali qasim@ubuntu:~$ sudo koha-remove libraryname Removing Koha instance libraryname ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'IF EXISTS `koha_libraryname`@`%`' at line 1 09:34 qalbaqali Is this a known issue? 09:35 qalbaqali Ubuntu 16 09:39 qalbaqali I'm using MySQL instead of MariaDB, so I am guessing the uninstall command is not detecting what type of DB i have chosen when setting up using https://wiki.koha-community.org/wiki/Koha_on_Debian 09:41 ashimema we don't distinguish between the two and attempt to only use SQL pragma's that are compatible 09:41 ashimema so.. if it's erroring out for you then you've found a bug 09:41 ashimema I have a feeling it's the backtics? 09:41 ashimema could you report a bug on bugzilla please.. then I might be able to investigate a bit more 09:42 qalbaqali could you please link me to bugzilla koha? 09:43 ashimema https://bugs.koha-community.org/bugzilla3/ 09:43 ashimema I'll take a quick look at the code for you now to help resolve it temporarily if it's obvious whilst I we work on a more formal patch 09:44 ashimema thankyou :) 09:45 qalbaqali appreciate it :), I am waiting for the confirmation email for my bugzilla account. As soon as I get it ill write up a ticket 09:45 ashimema erm.. 09:45 ashimema are you 100% sure you're using mysql and not mariadb? 09:46 ashimema that error message is just passed along from the database 09:46 qalbaqali come to think of it now, I might be using MariaDB. I set it up yesterday and I forgot which command I ran when creating the DBs 09:46 ashimema haha.. no worries.. 09:46 ashimema that makes a little more sense then 09:48 ashimema could you check your mariadb version for me? 09:48 ashimema looks like 'IF EXISTS' was only added for that statement in mariadb 10.1.3 09:49 ashimema hmm.. yeah.. that's definitely a bug.. 09:50 ashimema the 'IF EXISTS' is the issue.. 09:50 qalbaqali Yup.. that's it. I am using v10.0.38 09:50 ashimema it's also bad in mysql.. we still support 5.5 and the IF EXISTS was only added to mysql in 5.7 09:53 qalbaqali Are there any manual steps to remove koha somewhere in the wiki maybe? 09:54 ashimema https://github.com/Koha-Community/Koha/blob/master/debian/scripts/koha-remove is the script that does it 09:55 ashimema that's going to be the most accurate 09:55 ashimema debian package install? 09:56 qalbaqali yes 09:56 kohaputti maybe apt uninstall koha*? 09:56 kohaputti or was it remove.. 09:57 ashimema that'll also fail it 09:57 ashimema it's remove they've asked for 09:57 kohaputti oh, apt purge it is 09:57 ashimema no.. 09:57 ashimema I 'think' they just want to remove one instance 09:57 ashimema so they can setup another? 09:58 kohaputti I see 09:58 qalbaqali I want to remove the whole koha, I screwed up and I want to create a new fresh installation 09:58 ashimema the dirty work around is to edit /usr/sbin/koha-remove directly.. and just take out the 'IF EXISTS' 09:58 qalbaqali Ill go for that one ^ 09:58 ashimema :) 09:59 qalbaqali thank you ashimema :D 09:59 ashimema once you've done that, re-running the koha-remove should work nicely 09:59 ashimema no worries 09:59 qalbaqali you've been helpful 09:59 ashimema sorry there's a bug :) 10:00 qalbaqali its not a bug, its a feature! 10:01 qalbaqali kidding. You guys are doing great work, making it possible for us to have our own library system. Keep it up! 10:01 ashimema :) 11:29 ashimema Joubu around today? 11:41 oleonard Hi all 11:42 magnuse hiya oleonard 11:56 * ashimema is tired today 11:57 oleonard Halloween party hangover eh? 11:58 oleonard magnuse: I was curious whether Norway had a holiday today and I see you're in a long national holiday drought between June and December :( 11:59 oleonard magnuse: But then I remembered countries other than the US get decent vacation time :D 12:01 * oleonard realizes that regular national holidays in the US keep the proletariat from reaching their boiling point (O_O) 12:02 magnuse oleonard: yeah, we have 5 weeks holiday, most people have all of july off 12:02 magnuse but june-december is kind of boring, yes 12:10 * cait waves quietly 12:10 cait oleonard: holiday in Germany 12:10 * ashimema grumps at cait 12:11 * cait hides 12:11 oleonard cait: But a regional holiday, right? Not national? 12:11 cait I tihk you are right, the Berlin library said they don't have it 12:12 cait i tihnk some have the 31 tho - reformation day? 12:15 cait seems like almost any state has one or the other 12:17 cait i am on bug 23938 12:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 major, P5 - low, ---, nick, Signed Off , Title missing from Checked out box 12:20 cait oleonard: i was wondering if oyu have a long and boring project you need some help with? 12:20 oleonard :D 12:20 cait did I open a can of worms? 12:21 oleonard I'm looking for the right sized can right now 12:22 oleonard But seriously, what kind of thing do you mean? 12:22 cait to open another can of worms... can I safely ignore the update errors for accountlines? 12:22 cait oleonard: clean up things maybe? 12:22 ashimema ? 12:23 ashimema what update errors cait? 12:23 cait http://paste.koha-community.org/7108 12:23 cait i think related tot he thing you grumped at me for... just wondering i i can just continue 12:25 cait oleonard: looking for a little project for my vacation 12:25 oleonard Yeah, I wish I had some good ideas but I can't think of anything offhand 12:25 cait buttons... icons... whatever touching templates or so 12:25 cait ok,if you can think of something, let me know:) 12:26 ashimema what DB are you using cait? 12:26 cait this is a standard kohadevbox 12:26 cait sec 12:26 cait hm ok 12:26 cait i am trapped in the web installer 12:27 cait wanted to check the about page 12:27 cait it doesn't le me finish because of the error 12:27 cait what is the cli command again? 12:28 ashimema one moment 12:29 cait i am right back too just starting tea 12:33 cait back until the water boils 12:34 cait andreashm: no holiday in sweden? 12:35 magnuse nor in norway 12:36 ashimema can you try some SQL manually for me cait? 12:42 cait yes 12:43 cait ah 12:43 cait found the version 12:43 cait Your MariaDB connection id is 37 12:43 cait Server version: 10.1.38-MariaDB-0+deb9u1 Debian 9.8 12:43 ashimema initially can you do a `SHOW CREATE TABLE accountlines` for me to check you have any CHECK constriants at all 12:44 cait http://paste.koha-community.org/7112 12:44 oleonard I did not know about "show create table," that's cool 12:44 cait oleonard: agreed 12:44 cait i usually use workbnehc, but useful to know the command line trick too 12:44 ashimema hmm 12:45 ashimema so you don't have the constraint in the first place.. that's interesting. 12:46 cait my last reset_all was not that long ago 12:47 ashimema `SHOW INDEX FROM accountlines WHERE key_name accountlines_check_type` 12:47 cait but i hadn't used this in a while, so it was a jump from 40 to 47 i think 12:47 cait You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'accountlines_check_type' at line 1 12:48 cait =? 12:48 cait ERROR 1054 (42S22): Unknown column 'accountlines_check_type' in 'where clause' 12:48 ashimema sorry.. yeah, I missed an '=' above 12:50 cait with the = it's the secon derror 12:50 ashimema `SHOW INDEX FROM accountlines WHERE key_name = accountlines_check_type` 12:50 ashimema ok, thanks 12:50 ashimema that leads me to think we have bigger problems with mariadb 12:51 magnuse uh oh 12:52 cait any good idea how i can work around it to get me back into business? 12:52 cait i have an hour i wanted to spend on some patches... 12:53 ashimema yes 12:53 ashimema one moment 12:53 ashimema add 12:54 ashimema `if ( index_exists( 'accountlines', 'accountlines_check_type') ) {` after line 20013 12:55 ashimema and `}` after line 20040 12:55 ashimema in updatedatebase.pl 12:56 ashimema yet another subtle difference between mariadb and mysql 12:56 cait it's the kind of thing I was worried about - sorry if it came across harsh 12:58 ashimema the simple answer is we don't support mariadb and call it mysql 12:58 ashimema they are not drop in replacements for each other any more! 12:58 ashimema that.. or we start supporting them properly and having installer/data/mysql AND installer/data/mariadb 12:58 ashimema anyways.. I'm fed up of that conversation 12:59 cait not quite 12:59 cait [Fri Nov 1 12:58:36 2019] updatedatabase.pl: Global symbol "$raise_error" requires explicit package name (did you forget to declare "my $raise_error"?) at /home/vagrant/kohaclone/installer/data/mysql/updatedatabase.pl line 20042. [Fri Nov 1 12:58:36 2019] updatedatabase.pl: Execution of /home/vagrant/kohaclone/ 12:59 cait installer/data/mysql/updatedatabase.pl aborted due to compilation errors. 12:59 cait i tihnk a lot are using mariadb as it is what debian default is 12:59 cait so... maybe not so simple 13:00 cait I tihnk the easiest would be to remove the constraint for onw until we have a proper fix 13:00 ashimema sorry.. I didn't account for the added first line when I gave you the second line number 13:00 ashimema the closing brace should be after the RaiseError 13:00 cait moving one down 13:00 cait yeah doing that right now 13:01 cait that worked 13:01 cait thx 13:01 ashimema ta 13:02 ashimema mwah 13:12 huginn News from kohagit: Bug 23805: (RM follow-up) Remove CHECK constraints <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f7325a6ed70fab67576eb0b5a74314d6a6191372> 13:12 ashimema done 13:12 ashimema I've given up caring about data integrity 13:13 oleonard :( 13:15 koha-jenkins Project Koha_Master_D9 build #969: ABORTED in 1 min 36 sec: https://jenkins.koha-community.org/job/Koha_Master_D9/969/ 13:15 koha-jenkins Project Koha_Master_D8 build #503: ABORTED in 2 min 40 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/503/ 13:16 koha-jenkins Project Koha_Master_D10 build #69: ABORTED in 59 sec: https://jenkins.koha-community.org/job/Koha_Master_D10/69/ 13:17 koha-jenkins Project Koha_Master_U18 build #441: ABORTED in 1 min 15 sec: https://jenkins.koha-community.org/job/Koha_Master_U18/441/ 13:18 cait ashimema: not to make you blow up... but... kohastructure 13:18 cait do we need to do something there as well? 13:19 ashimema ta 13:21 ashimema though it shouldn't actually matter there 13:22 ashimema as we're not updating.. it's only updates that the syntx differes 13:27 cait if we end up with the same structure for new and updated that's ok 13:29 ashimema we currently won't 13:32 magnuse huh, never really tried this before... i go to Home › Administration › Columns settings and mark som columns in the (id=issues-table) as "hidden by default". then reload the page with that table, but the columns still show. am i misunderstanding this whole feature? 13:32 ashimema are those settings perhaps cached? 13:32 magnuse possibly 13:32 caroline_catlady good morning! 13:32 magnuse hiya caroline_catlady 13:34 cait ashimema: can we fix that please? 13:34 cait magnuse: the details and checkout tabs are different tables settings - which tab are you loking at? 13:34 cait one is under circ and one in patrons i think(on the admin page) 13:34 cait hi caroline_catlady 13:36 magnuse ah, that could be it cait 13:37 magnuse cait++ that was it! 13:37 cait you are welcome 13:38 magnuse and the "Column visibility" thingy above the table itself, that is not supposed to be remembered between sessions or anything like that? 13:38 cait not currrently 13:38 cait oleonard: had a nice patch starting to do that... I hope he will revive it sometime 13:39 magnuse yay! 13:39 * oleonard hopes so too 13:39 * oleonard can't remember what the hangup was 13:43 cait i tihnk it was just the mixup with the new features on the overdues report that stopped it 13:43 cait iirc 13:43 cait although it would be very helpful for that one 13:43 oleonard I remember that... I think there was a bug with it that I discovered... 13:51 cait oleonard: do you want me to find the bug number? 13:51 oleonard No, thanks I remember it 14:03 tcohen hola #koha 14:04 cait tcohen: ashimema - pqa for me on bug 22581 14:04 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 new feature, P5 - low, ---, agustinmoyano, Passed QA , Add support for Plaine & Easie musical incipits rendering in OPAC 14:06 cait have to run, maybe back later tonight 14:11 magnuse cait++ 14:16 tcohen lovely 18:35 oleonard How the heck do you enroll a patron in a club? 20:51 bag !bang 20:51 AnnaBoten bag, you missed the duck! 20:51 bag !bang 20:51 AnnaBoten bag, you missed the duck! 20:51 bag !bang 20:51 AnnaBoten \_x< bag: 1 (101840.42 seconds) 20:51 bag YAY 20:57 AnnaBoten \_o< quack! 20:57 wahanui !bang 20:59 cait hi bag 20:59 bag heya cait 20:59 bag !bang 20:59 AnnaBoten \_x< bag: 2 (116.23 seconds) 21:01 AnnaBoten \_o< quack! 21:01 wahanui !bang 21:35 ashimema !bang 21:35 AnnaBoten \_x< ashimema: 1 (2004.53 seconds) 21:35 AnnaBoten [('bag', 2), ('ashimema', 1)] 21:35 AnnaBoten Best time: bag with 116.23 seconds 21:44 AnnaBoten \_o< quack! 21:44 wahanui *click* 22:05 bag !bang 22:05 AnnaBoten \_x< bag: 1 (1238.43 seconds) 22:07 AnnaBoten \_o< quack! 22:07 wahanui oops, slipped over