Time  Nick                  Message
05:28 cait                  @later tell tcohen do you have another moment to take a look at bug 23653? It's in the list of majors but might be an installation issue
05:28 huginn                cait: The operation succeeded.
06:11 ashimema              Mornin' #koha
06:29 fridolin              yolo
06:29 fridolin              wahanui: yolo
06:29 wahanui               fridolin: what?
06:30 fridolin              chill men
06:35 reiveune              hello
06:35 wahanui               privet, reiveune
06:42 cait                  good morning #koha!
06:43 liliputech_asu        morning :)
06:48 cait                  good morning liliputech_asu :)
06:48 cait                  and good morning marcelr ;)
06:52 davidnind[m]          hi cait
06:54 alex_a                Bonjour
06:54 fridolin              wahanui: i'm I online ?
06:54 wahanui               bugger all, i dunno, fridolin
06:55 fridolin              thx
07:14 cait                  hi davidnind[m] :)
07:14 cait                  great to see all the activity with the manual!
07:22 davidnind[m]          it is! (just hope I'm doing the merges right...)
08:01 marcelr               hi #koha
08:19 sev_q                 bonjour #koha :)
08:20 marcelr               hi sev_q
08:20 marcelr               cait: thx, waking up now
08:21 sev_q                 hello marcelr !
08:37 nlegrand              Hey!
08:40 liliputech_asu        salut :)
08:42 eythian               hi
09:03 vfernandes            hi #koha
09:16 marcelr               ashimema: hi
09:16 wahanui               privet, marcelr
09:16 ashimema              morning marcelr
09:16 ashimema              thanks for taking a look at 23049
09:16 marcelr               not ready yet
09:17 ashimema              I'm just rebasing some shibboleth patches and then I'll work through your feedback
09:17 marcelr               having serious doubts about two account type columns
09:17 marcelr               please wait while i am still qaing
09:17 marcelr               so my hardest comment is not on the bug yet..
09:17 ashimema              ok
09:35 marcelr               ashimema: sorry for failing qa on it ;)
09:35 marcelr               this is a discussion item
09:51 huginn                News from kohagit: Bug 23626: (follow-up) Fix JS when not viewing results <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=85b5abcc4e8a0d41c0e286d1b9f7deba4905636c>
10:01 huginn                News from kohagit: Bug 17140: DBRev 19.06.00.040 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9d9bb45865c9d6c88952f47f52f0e92ddcce0054>
10:01 huginn                News from kohagit: Bug 23484: (follow-up) add parenthesis in JOIN <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=77b681b5843dabd8808e6ad3e62999f1e9421280>
10:01 huginn                News from kohagit: Bug 17140: Atomic update file <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bc6e5902898fc3fbaa69b0fcc99359eadd6a8c76>
10:01 huginn                News from kohagit: Bug 17140: Make rounding syspref controlled <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ae075fded2a4ef8fb2f241e4cf9bb90d7587b02c>
10:01 huginn                News from kohagit: Bug 23484: Update pendingreserves.pl to use circulation_rules <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c21a9cf0b0b8fc03629837c8651c10781ddfe3c7>
10:01 huginn                News from kohagit: Bug 17140: fix rounding errors when paying fines <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c2df905bfef771415d47aeba7db6ea445a33f1e1>
10:10 marcelr               hmm it is fail qa today
10:58 cait                  andreashm++ # comment on the fines bug
11:26 kidclamp              marcelr FQA is better than no QA at all
11:31 oleonard              Hi all
11:32 sev_q                 hi oleonard !
11:33 cait                  kidclamp: bug 19465?
11:33 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 enhancement, P5 - low, ---, tomascohen, Signed Off , Allow choosing Elasticsearch server on instance creation
11:33 cait                  and hi sev_q!
11:34 sev_q                 if some sql experts want to have some fun, I had 2 news lines on the wishlist on SQL Reports Library :)
11:34 sev_q                 ha cait !
11:34 cait                  I'd love to help, but can't today :(
11:35 sev_q                 oh no probelm cait ! it on my "maybe one day to do list" :)
11:40 kidclamp              what are they sev_q ? I am curious
11:42 oleonard              https://wiki.koha-community.org/wiki/SQL_Reports_Library#WISHLIST
11:45 sev_q                 thanks kid clamps ! in fact my problem for the first one is that I don't understand how a sugestion is linked to an aqorder (I clearly missed somthing but I can't found what)
11:47 sev_q                 oups... sorry kidclamp, new keyboard and lots of typos :)
11:54 kidclamp              sev_q:https://github.com/bywatersolutions/koha-plugin-reports-plus
11:54 kidclamp              That does the second one
11:58 oleonard              Ooh, Reports-plus® !
12:01 oleonard              kidclamp: Is there any reason besides expediency that that is a plugin and not part of Koha?
12:02 cait                  oleonard++ was biting my tongue :)
12:02 kidclamp              It was more of a playground to test things, I should submit it at some point
12:02 ashimema              +1
12:02 kidclamp              I just haven't had a chance to get back to it
12:03 kidclamp              anyone is free to give it a shot :-)
12:03 sev_q                 kidclamp : you're amazing as usual !
12:03 ashimema              I wouldn't mind if we had a better communal way of showing off plugins ;)
12:03 kidclamp              kidclamp--
12:03 huginn                kidclamp: Error: You're not allowed to adjust your own karma.
12:03 sev_q                 can't wait to test it :)
12:03 ashimema              that project has been on my list for a while though.
12:04 oleonard              huginn helps us all practice self-care
12:04 huginn                oleonard: downloading the Perl source
12:20 * andreashm_          waves
12:21 ashimema              man, that itemtype image bug is wierd
12:21 cait                  i tried to look at it...b ut didn't quite get it
12:22 cait                  i think it has to do with the change in handling the object
12:22 cait                  the object method does't appear to work anymore
12:22 cait                  so... maybe it's not an object?
12:22 cait                  i go lost there.
12:24 ashimema              that would also break translated_description
12:24 ashimema              hmm
12:25 ashimema              you are totally right though
12:25 ashimema              he unblesses
12:25 ashimema              good call cait
12:25 ashimema              I remember not liking that when I first saw it
12:25 cait                  yeah, but I didn't dare to try an dunderstand why he would do that
12:25 ashimema              but couldn't see what it broke
12:26 cait                  and how the correct fix for theother bug woudl look like to restore...
12:26 ashimema              he's doing it because he wants to embed additional data
12:26 ashimema              which you can easily do with a hash but not so easily with an object
12:26 * ashimema            is working on it ;)
12:26 cait                  thx :)
12:26 cait                  at least i was not totally off then
12:26 cait                  but ithink it's a step backwards
12:27 cait                  once we pass objects to templats - we should not undo that
12:27 ashimema              totally agree
12:27 ashimema              I missed it
12:27 ashimema              my bad
12:27 ashimema              think i was down on this being such a low yield cycle.. i wanted to get some things in.
12:28 ashimema              like going shopping when you're hungry.. it's always a bad idea ;)
12:28 cait                  that is true
12:33 andreashm_            sigh, print problems again.
12:33 andreashm_            anyone else experienced that hold-slips, but not other slips (transfer-slips etc.), are slow in being sent to the printer? (takes about 5 seconds for returns.pl to reload)
12:34 andreashm_            problem appeared after upgrade to 18.11
12:34 cait                  might be related to a reace condition problem we had a while ago?
12:35 ashimema              first part fixed
12:35 andreashm_            any info on that?
12:35 andreashm_            cait
12:36 ashimema              do you have a preference as to whether we do split that bug into two or not cait?
12:38 cait                  if you have a fix for one issue
12:39 cait                  i think a split would make sense
12:39 cait                  so we can move on with that
12:39 cait                  i was not aware the problem was caused by 2 different things when i filed it
12:40 ashimema              ok.. patch uploaded for the first half
12:52 caroline_crazycatlady hi everyone!
12:54 ashimema              dang the second one is wierd as they come
12:54 ashimema              he code is scary
12:58 oleonard              ashimema gets an early Halloween
12:58 ashimema              lol
13:16 ashimema              kidclamp sill around?
13:16 ashimema              actually.. anyone with an interest with that itemtype image stuff
13:16 ashimema              if you've selected an image in the shipped set rather than a remote one..
13:17 ashimema              is there any reason you'd want the url in the remote url box to contain the url of the local image?
13:17 caroline_crazycatlady ashimema: I can't see any reason
13:23 ashimema              brill
13:24 ashimema              I blame kidclamp ;)
13:24 * oleonard            also votes: definitely wrong
13:24 oleonard              (not about kidclamp, about the url)
13:24 ashimema              bug 23804 is now ready for SO
13:24 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 major, P5 - low, ---, koha-bugs, Needs Signoff , Itemtype not checked when editing
13:24 ashimema              that was a fun one to understand
13:25 ashimema              oh cool.. thanks for SO on bug 23772 so quick oleonard
13:25 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 major, P5 - low, ---, martin.renvoize, Signed Off , Itemtype icons not showing in table
13:27 kidclamp              did I break a thing?
13:27 ashimema              indeed you did.. like a year ago ;)
13:27 ashimema              :P
13:28 ashimema              23804 is all your fault :P
13:28 ashimema              fixed now though.. and I can certianly see why you had it confused.. that code is crazy
13:37 huginn                News from kohagit: Bug 23803: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b9086738e9ffc8fb5a2328caf7e6719e84ba63a0>
13:37 huginn                News from kohagit: Bug 23803: (follow-up) Remove additional references and file <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=171573d2984733a0677d353d8f361f2bfe87e05d>
13:37 huginn                News from kohagit: Bug 23803: Add Font Awesome icon to cart in staff interface <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f3b3498256e8af81232ff8be84f373509485f1f9>
13:37 huginn                News from kohagit: Bug 23771: Don't look for patrons if we don't have a userid <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c9c6dd10167bc4c60cb384651f4dc802944c4228>
13:40 * oleonard            waves to wizzyrea
13:41 caroline_crazycatlady ashimema: I applied the patch for bug 23804, but I still can't see the image in the table
13:41 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 major, P5 - low, ---, martin.renvoize, Needs Signoff , Itemtype not checked when editing
13:41 caroline_crazycatlady What am I missing?
13:41 ashimema              23804 doesn't fix the table ;)
13:42 caroline_crazycatlady ok so I have to apply another patch to get step 2?
13:42 ashimema              bug 23772 fixes the table
13:42 huginn                Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 major, P5 - low, ---, martin.renvoize, Signed Off , Itemtype icons not showing in table
13:42 ashimema              bug 23804 fixes the edit form
13:42 ashimema              cait wanted them split into two bugs (should make backporting the latter one easy as that one affects 18.11 onwards)
13:43 caroline_crazycatlady It's just the test plan that is confusing I guess
13:43 ashimema              ahh...
13:43 ashimema              my bad
13:44 ashimema              your toally right.. the test plan is totally wrong
13:45 ashimema              you can apply the other bug to be able to follow it
13:48 caroline_crazycatlady mmm... remved the patch but the image is still checked... I think today is going to be very confusing. Good thing a 3-day weekend is coming up zzz
14:05 cait                  caroline_crazycatlady: what's on monday? :)
14:06 caroline_crazycatlady Canadian Thanksgiving
14:08 oleonard              And US's "Columbus Day" (boo)
14:36 corilynn              we call it "Practice Thanksgiving" in hour house
14:36 corilynn              *our
15:08 cait                  do we know about how many tests jenkins runs?
15:42 reiveune              bye
15:45 ashimema              lots
19:57 liliputech_asu        hello :)
19:58 * oleonard            can't tell who just arrived and who is just reconnecting
20:11 liliputech_asu        oleonard: I'm not supposed to be here ;) weekend time in france but had an email to reply to before leaving :)
20:16 oleonard              Now I'm off. Happy weekend everyone.
22:04 caroline_crazycatlady have a good weekend everyone!