Time  Nick               Message
05:28 marcelr            hi #koha
05:44 marcelr            hi cait
05:45 cait               hi marcel!
05:59 cait               trying to figure out how to go about testing bug 20307
05:59 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 new feature, P5 - low, ---, jonathan.druart, Signed Off , Language overlay for authorized values
05:59 cait               but i guess just starting somewhere will be good for the half hour i have right now :)
08:37 ashimema           mornin' 'koha
08:37 ashimema           sounds scary cait.. I tested it as best I could.. seemed to work
08:38 ashimema           it's probably one to just do a few tests on.. and then throw it in and see if anytihng drops out over the next few months
08:38 ashimema           horrible as it sounds..
08:38 ashimema           I think it's minimally intrusive as a whole
08:38 * ashimema         is currently trying to understand DateTime..
08:38 ashimema           always a place that scares me.. :(
08:43 ashimema           Why of why is `DateTime->now()->delta_ms(DateTime->now()->add( hours => 4 ) = DateTime::Duration->new( hours => 3, minutes => 59, seconds => 15 );`!
08:44 cait               ashimema: which one?
08:44 wahanui            which one is, like, that
08:44 cait               sorry, i might be missing the first bit of conversation
08:44 cait               so it sounds like cait is scary again...
08:44 ashimema           huh.. which one what?
08:44 wahanui            rumour has it which one is that
08:45 cait               (10:37:52) ashimema: sounds scary cait.. I tested it as best I could.. seemed to work
08:45 cait               what was before that? :)
08:45 ashimema           bug 20307 your testing
08:45 cait               and I AM NOT SCARY
08:45 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 new feature, P5 - low, ---, jonathan.druart, Failed QA , Language overlay for authorized values
08:45 cait               oh
08:45 cait               waiting for Joubu now :)
08:45 ashimema           it was a reply to you're `trying to figure out how to go about testing bug 20307
08:45 ashimema           huginn``
08:45 cait               it's probably not as bad as it sounds, apart from the last ponit
08:48 ashimema           ouch.. good spot on that last one
08:51 cait               marcelr: commented on bug 23445
08:51 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23445 normal, P5 - low, ---, katrin.fischer, Failed QA , Loan period unit in circulation rules is untranslatable causing problems one editing rules
08:53 cait               not sure i am best at explainign today
08:58 marcelr            ok cait i wont block that
08:59 cait               sorry for so many words
08:59 marcelr            :)
08:59 cait               and thx for QA :)
08:59 cait               marcelr++
09:02 cait               marcelr: not sure how strong your date foo is.. but i've been eying bug 15260 and got very confused about it all
09:02 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 enhancement, P5 - low, ---, andrew.isherwood, Signed Off , Option for extended loan with useDaysMode
09:03 marcelr            date foo ?
09:03 cait               your skills with date/time calculations
09:03 marcelr            i love them ;)
09:03 cait               that makes you a little scary :)
09:03 marcelr            heh
09:05 marcelr            ashimema: i think you are wrong about tracklinks
09:05 marcelr            my $search_crit = { uri => $uri };
09:06 marcelr            we are searching for uri AND bibllionumber OR uri AND itemnumber
09:06 marcelr            we are definitely not searching for just a biblionumber
09:10 cait               hm uris can be on item and record level - need to catch both
09:11 marcelr            yeah we do
09:11 * ashimema         double checks he read the patch right
09:12 ashimema           poop.. yuo're right.. I missed that you'd assign uri at the beggining
09:13 marcelr            i remember testing these variations
09:13 marcelr            even small changes in uri etc
09:14 marcelr            it is a bit arbitrary if it could lift along as qa follow-up but reverting it on the base of wrong assumption is hard too :)
09:16 ashimema           That's why I didn't revert it.. I asked someone else to check I'd read it right ;)
09:16 * ashimema         is running the tests again
09:16 marcelr            thx
09:17 ashimema           surprised Joubu also misread it
09:17 ashimema           :(
09:17 ashimema           nobodies perfect though
09:17 marcelr            maybe he just followed your advice
09:17 ashimema           'tis why we have qa ;)
09:19 eythian            hi
09:20 marcelr            hi eythian
09:20 eythian            hoi marcelr
09:20 marcelr            long time
09:20 eythian            no sea: <|-(((((-< (it's supposed to be a fish skeleton)
09:21 marcelr            still working on regexes?
09:21 eythian            heh
09:21 eythian            always
09:25 ashimema           do you understand the DB rollback issue now marcelr?
09:25 ashimema           I'd be really interested if you have any better ideas
09:26 ashimema           or eythian for that matter..  any thoughts on the best way to make an integration test reset the DB to it's original state after the tests have run?
09:27 ashimema           I've gone for a quick and dirty dump at beggining then reload at the end.. (we're on different connections for the integration tests of course so can't just use DB transactions)
09:28 marcelr            yeah i was thinking about problems with nested transactions we have in some tests; but this is a selenium like approach
09:28 ashimema           yup
09:29 ashimema           I thought we'd resolved most of the nested transactions stuff..
09:29 ashimema           tcohen gave it a good go at some point I'm sure.
09:29 marcelr            iirc bit of a workaround ?
09:29 eythian            I've never seen a good solution. Common ways are that the test rolls back its changes as it goes (usually leaves detritus around when the test fails), or having a random element to the data for each test so that leaving bits behind doesn't matter (not always possible.)
09:29 ashimema           mm. probably
09:29 eythian            Also mocking the database so it doesn't really exist.
09:29 eythian            that's probably the best one where you can
09:29 ashimema           yeah.. I think we've got a mix of all of those now
09:30 ashimema           mocking is good but also the most tedious to impliment I find
09:30 ashimema           took me ages to mock everything I needed for he shibboleth tests
09:30 ashimema           thanks for the advice though.. always helpfull to know.. even if it's that everyone else is just in the same boat of pain
09:31 marcelr            you know mokken, eythian ;)
09:32 eythian            met thee?
09:34 marcelr            yeah thats yet another meaning
09:35 marcelr            zit niet zo te mokken met die mok
11:23 huginn`            News from kohagit: Bug 23445: (RM follow-up) Add warning for unexpected lengthunit <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1aae63606caeb389a40bd644b1f9e30917325573>
11:23 huginn`            News from kohagit: Bug 23455: Patron card printing from Patron lists is broken <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a57aea15a7f86e71bdfb6d6540aed18b2702b226>
11:23 huginn`            News from kohagit: Bug 23446: Fix display issue in serials navigation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d5152dfcdf9ba63fd04d0dc15f34c851e5c85836>
11:23 huginn`            News from kohagit: Bug 23445: Make loan period unit translatable fixing editing issue <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=16789351efd1f7dca88ed0797208ba5723922b62>
11:23 huginn`            News from kohagit: Bug 23242: Fix insert of Z3950 servers with strict SQL modes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9c730244768ea355004e821d5be35dc2e617840>
11:23 huginn`            News from kohagit: Bug 22830: correct for loop in value_builder/unimarc_field_4XX.pl value_builder <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=669864f4b0cb16fc9a8566bffdeb42d7875fd8aa>
11:23 huginn`            News from kohagit: Bug 22799: Avoiding batch item modification case sensitivity when entering barcodes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2071fa4aca27f6748f32fd62037a203df2347141>
11:33 huginn`            News from kohagit: Bug 23324: (QA follow-up) Typo and remove unneeded use statement <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b48e2d5e7a41511dccadb01808e1ece259c5f0b9>
11:33 huginn`            News from kohagit: Bug 23324: (QA follow-up) Use existing NormalizeISBN function <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5104d1eae67db94bebb05b2e9f1817685649b224>
11:33 huginn`            News from kohagit: Bug 23324: Add an ISBN normalization routine <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3d15819443bd114a5e61a7a9ee947a3307d39b8f>
11:38 oleonard           Hi folks
11:39 cait               hi oleonard!
11:39 wahanui            hi oleopard
11:46 magnuse            kia ora oleonard
12:04 koha-jenkins       Project Koha_Master_D8 build #353: UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D8/353/
12:05 koha-jenkins       Project Koha_Master_D9 build #844: UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D9/844/
12:07 ashimema           Booo
12:07 cait               boo
12:16 oleonard           👻
12:21 koha-jenkins       Project Koha_Master_U18 build #330: UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_U18/330/
12:22 eythian            g'day oleopard
12:34 magnuse            trying to run a cronjob on a gitified 18.11.x i get this error:
12:34 magnuse            http://paste.koha-community.org/7281
12:34 magnuse            Can't locate Koha/Exceptions/DuplicateObject.pm
12:34 magnuse            all i try to do is "use C4::Context;"
12:37 cait               devbox?
12:37 wahanui            devbox is probably working fine btw :)
12:37 oleonard           Hush wahanui
12:38 magnuse            nope, a gitified production instance
12:39 ashimema           feels like PERL5LIB doesnt know where lib/Koha is
12:39 ashimema           or.. we have a bug where that module is missing..
12:39 ashimema           version?
12:39 wahanui            i guess version is very stable and translation is great
12:39 ashimema           18.11.x.. you already said
12:39 ashimema           could be a backport error
12:41 magnuse            /home/kohaadmin/kohaclone/Koha/Exceptions.pm does mention Koha::Exceptions::DuplicateObject
12:41 magnuse            but there is no DuplicateObject.pm in /home/kohaadmin/kohaclone/Koha/Exceptions/
12:41 wahanui            Hmm.  No matches for that, magnuse.
12:42 magnuse            18.11.04 to be precise
12:43 magnuse            oops, the script seems to run ok from the command line, but not from cron
12:43 magnuse            in both cases i run the script with ...PERL5LIB=/home/kohaadmin/kohaclone/ /usr/bin/perl...
12:44 koha-jenkins       Project Koha_Master_D9 build #845: STILL UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D9/845/
12:45 koha-jenkins       Project Koha_Master_D8 build #354: STILL UNSTABLE in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D8/354/
12:48 magnuse            not running through koha-shell, but setting KOHA_CONF and PERL5LIB made the error go away
12:49 huginn`            News from kohagit: Bug 23445: (RM follow-up) Missing filter <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7e4f25e088305d9dd299bbfaa33b6140137c2f01>
12:52 ashimema           hmm.. I bet koha-gitify's last change was before koha-shell really got used widely.. bet it doesn't do much to change that at all
12:52 * ashimema         conjecture
13:07 caroline_catlady   good morning!
13:07 oleonard           Hi caroline_catlady
13:18 koha-jenkins       Yippee, build fixed!
13:18 wahanui            Congratulations!
13:18 koha-jenkins       Project Koha_Master_D9 build #846: FIXED in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/846/
13:28 koha-jenkins       Yippee, build fixed!
13:28 wahanui            Congratulations!
13:28 koha-jenkins       Project Koha_Master_U18 build #331: FIXED in 38 min: https://jenkins.koha-community.org/job/Koha_Master_U18/331/
13:30 oleonard           Hi wizzyrea
13:34 koha-jenkins       Yippee, build fixed!
13:34 wahanui            Congratulations!
13:34 koha-jenkins       Project Koha_Master_D8 build #355: FIXED in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D8/355/
13:39 magnuse            have fun #koha
13:45 cait               thx oleonard++!
13:47 oleonard           👍
13:48 cait               i hope that's a nice square thing :)
13:49 oleonard           <thumbs-up.png>
14:02 cait               :)
14:16 * oleonard         buys cait emoji support in her IRC client for Christmas
14:17 * caroline_catlady wonders if hexchat has an emoji support plugin
14:18 cait               :)
14:18 oleonard           Chatzilla doesn't have a tool for inserting them but at least I can paste them in and see them
14:18 cait               oleonard: maybe i have to check configuration
14:20 oleonard           It should take precedence over all other tasks
14:33 cait               pidgin could - but i can't find the folder where i'd have tput it
14:34 cait               it's not where it was before windows 10... (new os since begining of the week)
14:34 cait               so i guess you will have to describe for me for now...
14:41 eythian            It's a font thing, it should just work if you have a font with that character.
14:42 cait               oleonard: can you emoji me please?
14:42 oleonard           🐎
14:42 cait               hm no tworking yet
14:42 cait               :strawberry:?
14:43 wizzyrea           no
14:43 wizzyrea           :(
14:43 wizzyrea           hexchat shows them and you can paste them in
14:43 cait               i can see yous wizzyrea
14:43 cait               maybe iam jsu missing some now
14:43 cait               you couldn't see the strawberry?
14:43 wizzyrea           nope
14:43 wizzyrea           hexchat at least doesn't translate those
14:43 oleonard           ::invisible strawberry::
14:44 wizzyrea           hehe
14:44 wizzyrea           :horse:
14:44 cait               i can see the horse
14:44 wizzyrea           wot
14:44 wizzyrea           hah
14:44 wizzyrea           my horse?
14:44 wizzyrea           or oleonard's horse
14:44 cait               yours
14:44 wizzyrea           :strawberry:
14:44 wizzyrea           weeeird
14:44 oleonard           :sasquatch:
14:45 cait               that prints as text
14:45 cait               but i see it shoudl be a sasquatch
14:45 cait               i use pidgin there is tons of themes
14:45 cait               not sure which woudl be the right one
14:45 cait               https://developer.pidgin.im/wiki/ThirdPartySmileyThemes
14:45 cait               something to investigate another time
14:45 cait               :)
14:45 oleonard           (I don't think there is actually a sasquatch emoji)
14:45 cait               there shoudl be
14:45 cait               ok, leaving for the weekend
14:46 cait               bye all!
14:46 caroline_catlady   bye!
14:47 wizzyrea           bye cait
14:47 wizzyrea           what do you all think about this problem of items that have no itemtype
14:47 wizzyrea           for example the hold queue spits them out as warnings
14:47 ashimema           hahahaha..
14:47 ashimema           I've been grappling with that issue of late
14:47 wizzyrea           the holds to pickup gives ISE when it has one
14:48 ashimema           well.. not specifically the holds queue.. but a general.. wtf.. how can an item not have any effective_itemtype
14:48 wizzyrea           (it also chokes on borrowers with no expiry, or holds with no expiry, but that's a different problem)
14:48 wizzyrea           i was thinking about how to solve this
14:48 wizzyrea           would it make sense
14:48 wizzyrea           to have a default item type
14:48 oleonard           This issue discriminates against Highlander patrons who have no expiration date
14:49 wizzyrea           say, the one you create with the onboarder
14:49 wizzyrea           with the option to set any others later in the interface
14:49 caroline_catlady   We have tons of warning when running rebuild_zebra for some reason
14:49 wizzyrea           that's another place
14:49 wizzyrea           it's super easy to get an item with no item type
14:49 wizzyrea           it isn't a required field for items
14:49 caroline_catlady   blou got tired of it so he changed it so that if the item has no itemtype, it takes the record's itemtype
14:50 wizzyrea           harder to be blank, but it can still happen
14:50 caroline_catlady   yes, but at least in the default framework, the itemtype is mandatory (942$c)
14:51 wizzyrea           it's definitely harder to mess that up
14:51 wizzyrea           but it can still happen.
14:51 wizzyrea           maybe fall back to the bib, and then back to a default?
14:51 wizzyrea           if you don't have both
14:51 wizzyrea           idk
14:52 wizzyrea           ashimema, do you have any brilliant ideas about fixing that?
14:52 wizzyrea           i feel like it's gone on long enough, we need to Do Something
14:52 caroline_catlady   I like the capitalization :)
14:52 wizzyrea           of course it's not the most urgent bug but it's confidence eroding when people get internal server errors
14:53 ashimema           tcohen and I discussed it yesterday
14:53 wizzyrea           awesome
14:53 caroline_catlady   I feel like if you have item-level itemtypes syspref set, the item-level itemtype should be mandatory?
14:53 ashimema           in general it does actually fallback from item level to bib level already.. but you are correct.. you can still have an empty bib level
14:53 ashimema           I agree
14:53 KotH               might anyone here know, where i could get MARC data to japanese books? I don't really want to create my own entries....
14:54 wizzyrea           that is a really good q KotH
14:54 ashimema           the best we came up with so far was a nasty warning in the about page with all the other warnings so we can shame librarians into fixing their catalogues
14:54 oleonard           caroline_catlady: Unfortunately we don't have checks on imported records to prevent items from being imported without itype
14:54 caroline_catlady   right, only when you batch import them
14:56 wizzyrea           wine.wul.waseda.ac.jp port 210 might work?
14:56 wizzyrea           see that's why I think a default one that is always applied, user configurable, would be best
14:56 wizzyrea           if it doesn't have one, we automatically use the default one
14:57 wizzyrea           so at least everything has an effective item type
14:57 oleonard           Makes sense to me
14:57 caroline_catlady   I like it
14:57 wizzyrea           but there might be a technical reason not to do that?
15:00 ashimema           none that I can think of
15:03 oleonard           Is "it's hard work" a technical reason?
15:04 oleonard           Bug 14862
15:04 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 normal, P5 - low, ---, oleonard, Needs Signoff , Upgrade jQuery from 1.7 to 3.4.1 in OPAC
15:08 wizzyrea           hehe yes
15:08 wizzyrea           that's a technical reason
15:08 wizzyrea           oh boy now that, that's hard work
15:15 KotH               YAY! there is an english form where one can apply to access the national diets library's marc data... which you can only find if you navigate through two pages of dense japanese legalese ^^'
15:17 KotH               hmm.. I can apparently apply for Z39.50 or SRU as service... which one is better?
15:26 oleonard           Yay, it's weekend cait!
15:30 oleonard           When did we get so many templates in the OPAC
15:30 oleonard           There used to be like... five.
15:41 ashimema           SRU generally requires a tad less setup KotH
15:41 ashimema           (it sits on standard HTTP ports most of the time.. Z39.50 often doesn't)
15:41 KotH               ashimema: thanks
15:42 KotH               for reference, if anyone else ever needs japanese marc data: https://www.ndl.go.jp/form/en/service/api_application.html
15:47 oleonard           KotH: You grab it from them, we'll grab it from  you ;)
15:57 KotH               *g*
16:55 * cait             sends oleonard cookies
16:55 * cait             is making lasagna
16:55 cait               i tihnk the first in 10 years - veggie
16:56 cait               can someone make sense of bug 23466?
16:56 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23466 major, P5 - low, ---, koha-bugs, NEW , In some catalogs it does not show the "holding"
17:02 * ashimema         is making apricot and prune chicken tagine... Mmm
17:03 ashimema           Pass on bug 23466
17:03 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23466 major, P5 - low, ---, koha-bugs, NEW , In some catalogs it does not show the "holding"
17:06 cait               ashimema: top!
17:06 cait               i love fruity and salty :)
17:07 cait               are still school holidays?
17:08 ashimema           To
18:30 caroline_catlady   For bug 23353, can I take the opportunity to update the default framework with new labels as per www.marc21.ca or should that be a different bug entirely?
18:30 huginn`            Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23353 major, P5 - low, ---, caroline.cyr-la-rose, ASSIGNED , ACQ framework makes fr-CA web installer explode
18:30 caroline_catlady   I would put them in different patches, but in the same bug
18:40 cait               caroline_catlady: i tihnk if you them in a different bug, you#d have nicer visibility in the release notes
18:41 cait               or we coudl update the bug title maybe
18:41 cait               ... laundry bbl
18:56 cait               re
20:46 caroline_catlady   good weekend everyone!