Time Nick Message 05:31 lari does koha have tools to sync marc21 framework updates (such as bug 21899) into other languages in installer/data/mysql/lang_LANG ? 05:31 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21899 enhancement, P5 - low, ---, bgkriegel, Pushed to stable , Update MARC21 frameworks to Update 27 (November 2018) 06:34 fridolin hi 06:35 reiveune hello 07:01 alex_a bonjour 07:12 calire morning 07:32 * magnuse waves 07:46 ashimema good morning #koha 07:46 ashimema did I miss much last week? 08:15 magnuse kia ora ashimema! 08:16 magnuse nah we just decided to rewrite Koha in Java 08:16 ashimema :S 08:19 magnuse isn't that the expected answer to that question? ;-) 08:21 ashimema hehe, indeed it is 09:52 * andreashm waves 10:40 huginn` News from kohagit: Bug 23396: DBRev 19.06.00.016 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3eadb87fd86b2331d4ea58aa86f1810bbf952c89> 10:40 huginn` News from kohagit: Bug 23396: (QA follow-up) Add atomic update <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5e4e26dd0f7516bd3dca4758bbc3c72e4b9723d5> 10:40 huginn` News from kohagit: Bug 21518: Material type "three-dimensional artifact" displays as "visual material" <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=88ff22bb5a5d535893cf238ae784bb62a5b7d676> 10:40 huginn` News from kohagit: Bug 23396: Add keyboard_shortcuts.sql to C4/Installer.pm <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=484b8245af189edcaba64f191981cd5374237125> 10:40 huginn` News from kohagit: Bug 14549: POD and variable cleanup <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3352d75bfeea1dd5d9d6e025b6884a190044003c> 10:40 huginn` News from kohagit: Bug 14549: Check patrons reserves for any holds on a bib when checking out an item <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=36ee00ed952ed9081eeeca5e98fe006fbaa12db6> 10:40 huginn` News from kohagit: Bug 14549: Unit tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=33bd28fb856d496370f7132171aa479c77b28af8> 10:40 huginn` News from kohagit: Bug 10492: Translation problems with TT directives in po files <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0f5d14f70792d5406857a81c415bc3f58cbd8b96> 10:45 ashimema @later tell tcohen did a recent jenkins update change how status icons work? 10:45 huginn` ashimema: The operation succeeded. 12:02 eythian wahanui: can you hear me now? 12:02 wahanui eythian: i haven't a clue 12:06 magnuse it heard something... 12:12 eythian my IRC client thought it was connected when it actually wasn't, and I was surprised how quiet it was in here... 13:19 Joubu ashimema: there is no more space on Jenkins, I guess that's why the icons have not been generated 13:19 Joubu and hi #koha! 13:19 ashimema I wondered that 13:19 ashimema hi Joubu! 13:21 lydell Hi, everyone. We recently updated our Koha from 16.11 to 19.05 and it seems like we can't login to Koha with our MySQL login anymore. Is this expected? If so, can we setup a new admin login? 13:25 magnuse lydell, yes i think that is expected 13:25 magnuse there is a command line script to add a superlibrarian 13:28 magnuse misc/devel/create_superlibrarian.pl 13:28 magnuse if you are on a package install: /usr/share/koha/bin/devel/create_superlibrarian.pl 13:31 caroline_catlady good morning! 13:33 fridolin yooo 13:34 lydell I'll try the command line script and see if that helps. Thanks! 13:34 oleonard Hi #koha 13:35 fridolin bug 23427 swapped syspref XD the bug was sleeping since 3.18 13:35 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 normal, P5 - low, ---, fridolin.somers, Needs Signoff , Better sorting of previous checkouts 13:35 fridolin i must says system preferences meaning is very disturbing 13:36 fridolin "asc" meaning earliest to latest => but the value of date is growing 13:36 wizzyrea hi 13:36 greenjimll ILSDI question for anyone around: should GetRecords return a date_due field in items? Our previous Koha instance seemed to and the self-documentation says it should, but our live 18.11.04 isn't including them. 13:37 fridolin greenjimll: i think its field onloan that gives this due date 13:38 fridolin oh but you mean in <items> tag 13:39 greenjimll Yes. It looks like it changed at some point between 16.05 and 18.11, but the self-generated docs from ilsdi.pl still include it. 13:39 greenjimll I use it in our reading list system to work out availability on the fly - librarians have just noticed that everything is now available! 13:40 fridolin i see a date_due in <issues><issue> 13:40 greenjimll The onloan element will fix things though - thank fridolin 13:41 fridolin https://demo.biblibre.com/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=345 13:41 greenjimll Yes, but I'd have to process all the issues, rather than just look in each item. The onloan field seems to work OK though as a replacement. 13:41 fridolin greenjimll: there is no named field onloan, its a MARC subfield, i think issues tag is better 13:42 greenjimll I'm seeing an "onloan" field in each item on our 18.11.04 instance? 13:42 fridolin ah indeed 13:43 fridolin date_due will contain the hour 13:43 fridolin so you have the choice ^^ 13:44 greenjimll If you take a look at https://demo.biblibre.com/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords you'll see it still says "date_due" in the item, even though on 18.11.04 it isn't there! 13:45 greenjimll I'm guessing the self-generated documentation of ilsdi.pl has got out of step with the code generating the XML at some point. I only tripped over it because I'm using it for our reading lists. 13:45 greenjimll That'll teach me to read documentation. :-) :-) 13:48 oleonard That classic rookie mistake ;) 13:51 greenjimll OK, I think I should probably put in a bug report for this... not sure if its the documentation that needs to match the code, or the code that needs to match the docs. :-) 14:00 lydell magnuse: Thanks for your help! The script did allow me to create a new superlibrarian 14:03 huginn` News from kohagit: Bug 23099: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7af08918892b7763c551f70e0de30a8202ab14f2> 14:03 huginn` News from kohagit: Bug 11529: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fe55839893828071967bd84a3041904bb75ac0d0> 14:03 huginn` News from kohagit: Bug 11529: DBRev 19.06.00.018 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7883eb0692b15fdc453437cc595bf1903fa4540b> 14:03 huginn` News from kohagit: Bug 22610: DBRev 19.06.017 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d82e31ab13d658dae7b1385692064d570752be42> 14:03 huginn` News from kohagit: Bug 11529: (QA follow-up) Copy existing subtitle mappings and warn others <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=66655602b7038a4d7ae45e6d3b8bb98cf78cb0c4> 14:03 huginn` News from kohagit: Bug 23386: Add language of original in advanced search <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2905ff0bf87ba0fd71c2fb3bc54bf368fc9d95ce> 14:03 huginn` News from kohagit: Bug 23099: OPAC Search result sorting "go" button flashes on page load <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a89a203c1c85841a09b49771adbd77eeb76180c2> 14:03 huginn` News from kohagit: Bug 11529: (follow-up) Fix QA issues <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5b1ed49baa49927768dc004d1d56684651bb6d79> 14:03 huginn` News from kohagit: Bug 11529: (follow-up) Fix link on hold request page <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4cf5fcf10b85e22aeacc2578a39b173951132143> 14:03 huginn` News from kohagit: Bug 11529: Add templates for biblio title display. Unify display. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a1a05db1b638803135df535cd9f40180523e5f0e> 14:03 huginn` News from kohagit: Bug 11529: (follow-up) Remove manage_keywords2koha_mappings permission. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1543134b346fd0c6eab26b3023ca6cf764a16952> 14:03 huginn` News from kohagit: Bug 11529: Remove duplicate column name from select query <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b641ca7aa758f580f950c4529afa1f63c8fed73f> 14:03 huginn` News from kohagit: Bug 11529: Replace bibliosubtitle with biblio in all framework sql's. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2556b9e523f15765147fe34ed9a2d3d76105bc46> 14:03 huginn` News from kohagit: Bug 11529: Update kohafield in default framework only if not already set. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=26e5873ee505ace671f2c9e1a9c6ec9ee3278c1b> 14:03 huginn` News from kohagit: Bug 11529: DBIx schema changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8c8bbb3198b8809aeaabab4de2e7e6bad957d94b> 14:04 huginn` News from kohagit: Bug 11529: Remove field mapping table and admin page <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5af98f8fab3b0d9263962bac6b5a1e453ad3e988> 14:04 huginn` News from kohagit: Bug 11529: Clean up subtitle usage <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ee44dce28562941b8f831bb79a564c1384a8f832> 14:04 huginn` News from kohagit: Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0e4f36b653af8425650dc76130cfa25af50429ae> 14:04 huginn` News from kohagit: Bug 11529: Use new biblio fields whenever possible <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4ea26c0a697fcd8e4f88feb9a4f43a8b02c06650> 14:04 huginn` News from kohagit: Bug 11529: Add new fields to biblio table <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fabac13052d93465f8d348493930de4daedc708b> 14:04 oleonard ashimema++ 14:07 ashimema nice spot greenjimll , deffo a bug if the docs don't match the functionality.. 14:07 ashimema oleonard... 14:07 wahanui rumour has it oleonard is happy for ashimema to write the release script 14:07 greenjimll Just raising a bug report for it... 14:07 oleonard ... 14:08 ashimema I just tried to apply 23339 but it seems something i've pushed earlier today means it doesn't apply :(.. the rebase looks reasonably trivial but as the indenting expert I thought I'd ask you to take a quick look at it for me.. wouldn't want to make it worse again ;) 14:09 oleonard I'll take a look 14:09 oleonard Thanks 14:10 greenjimll OK, there's now Bug 23429. 14:10 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 minor, P5 - low, ---, koha-bugs, NEW , ilsdi.pl GetRecords documentation does not match output 14:10 ashimema sorry I didn't spot it earlier to make it someone elses problem ;) 14:11 ashimema thanks greenjimll :) 14:28 koha-jenkins Project Koha_Master_D8 build #336: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_Master_D8/336/ 14:38 lukeG1 oleonard: thanks for the follow-up up 14:39 oleonard lukeG1: By the way, it's worth revisiting whether we want the link to only show up on the first page of search results 14:39 oleonard I'm ambivalent about it now 14:42 oleonard I would like to recommend Bug 22804 if anyone is looking for a signoff. It requires OverDrive access, so I know it's not for everyone... 14:42 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 normal, P5 - low, ---, oleonard, Needs Signoff , OPAC Overdrive JavaScript contains untranslatable strings 14:45 huginn` News from kohagit: Bug 23328: Some check-in messages should be dismissable <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=43b0ef8f535bb1bd8341997d25675741b2ad0776> 14:55 huginn` News from kohagit: Bug 23237: Fix POD and typos <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a6fb4e4f2af100c867da3434756a82f65c04b971> 14:55 huginn` News from kohagit: Bug 23237: Plugin allow [% INCLUDE %] from template <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8c517d2f2860c08263f44dfde8d3cadea418694e> 14:57 koha-jenkins Project Koha_19.05_D9 build #21: STILL UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_19.05_D9/21/ 15:06 reiveune bye 15:24 oleonard ashimema: Bug 23339 rebased 15:24 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 enhancement, P5 - low, ---, oleonard, Passed QA , Reindent addbooks.tt 15:24 ashimema thanks :) 15:26 koha-jenkins Project Koha_Master_D8 build #337: UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D8/337/ 15:28 huginn` News from kohagit: Bug 23339: (follow-up) Markup comments and corrections <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cf0f57b437f64f96f4a0cadb14d7ba71cafc0f25> 15:28 huginn` News from kohagit: Bug 23339: Reindent addbooks.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c2cfb45d3d74023a711ce127b71df8c3cc88218a> 15:32 Joubu ashimema: Jenkins certainly failing because of misc4dev bug, you should manually start a new run 15:33 ashimema koha-testing-docker is building.. so I think you're right 15:34 ashimema once that's good I should be able to re-run the last push :) 15:34 ashimema thanks 15:35 tcohen hi 15:35 tcohen ashimema: we are missing mtj's node 15:35 tcohen things will be slower 15:35 tcohen :-) 15:35 ashimema thanks for the heads up 15:53 oleonard ashimema: It looks like Bug 11529 may have broken the holds queue report for some reason? 15:53 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 enhancement, P5 - low, ---, ere.maijala, Pushed to master , Add subtitle, medium and part fields to biblio table 15:53 oleonard It's now coming up empty for me even though the db has data in it 15:54 koha-jenkins Project Koha_Master_D9 build #830: STILL UNSTABLE in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/830/ 16:01 koha-jenkins Project Koha_Master_D8 build #338: ABORTED in 7 min 20 sec: https://jenkins.koha-community.org/job/Koha_Master_D8/338/ 16:03 tcohen ^^ that was me 16:14 ashimema nooo 16:14 ashimema did we miss something oleonard 16:14 * ashimema tests 16:15 koha-jenkins Project Koha_Master_U18 build #317: UNSTABLE in 56 min: https://jenkins.koha-community.org/job/Koha_Master_U18/317/ 16:15 ashimema this one right: /cgi-bin/koha/circ/view_holdsqueue.pl 16:17 ashimema :( 16:17 ashimema I can replicate the issue 16:20 Joubu there is an SQL error 16:21 Joubu there is a comma missing 16:22 Joubu C4/HoldsQueue.pm:138 16:22 ashimema so there is.. 16:23 ashimema tanks Joubu.. you got there moments before me.. I'd just spotted the error but hadn't got to the missing comma yet :) 16:25 ashimema fix pushed 16:25 huginn` News from kohagit: Bug 11529: (RM follow-up) Fix missing comma in query <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=762a03fca1e7b5b0c37a4a0715a1dc2d84b9200a> 16:26 ashimema If that's the only fallout from that bug I'll be super happy :) 16:26 ashimema It's been well tested by lots of people.. but it's still a fairly big change 16:56 koha-jenkins Project Koha_Master_D8 build #339: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_Master_D8/339/ 16:59 oleonard ashimema: Better to have stuff break sometimes than never make progress 17:00 * oleonard says, breaking things 17:05 oleonard Joubu++ 17:09 Joubu ashimema: are you on the other failures? 17:09 Joubu I am looking at the www tests, you can fix the missing filters ;) 17:09 ashimema just about to be.. not looked at them yet.. had to pause to take daughter to martial arts 17:09 ashimema ta 17:10 koha-jenkins Project Koha_Master_D9 build #831: STILL UNSTABLE in 54 min: https://jenkins.koha-community.org/job/Koha_Master_D9/831/ 17:24 ashimema hmm 17:24 ashimema these filters may be false failures.. 17:24 ashimema we don't worry about filters in FOREACH blocks so I'm not sure we should worry about them in a WHILE block either.. 17:25 * ashimema refers to guidlines.. we don't discourage WHILE do we.. I can't see any other use of it in our templates. 17:27 koha-jenkins Project Koha_Master_U18 build #318: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_U18/318/ 17:37 ashimema Joubu: still around? 17:39 Joubu yup 17:40 ashimema do you agree with my final followup on 11529 ? 17:40 ashimema adding WHILE to the recognised directives list in the QA filters test tool? 17:40 ashimema I initially thought why not use a FOR.. but actually I see why he's doing it.. for interleaving purposes to WHILE makes sense.. I think 17:41 ashimema in which case I think it needs the same treatments as FOR loops.. just wanted to make sure you agreed as more of an expert in this area than me :) 17:42 Joubu yes, definitely, someone asked for that already (cannot remember who/when/where) 17:43 ashimema brill, thanks 17:43 Joubu Maybe on a separate bug report, for backporting purpose 17:43 ashimema pushed then :) 17:43 ashimema thanks 17:43 huginn` News from kohagit: Bug 11529: (RM follow-up) Add WHILE to directive list <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=107804fb872eea2cb9e21d6f54e747ba047c9c9e> 17:43 huginn` News from kohagit: Bug 11529: Prevent too many spaces/break lines in the title tag <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cce433ba4c796c96bbd7f68bf7c0546ca8fed695> 17:44 Joubu https://gitlab.com/koha-community/qa-test-tools/issues/17 17:45 Joubu And it's the same line I guess :) 17:45 ashimema hmm.. you are likely right.. 17:45 ashimema I'll add a bug for it retrospectively now 17:45 oleonard Joubu thanks for testing Bug 23013! 17:45 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 enhancement, P5 - low, ---, oleonard, Needs Signoff , Upgrade DataTables in the staff client 17:45 oleonard Joubu: Did you rebuild the staff client CSS? 17:46 Joubu nope! 17:47 Joubu ha, better! 17:47 * ashimema is really happy to see that one moving :) 17:48 ashimema Joubu.. I see you've rebased a few of your bigger projects.. any preference on order I should attack them? 17:51 Joubu bug 15522 (and the 2 deps) and bug 20443 (not ready but I am stuck and need help) 17:51 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , New interface for revamped circulation rules 17:51 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Move C4::Members::Attributes to Koha namespace 17:53 koha-jenkins Project Koha_Master_D8 build #340: STILL UNSTABLE in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D8/340/ 17:53 Joubu and I have a local branch (apparently I did not submit it yet) where I remove AddItem/ModItem 17:54 ashimema nice 17:57 koha-jenkins Project Koha_Master_D9 build #832: STILL UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/832/ 17:57 ashimema also.. I'm keen to get a QA eye on bug 20307.. I found I couldn't easily do it any simpler.. it looks good.. though I tihnk it may benefit from a few more unit tests ;) 17:57 ashimema I'll be trying to find a friendly QAer for it soon.. just thought you'd like the heads up 17:57 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 new feature, P5 - low, ---, jonathan.druart, Signed Off , Language overlay for authorized values 17:58 Joubu thanks! 17:59 lydell Does anyone know if it's possible to adjust the barcode alignment to be centered similar to the text in a barcode/biblio layout? We recently updated from Koha 16.11 to 19.05 and the barcodes are no longer centered on the labels 17:59 * ashimema goes for the collection of child run 17:59 ashimema brb 18:21 koha-jenkins Project Koha_Master_D8 build #341: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_Master_D8/341/ 18:49 koha-jenkins Yippee, build fixed! 18:49 wahanui Congratulations! 18:49 koha-jenkins Project Koha_Master_U18 build #319: FIXED in 56 min: https://jenkins.koha-community.org/job/Koha_Master_U18/319/ 18:50 koha-jenkins Yippee, build fixed! 18:50 wahanui Congratulations! 18:50 koha-jenkins Project Koha_Master_D9 build #833: FIXED in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/833/ 18:59 oleonard See y'all later 19:22 asdsada hello All 19:23 asdsada what do you like about koha? 19:31 caroline_catlady asdsada: it's user-friendly and customizable, so it's suitable for libraries of all types and sizes 19:31 asdsada are you engineer, was it hard to set it up? 19:32 caroline_catlady asdsada: no I'm a librarian 19:33 asdsada did you set it up? 19:33 asdsada or someone else did for you? 19:34 caroline_catlady I work in a support company, so my colleagues install the software for our clients. I do the configuration 19:35 asdsada I see 19:35 caroline_catlady It's a company that has been around for more than 10 years so they have their process pretty much down to a T. When I tell them to create a new installation, 5-10 minutes later I have it ready 20:00 asdsada so you work for support company 20:00 asdsada or you work for library 20:01 caroline_catlady I work for a support company, but I am a librarian 20:25 lydell Does anyone know how to center a barcode in a label creator layout? I can center the text, but the barcode doesn't get centered 20:25 caroline_catlady If I remember correctly, you have to play with the left text margin 20:28 lydell Ok, that looks like it might actually help. If I understand right, the left text margin doesn't actually move centered text, but does affect the barcode? 20:29 caroline_catlady That's what I remember too 20:30 caroline_catlady It's been a while since I did barcode, and my brain has erase this trauma from its memories 20:31 lydell Lol, that's definitely understandable! It looks like adjusting the left text margin will allow me to center the barcode. Thank you! 20:31 caroline_catlady no prob! 21:22 davidnind caroline_catlady: is it okay if I add the education meeting to the Koha YouTube channel? 21:22 caroline_catlady sure! 21:22 davidnind thanks! 21:33 caroline_catlady anyone good with TT in notices around? I'm trying to use an IF and it doesn't seem to be working