Time  Nick          Message
05:37 fridolin      hi there
06:12 ashimema      :D
06:12 ashimema      10!
06:21 magnuse       ashimema++ for RM!
06:21 ashimema      :)
06:25 magnuse       then you can sneak in all the crazy ill goodies without anyone noticing!
06:28 ashimema      lol
06:41 reiveune      hello
06:43 magnuse       bonjour reiveune
06:57 alex_a        bonjour
07:05 magnuse       kia ora alex_a
07:08 ashimema      alex_a
07:08 ashimema      Are you still interested in / working on bug 8137
07:08 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 enhancement, P5 - low, ---, alex.arnaud, Failed QA , Checkout limit by patron category for all libraries
07:09 ashimema      I've got a customer wanting to test it
08:22 * ashimema    wants the QA scripts to magically run the relevant tests.. it's all too easy to forget to run them
08:22 ashimema      @later tell cait I'm catching up ;)
08:22 huginn`       ashimema: The operation succeeded.
09:01 cait          hay_fever--
09:03 cait          good morning all
09:06 cait          oh, that's quiet
09:08 ashimema      hi
09:08 cait          life! :D
09:09 tuxayo        o/ cait ashimema
09:12 magnuse       hiya cait ashimema tuxayo
09:13 magnuse       anyone familiar with how "Netloan PC Bookings" talks to SIP2?
09:16 cait          sorry, never heard of it
09:17 ashimema      we have customers using it I think
09:17 ashimema      I leave SIP configs to others here though..
09:18 ashimema      anything in particular you're struggling with magnuse
09:18 ashimema      is bug 11573 still a thing?
09:20 cait          bug 11573
09:20 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 normal, P5 - low, ---, wizzyrea, Failed QA , change description of rental charges in account fines
09:20 cait          i believe so
09:20 ashimema      no idea why that didn't work first time
09:20 cait          but it might be a duplicate
09:20 cait          let me check
09:21 ashimema      looks like it's not been touched in nearly 3 years
09:21 ashimema      still.. I've ressurected older recently
09:22 cait          there was a patch from caroline recently
09:22 cait          i am looking for it
09:22 ashimema      the patches on this one are wierd..
09:23 cait          i think we might be able to close this one as duplicate: bug 17413
09:23 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17413 enhancement, P5 - low, ---, koha-bugs, NEW , Translatability: Rental fee, Renewal of Rental Item etc. are hard coded
09:24 ashimema      a quick glance at the code make's me think it doesn't stand a chance of working
09:24 ashimema      excellent
09:24 wahanui       darn tootin' it is.
09:24 cait          still looking for the other bug i was thinking of
09:25 magnuse       ashimema: netloan blames a problem on koha, so i wonder when it actually talks to koha/sip2 - just when a reservastion is made, or also when the patron tries to "use" the reservation
09:25 cait          ah found it, but it was another related one: bug 21953
09:25 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 minor, P5 - low, ---, caroline.cyr-la-rose, Failed QA , Term "Lost item" is untranslatable
09:27 ashimema      hmm
09:31 * cait        tries to interpret hmm and fails
09:33 cait          i feel we really need to do something about the pay form
09:33 ashimema      huh?
09:33 ashimema      what are you trying to interpret cait?
09:33 cait          [off] http://librarygeekgirl.de/pics/Selection_006.png
09:34 cait          i entered the amount i want to pay, it's less than the amount i owe... and the system tells me that i need to give change?
09:34 ashimema      erm.. that's plain wrong
09:34 cait          is it just the labelling being confusing and i entered it wrong... or what's going on there?
09:34 ashimema      I find those fields really confusing now
09:34 ashimema      why do we need 'outstanding,
09:34 cait          same
09:34 ashimema      'paid' and 'collected'
09:34 ashimema      having all three is just wierd
09:35 cait          outstanding makes sense... to me
09:35 cait          it's the total on the account due
09:35 cait          but we used to nly have amount paid
09:35 ashimema      indeed
09:35 ashimema      but all three just confuses matter
09:35 cait          i have no idea what the collect from is for
09:35 cait          ah
09:35 ashimema      what the 'collect from patron' there for at all?
09:35 cait          i guess i know say: i want to pay 6 but i gave you 13.20...
09:35 cait          but... that's just super odd
09:35 cait          and i don't want to enter 2 fields
09:36 ashimema      totally
09:37 ashimema      isn't it a bit strange to allow someone to hand over a £20 when they owe £10 but allow them to only pay £5.
09:37 ashimema      feels like a really fringe case.. might happen very ocassionally in real life
09:38 ashimema      but surely you just calculate the change yourself at that point
09:39 ashimema      want me to rescue bug 21953 cait
09:39 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 minor, P5 - low, ---, caroline.cyr-la-rose, Failed QA , Term "Lost item" is untranslatable
09:39 ashimema      sorta looks like it won't get any love otherwise
10:16 cait          wizzycray: could you take a look at bug 22359 please? looking for opinions
10:16 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 enhancement, P5 - low, 19.05, koha-bugs, NEW , Improve usability of 'change calculation' (bug 11373)
10:29 greenjimll    Just to join in the chorus, I asked the guys here about due/paid/collected and they think its nuts too. :-)
10:31 cait          ashimema: yes plz
10:31 cait          greenjimll: can you comment on the bug please? I tink it could give it some push
10:32 cait          greenjimll: I feel a bit lonely there right now :)
10:32 cait          also if you have ideas how to fix it
10:38 greenjimll    cait: which of the bugs mentioned this morning is the one that needs the comment?
10:38 cait          bug 22359
10:38 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 normal, P5 - low, 19.05, koha-bugs, NEW , Improve usability of 'change calculation' (bug 11373)
10:38 cait          for the change cash thing
10:48 greenjimll    OK, comment made.  The only thing we could thing of is if some sites need to reconcile Koha payment records to ones from an EPOS till system.
10:48 greenjimll    s/thing of/think of/
10:52 cait          greenjimll: i just commented back
10:52 cait          i think the idea was to help people calculate
10:53 cait          but I tihnk it needs to step back to be more optional
11:02 cait          trying to see where we build the table of saved reports to fix bug 22357
11:02 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 major, P5 - low, ---, koha-bugs, NEW , Every run of runreport.pl with --store-results creates a new row in saved reports
11:09 ashimema      bug 21953 back to SO for a final quick QA run on the two followups I added.
11:09 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 minor, P5 - low, ---, caroline.cyr-la-rose, Signed Off , Term "Lost item" is untranslatable
11:13 cait          i have a fix... bt i am not sure why the line I deleted was there in the first place :(
11:19 cait          ashimema: did you mean to touch bug 12156?
11:19 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156 major, P5 - low, ---, gmcharlt, NEW , Merging staged records with no 952c with records created in acquisitions loses data from both
11:20 cait          ah already fixed
11:20 josef_moravec cait: see bug 17535, it added the line you are going to remove in bug 22357
11:20 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 normal, P5 - low, ---, jonathan.druart, CLOSED FIXED, Regression: Search for reports by keywords
11:20 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 major, P5 - low, ---, katrin.fischer, Needs Signoff , Every run of runreport.pl with --store-results creates a new row in saved reports
11:20 cait          thx josef_moravec!
11:20 ashimema      er no..
11:21 ashimema      not seen 12156 before
11:21 ashimema      did I do sometihng>?#
11:21 ashimema      :confused:
11:22 cait          josef_moravec: this code is quite confusing
11:22 cait          i am not even sure what it would do with saved_reports as we are not searching there
11:22 cait          or do we really want to search in results?
11:22 josef_moravec cait: I don't think so
11:23 josef_moravec before 17535, the test was broken, is it passing after your fix?
11:23 josef_moravec for now?
11:23 cait          hm it looks like we do
11:24 cait          http://paste.koha-community.org/2622
11:24 cait          i am going to fail my patch... but given that I am really not sure how to fix it, someone else might have to have a go
11:28 cait          josef_moravec: i had a feeling thi swas not going to be so easy... but as the bug hasn#t received much attention so far :)
11:28 cait          do you have a clue how we could fix this right?
11:29 josef_moravec cait: sadly no, to be honest, I do not know the reports code much...
11:30 cait          it's quite confusing
11:30 cait          maybe the link to the other bug will wake up Joubu
11:31 * ashimema    thinks Joubu is happily sunning himself on a beach somewhere
11:32 * cait        misses him
11:33 ashimema      me too
11:44 magnuse       ashimema, AndrewIsh: do you think there is a chance bug 22280 got solved as a side effect of something else? i can't seem to reproduce the problem on master
11:44 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 normal, P5 - low, ---, koha-bugs, NEW , The ILL module assumes every status needs a next/previous status
11:46 cait          can someone remind me how to fix htis? [NoNodes] ** No nodes are available: [localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/Indexer.pm line 382.kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ exit
11:49 cait          i started the service, but the status is red
11:49 cait          http://paste.koha-community.org/2623
11:51 kidclamp      check var/log/elasticsearch/elasticsearch.log
11:51 kidclamp      the service didn't start for some reason
11:54 magnuse       not enough tuits!
12:08 oleonard      Hi all
12:15 AndrewIsh     magnuse:  Nothing springs to mind that could have mitigated that bug!
12:16 magnuse       gah
12:16 magnuse       i better test more carefully, then
12:27 cait          kidclamp: running out to meet a friend for icecream - maybe if oyu are still around later we can have a look at elastic?
12:29 kidclamp      sure
13:15 magnuse       why don't we have autocomplete="off" on fields where you search for patron data like name etc?
13:16 oleonard      There was a bug that did that some time ago... maybe some exceptions have crept in?
13:18 oleonard      Bug 5009
13:18 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5009 enhancement, P5 - low, ---, dpavlin, CLOSED FIXED, add autocomplete="off" to borrowernumbers and barcode forms
13:18 oleonard      Bug 12283
13:18 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12283 enhancement, P5 - low, ---, pasi.kallinen, RESOLVED FIXED, Set autocomplete=off for patron search input
13:28 oleonard      Bug 22553
13:28 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 major, P5 - low, ---, oleonard, Needs Signoff , Unchecking a subpermission does not uncheck the top level permission
13:29 magnuse       thanks oleonard
13:29 MauBR         Hello friends good mornign (depending your country :)). I have a question, please help me. I am trying to edit the 000 header field, 18 subfield but in administration / Marc structure the 000 field does not shows the subfields inside 000 header... where can I find the subfields for edit???
13:31 oleonard      I think strictly speaking 000 doesn't have subfields, MauBR
13:31 oleonard      Are you using MARC21?
13:32 oleonard      MauBR: When you edit the subfields for 000 do you see just the "@" tab?
13:33 MauBR         Hello Leonard. Yes I am using MARC. I need to edit the value of the 18th position of the header 000. In my case it shows "a- AACR 2", but i want to change it to default value: "i- Incluye puntuación ISBD"
13:34 MauBR         but I do not know where to change it.
13:34 MauBR         yes I see the @ tab
13:35 oleonard      As far as I know there is no setting to change that
13:36 oleonard      But you could probably do it with some custom JavaScript. Let me give it a try.
13:37 MauBR         Thank you Leonard.
13:39 oleonard      MauBR: Do you currently have any code in the intranetuserjs system preference?
13:39 MauBR         let me see
13:40 MauBR         No i dont Leonard
13:41 pastebot      "oleonard" at 127.0.0.1 pasted "MauBR: Add this to the intranetuserjs system preference:" (5 lines) at http://paste.koha-community.org/2624
13:42 MauBR         ok
13:42 MauBR         should I restart apache after that?
13:43 oleonard      No
13:43 MauBR         Leonard, it works!!! Thank you very much! no need to restart apache.
13:44 oleonard      :)
13:44 MauBR         :)
13:48 wizzycray     hi
13:48 wahanui       hello, wizzycray
13:48 oleonard      Hi wizzyrea
13:49 wizzyrea      hello hello
13:49 * oleonard    pictures wizzyrea turning into wizzycray after a certain amount of time in #koha, which is why she's wizzycray when she logs back in
13:49 wizzyrea      or maybe cray because of too much time away ;)
13:50 oleonard      That's more like it :D
13:50 wizzyrea      ^.^
13:51 * wizzyrea    looks at the circulation home page and is JUST SIMPLY CHUFFED
13:51 wizzyrea      it looks so good now.
13:51 wizzyrea      sometimes I forget
14:01 fridolin      https://wiki.biblibre.com/doc:koha:base_de_donnees:tips
14:01 fridolin      liliputech_asu_away: ^
14:05 oleonard      wizzyrea++
14:30 vfernandes    hi #koha
14:31 vfernandes    on opac-detail.pl we have the following if: [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
14:31 vfernandes    MARCNOTES comes from method GetMarcNotes
14:31 vfernandes    but i can't find from where notes are being calculated
14:32 vfernandes    it's opac-detail.tt and not opac-detail.pl
14:32 oleonard      vfernandes: I think it's looking for biblio.notes
14:32 wizzyrea      hm, aren't the notes usually in the 500 fields?
14:32 vfernandes    hummm that's it
14:33 oleonard      biblio.notes is kinda obsolete since MARC came along.
14:33 vfernandes    in MARC21 the notes are in 500 fields, in UNIMARC in 300 fields
14:33 wizzyrea      so more like thinking about what what kind of paint it needs, rather than the colour.
14:33 wizzyrea      er lol
14:34 wizzyrea      1694             # Field 5XX$u always contains URI
14:34 wizzyrea      1695             # Examples: 505u, 506u, 510u, 514u, 520u, 530u, 538u, 540u, 542u, 552u, 555u, 561u, 563u     , 583u
14:34 wizzyrea      in C4/Biblio.pm
14:34 wizzyrea      for MARC21
14:35 wizzyrea      but yeah it's grabbing them from the 500 fields
14:35 wizzyrea      unless it's in the note blacklist syspref thingerdoodle
14:38 vfernandes    the problem is that if MARCNOTES is empty (because of note blacklist), biblio.notes appear on note separator
14:38 wizzyrea      ahh
14:38 wizzyrea      always good to lead with the problem you are trying to solve :)
14:39 wizzyrea      Are you saying you never want to see notes ever?
14:41 vfernandes    I want to see the notes, but with blacklist working
14:42 wizzyrea      ah, so you have notes in the biblio.notes that you don't want to see?
14:42 vfernandes    yes
14:42 wizzyrea      and you can't blacklist them?
14:42 wizzyrea      because they're not marc ones
14:42 wizzyrea      tricky
14:43 vfernandes    https://catalogo.biblioteca.uab.pt/cgi-bin/koha/opac-detail.pl?biblionumber=39375
14:44 vfernandes    I have a 300 field note filled, the system preference NotesBlacklist is set to "300"... MARCNOTES is empty, so biblio.notes is shown instead
14:50 wizzyrea      that seems like a bug, that you can't blacklist biblio.notes
14:57 wizzyrea      cait about?
15:02 wizzyrea      https://css-tricks.com/responsive-data-tables/ I like this
15:02 wizzyrea      oleonard ^
15:02 wizzyrea      because you are not busy enough
15:02 wizzyrea      kekekeke
15:02 wizzyrea      I tease
15:04 oleonard      We actually do a variation of that in the OPAC ...which could be improved
15:04 wizzyrea      I want to see it on those tables in the intranet that don't smush
15:04 oleonard      See the holdings table on opac-detail
15:04 oleonard      Yeah of course
15:05 wizzyrea      i mean so many things to fix >.<
15:11 oleonard      Bug 15326 is making good progress. Still needs work, but getting a lot closer.
15:11 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 new feature, P5 - low, ---, aleisha, Failed QA , Add CMS feature
15:12 wizzyrea      YASS
15:12 * oleonard    hates to keep throwing it back when it has already taken so long, but...
15:12 wizzyrea      *nod*
15:18 wizzyrea      hm I dn't get any errors from the QA tool for that patchset?
15:18 wizzyrea      on the CMS?
15:21 ashimema      awesome oleonard__
15:21 ashimema      awesome oleonard++ even
15:21 pastebot      "oleonard" at 127.0.0.1 pasted "15326 QA tool failures" (29 lines) at http://paste.koha-community.org/2625
15:25 ashimema      think those are all false failures
15:26 wizzyrea      well those are new .pm
15:26 wizzyrea      so if they don't have POD
15:26 * ashimema    sort of wants to fix those but has been warned not to before by Joubu for some reason.. can't remember why
15:26 wizzyrea      that's probably not great?
15:26 ashimema      think it's basically just very hard to fix
15:26 wizzyrea      it's not like they are less because they removed a sub or something
15:27 ashimema      It's worth checking they have POD.
15:27 ashimema      but they may well do.. that failure will still be there I think
15:27 ashimema      unless my memory is serving me wrong
15:27 wizzyrea      though I'd have to read how it comes to the conclusion that it's lesser coverage than before
15:27 wizzyrea      because uh, how could it possibly be less on a new .pm?
15:27 ashimema      maybe my memory is entirely failing me
15:29 wizzyrea      omg I amust be very dense where do you even add pages
15:31 oleonard      Tools -> Pages
15:32 wizzyrea      well that is 100% not there
15:33 * wizzyrea    resets the things
15:34 magnuse       \o/
15:38 * oleonard    fakes his own death and starts a new life in Idaho o/
15:39 wizzyrea      I... what why
15:39 oleonard      I was resetting all the things?
15:39 wizzyrea      ohhh
15:39 wizzyrea      well idaho is supposed to be under like 3 feet of snow soon
15:39 reiveune      bye
15:39 wizzyrea      or something
15:39 wahanui       something is probably broken
15:39 wizzyrea      bye
15:39 wizzyrea      ooh just caught him yess
15:40 oleonard      Ha
15:49 wizzyrea      @seen mtompsett
15:49 huginn`       wizzyrea: I have not seen mtompsett.
15:49 wizzyrea      o rly
15:49 wizzyrea      @seen mtompset
15:49 huginn`       wizzyrea: mtompset was last seen in #koha 6 weeks, 6 days, 11 hours, 25 minutes, and 53 seconds ago: * mtompset collapses asleep.
15:50 wizzyrea      gosh I hope he didn't collapse and not wake up :(
15:54 wizzyrea      there it is jeez
15:56 wizzyrea      man I'm gonna need a cookie or something before i test this
16:06 ashimema      lol
16:06 * ashimema    sends a bag of double chocolate chip cookies wizzyrea's way
16:06 wizzyrea      golly thank you
16:14 oleonard      I'm working from home all this week (which is unusual for me), and the temptation to go and make cookies is STRONG
16:15 ashimema      do it, do it...
16:15 * ashimema    chants in a teenage peer pressure manor
16:21 * oleonard    saves all his idle time for petting the cat
16:32 ashimema      good plan
16:33 wizzyrea      no no you see
16:33 wizzyrea      if you make the cookies
16:33 wizzyrea      then while they are baking
16:33 wizzyrea      you pet the cat
16:34 wizzyrea      multitasking!
16:34 wizzyrea      more task layering I guess
16:37 wizzyrea      hi cait
16:37 * cait        waves
16:38 * oleonard    , mixing cookies, shouts "Alexa, fix Bug 14907!"
16:38 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 normal, P5 - low, ---, koha-bugs, NEW , Item search: Call Numbers in Item search results are ordered alphabetically
16:41 cait          lol
16:41 cait          if it was just that easy
16:42 ashimema      hehe
16:42 cait          but i would be slightly worried about her code
16:42 cait          calling home
16:42 ashimema      It's school hols here.. I'm so tempted to hollar 'Isobel fix...'
16:43 wizzyrea      Isobel is a pretty name
16:43 ashimema      but I've not got a bug to hand I can give her yet
16:43 ashimema      shout if you have a bug a 10 year old can takle.. she's done a couple already.. mostly string changes. I think she wants a small step up :)
16:44 wizzyrea      aw my kiddo is 11
16:44 cait          i'll keep it in mind!
16:44 ashimema      Don't think Amelia is up to it yet though.. she's only 4.. wow how the years fly by
16:44 cait          true
16:44 cait          she got one of the first onesies
16:45 cait          hay_fever--
16:47 ashimema      🙂 She did.. and I still have it in a memories box :)
16:48 ashimema      Time for tea.. back in a bit..
16:48 cait          aaw :)
17:04 cait          wizzyrea: oops
17:04 cait          were you just testing bug 22069?
17:04 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 normal, P5 - low, ---, koha-bugs, Needs Signoff , Log viewer not displaying item renewals
17:04 cait          i just changed the patch slightly
17:04 wizzyrea      i was
17:04 wizzyrea      which one do you like better?
17:05 wizzyrea      if your two
17:05 wizzyrea      the one I signed off works for all cases
17:05 wizzyrea      do you have a preference?
17:06 cait          I am not sure about yours
17:06 cait          i think th eline is not needed
17:06 wizzyrea      no no yours is better
17:06 wizzyrea      ignore mine
17:06 cait          i think RENEW will already be in actions
17:06 wizzyrea      it doesn't seem to be because it works when that's in there, but it doesn't when it's not
17:07 cait          i just removed the circulation condition... it won't hurt if it's added becuase it will still limit by module
17:07 wizzyrea      but anyway yours does work
17:07 cait          it's strange enough that bug was never noticed
17:07 wizzyrea      well renewal log is default off
17:07 wizzyrea      do you like your 2nd patch better?
17:08 wizzyrea      third patch I guess
17:08 cait          yep
17:08 wizzyrea      ok :)
17:08 cait          third was just a change on commit message
17:09 cait          wizzyrea++ thx for testing
17:10 wizzyrea      no worries, better to get them turned around while people are still thinking about it
17:10 wizzyrea      (and yes I honestly did test it on all three patches)
17:19 cait          oleonard++ wizzyrea++ # permissions bug
17:21 cait          wizzyrea: could you maybe look into bug 22626 too?
17:21 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 normal, P5 - low, ---, oleonard, Needs Signoff , 'Filter paid transactions' broken on Transactions tab in staff
17:22 wizzyrea      sure
17:25 wizzyrea      well that was easy to test :P
17:27 oleonard      wizzyrea++
17:27 wizzyrea      so cait
17:27 wizzyrea      on 22357
17:28 * oleonard    does a double-take because he's working on 22537
17:28 wizzyrea      does there maybe need to be another data structure for the saved results
17:28 wizzyrea      that's independent of the reports themselves?
17:30 wizzyrea      oleonard, on 3766 i think we should make another bug for roads
17:30 wizzyrea      :P
17:31 wizzyrea      and keep this one for streets
17:31 wizzyrea      or cities
17:31 wizzyrea      i mean
17:31 oleonard      I'd certainly be fine with that
17:34 wizzyrea      k done bug 22673
17:34 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22673 minor, P5 - low, ---, koha-bugs, NEW , Road types only on one address
17:36 wizzyrea      right and commit message on that cities/town patch tidied up as well
17:41 oleonard      Thanks wizzyrea
17:59 wizzyrea      I feel like bug 16357 actually works
17:59 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 normal, P3, ---, mtj, Failed QA , Plack error logs are not time stamped
18:00 wizzyrea      but it's hard to get people to test that
18:00 wizzyrea      @kidclamp maybe you or khall want to have a go at testing that? or get larry to
18:00 huginn`       wizzyrea: I suck
18:00 wizzyrea      er no, I think it's me huginn`
18:04 * cait        checkes the queue and gasps
18:04 cait          i had that under 70 *grump* heh
18:04 cait          but kidclamp's is going up too
18:05 wizzyrea      yeah exactly
18:05 cait          wizzyrea: i keep throwing things at you... bug 17674 missed last release... I'd still like to have that
18:05 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 enhancement, P5 - low, ---, charles.farmer, Needs Signoff , Allow UI to delete serials issues in batch
18:05 wizzyrea      ohhh
18:05 cait          just throw them back if you need me to stop
18:05 wizzyrea      no no
18:05 wizzyrea      this is what I do :)
18:07 wizzyrea      it's good because I have a very linear way of going about the signoff list
18:07 wizzyrea      and I'm happy to look at people's pets
18:07 wizzyrea      pet bugs I mean
18:07 wizzyrea      also pets but I meant pet bugs.
18:08 oleonard      I'm happy to look at people's pets too
18:10 lukeG         oleonard: UI designer/moonlighting veterinarian
18:10 * wizzyrea    is an expert patter
18:10 * wizzyrea    is super good at patting peoples pets.
18:11 oleonard      lukeG: Definitely only in the pet-appreciation sense
18:11 cait          i like cats?
18:11 cait          *feels the group pressure*
18:12 oleonard      https://zivotdesign.com/p/view.php?p=15548334871129
18:12 cait          aaaaaw
18:12 cait          what do you need me to stamp pqa?
18:12 oleonard      I'll even look at people's actual pet bugs if anyone has one.
18:13 wizzyrea      https://scontent-dfw5-2.cdninstagram.com/vp/c26bfb2cc6318280d6547e173cb3e211/5D3B35DB/t51.2885-15/e35/51023181_251913825723318_8328281837321601293_n.jpg?_nc_ht=scontent-dfw5-2.cdninstagram.com
18:13 wizzyrea      terrible link I hope it works
18:13 wizzyrea      is my poochie <3 <3 <3
18:14 oleonard      Sweet dragon rider
18:16 oleonard      Another one: https://zivotdesign.com/p/view.php?p=15548337517690
18:16 wizzyrea      awwwwwwww
18:16 wizzyrea      i think your cat might be broken though
18:17 oleonard      I think my cat is still under warranty... Maybe when they fix him they can make him nice
18:17 wizzyrea      oh snap
18:19 cait          oleonard: don't say that.. i've got tons of pet bugs
18:20 oleonard      cait: Tarantula? Hissing cockroach?
18:20 cait          maybe 22601? looks like some kind of insect
18:22 wizzyrea      tfw setting up test cases feels buuurdensooomeeee
18:22 wizzyrea      it isn't of course
18:22 * oleonard    sees if he can revive Bug 21891
18:22 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 normal, P5 - low, ---, oleonard, ASSIGNED , Remove non-XSLT detail view in the staff client
18:22 wizzyrea      it just feels that way
18:23 cait          that's a good one too
18:23 * cait        pats it
18:31 * cait        wonders if someone else thinks 'Payment, thanks' is odd
18:31 cait          why the thanks? i mean we are polite... but
18:31 oleonard      Yes, odd.
18:32 cait          can we kill it? the three of us? :)
18:32 oleonard      No one will ever find out!
18:32 cait          hehe
18:32 cait          i thought of us as a super hero team, but maybe we are villains
18:32 cait          superlibrarians of the dark side
18:36 cait          bug 22647
18:36 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22647 enhancement, P5 - low, ---, koha-bugs, NEW , Copy number should increment similar to barcode
18:43 cait          hm
18:43 cait          not that one
18:43 cait          22674
18:44 cait          bug 22674
18:44 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 enhancement, P5 - low, ---, koha-bugs, NEW , Change wording of payments in the GUI
18:46 wizzyrea      ok devil's advocate there
18:46 wizzyrea      it is extremely common to put thanks on receipts and things in the US - and maybe I'd leave that thanks on in the OPAC
18:46 wizzyrea      as the patron sees it
18:46 wizzyrea      but it makes not a lot of sense in the intranet
18:47 cait          but it's in a table
18:47 cait          and not on a receipt
18:47 wizzyrea      do we show the payment note thinger to the patron in the OPAC?
18:47 * wizzyrea    looks
18:47 cait          payment note? i am not sure
18:48 cait          i think i have removed the thanks in trnaslation, germans are not so nice :P
18:48 cait          or it might just be me
18:49 wizzyrea      We do show that in the OPAC
18:49 cait          hm?
18:49 wizzyrea      the payment note
18:49 wizzyrea      Payment, thanks
18:50 wizzyrea      so patrons do see it
18:50 cait          ah, i think we were talking different things
18:50 wizzyrea      could*
18:50 cait          there is a note field for payments too
18:50 cait          that's description
18:50 wizzyrea      well that's what I mean
18:50 cait          yep
18:50 wizzyrea      the description shows
18:50 cait          yes
18:50 cait          there are like 3 includes
18:51 cait          that translate the codes into what shows there i think
18:51 wizzyrea      I can 100% see that some places might not like that verbiate
18:51 cait          so we could make it different for opac and staff
18:51 wizzyrea      verbiage
18:51 * wizzyrea    ponders
18:53 cait          wizzyrea: different question, code for bug 3766 is still the same, right?
18:53 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 enhancement, P5 - low, ---, oleonard, Signed Off , Cities/Towns only on one address
18:53 wizzyrea      that's right
18:53 cait          because was almost finished testing yesterday :)
18:53 cait          ok
18:54 cait          that will speed things up a bit :)
18:54 wizzyrea      yeah I just split off the roads as there was nothing done for roads in there
18:54 wizzyrea      and put it in a new bug
18:54 wizzyrea      and changed the title and the commit message
18:54 cait          yep, fine with that
18:54 wizzyrea      the original note references the roads but whatever
18:55 cait          it#s a real old bug, i think this is nice already as is
18:55 wizzyrea      yeah I have a strong suspicion that NZ might be one of the few places to have/commonly use the road types
18:56 wizzyrea      (in koha, everywhere has road types)
18:56 cait          they don't really make sense here
18:57 wizzyrea      i mean to take the time to set up an authorised value to have them be consistently entered
18:57 cait          Herosestraße
18:57 cait          straße = street
18:57 cait          it's part of the name, not separate
18:57 wizzyrea      yeah that wouldn't make a lot of sense in german
18:57 cait          becuase we Germans like to glue everything together
18:57 wizzyrea      i like it
18:57 cait          i tihnk in france it works too
18:57 cait          i seem to remember having been told that at laest
18:58 wizzyrea      for some reason in nz they really like having the street number and the street name and the street type separate
18:58 cait          ourlong words often create issues
18:58 cait          like tables being too small etc. becuase the browser can't break them over multiple lines like it works with English
19:00 wizzyrea      yeah
19:07 cait          nooo...
19:07 cait          no more pet pics :(
19:08 wizzyrea      oh well
19:08 wizzyrea      I have more pictures :P
19:08 wizzyrea      https://scontent-dfw5-2.cdninstagram.com/vp/a432f9ed95f8040471ac184e3db47963/5D3D0DFF/t51.2885-15/e35/26364244_1371252936316564_4015456218855243776_n.jpg?_nc_ht=scontent-dfw5-2.cdninstagram.com
19:10 wizzyrea      https://scontent-dfw5-2.cdninstagram.com/vp/f73e0915e410dffe11685f2046af3e3b/5D340BBE/t51.2885-15/e35/43205967_749885055345637_5167453737979686448_n.jpg?_nc_ht=scontent-dfw5-2.cdninstagram.com
19:11 cait          do you have cats too? ;)
19:11 wizzyrea      hm yes but he is hidey
19:12 oleonard      I like that smiley one wizzyrea
19:13 wizzyrea      he has the funniest underbite
19:26 ashimema      I've always felt the thanks in payment was weird.. we get rid in British English mostly for customers too
19:26 ashimema      Me just spent the last 20 mins reading back
19:29 wizzyrea      I see that construction pretty often on things like account pages for say, phone bills
19:29 wizzyrea      but it doesn't hurt anything to get rid of it
19:31 oleonard      I see a lot of instances of "return -1" in Koha code. Is that a Perl way of saying "return false" or is it more complicated than that?
19:38 ashimema      Haha
19:39 ashimema      Actually return -1 will equate to Boolean true
19:39 oleonard      Why use -1 ?
19:39 ashimema      Really depends on what routines/methods your looking at
19:39 ashimema      Why not 😉
19:39 ashimema      Returns should be meaningful
19:41 ashimema      So as long as the meaning of -1 is documented (I bet it's not) for the routine then it is perfectly acceptable.. if it's not documented it feels somewhat random and fraught will peril changing it just in case something expects it to be returned that way
19:42 ashimema      I'm a fan of explicit returns at least.. All subs return something.. even if there's no 'return $thing' line
19:42 ashimema      They default to.returning the result of the last thing they processed
19:43 cait          which can be hard to spot
19:43 * cait        likes explicit too
19:44 wizzyrea      cait do you have a GDPR feeling about bug 12532
19:44 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 new feature, P5 - low, ---, charles.farmer, In Discussion , Redirect guarantee email to guarantor
19:44 ashimema      Yup
19:44 cait          ah, explicit, not gdpr
19:44 cait          i hope it's optional?
19:44 wizzyrea      it is
19:44 ashimema      Lol, yes
19:45 cait          we don't really use guarantors right now in terms of family accounts, so not a real strong feeling
19:45 cait          i am not sure if that is a comomn thing in public libraries here or not, I haven't seen it so far
19:45 wizzyrea      what about the "we don't tell guarantees that their guarantor gets their notices" thing
19:45 ashimema      Optional at the gauruntee end or just as a pref for staff
19:45 wizzyrea      i'm just trying to make sure i'm not being a willful curmudgeon
19:46 wizzyrea      i mean I kinda am but also mostlynot
19:46 ashimema      Hehe
19:46 cait          is it per patron or global?
19:46 wizzyrea      it's global
19:46 wizzyrea      which I don't like
19:46 wizzyrea      and the guarntee can't opt out
19:46 wizzyrea      guarantee*
19:46 ashimema      I have no idea how gdpr treats 'minors'
19:46 ashimema      That's effectively what were talking about in the majority case here isn't it
19:47 wizzyrea      well theoretically
19:47 wizzyrea      did we ever get the ability for any patron to have a guarantor?
19:47 wizzyrea      I didn't chase it up but I know it was a huge long bug for a while
19:47 ashimema      Mmm, I don't like that its global..
19:47 oleonard      I don't think so wizzyrea
19:47 cait          wizzyrea: patches around for that, but not in i think
19:47 wizzyrea      that's good that makes it easier to swallow
19:47 ashimema      But.. if the whole idea is that all gauruntees are also minors then it sort of makes sense to me..
19:47 cait          there is also a big patch in my qa that kind of rewrite the guarantor system
19:47 cait          from kle
19:47 cait          kyle
19:48 wizzyrea      but yes the majority case is that they'd be minors
19:48 wizzyrea      but I don't like that we don't tell them
19:48 cait          allowing guarantors that are nt patrons
19:48 cait          i tihnk
19:48 cait          one of the more scary patches i haven't worked up to yet
19:48 cait          i'd like a note somewhere
19:48 cait          and also per user instead of global
19:48 cait          like we have the 'can see tihngs in opac' maybe?
19:48 wizzyrea      ah bug 12446
19:48 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 enhancement, P5 - low, ---, charles.farmer, Failed QA , Enable an adult to have a guarantor
19:49 wizzyrea      is the one I was thinking of
19:50 wizzyrea      gonna guess
19:51 wizzyrea      big leap
19:51 wizzyrea      same company, same client
19:51 ashimema      Lol
19:51 wizzyrea      they need these functions
19:51 * ashimema    wonders about the use cases..
19:51 wizzyrea      an organisation can guarantee a professional?
19:52 wizzyrea      you have a group of teachers in a building
19:52 wizzyrea      you want to see what all of those teachers have checked out
19:52 * oleonard    made some progress on Bug 22659
19:52 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 enhancement, P5 - low, ---, oleonard, ASSIGNED , Add 'save and continue' functionality to news editor
19:52 wizzyrea      guarantor/guarantee would make that easy
19:53 wizzyrea      (and those are just the ones I've had librarians ask me about in the past)
19:53 wizzyrea      "can I..."
19:53 cait          i am little worried about the conflicts with
19:53 cait          bug 14570
19:53 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 enhancement, P5 - low, ---, kyle, Signed Off , Make it possible to add multiple guarantors to a record
19:53 wizzyrea      ew yeah that could get gross
19:54 wizzyrea      should we let them know they are in danger of having to rewrite the whole thing?
19:54 cait          hard to tell how we shoudl do it right
19:54 cait          all are kinda old
19:54 wizzyrea      yeah
19:57 cait          wow
19:58 cait          nso is below 200
19:58 cait          last time has been a while ago
19:58 * oleonard    had never tried enabling notice translation before reading cait's comment on Bug 22663
19:58 huginn`       Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22663 enhancement, P5 - low, ---, koha-bugs, NEW , Improve usability of 'display location' pull down in news editor
19:59 cait          oleonard: we got a lot of multi-lingual libraries
19:59 oleonard      I'm just surprised I'd never turned it on.
20:00 oleonard      I think doing the same for news is a good idea
20:02 oleonard      Okay, that's it for me. See y'all later
20:03 cait          one day... i will manage to say bye to oleonard
20:56 * cait        waves at kathryn
20:57 wizzyrea      hi kathryn
20:57 kathryn       hi wizzyrea and cait :)
20:58 ashimema      nighty night koha
21:04 cait          good night ashimema
21:25 wizzyrea      later friends