Time Nick Message
20:02 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 enhancement, P5 - low, ---, nick, Signed Off , Allow automatic update of location on checkin
20:02 alexbuckley so it does look like a commit message problem like you say. when you say 'Hayley's seems to want us to test the 2 sysprefs?' do you mean your taking it that hayley wants you to test the 2 sysprefs in bug 14576?
19:51 alexbuckley not a problem :)
19:48 wizzyrea cool thanks very much I felt terrible failing it :(
19:47 alexbuckley ah yes, i'll look at the bug report and refresh my memory on whats happening
19:45 wizzyrea (i know it's saturday and you're probs busy with trip prep and such)
19:44 wizzyrea with the patches
19:44 wizzyrea there's something funny going on there
19:44 wizzyrea you might have seen my comment on 21159?
19:43 wizzyrea while you are here
19:43 wizzyrea oh
19:43 wizzyrea yep
19:43 alexbuckley :)
19:43 alexbuckley its good that his school over there is nice
19:43 wizzyrea he seems to be doing alright
19:42 wizzyrea kids not nice.
19:42 wizzyrea his last nz school was :( :( :(
19:42 wizzyrea (it was my fav)
19:42 wizzyrea (LB probs always be a fav)
19:41 wizzyrea he likes the lunches, and it's running 2nd favourite school behind Lyall Bay
19:41 alexbuckley yeah :) How is spud finding American schools?
19:40 wizzyrea enormous trip how exciting
19:39 wizzyrea the rest... eh
19:39 wizzyrea work is lovely :)
19:39 alexbuckley pretty good thanks 9 days to go, we've got a team lunch on friday before I go, and i fly to Auckland on sun :) How are you going?
19:37 wizzyrea how doin
19:37 alexbuckley hey wizzyrea :)
19:35 wizzyrea and aleisha :P
19:35 wizzyrea er alexbuckley
19:35 wizzyrea hi aleisha
19:11 wahanui bidet, wizzyrea
19:11 wizzyrea hi
19:02 oleonard Bye all. Happy weekend
16:22 ashimema happy birthday chap
16:21 * ashimema wonders how eythian will be celebrating this evening
16:13 * eythian -> brewery
16:13 eythian (it's also pretty nice.)
16:13 ashimema oh wow
16:12 eythian The first review it shows me says "An outstanding way to drink tea", so...
16:11 eythian ashimema: this is sometimes brewed somewhere over your way: https://www.ratebeer.com/beer/yeastie-boys-gunnamatta/173556/
16:10 * ashimema thinks about swapping tea for beer..
16:10 * ashimema goes to get tea..
16:09 cait lol
16:09 * eythian is more likely to succeed.
16:09 * eythian wants a beer.
16:09 * ashimema wants database polymorphism
16:08 eythian that code was (probably still is) a bit nightmarish.
16:08 ashimema the two things need distinctly different information
16:08 * ashimema is getting dangeriously close to say.. Would anyone mind if I split accountlines down the middle and created two tables instead of one.. one for credits one for debits?
16:07 eythian *time. Dunno about tim.
16:07 ashimema been there,
16:07 eythian ashimema: Re: HashRefInflator, I think if you're doing the full ORM thing then you can't use it, however if you're querying for a lot of data then it's almost certainly worth using it to just fetch the data then process. Otherwise it'll cost you real tim.
16:07 ashimema yikes.. oh yes
16:07 oleonard :D
16:07 cait oleonard: that might be on some Koha things
16:07 corilynn right? and music authorities a hundred times so
16:06 * ashimema hands corilynn the swear tin just in case.. that's usualy where I end up if I'm *seriously* deep in authorities ;)
16:06 cait oleonard: vacation = can spend more time lke I please... :D
16:05 ashimema this cycle felt a little slow to start with... but it's certainly going full throttle at the moment
16:05 corilynn although, I'm *seriously* deep into authorities now too
16:05 corilynn I try and stick to my perview, the cataloging interface
16:04 ashimema those queus gotta keep growing.. we wouldn't want kidclamp bored now would we ;)
16:04 oleonard Sign-offs are always good corilynn. Just pretend the QA team doesn't have feelings!
16:03 ashimema hehe
16:03 corilynn which only make more work, but I've done a lot of "not sign-offs" too
16:03 corilynn unfortunately, my tuits currently come in sign-offs
16:03 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 enhancement, P5 - low, ---, carnold, Signed Off , Advanced editor - Rancor - add ability to edit records in import batches
16:03 oleonard Bug 18823
16:03 corilynn let me know what kind of tuits I can help with?
16:02 * ashimema is running low on QA tuits at the moment... :(
16:02 corilynn I *know* there's a lot in QA, I just want to *bump* OR... at least know if there's something that's going to keep it from going before it's too late to make the next cycle
16:01 corilynn I used it quite a lot
16:00 corilynn I've signed off on it, my company has sponsered it
16:00 wizzyrea quite a lot in that state atm
16:00 corilynn it needs QA
15:59 wizzyrea or retesting? or
15:59 wizzyrea what it needs QA or something?
15:56 corilynn yeah, tried to make it this time.. but family stuff... I want to *somehow* get 18823 some lovin'
15:55 ashimema I personally like to read the whole log.. but you may prefer the summary version
15:55 corilynn thx, thx, ashimema
15:55 ashimema pick from the one's at the top..
15:54 ashimema http://meetings.koha-community.org/2019/ corilynn
15:54 ashimema no offence intended
15:54 corilynn thank you!
15:54 ashimema queue tcohen, kyle and josef :)
15:54 oleonard corilynn: https://wiki.koha-community.org/wiki/Development_IRC_meeting_27_March_2019
15:54 ashimema haha..
15:54 ashimema I reckon it probably needs a team effort from some people overly familiar with accounts...
15:53 corilynn can someone point me to the dev meeting notes from wednesday? I swear I searched...
15:53 wahanui something is broken
15:53 wizzyrea or something.
15:53 wizzyrea well, the devil you know.
15:53 kidclamp :-D
15:53 ashimema there's allot of code pathss :(
15:53 kidclamp I know it is coincidence, but when your script fails to compile because of line 666 still a bit scary
15:52 * ashimema has been working hard the last few months to attempt to get to that level of coverage here.. but bets he hasn't reached it
15:52 ashimema my hope is that the tests cover the vast majority..
15:52 ashimema it is indeed a bit big and scary
15:50 wizzyrea hehe
15:50 wizzyrea because that will take Some Time.
15:50 wizzyrea which is why I asked lol
15:50 wizzyrea that is about the scope of stuff I thought might be in that
15:50 ashimema no worries..
15:49 wizzyrea I had my head in a patch sorry
15:49 wizzyrea no no
15:49 wizzyrea oh
15:49 * ashimema hopes not
15:49 * ashimema thinks he broke wizzyrea..
15:48 ashimema I can't easily split it down into smaller chunks :(
15:48 ashimema there's allot there :'(
15:48 ashimema my-oh-my!
15:48 ashimema enrolement fees
15:48 ashimema manual invoices, manual credits
15:47 ashimema Doing some SIP translactions (checking that interface gets set to SIP for those)
15:47 ashimema payments and open/closed days combinations to catch the 'credit creation' route).. Making reserverse (again with the sysprefs set for charging for that).. from both OPAC and Staff side to check the interface gets set correctly..
15:47 ashimema it's going to involve things like marking items as lost (with both values for the processing fee options.. to check 'chargelostitem'), returning a lost item (with and without already having made payment to check _FixAccountForLostAndReturned), checkout items with issuing charges (checking AddIssuingCharge), doing some offline transactions and uploading them (checking 'ProcessOfflinePayments').. testing Overdues (again with and without partial
15:43 ashimema want me to try and work out a step-by-step plan ?
15:43 ashimema we touch literally everything that would work with accountlines
15:43 ashimema If we want a good thorough testing there's likely to be a fair amount of excersize
15:42 ashimema :doh:
15:42 ashimema I didn't write a test plan did I..
15:41 ashimema well.. not always always ;)
15:41 * ashimema is still here.. always lurking
15:41 ashimema hi wizzyrea
15:32 huginn` wizzyrea: The operation succeeded.
15:32 wizzyrea @later tell ashimema I was looking at your bug 22600, had some questions re: testing (the unit tests pass you'll be happy to know)
15:28 liliputech_asu I guess you could embed some .mo/.po within the kpz file. don't know how you can call them though.
15:27 wizzyrea ashimema about?
15:26 liliputech_asu yup, plugins translation is an issue, I got the question for my own work but didn't had the time to look after this yet
15:25 liliputech_asu + there's already a comment system which means people can rate plugins, it's already designed.
15:25 kidclamp and they need to be translatable
15:25 oleonard plugins require a lot more vetting than reports
15:24 wizzyrea maybe.
15:24 liliputech_asu + it's already interfaced with Koha (starts 19.05)
15:24 liliputech_asu What about hosting them on Mana? it's already a central community sharing platform...
15:20 wizzyrea there are other ideas.
15:20 wizzyrea instead of svn
15:20 wizzyrea but using git
15:20 wizzyrea I want one like the wordpress plugin directory
15:20 wizzyrea yep it's a think we all want but can't agree on how best to go about it
15:19 liliputech_asu couldn't find a place where I could list them all...
15:18 liliputech_asu one thing is definitely missing though: plugins marketplace / database / store / whatever you call it...
15:13 liliputech_asu lulz
15:11 wizzyrea it's a nightmare.
15:11 wizzyrea and I've implemented or helped to implement almost every janky 3rd party integration that exists.
15:11 wizzyrea yep I've worked for Koha vendors.
15:10 liliputech_asu many third-party service vendors also do it in a different way, while studying products for recommendations, I've stumbled into Syndethics, and they don't offer a plugin. they ask you to add something in your JS (like Matomo) which queries their website for further executable code.
15:09 oleonard Tell it to EBSCO I guess
15:08 liliputech_asu *see how many
15:08 liliputech_asu hum... being a vendor I'd say it's in your interest to make yourself "usable" from other platforms. See how may payment processors have a plugin designed for wordpress for example.
15:00 wizzyrea it also makes sense to push dev of those features back onto the vendor, but I can't see them supporting their own product in that way.
14:57 wizzyrea book cove.rs, mmm I'm not sure
14:57 wizzyrea there are some things where plugins make sense - overdrive, recorded books, ebsco, those things make sense
14:56 liliputech_asu maybe not their priority to keep up-to date with koha?
14:55 wizzyrea I've worked with the EBSCO plugin, they have enough trouble keeping it up to date and they have billions of dollars at their disposal.
14:54 liliputech_asu huuuu... but less incursion of proprietary service into Koha Core code. less dependency to third-party service. wouldn't that be nice?
14:52 wizzyrea mostly its the peoplepower issue.
14:52 liliputech_asu meh.
14:52 * wizzyrea snickers
14:52 * oleonard has been hearing all about this new GPL thing lately
14:52 liliputech_asu Agree that maintaining a plugin often relies on less people than whole koha community.
14:51 liliputech_asu plugins must be open-sourced as well since they use Koha code and Koha is GPL :)
14:50 liliputech_asu why would it be harder than maintaining those features in Koha itself?
14:50 wizzyrea this appeals to me but might be a maintenance nightmare
14:49 oleonard It occurs to me to wonder if we should move every feature which depends on a proprietary service into a plugin... Amazon covers, Syndetics, iDreamBooks...
14:49 liliputech_asu that's what I did for my Opac plugin, works like a charm : http://github.com/liliputech/koharecommenderengine
14:48 wizzyrea sure
14:48 liliputech_asu you can actually have a kpz install jquery things into opacuserjs and intranetuserjs
14:47 liliputech_asu kpz plugins powa.
14:42 wizzyrea naw
14:41 magnuse ah, so not a .kpz plugin?
14:41 oleonard magnuse: Star ratings always depended on a jquery plugin. The old plugin was not maintained.
14:40 magnuse star ratings are being turned into a plugin?
14:40 wahanui que tal, wizzycray
14:40 wizzycray hi
14:40 oleonard I wondered. I sent you some secret codes. They were probably intercepted by the Chinese government
14:39 wizzyrea no!
14:39 oleonard Did you get my message about it the other day?
14:38 * wizzyrea shakes fist
14:38 wizzyrea lulz bc he had the creds already >.>
14:38 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 normal, P5 - low, ---, oleonard, Signed Off , Star ratings plugin replacement missing from a couple pages
14:38 oleonard wizzyrea: kidclamp beat you to it. Bug 22432
14:37 wizzyrea but I can't find it
14:37 wizzyrea oleonard, you had a bug that was to do with overdrive and recordedbooks
14:35 wizzyrea i.e. they'll still work
14:34 wizzyrea and I feel quite confident that if the files are getting copied correctly *now* (they are) this patch won't change it
14:33 wizzyrea and use the instance paths instead of the standard install ones
14:33 wizzyrea you just have to play by debian's rules
14:33 wizzyrea the patch works! it does!
14:33 * magnuse wishes for timestamps too
14:30 koha-jenkins Project Koha_Master_D8 build #206: FIXED in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/206/
14:30 koha-jenkins Yippee, build fixed!
14:29 koha-jenkins Project Koha_Master_U18 build #193: STILL UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_U18/193/
14:29 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 normal, P3, ---, mtj, Failed QA , Plack error logs are not time stamped
14:29 ashimema bug 16357
14:26 wizzyrea I wished for time/date stamps in that log for so long
14:26 wizzyrea also is there work to be done with those dependencies?
14:25 wizzyrea i'll sign off, I made it work but it wasn't automatic
14:25 wizzyrea tcohen and/or kidclamp, what do you think about bug 16357? how much more testing do you think that needs?
14:23 koha-jenkins Project Koha_Master_D9 build #700: SUCCESS in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/700/
14:22 * oleonard wonders if cait got that vacation approved by kidclamp
14:22 wizzyrea but I guess we need to check that it works just fine when an instance is created
14:21 wizzyrea i've made it work
14:21 wizzyrea i mean,
14:21 wizzyrea !
14:21 wizzyrea cait! holiday
14:21 cait bye all!
14:21 wizzyrea i'm not sure how best to test that
14:21 * cait goes vacation
14:21 ashimema cookies :)
14:21 wizzyrea I'd loooove to get that signed off but
14:21 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 normal, P3, ---, mtj, Failed QA , Plack error logs are not time stamped
14:21 wizzyrea did you see bug 16357
14:19 wizzyrea i will have a look
14:18 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 blocker, P5 - low, ---, martin.renvoize, Needs Signoff , We should add an 'interface' field to accountlines
14:18 ashimema bug 22600 would be nice (as the current blocker).. it's big but hopefully obvious and easy to test wizzyrea?
14:18 ashimema 22600 would be nice (as the current blocker).. it's big but hopefully obvious and easy to test?
14:17 ashimema marcelr still around?
14:17 wizzyrea anyone got any passion projects theyd like tested?
14:14 wizzyrea hi everyone
14:14 wizzyrea You are welcome :)
14:09 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 enhancement, P5 - low, ---, nick, Signed Off , Allow automatic update of location on checkin
14:09 oleonard wizzyrea: Thanks for testing Bug 14576. I'm hoping that gets moving
14:09 magnuse Hi wizzyrea
14:08 oleonard Hi wizzyrea
14:04 magnuse see opac/opac-reserves.pl line 539 for an example of this in the wild
14:03 magnuse as far as i can tell
14:03 magnuse if $x is one and both $y and $z is one, $x stays one
14:02 magnuse if $x is one and either $y or $z is zero, $x gets zero
14:02 magnuse if $x is zero, nothings happens
14:01 cait maybe if left true then set to...?
13:59 ashimema huh
13:59 cait ?
13:56 magnuse there are 5 occurrences in Koha
13:56 magnuse very handy
13:56 oleonard-away By Grabthar's Hammer, what a savings.
13:55 magnuse but what if it is: $x &&= $y && $z
13:54 magnuse OK, found this: if ( $x ) { $x = $y } # $x &&= $y;
13:54 huginn` News from kohagit: Bug 19380: Add transfer informations in ILS-DI GetRecords response <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1611c13e85fca43f24a75287b333ff71db2361b9>
13:54 huginn` News from kohagit: Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6666918dd661b0207366becefd1480257197a353>
13:54 huginn` News from kohagit: Bug 13895: (follow-up) Add Modern::Perl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=94206510d7a7641e0e283738f56249c90f7d632e>
13:43 magnuse can someone point me to the meaning of &&= in perl? kind of hard to google. mentioned once in passing in perlop. not in the index of Programming Perl
13:40 talljoy top of the morning to ya
13:40 oleonard Hi talljoy
13:37 talljoy morning
12:54 magnuse nothing useful in the logs
12:49 magnuse liquorice, andreashm!
12:35 magnuse gah! why oh why can't i save 773$t+w? (normarc)
12:27 koha-jenkins Project Koha_Master_U18 build #192: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_U18/192/
12:25 wahanui hi oleopard
12:25 calire hi oleonard
12:25 koha-jenkins Project Koha_Master_D8 build #205: STILL UNSTABLE in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D8/205/
12:17 koha-jenkins Project Koha_Master_D9 build #699: SUCCESS in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D9/699/
11:59 magnuse ashimema: i think maybe ->unblessed is meant to be a temporary thing, until we are ready to use the objects everywhere?
11:58 oleonard Re: [Koha] HEA map broken? ...whispering darkly... Thanos!
11:48 wahanui hi oleopard
11:48 kidclamp hi oleonard
11:46 huginn` News from kohagit: Bug 21646: Clean up Overdrive template <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d635827c541220a21190a26d28740f06e41a9cb1>
11:46 huginn` News from kohagit: Bug 22127: Update date accessioned plugin - remove unused routine <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=68fbc962182cba2c97ac580446513ac542ee631d>
11:46 huginn` News from kohagit: Bug 22518: Remove references to 'O' accounttype <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e8eb0cf0f2ddf6aa741d63e9f4f38241d0c1ecf4>
11:46 huginn` News from kohagit: Bug 22518: Add database update 'just in case' <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c42aa0a53490c2d234742e09336def962e01d96e>
11:46 huginn` News from kohagit: Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7aaa10e0922b21f1c9ed40ede0d3dfc0a63c2832>
11:46 huginn` News from kohagit: Bug 22596: use raw TT filter in items search with custom field <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eb7e0f018c479024f0ceacb9f0c235b556ec2979>
11:46 huginn` News from kohagit: Bug 22518: (QA follow-up) Add rows updated to feedback <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cd4858918f0ad2d6ee512edbf70677b1f62c0685>
11:46 huginn` News from kohagit: Bug 22518: DBRev 18.12.00.036 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=67c99f585c560fc25c7dbd896b9cd4af50f4b11d>
11:32 oleonard Hi all
11:31 ashimema :(
11:31 ashimema it's really nice.. but I think it's another forbidden method in Koha::Object world
11:31 ashimema lol.. I used it loads when writing rebus:list
11:23 eythian I'm in the process of moving all our read processes to it.
11:23 eythian ashimema: I discovered HashRefInflator recently, took the average request time for expensive requests from 5s to 1.25s.
11:14 ashimema 'tis the above bug that got me questioning it.
11:13 ashimema that's precisely the use case for HashRefInflator in DBIx::Class.. "Give me my results fast and skip making an object from them"
11:12 * ashimema see's a patturn all over the place where we build an expensive Koha::Object only to call ->unblessed on it a moment later and then never do anything with the object form again.
11:11 ashimema remind me anyone.. do we use HashRefInflator at all with Koha::Objects?
11:11 kidclamp morning
11:08 josef_moravec by #koha
11:03 marcelr htg now
11:03 marcelr great ashimema++ josef_moravec++
11:01 josef_moravec team++
11:01 wahanui team has karma of 2
11:01 josef_moravec karma team
10:59 ashimema team++
10:58 josef_moravec thanks ashimema
10:58 * ashimema sticks it in a tab to look at
10:58 marcelr hopefully we can have some qa soon
10:57 marcelr thanks josef_moravec
10:57 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 enhancement, P5 - low, ---, m.de.rooy, Signed Off , GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove
10:57 josef_moravec marcelr: bug 21336 looks good for me, signing off
10:44 ashimema hehe.. and thanks for the PQA on 22518.. it'll be so nice to finally clean some of these things up :)
10:42 ashimema the set should be ready again shortly.. just re-running the suit as I said.. then there will be patches incoming
10:42 marcelr np
10:42 ashimema sorry if I waisted some of your time.. I should have gone through and reset them to assigned
10:42 marcelr dont go there anymore :)
10:41 marcelr im out of it
10:41 ashimema so.. hold off there for a few minutes more if you happened to still be walking that tree
10:41 ashimema oh.. marcelr.. sorry.. I'm just rebasing the whole 22008 dependant tree (and updating the tests to as there were a bunch of failures on the branch I missed due to a slip missing the '-r' on running the whole test suit)
09:38 vfernandes hi #koha
08:41 marcelr josef_moravec: 21336 is in nso again
08:22 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 normal, P5 - low, ---, josef.moravec, Needs Signoff , Default value in issues.renewals should be '0' not null
08:22 josef_moravec bug 22607
08:13 * ashimema feels a numpty for not realising he'd only run like 1/4 of the test suit against that one before submitting
08:13 ashimema Ack..I left off the -r when testing the interface addition bug, sorry josef_moravec . I'll be fixing tests this morning
07:56 alex_a bonjour
07:55 cait good morning
07:54 reiveune hello
07:05 josef_moravec marcelr: ah, great!
07:03 marcelr i will have a look at 21336 again
07:03 marcelr hi josef_moravec
07:03 josef_moravec hi marcelr
06:57 marcelr hi #koha
06:52 josef_moravec hi cait
06:52 cait morning josef_moravec :)
06:25 josef_moravec morning #koha
06:16 cait :)
06:15 cait happy bday eythian