Time  Nick          Message
00:03 CrispyBran    bug 21346
00:03 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 major, P5 - low, ---, cbrannon, Needs Signoff , Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
02:25 huginn        News from kohagit: Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4abe3a4082c8fc28b99b2d54825442d2328b4eef>
02:25 huginn        News from kohagit: Bug 21755: Show patron updated date in circ menu <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3e20a2aa2229b6f93bf3ddfae3ff323690c75c2c>
02:25 huginn        News from kohagit: Bug 12258: (QA follow-up) Add some missing rrrrrrs <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a83bc8ca4c15200c7d66a578f37d02095541018f>
02:25 huginn        News from kohagit: Bug 21719: Fix typos <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=543630b3c47322f071875627ea028a187928cdfc>
02:25 huginn        News from kohagit: Bug 21715: Ease translation of account and account offset type descriptions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9670becc164475b57f3258a512d88779c1ead6c3>
02:25 huginn        News from kohagit: Bug 21628: (follow-up) Indentation and filter corrections <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=70f7d801b7337445aa26c63455813b1990edcc90>
02:25 huginn        News from kohagit: Bug 21666: Replace unsupported use attribute with more widely supported attribute <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a08e72c5e72ebbd17cc088584d097ecfa6b1e4d2>
02:25 huginn        News from kohagit: Bug 21628: Simplify holds awating pickup report <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b23e544bd9db0ecaaf07688172e1ebc8da5a49dd>
02:25 huginn        News from kohagit: Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9fb827d59d0421b1f3e2de36239cef4c7411c666>
02:25 huginn        News from kohagit: Bug 21158: Add cronjob references to the system preference descriptions if a cronjob... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=380f1dcbf8d3b8e65a733cc3174b9d0c0a46ab7d>
02:25 huginn        News from kohagit: Bug 21015: fix performance issue with C4::Members <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=83e0765f448c35c6f387d41fe39feb94b9bc64f3>
02:25 huginn        News from kohagit: Bug 21433: Update two-column templates with Bootstrap grid: Tools part 1 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ca1c87c7eee65ca79b52f999213e53f1f0ee32f0>
02:25 huginn        News from kohagit: Bug 20486: Add --marc_conditions option to export_records.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f3c51f99d164a31e10161fdf5d2b80a989735854>
02:57 Guest2299     Project Koha_Master_U18 build #89: STILL UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_Master_U18/89/
02:58 Guest2299     Project Koha_Master_D9 build #600: STILL UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/600/
03:02 Guest2299     Project Koha_Master_D8 build #96: STILL UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D8/96/
06:59 fridolin      hi there
06:59 wahanui       bidet, fridolin
07:00 fridolin      wahanui: fetch me a coffee please
07:00 wahanui       i haven't a clue, fridolin
07:36 reiveune      hello
07:41 josef_moravec morning #koha
07:45 Archie^       Good Morning #koha  !
07:51 alex_a        bonjour
07:51 wahanui       what's up, alex_a
07:52 ere           morning #koha!
07:54 magnuse       \o/
08:25 tuxayo        hi #koha o/
08:26 * andreashm   waves
08:27 * cait        waves back
08:45 andreashm     hi cait
08:46 cait          hi andreashm
08:46 * cait        puts a big cookie jar in the middle of #koha
08:46 cait          this week needs it
08:47 * andreashm   feeds it extra cookies
08:48 tcohen        morning
08:48 andreashm     (some with liquorice hidden in them, for fun effects)
08:48 andreashm     hi tcohen!
08:48 tcohen        wake early to work on things, wait 25 min for macOS upgrade to finish, bummer
08:48 tcohen        hi andreashm
08:48 * ere         tried to grab a cookie, but it was httpOnly
08:49 tcohen        hi ere
08:49 ere           hi tcohen!
08:50 andreashm     ere: haha
08:51 cait          andreashm: salty licorice?
08:51 andreashm     tcohen: bummer indeed
08:51 * cait        hands ere another good cookie
08:51 andreashm     cait: your favorite!
08:51 cait          heh
08:51 cait          i bought some at the airport
08:52 cait          the reactions of the coworkers where very diverse
08:52 andreashm     hahaha
08:52 andreashm     someone liked it? ;-)
08:52 ere           thanks cait :)
08:52 cait          of course, and some hated it :)
08:53 * andreashm   offers some chocolate with liquorice inside
08:53 cait          you swedes are weird :)
08:54 cait          this_new_api_not_koha--
08:54 andreashm     cait: we are indeed
08:54 andreashm     cait: ?
08:54 cait          testing this for months and still find new failing test cases *frustrated*
08:55 tcohen        cait: what are you testing cait?
08:56 ere           andreashm: the liquorice chocolate is surprisingly good, but I still prefer them separately :D
08:56 andreashm     ere: all three combos are good!
08:56 eythian       liquorice chocolate was common in NZ too. Now I've just remembered something I miss.
08:56 cait          the problem is not koha related... just needed to vent a little
08:57 eythian       wonder if I can find it here, they're mad for liquorice but not good at combining things to make them better.
08:57 cait          eythian: but nice to see you around .)
08:57 ere           So, about Koha, anyone feel strongly about the fieldmapping table ("Keyword to MARC mapping" in Administration)? I'm going to propose nuking it..
08:57 eythian       cait: what happened to your eye?
08:58 cait          band aid on one of the finger
08:58 cait          s
08:58 eythian       ah, so you poked your eye with it then
08:59 cait          hard to type :)
08:59 andreashm     eythian: take a trip up north and get some!
09:00 andreashm     ere: I mostly find that one frustrating. Not even sure how it works... =)
09:00 eythian       https://www.rjslicorice.co.nz/products/chocolate-covered-licorice/ I will note that this is from the same town that Koha started in.
09:02 ere           andreashm: It's simply confusing and replacing part of what the framework defines. I'm working on bug 11529..
09:02 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 normal, P5 - low, ---, ere.maijala, ASSIGNED , Add subtitle field to biblio table
09:03 eythian       andreashm: though it'd be a great excuse for a trip to Sweden :)
09:04 andreashm     eythian: yeah, rangi mentioned rjs at kohacon in portland.
09:11 andreashm     looking forward to trying it out in 2020
09:16 cait          ere: our use case would be covered with your new subtitle fields
09:17 cait          ere: not sure if other people put other fields in there... you could
09:17 cait          if you want to make randoms stuff show up with the title ins ome places
09:17 * ashimema    has never really understood what it was for either
09:17 cait          i like the idea, but it was never followed up
09:17 ere           cait: You could still do it with the framework..
09:17 cait          ere: not in a lot of places
09:18 cait          there is more than the normal views :)
09:18 cait          if you take a look at all the places the data from there is shown
09:18 cait          it's mostly about thos eplaces where you get incomplete title information but might need more to tell things apart
09:18 cait          i was tempted to put 773 there... not sure if i have
09:18 cait          because we are really bad in showing the source for analytics in lots of places
09:19 ere           cait: I mean, with what I've done the framework is authoritative and there you could have whatever you want. It would apply wherever the old fieldmapping was previously used and can be easily added to other places too.
09:19 cait          i haven#t taken a look at your patches yet
09:19 cait          i thought it only added fields for the other 245 to the mappable tables
09:19 ere           cait: And we can get rid of a lot of MARC record or framework code retrievals.
09:19 cait          ah, also you can change keyword to marc on the fly... changing ht emappings and updating your data is a pain
09:20 cait          the job we have for that is way too slow
09:21 ere           cait: That's true. The flexibility has a penalty, though. It's awful if you need o retrieve a hundred MARC records just to display a hundred loans in a list.
09:21 cait          yeah there sure is a performance issue
09:21 ere           cait: I can of course take a peek at the job too, perhaps it can be optimized.
09:22 cait          we found it way too sloe for our big dbs last time we changed mappings
09:22 cait          talk.. hours
09:22 cait          but that was a db of about 1.000.000
09:22 ere           cait: The only real downside I can see apart from not being able to change things on the fly is that the dynamic mapping allows different fields for different frameworks.
09:23 cait          also the number of fields in the tables is still limited
09:23 cait          columns I eman
09:23 cait          mean
09:23 cait          i am not sure if there are other use cases
09:23 ere           true, but then the mechanism is not used for anything but subtitle..
09:23 ere           **currently** used
09:35 andreashm     seems like a big set-up for little gain, with the current keywords to marc mappings
09:36 * andreashm   went and looked. we aren't using it at all
09:38 ere           andreashm: heh.. I suppose many don't even realize it's there and since the editing form is also pretty plain with no hints on what can be done, it's not easy to discover.
09:39 ere           I suppose it would be possible to have both mechanisms, but that'd complicate the code
09:49 cait          ere: it's named subtitle - i am afraid people have been creative
09:49 cait          it makes marc show up somewhere
09:50 cait          that give slots of room for fun stuff :)
09:50 cait          i think for killing it, we might wnt to do a mailing list thing
09:56 andreashm     cait: does it actually work for anything else than subtitle? I have a vague feeling we were looking in to it when we migrated, but couldn't get anything other than subtitle working?
09:56 * andreashm   could be totally wrong
09:57 andreashm     ... usually is.
09:58 cait          ther are no other keywords
09:58 cait          but it just makes shows up arbitrary marc fields below the title
09:59 cait          people could have used it for anyhting
10:11 andreashm     yes, of course.
10:11 andreashm     but it seems a kind of roundabout way of doing this.
10:12 andreashm     but since people are sure to be doing some madness, probably good to send a mail to the mailinglist for opinions
10:12 ashimema      cait still here?
10:18 cait          kind of
10:18 cait          putting out fires?
10:18 ashimema      you light some fires have you.. oh dear
10:21 josef_moravec hi andreashm, the problem with the harvester deamon I have is probably because of filesystem permissions when running it on devbox
10:22 andreashm     josef_moravec: ok. strange though, I got it running in portland
10:22 andreashm     using devbox
10:23 josef_moravec look into log, but i had the similar problem when testing itz
10:23 andreashm     which log?
10:23 eythian       I think I once used that keywords thing to do some stuff with custom templates.
10:42 ere           cait: Still, almost all of that can be accomplished by modifying the default framework, you'll just need the batch update done if you change it. I'll post an RFC on the mailing list when I have properly tested what I've done.
10:43 cait          ok
10:47 * ashimema    wonders if josef_moravec has ever considered rmaint?
11:10 ere           cait: huh, the batch update script for the biblio fields is pretty bad.. it has remnants of some old items functionality etc. so it does a lot of useless work. I'll tweak it a bit while at it.
11:10 cait          ere: yeah, i suspected that
11:11 cait          ere: i also think it updates all fields... might be nice to be able to tell it waht to look at to gain some
11:11 cait          like... we want to update stocknumber
11:11 cait          bad example
11:12 cait          ean
11:12 ere           cait: if there was such field..
11:12 cait          both exist
11:12 cait          but stocknumber is in items :)
11:13 cait          we have resused ean for our union catalog record number.... because we need to query it all the time
11:14 cait          kidclamp: do we only ever submit the scss file?
11:14 kidclamp      yes
11:15 cait          my bad, sorry
11:15 ere           cait: uh, right, ean is in biblioitems.. I'm having a bit of trouble to understand why some are in biblio and some in biblioitems
11:15 cait          it was an early frbr like model
11:15 cait          biblio with many biblioitems
11:15 cait          1:n... before marc
11:15 kidclamp      cait: in this case I think the staff global was just a mistake, it should just be removed - the max holds per day i sfailure reason
11:15 cait          now it's 1:1 an dmakes not much sense
11:15 cait          yeah it overlapped
11:15 ere           cait: right, that explains
11:15 cait          lunch time bbl
11:16 kidclamp      also biblioitems used to have the marcxml - was heavier to query and use that, get the basic stuff in biblio
11:17 ashimema      should that be another thing in the qa script.. the inclusion of css changes
11:17 ashimema      scss only now
11:17 kidclamp      there are some files that are css, but the opac and staff-global shouldn't be touched
11:17 kidclamp      it could be, but those just generally wont apply
11:18 ere           kidclamp: ok, thanks
11:18 * ere         is definitely bumping on some archaeological findings
11:18 ashimema      hehe
11:19 ashimema      I know that feeling well ere
11:19 ere           ashimema: it's still good to know that there at least used to be a reason for something :)
11:19 ashimema      I removed a db field that's not been used for 10 years the other day!
11:19 ashimema      hehe.. indeed
11:19 ere           ashimema: cool
11:20 ashimema      I'm not sure there was ever a reason for the field I cleaned up.. I think it never got fully implimented in the first place
11:20 ere           aparently there wasn't as much code review then..
11:47 marcelr       hi #koha
11:58 eythian       hi marcelr
11:59 marcelr       hi eythian alles goed
12:01 eythian       ja prima, met jou?
12:09 josef_moravec ashimema: josef_moravec considered it, but is not sure if he has enough time for that :(
12:10 ashimema      mmm, time is always a factor
12:10 ashimema      well.. I think you'd make a good rmaint if you fancy it in the future ;)
12:12 josef_moravec ashimema: I would like to take this role in the future, It attracts me ;)
12:13 ashimema      :)
12:13 * ashimema    goes back to the drawing board in his hunt for an 18.05.x maintainer to hand over to
12:16 * eythian     places thumb to forehead and says "bags not" :)
12:16 ashimema      lol
12:23 josef_moravec if anybody interested, first version of the open source selfcheck Tohu was just released. It is full of bug and working only on top of SIP2, but with more ILSs integration capability: https://github.com/open-source-knihovna/tohu
13:01 cait          ere: in the 'dark ages' everyone could push...
13:04 ere           cait: It would still be so convenient... :D
13:05 cait          convenient yes... but we'd start breaking each others stuff all the time again
13:07 ere           cait: Sure, but hey... ;)
13:16 cait          ere: are you going to tell me know that you are so trustworthy it would never happen? ;)
13:16 marcelr       just give him the push privileges
13:16 ere           cait: Of course. I've never made a mistake and I've posted a bad patch. Never ever.
13:17 marcelr       ere++
13:17 * ere         hides
13:17 marcelr       can we put that in the quotes
13:17 cait          if i remembered my password...
13:17 marcelr       i never did too until this week :)
13:17 * cait        is trying to reproduce a zebra search with sql and faild
13:17 cait          fails
13:17 marcelr       noo
13:17 cait          i am missing 3 ebook srecords *sigh*
13:18 marcelr       cait: did you see the roles patch btw ?
13:18 cait          probably not - or i don't make the connection right now
13:18 ere           marcelr: Well, uh, let's just say that I'd prefer not to boast too much. And it's of course possible that I'd make a mistake... Like the extra comma in one of my current patches :O
13:19 marcelr       cait: bug 21782
13:19 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21782 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Release team 18.11
13:19 cait          only missing 1 record now... on the theory thata koha zebra catches some typos
13:19 marcelr       ere: just an extra comma
13:20 cait          extras are good... right?
13:20 marcelr       not always
13:20 ere           marcelr: That, and maybe something else too. Extras are usually fine, but computers don't get it.
13:21 Joubu         @quote add <ere> "cait: Of course. I've never made a mistake and I've posted a bad patch. Never ever."
13:21 huginn        Joubu: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
13:22 ere           Joubu :D
13:22 marcelr       Joubu you never did too ?
13:23 Joubu         nobody did I think
13:23 Joubu         @quote add <ere> "cait: Of course. I've never made a mistake and I've posted a bad patch. Never ever."
13:23 huginn        Joubu: The operation succeeded.  Quote #333 added.
13:23 ashimema      lol
13:23 marcelr       cool
13:23 marcelr       ere: you will be remembered
13:23 ere           \o/
13:24 marcelr       hope to see it on the dashboard often ;)
13:25 cait          not it looks like i saidd that..
13:25 cait          now it looks like...
13:25 cait          i am not sure i am super happy about that
13:25 Archie^       ok so i have a question. is there any way i can check what biblioitems item has ?
13:25 ere           cait: Ha, it does! Awesome!
13:25 marcelr       cait you never made a mistake
13:26 cait          only like a dozen in the granular permissions
13:26 ere           "I was misunderstood. It was quoted out of context."
13:26 marcelr       thats a quote for
13:27 ere           s/It/I/
13:27 huginn        News from kohagit: Bug 12365: DBRev 18.06.00.055 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=09c76aa01020dc68c22136a6549eeb90530d37e4>
13:27 huginn        News from kohagit: Bug 21770: Allow html_entity for href <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6932e104f31bc80e7320fe9f5d48ed16d5fb4d3a>
13:27 huginn        News from kohagit: Bug 21770: Add tests for html_entity <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f9e83266d1e4c987412a57a77ca7d0a4d653a65b>
13:27 huginn        News from kohagit: Bug 12365: (follow-up) Fixing broken circ rules table <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ccae80f5e87d1b86754d092e74c1af03850bc1b2>
13:27 Joubu         @quote add <ere> "I was misunderstood. I was quoted out of context."
13:27 huginn        News from kohagit: Bug 12365: (follow-up) Putting backticks in atomicupdate <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1fa74499070da0aca19ccc3d4c1e1e97d8f500db>
13:27 huginn        News from kohagit: Bug 12365: (follow-up) Adding maxlength attribute and popover <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=63595cce65f54ad46029976786d381b944bfe0ff>
13:27 huginn        News from kohagit: Bug 12365: Notes for rules <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=812b3d66b573beabefdb3f66d74d3df3abb3eccd>
13:27 huginn        Joubu: The operation succeeded.  Quote #334 added.
13:27 ere           Joubu++
13:29 Joubu         marcelr: I think Martin is missing from 18.05 QA team member
13:29 marcelr       hmm
13:30 ere           cait: The actual table modification in batch rebuild is not the bottleneck. It's the MARC record creation and processing that takes most of the time. Sadly it's not easy to make it faster, but I managed to optimize it a bit.
13:30 marcelr       Joubu: he was not in 18.05
13:32 Joubu         marcel: ha, my first mistake!
13:33 Archie^       is there a way the check what books a certain library has?
13:36 marcelr       can we add that to the quotes :)
13:38 Joubu         PeanutButterWoman: kidclamp?
13:38 wahanui       kidclamp is, like, the almighty leader
13:39 marcelr       new nickname ?
13:39 marcelr       for a new release..
13:39 kidclamp      I don't currently have an ater ego in here, but it's a nice thought
13:39 kidclamp      then I can argue with myself
13:39 kidclamp      and qa my own bugs?
13:39 marcelr       np
13:40 marcelr       i started with that ;)
13:40 Archie^       nevermind i found it
13:43 kidclamp      is this why I have never met marcelr? he is just someone's alter ego? /me goes to analyze marcelr 's sign off to determine a pattern
13:43 marcelr       noo
13:44 Joubu         he signoffs his own bugs!
13:44 marcelr       actually everyone should
13:44 marcelr       just another discussion..
13:45 Joubu         [off] I do not test my patches
13:45 cait          kidclamp: bug 14391 - how is the permissions situation there now?
13:45 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 enhancement, P5 - low, ---, katrin.fischer, Pushed to Master , Granular permissions for the administration module
13:46 cait          hm, i mean bug 15774?
13:46 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 enhancement, P5 - low, ---, nick, Failed QA , Additional fields for baskets
13:46 cait          Joubu: will you fix bug 15184?
13:46 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 enhancement, P5 - low, ---, jonathan.druart, Failed QA , Ability to duplicate existing order lines to a given basket
13:54 marcelr       Joubu: what is your thought about cloned items subfields? see bug 21774
13:54 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21774 major, P5 - low, ---, m.de.rooy, Needs Signoff , Cloned item subfields disappear when editing an item
13:55 marcelr       what should be the severity ?
13:57 Joubu         more than major if it affects stables
13:58 Joubu         cait: trying to, yes
13:58 marcelr       Joubu: it also depends on how we think about allowing it
13:58 tcohen        morning
13:58 marcelr       somehow we drifted items away from marc21
13:58 cait          morning tcohen
13:58 marcelr       hi tcohen
13:59 Guest2299     Project Koha_Master_D9 build #601: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D9/601/
13:59 Joubu         kidclamp: "created by" is not kept from the form to the "no result" view
13:59 Joubu         it sounds like a bug
14:01 tcohen        hola Joubu
14:01 Guest2299     Project Koha_Master_D8 build #97: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/97/
14:02 Guest2299     Project Koha_Master_U18 build #90: STILL UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_Master_U18/90/
14:03 Joubu         tcohen: hola!
14:13 oleonard      Hi #koha
14:13 marcelr       o/
14:15 Joubu         kidclamp: patch attached to 12365 to fix jenkins
14:17 Joubu         kidclamp: I am going to open a bug report to remove this silly test
14:22 Joubu         kidclamp: bug 21787
14:22 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21787 normal, P5 - low, ---, jonathan.druart, ASSIGNED , GetHardDueDate.t has a silly test
14:37 oleonard      SlackIntegration[m] ?
14:38 ashimema      huh
14:51 marcelr       ashimema: i am just amazed that next is faster than count
14:52 ashimema      I don't think next is
14:53 marcelr       yeah but 1000 nexts are faster
14:54 marcelr       i looked also at CachedKids from DBIx but not wiser
14:56 ashimema      hmm
14:57 ashimema      https://metacpan.org/source/RIBASUSHI/DBIx-Class-0.082841/lib/DBIx/Class/ResultSet.pm#L1594
14:57 ashimema      count is cached at the dbic level here
14:57 ashimema      which is why recursing count on the same resultset should be very very fast.
14:58 ashimema      https://metacpan.org/source/RIBASUSHI/DBIx-Class-0.082841/lib/DBIx/Class/ResultSet.pm#L1229
14:59 ashimema      next gets really clever ;)
14:59 ashimema      there's loads of optimizatino in there regarding caching rows
14:59 ashimema      see _construct_results
15:00 ashimema      if you wanted to get really knowledgable I'm sure ribasushi would be up for a good chat ;)
15:00 ashimema      he's a lovely chap
15:00 ashimema      of course .. Koha::Objects add a layer of 'fun' on top of all this ;)
15:01 marcelr       htg will have a look later thanks !
15:25 * CrispyBran  waves
15:27 CrispyBran    Bug 21346 is ready to sign off or be criticized  :)
15:27 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 major, P5 - low, ---, cbrannon, Needs Signoff , Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
15:36 ashimema      oleonard about?
15:36 * oleonard    waves
15:36 ashimema      bug 21186
15:36 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 normal, P5 - low, ---, oleonard, Pushed to Master , Incorrect Bootstrap modal event name in multiple templates
15:37 ashimema      remind me.. when did we upgrade bootstrap in staff?
15:37 ashimema      does this apply to 18.05 x too?
15:37 oleonard      Quite a while ago :)
15:37 ashimema      brill
15:37 ashimema      I thought so
15:37 ashimema      just being causious
15:38 oleonard      Yeah, it's in 17.11.x
15:38 ashimema      ta
15:38 ashimema      I'll backport it then ;)
15:39 oleonard      Let me know if you run into any trouble.
15:40 ashimema      looks simple enough.. replace 'hidden' with `hidden.bs.modal`
15:40 ashimema      it'll just be lots of conficts due to filter ;)
15:44 * caroline    waves
15:44 oleonard      Hi caroline
16:16 Guest2299     Project Koha_18.05_D9 build #111: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/111/
16:16 Guest2299     Project Koha_18.05_U18 build #112: UNSTABLE in 29 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/112/
16:19 Joubu         ashimema: ^ bug 21671
16:19 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 normal, P5 - low, ---, chris, NEW , Koha/Patron/Modifications.t is failing randomly
16:20 ashimema      thanks Joubu :)
16:25 ashimema      ever seen this when running updatedatebase joubu?
16:25 ashimema      readdir() attempted on invalid dirhandle $dirh at ./installer/data/mysql/updatedatabase.pl line 16933.
16:26 Joubu         what's the value of intranetdir in the config?
16:27 Guest2299     Project Koha_18.05_D8 build #111: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/111/
16:44 Guest2299     Project Koha_18.05_D9 build #112: SUCCESS in 28 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/112/
16:45 Guest2299     Yippee, build fixed!
16:45 Guest2299     Project Koha_18.05_U18 build #113: FIXED in 29 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/113/
16:49 ashimema      Joubu /home/martin/kohaclone
16:49 ashimema      hasn't changed in literally years I believe
17:20 CrispyBran    bug 21446 is ready to be signed off.  :)
17:20 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 enhancement, P5 - low, ---, cbrannon, Needs Signoff , Permanent location should show instead of cart location - course-details.tt
17:23 thd           ashimema: I withdraw what I suggested yesterday about Bugzilla being an option to investigate for task management.  While Mozilla does use their own customised version for task management, and their are some underused features to support that I would not recommend it as it specifically stated to not be the purpose of Bugzila which is to provide a great bugs management system which it is.  A little research has shown me that suitable alternatives
17:23 thd           to Taiga for task management may not exist as free software projects.  I would not encourage using an opencore project which holds back features from the "community edition".  Taiga is free software not open core.  If search needs to be better in Tagia that is something to pursue but I do not find any alternatives worth investigating.
17:29 thd           Joubu: I have satisfied myself that Taiga is the best option for free software task management.  See my message above to ashimema.  He rightly identified some search and navigation weakness but I did not find any suitable alternative as a free software project for task management.
17:34 Joubu         https://tree.taiga.io/project/joubu-koha-rm-1711/wiki/about
17:35 Joubu         # Why taiga?
17:35 Joubu         Because it is an open-source project that is very great and easy to use.
17:35 Joubu         yes I know
17:37 thd           Joubu: There are many alternatives if that are only quasi free software but nothing comparable that does not hold back features from the community edition.
17:39 Joubu         make_schema_at(
17:39 Joubu         "Koha::Schema",
17:39 Joubu         -        { debug => 1, dump_directory => $path, preserve_case => 1 },
17:39 Joubu         +        { debug => 1, dump_directory => $path, preserve_case => 1, overwrite_modifications => 1 },
17:39 Joubu         kidclamp: ^
17:39 kidclamp      is what  I am trying
17:39 kidclamp      my vms all take forever on sql stuff right now
17:39 kidclamp      I don't know why
17:39 thd           Joubu: I had to convince myself that you were quite correct.  Sadly, I will have to replace my netbook to make Taiga useable for me when I am at some alternative locations.
17:40 kidclamp      I blame the beaver
17:41 Guest2299     Project Koha_18.05_D8 build #112: SUCCESS in 25 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/112/
17:42 kidclamp      ubuntu 18.04 that is
17:44 Joubu         thd: there was no concensus about taiga anyway
17:45 Guest2299     Project Koha_18.05_U18 build #114: SUCCESS in 27 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/114/
17:49 Joubu         oleonard: what about removing 'type="text/javascript"' at the intranet? I do not find the bug report
17:50 oleonard      Is there only one for the OPAC? I may have not filed one since I was correcting so many instances in other bugs
17:50 Joubu         oh ok
17:50 Joubu         we have regressions already:
17:50 Joubu         koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt:<script type="text/javascript">
17:50 Joubu         koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recordedbooks-search.tt:<script type="text/javascript">
17:51 Joubu         oleonard: I guess that's why I did not write the QA checks yet
17:51 Joubu         because the requirement is not for both interface
18:01 cait          i think it is for both
18:01 cait          meant to be at least
18:03 Guest2299     Project Koha_18.05_D9 build #113: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/113/
18:20 huginn        News from kohagit: Bug 12365: (RM follow-up) Fix schema files <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d013562745a9683378f65316c15f955e2b6e25d3>
18:20 huginn        News from kohagit: Bug 15184: Fix bad merge conflict with created_by <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=41ebda2d95f6d01c068a7f4ab82c160105050678>
18:20 huginn        News from kohagit: Bug 15395: Fix QA failure - filter not found <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=92944ae3a4944c61e7c491a9aef23822a8d543d9>
18:20 huginn        News from kohagit: Bug 15395: Use POSIX::setlocale <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3bd68dace98a6cf72c862a512b11851299f1b333>
18:20 huginn        News from kohagit: Bug 15184: Fix TT filter <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b844c3c46fac6d35f6bfb08fb18294912ef0dcbb>
18:20 huginn        News from kohagit: Bug 15395: Do not process template files that do not use i18n.inc <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ee0c8f319a5cfa9a23d6ac2be0cd2d6ebf70beed>
18:20 huginn        News from kohagit: Bug 15395: Make QA test script happy <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d1c6e70b446ff0f099f42e29352c5b718b36b0b1>
18:20 huginn        News from kohagit: Bug 15395: Add unit tests for extract_messages_from_templates <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eae72c6712d1eec517afb428ca0c013aada4c706>
18:20 huginn        News from kohagit: Bug 15395: Do not use nl_putenv, use $ENV instead <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ada579ae056537cd8fb87eaaedaabd84ec62689>
18:20 huginn        News from kohagit: Bug 15395: Make msgmerge quiet <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6d6bc705ec4f9697076dbb01ebdafced5fa92492>
18:20 huginn        News from kohagit: Bug 15184: Add missing html filters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4f51ad613699919fae357a3ae8bc1248d0b4fc6f>
18:20 huginn        News from kohagit: Bug 15184: Improve styling <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=222a0efa5e25e27b00e4db55bb4c403296b4a694>
18:20 huginn        News from kohagit: Bug 15184: Change permission (+x) on .pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5cd4b1cc86766d6c2723422ffb762aeb8c1f0a9f>
18:20 huginn        News from kohagit: Bug 15184: Set created_by to the logged in user <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bbe179a1d50bba9a7d101b42d05d924335bbff38>
18:20 huginn        News from kohagit: Bug 15184: Do copy items for not a serial OR if items are created on ordering <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d658cb6f7ecb18845a78d4708ee63ad1126f220f>
18:20 huginn        News from kohagit: Bug 15184: Remove the checkboxes on the last step <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1883508b2ae38216e9481c3356f517231e933738>
18:20 huginn        News from kohagit: Bug 15184: add missing filters <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9e75d96d62e4ed4ccec911920ed2948c16e6ce1d>
18:20 huginn        News from kohagit: Bug 15184: Add POD <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6aa113b28b1bd1aff0ad370a12f50ed25789d8e1>
18:20 huginn        News from kohagit: Bug 15184: Add the ability to duplicate existing order lines <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bf5d8115f5db26b43f829932b657bf864dce7a04>
18:20 huginn        News from kohagit: Bug 15395: Allow correct handling of plural translation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d708255c7a4d981c7c7bdd0644a75202ec43b297>
18:31 cait          back
18:33 * CrispyBran  waves
18:43 cait          hm can't find a package for Locale::Messages
18:43 cait          can someone help?
18:43 cait          it appears as required now
18:44 cait          and can't finish the web installer
18:44 cait          i tried lib-locale-messages-perl
18:44 rangi         it would be liblocale-messages-perl
18:44 rangi         but its not packaged
18:44 oleonard      Hi rangi
18:44 rangi         was it added to master without someone checking that?
18:44 rangi         heya oleonard
18:44 wahanui       oleonard is happy for ashimema to write the release script
18:45 oleonard      :D
18:45 oleonard      wahanui: What else am oleonard?
18:45 wahanui       you are, like, happy for ashimema to write the release script
18:45 cait          julian claims on the bug it's in oldoldstable...
18:45 cait          https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395#c141
18:45 huginn        Bug 15395: enhancement, P5 - low, ---, julian.maurice, Pushed to Master , Internationalization: plural forms, context, and more
18:45 rangi         its not pacakged in debian
18:45 Joubu         liblocales-perl
18:46 Joubu         I think
18:46 rangi         or maybe liblocales-lint-perl
18:46 cait          it's installing, will see in a moment
18:46 rangi         or libintl-perl
18:46 rangi         :)
18:47 cait          Joubu: yours didn't work
18:47 cait          trying the next
18:47 rangi         https://metacpan.org/release/libintl-perl
18:47 Joubu         it's libintl-perl
18:47 rangi         https://packages.debian.org/sid/libintl-perl
18:47 Joubu         yes
18:48 rangi         yep
18:48 cait          that worked
18:48 cait          commented on the bug
18:51 Guest2299     Project Koha_Master_U18 build #91: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_U18/91/
18:54 Guest2299     Project Koha_Master_D9 build #602: STILL UNSTABLE in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D9/602/
18:58 Guest2299     Project Koha_Master_D8 build #98: STILL UNSTABLE in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D8/98/
19:02 Joubu         kidclamp: I do not recreate these ones ^, weird
19:23 CrispyBran    oleonard, how does one preview a notice?  I am not seeing any option to preview.
19:23 oleonard      CrispyBran: What notice are you editing?
19:24 kidclamp      I don't recreate failures either
19:24 CrispyBran    Nothing particular.  Just trying to sign off on 21795
19:25 oleonard      CrispyBran: You can only trigger the preview when editing CHECKIN, CHECKOUT or  HOLD_SLIP.
19:25 CrispyBran    ah
19:33 CrispyBran    oleonard, have we not converted menus to a popup menu in bootstrap yet?
19:34 oleonard      What is the context for your question?
19:35 CrispyBran    If you are on smaller screen, the left menu is pushed to the bottom.  Do we not have a mechanism in place to put the menu in a button on smaller screens?
19:36 oleonard      Not yet. That's out of scope for these Bootstrap grid patches.
19:36 CrispyBran    okay
19:37 CrispyBran    I do not enjoy tables on bootstrap.
19:38 oleonard      I assume you mean you don't enjoy tables at small viewport widths.
19:38 CrispyBran    :)
19:39 CrispyBran    I almost think the organization should be restructured eventually.  Category groupings: Library -> Module.  It would reduce the columns by 2 at least.
19:39 CrispyBran    But that would be another project.
19:40 tcohen        Joubu++
19:46 cait          Joubu++
19:48 * tcohen      is anxious to have kidclamp back and pusing the follow-up, feeling guilty for breaking hte tests in the meantime
19:53 CrispyBran    oleonard, I signed off 21795, but the entry doesn't look right.  Usually it appends something at the bottom of the comment.  Is there something I am missing in my kohadevbox?
19:54 oleonard      It's missing the "signed-off by" line at the bottom.
19:55 oleonard      What process did you use to sign it off?
19:55 Joubu         bye #koha
19:56 CrispyBran    traditional: git bz attach -e 21795 HEAD - Didn't use git so because I have a permission issue.
19:56 oleonard      If you can't use git so you should use 'git commit -s --amend'
19:58 CrispyBran    ugh.  sorry!
19:59 oleonard      It's not a big deal. Thanks for testing it
19:59 CrispyBran    Yea, but now it looks like I did it.
19:59 CrispyBran    :/
19:59 oleonard      Bye everyone, see you tomorrow
19:59 CrispyBran    CrispyBran--
19:59 huginn        CrispyBran: Error: You're not allowed to adjust your own karma.
20:01 kidclamp      CrispyBran++
20:01 huginn        News from kohagit: Bug 21413: Call AddBiblio in list context <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=de3015dabbc438b89d8b76680efc6d602b55d3a5>
20:01 CrispyBran    no no no
20:01 CrispyBran    don't raise my karma for being bad
20:02 kidclamp      I raise it for you to aspire to :-)
20:02 kidclamp      mistakes aren't bad, they happen to us all
20:08 magnuse       @quote add <kidclamp> mistakes aren't bad, they happen to us all
20:08 huginn        magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
20:10 magnuse       @quote add <kidclamp> mistakes aren't bad, they happen to us all
20:10 huginn        magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
20:10 magnuse       boo
20:10 Bovinity      Darn.
20:12 kidclamp      don't worry magnuse, I will say it again
20:12 kidclamp      and do it again
20:13 Bovinity      So we upgraded to 18.05.05 last night and I guess the new unicode support breaks any reports that have variables. Freaked everyone out for a minute this morning. :D
20:18 magnuse       new unicode support?
20:19 cait          ?
20:19 cait          Bovinity: it shoudl not break anything
20:20 Bovinity      Any report using a variable returned an illegal collation mix error. Had to toss in an appropriate collate keyword to get em working.
20:28 cait          Bovinity: that's really odd
20:33 cait          did all your tables get changed correctly?
20:33 Guest2299     Yippee, build fixed!
20:33 Guest2299     Project Koha_Master_D9 build #603: FIXED in 29 min: https://jenkins.koha-community.org/job/Koha_Master_D9/603/
20:34 Guest2299     Yippee, build fixed!
20:34 Guest2299     Project Koha_Master_U18 build #92: FIXED in 29 min: https://jenkins.koha-community.org/job/Koha_Master_U18/92/
20:37 Guest2299     Yippee, build fixed!
20:37 Guest2299     Project Koha_Master_D8 build #99: FIXED in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D8/99/
20:43 Bovinity      As best as I can tell, yes. It seems like it's using general_ci for variables and the tables are all unicode_ci.
20:43 Bovinity      On the bright side, we can put cat emoji into titles now!
20:44 cait          Bovinity: sorry, it still doesn't sound right
20:44 cait          and we had no reports about any issues with the reports so far
20:45 Bovinity      Weird. Was fine before last night, then the update hit and any report with a variable in it started doing that. Easy enough fix for each of them, at least.
20:47 cait          we've just fixed tons of reports because of the marcxml move
20:47 cait          if there is aproblem, i think we should fix it
20:47 Joubu         cait: did not the automatic update fix the reports?
20:48 cait          not really :(
20:48 cait          it actually broke a lot of them
20:48 cait          say you have used biblioitems.ean and marcxml in one report
20:49 magnuse       i just upgraded a site from 17.11 to 18.05.05 and reports with params are not broken there, fwiiw
20:49 * magnuse     wanders off
20:49 cait          the convesion script totally removes biblioitems and replaces with bibio_metadata
20:49 Bovinity      Parameters are fine, but if you save something to a variable that's when it fails.
20:49 cait          so you have to back in and readd biblioitems table
20:49 cait          and fix all the aliases and stufff
20:49 magnuse       ah, ok
20:49 Joubu         cait: we could improve it if it does not work well enough
20:50 cait          i was not sure if it was workth reporting since it changed in 17.11
21:09 huginn        News from kohagit: Bug 19349: DBRev 18.06.00.058 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=edf50215b5e2282568f12f4d1e33dd8e56a467c8>
21:09 huginn        News from kohagit: Bug 19349: (QA follow-up) Cosmetic changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=04d137b06d1cc872941aab38ecc41e562c7a5554>
21:09 huginn        News from kohagit: Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4a61f18f41f7fa4643bd893f525cede496329d3e>
21:09 huginn        News from kohagit: Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7d10549ae8632e6640d3a99014268a2a1e46b3c4>
21:09 huginn        News from kohagit: Bug 18507: Shibboleth auto-provisioning - Sync <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9dc5a53daabc0b7a07430bf0f5ba469d2b4c2e6c>
21:09 huginn        News from kohagit: Bug 19349: Store record's creator and last modifier in record <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=42e9c49934c87f17b3350955e7d5d0860ecbe8bd>
21:15 kidclamp      byee
21:17 Bovinity      o/
21:39 Guest2299     Project Koha_Master_U18 build #93: SUCCESS in 29 min: https://jenkins.koha-community.org/job/Koha_Master_U18/93/
21:44 Guest2299     Project Koha_Master_D9 build #604: SUCCESS in 30 min: https://jenkins.koha-community.org/job/Koha_Master_D9/604/
21:47 Guest2299     Project Koha_Master_D8 build #100: UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D8/100/
21:48 cait          can we get another native speaker's opinion on bug 21467?
21:48 huginn        Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 enhancement, P5 - low, ---, jonathan.druart, Passed QA , Allow several receipts for a given subscription