Time Nick Message 00:10 CrispyBran Anyone here? 00:10 * CrispyBran waves 00:12 rangi sorta 00:15 CrispyBran rangi, I committed a patch, but I need to change the patch. Is there a way to reset my branch and load my patch as if I haven't committed or staged it yet, so I can make changes and resubmit? 00:16 CrispyBran I don't want to have to retype the whole thing. 00:16 rangi yeah 00:17 rangi you dont need to do anything fancy even 00:17 rangi make your changes 00:17 rangi git add the file(s) 00:17 rangi git commit --amend 00:17 rangi now you are amending the commit, rather than making a new one 00:17 rangi so the changes you made are in that commit now 00:17 rangi cool eh 00:18 CrispyBran that's good. I will try that. Thanks. 01:35 CrispyBran rangi: if I replace a patch that just removes indent changes, do I need to have it signed off again? 01:36 CrispyBran joubu: are you there? 01:37 rangi nope shouldnt need to as long as you explain that's what it does 01:45 CrispyBran rangi: sorry. One more question. If I am not changing anything in the files, but want to fix a typo in the test plan in the notes of the patch, is there a way to do that? 01:45 rangi yep, just git commit --amend 01:45 rangi and change the commit message 01:46 CrispyBran ah. I was so close. Thanks again! 04:23 paxed hmmm 04:23 paxed name: _("Bibliograpic Record ID") 05:29 paxed cait: re bug 11175 - i think i'd rather try to get that as it is into master, and slowly add on to it (like the "limit the number of components shown" you wanted) 05:29 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 enhancement, P5 - low, ---, pasi.kallinen, Needs Signoff , Show the parent record's component parts in the detailed views. 05:35 calire morning #koha 05:37 josef_moravec hi calire 05:38 calire hi josef_moravec 05:41 cait paxed: at the moment it will break our catalog 05:41 cait paxed: i am not insisting in the imiting, but hten it needs to be an optional feature 05:41 cait which might be good anyway to get it accepted 05:42 paxed more sysprefs. 05:42 cait i am not sure about performance for several hundred... but my guess is not super good 05:42 paxed cait: literally breaks you cat? 05:43 paxed +r 05:43 cait i can't test on one of the big production sites, but I think scrolling down several pages would be annoying already 05:43 cait if it doesn't slow down the detai page load considerably too 05:44 cait hm another thought 05:44 cait how does it behave with easyanalytics? 05:44 cait we don't use that, but it uses 773 05:44 cait it might be libraires using htat will wnat to turn it off 05:45 paxed i don't know, we don't use easyanalytics 05:46 cait it adds 773 and doesn't go with usecontrolnumber 05:46 cait so we can't use it, but i think some use it rather extensively 05:47 cait it works on item level 05:47 paxed cait: also, it shows scrollbars if the block with the components would get taller than 25 em 05:47 cait but uses 773.... which is why i am not super happy about implementation 05:48 cait it makes items 'shine through' if you link it to one thing, it will show up on other records 05:48 cait one item... showing on multiple records (in theory, i haven't tested in a long time) 05:48 cait i really think an on/off switch would be safest for now 05:49 cait then we don't have to think so much about how it might break stuff, because you can turn it off 05:49 paxed i had never even hard of UseControlNumber 05:49 paxed heard* 05:50 paxed cait: can you give me actual marc records that link to each other? 05:51 cait oh 05:51 cait i don't have a set right ready right away 05:52 cait what it does is use 001 in the parent and $w in the child 05:52 cait $w should be a combination of the 003 MARC org code and the 001 - but just 001 works and is what we do for simplification 05:52 cait i am about to leave, maybe ask me later and i can try to get some examples 05:53 paxed cait: select metadata from biblio_metadata where ExtractValue(metadata, '//datafield[@tag="773"]/subfield[@code="w"]')=(select ExtractValue(metadata, '//controlfield[@tag="001"]') from biblio_metadata where biblionumber=4760) or biblionumber=4760 into outfile '/tmp/bib4760.mrc' fields terminated by '' optionally enclosed by '' lines terminated by ''; 05:53 paxed or something 05:53 cait ? 05:54 cait i usually just use a list and send me marc records from the opac :) 05:54 cait but i got some things i need to do this morning before a library opens, so it will have to wait a big 05:54 cait bit 05:54 paxed that query exports biblionumber and it's component records (if linked via 773$w) 05:55 paxed also, the patch does search for (773$w='Host001' and 003='Host003') or 773$w='Host003 Host001') 05:56 cait usecontrolnumber controls if the linking is used in xslt 05:57 cait because some libraries might have $w unintentionally from getting data from external resources 06:06 cait bbiab 06:36 reiveune hello 06:38 magnuse \o/ 06:55 matts hi 06:56 calire hi matts 06:56 alex_a bonjour 07:06 fridolin hi there 07:17 magnuse bonjour france 07:25 tuxayo hi #koha o/ 07:25 tuxayo hi magnuse :) 07:26 calire hi tuxayo, magnuse :) 07:41 * cait waves 07:56 tuxayo o/ cait 07:57 magnuse anyone else seeing Bug 21457? 07:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21457 normal, P5 - low, ---, koha-bugs, NEW , datelastseen and datelastborrowed out of sync 08:03 * andreashm waves 08:11 * cait waves back 08:13 andreashm hi cait 08:17 cait magnuse: never investigated those, i htink we might not be using them 08:17 cait datelastseen is mostly in context of inventory 08:17 cait i guess that could get them out of sync? 08:18 magnuse the library that reported it has never used/done inventory, as far as i know 08:18 magnuse but shouldn't those dates make sense anyway? 08:35 m23 hi datelastborrowed is relevant for statistics, datelastseen for inventory and searching of "lost" documents 08:53 paxed name: _("Bibliograpic Record ID") 08:53 paxed ^ that could use a typofix 08:54 paxed also the capital R should probably be lowercase 09:03 severine Bonjour #Koha ! 09:04 andreashm hi severine! 09:05 severine hi andreashm ! 09:05 calire salut severine 09:07 severine good morning calire :) 09:07 andreashm morning? almost time for lunch! 09:07 * andreashm is hungry 09:08 * calire had a snack 09:09 * andreashm gets hungrier 09:10 * calire is admittedly still hungry 09:13 severine not wrong andreashm !! 09:14 severine time is running out... 09:48 cait time for lunch? 10:52 * kidclamp waves 11:05 andreashm hi kidclamp! 11:05 kidclamp hi andreashm 11:06 andreashm is there a good (=easy) way to move a number of issues from one patron to another? say 800 or so. 11:07 kidclamp issues maybe, but statistics harder - unless limited to a date range 11:17 paxed cait: isn't the description of UseControlNumber misleading? it doesn't say "use only 773w=Host001 for linking" (when the standard is 773w='(Host003) Host001'), it's just "use" or "not use" 11:31 oleonard Hi #koha 11:47 andreashm hi oleonard 11:56 calire hi oleonard 12:02 oleonard Thank you for the signoffs calire 12:05 calire no problemo 12:16 magnuse calire++ 12:42 Joubu Hi #koha 12:43 Joubu I am getting the following error when starting my devbox: 12:43 Joubu fatal: [jessie]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh.", "unreachable": true} 12:43 Joubu anybody else already got it? 12:47 Joubu heh, vagrant halt, then up again fixed the issue 13:00 oleonard Joubu: I've had similar trouble with my devbox if I use "suspend" instead of "halt." 13:06 caroline Good morning! 13:07 calire hey caroline 13:10 * andreashm waves 13:21 tcohen hola 13:21 oleonard Hi tcohen 13:22 eythian hi oluipaard, tcohen 13:58 corilynn fresh new Koha developer reporting for duty :) 13:58 caroline Hi corilynn! Welcome! 13:58 oleonard Hi corilynn 14:00 corilynn oleonard, thank you for reporting the KohaDevBox issue last week, really helped me 14:00 oleonard Oh good 14:01 calire hi corilynn 14:28 Joubu @later tell CrispyBran do not hate me too much please 14:28 huginn Joubu: The operation succeeded. 14:31 cait hi corilynn 14:31 cait where are you from? 14:32 corilynn a lot of places :) .. but I'm living in Connecticut now 14:32 corilynn i'm mostly "from" Alaska 14:33 cait paxed: both forms should work, but only after marcel added it 14:33 mtompset Greetings, #koha 14:33 mtompset @seen cait 14:33 huginn mtompset: cait was last seen in #koha 38 seconds ago: <cait> paxed: both forms should work, but only after marcel added it 14:33 cait and it only lists the fields, i think the description is correct 14:33 cait i just said something :) 14:34 mtompset Timing. :) 14:34 mtompset bug 15529 14:34 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 normal, P5 - low, ---, alexbuckley, Needs Signoff , Process Message Queue may send duplicate emails if process is launched twice 14:34 mtompset I've added a patch which makes it passable for me. :) 14:36 mtompset @seen barton 14:36 huginn mtompset: barton was last seen in #koha 1 week, 3 days, 23 hours, 59 minutes, and 32 seconds ago: <barton> Joubu: you're right about sharing the imported file. 14:36 mtompset @seen wizzyrea 14:36 huginn mtompset: wizzyrea was last seen in #koha 6 days, 11 hours, 47 minutes, and 39 seconds ago: <wizzyrea> @later tell CrispyBran just later me with whatever you need ;) I think I know what it is. 14:37 mtompset Just seeing if anyone on the bug was around to sign it off. :) 15:00 reiveune bye 15:16 mtompset Greetings, barton 15:18 Joubu corilynn: Thanks for your patch on bug 18584 15:18 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 trivial, P5 - low, ---, carnold, Needs Signoff , Our legacy code contains trailing-spaces 15:19 corilynn the tutorial is very helpful :) 15:19 Joubu corilynn: I have just noticed that you did not update your git configuration 15:19 Joubu the author of the patch is: Author: Your Full Name <your_email> 15:19 corilynn ah, ok 15:20 Joubu corilynn: do you want to try and resubmit it with the correct name? 15:20 corilynn sure... do you just reject it and I try again? 15:21 corilynn I just updated the .gitconfig with my name 15:21 corilynn Joubu, I 15:21 corilynn ve only used git once... 15:22 Joubu To update the existing commit you can use --amend --author: git commit --amend --author="Your name <your_email>" 15:37 corilynn Joubu, I think it maybe is too late? 15:38 Joubu corilynn: too late? 15:38 corilynn i tried amending, but it shows another bug? 15:39 Joubu which one? 15:39 Joubu 21416? 15:39 corilynn 18584 15:39 corilynn oh 15:39 corilynn uh 21416 15:39 corilynn gr missing from ZEBRA_LANGUAGE 15:40 Joubu 21416 is top of master, you need to re-apply the patch locally (git bz apply). 15:41 corilynn ooooohhh 15:46 mtompset Joubu++ # thanks for the trust bug 16690. :) 15:46 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 major, P5 - low, ---, mtompset, Passed QA , Remote DB installation is less secure 15:47 corilynn okay... I think I got it now, thx for helping me through that Joubu! 15:55 Joubu corilynn: yes, that's perfect! 16:11 Joubu corilynn: how is going the signoff part? 16:31 huginn News from kohagit: Bug 17602: DBRev 18.06.00.034 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ccc40975e3cda7966b67be297dd16891aa8dc314> 16:31 huginn News from kohagit: Bug 17602: Compiled CSS <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c80074077dc7d1ff2652cf810160497e05ec426f> 16:31 huginn News from kohagit: Bug 17602: (RM follow-up) QA tool issues <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=903cf19f9ca5cc9a8effa776efd51321681dc583> 16:31 huginn News from kohagit: Bug 17602: Move spinner location to include file <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=28a1a90b3dace9207fd26a753ab222ba298bcb99> 16:31 huginn News from kohagit: Bug 17602: (QA follow-up) Fix tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c90fa4182e6fb78c2c09958d9671c2b61943412f> 16:31 huginn News from kohagit: Bug 17602: Use Asset TT plugin and fix indentation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a33826454bf01d7de1e5b5a57467cef14f96d419> 16:31 huginn News from kohagit: Bug 21437: Update two-column templates with Bootstrap grid: Patron lists <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=311b9dccbc60f05421416f402627b78e5efb5542> 16:31 huginn News from kohagit: Bug 17602: (follow-up) Adjust js paths to use version add spinner <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=441af54fc629e40157d050aa027c601c10e3f67d> 16:31 huginn News from kohagit: Bug 17602: Removed unused param to RecordedBooks API <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1dcb6f28ee91fe7661b546150279c7388286ff2f> 16:31 huginn News from kohagit: Bug 17602: fix RecordedBooks results pagination <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fc3bc961095280ba60db72b466762339f9d05905> 16:31 huginn News from kohagit: Bug 17602: Translations rework <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=34058bb6d0497079e7957933b364e76ad88ba765> 16:31 huginn News from kohagit: Bug 17602: Fix few minor QA issues <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=82ec758f18ba5b2600c065245fb68a3f177dcba8> 16:31 huginn News from kohagit: Bug 17602: Adapt test plan to make the tests pass <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fa8cda129ef5c71042334083ee13aecb56ed7ab6> 16:31 huginn News from kohagit: Bug 17602: Handle '60+' if there are more than 60 results <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=48c0e8952a46a5a3eef6cae138c88b1ae22b0986> 16:31 huginn News from kohagit: Bug 17602: Ease translation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7ff2b8d5e22e5333f51426c481bbfe83ae1ddc47> 16:31 huginn News from kohagit: Bug 17602: (follow-up) t/Koha_ExternalContent_RecordedBooks.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8cb8223e12d5e311e59813c1ba03835c0b50670e> 16:31 huginn News from kohagit: Bug 9188: Remove 'debug' information from patron statistics <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=36a52382227aecca98f8b57314d4374a60a99227> 16:31 huginn News from kohagit: Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2f1cba8b31063ea81862abd37aae009072b1fb15> 16:31 huginn News from kohagit: Bug 17602: OPAC integration of RecordedBooks <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=eb4be268d8d66ae0b7ca803ecf270a688fc6aea1> 16:31 huginn News from kohagit: Bug 17602: RecordedBooks Integration to Koha <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7825ff69c2acd2a390b18402e2813fdd9d0b4774> 16:33 corilynn Joubu, got distracted down a rabbit hole... 18823 is what I'm here for :) 17:00 Guest1662 Project Koha_Master_D9 build #563: STILL UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9/563/ 17:09 Guest1662 Project Koha_Master_D8 build #57: STILL UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D8/57/ 17:09 CrispyBran joubu: are you here? 17:10 * CrispyBran waves 17:13 Joubu yep 17:14 CrispyBran I don't hate you. :) I'm still learning. Just be kind and we'll be good. :) 17:14 CrispyBran Question about your tt suggestion 17:16 CrispyBran I see how to call up the location code from the item. But how do I use that code in tt to get the description from LOC? I can't use the same model that is used for branches, just above. I assume there is another method. 17:17 CrispyBran Not familiar with these methods yet. If there is a reference, that would help. 17:18 oleonard Is this what you're looking for CrispyBran? 17:18 oleonard [% AuthorisedValues.GetByCode( 'LOC', ar.item.location ) | html %] 17:18 oleonard ^^ an example from circ/article-requetss.tt 17:19 Joubu CrispyBran: the code is in items.location 17:19 CrispyBran I think so. 17:19 Joubu the description is retrieve using the TT plugin GetDescriptionByKohaField 17:22 CrispyBran Thanks joubu and oleonard 17:25 Joubu CrispyBran: as I said in the comment: you should not need to deal with non-existent description (authorised value LOC) for the code, the method will return the code if not exist (IIRC) 17:27 Guest1662 Project Koha_Master_U18 build #51: STILL UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_Master_U18/51/ 17:28 CrispyBran joubu: yes. Right now the template points to the code only, and the pl converts it to the description. So, my first task is to change the tt to point to the description. 17:29 Joubu CrispyBran: you saw my patch, right? 17:29 CrispyBran yes 17:29 CrispyBran never mind. 17:29 CrispyBran I saw the comments only 17:30 CrispyBran I see the rest 17:50 CrispyBran joubu: something is off with the logic showing the item.location. It is always testing true, and always showing the () for all items, but not showing anything in the (). 17:54 Carolina help please, wanting to return a book gives me the following error! Can not call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 2004.Thank you 17:55 Carolina help please, wanting to return a book gives me the following error! Can not call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 2004.Thank you 17:58 Carolina help please, wanting to return a book gives me the following error! Can not call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 2004.Thank you 18:07 cait Carolina: which version of Koha are you using? 18:39 mtompset @seen Joubu 18:39 huginn mtompset: Joubu was last seen in #koha 1 hour, 10 minutes, and 27 seconds ago: <Joubu> CrispyBran: you saw my patch, right? 18:40 mtompset Are you still around, Joubu? Was I supposed to avoid signing off on bug 18584 too? 18:40 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 trivial, P5 - low, ---, carnold, Signed Off , Our legacy code contains trailing-spaces 18:53 Carolina 18.05 18:54 Carolina Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 2004. 18:55 * CrispyBran waves 18:56 * oleonard waves goodbye for the day 19:00 ashimema Bug 21432 19:00 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 major, P5 - low, ---, koha-bugs, NEW , Internal Server Error in Checkout History 19:15 mtompset Hey, Cris-- seriously. I keep missing him. 19:53 Joubu mtompset: 18584 is for didactic purpose (see koha-howto), following the tutorial until the end should end with a signed off patch from the patch's author 19:54 Joubu ashimema: do you recreate the issue from bug 21432? 19:54 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 major, P5 - low, ---, koha-bugs, NEW , Internal Server Error in Checkout History 19:58 Freddy_Enrique Bug 18966 19:58 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966 blocker, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Move of checkouts - Deal with duplicate IDs at DBMS level 20:07 corilynn Joubu.... me? 20:08 Joubu yes :) 20:09 rangi morning 20:09 caroline hi rangi! 20:10 rangi heya caroline ! :) 20:11 cait caroline: coworkers love the candy i stole from the hackfest (maple syrup ones) 20:12 caroline cait: :D 20:12 rangi i've finished all my hackfest candy :( 20:12 caroline and the skittles? 20:13 rangi heh the kids ate those within days 20:14 cait i tell them it's from you of course :) 20:14 cait i still got... a lot of candy 20:14 cait dangerous 20:15 Freddy_Enrique good afternoon guys 20:15 * bag wishes you were all here still 20:16 cait bag: I sometimes dotoo :) 20:17 rangi hi Freddy_Enrique 20:17 rangi bag: i miss tots (and everyone of course) 20:17 Freddy_Enrique Check this out :). Little by little getting to kwon every corner of Koha: https://snag.gy/1wckFQ.jpg 20:18 Freddy_Enrique know* 20:18 caroline wow! 20:19 cait very cool 20:19 cait is that drawn? 20:19 rangi Freddy_Enrique++ 20:19 Freddy_Enrique haven't found a irc manual in the koha wiki :( 20:19 cait there is only one to chair meetings i think 20:19 Freddy_Enrique an* 20:19 Freddy_Enrique but... the evergreen has an interesting one. There I've learnt a little about karma 20:20 cait someinfo here: https://wiki.koha-community.org/wiki/IRC_Channel 20:20 caroline cait, can you look at https://tree.taiga.io/project/ldjamison-kohadocs-1805/task/558 20:21 Freddy_Enrique cait: yep. I did it using notability 20:21 Freddy_Enrique :o 20:22 Freddy_Enrique OMG, how did I miss that 20:22 cait it's not much 20:23 cait caroline: ineresting, i will check 20:23 cait definitely says your in my vie 20:23 cait w 20:23 cait i think we might have changed that at some point 20:23 cait actually in german i just left the pronouns off 20:23 Freddy_Enrique One thing that got my attetion was the dashboard... 20:24 cait Personal details 20:24 cait fines 20:24 cait because it looked a little strange 20:24 Freddy_Enrique Dashboard...bugzilla and jenkins... 20:26 Freddy_Enrique caroline: that link you just gave. Is it another koha resource? 20:27 caroline It's the main to do list for the docs team 20:27 Freddy_Enrique got it 20:33 caroline Freddy_Enrique: Did you make a list of all resources (other than your drawing)? 20:34 Freddy_Enrique Not yet.... But my goal is to map everything you guys give people to help them 20:35 Freddy_Enrique ...in a visual way. For me at least it is easier that way 20:35 caroline Good idea! 20:35 caroline There is also the newsletter and Twitter (more informative than a help resource, but still) 20:36 Freddy_Enrique One thing my friend.... what is the relation between jenkins and the dashboard? 20:36 Freddy_Enrique ok :) 20:36 Freddy_Enrique When I read jenkins... I imagined a butler 20:36 Freddy_Enrique imagine* 20:37 bag Freddy_Enrique++ 20:37 caroline I think tcohen is in charge of jenkins (but not sure) 20:37 Freddy_Enrique what is that? a bot like wananui? 20:37 cait jenkins' logo is a butler :) 20:38 cait it was renamed from hudson i think earlier 20:38 caroline it's a bot, but other than saying things don't work, I don't know what he does 20:39 cait jenkins? 20:39 cait jenkins is https://jenkins.koha-community.org/ 20:39 caroline yeah, isn't he the one saying build unstable? 20:39 cait everytime a commit is pushed to one of the branches, master, stable, unstable 20:39 cait jenkins runs tons of tests 20:39 cait automated tests, unit tests 20:39 cait and reports if any fail 20:40 Freddy_Enrique O.o... holy mustache... 20:40 cait it also shows on the dashboard 20:40 Freddy_Enrique ok, gotta improve my notes 20:40 cait so he plays a huge role in keeping the bugs out :) 20:42 Freddy_Enrique cait++ 20:43 * cait should have put thta in her talk 20:48 * CrispyBran waves 20:49 rangi hi CrispyBran 20:51 CrispyBran hi rangi 20:52 CrispyBran joubu: trying to figure out if it is me or the patch. Not sure why the description comes through. 20:53 Joubu certainly the patch :) 20:54 CrispyBran even striped it down and just displayed the variables. item.location and item.permanent_location are behaving completely different. 20:54 CrispyBran I don't think it is. You didn't do anything wrong, from what I can see. The item.location is just coming up weird. 20:55 Joubu CrispyBran: without your patch, right? 20:55 CrispyBran yes 20:55 CrispyBran I even striped out the original logic in the pl to make sure it wasn't modifying something, and it is the same. 20:56 CrispyBran If you take out everything in the if statement you modified in the tt and just put [% item.location %], it shows the description. 20:58 Joubu CrispyBran: ho I see, remove lines 256 and 257 from .pl 20:59 * bag eating some peanut butter M&Ms 21:00 CrispyBran yeah, I did. Obviously, that needs to go if the tt is going to handle it, but it didn't change anything. 21:00 CrispyBran wait 21:00 CrispyBran i lied 21:00 cait did you restart after? 21:01 cait i always forget that 21:01 cait well not always... but almost 21:01 cait restart plack that is 21:01 CrispyBran I know I restarted, but I did it again just to be sure. It is working now. 21:01 cait demo effect... once you told us :) 21:01 CrispyBran I knew that code needed to come out of the pl though. Okay. :/ I'll keep looking at it. 21:02 CrispyBran :) 21:03 Freddy_Enrique See ya all! ;-) 21:04 CrispyBran joubu, it isn't handling a missing description. It just leave empty () when the description is gone. 21:04 CrispyBran May be that removing the description is not the same a null. 21:06 CrispyBran I can add a condition to test for ''. Should I? 21:10 Joubu bug 21432 21:11 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 critical, P5 - low, ---, jonathan.druart, Needs Signoff , Internal Server Error in Checkout History 21:11 Joubu Sorry CrispyBran I was focussed on this critical one, back to yours 21:34 caroline gotta run! bye everyone! 22:12 * CrispyBran waves 23:25 mtompset @later tell CrispyBran Stop leaving just before I am going to greet you. :P 23:25 huginn mtompset: The operation succeeded.