Time Nick Message
00:22 Joubu /exit/exit
00:22 Joubu heh, bye :)
00:28 cait bye :)
06:33 reiveune hello
06:52 alex_a bonjour
08:55 drojf hi #koha
08:55 drojf yay for kohacon 2019 in europe
08:56 drojf but i want to go to both places :|
09:06 fridolin hithere
09:08 drojf hi fridolin
09:08 fridolin yoo drojf how are u ?
09:09 drojf warm. hottest summer ever ;)
09:09 drojf and you?
09:24 * andreashm waves
09:27 cait @wunder Konstanz
09:27 huginn cait: Konstanz, Germany :: Mostly Cloudy :: 78F/26C | Wind Chill: 78F/26C | Thursday: Scattered clouds with the possibility of an isolated thunderstorm developing this afternoon. High 89F. Winds ENE at 5 to 10 mph. Chance of rain 30%. Thursday Night: Partly cloudy. Low 68F. Winds NE at 5 to 10 mph.
09:27 cait that's... bearable
09:27 cait and the isolated thunderstorm sounds really nice
09:41 eythian cait: I was in Koeln on Saturday. It was 29° with the occasional 10 minute downpour. Quite refreshing.
09:44 cait we had like 35 here yesterday
09:44 cait then a bit of rain, but the thunderstorms happening elsewhere, so it has not cooled down for long
09:46 tcohen hi
09:46 cait tcohen: that's not your time?
09:46 tcohen I fell off the bed
09:48 cait ouch?
09:48 wahanui http://i.imgur.com/SjElkzG.gif
09:49 tcohen hehe
10:04 * ashimema sees tcohen adding to his pile of stuff to do.. API via plugin.. shiny
10:04 tcohen I marked it as NSO for people to know I want feedback
10:05 tcohen I'm already working with it for prototyping the things I want to propose
10:12 cait ashimema: are you back from vacation?
10:27 ashimema yup
10:28 ashimema playing catch up still at the moment though
10:30 * andreashm waves
10:44 magnuse @wunder bodo, norway
10:44 huginn magnuse: Bodo, Norway :: Clear :: 68F/20C | Thursday: Partly cloudy. High near 70F. Winds NNE at 10 to 15 mph. Thursday Night: Rain. Low 59F. N winds shifting to W at 10 to 15 mph. Chance of rain 100%. Rainfall near a half an inch.
10:45 andreashm Oh I missed the meeting yesterday.
10:59 ashimema tcohen still here?
10:59 ashimema or gone back to bed
11:05 cait ashimema++ thx for the note on the wiki
11:06 ashimema :)
11:08 cait @wunder Konstanz
11:08 huginn cait: Konstanz, Germany :: Overcast :: 84F/29C | Wind Chill: 84F/29C | Heat Index: 86F/30C | Thursday: Partly cloudy with a slight chance of thunderstorms. High 88F. Winds ENE at 5 to 10 mph. Chance of rain 30%. Thursday Night: Partly cloudy. Low 68F. Winds NE at 5 to 10 mph.
11:14 cait @wunder Konstanz
11:14 huginn cait: Konstanz, Germany :: Overcast :: 84F/29C | Wind Chill: 84F/29C | Heat Index: 86F/30C | Thursday: Partly cloudy with a slight chance of thunderstorms. High 88F. Winds ENE at 5 to 10 mph. Chance of rain 30%. Thursday Night: Partly cloudy. Low 68F. Winds NE at 5 to 10 mph.
11:15 cait slight chance..
11:21 andreashm @wunder Stockholm
11:21 huginn andreashm: Stockholm, Sweden :: Partly Cloudy :: 72F/22C | Thursday: Generally cloudy. High near 75F. Winds WSW at 5 to 10 mph. Thursday Night: Partly cloudy skies. Low near 50F. Winds WNW at 5 to 10 mph.
11:23 ashimema @wunder Stevenage, UK
11:23 huginn ashimema: Error: I could not find a valid location for: Stevenage, UK
11:23 ashimema wunder is useless to me now
11:24 ashimema @wunder Stevenage, United Kingdom
11:24 huginn ashimema: Stevenage, United Kingdom :: Partly Cloudy :: 77F/25C | Thursday: Partly cloudy. Warmer. High near 85F. Winds WSW at 5 to 10 mph. Thursday Night: Partly cloudy skies. Low 62F. Winds WNW at 5 to 10 mph.
11:24 cait nah, see :)
11:25 ashimema did it not used to do F and C temps
11:27 cait it still does?
11:27 cait well for the temperature at least
11:27 cait 77F/25C
11:28 cait ... and i am so jealous :)
11:28 ashimema my garden thermometer claims 29
11:31 andreashm ashimema: here it is appaerently 31, not 22. Sigh. =)
11:48 oleonard Hi #koha
11:49 calire hi oleonard
11:49 wahanui hi dear loon
11:52 eythian @wunder amsterdam
11:52 huginn eythian: Amsterdam, Netherlands :: Clear :: 81F/27C | Thursday: Sunny. High 84F. Winds WNW at 5 to 10 mph. Thursday Night: A clear sky. Low near 60F. Winds N at 5 to 10 mph.
11:54 * andreashm waves
11:59 oleonard @wunder 45701
11:59 huginn oleonard: Athens, OH :: Overcast :: 68F/20C | Thursday: Mostly cloudy...isolated thunderstorms developing this afternoon. High 79F. Winds light and variable. Chance of rain 30%. Thursday Night: Considerable cloudiness. A stray shower or thunderstorm is possible. Low 67F. Winds light and variable.
11:59 cait bbiab
12:08 ashimema confused.. is bug 20806 an enhancement or a bugfix.. it's marked as enhancement but the first comment reads as though it's a bugfix
12:08 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 enhancement, P5 - low, ---, josef.moravec, Pushed to Master , Item type in holds history table should be written as description, not code
12:09 ashimema anyone got an opinion
12:11 oleonard If it were the OPAC I'd say it was definitely a bug fix
12:11 ashimema :)
12:12 oleonard I guess that means I lean towards bug fix
12:12 ashimema yeah.. I'm leaning towards bugfix.. think I'll go that way and port it.. it's a fairly simple patch
12:14 ashimema thanks for commenting oleonard :)
12:14 oleonard Well, I have opinions.
12:26 oleonard jajm around?
12:27 jajm yes
12:31 oleonard I see that when you added the select2 plugin you also added some css to highlight missing required fields
12:31 oleonard ...but that doesn't seem to be working now. I'm looking at the add item form.
12:31 cait back
12:31 oleonard jajm: Do you recall that working correctly?
12:36 jajm oleonard, it was 2 years ago, i don't trust my memory enough to be 100% sure it was working... but i'm 100% sure Joubu wouldn't have signed off this patch if it wasn't working :)
12:37 oleonard Good point
12:40 * oleonard files a bug
12:41 cait oleonard: were you lookign at my patch by chance?
12:42 cait bug 14662
12:42 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 major, P5 - low, ---, katrin.fischer, Needs Signoff , Add empty entry to pull down when subfield is mandatory and linked to authorized value
12:42 cait i tried to make them highlight, but failed
12:43 oleonard Yes
12:43 cait oleonard++
12:44 cait thank you
12:47 cait i tihnk it didn't work - because it couldn't be tested at the time
12:48 cait mandatory fields can't be 'unset' at the moment if they are pull downs, so the code would have never been reached
12:51 oleonard I'm not sure I understand, cait. Are you saying that in master I shouldn't be able to "unset" a mandatory <select> on the add item screen?
12:53 cait at the ommen tno
12:53 cait sorry
12:53 cait let me double check
12:53 cait oleonard: that#s the point of my patch
12:54 cait without the patch, you mark any pull down field mandatory and you lose the empty option
12:54 cait which means... the code for missing required can never be triggerd, koha just selects the first entry which is never emoty
12:54 cait and wrong
12:54 cait so even if it was empty before in the item - when you go to the edit item form, it will show up as the first value from the pull down
12:55 cait without patches from bug 14662
12:55 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 major, P5 - low, ---, katrin.fischer, Needs Signoff , Add empty entry to pull down when subfield is mandatory and linked to authorized value
12:55 cait hope the explanation made sense
12:56 oleonard I'm confused. On my screen, required fields Permanent location and Current location do not have the option to unset. Required fields ccode and itemtype do.
12:56 oleonard Is that what you see too?
12:56 cait can you share a screenshot?
12:57 cait i can share mine without the patch sec
12:57 cait [off] http://librarygeekgirl.de/pics/Selection_062.png
12:57 cait there is no X to empty
12:58 oleonard https://zivotdesign.com/p/view.php?p=15332146650498
12:58 cait interesting
12:59 cait can you get back to empty after selecting an itemtype?
12:59 oleonard Yes, and with ccode too.
12:59 cait how?
12:59 cait and you didn#t apply the patch?
13:00 oleonard Yes. On master. https://zivotdesign.com/p/view.php?p=15332148462980
13:01 cait i can't
13:01 cait we are quite annoyed by this bug and i tested in 17.11 too and couldn't do that there
13:01 cait browser?
13:02 cait oleonard: there is something odd going on :(
13:02 oleonard Firefox, Windows 10. I *do* see what you see on our production system which is 17.11.07
13:02 cait i am looking on master, almost fresh db, firefox and chromium in ubuntu
13:02 cait and no x
13:03 oleonard Joubu bullied me into starting a new Debian desktop installation in Virtualbox, so I'll try to finish that today and test.
13:03 cait thx
13:04 cait this bug really keeps us from making itemtype mandatory right now
13:04 cait which is then causing bugs too...
13:04 * oleonard hasn't installed a non-kohadevbox Koha in ages :(
13:04 cait i feel with you, once converted...
13:04 cait Bug 21133: Fix use statements order is my last commit on the branch
13:04 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 major, P5 - low, ---, jonathan.druart, Pushed to Master , Missing use C4::Accounts statement in Koha/Patron.pm
13:04 cait oleonard: just for the fun of it... try a restart all?
13:05 oleonard :|
13:05 * oleonard hides
13:05 cait i think hugh had seen it too, so it should be an existing bug
13:05 cait lol
13:05 cait what did you do?
13:05 cait i am not going ot bite.. :)
13:06 oleonard Okay, ANYWAY. I'll go back to trying to get highlighting to work.
13:06 cait you are not going to tell me? :)
13:06 * cait tries bribing you with cookies
13:06 oleonard I followed your advice and did restart_all.
13:06 cait ah
13:06 cait been there too often myself
13:07 cait the bug is real!
13:09 cait jajm: do you think you or someone else from biblibre might have time ot take a look at bug 14716? it's about correctly uri-encoding links in hte xslt and missing a unimarc sign-off
13:09 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 normal, P5 - low, ---, ere.maijala, Needs Signoff , Correctly URI-encode URLs in XSLT result lists and detail pages
13:09 * cait waves at caroline
13:09 caroline good morning all!
13:11 huginn News from kohagit: Bug 21136: Fix add/edit patron when cities are defined <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b7fa3b9b43bce1bae3d7fcdc76775cc84b83433d>
13:11 huginn News from kohagit: Bug 21129: Fix typo created vs created_by <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d65ab39699c0406f7438e2c7f1d0d36e233f2d7b>
13:11 huginn News from kohagit: Bug 21129: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=336c54860531253d860165dc9a6d406892b1600a>
13:12 jajm cait, i added it to my list of bugs to look at, but i don't know when i'll have the time to do it
13:13 jenkins Project Koha_17.11_D8 build #81: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_17.11_D8/81/
13:13 jenkins * victor.grousset: Bug 20623: Fix basket group PDF when itemtype not itemtype table
13:13 jenkins * m.de.rooy: Bug 20623: (QA follow-up) Remove one find call
13:13 jenkins * victor.grousset: Bug 20623: (QA follow-up) avoid fetch() calls in some cases
13:13 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623 minor, P5 - low, ---, victor.grousset, Pushed to Stable , PDF export of a basket group fails when an item has an itemtype that is not in the itemtype table
13:13 cait maybe you have someone else in mind who could test
13:21 huginn News from kohagit: Bug 21094: Syndetics: always use https instead of http <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6e0548cc1a7a924731bd414fec2f7917f044040a>
13:21 huginn News from kohagit: Bug 21077: Fix database documentation for statistics.type <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0b89cbf6a473e71597bc051d88c2152531648ad8>
13:22 oleonard cait: Shouldn't the same changes be made to addbiblio.pl to allow for blank mandatory entries?
13:33 huginn News from kohagit: Bug 21122: Fix check-url-quick when utf8 characters in URL's <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=10720d2a5c50b82d565cab9ad70c8498164d81b2>
13:33 huginn News from kohagit: Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c6b50f0bac092779f93033c8a3f002cb8722d7d4>
13:33 huginn News from kohagit: Bug 20770: ILL loans OPAC form notes field allow arbitrary input <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=552873f7d466abee6919414b8d2f5e6c99f9a44f>
13:35 oleonard Who's pushing patches?
13:37 cait tomas
13:38 cait oleonard: i could try on a separate bug maybe?
13:38 oleonard ?
13:38 cait your question about addbiblio
13:38 cait or follow-up on this
13:38 cait it's a little scary, i will take a look
13:39 jenkins Project Koha_Master_D9 build #520: SUCCESS in 25 min: https://jenkins.koha-community.org/job/Koha_Master_D9/520/
13:40 oleonard Oh right, sorry. Yes, I think a separate bug would be fine.
13:40 jenkins Project Koha_Master_U18 build #20: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_Master_U18/20/
13:40 ashimema nooo.. my queue is going to fill up more!
13:41 cait trying to see if I can find the right spot, but the code is much more complicated
13:43 cait hm or not so much
13:48 cait oleonard: any hope for the highlighting?
13:48 oleonard Yes, easy CSS fix it turns out.
13:48 cait nice!
13:48 cait do you want ot keep it on the separate bug or want to do as a follow-up and i sign off yours and you mine?
13:49 oleonard I should have made it a follow-up. Since I didn't, I'm just going with it.
13:49 jenkins Project Koha_Master_D8 build #21: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D8/21/
13:49 cait ok
13:49 cait i will sign off anyway
13:49 cait working on a patch for bibliographic records now
13:51 ashimema bug 19604 - bug of enhancement.. reads like a bug again to me but is marked as an enhancement
13:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 enhancement, P5 - low, ---, nick, Pushed to Master , Elasticsearch Fixes for build_authorities_query for auth searching
13:51 ashimema I'm not using elastic anywhere so can't easily comment
13:51 cait definitely a bug
13:51 ashimema cheers cait :)
13:52 cait also bug 20273 after that one
13:52 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 normal, P5 - low, ---, alex.arnaud, Pushed to Master , Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat
13:54 cait oleonard: the hightlighting on the bibliographic frameworks work ok
13:54 cait writing test paln now then attaching as a follow-up to the bug
14:00 ashimema that bug doesn't like applying to my branch
14:01 cait oleonard: attached a second patch, can you have another look?
14:03 ashimema aha.. unmentioned dependancy
14:03 ashimema fun imes
14:04 cait ouch
14:05 ashimema so.. are we sure there's a bug there in 18.05 branch
14:05 alex_a__ Anyone here knowns why we have ModReserveStatus AND ModReserveAffect in reserves code?
14:05 jenkins Project Koha_Master_D9 build #521: SUCCESS in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9/521/
14:06 jenkins Project Koha_Master_U18 build #21: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_Master_U18/21/
14:06 alex_a__ Seems like there is some problems since we pushed bug 12063
14:06 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 enhancement, P5 - low, ---, alex.arnaud, RESOLVED FIXED, Change date calculation for reserve expiration to skip all holidays
14:06 cait ashimema: the second one is not as bad
14:06 cait or is the first one already giving you trouble?
14:06 cait for me... i could not search authorities at all without the first, unless i used sorting 'none'
14:07 ashimema the first is the issue
14:07 cait alex_a__: holds... not sure i can explain that
14:07 ashimema the config files it updates don't exist yet in my branch
14:07 alex_a__ correction: why we have ModReserveStatus('W') and ModReserveAffect
14:07 cait ah
14:07 cait so maybe it's not going to work then hm
14:08 oleonard cait++
14:09 cait thx a lot for your help with the CSS
14:09 cait i stared quite a while at it last night and just couldn't make it yellow
14:10 cait oleonard++
14:10 alex_a__ cait, with BZ 12063, hold expirationdate is set in database when it becomes "waiting" (found: W, priority 0). And this is done in ModReserveAffect (used on a return). But i seems that some reserves are set to waiting using only ModReserveStatus('W')
14:11 cait i was not a fan of bug 12063
14:11 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 enhancement, P5 - low, ---, alex.arnaud, RESOLVED FIXED, Change date calculation for reserve expiration to skip all holidays
14:11 cait i think we should not use expirationdate for 2 different things
14:11 cait the date the patron picks and the date the pickup is due
14:11 cait i haven't actively worked on the patch st
14:11 cait set
14:13 alex_a__ We always used expirationdate. 12063 just write it in database instead of calcul it each time (and everywhere) we need it
14:14 cait how did we use it when it was not in the database?
14:14 cait alex_a__: i tihnk it should have been a new db field
14:14 cait but that's me - I will keep complaining ;)
14:15 cait we lose the date the patron set
14:15 cait anyway... not really familiar with this part :(
14:16 alex_a__ cait, nope, we keep it if it prior to the library delay
14:16 cait still feels a little messy, but it's probably ok for most
14:17 cait so maybe i should stop complaining :)
14:21 cait hm in theory it could be a problem if you decide to check out an item waiting to someone else
14:21 cait which you probably shouldn#t, but I think Koha might allow it
14:22 cait but you shouldn't
14:23 ashimema only 50 more commits to go.. plus whatever tcohen has pushed today :'(
14:23 cait telling you that these have been slow weeks.... probably doesn't help? :)
14:24 ashimema lol
14:24 tcohen ashimema: I pushed a couple fixes only, just in case you wanted them for stable
14:24 ashimema 'tis my own fault.. i shouldn't go on holiday ;)
14:25 ashimema hehe.. coolios
14:25 tcohen ashimema: I need to talk about bug 20407
14:25 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 enhancement, P5 - low, ---, alex.arnaud, Signed Off , Hide some fields from unauthorized users
14:25 tcohen can you?
14:26 ashimema give me a minute to draw a line on my push frenzy ;)
14:27 ashimema right.. all good.. I decided to pause at bug 20757
14:27 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Capture a screenshot on selenium errors
14:27 ashimema looks like it might be a nice one to backport even though it's enhancement.. makes devs lives easier on failures
14:27 ashimema anywho.. fire away.. I'll have a quick read of the bug
14:27 tcohen ashimema: wait
14:27 tcohen the use case: /libraries
14:28 tcohen you want to list libraries
14:28 tcohen (say) for a dropdown
14:28 ashimema oh, I've laready commented on the bug you linked to..
14:28 ashimema so for /libraries.. yes
14:28 tcohen there was a discussion about having a 'public' endpoint for such use case, and /libraries for CRUD operationg
14:30 tcohen I feel x-staff-only or the like makes more sense
14:30 Joubu ashimema: yes, please backport
14:30 jenkins Project Koha_18.05_D8 build #30: UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/30/
14:30 jenkins * martin.renvoize: Bug 6647: Revert - Label item search should use standard pagination
14:30 jenkins * Tomás Cohen Arazi: Bug 20942: OpenAPI spec for /patrons/{patron_id}/account
14:30 jenkins * Tomás Cohen Arazi: Bug 20942: Unit tests for /patrons/{patron_id}/account
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 minor, P5 - low, ---, oleonard, RESOLVED FIXED, Label item search should use standard pagination routine
14:30 jenkins * Tomás Cohen Arazi: Bug 20942: Add route to get patron's account balance
14:30 jenkins * Tomás Cohen Arazi: Bug 20942: Split debit and credit lines
14:30 jenkins * Tomás Cohen Arazi: Bug 20942: (QA follow-up) Use $lines->total_outstanding
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 new feature, P5 - low, ---, tomascohen, Pushed to Stable , Add route to get patron's account balance
14:30 jenkins * oleonard: Bug 21038: Reserves should be holds
14:30 jenkins * Jonathan Druart: Bug 20079: Display stack trace for development installations
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 trivial, P5 - low, ---, oleonard, Pushed to Stable , Reserves should be holds
14:30 jenkins * josef.moravec: Bug 20806: Add item type description holds history page
14:30 jenkins * Jonathan Druart: Bug 20806: Do not rely on column position
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 enhancement, P5 - low, ---, jonathan.druart, Pushed to Stable , Display stack trace for development installations
14:30 jenkins * Jonathan Druart: Bug 20806: Surround string by span tag to help translation
14:30 jenkins * oleonard: Bug 16575: Irregular behaviour using window.print() followed by
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 minor, P5 - low, ---, josef.moravec, Pushed to Stable , Item type in holds history table should be written as description, not code
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 normal, P5 - low, ---, oleonard, Pushed to Stable , Irregular behaviour using window.print() followed by window.location.href=
14:30 jenkins * katrin.fischer: Bug 16575: (follow-up) Compiled CSS
14:30 jenkins * Nick Clemens: Bug 21076: Don't call autocomplete code after patron found
14:30 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 normal, P5 - low, ---, nick, Pushed to Stable , Javascript error on article requests page
14:31 tcohen ashimema: how would you define the required permissions in the OpenAPI spec?
14:31 jenkins Project Koha_18.05_U18 build #26: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/26/
14:31 jenkins * martin.renvoize: Bug 6647: Revert - Label item search should use standard pagination
14:31 jenkins * Tomás Cohen Arazi: Bug 20942: OpenAPI spec for /patrons/{patron_id}/account
14:31 jenkins * Tomás Cohen Arazi: Bug 20942: Unit tests for /patrons/{patron_id}/account
14:31 jenkins * Tomás Cohen Arazi: Bug 20942: Add route to get patron's account balance
14:31 jenkins * Tomás Cohen Arazi: Bug 20942: Split debit and credit lines
14:31 jenkins * Tomás Cohen Arazi: Bug 20942: (QA follow-up) Use $lines->total_outstanding
14:31 jenkins * oleonard: Bug 21038: Reserves should be holds
14:31 jenkins * Jonathan Druart: Bug 20079: Display stack trace for development installations
14:31 jenkins * josef.moravec: Bug 20806: Add item type description holds history page
14:31 jenkins * Jonathan Druart: Bug 20806: Do not rely on column position
14:31 jenkins * Jonathan Druart: Bug 20806: Surround string by span tag to help translation
14:31 jenkins * oleonard: Bug 16575: Irregular behaviour using window.print() followed by
14:31 jenkins * katrin.fischer: Bug 16575: (follow-up) Compiled CSS
14:31 jenkins * Nick Clemens: Bug 21076: Don't call autocomplete code after patron found
14:32 Freddy_Enrique Good mroning everyone+
14:32 jenkins Project Koha_18.05_D9 build #30: UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/30/
14:32 jenkins * martin.renvoize: Bug 6647: Revert - Label item search should use standard pagination
14:32 jenkins * Tomás Cohen Arazi: Bug 20942: OpenAPI spec for /patrons/{patron_id}/account
14:32 jenkins * Tomás Cohen Arazi: Bug 20942: Unit tests for /patrons/{patron_id}/account
14:32 jenkins * Tomás Cohen Arazi: Bug 20942: Add route to get patron's account balance
14:32 jenkins * Tomás Cohen Arazi: Bug 20942: Split debit and credit lines
14:32 jenkins * Tomás Cohen Arazi: Bug 20942: (QA follow-up) Use $lines->total_outstanding
14:32 jenkins * oleonard: Bug 21038: Reserves should be holds
14:32 jenkins * Jonathan Druart: Bug 20079: Display stack trace for development installations
14:32 jenkins * josef.moravec: Bug 20806: Add item type description holds history page
14:32 jenkins * Jonathan Druart: Bug 20806: Do not rely on column position
14:32 jenkins * Jonathan Druart: Bug 20806: Surround string by span tag to help translation
14:32 jenkins * oleonard: Bug 16575: Irregular behaviour using window.print() followed by
14:32 jenkins * katrin.fischer: Bug 16575: (follow-up) Compiled CSS
14:32 jenkins * Nick Clemens: Bug 21076: Don't call autocomplete code after patron found
14:33 caroline Good morning Freddy_Enrique !
14:33 Joubu tcohen: I have just removed this (^) verbose mode for all jobs
14:34 tcohen cool
14:34 ashimema sorry.. got lost on the Jenkins fun there tcohen
14:34 ashimema so..
14:34 oleonard Bug 21149 is not cool
14:35 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 blocker, P5 - low, ---, koha-bugs, NEW , Administrator creation in onboarding always fails
14:35 ashimema you're looking at creating dual routes.. one for public access and one for authenticated access
14:35 ashimema is that what you were saying
14:36 ashimema I think I wasn't really sure what I thought to be honest
14:36 tcohen it is the easiest way in my opinion, because I didn't manage to think of a proper way for defining the permissions
14:36 tcohen say you get a 401, then what?
14:36 tcohen you log in, you get a 403?
14:36 tcohen it doesn't sound bad ha
14:37 tcohen it only bothers me that we cannot define that on the spec
14:38 tcohen maybe we can use Content-type: schema=public
14:38 tcohen on the request
14:38 Joubu oleonard: I will have look
14:38 tcohen and check there's x-public fields
14:39 tcohen (in V1/Authpm)
14:39 Joubu oleonard: did you see my patch on bug 20044? It fixes the select2 width problem for me
14:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 enhancement, P5 - low, ---, oleonard, Failed QA , Switch single-column templates to Bootstrap grid: Cataloging
14:39 tcohen - Requested public schema, x-public fields exist => bypass x-koha-permission
14:42 Joubu oleonard: if you have a "small bugs I want to work on rainy days" list, could you add this one: https://screenshots.firefox.com/eP5S6Odk5TAtFiLJ/pro.kohadev.org
14:43 Joubu the "To" is really misplaced on few window's widths
14:47 fridolin Our sandboxes are live again
14:47 oleonard @wunder 45701
14:47 cait woohoo
14:47 huginn oleonard: Athens, OH :: Overcast :: 71F/22C | Thursday: Scattered thunderstorms developing this afternoon. High 78F. Winds light and variable. Chance of rain 50%. Thursday Night: Considerable cloudiness. A stray shower or thunderstorm is possible. Low 67F. Winds light and variable.
14:47 fridolin on a fresh new server
14:47 cait fridolin++ biblibre++
14:47 oleonard Joubu: The forecast looks cooperative.
14:47 fridolin thanks cait go testing ;)
14:47 cait heh, emailing my contact who told me instead :P
14:48 Joubu haha :)
14:50 jenkins Project Koha_18.05_D8 build #31: STILL UNSTABLE in 19 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/31/
14:51 cait @wunder Konstanz
14:51 huginn cait: Konstanz, Germany :: Clear :: 88F/31C | Wind Chill: 88F/31C | Heat Index: 89F/32C | Thursday: Partly cloudy. Lows overnight in the upper 60s. Thursday Night: Some clouds. Low 68F. Winds NE at 5 to 10 mph.
14:51 cait any chance for rain gone...
14:52 Joubu bug 21149 would have never existed with bug 19185
14:52 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21149 blocker, P5 - low, ---, jonathan.druart, Needs Signoff , Administrator creation in onboarding always fails
14:52 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Web installer and onboarding tool selenium test
14:53 Joubu just saying..
14:53 ashimema right.. I think I see where you're going tcohen
14:53 ashimema will need to mull it over a bit.. think the heat is melting my brain
14:55 Joubu ashimema: !
14:55 jenkins Project Koha_Master_D8 build #22: SUCCESS in 24 min: https://jenkins.koha-community.org/job/Koha_Master_D8/22/
14:55 Joubu ashimema: https://jenkins.koha-community.org/job/Koha_18.05_D8/31/ you backported bug 20942, which depended on
14:55 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 new feature, P5 - low, ---, tomascohen, Pushed to Stable , Add route to get patron's account balance
14:55 Joubu bug 20990, which is *not* backported
14:55 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Add Koha::Account::outstanding_credits
14:55 Joubu koha_1 | Can't locate object method "add_credit" via package "Koha::Account" at t/db_dependent/api/v1/patrons_accounts.t line 128.
14:56 * ashimema is looking now joubu
14:56 ashimema but thanks for pointing it out
14:59 cait y
14:59 ashimema crap indeed
14:59 ashimema fixing now.. annoyed at myself for missing that..
15:00 * cait sends icecream
15:00 ashimema I need to improve my git hook
15:00 Joubu ashimema: yes and 20990 depends on another not backported one
15:00 Joubu ashimema: what's your plan?
15:01 * ashimema is working backwards to see how viable backporting is
15:01 ashimema if not it'll be to revert the top one
15:01 ashimema hmm.. I had a point on bug 20980.
15:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 normal, P5 - low, ---, tomascohen, RESOLVED FIXED, Manual credit offsets are stored as debits
15:02 ashimema it changes some internal expectations
15:04 ashimema what do you think Joubu.. will backporting bug 20980 be a pain for end users you reckon
15:05 reiveune bye
15:05 ashimema well.. end users meaning support companies in high likelyhood.. with possibly the odd librarian writing a report that would now yield a different result I think.
15:05 Joubu I would revert, squash and push
15:06 Joubu did you ask tcohen?
15:06 ashimema yup
15:15 jenkins Project Koha_18.05_D9 build #31: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/31/
15:19 jenkins Project Koha_18.05_U18 build #27: STILL UNSTABLE in 46 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/27/
15:25 ashimema pushed.. hope that silences jenkins
15:30 tcohen account offsets are not used in the code
15:48 jenkins Yippee, build fixed!
15:48 jenkins Project Koha_18.05_D9 build #32: FIXED in 24 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/32/
15:49 jenkins Yippee, build fixed!
15:49 jenkins Project Koha_18.05_D8 build #32: FIXED in 23 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/32/
15:57 Freddy_Enrique Jenkins....why does it sounds so familiar that name...
15:58 * Freddy_Enrique starts searching
16:00 cait product name
16:00 cait https://jenkins.io/?
16:04 Freddy_Enrique I knew it!!
16:04 Freddy_Enrique thanks cait
16:04 caroline I thought Jenkins was a butler or something like that
16:04 cait i think that#s the idea - from the logo
16:04 * caroline speaks with an English accent "Thank you Jenkins, you may dispose"
16:04 cait the project chenged its name once, but i forgot the former name
16:04 cait hehe
16:05 eythian Hudson
16:07 Freddy_Enrique So.. Jenkins must be so elegant... with everything he does
16:08 caroline He definitely has a mustache
16:08 caroline and elegant waxed mustache ;)
16:08 * cait is not thinking of kidcl
16:08 cait kidclamp
16:08 Joubu "STILL UNSTABLE" is not much elegant
16:09 cait heh
16:09 Freddy_Enrique heh
16:10 jenkins Project Koha_18.05_U18 build #28: STILL UNSTABLE in 43 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/28/
16:11 caroline I imagine him more like a disembodied voice that yells stuff once in a while... like in the Heart of Gold
16:24 oleonard Thanks caroline, now I'm playing the online version of the Hitchhiker's Guide to the Galaxy interactive fiction game and I'm getting nothing done and I'm fired.
16:25 caroline :( sorry! It was so improbable, it was bound to happen
16:32 cait heh
16:32 cait i love you, #koha :)
16:33 Freddy_Enrique X2
16:36 * oleonard gets the babel fish
16:49 cait working on granular admin permissions...
16:49 cait why do we have so many things to admin?
16:53 ashimema hmm..
16:53 ashimema U18 still unstable makes me an unhappy person
17:13 ashimema right, I'm done for the night (unless Jenkins throws errors at the end of this build).. have a good evening #koha
17:16 tcohen ashimema: we can solve them tomorrow anyway :-D
17:20 caroline Woo! Eric said I'm going to KohaCon! :D
17:21 oleonard Yay!
17:24 * ashimema gets upset again that he can't make it
17:26 * caroline apologizes to ashimema :(
17:26 * caroline is canadian and therefore apologizes for everything :/
17:29 cait caroline++ awesome!
17:30 cait oleonard: you don't agree that the column visibility should not show to end users in the opac?
17:31 oleonard We deliberately added column visibility to the OPAC. I assume that means *someone* wanted it.
17:31 oleonard I personally think it's unlikely that any patron really wants to fiddle with it.
17:32 cait i think the idea was to make the table configurable
17:32 cait witout having the user do so
17:32 cait that's what the holdings table is like
17:32 cait we just tested the feature in 17.11 - it only allows config from the intranet
17:33 cait so it showing up is either a new feature or a regression
17:33 cait i tend to regression, becuase it doesn't really look nice
17:33 cait and as you said, i think users don't want to fiddle with that
17:34 cait the other on the subscription was because we couldn't agree on which column to show for the date
17:34 cait i think both patches only wanted to use the intranet configuration part
17:34 cait tcohen: around?
17:35 jenkins Project Koha_18.05_U18 build #29: STILL UNSTABLE in 27 min: https://jenkins.koha-community.org/job/Koha_18.05_U18/29/
17:37 jenkins Project Koha_18.05_D9 build #33: UNSTABLE in 27 min: https://jenkins.koha-community.org/job/Koha_18.05_D9/33/
17:40 cait oleonard: sorry, hope that made sense (seem I am talking a bit much)
17:41 Joubu cait: ha, just commenting on the bug
17:41 cait poor oleonard
17:41 cait going to warm up dinner
17:42 oleonard cait: Yes that makes sense
17:42 oleonard cait: Looking at the patch on Bug 16759 I assumed that the button appeared then
17:42 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Make OPAC holdings table configurable
17:43 Joubu oleonard: nope, after 16759 the buttons did not appeared
17:45 jenkins Project Koha_18.05_D8 build #33: UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_18.05_D8/33/
17:52 oleonard I see... The problem is that 16759 added the "B" dom configuration to show buttons, but the buttons plugin was not added in the OPAC
17:53 oleonard When 7547 added the buttons plugin, suddenly a wild button appears.
18:11 ashimema just doing dinner, then will come back to the failing Jenkins.. on first look it seems to be a simple enough merge error 😊
18:23 cait you can do it:)
18:23 cait wild button sounds like a pokemon
19:27 oleonard https://zivotdesign.com/p/view.php?p=15332380426950
19:28 oleonard Check it out and see you later
19:36 tcohen oleonard: can we add some padding on the left? so it is closer to the bottom padding
19:51 cait i like it
20:16 Joubu [off] Have you ever violated any law related to possessing, using, or distributing illegal drugs?
20:16 Joubu we can lie, right? Or they know everything?
20:16 cait doing your ESTA?
20:16 Joubu yes, trying to not abandon before the end
20:16 cait read carefully, give reasonable answers :)
20:17 rangi heh
20:18 Joubu ho it's "no" to everything, I was sure there was a trick
20:18 rangi the main thing they ask you about
20:18 rangi (at immigration)
20:19 rangi is why you coming, and where are you staying
20:19 rangi they really hate it if you dont know where you are staying
20:19 caroline and when are you leaving ;)
20:19 rangi yep
20:19 rangi i think it must be at least 15 times for me now
20:19 rangi through/to the US
20:19 Joubu they put "physical or mental disorder", "drug abuser or addict" and "following diseases: Cholera, Yellow Fever" on the same line...
20:19 rangi yeah
20:20 rangi before the ESTA
20:20 rangi you had a green visa waiver card, you had to fill out
20:20 rangi that asked if you were a nazi
20:20 caroline lol!
20:20 rangi i think it had been the same questions since 1945
20:21 Joubu "For verification purposes, please re-enter the following information, as shown on your ESTA-eligible passport."
20:21 Joubu almost there, almost there......
20:21 rangi :)
20:21 rangi im lucky that i did one last year
20:21 rangi and its still valid
20:22 caroline I'm so glad we have nafta
20:22 Joubu [off] on the first form I had "Address Validation: Invalid Street Name." so I had to put something wrong...
20:22 caroline Oh wait...
20:22 Joubu [off] yes I am pananoid, I off it
20:24 caroline Joubu: that's why they are asking you a bunch of weird questions. you failed at the easy ones ;)
20:25 rangi Joubu: do you do immigration in LAX ?
20:25 Joubu I think so yes
20:25 rangi me too
20:26 rangi probably a while before you though
20:26 rangi i land at la at 9am
20:26 cait [off] I think i remember the nazi question from my first easta for reno?
20:27 Joubu heh not sure I land on Aug 22 ;) Visiting my bro in Canada for ~10d before Portland
20:27 rangi ahhhh
20:28 rangi good thinking
20:29 cait tcohen: around?
20:38 Joubu [off] AD - I have just tried for the first time my "transferwise card" to pay in a foreign currency, and it costs me 0.04€, with the same exchange rate as xe.com. I usually pay 0.5€ per transaction with other cards
20:41 rangi [off] ohh thats good to know!
20:41 rangi https://myhopcard.com/home/ <-- this looks like the best deal for transport in portland (speaking of cards)
20:42 rangi works on trains, light rail, buses and street cars $3 to get a card the $5 a day pass unlimited travel
20:42 rangi in theory i could put it on my nfc phone, but too paranoid for that
20:43 Joubu ha, I read "hop", I am disappointed
20:43 rangi heh
20:43 caroline it's not hop?
20:44 rangi i think it is?
20:46 * rangi goes off to a meeting
20:46 cait i am sure you guys are going to find a craft beer place
20:47 cait you always do
20:47 rangi its impossible not to
20:47 rangi there are 4 craft beer taps in teh hotel for a start :)
20:47 rangi ok now im really going
20:47 cait ... *sigh*
20:52 Joubu bye #koha
21:29 eythian https://www.vox.com/first-person/2018/7/26/17616516/amazon-silicon-valley-libraries-forbes
21:30 wizzyrea heh
21:30 wizzyrea the librarian outrage over that one was righteously epic
21:30 wizzyrea they ended up taking down the article
21:31 wizzyrea over the forbes one, not this vox article
21:32 eythian Yeah, I haven't seen the original, but based on what that one says it seemed pretty silly.
22:04 cait someone still awake?
22:09 cait just looking for someone to try and modify sru mappings
22:19 rangi hmm?