Time  Nick           Message
01:10 tcohen         hi
01:12 tcohen         @seen cait
01:12 huginn         tcohen: cait was last seen in #koha 3 hours, 43 minutes, and 41 seconds ago: <cait> *sigh*
01:12 bag            heya tcohen
01:13 * tcohen       is checking his TODO list before bed he
01:14 bag            :D
01:15 tcohen         @seen Joubu
01:15 huginn         tcohen: Joubu was last seen in #koha 3 hours, 55 minutes, and 0 seconds ago: <Joubu> yeah, we should clean the logs at some point...
02:17 huginn         News from kohagit: Bug 21087: (QA follow-up) Fix usage in create_superlibrarian.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dec983ec1b12de0e95aa0d64fc6e32a9d5b3fece>
02:17 huginn         News from kohagit: Bug 21087: Fix create_superlibrarian.pl script <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9add683d82b1a6db3cf62be5dca8d16c4d328207>
02:17 huginn         News from kohagit: Bug 21087: Do not store the password in ->store for existing patrons <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=135cb68db39d1eed8db6fe2ad31d1e62f8579dab>
02:17 huginn         News from kohagit: Bug 21087: Fix one wrong call <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ce1f9033fbdccb883673577868fa6d74e357cf60>
02:17 huginn         News from kohagit: Bug 21087: Hash passwords in ->update_password <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2e6fb40ef8296ba474e8338c4a55cc2804aa73be>
02:17 huginn         News from kohagit: Bug 21087: Test to describe the issue <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3d41d947d2760e0502607ddad20e13f2dd8677d0>
02:45 jenkins        Project Koha_Master_U18 build #15: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_Master_U18/15/
02:52 jenkins        Project Koha_Master_D8 build #16: STILL UNSTABLE in 34 min: https://jenkins.koha-community.org/job/Koha_Master_D8/16/
02:54 jenkins        Project Koha_Master_D9 build #515: STILL UNSTABLE in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D9/515/
06:08 * ashimema     is back today... Lots and lots of patches to go through
06:36 reiveune       hello
06:36 wahanui        salut, reiveune
06:49 * magnuse      waves
06:52 alex_a         bonjour
06:52 wahanui        privet, alex_a
06:55 fridolin       hi there
06:55 wahanui        what's up, fridolin
06:56 fridolin       very hot wahanui
07:54 * andreashm    waves
08:00 tuxayo         cait: Joe Doe has a signoff in master :D https://gitlab.com/koha-community/Koha/commit/135cb68db39d1eed8db6fe2ad31d1e62f8579dab
08:00 tuxayo         bug 21087
08:00 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 critical, P5 - low, ---, jonathan.druart, Pushed to Master , Patron's password is hashed twice when the object is saved
08:14 magnuse        @wunder bodø, norway
08:14 huginn         magnuse: Error: I could not find a valid location for: bodø, norway
08:15 magnuse        @wunder bodo, norway
08:15 huginn         magnuse: Bodo, Norway :: Mostly Cloudy :: 75F/24C | Tuesday: Partly cloudy. High 81F. Winds ENE at 10 to 20 mph. Tuesday Night: Mostly cloudy skies this evening will become partly cloudy after midnight. Low 69F. Winds ESE at 10 to 20 mph.
08:15 andreashm      @wunder stockholm
08:15 huginn         andreashm: Stockholm, Sweden :: Mostly Cloudy :: 66F/19C | Tuesday: Partly cloudy. High near 80F. Winds SSW at 5 to 10 mph. Tuesday Night: Partly cloudy skies. Low near 60F. Winds S at 5 to 10 mph.
08:15 andreashm      19? Hah. Something seems broken.
08:16 andreashm      More like 27C.
08:16 andreashm      hi magnuse btw
08:21 kohaputti      has somebody else here thought about reducing the amount of new database connections Koha makes per request?
08:23 kohaputti      One would be enough, right? But now it makes like 80 depending on the web page loaded.
08:23 magnuse        tjänare andreashm
08:23 magnuse        kohaputti: i'm sure a fix for that would be most welcome :-)
08:24 kohaputti      magnuse, some sort of singleton is in my thoughts right now. Any other ideas?
08:28 kohaputti      I don't know if turning Koha::Database to a singleton would work, or if it would cause some problems
08:28 kohaputti      I should try :)
08:28 kohaputti      soo even when one would call Koha::Database->new it would return the old connection
08:28 kohaputti      (if there is one)
08:29 kohaputti      Now the Koha codebase is full of calls like "Koha::Database->new" and the returned object (that has the connection) is not saved anywhere
08:33 kohaputti      So Koha::Database->new creates a new connection using C4::Context->new() but it only uses information like username, password, db host, which should be the same always unless koha-conf.xml is changed, right?
08:34 kohaputti      soo as far as I understand, it would be fine to make it a singleton. Or can one Koha instance talk to multiple different databases at the same time?
08:51 magnuse        kohaputti: that is a bit beyond me, but i did see some code comments about connecting to different databases. let me see if i can find it
08:52 magnuse        kohaputti: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Context.pm;h=41bce3b93d18f08b65de525d1a53780582bdb685;hb=HEAD#l138
08:54 magnuse        those lines have not been changed since 2002-10-02...
08:55 magnuse        my guess would be noone is actually using that
09:21 kohaputti      magnuse, thanks a lot! :) I think a setting preference for that might still be possible
09:23 kohaputti      though, making Koha fast by default would be better
09:28 andreashm      fast by default does sound good!
09:29 andreashm      As long as it does not affect database clustering etc. But I guess those who do that can tweak the code if needed.
10:41 Joubu          kohaputti: Are you sure it's 80 DB connections per request, how did you count?
10:42 Joubu          see also bug 19819
10:42 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 enhancement, P5 - low, ---, glasklas, Failed QA , C4::Context->dbh is unreasonably slow
10:42 Joubu          and `git log -p Koha/Database.pm` :)
10:42 Joubu          we need to keep the "ping"
10:43 kohaputti      I used nprof (profiler) and it said there was ~80 calls to Koha::Database->new that spend some tens of milliseconds, so it sounds like it is opening a new connection each time
10:43 kohaputti      ahaa, Joubu so it looks like somebody has tried to tackle this already!
10:43 kohaputti      thanks :)
10:47 Joubu          kohaputti: it's a too naive approach, but we could try and reduce it to 1
10:48 Joubu          but you will face some hidden bugs, like in the zebra daemon
10:48 raktajino18    With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
10:48 Joubu          10ms is not that much ;)
10:48 raktajino18    I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
10:48 raktajino18    or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
10:48 raktajino18    Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate
10:49 Joubu          mst++
11:03 kohaputti      Joubu, it added up to 3 seconds so I think it was like 40ms to establish connection. And probably 1 connection per request is the one we are looking for. I'm gonna read up a bit on the topic and look into the previous work, this sounds a really interesting problem to solve! :)
11:04 Joubu          tcohen: around?
11:07 Joubu          kohaputti: if it adds up to 3sec, I guess you have your DBMS running on a separate server and you had issues on the network :)
11:07 kohaputti      that's correct
11:13 Joubu          @later tell tcohen Trying to understand the last 18.05 D8 failures - https://jenkins.koha-community.org/job/Koha_18.05_D8/lastCompletedBuild/console
11:13 huginn         Joubu: The operation succeeded.
11:13 Joubu          @later tell tcohen there is something bad in our Exception modules:
11:13 huginn         Joubu: The operation succeeded.
11:14 Joubu          @later tell tcohen http://paste.koha-community.org/41
11:14 huginn         Joubu: The operation succeeded.
11:16 Joubu          @later tell tcohen Should not it be ->throw($_); instead? see Koha/Patron/Modification.pm:149
11:16 huginn         Joubu: The operation succeeded.
11:22 Joubu          @later tell tcohen something else, could you push the follow-up on bug 19604?
11:22 huginn         Joubu: The operation succeeded.
11:22 Joubu          (so nobody cares about jenkins failures?)
11:32 Joubu          @later tell tcohen as well as the last patch on bug 19166 - it will turn jenkins happy for master on D8
11:32 huginn         Joubu: The operation succeeded.
11:37 ashimema       sorry joubu.. i'd care except i'm only just back from leave snd am nowhere near caught up with the coms backlog yet ;)
11:38 dan3wik        With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
11:38 dan3wik        I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
11:38 dan3wik        or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
11:38 dan3wik        Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate
12:03 Joubu          ashimema: can you confirm you tested bug 18947?
12:03 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 major, P5 - low, ---, nick, Signed Off , Unexpected Active Directory LDAP authentication failure mode
12:04 Joubu          code looks ok to me, but cannot test (easily)
12:04 Joubu          I am willing to PQA it if you tested it
12:23 cait           @wunder Konstanz
12:23 huginn         cait: Konstanz, Germany :: Clear :: 92F/33C | Wind Chill: 92F/33C | Heat Index: 92F/33C | Tuesday: Sunny. Very hot. High 93F. Winds light and variable. Tuesday Night: Mainly clear. Low near 70F. Winds light and variable.
12:23 cait           i was outside... and I tihnk it was trying to kill me
12:25 andreashm      =)
12:25 andreashm      @wunder Stockholm
12:25 huginn         andreashm: Stockholm, Sweden :: Partly Cloudy :: 76F/24C | Tuesday: Partly cloudy. High 78F. Winds S at 5 to 10 mph. Tuesday Night: Partial cloudiness early, with scattered showers and thunderstorms overnight. Low near 60F. Winds S at 5 to 10 mph. Chance of rain 40%.
12:33 * ashimema     looks at the bug again.. pretty sure I tested it...
12:35 ashimema       yup.. I tested it
12:40 cait           andreashm: 24... so jealous
12:42 andreashm      cait: not so sure about that number. the national weather service says 29C here. =)
12:45 cait           hm inernet says 34
12:45 cait           maybe the westher service is a little optimistic
12:50 andreashm      seems so.
13:00 caroline_      good morning everyone!
13:00 andreashm      hi caroline_
13:06 Joubu          any ES users around?
13:07 Joubu          which version(s) of ES are we suppose to support? alex_a_ maybe?
13:09 alex_a_        Joubu, 5.x for the moment
13:10 alex_a_        But there some patches which make compliant or remove the use of copy_to feature so that we can support 6.x
13:10 Joubu          alex_a_: I have 5 installed but I get an error when I try to reindex
13:10 alex_a_        Joubu, which one?
13:10 Joubu          "[illegal_argument_exception] Custom Analyzer [analyser_standard] failed to find tokenizer under name [icu_tokenizer"
13:12 alex_a_        Joubu, did you install icu plugin ?
13:13 Joubu          I tried, but... do we have a doc somewhere?
13:13 Joubu          I did that `sudo /usr/share/elasticsearch/bin/elasticsearch-plugin install analysis-icu`
13:14 Joubu          so yes I think I installed it
13:16 magnuse        @wunder bodo, norway
13:16 huginn         magnuse: Bodo, Norway :: Mostly Cloudy :: 79F/26C | Tuesday: Mainly cloudy. A few peeks of sunshine possible. High 81F. Winds E at 10 to 15 mph. Tuesday Night: Mostly cloudy skies this evening will become partly cloudy after midnight. Low 68F. Winds ESE at 10 to 20 mph.
13:17 alex_a_        Joubu, what does that tell: curl -XGET 'http://localhost:9200' ?
13:18 Joubu          "number" : "5.0.0-alpha5",
13:18 Joubu          "lucene_version" : "6.1.0"
13:18 Freddy_Enrique Hi world
13:18 Freddy_Enrique Hi Joubu
13:19 Joubu          hola Freddy_Enrique
13:19 Freddy_Enrique :)
13:20 alex_a_        Joubu, curl -XGET 'http://localhost:9200/_cat/indices'
13:23 Joubu          yellow open koha_kohadev_mydb        ho74Aq-tSF-m9ZI5sz0pMg 5 1    0 0   810b   810b
13:23 Joubu          yellow open koha_kohadev_biblio      wTs0sn6kR8uwO6nTW1LxlA 5 1   29 0 82.4kb 82.4kb
13:23 Joubu          yellow open koha_kohadev_authorities 2EMhk5rpTJOA1UM0ZOZmlQ 5 1 1706 0  1.9mb  1.9mb
13:26 alex_a_        Joubu, curl -XGET 'http://localhost:9200/koha_kohadev_biblios/_search?q=title:a'
13:26 alex_a_        some results?
13:26 Joubu          nope, the index does not exist
13:27 Joubu          {"error":{"root_cause":[{"type":"index_not_found_exception","reason":"no such index","resource.type":"index_or_alias","resource.id":"koha_kohadev_biblios","index_uuid":"_na_","index":"koha_kohadev_biblios"}],"type":"index_not_found_exception","reason":"no such index","resource.type":"index_or_alias","resource.id":"koha_kohadev_biblios","index_uuid":"_na_","index":"koha_kohadev_biblios"},"status":404}%
13:28 alex_a_        Joubu, koha_kohadev_biblio (without the s) sorry
13:28 Joubu          {"koha_kohadev_biblio":{"aliases":{},"mappings":{"data":{"properties":{"es_id":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}},"record":{"type":"text","store":true,"include_in_all":false}}}},"settings":{"index":{"creation_date":"1495094328842","analysis":{"analyzer":{"analyser_phrase":{"filter":["lowercase"],"tokenizer":"keyword"},"analyser_standard":{"filter":["lowercase"],"tokenize
13:29 Joubu          r":"standard"}}},"number_of_shards":"5","number_of_replicas":"1","uuid":"wTs0sn6kR8uwO6nTW1LxlA","version":{"created":"5000005"}}}}}%
13:29 Joubu          should not be biblio*s*?
13:29 Joubu          41 Readonly our $BIBLIOS_INDEX     => 'biblios';
13:30 alex_a_        your index name is koha_kohadev_biblio
13:30 Joubu          I guess the one without the s is an old one
13:30 Joubu          no, I did a rebuild -d, so it removed the biblio*s* index
13:31 Joubu          I did a -d -a and /indices does not longer display authorities
13:31 alex_a_        _cat/indices tells that your "biblio" index is koha_kohadev_biblio. Not koha_kohadev_biblios
13:31 alex_a_        You got an error while reindexing?
13:32 alex_a_        you mean that koha_kohadev_authorities has been deleted after reindexing?
13:33 Joubu          /indices shows an old index, biblios and authorities are now dropped, I do a `rebuild -b` and I get the same error "failed to find tokenizer under name [icu_tokenizer]"
13:33 Joubu          not after indexing, after rebuild -d (-d for delete)
13:38 tcohen         morning
13:38 caroline_      good morning tcohen !
13:38 alex_a_        Joubu, it seems to be related to the ICU plugin
13:38 alex_a_        Did you restart ES after installing it?
13:39 Joubu          no
13:40 Joubu          ho
13:40 Joubu          great
13:40 Joubu          new error...
13:40 Joubu          "Mapping definition for [fields] has unsupported parameters:  [normalizer : my_normalizer]"
13:41 tcohen         Joubu: ->throw($_);, that's correct
13:42 alex_a_        Joubu, are you testing bz 19604?
13:42 alex_a_        Oh, it's pushed on master
13:43 * alex_a_      tests with a branch up to date
13:45 Joubu          I do not have the elasticsearch_config entry in my koha-conf, so the yaml files are used
13:45 huginn         News from kohagit: Bug 19166: Remove 'IF NOT EXISTS' in kohastructure <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a5492ce96bf4cbf93b91014b8b1b0fbb839a5084>
13:45 huginn         News from kohagit: Bug 19604: Fix perlcritic "Loop iterator is not lexical" <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4d45bd575569880676a212655d3d747f368697e4>
13:46 alex_a_        Joubu, that means it use config files in admin/searchengine. That should not be a problem
14:15 jenkins        Project Koha_Master_U18 build #16: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_Master_U18/16/
14:21 jenkins        Yippee, build fixed!
14:21 wahanui        o/ '`'`'`'`'`'`'`'`'`
14:21 jenkins        Project Koha_Master_D9 build #516: FIXED in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D9/516/
14:21 jenkins        Yippee, build fixed!
14:21 wahanui        o/ '`'`'`'`'`'`'`'`'`
14:21 jenkins        Project Koha_Master_D8 build #17: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/17/
14:36 Joubu          alex_a_: it finally works
14:36 Joubu          I just install ES 5.6 and the plugin
14:36 Joubu          alex_a_: there is not install doc to follow?
14:36 cait           @seen LeeJ
14:36 huginn         cait: LeeJ was last seen in #koha 1 week, 0 days, 20 hours, 25 minutes, and 40 seconds ago: <LeeJ> tcohen: around?
14:38 tcohen         Joubu: https://wiki.koha-community.org/wiki/Elasticsearch
14:38 tcohen         ??
14:38 cait           hm?
14:39 cait           you were ht elast person he wanted to talk to... and now he has vanished
14:39 cait           anything to say about that?
14:40 cait           oh no oleonard
14:40 caroline_      oleonard has also vanished it seems
14:41 * cait         suspects tcohen
14:41 Karen_         user has a fine and the sale the error from the opac, Can not call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217.  Thank you
14:41 cait           hi Karen_ - which vresion of Koha are you using?
14:41 alex_a_        Joubu, i read community one plus the official ES one
14:41 cait           you can find the exact version number on the about page
14:42 Karen_         Versión de Koha:	18.05.00.000
14:43 Joubu          I do not know why I had 5.0-alpha and 'apt install' did not update it to the correct version
14:43 cait           Karen_: please try to update to hte latest bugfix release
14:44 cait           the latest is 18.05.02 - with a lot of bugs fixed
14:44 cait           https://koha-community.org/koha-18-05-02-release/
14:44 cait           i think you might have run into bug 20832
14:44 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832 critical, P5 - low, ---, josef.moravec, RESOLVED FIXED, Opac user page crash when there is an overdue fine and not any rental charge for a patron
14:45 cait           this was fixed with version 18.05.01 - but if you upgrade go to 18.05.02
14:46 tcohen         cait: I can't tell you what happened
14:49 tuxayo         Can someone try create_superlibrarian.pl on master? Running the following makes Koka scream.
14:49 tuxayo         (adjust your branch and category)
14:49 tuxayo         misc/devel/create_superlibrarian.pl --userid superlib --password superlib --branchcode BDP --categorycode A_EXT --cardnumber superlib
14:49 tcohen         tuxayo: is your master up to date?
14:50 tcohen         I've pushed some patches that deal with that
14:50 tcohen         last night
14:50 wahanui        last night is the name of a yogurt
14:55 tuxayo         tcohen: yes, up to date. I get
14:55 tuxayo         DBD::mysql::st execute failed: Column 'privacy' cannot be null [for Statement "INSERT INTO `borrowers` ( `borrowernumber`, `branchcode`, `cardnumber`, `categorycode`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `flags`, `guarantorid`, `password`, `privacy`, `privacy_guarantor_checkouts`, `sms_provider_id`, `surname`, `userid`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=undef, 1='BDP', 2='593485945',
14:56 tuxayo         3='A_EXT', 4='2018-07-31T16:55:47', 5='2019-07-31T16:55:47', 6=undef, 7=undef, 8='1', 9=undef, 10='!', 11=undef, 12=0, 13=undef, 14=undef, 15='1'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.
14:56 tuxayo         DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy' cannot be null at /home/koha/src/Koha/Object.pm line 125
14:59 Karen_         Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217.
15:02 cait           Karen_: did you see my answer above?
15:02 cait           you need to update, this bug has been fixed.
15:04 Joubu          tuxayo: works for me
15:04 Joubu          `privacy` int(11) NOT NULL DEFAULT '1',
15:05 tuxayo         Joubu: thanks, that confirms that the usage of the command is correct. That was the aim :)
15:05 Joubu          tuxayo: maybe it's a bug, hidden
15:06 Joubu          tuxayo: select default_privacy from categories;
15:06 Joubu          I guess it comes from there
15:06 Joubu          it should be "default", "never", or "forever"
15:07 Joubu          otherwise privacy will be set to undef and you will get this error
15:07 cait           no khall either... what's this?
15:07 cait           aliens stealing koha-devs?
15:08 tuxayo         Joubu: there might something very wrong with the UNIMARC demo data ^^" https://privatebin.net/?a1a66834955d5c60#GYe982n2yPa3NnAOl2yTYAAxT8iaq5MH9bjYpI0EXZI=
15:08 tuxayo         cc fridolin  matts  ↑
15:08 Joubu          ha unimarc... lol
15:08 Joubu          ;)
15:08 tcohen         UNIwhat?
15:09 Joubu          tuxayo: set privacy="default" then
15:09 Karen_         is the only solution to update the error, Can not call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217, thanks for your answers
15:10 Joubu          it could/should be fixed at code level however
15:10 Joubu          Karen_: you should not use 18.05.00 anyway, it's buggy
15:11 tuxayo         Joubu: tcohen  >_< :P
15:11 Karen_         :(
15:11 Freddy_Enrique :(
15:13 Freddy_Enrique My question is gonna sound naive.... sorry in advanced. Koha is in github?
15:13 tuxayo         Joubu: > set privacy="default" then
15:13 tuxayo         Does this mean passing --privacy="default" But there is no such param right?
15:13 tcohen         Freddy_Enrique: a mirror of the official repo is on github
15:13 tcohen         and gitlab
15:14 Freddy_Enrique a mirror... like a copy or something?
15:15 tuxayo         Freddy_Enrique: like automatic syncronizing
15:15 tuxayo         https://gitlab.com/koha-community/Koha
15:15 tuxayo         https://github.com/Koha-Community/Koha
15:15 Joubu          tuxayo: no, in you DB: update categories set privacy="default";
15:16 Freddy_Enrique tuxayo++
15:16 Freddy_Enrique thanks
15:17 Joubu          use gitlab ;)
15:18 cait           Karen_: you could fix that one error by editing a file on the server - but you will likely run into other bugs. the small upgrade would be the better solution
15:19 cait           Freddy_Enrique: we just don't use it actively, so we won't process merge/pull requests there
15:19 Karen_         Thank you
15:19 cait           did you see the bug i posted earlier?
15:20 cait           Karen_: this one is likely your problem: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832
15:20 huginn         Bug 20832: critical, P5 - low, ---, josef.moravec, RESOLVED FIXED, Opac user page crash when there is an overdue fine and not any rental charge for a patron
15:20 tuxayo         Joubu: thanks, now I get the same error as matts ^o^
15:20 tuxayo         {UNKNOWN}: Undefined subroutine &C4::Accounts::manualinvoice called at /home/koha/src/Koha/Patron.pm line 864. at /home/koha/src/Koha/Patron.pm line 347
15:20 tuxayo         It doesn't seem comming from the data this time.
15:21 Joubu          tuxayo: select enrolmentfee from categories;
15:21 tuxayo         Actually maybe, because we might have "$enrolment_fee && $enrolment_fee" in our data
15:22 Joubu          that sounds like a bug
15:22 Joubu          tuxayo: 'use C4::Accounts;' is missing on top of Koha/Patron.pm
15:23 tuxayo         Joubu: Nothing *too* suspicious: https://privatebin.net/?a49a425fbe493187#JxN4Hx8n3uincv4gQP5vV7NZGmbB7fCFwFPJUH8wsdc=
15:23 Joubu          yes it is, it's != 0 :D
15:23 Joubu          tuxayo: as I said, there is a missing use
15:24 reiveune       bye
15:27 Joubu          tuxayo: are you willing to fix it? (report with a patch)
15:27 Freddy_Enrique Hi cait :). Thanks
15:34 tuxayo         Joubu: oh see, the missing use. I can fix it between tomorrow and thusday. Is that good enough?
15:34 Joubu          I will
15:38 Joubu          bug 21133
15:38 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 major, P5 - low, ---, jonathan.druart, Needs Signoff , Missing use C4::Account statement in Koha/Patron.pm
15:40 cait           bye all bbl
15:40 caroline_      bye cait syl!
15:41 Freddy_Enrique Bye cait
15:46 tuxayo         Joubu: thanks for the patch :) it has been signed off.
15:46 Joubu          tcohen: bug 21134
15:46 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Wrong error handling in Koha/Patron/Modification.pm hides a bug
15:46 tcohen         awesome, Joubu
15:48 tcohen         Joubu: the patch is trivially correct, but is there a way to trigger the hidden bug?
15:49 Joubu          tcohen: heh nope, that's the problem
15:49 Joubu          no idea why the test failed!
15:50 tcohen         ok
15:58 Mexico         Hello everyone,I'm writing you from Mexico and my company it is called Infoestrategica, we have been working with Libraries for more than 30 years and one of our services is to install Koha www.kohalatino.info
15:59 tcohen         hola Mexico
15:59 Mexico         Hola!
16:00 Mexico         So, is this the correct place to start a request to appear in the https://koha-community.org list of developers?
16:01 Joubu          nope, use the mailing list instead
16:01 Joubu          lists?
16:01 wahanui        try 'listserv', Joubu
16:01 Joubu          listserv?
16:01 wahanui        try 'mailing list', Joubu
16:01 Joubu          mailing list?
16:01 wahanui        mailing list is at http://koha-community.org/support/koha-mailing-lists/
16:02 Mexico         thanks a lot
16:02 huginn         News from kohagit: Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6e99cfbca7e904b7664163838a334c487c94e462>
16:10 Joubu          but... demo is 3.18 and no link to koha website...
16:12 huginn         News from kohagit: Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c8996047684d70fcd8dafa9176f6dc409c934459>
16:19 nullrouted18   <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:19 nullrouted18   With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:19 nullrouted18   I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:19 nullrouted18   or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:19 ddstreet01     <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:19 ddstreet01     With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:19 ddstreet01     I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:19 ddstreet01     or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:20 Freddy_Enrique ?
16:20 nullrouted3    <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:20 nullrouted3    With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:20 nullrouted3    I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:20 nullrouted3    or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:20 caroline_      Freddy_Enrique: spam bots... -_-
16:22 huginn         News from kohagit: Bug 21032: Fix using facet for searches made on specific index <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=96f253d5ed2f1770b42f06554ebb4c4e14b3afdf>
16:23 Mikaela15      <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:23 Mikaela15      With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:23 Mikaela15      I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:23 Mikaela15      or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:24 Freddy_Enrique what.....
16:25 Freddy_Enrique but... I thougt we had the captcha images to deal with it
16:25 Mikaela12      <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:25 Mikaela12      With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:25 Mikaela12      I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:25 Mikaela12      or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:25 Freddy_Enrique the.. Prove you are not a robot!
16:26 caroline_      I guess they can go around that
16:26 Freddy_Enrique O.o...
16:27 caroline_      I think the first message is kinda funny... "I don't want to lose any teeth" ?!
16:28 BlueShark413   <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:28 BlueShark413   With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:28 BlueShark413   I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:28 BlueShark413   or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:28 BlueShark      <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:28 BlueShark      With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:28 BlueShark      I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:28 Freddy_Enrique what the...
16:28 wahanui        the is not a stop word
16:28 BlueShark      or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:29 oleonard       Hi #koha
16:29 caroline_      oleonard was not abducted by aliens!
16:29 Freddy_Enrique Is it just me or so many spams today?
16:29 Joubu          not yet
16:30 caroline_      Freddy_Enrique: not just you... It was like this yesterday too
16:30 jenkins        Project Koha_Master_U18 build #17: STILL UNSTABLE in 25 min: https://jenkins.koha-community.org/job/Koha_Master_U18/17/
16:33 Joubu          they are hitting all freenode channels, just ignore them
16:34 caroline_      Joubu: I hadn't realized it was a big scale attack
16:35 Joubu          i.e. do not click the links, do not trust what they write
16:35 Freddy_Enrique Ok
16:35 oleonard       Was someone looking for me, or was it just general concern about alien abduction?
16:35 Freddy_Enrique jajaja
16:36 Freddy_Enrique why aliens?
16:36 jenkins        Project Koha_Master_D9 build #517: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D9/517/
16:36 caroline_      oleonard: cait was wondering where you were earlier. Since you and a bunch of other regulars were missing, this was the conclusion
16:36 oleonard       Logical.
16:38 jenkins        Project Koha_Master_D8 build #18: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_Master_D8/18/
16:45 nug70025       <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:45 nug70025       With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:45 nug70025       I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:45 nug70025       or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:48 Evidlo3        <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:48 tuxayo         Freddy_Enrique: caroline_ «I guess they can go around that»
16:48 Evidlo3        With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:48 Evidlo3        I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:48 tuxayo         One way is to have a legitimate website which sometime asks for captchas. But not for itself, it would show captchas from other websites in order to attack them!
16:48 Evidlo2326     <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:48 Evidlo2326     With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:48 Evidlo3        or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:48 Evidlo2326     I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:48 Evidlo2326     or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:48 tuxayo         Could also be with a hacked website where you just add captchas from other sites to get a source of humans to solve captchas to attack them... I'm not sure what can be done against that.
16:53 caroline_      I wonder who comes up with the messages. Probably some randomizer because "reach a global audience of entrepreneurs and fentanyl addicts" is just so random!
16:54 piklu10        <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:54 piklu12        <+SP9002_@efnet> so, he wants the win. so we're just gonna get lunch or something, then hes gonna push me to the ground and tap my ass with his foot so he can claim he "kicked my ass" tbh im going along with it becase I dont wanna lose any teeth
16:54 piklu10        With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:54 piklu12        With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/
16:54 piklu10        I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:54 piklu12        I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/
16:54 oleonard       I didn't even read that part caroline_, that's really crazy
16:54 piklu10        or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:54 piklu12        or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/
16:54 oleonard       Hi piklu10 how's your life working out?
16:54 jenkins        Project Koha_Master_U18 build #18: STILL UNSTABLE in 24 min: https://jenkins.koha-community.org/job/Koha_Master_U18/18/
16:55 Freddy_Enrique Wow...this is massive
16:55 Freddy_Enrique at least...this is the fist time I see this kind of behaviour
16:56 oleonard       Same, Freddy_Enrique.
16:56 Freddy_Enrique Hi ole :)
16:57 Joubu          ops could +s the channel to make it "secret" and (maybe) not found by bots
16:57 Joubu          magnuse, rangi, bag: ^
16:58 Joubu          let's see
16:58 Joubu          thanks bag!
16:58 bag            Joubu++
16:59 Joubu          ha
16:59 Freddy_Enrique jaja, not so fast my friend!
17:02 jenkins        Project Koha_Master_D9 build #518: UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_Master_D9/518/
17:04 caroline_      Five minutes without bots! Good job Joubu! :D Joubu++
17:05 Freddy_Enrique black belt in it solutions
17:05 Freddy_Enrique Joubu++
17:05 Freddy_Enrique IT*
17:13 Joubu          yeah, seems like it did the job. Good news :)
17:13 Joubu          And, for those who does not know him, just remember that mst (Matt S. Trout) is one of the best perl programmer and author of hundreds of CPAN modules ;) Remove from your mind the stupid link you saw here the last few days
17:16 jenkins        Project Koha_Master_D8 build #19: UNSTABLE in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D8/19/
17:21 Joubu          tcohen: oooops ^
17:21 Joubu          pfff, we suck
18:37 Freddy_Enrique well, its been a nice day. See you all!
18:38 caroline_      Is it normal that when I click "Log in to add tags" on the OPAC, once I'm logged in I go to my account and I don't stay on the record I'm trying to add tags to? Would you consider that a bug or no?
18:40 oleonard       I would consider that a bug.
18:50 tcohen         @seen LeeJ
18:50 huginn         tcohen: LeeJ was last seen in #koha 1 week, 1 day, 0 hours, 39 minutes, and 26 seconds ago: <LeeJ> tcohen: around?
18:50 caroline_      oleonard: would you mind reproducing it, just in case it's just me doing something wrong (it happens... way too much)
18:51 LeeJ           hey, I'm ok, tcohen is innocent
18:51 caroline_      XD
18:53 oleonard       caroline_: Confirmed in master
18:53 caroline_      yay!
18:53 caroline_      Actually, not yay, but yay!
19:10 cait           back :)
19:11 caroline_      Hi cait!
19:11 cait           hi caroline_:)
19:11 oleonard       Look cait I'm here!
19:11 cait           oh good, no aliens after all :)
19:12 tcohen         hi ncbaratta
19:12 cait           i am trying to have a look at bug 20813
19:12 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 enhancement, P5 - low, ---, kyle, Patch doesn't apply , Revamp user permissions system
19:12 cait           I didn't so far as to see if it interferes with your interface patch yet
19:12 Joubu          cait: no please don't, I am on it :)
19:12 cait           oh?
19:12 cait           i already started and commented today :)
19:13 ncbaratta      Howdy tcohen!
19:13 cait           Joubu: it's in failed qa, so didn't expect you
19:13 cait           how is it going?
19:13 Joubu          ha no sorry, I was talking about circ rules
19:14 oleonard       cait: I saw your comment on Bug 11375 and spent some time working to resolve it... Didn't get anywhere yet.
19:14 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 enhancement, P5 - low, ---, oleonard, Failed QA , Improve patrons permissions display
19:14 cait           ah, you are fast!
19:14 cait           Joubu: don't confuse me plz, it's still way too hot here
19:14 cait           i think we had like 35 degrees today
19:15 cait           oleonard: i am going to take a look at the code of the revamp patch, i've linked them, so you probably get updates?
19:16 cait           caroline_: just seeing the bug you reported - are you usin https by chance?
19:17 cait           ah sorry, i thought it might be bug 19799, but it's about login, not about changing language
19:17 caroline_      cait: I don't think so. my master is on my computer (does that make sense?)
19:17 huginn         Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Changing language on OPAC redirects back to homepage
19:28 oleonard       Bye all. I'm back to being abducted by aliens until tomorrow.
19:30 cait           hehe
19:30 cait           caroline_: yes it does, got confused
19:30 * cait         blames Joubu
20:44 rangi          Joubu: done, dunno if it will do anything, but worth a try
20:45 Joubu          rangi: yep it worked, it did it earlier :)
20:45 Joubu          we did not see any bots since it's secret
20:45 rangi          cool
21:55 caroline_      ttyl y'all!
23:42 caroline       Hello!
23:42 rangi          welcome back
23:42 wahanui        cait abducted me.
23:42 caroline       I'm rarely on at this time. Who's time zone is it?
23:42 rangi          nz
23:43 caroline       wahanui: lol!
23:43 wahanui        caroline: i'm not following you...
23:43 caroline       wahanui: I know...
23:43 wahanui        caroline: sorry...
23:43 caroline       Well hello NZ people! :D
23:43 rangi          Kia ora :)
23:45 caroline       I wanted to share this because I think it's hilarious... Often, when I'm translating, I come across things like this https://snag.gy/yOLIkQ.jpg I don't know if it's Pootle being cheeky or someone is actually being bad at translating...
23:46 caroline       Or maybe some people trying to take all the credit ;)
23:46 rangi          hehe naw its pootle trying to be helpful, it tries to guess
23:46 rangi          however that should be marked fuzzy, only a human can accept it :)
23:48 caroline       I don't know if it was... I don't think so. I'm currently going through all the fuzzies for fr-CA
23:48 rangi          cool
23:49 caroline       only 192 left... I hope
23:53 rangi          thats not too bad
23:53 rangi          you will be in portland right?
23:56 caroline       I don't know. Eric and I haven't spoken of it again
23:57 caroline       I'll write him an e-mail right now ;)
23:57 rangi          excellent
23:57 rangi          i'd love you to demonstrate translation at the hackfest ;)
23:57 rangi          and talk about how important it is to think about translation when developing
23:58 caroline       cait already asked me to demonstrate documentation ;)
23:59 rangi          hehe now you have 2 jobs :)
23:59 caroline       2x the incentive ;)
23:59 rangi          yup :)