Time Nick Message
03:08 keith dcc lagcheck
08:40 dhanu bn
09:39 kidclamp_away morning
09:39 kidclamp morning
11:40 oleonard Hi #koha
12:14 khall Joubu: added an alternate patch to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Let me know what you think
12:15 huginn Bug 20724: critical, P5 - low, ---, victor.grousset, In Discussion , ReservesNeedReturns syspref breaks "Holds awaiting pickup"
12:25 khall @later tell joubu added an alternate patch to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Let me know what you think
12:25 huginn khall: The operation succeeded.
12:25 huginn Bug 20724: critical, P5 - low, ---, victor.grousset, In Discussion , ReservesNeedReturns syspref breaks "Holds awaiting pickup"
12:46 tcohen morning
13:00 Joubu khall: yep, sounds better indeed.
13:00 Joubu khall: maybe we should move the pref logic to AddReserve actually?
13:01 khall Joubu: yes, I think that would be a good move
13:02 khall if you want to write that I'll sign it. Or visa versa if you want
13:08 Joubu khall: I will take a look later today
13:12 caroline_ Hi all!
13:14 caroline_ Is there a sys pref like OPACFineNoRenewals but for the staff side?
13:16 caroline_ I tried RestrictionBlockRenewing but it seems not to consider fees above noissuescharge cause for restriction
13:37 AndrewIsh Hey all. I'm currently working on bug 20750. I need to record arbitrary actions / events relating to ILL requests (e.g. status change etc.). On the face of it, actions_logs seems to be the place to do that. The data that will be recorded is likely to be pretty arbitrary, but it seems like that's common in action_logs anyway. Does this sound like the correct approach or would I be better creating an illrequest_actions table and doing it there.
13:37 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 enhancement, P5 - low, ---, andrew.isherwood, ASSIGNED , Allow timestamped auditing of ILL request events
13:59 Joubu AndrewIsh: action_logs seems to be the correct approach
14:00 AndrewIsh Joubu: OK, thanks
14:22 Joubu `git grep str8` # lol
14:35 mtompset Greetings, #koha
14:36 mtompset Oh sure, run away kidclamp_away ;)
14:36 * mtompset grins.
14:38 tcohen Joubu: I'm confused, I cannot reproduce now
14:43 Joubu tcohen: hum?
14:43 Joubu remove --verbose
14:43 Joubu (if you added it)
14:50 tcohen yes
15:00 mtompset Joubu, remove a '--verbose'? Is there still a -v? Verbose is generally a good thing?
15:01 * mtompset goes to see if there is more context in the logs.
15:02 Joubu bug 20745
15:02 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 major, P1 - high, ---, tomascohen, ASSIGNED , indexing/searching not active at end of installation
15:04 mtompset Thanks for the context, Joubu
15:17 Joubu oleonard: could you take a look at that? https://screenshots.firefox.com/q2kBGZ54QswGQWG0/catalogue.kohadev.org
15:18 Joubu (icon/text alignment and no icon for sharing)
15:18 oleonard Oh yeah I've been meaning to work on that and keep forgetting.
15:19 Joubu inconsistency++
15:21 mtompset I think you meant consistency++ and inconsistency-- Joubu :)
15:21 Joubu nope, we need inconsistencies to have more work
15:22 tcohen haha
15:22 tcohen Joubu: it seems my *great weather* is heading from Cordoba to Buenos Aires, enjoy it please!
15:23 tcohen maybe buy a a canoe ahead?
15:23 Joubu oleonard: looks like there is a margin missing on the title: https://screenshots.firefox.com/PryrMjICVmiqLufJ/catalogue.kohadev.org
15:23 * cait waves
15:23 Joubu sorry to drop things like that, but I have opened too many doors already
15:24 cait hm ubuntu update uninstalled virtualbox?
15:30 * cait waves at kidclamp
15:32 * kidclamp waves back
15:42 mtompset cait, which virtualbox do you have installed blank 5.1 or 5.2?
15:42 cait it works ok now after reinstalling
15:43 cait 5.2.10
15:43 mtompset interesting. okay.
15:44 mtompset Because I just got an update to 5.2.12 :)
15:45 mtompset probably because I have the virtualbox repos added, and installed 5.2
15:45 cait yeah no repos for me, just ubuntu standard
15:46 cait tcohen: need a sign-off on 20745?
15:46 tcohen please
15:46 mtompset I went with the repos, because I was having issues getting docker and virtualbox to play nice together.
15:46 tcohen is easy to test
15:46 tcohen maybe mtompset signs, you qa and we are done :-D
15:47 mtompset sounds good to me... let me fire it up.
15:48 AndrewIsh Hey all. I need to log changes to the Illrequest object's status property. I was originally going to overload the $request->status accessor, however, this won't catch cases where the code does something like: $request->store({ status => 'updated' }); So my question is, what would be the recommended way of achieving this? Overloading the "store" method? Or something else?
15:48 cait tcohen: great minds think alike ;)
15:49 cait AndrewIsh: sorry, no idea, maybe one of the others
15:49 mtompset My jessie takes extra time toboot, because I was trying to play with resizing. :)
15:50 mtompset -- and now the guest add ons miss match. :)
15:51 mtompset DOH! and NFS issues.
15:52 mtompset Going with stretch on this.
15:55 cait looking for qa on bug 20746
15:55 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746 normal, P3, ---, koha-bugs, Signed Off , Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer
15:57 cait also bug 20737 - quick one
15:57 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737 normal, P5 - low, ---, nick, Needs Signoff , Use https for Baker and Taylor cover images
16:04 mtompset okay signing off 20745.
16:05 mtompset I also tested it with --verbose and without --verbose :)
16:06 cait i'll take a look after the one i am working on right now
16:06 cait hm and after my database has reset :)
16:08 mtompset So, cait, if I signed off 20746, would you pass QA it? Because as far as I can tell it is just a bunch of file moves.
16:08 cait yeah we can do that
16:08 cait i ran the italian web installer, no sql errors
16:08 cait that's why resetting now heh
16:09 mtompset I'll test it now.
16:10 cait oleonard: i think I found a problem with the datepicker change
16:10 * mtompset frowns, "NOOOOOOOOOOOOOOOOOOOOOOOO!"
16:10 cait it seems to prevent me from typing the date directly
16:11 cait which we once identified as an accessibility issue
16:11 cait as the datepicker is not accessible
16:11 mtompset directly where? how?
16:11 cait you click into the field and use your keys
16:11 cait instead of clicking ;)
16:12 cait we once worked with a blind staff user
16:12 cait and she noted that - back then some of the date fields had readonly set, we remove dit
16:12 cait but now they appear locked up again
16:13 mtompset :(
16:15 Joubu priority should be the rel_18_05_candidate list
16:15 cait i know, but that looked fun
16:15 cait just getting into things again :)
16:15 cait i'll leave anot on the bug
16:16 cait hm actually it seems a problem with and without the new change now :(
16:16 cait wonder when we broke that
16:16 Joubu cait: which one is locked?
16:16 cait all.
16:16 Joubu date of birth is ok
16:16 cait hm maybe a browser thing
16:16 cait which one are you using?
16:17 Joubu FF
16:17 cait strange
16:17 cait where are you testing? i had a new user form
16:17 Joubu ok with chromium as well
16:17 cait def not for me, vrey odd
16:17 cait Joubu: trying with an empty input field?
16:17 cait i can change it if there is a date already
16:18 Joubu creating a patron, yes
16:18 cait ok, I tihnk it's me
16:18 cait quickly retesting
16:19 cait oleonard, mtompset: i take everything back, the problem is in front of the computer
16:21 cait bug 20746 now
16:21 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746 normal, P3, ---, koha-bugs, Signed Off , Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer
16:21 oleonard This is the perfect time for me to switch back to my IRC window
16:23 cait i guess so :)
16:35 mtompset cait: pebkac :)
16:42 cait tcohen, kidclampcan one of you qa bug 19862 plz? i am the patch writer
16:42 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 normal, P5 - low, ---, katrin.fischer, Needs Signoff , RoutingListAddReserves must be disabled by default
16:43 cait Joubu: for bug 20706 - should i just add the en now too?
16:43 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Fix links to help files for changed file structure (removed numbering on files)
16:44 Joubu yes
17:07 cait Joubu: done
17:12 TGoat hiya cait! ..cait, is there a permanent link (permalink) scheme for koha?
17:12 cait i am not sure what you mean, sorry
17:13 cait links to records are static... if that's what you mean?
17:14 cait hm reading the wikipedia article links in koha could qualify https://en.wikipedia.org/wiki/Permalink, but there might be more to it
17:16 oleonard TGoat: Links to most things aren't session-based, so a special permanent link isn't required for sharing
17:16 TGoat hard question to pose
17:18 TGoat thanks oleonard and cait .. I think they're asking what/if there is programming envolved in the permalink and if so is there a scheme used. They also ask if there's a permalink scheme for ISBN, ISSN or OCLC numbers.?
17:18 TGoat make sense?
17:18 cait you can construct a serach link to those
17:18 cait so i'd say that might be a scheme?
17:19 cait i'd include examples in the answer to be on the safe side i guess
17:19 oleonard TGoat: Koha doesn't have "pretty" urls out of the box, so you can do something like my.opac.org/isbn/123456789
17:19 oleonard you /can't/ do that
17:19 TGoat heh
17:19 cait could someone test something to avoid pebcak again? Turn on EnableBorrowerFiles and try to upload a file from the patron account in staff... it doesn't work for me but tells me i don't exist
17:19 oleonard But you could configure Apache to do it
17:20 TGoat huh, thanks oleonard and cait :D
17:25 mtompset cait, http://xkcdsw.com/4032
17:26 mtompset it's related to pebcak. :)
17:32 cait so can somoene test files for patrons quickly plz?
17:33 cait problem is here input type="hidden" name="borrowernumber" value="" />
17:34 cait will try to fix
17:38 Joubu cait: it's a bug from 18789, it should be patron.borrowernumber
17:38 Joubu cait: do you want me to follow-up on 18789?
17:39 cait we can do that
17:39 cait and then i just pass it?
17:39 mtompset cait, bug 20746 is ready for you to pass QA it. ;)
17:39 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746 normal, P3, ---, koha-bugs, Signed Off , Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer
17:40 cait done
17:44 mtompset Anyone care to look at bug 16690 and bug 17237?
17:44 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 major, P5 - low, ---, mtompset, Needs Signoff , Remote DB installation is less secure.
17:44 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237 minor, P5 - low, ---, magnus, Needs Signoff , Stop koha-create from creating MySQL users without host restriction
17:44 huginn News from kohagit: Bug 18789: Fix borrowernumber on members/files.tt <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d2ea81e6529768ec4e85afb46cf2e3b7255f9a2e>
17:45 cait mtompset: not quite my area of expertise
17:45 cait mtompset: bug 20706 for you maybe?
17:45 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Fix links to help files for changed file structure (removed numbering on files)
17:45 cait without it help file links will be broken
17:48 Joubu test plan is too big
17:48 Joubu :D
17:48 cait hm?
17:56 pabloab Hi all!
17:57 pabloab I'm having a plack related problem (who doesn't?)...
17:57 tcohen we don't :-D
17:57 pabloab Everything is fine until I reboot VM (Ubuntu Server 16.04), to have Koha working again I need to `koha-plack --start myinstance`, even I had already `koha-plack --enable myinstance`. I see some koha-common scripts on /etc/rc0.d/ (even now Debian 9 uses systemd), there I see those koha-plack --start $(koha-list --enabled --plack). Maybe the problem is that `koha-list --plack` doesn't list my plack enabled, started and working instance.
17:57 pabloab Surele you did :)
17:58 tcohen have you tested koha-list —enabled --plack?
17:58 pabloab yeap, no output
17:58 tcohen so
17:58 Joubu good news :)
17:58 tcohen koha-list —enabled?
17:58 Joubu ha no...
17:59 tcohen pabloab?
17:59 pabloab $ koha-plack --enable catalogo2 -> "Plack enabled for catalogo2"
17:59 tcohen have you tried koha-list —enabled and koha-list —plack ?
17:59 pabloab $ koha-list --plack -> nothing
18:00 tcohen did you see any warning about some apache modules not enabled?
18:00 tcohen (just in case)
18:00 pabloab I'll look again, but nothing related to this
18:09 pabloab @tcohen Yesterday I had those Error while loading /etc/koha/plack.psgi: Can't locate Koha/Exceptions/Exception.pm: ./Koha/Exceptions/Exception.pm: Permission denied at /usr/share/perl/5.22/base.pm line 97 as ksorbo on koha list.
18:09 huginn pabloab: I've exhausted my database of quotes
18:09 tcohen pabloab: any chance you manually disabled plack for (say) the staff interface?
18:10 tcohen (or the OPAC)
18:11 tcohen koha-list —plack really just checks the include line in the vhost config is commented
18:11 pabloab plack-error.log doesn't start lines with a timestamp so is a little bit difficult to be sure. Now I have https://pastebin.com/8bSX8xwr
18:11 tcohen lets keep talking one thing at a time
18:11 tcohen koha-list —plack not showing your plack is enabled
18:11 tcohen because you might have been tweaking things manually
18:12 pabloab no, I --stop --start a lot of times but I don't even know how to stop plack only for one of the interfaces
18:12 tcohen there's no such a things as plack for opac
18:12 tcohen it is just if the apache configuration is pointing to plack or not
18:12 tcohen plack might be running, and apache could not be using it, and falling back to CGI mode
18:14 pabloab I didn't touch anything manually. Maybe is related to let'sencrpt. Even it suppose to renew my certificates automatically, after 90 days they were expired.. maybe certbot --apache do something plack didn't like?
18:17 pabloab after reboot koha doesn't work at all, doesn't seems to fallback to CGI mode. I need to manually `koha-plack --start instance`
18:21 Guest1726 Project Koha_Master_D8 build #469: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D8/469/
18:21 Guest1726 Jonathan Druart: Bug 18789: Fix borrowernumber on members/files.tt
18:21 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 enhancement, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Send a Koha::Patron object to the templates
18:21 pabloab @tcohen koha-plack --start catalogo2 -> starts fine; pgrep -af plack -> show process; koha-list --plack -> nothing. Also tail plack.log show activity
18:21 huginn pabloab: downloading the Perl source
18:23 tcohen paste the output from
18:23 tcohen grep plack /etc/apache2/sites-enabled/catalogo2.conf
18:25 pabloab Include /etc/koha/apache-shared-opac-plack.conf and Include /etc/koha/apache-shared-intranet-plack.conf
18:25 oleonard I can't seem to stay put this afternoon.
18:26 tcohen odd
18:26 tcohen it is weird that koha-list doesn't recognise plack is enabled
18:28 tcohen the code that guesses the status is pretty trivial and hasn't changed in ages
18:28 tcohen https://snag.gy/9sCrB8.jpg
18:28 mtompset cait, 20706... that is huge testing.
18:29 mtompset Joubu, you guessed correctly on my response. :)
18:29 mtompset I'm tempted to write a selenium test. ;)
18:31 tcohen pabloab: only one space between Include and /etc…?
18:32 pabloab Yeah I see... https://github.com/Koha-Community/Koha/blob/master/debian/scripts/koha-functions.sh#L188
18:33 pabloab No, 6 spaces, I edited to paste it here
18:34 tcohen pabloab: keep the files kosher
18:34 tcohen LOL
18:35 tcohen so koha-list issue solved
18:35 pabloab jaja OK, I tried to be nice. Maybe is a bug? I offer myself to find the culprit
18:35 tcohen now, what Koha version is?
18:35 pabloab 17.11.05-1
18:36 mtompset cait, I think you missed 2 files for bug 20706.
18:36 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Fix links to help files for changed file structure (removed numbering on files)
18:36 cait which 2?
18:38 mtompset cait, I'm just checking that out now...
18:40 mtompset okay, I was wrong.
18:40 mtompset You caught something extra.
18:40 mtompset How do you trigger the nohelp page?
18:41 pabloab @tcohen ah! so it is a bug! that line should say grep '^[[:space:]]*Include[[:space:]]*/etc/koha/apache-shared-opac-plack.conf'
18:41 huginn pabloab: I'll give you the answer just as soon as RDA is ready
18:41 tcohen pabloab: the bug is in your apache file
18:43 tcohen check /etc/koha/apache-site*.in
18:43 tcohen both template files have only one space
18:43 tcohen so it muse have been manually tweaked
18:46 mtompset Found a way to trigger it. YAY!
18:47 pabloab @tcohen mmm I'm almost sure I didn't, maybe certbot... anyway, the function could be more tolerant :)
18:47 huginn pabloab: I'll give you the answer as soon as RDA is ready
18:48 Joubu pabloab: why do you add extra spaces to config files?
18:50 tcohen certbot certainly doesn't touch the file
18:51 pabloab I don't remember doing that, maybe I did for readability, and didn't suspect could have any effect
18:51 pabloab you are right, I'm guilty :(
18:53 tcohen pabloab: then you found another problem, right?
18:54 Joubu tr -s " "
18:55 pabloab Im sorry I don't know what do you mean. Is odd because I have a lot of trouble making work letsencrypt, even it suppose to work like a charm, but I don't remember messing around with any other lines, even less about plack, which I don't understand clearly
18:57 pabloab Don't you agree those line could be more tolerant? Is pretty usual to add those spaces (or even tabs) to config files..
19:02 pabloab Koha should see if the file is included, no matter the amount of spaces or anything else, don't you agree?
19:20 tcohen pabloab: I have my own 'Koha should' list :-D
19:25 pabloab jajaja add this one! Is tiny. Add it just below "make Koha work using microservices" :P Thanks for your help!
19:38 barton I just added 'Permalinks' to the shared rescources page on the Koha wiki -- these were the ones that I could dig up off the top of my head, I'd love to see more: https://wiki.koha-community.org/wiki/Permalinks