Time Nick Message 23:25 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 new feature, P5 - low, ---, benjamin.rokseth, Pushed to Master , Add routes to add, update and delete patrons 23:25 mtompset tcohen, are you suggesting the benjamin on bug 16330? 23:20 wahanui Using deft allegory, the authors have provided an insightful and intuitive explanation of one of Unix's most venerable networking utilities. https://www.amazon.com/review/R2VDKZ4X1F992Q 23:20 mtompset ping who? 23:19 tcohen mtompset: ping benjamin 22:19 mtompset I guess I'll just have to koha-devel mailing list it then. :( 22:05 tuxayo and me too! Bye o/ 22:03 wizzyrea they should definitely be on their way to bed :P 21:59 tuxayo mtompset: Norwegians should be sleeping by now ^^ 21:58 mtompset Because I patched something related to them, and I need someone to test it. :) 21:58 mtompset I'd like to understand those Norwegian system preferences. 21:58 mtompset Anyone seen a Norwegian? :) 21:57 mtompset Greetings, #koha. 21:57 huginn mtompset: magnuse was last seen in #koha 4 days, 8 hours, 9 minutes, and 46 seconds ago: * magnuse gotta run 21:57 mtompset @seen magnuse 21:37 rangi caroline_ and cait sunny so far 21:33 caroline_ hehehe! 21:32 cait how is tuesday? :) 21:32 caroline_ Is it a good morning where you are? 21:32 caroline_ hello! 21:31 tuxayo hi rangi 21:29 rangi morning 21:27 wizzyrea deny filling a hold with the same item, I mean. 21:26 wizzyrea it should pick the next reserve in line, and advance the queue for those items. 21:26 wizzyrea it absolutely should deny putting a hold on the same item twice 21:25 wizzyrea waiting is not a status that can be used to fill a hold 21:25 wizzyrea waiting is "it's sitting on the shelf for someone to come get" 21:25 wizzyrea yeah the rank is what order the holds should be filled in 21:25 tuxayo wizzyrea: there is something about rank. So maybe is should not deny. There is also a "waiting" state 21:13 wizzyrea and/or select the next available item for waiting 21:12 wizzyrea tuxayo: it should probably deny the 2nd attempt to mark the same item waiting 18:50 tuxayo Any idea Joubu ? 17:17 tuxayo Two patrons place a hold on the same item with ReservesNeedReturns set to "Automatically" 17:17 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423 normal, P5 - low, ---, koha-bugs, NEW , ReservesNeedReturns allows multiple patrons to have the same item set to 'waiting' 17:17 tuxayo Does anyone know what should be the expected behavior for bug 20423 ? 17:11 tuxayo And the fix could be common. 17:11 tuxayo Then the cause should (hopefully!) be the same. 17:11 tuxayo Joubu: thanks I will check if it reproducible in 17.11 and not in 16.11 17:08 wahanui maybe is a momentaneous error 17:08 Joubu maybe? 17:08 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423 normal, P5 - low, ---, koha-bugs, NEW , ReservesNeedReturns allows multiple patrons to have the same item set to 'waiting' 17:08 Joubu tuxayo: bug 20423 17:07 tuxayo The hold ends up without a expiration date which cause waitingreserves.pl to crash. 17:07 tuxayo Oh, there is a regression (16.11 ok, 17.11&master KO) on ReservesNeedReturns , is anyone using it? 16:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , Again and again, Circulation.t is failing randomly 16:51 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20721 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Circulation.t keeps failing randomly 16:51 Guest1726 Jonathan Druart: Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to fail randomly 16:51 Guest1726 Project Koha_Master_D8 build #467: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/467/ 16:51 wahanui o/ '`'`'`'`'`'`'`'`'` 16:51 Guest1726 Yippee, build fixed! 16:21 huginn cait: The operation succeeded. 16:21 cait @later tell LeeJ good luck!! 16:18 LeeJ well I'm heading out for now..off to a study session for my final exam tomorrow! 16:18 huginn News from kohagit: Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to fail randomly <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8bb531b5308635d53345cd04617b47acb076970e> 16:15 cait role model :) 16:14 caroline cait: just passed on the message, thanks so much! :D 16:13 LeeJ not bad for being a bit rusty..been away from it for a few years ;) 16:13 caroline LeeJ: lol! pretty good! ;) 16:11 LeeJ (who knew 8 years of French would have the occasional usefulness?) 16:10 LeeJ caroline: merci beaucoup à vous tous! 16:09 LeeJ I second cait's comment! 16:08 cait caroline: say thx to your coworkers/company - I've noticed and it's great :) 16:08 LeeJ caroline: thankfully Joubu taught me the trick of just watching the Release Notes gitlab page and just skimming off the top commit each time :) 16:07 caroline LeeJ: I can imagine, I see all the "Pushed to master" (which is good but still a lot of work) 16:06 cait caroline++ docs work 16:06 cait caroline: same for me :) i had just started writing it 16:05 cait tcohen: translate seems alive again - even without email :) 16:05 LeeJ caroline: I'm very grateful! I'm flailing just trying to keep up with release notes changes as they get added to make sure nothing is missed 16:04 caroline the whole team does community work *on friday afternons 16:04 tuxayo actually the operation is still in progress. We can see that "things" are happening witht last activity column. http://translate.koha-community.org/projects/18.05/ 16:04 caroline Normally the whole team does community work (the devs do mostly bugs or sign offs, and I do translation or doc), but I'd been soooo swamped lately I hadn't had time 16:03 tuxayo caroline: is seems to work now. And it seems there was an operation 20 min ago 16:03 caroline LeeJ: thanks! :D I finally had some time to do community work last week yay! 16:03 caroline Ok, so while I was writing my email to Bernardo, Pootle came back. phew! 16:02 LeeJ caroline: you're a documentation superstar :) 16:02 caroline Hi LeeJ ! 16:02 Joubu :s/pfffffffff/happy monday! 16:01 Joubu pfffffffff 16:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531 minor, P5 - low, ---, jonathan.druart, Pushed to Master , IssueSlip is failing randomly 16:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 normal, P5 - low, ---, mtj, Pushed to Master , OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled 16:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Warnings in tools scripts need to be removed 16:01 Guest1726 * Jonathan Druart: Bug 20531: (follow-up) Set the timestamps to the same value to get a 16:01 Guest1726 * mtj: Bug 20686: OPAC shows 'Login to OverDrive account' with 16:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 major, P5 - low, ---, nick, Pushed to Master , Multiple invitations to share lists prevents some users from accepting 16:01 Guest1726 * Jonathan Druart: Bug 20305: Remove warnings from tools scripts 16:01 Guest1726 * m.de.rooy: Bug 20687: (follow-up) Look for invitekey in show_accept and fix error 16:01 Guest1726 * Nick Clemens: Bug 20687: Check all share keys for a given list 16:01 Guest1726 * Tomás Cohen Arazi: Bug 20284: Fix minor compilation errors 16:01 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 major, P5 - low, ---, andrew.isherwood, Pushed to Master , ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance 16:01 Guest1726 * Tomás Cohen Arazi: Bug 20284: (QA follow-up) superlibrarian has ill permissions 16:01 Guest1726 * andrew.isherwood: Bug 20284: (follow-up) Added missing 'exit's 16:01 Guest1726 * andrew.isherwood: Bug 20284: ILLModuleCopyrightClearance text breaks 16:01 Guest1726 Project Koha_Master_D8 build #466: STILL UNSTABLE in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D8/466/ 16:00 * LeeJ waves to caroline 15:59 caroline Thanks Joubu 15:59 caroline ok! 15:59 Joubu caroline: I hope it's not normal, you should email Bernardo 15:55 caroline Is it normal that I get a 503 Unavailable service when I try to go to translate.koha-community.org? Are the strings being updated for 18.05? 15:40 LeeJ caroline++ 15:26 huginn News from kohagit: Bug 20305: Remove warnings from tools scripts <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=23aa9866124064cbea8d52c1ec8f72089b4e8626> 15:26 huginn News from kohagit: Bug 20284: ILLModuleCopyrightClearance text breaks <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b12d5e7c20f44e12b990eaa2a083202bf8b5d43c> 15:26 huginn News from kohagit: Bug 20284: (follow-up) Added missing 'exit's <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1b67f208232bbf7efa1eee35c3b1c28e5baa8199> 15:26 huginn News from kohagit: Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspre... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=affd3f0eceba42ec7c92706452a892823eed39e0> 15:26 huginn News from kohagit: Bug 20687: Check all share keys for a given list <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=90d249b39dcc6702074aea7b747807d231d09024> 15:26 huginn News from kohagit: Bug 20687: (follow-up) Look for invitekey in show_accept and fix error codes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f0b88ed328e83877cbb98c5e3904e6b087b5a9ca> 15:26 huginn News from kohagit: Bug 20284: (QA follow-up) superlibrarian has ill permissions <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=046f1f340132a97a2447a44707bdc1e2ded9a637> 15:26 huginn News from kohagit: Bug 20284: Fix minor compilation errors <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ab52b1f3ac03ad4b68ac4ab7fa29e32c5efe39b9> 15:26 huginn News from kohagit: Bug 20531: (follow-up) Set the timestamps to the same value to get a correct order <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9a1bed84d6ac0ac5b0b9ee631363bc9cb0d74b73> 15:16 Shane-S Had a student throw once across the room...they got detention..and I asked if I am to repair it..and I was told give them a spare and order a screen. Personally I would have been like here is notebook and pencil...hand write all homework and do all math by hand 15:15 Shane-S tuxayo: Well...if the parents cared maybe the kids would too...but they just expect it fixed and given back...and then the parents argue it isn't their kids fault. No one is at fault or responsible these days it seems. 15:09 Guest1726 Project Koha_Master_D8 build #465: STILL UNSTABLE in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D8/465/ 15:08 tuxayo Shane-S: so much waste :( Especially considering the environmental and social cost of making these things. 15:07 oleonard (but only a few patches submitted) 15:07 huginn Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 enhancement, P5 - low, ---, oleonard, ASSIGNED , Omnibus: Update two-column templates to use Bootstrap grid 15:07 oleonard Bug 20654... 181 of 201 templates changed 15:07 tuxayo awwww so cute wahanui 15:05 wahanui cait is probably the best friend you could ever have. 15:05 kidclamp hmm cait? 14:58 huginn Joubu: I'll give you the answer just as soon as RDA is ready 14:58 Joubu huginn is not feeling well 14:57 Shane-S Just an example...if you substitute my toddler with student and kindle with chromebook you have my daily life (no cuteness needed)...its like a pencil...they have to have one 14:55 tuxayo Shane-S: wow that's a terrible serial broker story 14:54 huginn News from kohagit: Bug 11317: (QA follow-up) Fix merge error and punctuation <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ba0abdf9292c26cfddb040bb3e491d03bf7e013f> 14:54 cait afk 14:51 Shane-S and...Kindle number 5...destroyed 14:51 Shane-S I am sure you all might like to know my toddler broke Kindle Fire...but wouldn't the history been more helpful...like Shane's kid broke 4 Kindles across 5 Libraries..."DENIED!" If you just saw broke a kindle in an email...and my cute toddler gave you that innocent look and I promised it wouldn't happen again...you might just override it :) 14:49 tuxayo hi #koha o/ 14:48 Shane-S didn't see a 14:48 Shane-S I mean books see to be damaged and replaced, not repaired. But electronics can be repairs. Just asking weather it is something that "fits" Koha, or I should look at more specialized software 14:46 Shane-S I just didn't a "records" of damages, just the item status 14:46 cait the other maybe a custom payment type? 14:45 cait hm maybe not checkout notes then, that would be more for reporting damage 14:45 Shane-S bot lag or just a commit that triggered mass messages? 14:44 huginn News from kohagit: Bug 20620: Remove warnings in moredetail.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4c36d4beb6f308ddec9b8da667ed23878bdc208d> 14:44 huginn News from kohagit: Bug 19171: Attempt to make "no holds possible" messages less confusing <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d2d937fc9bb4bdd886c12964c4a21b324626528b> 14:44 huginn News from kohagit: Bug 20663: Remove dead code related to compound reports <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=32a2528d53c7917a0d680dc54416df3202057a5e> 14:44 huginn News from kohagit: Bug 20663: Add some POD, so koha test tools don't complain <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=be35e4883a5595b08c14364fb5da7c98a251aeb5> 14:44 huginn News from kohagit: Bug 20685: Escape letter template content in textarea <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=305d3c36cb685fabce3ec4357ed769c25b12eb73> 14:44 Shane-S hmm...would you find a "records" of damages more relevant and reportable then just a notes field? Example cait break her MacBook Pro, I enter it as "damaged" and must fill in a note field and optional costs. Record is made with date/time/patronID/itemID/staffID/note field/costs(maybe have a repaired entry for this). Not sure how relevant that is, I just know I repairs lots of keyboard and screens multiple times. 14:40 cait kidclamp_away: possible yourwebsite search doesn't like me? :( 14:40 cait gmcharlt++ 14:39 oleonard gmcharlt++ 14:39 cait or checko your pm 14:39 cait you need to read back :P 14:39 gmcharlt oleonard++ 14:39 tcohen cait: what do you want? :-D 14:39 huginn gmcharlt: Quote #203: "francharb: oh god… it's complicated" (added by wizzyrea at 03:48 PM, May 08, 2012) 14:39 gmcharlt @quote random 14:38 cait i think bywater has a tutorial, but haven't found it yet 14:37 cait and the library gets an email 14:37 cait it's text they can put on the checkoutsin their account 14:37 cait Shane-S: maybe it's checkot notes, lookign for some info on it 14:37 Shane-S cait: But that isn't really something I can query, as it is just text right? 14:37 cait tcohen: your part of the deal? 14:37 cait looking for info 14:37 tcohen cait: thanks 14:36 cait Shane-S: patron notes 14:36 cait tcohen: commented 14:36 Shane-S I ask as I use it to track student chromebooks, but I can't find a good solution out there to monitor damages and repairs and the patron to make a report...like device A is having problems, patron John has had 6 repairs to devices checked out to him 14:34 cait i will check the bug out while you check :) 14:34 cait tcohen: dos the translate server work for you? 14:34 Shane-S So...I have an electronics and damages questions...does Koha have a way to store damage and repair history and patron assigment 14:31 oleonard gmcharlt: Could you check huginn's alarm clock? 14:18 tcohen cait: what do you think of bug 20712 14:17 cait morning tcohen 14:12 tcohen morning 14:01 cait caroline++ 14:01 cait :) 13:49 LeeJ cait: I just added a comment to the merge request to request English...if there's a problem with her doing them in English I can help with the screenshots..just waiting to see what's said :) 13:48 cait i don't have a clear preference, might be nice to use sample data where possible, but for osme things like catalog enrichment it might be not possible easily 13:45 LeeJ so I'll ask for screenshot updates before merge :) 13:44 LeeJ right 13:43 cait bit more critical for patron category codes and item types 13:43 cait i think library names and records can be non-english 13:43 LeeJ didn't want to merge until I checked :) 13:43 cait hm good question 13:43 LeeJ thankss 13:43 cait looking now 13:43 Joubu No idea for the screenshots questions... 13:42 Joubu lol 13:41 LeeJ Joubu cait are these valid screenshots? Or should all text on it be in English? https://gitlab.com/koha-community-devs-users/kohadocs/merge_requests/104/diffs 13:39 * LeeJ waves to cait 13:39 * cait waves 13:37 LeeJ Joubu: just need confirmation..we're standardizing all kohadocs screenshots to be fully in English yes? 13:37 Joubu Hi LeeJ, #koha 13:36 LeeJ Joubu: around? 13:34 LeeJ hi #koha 13:34 * LeeJ waves 13:25 marcelr khall: btw was that an additional signoff or a qa ? you did not change status.. 13:24 SoniaB marcelr: thks, I've seen that but as it appeers few lines later in the manual and I couldn't do a request even if I change this in the circulation rules, I thought that I have miss something else... 13:21 marcelr you can set it for patron types etc. 13:20 marcelr SoniaB: look at circulation rules at the right end 13:18 SoniaB I'm trying to configure article requests and I have a look to the manual : the second step is "Set to Enable patrons to place article requests." but I can't find where I have to do that. Is someone know how to do ? 13:15 khall np! 13:15 marcelr thx khall 13:14 wahanui bonjour, SoniaB 13:14 SoniaB Hello 11:44 * cait waves 11:32 wahanui hi olé onard 11:32 marcelr hi oleonard 11:32 oleonard Hi all 11:30 marcelr kidclamp++ 11:30 kidclamp updated 11:27 marcelr good point 11:27 kidclamp yes, helps if I apply to the correct repository 11:26 marcelr they apply with me 11:26 kidclamp wait. lemme try again 11:25 marcelr let me try again 11:25 marcelr they are from friday? 11:25 marcelr really 11:25 kidclamp code looks good marcelr, but patch won't apply 11:07 marcelr ah great 11:07 kidclamp yes, loooking now 11:06 marcelr kidclamp: here it is: @later tell kidclamp signed off on 20687, could you plz look at bug 11943 11:06 marcelr let me find it again :) 11:06 wahanui huginn is a bot, not a person. 11:06 kidclamp wahanui, where's huginn? 11:06 marcelr kidclamp: yeah huginn did not cooperate.. 11:05 marcelr hi eythian 11:05 eythian hi marcelr 11:05 kidclamp hmm..I don't think so, huginn is awol 11:04 marcelr kidclamp: did you see my later on the lists patch? 11:04 marcelr hi kidclamp 11:04 kidclamp hi marcelr 11:04 kidclamp him 11:04 marcelr hi #koha 11:00 eythian laters 11:00 rangi right, time for sleep, spotya later 10:59 rangi oooh that sounds neat 10:58 eythian https://www.indymanbeercon.co.uk/ rangi, if you've got an excuse to go to Manchester, I'm thinking of going to this 10:57 rangi ok, this script has finished running, I should hit the hay 10:57 rangi https://www.brewvana.com/tours/coffee-beer-and-donuts <-- its my 3 fave things!! 10:54 * eythian likes a good walking tour 10:54 rangi breakside, unicorn and migration 10:53 rangi theres a behind the scenes one that sounds fun 10:53 rangi i think ill probably go for a walking tour 10:53 eythian yeah exactly 10:52 eythian http://www.bbc.com/news/world-europe-41830304 10:52 rangi hehe yeah fair enough, 15 drunk people on a big slow thing 10:52 eythian they've banned them from the inner city here 10:52 eythian everyone local will probably hate you 10:52 rangi a 15 seater bike 10:51 rangi or the more ridiculous https://www.brewgrouppdx.com/brewcycle/ 10:49 rangi https://pedalbiketours.com/oregon-tours/#oregonbrewerytour 10:48 rangi nice! I don't think we will have any issues finding good beer in portland too 10:46 kidclamp https://alchemistbeer.com/ 10:45 kidclamp I'll have to make a trip to alchemist before i head out and will bring what I can to share 10:45 rangi yep me too 10:45 kidclamp nice, I am a fan of their beers 10:45 rangi i reckon we should just move the hackfest to there :) 10:45 rangi kidclamp: https://www.rogue.com/locations/rogue-hall 10:43 kidclamp :-) 10:43 rangi as in the brewery kidclamp 10:41 eythian rangi: heh neat. A friend was making noises recently about organising a trip to Portland, but I haven't heard from him in a while so I dunno what the current plan (if any) is. 10:41 kidclamp rogue as in the brewery? or an underground/unofficial brewpub? 10:40 rangi eythian: has anyone mentioned there is a rogue brewbar on the campus of the uni that kohacon18 is at? :) 10:40 rangi heh 10:32 eythian https://imgur.com/a/EzRn14b <-- the Amsterdam metro is going to become a confusing place for French tourists. 10:31 rangi magnuse: naw i gotta run some stuff on a clients machine anyway 10:31 wahanui hmmm... eythian is Time's Person of the Year for 2006. 10:31 rangi heya eythian 10:31 eythian hi rangi, magnuse, cait 10:30 magnuse rangi: thanks for digging into this, hope i didn't keep you up too far into the night 10:29 * magnuse needs food 10:27 magnuse and updating lastseen from check_password would hopefully catch logins from third party services via REST API and ILS-DI too 10:26 magnuse but it leaves us with a question of should we update lastseen on circ events, i think? 10:25 magnuse your patch will be a nice addition, then 10:24 rangi so nope, still won't catch users using overdrive, or any of the other ones that don't call patron info 10:23 magnuse ah yes, that is true 10:23 rangi i think that patch is still only doing it in the patron info right magnuse ? 10:22 cait maybeone 10:22 cait I think none of ours uses password on the selfcheck... 10:22 magnuse rangi does your patch do pretty much the same thing as "Bug 18625 - Update borrower last seen from SIP" then? 10:21 magnuse i just tested via telnet, and i could check out a book via sip2 without lastseen getting updated 10:20 magnuse yeah 10:20 rangi hope that makes sense 10:19 rangi and then you start scanning items 10:19 rangi selfcheck machines rarely require you to use a password, you scan the card and the machine does patron info 10:18 rangi so if it sees a valid user with a valid password, it updates lastseen 10:18 rangi in C4/SIP/ILS/Patron.pm 10:16 rangi because thats all that things like overdrive do 10:16 rangi i added an update to check_password 10:16 rangi yes thats right 10:14 rangi I think so, lemme find the patch I did 10:13 magnuse rangi: did you say self check machines will always do "patron info" requests before they do checkout? 10:12 kidclamp https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 10:12 kidclamp no huginn? 10:12 magnuse Bug 18821 - TrackLastPatronActivity is a performance killer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 10:11 rangi ah cool 10:11 magnuse which is pushed to master for inclusion in 18.05 10:11 kidclamp bug 18821 10:11 magnuse ah, but there is Bug 18625 - Update borrower last seen from SIP https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 10:11 rangi they dont ask for patron information 10:11 magnuse oh? 10:10 rangi because thats exactly what I had to patch 10:10 rangi nope it doesnt 10:10 magnuse it does, if there is a third party service like an ebooks service that authenticates patrons in koha via sip2 10:10 rangi it does as part of a circ transaction tho 10:09 rangi yes, but that doesnt get called by a login 10:08 magnuse rangi: nah, in sip2 it currently updates lastseen on "patron information" requests. not circ 10:06 rangi then we will actually have a valid lastseen 10:06 rangi to have it update on Circ too 10:06 rangi i have a patch to get it track logins in SIP too, we just need to add a bit to CanBookBeIssued 10:06 * cait waves 10:05 rangi so it only tracks logins in staff and opac, and only circ events in SIP (currently) 09:53 kidclamp ah, yes, it tracks the logged in user, or the patron when they login - and then it is on every page load 09:52 kidclamp the call is in C4/Auth::checkauth 09:52 magnuse yeah, when i do a checkout, my lastseen is updated, but not the lastseen of the patron 09:49 magnuse let me test that 09:49 magnuse that would explain the behaviour i saw 09:49 kidclamp_ magnuse, I believe it actually updates on every page load 09:47 magnuse Bug 16276 - When automatically deleting expired borrowers, make sure they didn't log in recently https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 09:47 magnuse rangi: thanks for looking. from bug 16276 it looks like the original intent was only to track logins 09:25 rangi maybe i was confused and its just SIP, and opac login that update it 09:25 rangi ill have to look again in the morning 09:19 rangi maybe it doesn't now im totally confused :) 09:08 rangi but darned if i can find where/how 09:08 rangi so weird, because afaict it is updating on a circ operation 08:55 rangi I might be dreaming :) i'll have a quick look 08:53 magnuse ah, ok, i'll investigate in that direction then. thanks :-) 08:51 rangi magnuse: i did track it down, but I can't remember where I saw it, I think its when you scan the card, not when you issue anything 08:45 severine_q I always fail when I try to add a schedule task to a saed report, is there someone who could help me ? 08:43 magnuse trying to figure out how borrowers.lastseen is updated. so far i have not been able to figure out how it is updated by circ actions (but observing the db tells me it *is* updated in circ actions): https://wiki.koha-community.org/wiki/Updating_borrowers.lastseen 08:31 severine_q Good morning #koha :) 07:17 rangi yep, it probably needs a full check to make sure its consistent in SIP and staff and OPAC 07:15 magnuse but you also have to turn the syspref on... 07:15 magnuse libraries will be looking for this in light of gdpr 07:14 magnuse rangi++ 07:14 magnuse that is how i stumbled into it - a library wanting to delete inactive borrowers 07:14 rangi ill try to get time to file the bug, and update the code for master 07:14 magnuse yup 07:12 rangi but yeah, every time you see (login, circ action) a borrower we should update that column, then its much easier for libraries to find inactive borrowers 07:12 cait so you got sign-off and qa.... well, if this qa can figure out how sip works again 07:11 rangi :) 07:11 cait i'd agree too 07:11 * magnuse will sign off on it without arguing 07:10 rangi with dealing with arguing for ages about it pointlessly 07:10 rangi if i can be bothered 07:10 cait are you filing a bug? 07:10 cait both make sense - circ and auth 07:10 rangi (expect in the one library I have deployed it in) 07:09 rangi if you just authenticate it doesn't 07:09 rangi it updates last seen 07:09 rangi so if you circ something in SIP 07:08 rangi to make it update when a user logs in 07:08 rangi thats why i had to add code 07:08 rangi yep 07:07 magnuse as far as i can see that is the only place sip2 updates lastseen? 07:06 magnuse lastseen is updated in a "patron info" sip2 request: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/SIP/Sip/MsgType.pm;h=9ec126ed124e76f573065fcea52e5dcfa6b0e89f;hb=HEAD#l939 07:04 rangi yeah, the SIP code doesnt use that 07:03 magnuse http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Patron.pm;h=35cfce4ca1b92678591dcd2838034789e3faa75d;hb=HEAD#l474 "sub track_login" 07:03 magnuse huh, that is the opposite of what i am seeing... 07:02 rangi i havent looked at the bug report, but ive read the code ;) at least in 17.11 07:02 rangi (but if you issued to them in the staff client, or they took an item out via SIP, it did update) 07:02 rangi because if someone is getting a book from overdrive, with auths via SIP, that was never updating the the lastseen 07:01 rangi well i just had to do some work on the SIP code to get it to update lastseen when a user logged in, because it was only updating when a circ event happened 07:00 cait hi magnuse and rangi 07:00 cait not sure without reading the code 07:00 cait I think logged in was int e bug description 06:59 rangi i thought it did the opposite, updated it when circ events, not when logged in? 06:58 magnuse ....and hiya #koha 06:58 magnuse wouldn't it make sense to update borrower.lastseen on circ events too, not just logins? some patrons might login and never borrow anything, others might borrow lots and never log in 06:53 wahanui what's up, alex_ 06:53 alex_ bonjour