Time  Nick       Message
01:58 mtj        hey wizzyrea, rangi.. im planning to get to the meetup tmrw
01:58 wizzyrea   \o/
02:01 mtj        🙋
05:38 davidnind  A message for Mason (not sure whether message worked) - Thanks for the offer of a lift. I'm going up Whanganui this evening, see you Thursday! David Nind
05:43 mtompset   Have a great day, #koha wizzyrea mtj rangi
06:15 fridolin   hi community
06:47 cait       hi fridolin :)
06:51 fridolin   cait: bonjour
06:51 wahanui    hola, fridolin
06:53 fridolin   kwack ?
07:30 alex_a     bonjour
07:34 * calire   waves
08:01 gaetan_B   hello
08:01 wahanui    hola, gaetan_B
08:11 tuxayo     hi #koha o/
08:14 calire     hi tuxayo
08:35 eythian    hi.
08:35 tuxayo     Oh I get it calire your new nick allows you to be next to cait in alphabetical lists! :D
08:36 tuxayo     hi eythian o/
08:36 cait       cozy
08:39 eythian    hi there tuxayo, cait.
08:41 * cait     waves
08:48 nlegrand   Hello #koha
08:48 calire     tuxayo: haha, I hadn't thought of that ^^
09:12 nlegrand   thank you cait, we will have a look :)
09:15 cait       nlegrand: np :)
09:15 cait       nlegrand: sent you a pm too
09:59 tuxayo     QA question: I have this JS include but only one of the functions is used publicly. How do I document that and avoid name collisions? Adding a leading underscore in the name like in Python?
09:59 tuxayo     https://gitlab.com/tuxayo/Koha/commit/2bf8886891ece2454fec469654e555f7b53600bf#7684767c8d30929428beb6e8083a30c8a9ea1946_0_4
09:59 tuxayo     cc alex_a jajm
10:00 alex_a     lapin compris
10:01 tuxayo     QA question 2: this is an include with only JS. How do I reflect that in the name?
10:01 tuxayo     (I think fridolin gave me that feedback)
10:01 tuxayo     alex_a: there are 3 functions in the include. Only one of them will be used outside this file
10:01 ere        nlegrand: Hi! Thanks for the log. I finally see the errors in there but need to analyze more to find out the actual reason.
10:02 jajm       tuxayo, i recommend you read about the module pattern in js for Q1
10:02 fridolin   tuxayo: i suggest a js file, no include
10:03 fridolin   if translation needed, add strings in an include, like for Datatable
10:04 jajm       fridolin, he's using a TT plugin in this file
10:04 tuxayo     fridolin: doesn't work, as it uses a syspref and needs to be preprocessed by TT for that.
10:04 fridolin   ah indeed
10:05 tuxayo     alex_a: "js for Q1" I don't get it.
10:05 alex_a     tuxayo: you mean jajm
10:06 jajm       tuxayo, for an answer to your 1st question, google "module pattern javascript"
10:06 tuxayo     Indeed alex_a !
10:06 tuxayo     jajm: ok thanks!
10:07 fridolin   i'd say like koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
10:09 jajm       tuxayo, something like that should do what you want : https://toddmotto.com/mastering-the-module-pattern/#anonymous-object-literal-return
10:13 jajm       tuxayo, note that your code will fail if DecimalSeparators contains a " (double quote) because of the 1st line of isPrice
10:24 tuxayo     jajm: thanks, I'll use this pattern.
10:24 tuxayo     «code will fail if DecimalSeparators contains a "» indeed, is there an easy way to prevent that? I case someone mistakenly add a " in the syspref. Or think that we need to enclose the value with quotes.
10:28 jajm       tuxayo, you can use TT plugin JSON::Escape
10:28 jajm       [% USE JSON.Escape %]
10:29 jajm       var pref = [% Koha.pref('DecimalSep').json %];
10:29 jajm       it will automatically escape double quotes
10:30 fridolin   new syspref again :(
10:32 fridolin   z3950 : does someone have a connexion to University of Chicago z3950 server ?
10:39 cait       what#s with you people and sysprefs?
10:39 cait       sysprefs++
10:47 tuxayo     fridolin: the last conclusion was that this syspref was needed. Any new element?
10:47 tuxayo     thanks jajm :)
10:48 fridolin   no pb ;) syspref is life
10:49 jajm       fridolin, i think you need to reconsider your life then :)
10:49 fridolin   ;)
10:49 fridolin   bier is life then
10:50 tuxayo     fridolin: https://en.wiktionary.org/wiki/bier#Noun
10:50 tuxayo     bier (Noun): A litter to transport the corpse of a dead person.
10:51 tuxayo     Not very lify stuff XD
10:51 fridolin   whooo need
10:53 fridolin   "money makes the world goes round" but only with the good decimal separator ^^
10:57 cait       fridolin: remind me, how often do you update koha?
10:58 cait       trying to remember what others told me and my brain is like swiss cheese
11:02 fridolin   cait: each year major upgrade like 16.11 > 17.11
11:02 fridolin   each 3 month minor 16.11.12 to 16.11.15
11:04 cait       thx!
11:04 cait       are you usually jumping on stable then?
11:04 cait       or oldstable?
11:04 wahanui    it has been said that oldstable is now 3.12.
11:04 cait       wahanui: forget oldstable
11:04 wahanui    cait: I forgot oldstable
11:09 calmagnus  Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": Can't locate object method "cache_dir" via package "Swagger2::SchemaValidator" at /usr/share/perl5/Swagger2.pm line 41.
11:09 fridolin   cait: we are jumping to 17.11 this summer
11:09 calmagnus  anyone else seen that when trying to run under plack?
11:10 fridolin   calmagnus: which is your Koha version
11:11 calmagnus  fridolin: 17.0506
11:11 magnuse    package install
11:11 wahanui    package install is easy, if you do it on a supported os
11:11 fridolin   ah
11:11 magnuse    so true
11:12 cait       thx frido!
11:12 cait       fridolin++
11:12 fridolin   you may compare /etc/koha/plack.psgi with file is sources
11:12 fridolin   cait: your welcome ;)
11:13 fridolin   we are preparing the db upgrade timing due to biblio_metadata converison
11:13 cait       ooh  right
11:13 cait       how bad is it?
11:16 fridolin   depends on the server
11:16 fridolin   but may last an hour or two
11:25 GiuseppeP  Hello, If I want add Let'sEncrypt to an instances can I do koha-create --letsencryot also if the instance already exist?
11:26 magnuse    GiuseppeP: you can only use --letsencrypt with koha-create
11:26 magnuse    there is currently no easy way to add letsencrypt to an existing site
11:27 GiuseppeP  so the better way still adding it manually?
11:27 magnuse    bug 16662 aims to add that functionality
11:27 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 enhancement, P5 - low, ---, koha-bugs, In Discussion , Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances)
11:28 magnuse    yes, adding it manually is the best option for now
11:28 GiuseppeP  ok thanks
11:30 nlegrand   ere sure!
11:37 nlegrand   ere wanted to say "thanks" I'm a bit confusel lately :)
12:00 ere        nlegrand: no problem :)
12:16 oleonard   Hi #koha
12:17 calire     bonjour oleonard
12:18 oleonard   Hello calire, a person I have never met before. Welcome to #koha
12:18 * calire   removes dark glasses
12:18 GiuseppeP  hmm Koha is ignoring my htaccess on intranet/htdocs... it used to works on Koha 3.x, but Koha 17.11 seem ignoring it. any idea?
12:19 GiuseppeP  I just tried to empty it and put there a Redirect rule to test it, but no luck
12:19 cait       hey kidclamp!
12:19 wahanui    well, kidclamp is contemplating shaving the stache
12:19 kidclamp   morning cait!
12:20 cait       back home safe and sound?
12:20 kidclamp   indeed
12:20 cait       :)
12:21 cait       i've submitted my patches last night
12:21 cait       incase you get bored today ;)
12:21 oleonard   GiuseppeP: Did you change the way you installed Koha for 17.11, or was it an upgrade in place?
12:22 * kidclamp doesn't thing that will be a thing today, but I will try to taker alook
12:23 nlegrand   hey oleonard! I bought and ate some morchella on saturday, I thought about you :)
12:23 nlegrand   hiya kidclamp
12:23 kidclamp   hi nlegrand
12:24 kidclamp   oleonard: I totally messed things up for you - no one can go to Germany
12:24 kidclamp   ;-)
12:24 GiuseppeP  oleonard: frehs install
12:24 GiuseppeP  by repo
12:24 oleonard   Thanks nlegrand :)
12:26 * oleonard brb
13:09 marcelr    hi #koha
13:12 eythian    hi marcelr
13:13 marcelr    o/
13:18 kidclamp   hi marcelr
13:18 marcelr    hi kidclamp
13:18 marcelr    back?
13:18 wahanui    and forth.
13:19 kidclamp   indded
13:19 kidclamp   indeed even
13:23 GiuseppeP  I did a strace to understand why htaccess is not working and that look strange: https://pastebin.com/Qxmy3v4q
13:23 GiuseppeP  looks like it is searching the htaccess on /usr instead of the document root
13:24 GiuseppeP  could be a bug qith apache 2.4.25?
13:24 GiuseppeP  *with
13:41 tcohen     @seen jajm
13:41 huginn     tcohen: jajm was last seen in #koha 2 hours, 52 minutes, and 4 seconds ago: <jajm> fridolin, i think you need to reconsider your life then :)
13:41 tcohen     @seen matts
13:41 huginn     tcohen: matts was last seen in #koha 23 hours, 17 minutes, and 39 seconds ago: <matts> tuxayo, exactly. Or giving wahanui only blanks.
13:49 tcohen     @later tell matts I need to talk with you about the orders endpoint for Coral
13:49 huginn     tcohen: The operation succeeded.
14:01 GiuseppeP  fyi: I've solved the problem of htaccess forcing the override on document root
14:16 oleonard   Glad to hear it GiuseppeP.
15:08 tuxayo     Functional question: for bug 12310 we have a file named price.inc and functions with price in their name.
15:08 tuxayo     Are there other non-price numeric fields in Koha where we could use that?
15:08 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
15:08 tuxayo     If yes: technical/QA question: how do I rename this stuff? "decimal-numbers" instead "price" ?
15:26 GiuseppeP  hmm after moving koha to HTTPS it is generating a lot of load, the process using more CPU (a lot more than in past) are opac_search.pl and 404.pl is that normal?
15:26 GiuseppeP  something like 45-65% CPU
15:29 tuxayo     GiuseppeP: The overhead of the actual TLS (responsible for the S in HTTPS) should not be noticable and is nowhere near the numbers you have.
15:29 tuxayo     https://www.keycdn.com/blog/https-performance-overhead/
15:29 tuxayo     Could the configuration change have impacted something else?
15:33 GiuseppeP  I had to add some rewriterule for https and let's encrypt I'm curious if that could be the cause
16:14 tuxayo     GiuseppeP: if one doesn't update the rewrite rules for bug 12904, it's possible to have a high CPU usage (until the resources fail to load with an error). That might eventually help ^^"
16:14 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 enhancement, P5 - low, ---, kyle, RESOLVED FIXED, Force browser to load new JavaScript and CSS files after upgrade
16:15 tuxayo     Coding style question: which case of JS variable and functions?
16:15 tuxayo     Can't find in https://wiki.koha-community.org/wiki/Coding_Guidelines (maybe we follow the default of JSHint then?)
16:15 tuxayo     s/of/for
16:19 oleonard   tuxayo: We don't have an established guideline.
16:19 kidclamp   you mean camelCase vs underscore_case>
16:21 paul_p     hi tcohen.
16:21 paul_p     can you join matts & me on #koha-temp ?
16:22 tcohen     we can zoom or hangouts if you prefer
16:23 paul_p     tcohen HG ok
16:23 paul_p     tcohen I open a hg & invite you
16:24 tcohen     perfect
16:24 paul_p     tcohen https://hangouts.google.com/hangouts/_/biblibre.com/tcohen
16:32 tuxayo     kidclamp: oh you're back :D
16:32 tuxayo     Yes I meant these cases.
16:32 tuxayo     oleonard  is there a clearly dominant practice?
16:33 * tuxayo   crosses fingers for underscore_case but would be fine if there is at least any dominant convention
16:40 oleonard   tuxayo: A quick glance suggests it's a pretty even split. I'm in favor of underscore_case too.
16:41 paul_p     tcohen have you seen you're #7 commiter ? http://git.koha-community.org/stats/koha-master/authors.html
16:46 tuxayo     "it's a pretty even split" why T_T
16:46 tuxayo     okay then I'll contribute pushing the rock on underscore_case slope ^^
16:46 tuxayo     Oh but the standard library methods use camelCase :(
16:47 tcohen     paul_p: nope
16:47 paul_p     tcohen now you know ;)
16:48 tcohen     coding guidelines?
16:48 wahanui    coding guidelines are http://wiki.koha-community.org/wiki/Coding_Guidelines
16:49 paul_p     I lost the 1st place 2 years ago IIRC, the 2nd place a few months ago, and will loose the 3rd in favor of Owen soon. You've a lot of work to take the 4th place (Galen being away, and kyle not submitting a lot, you should beat them soon ;) )
16:50 paul_p     [and in fact, joubu should be #1, because chris & I have a LOT of commit that are CVS commits. 1 file change= 1 commit. The # of commit is artificially enormous.
17:09 * tuxayo   sent a long message: tuxayo_2018-03-21_17:09:20.txt <https://matrix.org/_matrix/media/v1/download/matrix.org/gykqLPkjEbXbdTnauGnwUYWS>
17:46 tcohen     as long as we make Koha better, lets have thousands of commits!
17:51 * oleonard submits all future changes in single-line patches
17:53 kidclamp   that's a lot of cherries to pick
18:02 tuxayo     Maybe that would lead to a bit less conflicts? :P But more error prone other things (forgetting half of a patch)
18:38 tuxayo     To answer my above question: it's `function foo(bar) {`
18:39 tuxayo     https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo:Unofficial_coding_guidelines#Spacing_conventions
18:40 oleonard   function foo( bar ){   :P
18:47 tuxayo     Oh deer 🦌
18:48 * tuxayo   goes grepping some more code
18:50 Dyrcona    kidclamp: https://gist.github.com/Dyrcona/4629200 <- For when you have a lot of cherries to pick.
18:51 kidclamp   thanks Dyrcona
18:58 tuxayo     I wonder if someone has made a program that greps a project and outputs the existing coding style.
19:03 Dyrcona    Emacs can do that for C/C++ with the various cguess-* commands. Don't think anyone has added that for Perl.
19:03 Dyrcona    Does it automatically for Python.
19:16 tcohen     for Perl we use PBP, and all commits are checked with perlcritic for inclusion
19:17 tcohen     also, whatever the current RM wants he
19:27 tuxayo     Functional question: for bug 12310 we have a file named price.inc and functions with price in their name.
19:27 tuxayo     Are there other non-price numeric fields in Koha where we could use that? (parsing numbers with various formatting)
19:27 huginn     Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 critical, P5 - low, ---, victor.grousset, ASSIGNED , Accept different monetary formats as input
19:27 tuxayo     If yes: technical question: how do I rename this stuff? "decimal-numbers" instead "price" ?
19:37 em_        hey I installed Koha 17.11.03 which is the latest version and I am nt able to upload pdf files
19:37 em_        is there a bug?
19:37 em_        it works fine in 17.11.02 though
19:37 em_        followed the same steps in installing.
19:37 em_        can somebody help
19:37 em_        ?
19:40 tuxayo     em_: any error in the logs?
19:43 em_        no error
19:43 em_        clear installation
19:44 tcohen     make sure you delete de browser cache
19:44 tcohen     file upload heavily depends on a .js library
19:45 em_        ok
21:20 tcohen     #koha what would the relator code for 'prologuist' be?
21:21 emucla     installing koha i get this error https://pastebin.com/jBy2ZqEV
21:21 tcohen     win? aui?
21:21 tcohen     talljoy?
21:21 wahanui    talljoy is one of the few women that can see eye to eye with druthb. Almost all the others need to stand on a box.
21:25 tcohen     emucla: are you using MySQL 5.7?
21:25 emucla     no mariadb
21:30 emucla     I tried to populate database I marked all options in the webinstaller
21:32 emucla     database version 5.5.5-10.1.26-MariaDB-0+deb9u1
21:50 tcohen     emucla: I'm sorry I'm busy, check the install wiki there are instructions to set the sql-mode config so it doesn't cause trouble
21:51 emucla     ok thanks :)
21:53 magnuse    @seen rangi
21:53 huginn     magnuse: rangi was last seen in #koha 1 day, 1 hour, 28 minutes, and 13 seconds ago: <rangi> they both work, you just have to be mindful that if they change the rule for the opac, then your intranet will break and vice versa if you put them both in the same file
21:57 tcohen     magnuse: why are you awake? :-D (glad you are btw, hi!)
21:57 magnuse    i'm just about falling asleep :-)
21:57 magnuse    and hi!
21:58 magnuse    and bye!
21:58 tcohen     mindfulness++
22:57 emucla