Time Nick Message
00:05 mtompset The slow testing is running a perl -wc check on all p[lm] files.
00:06 mtompset Because Joubu claims there isn't anymore, but I think there may be some hiding.
00:06 wizzyrea oh question for you
00:06 wizzyrea we have an older-ish devbox
00:06 mtompset Sorry to hear that. ;)
00:06 wizzyrea what do we need to do after bub 12904
00:07 wizzyrea bug 12904
00:07 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 enhancement, P5 - low, ---, kyle, Pushed to Master , Force browser to load new javascript files after upgrade
00:07 mtompset Oh, is that the ... right...
00:07 mtompset The file: /etc/koha/apache-shared.conf
00:07 mtompset Gets shared by everything.
00:07 mtompset I threw the two rules in there.
00:08 wizzyrea where is "in there"
00:08 wizzyrea oh oh
00:08 wizzyrea nm
00:08 wizzyrea reading
00:08 wizzyrea ;)
00:08 mtompset then you just restart apache
00:08 mtompset do a restart_all
00:08 mtompset and all should be good.
00:09 wizzyrea I don't think she has the misc4dev thingerdoodle
00:09 mtompset that is normally installed by default in /home/vagrant
00:09 wizzyrea this devbox may be older than misc4dev
00:09 mtompset Really?!
00:09 wahanui really is probably more trouble than she's worth.
00:10 wizzyrea which might be a case to drop it and make a new one with the newer devbox code
00:10 wizzyrea no cool that fixed it :)
00:10 mtompset Then git pull master for the kohadevbox, and "vagrant up jessie --provision"
00:10 wizzyrea yep that part we know about
00:10 wizzyrea just she's got work in there
00:10 mtompset Ah, hence the desire to not vagrant destroy.
00:10 wizzyrea and no external sync'd repo
00:10 wizzyrea etc
00:10 wizzyrea yeah
00:11 mtompset This is where you CREATE the external repo.
00:11 wizzyrea :)
00:11 mtompset by copying off your kohaclone directory.
00:11 wizzyrea we'll see
00:11 mtompset and then setting the kohadevbox setup. :)
00:12 mtompset make sure to do do a git pull on the devbox.
00:12 mtompset I just submitted a patch to fix kohadocs sync repo issue. :)
00:12 mtompset I was getting a weird mkdir -p '' error for not explanation -- except I was trying to sync kohadocs.
00:12 wizzyrea ahh
00:12 mtompset turned out there was a typo in the yml files. DOH!
00:13 wizzyrea it's really up to her if she wants to drop and recreate
00:14 mtompset Filezilla the files onto the host machine, then drop and recreate is best with sync repos. for kohaclone and kohadocs. :)
00:14 mtompset And then it makes testing the same thing in jessie, stretch, and xenial trivial, because they all use the same directory. :)
00:16 mtompset Greetings, mtj
01:03 mtompset oh yuck.
01:05 mtompset @later tell Joubu C4/Barcodes.pm has multiple packages in it. perl -wc doesn't distinguish my within the package, but the file, for $DEBUG.
01:05 huginn` mtompset: The operation succeeded.
01:47 mtompset Have a great day, #koha wizzyrea
01:55 wizzyrea believe it or not, I do know how the devbox works, generally, just there weren't enough words in the email to grasp what exactly needed doing and don't have time/priority to dig it all up
03:13 jomat a
06:57 LibraryClaire anyone else having connection issues with bugs.koha-community.org?
07:00 cait ok for me this morning so far :)
07:00 LibraryClaire works in my dev environment but not on normal windows
07:01 cait strange
07:01 cait should check the dashboard next time
07:02 cait if it works in one but not the other
07:27 alex_a bonjour
07:30 LibraryClaire hi alex_a
07:30 alex_a hello LibraryClaire
07:32 magnuse ~~~
07:34 LibraryClaire hi magnuse
07:34 wahanui kamelåså
07:34 magnuse guten morgen BüchereiKlara
07:39 reiveune hello
08:13 petter morning!
08:18 magnuse g'day petter
08:18 petter hei magnus
08:20 cait hi petter :)
08:20 petter hi cait:)
08:21 tuxayo_afk hi #koha o/
08:21 cait hi tuxayo_afk :)
08:21 tuxayo woops, failed to change nick ^^
08:22 petter I added a discussion point to tomorrows dev meeting: https://wiki.koha-community.org/wiki/Development_IRC_meeting_14_February_2018#Agenda
08:22 petter I want to hear the opinions about merging old_reserves into reserves, old_issues into issues, deleteditems into items etc.
08:23 cait i think generally we want to do it
08:23 petter It's not a fun task, but we should do it imho, needs to be a coordinated community effort
08:23 cait it's just tricky to do without breaking all the things
08:23 petter I'm willing to put in some time work on it
08:24 cait cool - I'd be willing to put time for testing
08:24 cait but it's huge
08:24 petter Yes it is
08:24 cait not sure how we can break it down to be a bit less intimidating
08:24 cait not sure what's the easiest one either
08:24 cait maybe issues or even reserves
08:25 cait we only got 90 days left this cycle
08:25 cait time flies
08:25 petter right, maybe not enough time, but no reason not to start!
08:25 cait agreed
08:25 gaetan_B hello
08:25 cait hi gaetan_B
08:36 eythian hi
08:39 josef_moravec cait: petter: would be nice to have these tables merged, I would like to test too, maybe reserves is a good candidade to be done first...
08:39 petter Great! The more testers the better
09:08 oha petter++
10:39 magnuse petter++
10:51 dersmon hi! just wanted to follow up on a problem i had yesterday: my authority files were not imported, because they had 001 fields. when i run bulkmarcimport.pl with option -k everything works
10:52 dersmon this still seems like a bug to me? should i add a ticket?
11:02 * paxed grumbles something incoherent about using proper classes with html elements
11:32 dersmon https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 already exists
11:32 huginn` Bug 4226: normal, P5 - low, ---, bargioni, Failed QA , bulkmarcimport.pl doesn't replace 001 when keepids is not specified
11:58 paxed https://wiki.koha-community.org/wiki/Koha_plugins has a link to https://bywatersolutions.com/koha-plugins/ which doesn't exist
12:01 cait paxed: maybe leave khall a later
12:01 cait I think the list might be linked from their website
12:30 rajesh hallo I am getting this error in browser
12:30 rajesh DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access denied for user 'koha_library'@'localhost' (using password: YES) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1492. at /usr/share/koha/lib/Koha/Database.pm line 100
12:34 oleonard Yo
12:36 rajeh DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access denied for user 'koha_library'@'localhost' (using password: YES) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1492. at /usr/share/koha/lib/Koha/Database.pm line 100
12:36 rajeh I am getting this error in browser
12:36 rajeh I am using ubuntu
12:37 rajeh pls help me
12:37 oleonard rajeh: it looks to me like a problem with your MySQL credentials.
12:38 rajeh Ok so what to do it is mariadb
12:39 oleonard How did you install Koha rajeh?
12:39 oleonard packages? manual installation?
12:39 rajeh apt-get install koha-comman
12:41 oleonard Are you able to log in directly to the database using the koha_library user?
12:41 rajeh I could not understand
12:41 rajeh I am beginer
12:46 * LeeJ waves
12:46 LeeJ hi #koh
12:46 LeeJ koha, even
12:46 oleonard Does the package install process let you configure it with an incorrect mysql password?
12:50 LeeJ oleonard: not in my experience..where are you running into trouble?
12:50 oleonard I'm not, but someone was just here asking
12:50 LeeJ ah
12:51 LeeJ I've never experienced it..and I can't think of any step where it would be possible
12:54 eythian oleonard: iirc, no. There'd be no point.
12:59 eythian almost need a "fix DBA creds" script that regenerates them, writes them to the DB and rewrites the config, just to help people who have done something weird and probably edited the wrong part of the config or something.
13:18 marcelr hi #koha
13:20 marcelr running fresh master still problematic?
13:22 marcelr almost no javascript gets loaded..
13:23 marcelr ok, i forgot the rewriterules of course..
13:27 khall cait: I think the issue is probably 20187, assuming you did the update to fix your apache files already
13:27 khall bug 20187
13:27 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 normal, P5 - low, ---, kyle, Needs Signoff , New rewrite rules can break custom css
13:29 Joubu there are also tiny mce and item types translation
13:30 Joubu khall: I tried that rule but it does not fix tiny mce
13:32 marcelr khall: why do you put [N,L] in the rule flags?
13:32 marcelr they seem to contradict
13:32 Joubu http://pro.kohadev.org/intranet-tmpl/lib/tiny_mce/plugins/advlink/editor_plugin.js
13:32 marcelr next=go further last=stop
13:32 marcelr i think a default setup could go with [L]
13:33 marcelr but maybe [N] could be the safe side..
13:33 khall marcelr: I don't know why those are like that, I'm not the author of the original patch set. I filed the bug and submitted different patches. I think it was Martin that came of with this admittedly better implementation
13:34 khall Joubu: can you post the koha generated url to that file?
13:34 Joubu this is rewritten: http://pro.kohadev.org/cgi-bin/koha/admin//plugins/save/editor_plugin.js
13:35 khall the one with the koha version embedded
13:35 marcelr can we move them to apache-shared.conf instead of opac and intranet btw ?
13:35 khall that would be sensible marcelr , we should make that a separate bug
13:37 cait the other url is on thebug report
13:53 marcelr Joubu: what about replacing NL by L on bug 20187 ?
13:53 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 normal, P5 - low, ---, kyle, Signed Off , New rewrite rules can break custom css
13:53 Joubu see comment 98
13:54 Joubu of 12904
13:54 marcelr yeah i saw
13:54 marcelr it would make me choose for L
13:54 Joubu I do not have the answer :)
13:54 Joubu but that would make sense
13:55 marcelr i guess it makes no sense to rewrite it again on another rule
13:55 Joubu marcelr: seen comment 100? This one is not fixed yet
13:55 wahanui I haven't seen 'comment', Joubu
13:55 marcelr and we cant catch all custom changes..
13:57 Joubu FYI I have added "LogLevel alert rewrite:trace8" to the apache config file
13:57 Joubu useful to debug and understand how the rules work
13:58 marcelr where gets it loaded ?
13:59 Joubu I put it just above the rewrite rules
13:59 marcelr sorry but i mean the editor_plugin.js
14:00 marcelr some include in another js or so ?
14:02 Joubu marcelr: that is the problem, I do not know... :)
14:02 Joubu looks like it is from tiny_mce.js, but not explicitely
14:03 marcelr this is ugly: koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl
14:03 marcelr perl script in tmpl
14:05 jajm new rewrite rules in bug 20187 seem to break the intranet login page and the web installer (KOHA_VERSION empty in templates), can someone confirm ? cc khall Joubu marcelr
14:05 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 normal, P5 - low, ---, kyle, Signed Off , New rewrite rules can break custom css
14:13 Joubu jajm: looks like, yes
14:15 Joubu jajm: I get a blank page, but no 404
14:16 jajm Joubu, what do you mean by "no 404" ? JS and CSS files return 200 OK ?
14:22 marcelr Laden voor het <script> met bron ‘https://dev.rijkskoha.nl:28443/intranet-tmpl/prog/js/staff-global_.js’ is mislukt.
14:23 marcelr there is no koha version in that line..
14:25 marcelr jajm: confirmed intranet login does not work
14:28 Joubu maybe we can try to send 00.0000000 from install.pl?
14:30 marcelr Joubu: we should add KOHA_VERSION to C4/Auth in another place
14:31 marcelr when we call auth.tt for logout
14:31 marcelr line 194 and around
14:31 marcelr shall I add a patch for it ?
14:32 tuxayo marcelr_: jajm Strange, intranet login works for me.
14:32 marcelr apache restarted ?
14:32 marcelr go to home page and logout
14:33 jajm and clean your browser cache
14:36 Joubu I think we should 1. improve the rule to fix tiny mce (khall and I are on it but cannot understand where does the problem from from), and 2. fix the login page and install (on another bug report)
14:37 khall agreed
14:39 tuxayo marcelr: jajm I opened a clean firefox profile, cleared all history and cache, restarted apache, logged out from the intranet and log in still worked
14:40 marcelr strange
14:41 Joubu khall: so... The only way I can see the editor is to remove the _[% KOHA_VERSION %] suffix to tiny_mce.js
14:41 tuxayo found, testing something to confirm
14:42 Joubu I guess it is not the best way to fix it, but I do not think we should spend hours on that bug :)
14:43 marcelr adding KOHA_VERSION in checkauth should fix the login problem
14:44 marcelr added a patch on 20187; do we need it on another report ??
14:45 tuxayo marcelr: jajm Yep, intranet login is broken. I only applied the new rewrite rules to the OPAC in apache config.
14:45 marcelr tuxayo: i added a patch to fix it
14:49 Joubu marcelr: I will create another bug report for this issue if you do not mind
14:50 marcelr ok move it from there
14:50 Joubu 2 bugs: 1. rewrite rule, 2. auth + installer problem, 3. tiny_mce
14:50 Joubu so 3 bugs :)
14:52 tuxayo Joubu: would the current test suite have caught these bugs ?
14:52 Joubu no
14:52 Joubu jenkins is green
14:53 Joubu but we found several bugs yesterday we fixed (related to misc4dev and koha-test-docker for instance)
14:54 tuxayo yay :D
14:54 Joubu marcelr: bug 20189, patch moved
14:54 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 normal, P5 - low, ---, m.de.rooy, Needs Signoff , No style on authentication and installer pages
14:54 marcelr ok
14:54 marcelr adding a follow-up on 20187 again..
14:55 tuxayo For the remaining bugs. Would the (hopefully) future functional tests have caught them?
14:56 Joubu tuxayo: feel free to write some :) I have already several selenium patches on bugzilla waiting to be pushed
14:57 marcelr tuxayo: signoff on 20189 ?
14:58 tuxayo marcelr: done :)
14:58 tuxayo I almost sent it to 20187 ^^
14:59 Joubu tuxayo: I guess bug 19185 will catch that kind of issues
14:59 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 enhancement, P5 - low, ---, alexbuckley, BLOCKED , Web installer and onboarding tool selenium test
14:59 marcelr tuxayo: thx but Joubu changed the commit message and bug number
14:59 marcelr can you still correct? or should I
15:00 tuxayo ow, I even compared the two patches and missed that. Trying to fix.
15:01 Joubu khall: bug 20190
15:01 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 normal, P5 - low, ---, kyle.m.hall, ASSIGNED , TinyMCE is broken and not displayed
15:02 khall thanks Joubu I'll put the patch there
15:06 Joubu as you are all available to work on Koha today and we have almost fixed everything caused by bug 12905, you can take a look at bug 19802 and bug 19243
15:06 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 normal, P5 - low, ---, jonathan.druart, CLOSED FIXED, Deleting parent fund will orphan child funds, leaving them un-editable
15:06 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move Selenium code to its own module
15:06 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Selenium test for testing the administration module functionality - part 1
15:06 Joubu they could have helped us to catch these issues during the QA process
15:07 Joubu s/12905/12904
15:08 Joubu oleonard: thanks for bug 20135! I have not seen it before
15:08 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 major, P5 - low, ---, oleonard, Passed QA , Staff client language choose pop-up can appear off-screen
15:08 oleonard It was a recent patch of mine which caused it :|
15:09 tuxayo marcelr: is okay now?
15:09 tuxayo *it
15:09 khall cait: let us know if 20187 and 20190 fix your problem. Maybe greybox needs a fix similar to 20190
15:09 marcelr tuxayo++
15:10 Joubu @later tell rangi openhub update was slow but we finally see the academy students on the dashboard as new contributors ;)
15:10 huginn` Joubu: The operation succeeded.
15:11 Joubu khall: 20187 fixes it, I confirmed on 12904 already
15:11 khall ah, good. I'm usually out of the loop ; )
15:17 tuxayo Joubu: I'm definitely interested in working on tests. But for the short term I don't think being able to do that though :(
15:17 marcelr Joubu: one in PQA and two in SO
15:18 marcelr i would ignore the complaints on intranet-tmpl hardcoded
15:22 Joubu marcelr: could be replaced easily by [% interface %], right?
15:23 marcelr yeah seems so
15:24 cait khall: did you test it?
15:24 marcelr cait: i tested the mce one too
15:24 cait test is: edit itemtype > add translation > shoudl open in modal, will open in tab if broken :)
15:25 marcelr thats another test plan
15:25 marcelr i checked edit branch
15:25 Joubu cait: yes it fixes it
15:26 cait that's theone I ran into
15:26 cait i can't test for a another half day or so, please don't want for me
15:30 Joubu anyone to QA 20189 and 20190?
15:30 Joubu marcelr: does 20189 fix the installer as well?
15:31 marcelr will take another look
15:31 cait bug 20189
15:31 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 normal, P5 - low, ---, m.de.rooy, Signed Off , No style on authentication and installer pages
15:34 Joubu no it does not
15:34 marcelr we need the same change somewhere else too
15:37 Joubu marcelr: there is not syspref 'version' when we run the installer
15:37 Joubu no*
15:37 marcelr sure
15:38 marcelr is it sufficient to kill the underscore
15:38 marcelr ?
15:38 marcelr not very nice btw
15:40 * Nemo_bis reports to world underscore fund
15:40 marcelr lol
15:41 Joubu marcelr: I fixed it by adding:
15:41 Joubu 3 [% SET KOHA_VERSION='00.0000000' %]
15:41 Joubu to installer-doc-head-close.inc
15:41 Joubu another fix would be to remove the _[% KOHA_VERSION %] part from this include file
15:41 Joubu that sounds more correct
15:42 mtompset Greetings, #koha.
15:43 marcelr Joubu++
15:43 marcelr hi mtompset
15:47 Joubu marcelr: Do I upload my patch?
15:47 marcelr yeah
15:47 marcelr we need it!
15:47 Joubu I did not know if you were on it or not
15:47 Joubu attached on bug 20189
15:47 marcelr no let me see what you did..
15:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 normal, P5 - low, ---, m.de.rooy, Signed Off , No style on authentication and installer pages
15:47 marcelr ok
15:49 marcelr looks good to me, want another test?
15:50 tuxayo khall++
15:50 tuxayo marcelr++
15:50 tuxayo For 20187, so people won't have to update their apache conf 3 times ^^
15:50 marcelr tuxayo++ Joubu++
15:52 Joubu a note about that, we fixed the script cp_debian_files.pl from the misc4dev repo to copy the apache config files and update *-git.conf (call gitify), so dev just need to call that script to update them automatically
15:52 Joubu (just call reset_all for everything :D)
15:55 marcelr ok tested the install
15:57 marcelr later #koha
16:00 huginn` News from kohagit: Bug 20189: Fix style on installer and onboarding pages <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c24abd7dc1fdd71e64083478134dc99fc39cf654>
16:00 huginn` News from kohagit: Bug 20190: Replace intranet-tmpl with [% interface %] <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=addb4a06b5e082c56f91a325565c0b688439a1de>
16:00 huginn` News from kohagit: Bug 20190: TinyMCE is broken and not displayed <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5bc0ea5bd73e679cafabc73506584f9e29493529>
16:00 huginn` News from kohagit: Bug 20187: (QA follow-up) Replace N,L flag by L flag <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=818f1c2f83682167c6850bf28eeac89a06389e8e>
16:00 huginn` News from kohagit: Bug 20189: Fix style on the authentication page <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c5dcfcd6b3bf24b78fab75149b271ea902b393bf>
16:00 huginn` News from kohagit: Bug 20187: New rewrite rules can break custom css <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8cd0a76d1034d582ff0cfde986331324369294f7>
16:00 huginn` News from kohagit: Bug 20163: Position of NoLoginInstructions text is inconsistent <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3c78966c5d6eb182ad3de2eaf9d47fa843764c6b>
16:00 huginn` News from kohagit: Bug 20135: Prevent staff client language choose pop-up from appearing off-screen <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c079990723a90e2d97f821959cf0289dad539c73>
16:00 huginn` News from kohagit: Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=47b359cc96b238250637db9ae9df2e176c4ea3ca>
16:11 Joubu jajm: do you remember why you obsoleted this patch: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71419&action=edit
16:12 Joubu I do not find it on another bug report
16:12 tuxayo see you tomorrow #koha
16:14 reiveune bye
16:25 Joubu Any English native speakers around to answer bug 19466#c11?
16:25 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 major, P5 - low, ---, david.bourgault, Passed QA , Cardnumber auto calc is broken because field is required
16:28 jajm Joubu, I don't remember obsoleting any patch on this bug, it's probably a mistake
16:30 jajm Joubu, git-bz auto obsoleting patches with the same commit subject ?
16:30 Joubu jajm: ha right!
16:31 kidclamp_dnd I would lean towards 'blank' over 'empty' - makes more sense for a form, but either works
16:31 kidclamp_dnd jajm^
16:34 Joubu kidclamp_dnd: it was for me, thanks!
16:47 jenkins Project Koha_Master_D8 build #362: SUCCESS in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D8/362/
16:47 jenkins * oleonard: Bug 20163: Position of NoLoginInstructions text is inconsistent
16:47 jenkins * Jonathan Druart: Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl
16:47 jenkins * oleonard: Bug 20135: Prevent staff client language choose pop-up from appearing
16:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 trivial, P5 - low, ---, oleonard, Pushed to Master , Position of NoLoginInstructions text is inconsistent
16:47 jenkins * kyle: Bug 20187: New rewrite rules can break custom css
16:47 jenkins * m.de.rooy: Bug 20187: (QA follow-up) Replace N,L flag by L flag
16:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly
16:47 jenkins * m.de.rooy: Bug 20189: Fix style on the authentication page
16:47 jenkins * Jonathan Druart: Bug 20189: Fix style on installer and onboarding pages
16:47 jenkins * kyle: Bug 20190: TinyMCE is broken and not displayed
16:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 major, P5 - low, ---, oleonard, Pushed to Master , Staff client language choose pop-up can appear off-screen
16:47 jenkins * Jonathan Druart: Bug 20190: Replace intranet-tmpl with [% interface %]
16:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 normal, P5 - low, ---, kyle, Pushed to Master , New rewrite rules can break custom css
16:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 normal, P5 - low, ---, m.de.rooy, Pushed to Master , No style on authentication and installer pages
16:47 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 normal, P5 - low, ---, kyle.m.hall, Pushed to Master , TinyMCE is broken and not displayed
17:07 mtompset Greetings, #koha.
17:08 mtompset Joubu, Did you get my inquiry about pm's with multiple packages in a single file?
17:08 Joubu yes, I answered on the bug report
17:09 mtompset There... got it.
17:10 mtompset Okay, so because any remaining issues are refactoring, you're saying this bugs scope is just limited to these two changes?
17:13 mtompset And if you were going to split the packages, you'd split them with an our $DEBUG, correct?
17:14 Joubu I'd remove DEBUG
17:14 Joubu or fix it, but now it's always 0...
17:14 LeeJ cait: around?
17:14 cait kind of
17:17 huginn` News from kohagit: Bug 20144: DBIC Schema changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ea7fa8d011afc6d2337aebb440c1bf1f4732b143>
17:17 huginn` News from kohagit: Bug 20144: DBRev 17.12.00.015 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fc30a2c82c487fdf6da354cccd86c29b2c1d4aee>
17:17 huginn` News from kohagit: Bug 20144: [sql_modes] Fix GROUP BY clause in Virtualshelves search (DT) <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fb16189e0bedb6c2c91d778ca842cfca2507018c>
17:17 huginn` News from kohagit: Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if not... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=3f69f6e1c8738564c30d613d245ea8af5f6b91fd>
17:17 huginn` News from kohagit: Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=410e3c81d59f27e4e21d4f55d45c9de74f6d80d9>
17:17 huginn` News from kohagit: Bug 20144: [sql_modes] Fix search history tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0fe8670547ec0fe3e55f8e0dbb77fbf07f141601>
17:17 huginn` News from kohagit: Bug 20144: [sql_modes] Fix values when creating a sql report in tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=129270cd4657f6b13b3890920cbd75cd83595187>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Set default value for opac_news.content in tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=44ca7c37acd2b5f16160c03d8772c1ff01f3990a>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in GetItemsForInventory <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a93e49131d4d22c5bc2123f9a3626c36845d9e07>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8a0e21f0ecfd7e5bd135ad30e8955960b5d3549d>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Set value for creator_batches.timestamp <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=cf26f1f41f5d0d6ebedfe46b9405dc3b8fc71506>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b8f0a3fc40ce4aa64dec1c819a936d7397970ddf>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ffae331219341978582bc1db7a03b2c6449b7227>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=21922eeac502d055ee5eaaf59da0ae8d251d37a3>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Remove 'Null' string values from GetHardDueDate.t <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=29434b14549144589cc0663a25246914cb093d3d>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Set default value for Itemtype fees in TestBuilder <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f75f7bb9eec1325cf3c1527c571fbe392b478ad>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Fix GROUP BY clause in GetInvoices <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=39b0b5909cb0bc271b85723eb32d02146649b3be>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Fix GROUP BY clause in GetBasketsInfosByBookseller <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2e35da4f6b0e2c25ca1e6acb3e80f8b9d65cb658>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Add default value for export_basket.description in tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=406a480a780e67d3386e354907f8fac674257c17>
17:18 huginn` News from kohagit: Bug 20144: [sql_modes] Do not store 0000-00-00 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=53e46a58624f14f6528b6bd06c0eb39bd09b9e0f>
17:20 LeeJ Joubu: where can I find that meeting template so I can fix the missed docs meeting?
17:21 Joubu https://wiki.koha-community.org/wiki/Documentation_IRC_meeting_Template
17:22 LeeJ Joubu: thank you!
17:23 Joubu copy it as it, keep the __SECTIONS__
17:24 kidclamp_dnd thanks Joubu, will take a look and try to rebase on top of 12001
17:24 kidclamp_dnd Joubu++
17:40 furkan Hello, i'm a newbie on koha project.I would like to ask that, the docker project is always up to date?
17:42 LeeJ hi furkan! Welcome to the community! I'm not personally familiar with docker, but I believe Joubu and mtompset are..
17:43 * mtompset denies everything.
17:43 * LeeJ recalls that's the motto of the CIA
17:46 furkan Thanks
18:02 jenkins Project Koha_Master_D8 build #363: UNSTABLE in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D8/363/
18:02 jenkins * alex.arnaud: Bug 4319: [OPAC] Allow holds on waiting/transit items
18:02 jenkins * m.de.rooy: Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest
18:02 jenkins * m.de.rooy: Bug 4319: (QA follow-up) Use ReservableItems in all scripts
18:02 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 major, P2, ---, alex.arnaud, Pushed to Master , waiting and in transit items cannot be reserved
18:02 jenkins * alex.arnaud: Bug 4319: (QA follow-up) Rename hasItemswaitingOrInTransit to
18:02 jenkins * Jonathan Druart: Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to
18:02 jenkins * Jonathan Druart: Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed
18:02 jenkins * m.de.rooy: Bug 19301: (QA follow-up) Add POD, use statements and correct typo
18:02 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
18:02 jenkins * m.de.rooy: Bug 19301: (QA follow-up) Add a few simple tests
18:02 jenkins * david.bourgault: Bug 19466: Warn about conflicting settings of autoMemberNum and
18:02 jenkins * Jonathan Druart: Bug 19466: Restore original sentence to avoid additional translation
18:02 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 major, P5 - low, ---, david.bourgault, Pushed to Master , Cardnumber auto calc is broken because field is required
18:02 jenkins * kyle: Bug 19530: Prevent multiple transfers from existing for one item
18:02 jenkins * mtompset: Bug 19530: Added commentary for last test when prove -v
18:02 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 normal, P1 - high, ---, kyle, Pushed to Master , Prevent multiple transfers from existing for one item
18:02 jenkins * kyle: Bug 19530: Don't update the date arrived for closed transfers
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix borrowers table structure
18:02 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Test suite is failing with new default SQL modes
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set a default value for lowestPriority
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix default value for statistics.amount
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix generated value for account_offsets.amount
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for Aqbookseller in TestBuilder
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix datatype for aqbasket.authorisedby
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for aqbasket.is_standing
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix date format in tests
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set missinglist and recievedlist in
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Shorten cities.city_zipcode
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Add default values for export_format columns
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Correct quotes.timestamp values in tests
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Shorten items.barcode
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Add a value for
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix default value for statistics.itemnumber
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for Acccountline in TestBuilder
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Shorten aqbudgets.budget_code
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove HAVING clause in GetLateOrders
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Add default value for
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set issuingrules.no_auto_renewal_after to NULL in
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove HAVING clause in GetUpcomingDueIssues
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Correct quotes.timestamp values in tests
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove HAVING clause in GetBorrowersToExpunge
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Add default value for
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests
18:02 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Shorten auth_header.authtypecode values in tests
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set correct value for old_issues.issue_id in
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Shorten values for virtualshelfshares.invitekey
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Add default value for export_basket.description
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix GROUP BY clause in
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix GROUP BY clause in GetInvoices
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for Itemtype fees in
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove 'Null' string values from GetHardDueDate.t
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set value for
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set value for creator_batches.timestamp
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set default value for opac_news.content in tests
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix values when creating a sql report in tests
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix search history tests
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Add default value for
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Fix GROUP BY clause in Virtualshelves search (DT)
18:03 jenkins * Jonathan Druart: Bug 20144: [sql_modes] Do not store 0000-00-00
18:03 jenkins * Jonathan Druart: Bug 20144: DBRev 17.12.00.015
18:03 jenkins * Jonathan Druart: Bug 20144: DBIC Schema changes
18:11 LeeJ Joubu: I had to take care of something so I'm getting around to the wiki page now...so I just create a new wiki page for the february meeting, copy the contents of the documentation wiki template (leaving the underscored fields intact, etc.) to the february meeting wiki, then finally link it in the january wiki page..is that correct?
18:39 LibraryClaire anyone got any tips - if i try to do a git pull on kohadevbox I get: fatal: No remote repository specified. Please, specify either a URL or a remote name from which new revisions should be fetched.
18:39 * LeeJ waves to LibraryClaire
18:40 LeeJ do you have a valid remote URL?
18:40 * LibraryClaire waves to LeeJ
18:40 LibraryClaire um, I don't know
18:40 Joubu LeeJ: yep, should work
18:40 LibraryClaire i assume something is missing somewhere
18:40 LeeJ LibraryClaire: try running "git remote show origin"
18:41 LibraryClaire fatal: 'origin' does not appear to be a git repository fatal: Could not read from remote repository.
18:41 Joubu `git remote -v`
18:41 LibraryClaire that does nothing
18:41 LeeJ thanks Joubu :) I'll work on that wiki now
18:42 * cait hides
18:42 Joubu LibraryClaire: `pwd` # Are you sure you are at the right place?
18:43 LibraryClaire where should i be?
18:44 mtompset @seen khall
18:44 huginn` mtompset: khall was last seen in #koha 3 hours, 32 minutes, and 22 seconds ago: <khall> ah, good. I'm usually out of the loop ; )
18:44 Joubu /home/vagrant/kohaclone if you are inside the devbox
18:44 mtompset Are you around, khall?
18:44 Joubu otherwise in $SYNC_REPO
18:45 LibraryClaire Joubu I am in devbox in kohaclone as if I was going to test
18:45 mtompset If you are going to run tests, 'kshell' first.
18:46 Joubu LibraryClaire: make sure you have something (`ls`), then a .git (`ls .git`, but I guess you have it since it's not the error)
18:47 Joubu and then add the repo with `git remote add origin git://git.koha-community.org/koha.git`
18:47 LibraryClaire yeah I have some .git
18:47 Joubu and then fetch again
18:47 LibraryClaire Joubu++
18:47 Joubu you are not supposed to remove the origin repo ;)
18:47 LibraryClaire I didn't know I had
18:48 LibraryClaire my devbox borked, as it always does at home and I ended up having to try and rebuild it but not sure what I did
18:48 LibraryClaire but it does seem to be fetching things now so that's one step further :)
18:57 mtompset khall, You here?
18:57 khall yep!
19:27 huginn` News from kohagit: Bug 20144: (follow-up) Adjust /patrons endpoint <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8c489457caf79f3c71eb78e1c75939fcde0fef32>
19:28 cait back
19:28 * LeeJ waves
19:38 Joubu @later tell marcelr could you take a look at the noise of t/db_dependent/FrameworkPlugin.t?
19:38 huginn` Joubu: The operation succeeded.
19:41 Joubu furkan: what did you call the "docker project"?
19:57 huginn` News from kohagit: Bug 19243: Fix tests for patron categories <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=03a547da32195aa98cd9cd28b8d64f7bc399fa02>
19:57 huginn` News from kohagit: Bug 19243: Fix tests for AV <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f1d4bdb926798a1523fe3e98e101aaa367555a19>
19:57 huginn` News from kohagit: Bug 19802: Add stack trace to ease debugging <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f6f95808d815c6ef5376a5e9d5e238387010dd6d>
19:57 huginn` News from kohagit: Bug 19243: The "delete library" is now a button with id <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8391e5d9353392eeae594b29111ebfeb2938a87d>
19:57 huginn` News from kohagit: Bug 19243: Fix for bug 19860 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=26cc2b211a1bfae5bf510f6aeaf5cab751cdcabf>
19:57 huginn` News from kohagit: Bug 19243: fix urls - do not use /cgi-bin/koha <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4f175ce2bb556dd79561b5945708c77223bddb70>
19:57 huginn` News from kohagit: Bug 19243: Amended Selenium test to add the creation of patron category and authorise... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8876fd3e716dc71640bc1f067f37ecd82c21384c>
19:57 huginn` News from kohagit: Bug 19243: Add selenium tests for the administration module <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bee0c0b4ab17d336feda519b842f8212edfd696f>
19:57 huginn` News from kohagit: Bug 19802: Move Selenium code to t::lib::Selenium <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d482aef2e420cc2466a6e645eebea9c0c8d4a19d>
19:59 LibraryClaire Joubu any ideas on this message?: There is no tracking information for the current branch. Please specify which branch you want to merge with.
20:00 Joubu `git branch`
20:02 LibraryClaire it doesn't seem to be linked to one
20:04 Joubu git checkout -b master origin/master
20:08 LibraryClaire ok, there are a load of untracked working tree files that prevent that
20:08 LibraryClaire I think that is enough for today...
20:09 LibraryClaire laters
20:10 magnuse when you make a report public there is no way to page through the results, right? "LIMIT <<Offset>>, <<Limit>>" does not work (koha adds another "limit" after that)
20:11 cait you can set how many are returned
20:11 cait but no paging i think
20:11 cait the how many is a pref
20:12 cait check the web services tab :)
20:12 jenkins Yippee, build fixed!
20:12 wahanui o/ '`'`'`'`'`'`'`'`'`
20:12 jenkins Project Koha_Master_D8 build #364: FIXED in 44 min: https://jenkins.koha-community.org/job/Koha_Master_D8/364/
20:12 jenkins Tomás Cohen Arazi: Bug 20144: (follow-up) Adjust /patrons endpoint
20:12 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Test suite is failing with new default SQL modes
20:13 magnuse cait: yeah, i found SvcMaxReportRows, but thanks anyway
20:16 cait k
20:21 magnuse cait++
20:38 furkan Joubu: this one https://github.com/digibib/koha-docker
20:57 jenkins Project Koha_Master_D8 build #365: SUCCESS in 45 min: https://jenkins.koha-community.org/job/Koha_Master_D8/365/
20:57 jenkins * Jonathan Druart: Bug 19802: Move Selenium code to t::lib::Selenium
20:57 jenkins * Jonathan Druart: Bug 19802: Add stack trace to ease debugging
20:57 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Move Selenium code to its own module
20:57 jenkins * Jonathan Druart: Bug 19243: Add selenium tests for the administration module
20:57 jenkins * alexbuckley: Bug 19243: Amended Selenium test to add the creation of patron category
20:57 jenkins * Jonathan Druart: Bug 19243: fix urls - do not use /cgi-bin/koha
20:57 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 enhancement, P5 - low, ---, alexbuckley, Pushed to Master , Selenium test for testing the administration module functionality - part 1
20:57 jenkins * Jonathan Druart: Bug 19243: Fix for bug 19860
20:57 jenkins * Jonathan Druart: Bug 19243: The "delete library" is now a button with id
20:57 huginn` Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Make staff client home page responsive
20:57 jenkins * Jonathan Druart: Bug 19243: Fix tests for AV
20:57 jenkins * Jonathan Druart: Bug 19243: Fix tests for patron categories