Time  Nick          Message
06:52 LibraryClaire morning #koha
07:02 josef_moravec morning #koha
07:02 LibraryClaire hi josef_moravec
07:03 josef_moravec hi LibraryClaire
07:21 magnuse       ~~~
07:22 LibraryClaire hi magnuse
07:22 wahanui       kamelåså
07:33 cait          josef_moravec++ early and already on qa :)
07:34 josef_moravec cait: hi, yes, i want to do something before toot many people come and want me to do something for them (typical day in work) ;)
07:34 josef_moravec in work => at work, of course ;)
07:34 josef_moravec I hope... ;)
07:36 reiveune      hello
07:36 wahanui       privet, reiveune
07:36 josef_moravec cait: poll filled
07:37 fridolin      hie there
07:39 cait          josef_moravec: know the feeling - had to get this done before work too :)
07:50 alex_a        bonnour
07:50 alex_a        bonjour
07:50 josef_moravec hi alex_a
07:54 alex_a        hi josef_moravec
08:13 LibraryClaire hi alex_a
08:20 cait          good morning #koha .)
08:20 gaetan_B      hello
08:26 mtj           hey folks, does anyone know of any nice koha-docker repos?
08:26 mtj           something production ready(ish?)
08:30 magnuse       mtj: i know oslo public uses docker
08:30 magnuse       in production
08:31 magnuse       https://github.com/digibib/koha-docker
08:32 magnuse       https://hub.docker.com/r/digibib/koha/
08:38 marcelr       hi #koha
08:39 LibraryClaire hi marcelr
08:39 marcelr       :)
09:02 cait          hm no 17.11 demo installation? all I tested so far are still 17.11
09:03 cait          i mean 17.05
09:05 cait          Equinox++
09:05 cait          gmcharlt++
09:05 cait          found one on the wiki https://wiki.koha-community.org/wiki/Koha_Demo_Installations
09:07 cait          404 when turning on ILL.... is this to be expected?
09:18 cait          biblibre++ too
09:19 josef_moravec cait: I don't think so... On Kohadevbox it is ok, so maybe some problem with packages...I guess
09:19 cait          josef_moravec: or missing config? I will file a bug report
09:19 josef_moravec cait: maybe - configuration of ILL module is not so user friendly
09:20 josef_moravec will change I guess, there is bug for it
09:20 cait          hm new bugzilla component for ILL?
09:20 josef_moravec bug 19605
09:20 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 enhancement, P5 - low, ---, koha-bugs, NEW , ILL backends should be pluggable through regular Koha plugins
09:20 cait          yeah
09:20 josef_moravec cait: looks like good idea
09:20 cait          but might be something devs don't notice
09:20 cait          the error - will file and see, can always be closed:)
09:21 josef_moravec cait: true
09:22 cait          @later tell Joubu coudl/shoudl we add a new component on bugzilla for the ILL module?
09:22 huginn`       cait: The operation succeeded.
09:24 ashimema      @later tell kidclamp ldap should be easy, saml not so much, no idea about CAS
09:24 huginn`       ashimema: The operation succeeded.
09:25 ashimema      @later kidclamp feel free to catch me this afternoon (moring your time) when you're online
09:25 huginn`       ashimema: I suck
09:25 LibraryClaire lol
10:01 tuxayo        cait: What have I done? there twice the 17.11 BibLibre's demo. Thanks for making me notice that.
10:01 cait          hm?
10:03 tuxayo        cait: It was a poorly worded realization that I duplicated by mistake a line in the demo wiki page ^^
10:03 cait          ah :) i didn't notie
10:37 eythian       hi
10:38 magnuse       kia ora eythian
10:41 * eythian     only has two remaining days of work before heading to summer
10:43 * magnuse     only has today left before heading to gran canaria :-)
10:44 eythian       oh nice
10:49 janPasi       can anyone tell me about plack with koha?
10:49 janPasi       we're having huge performance problems with it
10:51 janPasi       it seems that as soon as we get more than a handful of users, everything gets really really slow
10:51 janPasi       this wasn't a problem with older version of koha that we were using
10:57 tuxayo        janPasi: which are the two versions you are talking about?
10:57 janPasi       tuxayo: the old one was ancient 3.16 with LOTS of our own code
10:58 janPasi       tuxayo: the new one is 17.06 (also with lots of our own code :D)
10:58 janPasi       tuxayo: we're a fairly large public library, so there's all kinds of things that we needed Koha to do
10:59 tuxayo        janPasi: wow that must have been a lot of work to perform such a version jump
10:59 janPasi       tuxayo: ~2 million items / 200000 patrons and around 6 million yearly checkouts
10:59 janPasi       tuxayo: yep :D
11:00 janPasi       tuxayo: everything was fine in testing, but of course it all falls to pieces just before production
11:00 janPasi       tuxayo: i'm pretty sure this is a problem with the amount of simultaneous users
11:00 tuxayo        janPasi: I don't yet have enough experience to evaluate the size (well 200000 patrons seems "a lot" ^^)
11:01 tuxayo        janPasi: so you don't have plack at all for now?
11:01 janPasi       tuxayo: plack is up and running, but it doesn't seem to perform very well
11:02 tuxayo        janPasi: oh this is sad. What are you value for "max_requests" and "workers" in the plack config?
11:03 janPasi       tuxayo: at the moment 16 workers and 400 requests
11:03 janPasi       tuxayo: the problem is i have no idea how those values should be :D
11:03 janPasi       tuxayo: missing good pointers
11:05 tuxayo        janPasi: 400 should be enough. As for the numbers of the workers, I don't know how to evaluate if the workers are overused or underused.
11:05 janPasi       yep, that's a hard thing
11:06 tuxayo        janPasi: The first is to find if Perl execution/compilation is the actual bottle neck. It could be the DB itself or having to access the DB over the network for intance
11:07 tuxayo        *instance
11:10 janPasi       db works perfectly, it's really well tried and tested :)
11:11 janPasi       i think there is a fiber connection between the front-end server and db
11:11 janPasi       so i'm pretty sure that's not the problem
11:13 janPasi       i highly doubt that perl compilation/execution is a problem either, we have 32 cpu cores and 128GB memory :D
11:14 janPasi       on two servers
11:15 tuxayo        janPasi: then there is a network latency which is much higher than on localhost even with a very good network.
11:15 tuxayo        Does anyone know how to check if the huge number of the DB queries having to go through a complete network stack is the bottleneck in this case?
11:15 tuxayo        That a nice setup you got there :)
11:15 janPasi       yeah, it's a fairly large system
11:19 janPasi       area wise also, our library covers around 40.000 square kilometers
11:19 janPasi       we have around 60 branches
11:21 tuxayo        janPasi: I think you might be one the biggest instances on many metrics O_O https://hea.koha-community.org/
11:27 janPasi       tuxayo: yeah, we've been planning on enabling the reporting to hea
11:28 janPasi       tuxayo: it would also be nice to get some of our code out to the community, but that's a bit complicated
11:28 janPasi       tuxayo: mostly technically complicated, all our code is in github, so in theory it's there for anyone to use
11:29 janPasi       tuxayo: we would definetely like to be able to participate the international koha development more
11:29 janPasi       we have around 700 code changes of our own
11:30 janPasi       that's far too much :D
12:41 oleonard      Hi all
12:42 josef_moravec hi oleonard
12:42 wahanui       hi oleopard
12:55 tuxayo        janPasi: 700 patches?
13:03 cait          can someone help me out with a quck question? looking for the piece of code in Koha that can convert marcxml/mrc
13:03 jenkins       Project Koha_17.11_D8 build #16: SUCCESS in 35 min: https://jenkins.koha-community.org/job/Koha_17.11_D8/16/
13:03 jenkins       * david.bourgault: Bug 19683: Fix authority types in tools/export template
13:03 jenkins       * fridolin.somers: Bug 19646: fix value_builder marc21_linking_section template
13:03 jenkins       * m.de.rooy: Bug 19646: (QA follow-up) Fix tab character
13:03 jenkins       * fridolin.somers: Bug 19640: fix OPAC IdRef webservice display
13:03 jenkins       * josef.moravec: Bug 19456: Make patron-title ability to be generated with or without
13:03 jenkins       * fridolin.somers: Bug 18833: Plugin unimarc_field_210c pagination error
13:03 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683 normal, P5 - low, ---, david.bourgault, Pushed to Stable , Export.pl does not populate the Authority Types dropdown correctly
13:03 jenkins       * kyle: Bug 19533: Hold pulldown for itemtype is empty if hold placement needs
13:03 jenkins       * simon.pouchol: Bug 19692: fix unclosed div in opac-shelves.tt
13:03 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 major, P5 - low, ---, fridolin.somers, Pushed to Stable , value_builder marc21_linking_section template is broken
13:03 jenkins       * david.bourgault: Bug 19681: Correct result count formatting
13:03 jenkins       * oleonard: Bug 19643: Pagination buttons on staged marc management are stacking
13:03 jenkins       * Nick Clemens: Bug 18990: Overdue Notices are not sending through SMS correctly
13:04 jenkins       * cnighswonger: Bug 10222: Error when saving Demco label templates
13:04 jenkins       * mtompset: Bug 10222: Correct and expand to other languages
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640 normal, P5 - low, ---, fridolin.somers, Pushed to Stable , IdRef webservice display is broken
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 normal, P5 - low, ---, josef.moravec, Pushed to Stable , Some pages title tag contains html
13:04 jenkins       * Jonathan Druart: Bug 7143: Update about page for new dev - Simon Pouchol
13:04 jenkins       * Jonathan Druart: Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
13:04 jenkins       * Nick Clemens: Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata
13:04 jenkins       * Nick Clemens: Bug 19724: DBRev 17.11.00.001
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833 minor, P5 - low, ---, fridolin.somers, Pushed to Stable , plugin unimarc_field_210c pagination error
13:04 jenkins       * Nick Clemens: Bug 19551: Fix wrong order of operations in cash register report
13:04 jenkins       * oleonard: Bug 19595: Clicking plugin link does not fill item's date acquired field
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533 minor, P5 - low, ---, kyle, Pushed to Stable , Hold pulldown for itemtype is empty if hold placement needs override
13:04 jenkins       * oleonard: Bug 19602: Add usage statistics link to administration sidebar menu
13:04 jenkins       * oleonard: Bug 19674: Broken indicators of changed fields in manage staged MARC
13:04 jenkins       * victor.grousset: Bug 12497: Fix search history non-accessible when OPAC was private
13:04 jenkins       * victor.grousset: Bug 12497: Fix OPAC search history reachable by URL even when disabled
13:04 jenkins       * mtompset: Bug 18907: Build has deprecating message
13:04 jenkins       * Jonathan Druart: Bug 19724: DBIC Schema changes
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692 trivial, P5 - low, ---, simon.pouchol, Pushed to Stable , Unclosed div in opac-shelves.tt
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681 trivial, P5 - low, ---, david.bourgault, Pushed to Stable , label-item-search.pl result count formatting error when there is only one page
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643 normal, P5 - low, ---, oleonard, Pushed to Stable , Pagination buttons on staged marc management are stacking instead of inline
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 normal, P5 - low, ---, nick, Pushed to Stable , Overdue Notices are not sending through SMS correctly
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 normal, P5 - low, ---, mtompset, Pushed to Stable , Error when saving Demco label templates
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 trivial, P5 - low, ---, koha-bugs, Pushed to Stable , Bug for tracking changes to the about page
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , False positives for 'Update SQL' button
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 normal, P5 - low, ---, julian.maurice, Pushed to Stable , Add timestamp to biblio_metadata and deletedbiblio_metadata
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551 normal, P5 - low, ---, nick, Pushed to Stable , Cash register report has bad erroneous results from wrong order of operations
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 normal, P5 - low, ---, oleonard, Pushed to Stable , Clicking plugin link does not fill item's date acquired field
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602 normal, P5 - low, ---, oleonard, Pushed to Stable , Add usage statistics link to administration sidebar menu
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674 minor, P5 - low, ---, oleonard, Pushed to Stable , Broken indicators of changed fields in manage staged MARC records template
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 minor, P5 - low, ---, victor.grousset, Pushed to Stable , Make OPAC search history feature accessible when it should
13:04 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907 trivial, P5 - low, ---, mtompset, Pushed to Stable , Warning "dpkg-source: warning: relation < is deprecated: use << or <="
13:06 kidclamp      convert to what cait?
13:06 janPasi       tuxayo: 700 commits, yeah, around that
13:06 cait          xml marc to non xml marc
13:06 cait          question from a coworker
13:06 cait          i think Koha can probably do it with the tools we use, but not sure where to start looking
13:06 janPasi       tuxayo: we got rid of about a hundred on upgrade from 3.16 to 17.06
13:07 cait          as we work on marc records all the time and store xml
13:07 josef_moravec cait: maybe MARC::Record perl module?
13:07 cait          looking at the documentation, got a bit lot maybe, rechecking :)
13:08 cait          hm not spooting the right way to do it
13:10 cait          MARC::Record::new_from_xml maybe
13:10 cait          ok,must be missing something, not seeing that in the MARC record documentation
13:11 cait          *confused*
13:12 cait          i think i found it
13:12 cait          it's in MARC::File::XML
13:13 jcamins       cait: that's not part of MARC::Record. You want MARC::File::MARCXML
13:13 jcamins       Sorry, MARC::File::XML.
13:13 jcamins       And you already figured that out.
13:13 jcamins       :)
13:14 cait          am I right that the MARC object can then be written out as a marc file somehow? :)
13:14 cait          and hi jcamins :)
13:15 jcamins       MARC::File::USMARC. :)
13:15 cait          maybe as_formatted?
13:16 cait          i guess there is some schema there :)
13:16 jcamins       No, as_formatted is just pretty-printed text.
13:16 jcamins       You want MARC::File::USMARC::encode()
13:17 cait          thx a lot
13:17 cait          jcamins++
13:27 tuxayo        janPasi: did those hundred get rid due to the new version having fulfilled the same need? Or was it because it they were too hard to maintain?
13:29 janPasi       tuxayo: mostly because either the "official" community version of koha had same or similar functionality, or they had become otherwise obsolete
13:29 janPasi       tuxayo: there are still a few changes made here that we would like to discard, but it all takes time :)
13:30 janPasi       i think i got that sluggishness in control by tuning up plack variables in koha-conf.xml
13:30 tuxayo        janPasi: good, no loss due to the upgrade if I understand correctly? :)
13:30 janPasi       tuxayo: nope, it's all good in that sense :)
13:31 tuxayo        janPasi: plack: nice, just the workers and max_requests?
13:31 janPasi       tuxayo: yep, 32/800, sounds insane to me, but hey, it works
13:32 janPasi       tuxayo: well see if we need to adjust them later on
13:32 janPasi       *we'll
13:37 tuxayo        janPasi: 1 request over 400 having to recompile shouldn't be a problem. Then it was the number of workers? Were all the 16 previous workers active (CPU 100% or waiting for IO (DB)) when Koha was slow.
13:38 janPasi       nope, we had about 10% load then :D
13:38 janPasi       the library is closed for the upgrade, so not much use at all
13:38 janPasi       no i/o waits either
13:39 janPasi       we normally run somewere between 40-60% load during opening hours
13:40 janPasi       with practically no i/o delay, we have a SAN system that automatically optimizes itself
13:40 janPasi       it's an array of SSD's and rotating disks
13:40 janPasi       plut the index is kept in ram all the time
13:40 janPasi       *plus
13:44 janPasi       tuxayo: why do i still only see two starman processes in process list?
13:45 * tuxayo      sent a long message: tuxayo_2017-12-14_13:45:27.txt <https://matrix.org/_matrix/media/v1/download/matrix.org/xXUkDtSCjWgLohUBgqwvfbVW>
13:47 tuxayo        janPasi: you should see 1 master and N workers. (maybe they are started on demand to not have 32 processes starting at the same time starman/plack is started)
13:49 janPasi       tuxayo: i'm using nmon because it gives me a nice graph, there is no i/o delay there, it would show up
13:51 tuxayo        janPasi: I didn't know nmon, looks nice :)
13:52 janPasi       it's pretty nice, it can do logging also, so you get long term statistics with it fairly easily
13:55 janPasi       well it doesn't actually follow koha-conf.xml :D
13:55 janPasi       the plack config that is
13:56 janPasi       you have to change it in the initscript
14:04 * LeeJ        waves
14:04 LeeJ          hi #koha
14:04 kidclamp      Joubu around?
14:05 kidclamp      hmmm...not yet
14:05 LeeJ          kidclamp: thanks for helping me get that code fix of mine added so quickly the other day :)
14:07 kidclamp      np LeeJ
14:07 marcelr       pvs
14:07 marcelr       oops
14:07 kidclamp      hi marcelr
14:08 marcelr       hi kidclamp
14:08 marcelr       lvs
14:09 LeeJ          hi marcelr
14:09 marcelr       hi LeeJ
14:12 janPasi       turns out the plack-initscript is one of ours too, so there... :D
14:13 janPasi       have to fix it tomorrow
14:16 kidclamp      @later tell Joubu pingme about 19776
14:16 huginn`       kidclamp: The operation succeeded.
14:21 clrh_         oh nice, I see sandbox.bywatersolutions.com does the code published somewhere kidclamp khall ?
14:22 kidclamp      LibraryClaire++
14:22 kidclamp      clrh++
14:22 kidclamp      increment all the claires
14:22 LibraryClaire claires++
14:23 clrh          it's just a bws++ me,I did nothing =D
14:41 LeeJ          so can someone elaborate on C4::Debug? To use it is it basically just "$debug and warn 'Debug message'"?
15:32 tuxayo        Cheap automated testing idea: have a bot that clicks on random links and see if there is a 500 error.
15:32 tuxayo        That way it could be ran on the demos DBs and find regressions with existing data. See BZ 19808 for 3 examples of regressions (one or two are critical) that could have been found this way.
15:33 oleonard      tuxayo: I think that's what selenium tests are?
15:33 tuxayo        oleonard: oh, they are random?
15:33 oleonard      No, not random
15:35 tuxayo        oleonard: The idea is to have basic exploratory testing that could be ran on multiple DBs. Does that seem useful?
15:36 cait          tcohen++
15:36 tcohen        thanks
15:36 cait          tuxayo: I think randomwon't get you so far with koha, because you need to input things here and there or search
15:36 oleonard      tuxayo: I think most problems surface when testing multiple steps with user input rather than just links.
15:37 cait          alexbuckley has done a lot of work on selenium tests - if you look for sleenium in bugzilla
15:40 Joubu         hi #koha
15:42 tuxayo        \o Joubu
15:45 tuxayo        cait: Thanks, there are a lot of scenarios indeed.
15:45 tuxayo        Wouldn't randomess find enough basic issues? (like whole 500 error pages)
15:45 tuxayo        oleonard: Filling inputs could be also done, that would test error handling ^^
15:46 oleonard      tuxayo: If you build something useful it will be useful :)
15:47 tuxayo        oleonard_: of course ^^ The idea is to estimate the ROI of such a thing.
15:50 Joubu         cait: ILL component created
16:11 tuxayo        Joubu: I confirm that I can work on BZ 19808. For now I have a scenario that doesn't depend on some test DB. I can't finally go into the code to fix the issue.
16:14 Joubu         tuxayo: I did not get it, you can work on it but cannot fix the issue?
16:15 cait          Joubu: thx :)
16:19 tuxayo        Joubu: s/For now/Now
16:19 tuxayo        Sorry for the confusion, I can work and reproduce it. And it seems rather simple to fix.
16:21 barton        @later tell larryb cindy has an attachement that needs to be removed from an rt ticket; I've been pounding my head against the rt-shredder documentation and could use a second pair of eyes. Thanks!
16:21 huginn`       barton: The operation succeeded.
16:21 barton        ack, wrong channel.
16:22 * cait        hands barton the cookie jar
16:23 * barton      deposits a mackeroon.
16:25 cait          was more to take one .)
16:28 Joubu         cait, kidclamp, josef_moravec: just created https://tree.taiga.io/project/joubu-koha-rm-1711/us/138 hope that makes sense
16:29 tuxayo        Coding guidelines question: Which of the two following? (Or is there another better option?)
16:29 tuxayo        A: if ( not defined $patrons ) { next; }
16:29 tuxayo        B: next if ( not defined $patrons );
16:30 * barton      is tempted to expound on the origins of browser cookies, but is afriad that he will go down a several hour rabbit hole. Do a google search for Dan O'Niel / Odd Bodkins, if you've got a couple of hours to kill, it's a trip worth taking.
16:33 Joubu         tuxayo: definitely it's: "next unless defined $patrons;"
16:34 tuxayo        Joubu: thanks :)
16:39 cait          thx :)
17:02 LeeJ          barton++
17:03 LeeJ          :)
17:05 cait          LeeJ: I cleaned up the general kanban a bit - i assigned you some tasks I had befor to do with documentation, not sure if youwant to continue/close them
17:10 reiveune      bye
17:13 Joubu         @later tell rangi from help.pl we have "See the full documentation for Koha in the manual (online)." the link is https://koha-community.org/manual/17.11/html/ which returns a 404, could you add a redirect to https://koha-community.org/manual/17.11/en/html/ ?
17:13 huginn`       Joubu: The operation succeeded.
17:18 Joubu         @later tell rangi well, there are all the others as well :-/ https://koha-community.org/manual/17.11/html/09_acquisitions.html
17:18 huginn`       Joubu: The operation succeeded.
17:23 LeeJ          cait: okay! I'll take a look at them. Thanks!
18:47 jenkins       Project Koha_17.11_D8 build #17: SUCCESS in 29 min: https://jenkins.koha-community.org/job/Koha_17.11_D8/17/
18:47 jenkins       * aleishaamohia: Bug 19496: Fixing to_address for patron notes
18:47 jenkins       * Jonathan Druart: Bug 19496: ReplytoDefault is a pref, not a C4::Context method
18:47 jenkins       * Jonathan Druart: Bug 7143: Update about page for new dev - Victor Grousset
18:47 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496 major, P5 - low, ---, aleisha, Pushed to Stable , Patron notes about item does not get emailed as indicated
18:47 jenkins       * Jonathan Druart: Bug 19775: Try & prevent Search/History.t to fail randomly
18:47 jenkins       * oleonard: Bug 19751: Holds awaiting pickup report should not be fixed-width
18:47 jenkins       * josef.moravec: Bug 19292: Add MARC code column on libraries list
18:47 jenkins       * m.de.rooy: Bug 19439: Remove eval with exit statements from opac/unapi
18:47 jenkins       * m.de.rooy: Bug 19439: (follow-up) Remove four spaces from lines 133-149
18:47 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 trivial, P5 - low, ---, koha-bugs, Pushed to Stable , Bug for tracking changes to the about page
18:47 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , Search/History.t is failing randomly
18:47 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 enhancement, P5 - low, ---, oleonard, Pushed to Master , Holds awaiting pickup report should not be fixed-width
18:47 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292 enhancement, P5 - low, ---, josef.moravec, Pushed to Stable , Add MARC code column on libraries list
18:47 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439 major, P5 - low, ---, m.de.rooy, Pushed to Stable , Some error responses from opac/unapi get lost in eval
19:07 magnuse       have fun #koha - see y'all after xmas!
19:14 huginn`       New commit(s) kohagit: Bug 19776: (follow-up) remove dup category_type keys <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=441585a6cc402340977948338dddc6090c1b541f>
19:14 rangi         @later tell Joubu I can but wouldn't it be better to let people pick the language of the manual they want to see?
19:14 huginn`       rangi: The operation succeeded.
19:15 rangi         I'll do the redirect for now, but it would be good to get it hooked to the language the staff client is in, to choose the right link
19:16 LeeJ          can anyone shed some light on how to make output print to the log files? Can't seem to get it to work for debugging purposes
19:17 rangi         which log file?
19:17 rangi         and which process?
19:17 LeeJ          any really..just trying to get some sort of log output
19:17 rangi         well then the answer is it depends
19:17 rangi         :)
19:18 rangi         you really need to know which log you are trying to get output to, and from what process
19:18 Joubu         rangi: yes definitely but we need to fix existing links asap
19:18 rangi         ie if you're talking SIP, thats gonna be syslog
19:18 LeeJ          I'm working on improving my booking plugin but some data isn't printing out and I was trying to log the output somehow to see what was going on
19:18 rangi         plack is going to be plack-error.log
19:19 rangi         Joubu: its being rewritten now
19:20 rangi         so the links will work
19:20 Joubu         perfect, thanks!
19:20 rangi         LeeJ: if you are running just cgi, it will be one of the apache error logs (using a warn)
19:21 rangi         hopefully that helps the annoying thing with plack-error.log is it has staff and public interface stuff in it, same with plack.log
19:21 rangi         would be good to separate that out
19:23 LeeJ          thanks rangi...I added in some warns so I should find it somewhere. Just have to figure out which log file :P
19:24 rangi         are you running plack? it should be in plack-error.log under /var/log/koha/instancename/
19:24 wahanui       Hmm.  No matches for that, rangi.
19:25 LeeJ          yes I'm running plack
19:26 LeeJ          for some reason warns hadn't been printing there but I'm going to try again
19:28 rangi         you do need to restart plack each time
19:28 rangi         (just in case)
19:35 LeeJ          okay I'll give it a try :)
19:40 LeeJ          gahhh
19:40 LeeJ          rangi: if I write "warn 'Testing logging!';" that should still log in plack-error.log? Because it's not :(
19:43 LeeJ          ah! it didn't write it to plack-error.log..it wrote it to intranet-error.log
19:43 rangi         it should yes, as long as the script you are writing it in is the one being executed :)
19:43 rangi         ahh hmm then it isnt running under plack
19:43 rangi         worth noting that
19:43 LeeJ          that's strange...plack is running
19:44 LeeJ          wonder if this is in any way related to the plugin error with plack from a while ago
19:46 rangi         it might be that plugins aren't in the path that plack executes
19:46 rangi         might have to check the apache config
19:47 LeeJ          but oddly enough the logging wasn't working with plack not running
19:49 LeeJ          ugh...RIP Net Neutrality :(
19:55 rangi         weird
19:55 rangi         and yeah, thats a mess
19:56 LeeJ          it is weird..I'm trying to run a SELECT query method and return the results for display..the query via method doesn't return anything but it DOES return results using koha-mysql with the same identical query
19:56 jenkins       Project Koha_Master_D8 build #311: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D8/311/
19:56 jenkins       Jonathan Druart: Bug 19776: (follow-up) remove dup category_type keys
19:56 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Test failing randomly - fix categorycode vs category_type
19:56 * LeeJ        smashes head off desk
20:04 huginn`       New commit(s) kohagit: Bug 19767: Remove unused serial-issues.pl script <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e66a78d1075ed5a1af995f79bd92b1ffc10036d7> / Bug 18330: (follow-up) Adapt holds.t to match the new datetime format <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=400804ada19be4e6865d356e3671f6119ad56357> / Bug 18330: Handle date-time in Koha::Object->TO_JSON <http://git.koha-community.org/gitwe
20:04 * cait        waves
20:04 * LeeJ        waves to cait
20:05 cait          :)
20:09 pastebot      "LeeJ" at 127.0.0.1 pasted "Is anything in this written wrong?" (29 lines) at http://paste.koha-community.org/113
20:09 LeeJ          what did I write wrong that would cause this method to always return nothing?
20:13 Joubu         you should use $dbh->selectall_arrayref($query, {Slice => {}})
20:13 Joubu         but it will not fix your problem
20:13 Joubu         I guess the query returns 0 row :)
20:14 LeeJ          Joubu: the weird thing is the same query actually returns 2 results (as it should) via koha-mysql
20:15 rangi         can anyone remember, what value you need to set the LOST authorised value to, so that when you mark something lost it returns it off a borrowers card?
20:16 LeeJ          rangi: I believe it's 3 (Lost and Paid For)
20:16 rangi         thanks
20:18 cait          it all does
20:18 cait          doesn't matter
20:18 rangi         even negative?
20:18 cait          but you need to return it from the items tab not the edit item form
20:18 cait          all the default values we have are positive, never tried negative
20:18 cait          but if you return from the item form = remians on the account, if you return from detai page, items tab = gets returend
20:19 rangi         thanks cait
20:19 cait          http://bywatersolutions.com/2015/02/23/lost-koha/
20:19 LeeJ          cait++
20:19 cait          and with the longoverdues script you can choose i think (but i remember there was some bug there)
20:21 rangi         right, this is just for my kids chool
20:21 rangi         school even
20:21 rangi         marking books lost from the interface at the end of the year
20:24 LeeJ          that makes sense
20:24 LeeJ          ugh...I've given up on figuring out that problem for today. It gave me a migraine
20:26 * cait        hands LeeJ the cookie jar
20:26 cait          ginger bread cookies with lemon icing
20:26 Joubu         bug 12363
20:26 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363 major, P5 - low, ---, jonathan.druart, Pushed to Master , Marking an item as lost in koha always returns it, but longoverdue.pl may not
20:26 LeeJ          oooooh
20:26 LeeJ          those sound delicious
20:26 cait          and sprinkles!
20:26 LeeJ          :D
20:26 Joubu         ('always' is wrong)
20:27 Joubu         gmcharlt_: Hi, Are you admin of https://gitlab.com/koha-community?
20:27 Joubu         someone else here?
20:28 Joubu         mtj: ^?
20:28 wahanui       ^ is what I think too
20:29 cait          not me
20:29 cait          :)
20:37 gmcharlt_     Joubu: not me either
20:37 Joubu         ok, certainly mtj then :)
20:39 * cait        thinks that's a good guess
20:41 LeeJ          well I'm gonna head out for some R & R to get rid of this headache
20:41 LeeJ          have a good night all
20:41 cait          LeeJ: goodnight, get better
20:41 LeeJ          cait: thanks! :)
20:45 jenkins       Project Koha_Master_D8 build #312: UNSTABLE in 42 min: https://jenkins.koha-community.org/job/Koha_Master_D8/312/
20:45 jenkins       * Jonathan Druart: Bug 19560: Correctly escape branchcode in admin/branches.pl
20:45 jenkins       * alexbuckley: Bug 19514: Implement password restrictions into onboarding tool
20:45 jenkins       * Jonathan Druart: Bug 19514: Add client-side check
20:45 jenkins       * oleonard: Bug 19758: Move template JavaScript to the footer: Serials, part 1
20:45 jenkins       * oleonard: Bug 19761: Move template JavaScript to the footer: Serials, part 2
20:45 jenkins       * oleonard: Bug 19777: Move template JavaScript to the footer: Serials, part 3
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Unable to delete library when branchcode contains special characters
20:45 jenkins       * oleonard: Bug 19778: Move template JavaScript to the footer: Serials, part 4
20:45 jenkins       * oleonard: Bug 19607: Move admin templates JavaScript to the footer: Basic
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 major, P3, ---, alexbuckley, Pushed to Master , No Password restrictions in onboarding tool patron creation
20:45 jenkins       * oleonard: Bug 19627: Move patron clubs templates JS to the footer
20:45 jenkins       * oleonard: Bug 19627: (follow-up) Include tools-menu.js on required templates
20:45 jenkins       * oleonard: Bug 19663: Move JS to the footer: Reports
20:45 jenkins       * lari.taskula: Bug 18330: Add RFC3339 to Koha::DateUtils
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move template JavaScript to the footer: Serials, part 1
20:45 jenkins       * lari.taskula: Bug 18330: Handle date-time in Koha::Object->TO_JSON
20:45 jenkins       * Tomás Cohen Arazi: Bug 18330: (follow-up) Adapt holds.t to match the new datetime format
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move template JavaScript to the footer: Serials, part 2
20:45 jenkins       * oleonard: Bug 19767: Remove unused serial-issues.pl script
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move template JavaScript to the footer: Serials, part 3
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move template JavaScript to the footer: Serials, part 4
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move admin templates JavaScript to the footer: Basic parameters
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move patron clubs templates JS to the footer
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move JS to the footer: Reports
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330 enhancement, P5 - low, ---, lari.taskula, Pushed to Master , REST API: Date-time handling
20:45 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 minor, P5 - low, ---, oleonard, Pushed to Master , serial-issues.pl is unused and should be removed
21:37 cait          kidclamp_away: ping
23:36 jenkins       Project Koha_16.11_D8 build #90: STILL UNSTABLE in 2 hr 4 min: https://jenkins.koha-community.org/job/Koha_16.11_D8/90/
23:36 jenkins       Jonathan Druart: Bug 19655: Use ->build instead of build_object in 16.11.x
23:36 huginn`       04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655 critical, P5 - low, ---, kyle, Pushed to Stable , To.json doesn't escape newlines which can create invalid JSON