Time Nick Message 07:26 fridolin hi 07:29 reiveune hello 07:30 * magnuse waves 07:31 LibraryClaire hi #koha 07:52 LibraryClaire tfw you spend half an hour testing a patch and then go to sign off and find you never hit 'y' when it asked 'Apply?' -.- 07:54 alex_a bonjour 07:57 LibraryClaire salut alex_a 07:58 alex_a hello LibraryClaire 08:24 gaetan_B hello 08:29 tuxayo Hi :) does anyone have an idea why does the borrowers permission (Add, modify and view patron information) is needed for a user to see it's **own** search history in the OPAC? It's only enforced when the OPAC is private. 08:29 tuxayo https://gitlab.com/tuxayo/koha/blob/master/opac/opac-search-history.pl#L44 08:32 tuxayo LibraryClaire: so the patch wasn't necessary to get the desired result? 08:32 tuxayo #placebo-coding 08:34 LibraryClaire tuxayo: it was moving JS to footer so ideally there should be no change ^^ 08:54 cait tuxayo: that does not make sense. users don't have permissions 08:54 cait tuxayo: have you checked opacreadinghistory system preference? 09:05 * andreashm waves 09:27 magnuse \o/ 09:31 tuxayo cait: is the search history releated to opacreadinghistory ? 09:43 eythian hi 09:56 andreashm hey eythian 10:18 cait tuxayo: oops sorry, wrong pref 10:18 cait but there is one for turning on/off search history too 10:23 gaetan_B cait: what we found out is that, if you have activated search history on the opac with the proper syspref, and have an opac set to private via opacpublic, then patrons can only access their search history if they have the permission to manage borrowers 10:23 gaetan_B that really sounds like a bug to me 10:23 gaetan_B but tuxayo says it's been this way since the feature was introduced 10:24 gaetan_B i can't think of a good reason why, for me permissions should only be for the backend really 10:24 cait it does sound like a bug 10:24 cait checking perms in the opac makes no sense 10:24 cait it should check if you are logged in 10:26 tuxayo gaetan_B: cait : Here is the commit that created the feature: https://gitlab.com/tuxayo/koha/commit/feeafa8168965183ba8651cf3113c3c32af863ec#3b990c11bf2936859187ffcbafd4afd71e096140_0_42 10:46 gaetan_B cait: i think we'll take care of fixing bug 12497 while fixing this behaviour then. 10:46 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 minor, P5 - low, ---, oleonard, NEW , OPAC search history page should only be accessible when feature is activated 10:46 cait sounds good 10:47 gaetan_B maybe we'll just make one patch on this ticket 11:50 oleonard Hi all 11:50 LibraryClaire hi oleonard 12:43 tcohen morning 12:45 magnuse ¡hola! 12:54 oleonard LibraryClaire++ 12:54 oleonard Thanks for the patch testing 12:57 LibraryClaire you're welcome :) 13:13 jenkins Project Koha_16.05_D8 build #15: UNSTABLE in 26 min: https://jenkins.koha-community.org/job/Koha_16.05_D8/15/ 13:13 jenkins * Jonathan Druart: Bug 17278: Use available limit when requesting zebra when ccl query is 13:13 jenkins * Jonathan Druart: Bug 17278: Fix "show all items" link 13:13 jenkins * Jonathan Druart: Bug 17278: Fix test compilation errors 13:13 jenkins * Jonathan Druart: Bug 19262: Remove xt/author/pod_spell.t 13:13 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 major, P5 - low, ---, jonathan.druart, RESOLVED FIXED, Limit to available items returns 0 results 13:14 jenkins * nick: Bug 18801 - Merging authorities has an invalid 'Default' type in the 13:14 jenkins * m.de.rooy: Bug 18801: [Follow-up] Dbrev to repair bad auth type codes 13:14 jenkins * mtj: Bug 18801: DBRev 16.05.18.001 13:14 jenkins * dominic: Bug 18584 - removed white space in C4/Accounts.pm 13:14 jenkins * Tomás Cohen Arazi: Bug 19337: Make basic_workflow.t configurable through ENV 13:14 jenkins * oleonard: Bug 15644 - City dropdown default selection when modifying a patron 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , pod_spell.t does not work 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18801 normal, P5 - low, ---, nick, Pushed to Stable , Merging authorities has an invalid 'Default' type in the merge framework selector 13:14 jenkins * aleishaamohia: Bug 16204: Show friendly error message if trying to edit record which no 13:14 jenkins * m.de.rooy: Bug 19415: FindDuplicateAuthority is searching on biblioserver since 13:14 jenkins * aleishaamohia: Bug 19195: Preventing noisy warns when creating or editing a basket 13:14 jenkins * Jonathan Druart: Bug 19195: Do not explicitely force scalar context when unecessary 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 trivial, P5 - low, ---, koha-bugs, NEW , Our legacy code contains trailing-spaces 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337 enhancement, P5 - low, ---, tomascohen, Pushed to Stable , Allow basic_workflow.t be configured by ENV 13:14 jenkins * aleishaamohia: Bug 16463: Replace discharge link with error message if user has checked 13:14 jenkins * nick: Bug 19307: Mock the AllowFineOverride preference to ensure expected 13:14 jenkins * Jonathan Druart: Bug 19392: Clean-up behind auth_values_input_www.t 13:14 jenkins * aleishaamohia: Bug 16726: Clear text in syspref searchbox after submitting 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644 enhancement, P5 - low, ---, oleonard, Pushed to Stable , City dropdown default selection when modifying a patron matches only on city 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16204 enhancement, P5 - low, ---, aleisha, Pushed to Stable , Show friendly error message when trying to edit record which no longer exists 13:14 jenkins * aleishaamohia: Bug 16726: [FOLLOW-UP] Putting text in h1 13:14 jenkins * Jonathan Druart: Bug 16726: Do not display "You searched for:" if not needed 13:14 jenkins * Jonathan Druart: Bug 19386: Prevent t/db_dependent/SIP/Patron.t to fail randomly 13:14 jenkins * m.de.rooy: Bug 19386: [QA Follow-up] Remove some default values 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415 major, P5 - low, ---, m.de.rooy, Pushed to Stable , FindDuplicateAuthority is searching on biblioserver since 16.05 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19195 minor, P5 - low, ---, aleisha, Pushed to Stable , Noisy warns when creating or editing a basket 13:14 jenkins * david.bourgault: Bug 19345: Add missing error flag to template 13:14 jenkins * mtompset: Bug 17664: Silence non-zebra warnings in t/db_dependent/Search.t 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 normal, P5 - low, ---, aleisha, Pushed to Stable , OPAC discharge page should warn the user about checkouts before they request 13:14 jenkins * nick: Bug 19193: When displaying the fines of the guarantee on the guarantor 13:14 jenkins * Jonathan Druart: Bug 19423: Prevent DecreaseLoanHighHolds.t to fail randomly 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 normal, P5 - low, ---, nick, Pushed to Stable , t/db_dependent/Circulation/NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow 13:14 jenkins * pongtawat: Bug 17610 - Allow the number of plack workers and max connections to be 13:14 jenkins * techservspec: Bug 18616 - The "Add forgot password link to OPAC" should allow patrons 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , auth_values_input_www.t does not clean up 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 minor, P5 - low, ---, aleisha, Pushed to Stable , Text in Preferences search box does not clear 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , t/db_dependent/SIP/Patron.t is failing randomly 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19345 minor, P5 - low, ---, david.bourgault, Pushed to Stable , SendMail error does not display error message in password recovery 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17664 minor, P5 - low, ---, mtompset, Pushed to Stable , Silence non-zebra warnings in t/db_dependent/Search.t 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193 minor, P5 - low, ---, nick, Pushed to Stable , When displaying the fines of the guarantee on the guarantor account, price is not in correct format. 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 normal, P5 - low, ---, jonathan.druart, Pushed to Stable , DecreaseLoanHighHolds.t is failing randomly 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 enhancement, P5 - low, ---, kyle, Pushed to Stable , [16.11.x] Allow the number of plack workers and max connections to be set in koha-conf.xml 13:14 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 enhancement, P5 - low, ---, oleonard, Pushed to Stable , The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username 13:37 tcohen hi cait 13:40 tuxayo Just to have a rough idea: How complete are the automated tests? (whether unit, integration, functional) I.e is it still easy to break a big part of Koha without one of the tests noticing it? 13:42 jenkins Yippee, build fixed! 13:42 jenkins Project Koha_16.05_D8 build #16: FIXED in 24 min: https://jenkins.koha-community.org/job/Koha_16.05_D8/16/ 13:42 jenkins mtj: Revert "Bug 19392: Clean-up behind auth_values_input_www.t" 13:48 cait hi tcohen 14:03 magnuse jzairo: detailed coverage reports used to be part of the work Jenkins did, but i think that ot turned off. there are some numbers on the right hand side here: https://jenkins.koha-community.org/job/Koha_Master_D8/ 14:04 jzairo thanks magnuse 14:11 magnuse jzairo: i think you can use Devel::Cover and the accompanying "cover" commmand to get detailed stats, but i don't remember how 14:16 * fridolin releasing 17.05.06 14:29 magnuse fridolin++ 14:30 fridolin thanks ;) 14:43 fridolin cait: yop, on download site, there are still 16.11.13 release files 14:43 fridolin you may remove them 14:44 fridolin release in in progress, we are waiting for packaging before anoncement 14:48 cait fridolin: i never do 14:48 cait i only always add to it 14:49 cait maybe some automatism that hasn't worked yet as i uploaded just this morning? 14:49 cait i don't even know how to delete :) 14:50 fridolin cait: o sorry do not delete but move to old_release 14:50 fridolin just mv files i'd say 14:50 cait yeah but i never did that and they always disappeared 14:50 fridolin maybe done my RM 14:50 cait it hink you don't have to - it's not in the instructions 14:51 cait tcohen: do you know? 14:51 fridolin cait: there is in wiki : "Older versions of the same release should be moved into the old_releases directory" 14:51 cait huh 14:52 tcohen what's the question? 14:52 cait ok, you are right it#s mentioned, but I wonder what happened to all my other files :) 14:52 cait tcohen: turns out i never moved the old release files but they still disappeared 14:52 cait to do you know why? 14:52 cait fridolin: could you move mine? wrong computer, no key 14:52 tcohen maybe they are just in the old_ place 14:53 cait yeah but how did they get there :) 14:53 tcohen when I was RM I moved files when people forgot 14:53 cait bit late for me now :) i am out with this release 14:53 tcohen I can't speak for the current RM, just push critical stuff for the release 14:54 cait it was just a workflow question - I was also trying ot update documentation lately 14:54 fridolin cait: done 14:54 cait thank you 14:54 cait fridolin++ 14:54 cait has anyone heard from drojf[m] yet? 14:54 fridolin i dont know how i get the permission but mv worked 14:59 fridolin tcohen: cait btw server is nearly full 2.8G available 14:59 cait fridolin: maybe put the example command on the wiki? stands more out then 14:59 fridolin old releases takes 14G 14:59 cait who runs it? 14:59 cait fridolin: btw, still no luck with the koha-docs mailing list 14:59 cait who is taking care of the mailing lists? 14:59 fridolin dont know 15:00 fridolin ah the lists its us 15:00 cait i know 15:00 fridolin cait: what is your pb ? 15:00 cait If you are having trouble using the lists, please contact mailman@lists.koha-community.org... - got stuck in moderation too :( 15:00 cait the list is closed 15:00 cait we don't have access 15:00 cait and we told people to send stuff there for the manual 15:00 cait it's a closed list still controlled by nengard, but noticed too late 15:01 fridolin arf 15:01 nengard ?? 15:01 cait i only noticed when i sent the invitation to the docs meeting and it didn't went through 15:01 cait hey nengard :) 15:02 cait sorry, didn't want to summon you 15:02 cait but do you still have access to koha-docs? 15:02 cait http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-docs 15:02 nengard No worries at all, let me go see ... 15:02 cait fridolin: so... who hosts download? equinox? 15:02 nengard Ooooo I do :) 15:02 nengard Who can I change it to? 15:02 fridolin download i dont know 15:03 fridolin we could juste delete from old releases 15:03 cait ah chris 15:03 nengard i'm on my work computer can you give me his email address? 15:04 cait nengard: which address? 15:05 nengard whatever one you want me to use as the admin email address 15:06 cait ah 15:06 cait can you add me for now and I can go change it later to documentation team? 15:09 fridolin i've send a mail about download 15:09 cait nengard gave me access 15:15 cait seems there were some emails stuck 15:18 edveal Good morning 15:18 cait morning edveal 15:18 edveal Or afternoon as the case might be. :) 15:19 LibraryClaire hi edveal 15:22 edveal cait any new information on the documentaition meeting? 15:27 oleonard edveal: https://wiki.koha-community.org/wiki/Documentation_IRC_meeting_23_November_2017 (Nov 30) 15:30 edveal Thanks oleonard 15:32 oleonard Happy Birthday barton! 15:33 barton thanks oleonard! 15:33 barton doesn't feel any different ... thank god. 15:33 edveal Ah happy b-day barton 15:34 barton thanks edveal! 15:36 cait edveal: sent an emai last night - sorry, was afk 15:36 oleonard barton: Did you co-workers decorate your office cubicle at least? ;) 15:36 cait and happy birthday barton :) 15:37 barton oleonard: I think the doggies would have volunteered, but I have a puppy gate up. 15:37 barton thanks cait! 15:45 cait bye all :) 16:06 reiveune bye 16:11 talljoy @later tell cait Hello! I had a question regarding diacritics for you. (russian diacritics) :D 16:11 huginn talljoy: The operation succeeded. 19:34 * andreashm waves 19:45 oleonard I think I'm now about half way through Bug 17858 19:45 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 enhancement, P5 - low, ---, oleonard, NEW , Omnibus: Move staff client JavaScript to the footer 20:00 oleonard Someone please revive http://splitter.koha-community.org. Thanks. Bye. 20:01 wizzyrea idk who runs that 20:02 wizzyrea though it looks like it's working to me? 20:03 wizzyrea also hi 22:32 tcohen oleonard should reset his browser's cache