Time Nick Message
23:22 bag catch y’all later
23:22 bag ok I gotta go put a chicken in the rotisserie
23:22 magnuse bag++
23:20 bag magnuse++
23:20 bag awh thanks magnuse
23:19 magnuse bag++
23:17 bag ok cool - :D I will copy two messages into your pm then
23:17 magnuse i will investigate
23:16 magnuse yeah, i have seen a couple examples of that
23:16 magnuse gah
23:16 bag magnuse: I keep getting rejected when I try to send you emails :)
23:02 magnuse yay
23:02 cait willdo
23:01 magnuse cait: go to sleep :-)
22:36 huginn cait: Joubu was last seen in #koha 33 minutes and 33 seconds ago: <Joubu> bye #koha, I will be afk for a while! :)
22:36 cait @seen Joubu
22:15 magnuse see you later Joubu - thanks for pushing 7317!
22:02 Joubu bye #koha, I will be afk for a while! :)
19:46 magnuse tjänare mirkh
19:32 magnuse especially if it helps keep nso as low as it is now
19:32 * magnuse would not mind a summer-themed dashboard in december
19:31 oleonard Does <<items.content>> in notices always display as plain space-separated text or can you modify it somehow?
19:30 rangi im happy to switch out any css given to me ;)
19:30 rangi im pretty sure francessca did a holiday themed one last year
19:30 oleonard Koha Dashboard Beach Party
19:30 oleonard Leave it up to someone in rangi's neighborhood and it will be summer-themed.
19:28 magnuse will someone volunteer to do a yuletide-style dashboard, i wonder?
19:23 rangi heh
19:23 oleonard Thanks rangi I was shaking in my boots
19:22 rangi oleonard: dashboard back to normal
19:20 oleonard No wahanui no confetti.
19:08 huginn magnuse: I suck
19:08 magnuse @confetti
19:08 magnuse confetti!
19:08 magnuse Joubu++ tcohen++ atheia++ for the ILL module!!!
17:56 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 new feature, P5 - low, ---, alex.sassmannshausen, Pushed to Master , Add an Interlibrary Loan Module to Circulation and OPAC
17:56 jenkins Jonathan Druart: Bug 7317: Fix translatable-templates.t failure
17:56 jenkins Project Koha_Master_D8 build #292: FIXED in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D8/292/
17:56 jenkins Yippee, build fixed!
17:39 oleonard Thanks Joubu. I should RTFM
17:39 Joubu it means you should create a patron category with a category_code="ILLLIBS", or modify the partner_code entry in your koha-conf
17:38 Joubu "ILLLIBS" is the default category_code the the ILL partners
17:38 Joubu there is a new entry you will have to c/p
17:38 Joubu oleonard: see koha-conf.xml from the repo and yours
17:31 oleonard Oh, hm. That error doesn't prevent me from accessing the ILL page
17:29 oleonard Does anyone know how to resolve that?
17:28 oleonard "Warning: The ILL module is enabled, but the configured 'partner_code' (ILLLIBS) is not defined on the system"
17:25 huginn New commit(s) kohagit: Bug 7317: Fix translatable-templates.t failure <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=d149f1963e3f23f2fc880fa839dadc488428e52a>
17:16 oleonard Thanks, I missed it in the sea of comments
17:15 Joubu comment 20
17:15 Joubu well yes, there is a good test plan
17:15 oleonard Who should I bug for help? :)
17:14 Joubu nope
17:14 oleonard Joubu: Is there a guide for doing ILL testing with the dummy backend?
17:02 jenkins * Jonathan Druart: Bug 7317: DBRev 17.06.000.028
17:02 jenkins * Jonathan Druart: Bug 7317: DBIC Schema changes
17:02 jenkins * Jonathan Druart: Bug 7317: Display all the libraries, not only one
17:02 jenkins * Jonathan Druart: Bug 7317: Make fields mandatory when sending emails
17:02 jenkins * Jonathan Druart: Bug 7317: Do not use GET for deletion requests
17:02 jenkins * Jonathan Druart: Bug 7317: Simplify column headers
17:02 jenkins * Tomás Cohen Arazi: Bug 7317: (QA followup) Make query parameters consistent with other
17:02 jenkins * Tomás Cohen Arazi: Bug 7317: Remove traces of UnmediatedILL
17:02 jenkins * Tomás Cohen Arazi: Bug 7317: (followup) Remove extra columns from backends on the main list
17:02 jenkins * Tomás Cohen Arazi: Bug 7317: (QA followup) Rename 'branch' for 'library'
17:02 jenkins * Jonathan Druart: Bug 7317: Fix more translation issues
17:02 jenkins * Jonathan Druart: Bug 7317: use preventDefault to prevent the scrollbar to move to the top
17:01 jenkins * Jonathan Druart: Bug 7317: Add missing 'use Encode' statement
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: (QA followup) Fix capitalization and terminology issues
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: Handle missing email addresses gracefuly
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: (QA followup) ILL sysprefs belong to circulation section
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: (followup) Make tests independent of data on the DB
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: Add partner_code checks to abot page
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: opac.css update
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: (QA followup) Get rid of warnings from the tests
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: Handle backend absense more gracefuly
17:01 jenkins * magnus: Bug 7317: QA followup
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: Rewrite atomicupdate file
17:01 jenkins * magnus: Bug 7317: (followup) Fix id and class on body tag
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: Adjust packages koha-conf.xml
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: (followup) Migrate endpoint to OpenAPI
17:01 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 new feature, P5 - low, ---, alex.sassmannshausen, Pushed to Master , Add an Interlibrary Loan Module to Circulation and OPAC
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: Overload Koha::Illrequest::TO_JSON
17:01 jenkins * Tomás Cohen Arazi: Bug 7317: (QA folowup) 404 if module is disabled (intranet)
17:01 jenkins * alex.sassmannshausen: Bug 7317: Interlibrary loans framework for Koha.
17:01 jenkins * alex.sassmannshausen: Bug 7317: Add SQL templates & sysprefs.
17:01 jenkins Project Koha_Master_D8 build #291: UNSTABLE in 28 min: https://jenkins.koha-community.org/job/Koha_Master_D8/291/
16:57 huginn oleonard: The operation succeeded.
16:57 oleonard @later tell rangi Can the dashboard be un-spookied now that October is over?
16:55 oleonard I mean, oh no
16:55 oleonard Oh know the Koha dashboard is still spooky.
16:33 huginn New commit(s) kohagit: Bug 7317: DBRev 17.06.000.028 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ff8b030970e6e404a777418043994da3e55c9b7c> / Bug 7317: DBIC Schema changes <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dd88680cbec5d044e604e567cb65bffab091e618> / Bug 7317: Display all the libraries, not only one <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=45a87377213e8b487e5bd00063b40a7fe0
16:03 reiveune bye
15:53 oleonard Yes we still need a Big Button Plan.
15:50 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 enhancement, P5 - low, ---, josef.moravec, NEW , Make all buttons Bootstrap styled
15:50 Joubu bug 17873
15:49 Joubu oleonard: we should replace our buttons class="approve" with class="btn btn-default btn-sm approve". They look better :)
15:46 oleonard Joubu: Generally speaking I don't think one is preferable over the other, with the exception of "destructive" actions like deletions.
15:44 Joubu no should not be a post actually
15:41 Joubu same is used for "yes", I have my answer then
15:40 Joubu heh, get vs post
15:40 Joubu or 2/ <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
15:39 Joubu 1/ <a class="btn btn-default btn-sm deny" href="?method=illview&illrequest_id=1"><i class="fa fa-fw fa-remove"></i>No</a>
15:39 Joubu oleonard: what's better:
15:30 talljoy MEOW
15:23 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 normal, P5 - low, ---, oleonard, Needs Signoff , Unable to delete library when branchcode contains special characters
15:23 oleonard Like a proud cat presenting the carcass of a songbird I leave a patch for Bug 19560 on talljoy's front porch.
14:53 tuxayo cait: «but you probably won't do that for deleting a branch» unless you're an attacker ;)
14:52 cait tuxayo: not yet :)
14:52 tuxayo oleonard: ok maybe DELETE for delete operations? (if it's an HRX/AJAX request)
14:45 cait generally get is nice becuase you can craft links... but you probably won't do that for deleting a branch
14:45 cait i had one that also broke the link
14:44 cait i had run into it when testing the xss patches
14:44 * oleonard thinks delete operations should be POST anyway
14:44 cait hm ot sure
14:44 oleonard Oh, you're right that it's a GET operation. I wonder if changing it to POST would change it.
14:44 cait if the branchcode is part of the url
14:44 cait not sure
14:44 cait oleonard: hm maybe something about the url encoding?
14:43 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 enhancement, P5 - low, ---, koha-bugs, NEW , Special characters & and # in branchcode - unable to delete branch
14:43 oleonard Why would special characters in a branch code prevent it from being deleted? Bug 19560
14:17 Joubu just apply the patch
14:17 Joubu nope
14:16 kidclamp with second the calls should be changed right? No need to call it on results of other query? doing too many things at once so apologies if causing confusion :-)
14:14 Joubu kidclamp: The second patch should be better
14:06 kidclamp so iterate over patrons instead of massive query, looks reasonable at least
13:59 Joubu kidclamp: I attached 2 patches, I do not think the first patch will help, but the second one generates 2 simple queries and should be much faster
12:48 tcohen hola Joubu
12:48 Joubu hola tcohen
12:47 Joubu we should "force" DBIC to execute 2 queries, not this ugly stuff
12:47 kidclamp :-)
12:46 Joubu forget that, it's stupid
12:45 Joubu it makes the tests fail
12:45 kidclamp yeah, I'll need to get some sample data to test with, can you post that on the bug and I will try soon?
12:43 Joubu kidclamp: could you modify it like that and retry? ^
12:43 pastebot "kidclamp" at 127.0.0.1 pasted "new nonymise_issue_history?" (11 lines) at http://paste.koha-community.org/71
12:42 tcohen morning
12:42 Joubu kidclamp: the call does not make sense, it must be Koha::Patrons->search_patrons_to_anonymise( { before => $last_issue_date } )->anonymise_issue_history()
12:37 oleonard Hi all
12:34 kidclamp Koha::Patrons->search_patrons_to_anonymise( { before => $last_issue_date } )->anonymise_issue_history( { before => $last_issue_date } );
12:34 kidclamp it is generated by calling on the other sub
12:29 Joubu it should be 1 join on old_issues, that's it
12:28 Joubu The query is the one generated by this subroutine, it's what you mean right?
12:28 pastebot "kidclamp" at 127.0.0.1 pasted "anonymise_issue_history" (25 lines) at http://paste.koha-community.org/70
12:26 kidclamp I think the inner query is the patron one, then it gets wrapped in the anonymising one
12:24 Joubu I do not understand the generated query, why is it so complicated?
12:22 Joubu ha no
12:21 Joubu ha, it was a call per patron
12:21 kidclamp they were separate routines
12:20 Joubu kidclamp: what was done before?
12:19 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 major, P5 - low, ---, koha-bugs, NEW , anonymise_issue_history can be very slow on large systems
12:19 magnuse bug 19599
12:16 kidclamp can I get your thoughts on 19599 whenyou have a chance?
12:15 kidclamp Hi Joubu
12:11 Joubu hi #koha
08:30 * magnuse waves
07:45 fridolin hie tehre
07:44 alex_a bonjour
07:38 reiveune hello