Time Nick Message
01:14 rangi mtj++
01:27 mtompset Greetings, #koha.
01:27 mtompset aleisha: Just working through the last test plan I posted. :)
01:36 mtj hiya rangi, can i catch you this arvo for a quik mellon/plack chat?
01:37 rangi yep, gimme 10 mins then ill be around
01:38 mtj i thinking i just need to confirm the x-header stuff
01:45 rangi right
01:45 rangi yeah you need to add that whereever you have auth
01:46 rangi what i did, turn auth on for everywhere
01:46 rangi then disable for the places that dont need it
01:46 rangi which was eaiser
01:46 rangi eg
01:46 rangi <Location /cgi-bin/koha/opac-image.pl>
01:46 rangi MellonEnable "info"
01:46 rangi </Location>
01:46 rangi thats a no auth stanz
01:46 rangi a
01:47 rangi and you set the X_REMOTE_USER header
01:47 mtompset @later tell aleisha If comment #112 has anything you didn't do in your testing, try it before signing off.
01:47 huginn mtompset: The operation succeeded.
01:47 mtj ah ok... so thats an easy fix
01:47 rangi (making sure to wipe it first so people cant pass in bogus ones)
01:47 rangi Header unset X_REMOTE_USER
01:47 rangi then set it yourself
01:48 rangi http://git.catalyst.net.nz/gw?p=koha.git;a=blob;f=C4/Auth.pm;h=bb4e36715d9e1567801e09de6f2f52996ef81302;hb=8b7646d774bde21e80e1304936dee18f349f349d#l798
01:49 rangi check that out for the code stanza to catch that header in plack
01:49 rangi my $trusted_header = C4::Context->config('trusted_header');
01:49 rangi my $trust_head_val = get_header($trusted_header) if $trusted_header;
01:50 rangi RequestHeader set X_REMOTE_USER %{MELLON_sfdcid}e
01:50 rangi now that is going to be different
01:51 rangi because sfdcid
01:51 rangi is the value from salesforce
01:51 rangi you have to find out what the value is being passed back from your saml server
01:51 rangi and setit to be that
01:51 rangi does that make sense?
01:52 mtj hmm, yes i think so ... i'll have a little play with mine
01:53 mtj any other mods needed - or is that it
01:55 rangi just those code mods, if they arent in C4/Auth.pm that should be it
01:56 mtj yep, i see the two WR237697 patches
01:57 mtj ta, thats enough for me, i think :0)
01:57 rangi sweet :)
01:58 mtj ooh, does this mod *only* work for plack? .. ie: no cgi mode
02:02 mtj "Note: for reasons I can't really tell, this doesn't work when apache is
02:02 mtj running Koha as CGI, but does work under plack."
02:02 mtj ... or did that issue get resolved later
02:03 rangi yep, with cgi it should set normal headers you dont have to set a new one to pass through
02:03 rangi we dont run anything not in plack anymore, so havent looked into that
02:14 mtj yeap, makes sense.. thanks!
03:39 mtompset Have a great day, #koha rangi mtj
06:29 marcelr hi #koha
06:34 cait marcelr: so git bz behaves differently for you wehter there is signed off or not?
06:34 marcelr the difference is the {SIGNED_OFF] label
06:34 marcelr if there is no label, git bz will obsolete automatically
06:35 cait i didn't know that
06:35 marcelr so sometimes you forget
06:35 marcelr and then you need to git bz edit them
06:35 marcelr it is only extra work for signer and qaer
06:35 cait it's a valid reason
06:36 cait but it was not very clear from your email to me :)
06:36 cait i don't think people are aware of the difference
06:36 marcelr to the list ?
06:36 marcelr well respond please
06:36 cait can't right now, but will try to later
06:36 cait have to get to work :)
06:36 marcelr ok
06:36 cait and i can change my scripts
06:37 cait i use git so2 <number of commits>
06:37 cait so it's all done automatically
06:37 marcelr good
06:37 cait incuding the label
06:37 marcelr i should remove them with a script :)
06:37 cait maybe add to the next meeting? we'd have to change the wiki etc too and maybe some of the scripts
06:37 cait you could do that on applying as a hook maybe?
06:38 cait or with your sign off one
06:38 marcelr yes, but if no one adds them we do not need a hook
06:44 cait takes some time to achieve that
06:44 cait changing git bz to make it smarter might be the better immediate move
06:50 cait we can try both
06:50 cait bbl
07:07 drojf morning #koha
07:13 marcelr hi drojf
07:13 drojf hi marcelr
07:13 drojf @seen Joubu
07:13 huginn drojf: Joubu was last seen in #koha 1 day, 16 hours, 33 minutes, and 15 seconds ago: <Joubu> see also bug 18789, same for patrons :)
07:18 drojf @later tell Joubu is there an ETA for the security release? packages are done, don't know if the RMaints put all in place you need
07:18 huginn drojf: The operation succeeded.
07:27 alex_a bonjour
07:29 reiveune hello
07:46 cait marcelr++
07:48 drojf hi cait
08:07 drojf tumbleweed.gif
08:15 eythian hi
08:15 wahanui que tal, eythian
08:19 * magnuse waves
08:37 * andreashm waves
08:44 magnuse hooray for bug 19173 - plugin all the things!
08:44 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 enhancement, P5 - low, ---, kyle, Signed Off , Make OPAC online payments pluggable
08:44 magnuse khall++
08:45 magnuse hiya andreashm
08:45 andreashm hi magnuse!
08:45 wahanui kamelåså
08:45 andreashm magnuse: how's it going?
08:45 magnuse good
08:45 magnuse busy
08:46 josef_moravec khall++
08:46 magnuse doing another migration, which means putting semantikoha on the backlist for a bit again, sadly
08:51 andreashm magnuse: ah, to bad with semantikoha, but good with new clients! =)
09:00 magnuse yup
09:01 magnuse and there is norwegian ill to finish, and swedish ill to start out on...
09:05 andreashm all things ill!
09:06 magnuse hehe yeah
09:06 magnuse i *really* hope we get the generic ill module into 17.11!
09:07 andreashm any bug for that?
09:07 magnuse bug 7317
09:07 wahanui bug 7317 is, like, pretty idle
09:07 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 new feature, P5 - low, ---, alex.sassmannshausen, Patch doesn't apply , Add an Interlibrary Loan Module to Circulation and OPAC
09:07 magnuse there is a minor conflict and some missing tests. apart from that i am ready to sign it off, at least
09:07 andreashm looks like it needs a rebase
09:08 andreashm I'm hoping the OAI-PMH harvester makes it into 17.11
09:08 magnuse i think it is just a css conflict
09:08 magnuse yeah!
09:08 andreashm bug 10662
09:08 wahanui bug 10662 is a catch all at the moment
09:08 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 new feature, P3, ---, dcook, Needs Signoff , Build OAI-PMH Harvesting Client
09:09 magnuse i should be able to sign that off once i get to play a bit with the harvesting again
09:11 andreashm great!
09:12 magnuse ...which i have to do anyway to get semantikoha moving
09:13 andreashm good. is the demo site showing anything at the moment?
09:13 andreashm I thought I'd go and look for myself, but it's easier to ask. =9
09:14 magnuse nah, i think it got a bit broken just as i was heading off to my holiday...
09:15 andreashm ok
09:15 andreashm guess it won't be up until you get time to work on semantikoha again? I might be talking to my boss (one of them) about the project today. would be good to know the status of the demo-server, haha.
09:16 magnuse hehe, yeah, i'm afraid it will be a wee while before i can look at it again
09:18 andreashm alright
09:18 andreashm I'll be sure to remind you. =)
09:49 drojf .
09:50 drojf network weirdness, but irc does not seem to care
10:01 josef_moravec anybody interested in testing bug 18606 ;)
10:01 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 enhancement, P5 - low, ---, josef.moravec, Needs Signoff , Move rotating collections code to Koha::Object
10:34 marcelr SO back to 151; qaers, get it down further !
10:34 marcelr have to go
10:36 josef_moravec marcelr+
10:36 josef_moravec marcelr++
10:48 cait indeed marcelr++
10:51 drojf have a nice weekend #koha
10:54 cait translate down for anyone else?
10:57 josef_moravec cait: up for me
10:57 cait hm strange
10:57 cait which URL?
10:57 wahanui which URL are you adding them from?
10:58 cait i get a network timeout
11:01 cait @later tell wizzyrea can we remove the github link from the community resources on the kc.org start page? I think it might lead to people thinking we use it actively, as we sometimes get merge requests on github still
11:01 huginn cait: The operation succeeded.
12:26 Joubu Hi #koha
12:47 edveal Hi #koha
12:50 barton morning edveal!
12:50 edveal morning barton
12:54 tcohen morning
12:58 edveal Morning tcohen
14:02 huginn New commit(s) kohagit: Bug 18581 - Add standard edit and delete buttons to suggestions list <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9917d9cad1d9eb7adf9cc40b55693e24dc3cf0e8> / Bug 18354: [QA Follow-up] Add a prefix for the itemtype class <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=51b7af9d9bee17c5fc6b6f2c2dfa27224b1da512> / Bug 18354 Adding item type attribute to cover image div <http://git.koha-commu
14:12 huginn New commit(s) kohagit: Bug 19080: Fix perlcritic in routing-lists.pl <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=01e02364c905048908391615828f5878c2c5aac9> / Bug 19080: Fix member vs borrowernumber in delmember <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2480474cdf8f27c4114ab404f4669f052e5a49c7> / Bug 19080: Handle non-existing patrons gratefully <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdi
14:52 huginn New commit(s) kohagit: Bug 18447 - QA Followup - fix opac usage <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=249e721ba4b5f60c1d6f4567efd71a4609e60a98> / Bug 18447 - Remove redundant line <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05a8a1c7b43c63d5a06ad5beb49b2f9b20254f68> / Bug 18447 - Add changes to opac <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4e852b9f69a06710e5b0c7e2a26011d8dacda
15:26 huginn New commit(s) kohagit: Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser... <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ea886885d0efa0200cfa166453a4495692afc4d4> / Bug 19126: Fix Members.t with IndependentBranches set <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=44a8fc5b9363eb27223f32e1150fb8fff6f55d08> / Bug 19130: (followup) Controller scripts should preserve behaviour <h
15:31 tcohen bbl
16:17 jenkins Project Koha_Master_D8 build #245: SUCCESS in 2 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master_D8/245/
16:18 jenkins * Jonathan Druart: Bug 18046: CAS logout infinite redirect
16:18 jenkins * Jonathan Druart: Bug 18817 Correct Manual URL
16:18 jenkins * Jonathan Druart: Bug 18817: Update links with anchor automatically
16:18 jenkins * Jonathan Druart: Bug 18817: Update links manually
16:18 jenkins * Jonathan Druart: Bug 19040: Refactor GetMarcBiblio parameters
16:18 jenkins * Jonathan Druart: Bug 19040: [QA Follow-up] Adjust embed_items parameter in showdiffmarc
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 critical, P5 - low, ---, chris, Pushed to Master , Problem with redirect on logout with CAS
16:18 jenkins * Jonathan Druart: Bug 19040: Update 2 occurrences of GetMarcBiblio in 22_to_30
16:18 jenkins * Jonathan Druart: Bug 19134: C4::SMS falils on long driver name
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 minor, P5 - low, ---, jonathan.druart, Pushed to Master , Update links in the help files for the new 17.11 manual
16:18 jenkins * Jonathan Druart: Bug 16892: Add automatic patron registration via OAuth2 login
16:18 jenkins * Jonathan Druart: Bug 16892: System Preferences
16:18 jenkins * Jonathan Druart: Bug 16892: Follow up with adding missing IGNORE
16:18 jenkins * Jonathan Druart: Bug 16892: Follow up use AddMember as per QA comment
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 enhancement, P5 - low, ---, mtompset, Pushed to Master , Change prototype of C4::Biblio::GetMarcBiblio
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 normal, P5 - low, ---, magnus, Pushed to Master , C4::SMS does not handle drivers with more than two names well
16:18 jenkins * Jonathan Druart: Bug 16892: Address error checking in comment #47
16:18 jenkins * Jonathan Druart: Bug 16892: DBRev 17.05.00.004
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 enhancement, P5 - low, ---, mtompset, Pushed to Master , Add automatic patron registration via OAuth2 login
16:18 jenkins * Jonathan Druart: Bug 17288 - Advanced Editor - Rancor - Helpers for 006 and 007 fields
16:18 jenkins * Jonathan Druart: Bug 17288: (follow-up) Fix marc21_field_007.xml
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 enhancement, P5 - low, ---, nick, Pushed to Master , Advanced Editor - Rancor - Helpers for 006 and 007 fields
16:18 jenkins * Jonathan Druart: Bug 17288 (QA Followup)
16:18 jenkins * Jonathan Druart: Bug 17288: (follow-up) Remove unneccessary Date() function
16:18 jenkins * Jonathan Druart: Bug 18354 Adding item type attribute to cover image div
16:18 jenkins * Jonathan Druart: Bug 18354: [QA Follow-up] Add a prefix for the itemtype class
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 enhancement, P5 - low, ---, michael, Pushed to Master , Adding item type attribute to cover image div
16:18 jenkins * Jonathan Druart: Bug 18581 - Add standard edit and delete buttons to suggestions list
16:18 jenkins * Jonathan Druart: Bug 19080: Handle non-existing patrons gratefully
16:18 jenkins * Jonathan Druart: Bug 19080: Fix member vs borrowernumber in delmember
16:18 jenkins * Jonathan Druart: Bug 19080: Fix perlcritic in routing-lists.pl
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 enhancement, P5 - low, ---, oleonard, Pushed to Master , Add standard edit and delete buttons to suggestions list
16:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080 major, P5 - low, ---, jonathan.druart, Pushed to Master , Handle non existing patrons
18:06 tcohen hi
18:06 wahanui hi, tcohen
18:09 CrispyBran Easy signoff - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490
18:09 huginn 04Bug 18490: enhancement, P5 - low, ---, cbrannon, Needs Signoff , Transfer message confusing, cancel button missing
18:18 jenkins Project Koha_Master_D8 build #246: SUCCESS in 2 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master_D8/246/
18:18 jenkins * Jonathan Druart: Bug 18447 - Datepicker only shows -10/+10 years
18:18 jenkins * Jonathan Druart: Bug 18447 - Add changes to opac
18:18 jenkins * Jonathan Druart: Bug 18447 - Remove redundant line
18:18 jenkins * Jonathan Druart: Bug 18447 - QA Followup - fix opac usage
18:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 normal, P5 - low, ---, nick, Pushed to Master , Datepicker only shows -10/+10 years for date of birth
18:18 jenkins * Jonathan Druart: Bug 19130: Remove ->search() overloading and adjust tests
18:18 jenkins * Jonathan Druart: Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t
18:18 jenkins * Jonathan Druart: Bug 19130: (followup) Add POD
18:18 jenkins * Jonathan Druart: Bug 19130: (followup) Controller scripts should preserve behaviour
18:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130 normal, P5 - low, ---, tomascohen, Pushed to Master , K::A::Booksellers->search broken for attribute 'name'
18:18 jenkins * Jonathan Druart: Bug 19126: Fix Members.t with IndependentBranches set
18:18 jenkins * Jonathan Druart: Bug 19118 - Due to wrong variable name passed vendor name is not coming
18:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 normal, P5 - low, ---, m.de.rooy, Pushed to Master , Fix Members.t with IndependentBranches set
18:18 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 minor, P5 - low, ---, amitddng135, Pushed to Master , Due to wrong variable name passed vendor name is not coming in browser title bar
18:19 CrispyBran khall - is there a guide on resolving patches that won't apply?
18:20 CrispyBran or anyone?
18:20 wahanui Anyone? Anyone? Bueller? Bueller?
18:22 tcohen CrispyBran: read this https://git-scm.com/book/en/v1/Git-Branching-Basic-Branching-and-Merging
18:22 tcohen in fact, the whole book is worth reading
18:22 tcohen :-D
18:24 * magnuse waves
18:25 tcohen hi cait magnuse
18:26 magnuse hiya tcohen
18:33 pastebot "CrispyBran" at 127.0.0.1 pasted "Not sure how to resolve" (35 lines) at http://paste.koha-community.org/617
18:54 Joubu CrispyBran: 18503 depends on 18490
18:54 Joubu ha sorry, you applied it before
18:57 Joubu you can checkout an older commit (when the patch applied), apply then rebase
18:58 Joubu or use apply --reject
20:59 Joubu tcohen: bug 19176
20:59 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 normal, P5 - low, ---, jonathan.druart, ASSIGNED , Dates comparison fails on slow server
21:00 Joubu patch attached
21:00 tcohen (y)
23:50 tcohen have a nice weekend!
23:55 Freddy_Enrique Hi world
23:55 Freddy_Enrique anyone here?