Time Nick Message 23:58 eythian I do my best 23:53 wizzyrea you are too sensible. 23:51 eythian wizzyrea: put them into a note and add thing when you notice them. Then when you have a few, make a page. 23:48 wizzyrea cuz I"m drawing a blank and I really will write this for the website 23:48 wizzyrea obvs start with "it does backups for you" 23:48 huginn eythian: The operation succeeded. 23:48 eythian @later tell marcelr ook, ga je naar de Perl conf? 23:48 wizzyrea help me out and shout out what they are 23:45 eythian Good idea :) 23:45 wizzyrea feel like I need a 1 pager on "awesome things Koha does that you don't probably know about because reasons" 23:45 huginn eythian: The operation succeeded. 23:45 eythian @later tell marcelr https://sha2017.org/ there are still tickets available should you have nothing better to do for a few days. 23:44 wizzyrea (I wondered if they didn't know Koha did this excellent service for them by default) 23:44 wizzyrea bit worried that by now it's too late. 23:43 wizzyrea that's what I just mentioned to them :) 23:43 eythian How did they not have a backup? They're automatic daily. 23:42 wizzyrea <evil grin> 23:42 wizzyrea it was L2 23:42 ibeardslee noooooo 23:39 * wizzyrea dwells, goes to a dark place 23:31 mtompset Ha ha, ibeardslee :) 23:28 ibeardslee just don't dwell to long on the Library of Alexandria 23:24 mtompset Yes, data loss is something to mourn. :( 23:23 mtompset Oh. 23:23 wizzyrea the person on the list who didn't have a backup and lost all of their marcxml 23:22 mtompset What were you responding to, wizzyrea? 23:22 mtompset ? 23:18 wizzyrea I feel really sad for that person what a crap situation. 23:17 wizzyrea :) 23:17 wizzyrea hmm. 23:15 mtompset Greetings, wizzyrea 23:15 mtompset wizzyrea: You forgot to say, "For the honour of Grayskull!" ;) 21:28 rangi :) 21:26 mtompset But supper first... hard to program on an empty stomach. 21:26 mtompset I think I've seen some SQLite mocks in our tests... 21:24 mtompset Just needed to trigger my change case, and I have a test that does that now, but now I should mock the DB. 21:23 rangi but also hard to do 21:23 rangi which would be good, cos then we would test the installer every big run too 21:22 rangi a known db 21:22 rangi we really need the test suite to create, populate, test, and tear down 21:21 rangi basically for it (and quite a few others) 21:21 rangi (without iterating over the whole db) 21:21 rangi if you know what I mean 21:20 rangi mocking doesnt really test anything tho .. I'm not sure you could write a test that actually tested 21:20 * LeeJ waves bye to everyone take care! 21:20 mtompset First try to get to it do my entire puny DB... then work on mocking. 21:19 rangi unless you want to fetch every biblio in your database 21:19 rangi ie mock it 21:19 rangi you'd have to fake that anway 21:19 mtompset sorry I wasn't specific enough. 21:19 mtompset Not for the iterator. 21:19 rangi t/db_dependent/Koha/BiblioUtils.t 21:18 rangi mtompset: umm there is a test 21:13 cait bbiab 21:13 * LeeJ waves back to cait 21:13 * cait waves at LeeJ 21:12 mtompset That will be appreciated, if I can get a test written. 21:12 LeeJ mtompset: my deadline for my Koha-related work project is tomorrow afternoon so I should be able to get back to community dev work on Thursday so I can help with whatever needs work for what it's worth 21:11 mtompset I was so hoping to have this finished and signed off. 21:11 cait +1 21:11 mtompset again. 21:11 mtompset Nice way to think of it, but now 14385 is delayed. :( 21:10 wizzyrea well you can't really get mad about the past, you can only make the future better. 21:08 mtompset (within the last year) 21:08 mtompset Just wish the test for it had already been written before it was pushed to master recently. 21:08 rangi </diatribe> 21:08 * LeeJ cheers rangi on 21:07 rangi (like we are doign with the overdrive search) 21:07 rangi which allows us to have mixed formats in the index 21:07 rangi the idea being, you just get an iterator, of whatever format your records are under the hood, and you dont have to actually care 21:06 rangi (Which you can call with Koha::MetadataIterator) 21:05 rangi or when indexing your db 21:05 rangi which is super handy when building a results screen 21:04 rangi the main useful thing of it, is the iterator 21:03 wahanui something is fishy 21:03 rangi or something 21:03 rangi is it gets shifted to Koha::Metadata::MARC::Biblio 21:03 rangi i think what needs to happen with that module 21:01 rangi luckily there are less and less each year 21:01 rangi it's what all the academy students start out doing 21:01 rangi s/tt/t/ 21:00 rangi there are litterally tens of thousands of tests people have written for code they never wrote 21:00 mtompset That's good to know. 21:00 mtompset We've greatly improved then. 21:00 rangi there was about 30% coverage in 2010 20:59 rangi dude thats what people have been doing for years 20:59 rangi ok(my $utils = Koha::BiblioUtils->new()); 20:59 mtompset write one for code I didn't write? 20:59 rangi same way as you trigger everything else? 20:58 cait sorry, tired brain 20:58 cait HI BAG :) 20:58 mtompset So, anyone know how to trigger Koha::BiblioUtils in a test? 20:58 rangi morning 20:55 mtompset Still love you though, bag. :) 20:55 bag ah you are - HI CAIT 20:55 bag cait you around? 20:55 bag hi there mtompset 20:55 bag hehe 20:55 bag hey!! 20:53 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 enhancement, P5 - low, ---, robin, Pushed to Master , Elasticsearch support for Koha 20:53 mtompset bug 12478 20:53 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479 trivial, P5 - low, ---, dcook, CLOSED FIXED, Update mailmap for master 20:53 mtompset bug 12479 20:52 wahanui regexes are AWESOME 20:52 mtompset and pianohacker 20:52 mtompset and tcohen 20:52 wahanui khall_away is, like, familiar with DBIx::Class too, so he probably would know what to do 20:52 mtompset and khall_away 20:52 mtompset Perhaps I'll blame bag :P 20:50 mtompset Too tired to type properly. :P 20:49 mtompset ^now exist&no exist^ 20:49 mtompset So now I, who have never used ES, have to figure that out just to get my code to meet proper standards. 20:49 mtompset and those use it, but there's now existing test. 20:48 mtompset need to refactor the parameteres for EmbedItemsInMarcBiblio 20:48 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, ASSIGNED , Extend OpacHiddenItems to allow specifying exempt borrower categories 20:48 mtompset And now I, who want to fix bug 14385.... 20:48 mtompset And yet, it is in the code-base. 20:48 mtompset And yet, there isn't one. 20:48 mtompset The standard has been for the longest time that if you have something in the C4 or Koha directories, you must provide a test. 20:48 LeeJ mtompset: I understand your point 20:47 mtompset https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required_.28updated_Apr_26.2C_2017.29 20:46 mtompset LeeJ: You missed my point of frustration. 19:35 LeeJ mtompset: https://github.com/Koha-Community/Koha/search?utf8=%E2%9C%93&q=BiblioUtils&type= only three results for BiblioUtils...the module itself, BiblioUtils::Iterator and the ES rebuild script 19:34 LeeJ mtompset: misc/search_tools/rebuild_elastic_search.pl is the only thing that uses it 19:33 mtompset The point is WHERE IS A TEST TO TRIGGER IT. 19:33 * mtompset grumbles. 19:33 LeeJ mtompset: you're correct about ES 19:33 LeeJ mtompset: are you asking what uses BiblioUtils itself? 19:31 mtompset Because it seems to be used by ElasticSearch stuff, but THERE'S NO TEST! 19:31 LeeJ hmm... 19:31 * LeeJ praises Koha for the output_pref DateUtils method 19:31 mtompset What uses it? 19:31 mtompset Call tracing. 19:31 mtompset No, that's not the problem. 19:30 LeeJ mtompset: I could after reading the perldoc :P 19:23 mtompset Anyone here know about Koha::BiblioUtils? 19:01 mtompset Anyways... someone else can teach wahanui about EmbedItemsInMarcBiblio 19:00 mtompset EmbedItemsInMarcBiblio? 19:00 mtompset EmbedItemsInMarcBiblio <reply> is a pain 18:59 wahanui mtompset: I forgot embeditemsinmarcbiblio 18:59 mtompset wahanui: forget EmbedItemsInMarcBiblio 18:59 wahanui ...but wahanui is a bot|a repository of important and useful and accurate information or at least partially slow.|a little bit creepy.|right sometimes|a strange duck|a bot...|rumoured to be a sentient bot with sass|<reply> an extremely creepy stalker bot.... you have been warned|a parrot|<reply> wrong|<reply> on fire|<reply> gaining knowledge faster than sustainable|canadian|google|<reply> wahanui couldn't be bothered to show up|laser kiwi of the bo 18:59 mtompset wahanui: You are wrong now. 18:58 wahanui well, EmbedItemsInMarcBiblio is only called (outside of C4::Biblio) in three places: tools/export.pl, rebuild_zebra.pl, and catalouging/additem.pl 18:58 mtompset EmbedItemsInMarcBiblio 18:58 mtompset 14385... found another problem. :( 18:58 LeeJ hi mtompset 18:58 mtompset Greetings, LeeJ 18:57 LeeJ hi #koha 18:56 * LeeJ waves 18:27 * mtompset grumbles, "I found a bug in the code I was working on. I hate finding more threads to tie up." 15:48 marcelr bye #koha 15:11 oleonard Joubu++ # hard-working RM 15:03 oleonard You know you've been getting behind when bugs have gone from "New" to "Pushed to stable" before you even read the Bugzilla emails. 14:55 oleonard Trying to make up for my long period of inactivity. 14:47 cait oleonard++ 14:27 oleonard Thanks 14:26 Joubu oleonard: cd misc/translator; perl translate create aa-AA 14:22 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 trivial, P5 - low, ---, veron, Needs Signoff , Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) 14:22 oleonard Bug 18779 suggests testing by "creating a new language 'aa-AA'". How do you do that? 14:19 cait Joubu++ # making a too hot day better :) 13:28 Joubu It would be good the have a wiki page with different config 13:25 oleonard It'd be cool if someone could answer this: https://lists.katipo.co.nz/pipermail/koha/2017-July/048525.html 13:12 Dyrcona net split? 13:12 Dyrcona heh. 13:11 oleonard It's like a cleansing thunderstorm. 12:56 tcohen hi marcelr 12:56 marcelr hi tcohen 12:34 marcelr o/ 12:34 Joubu hi marcelr 12:34 marcelr hi #koha 12:34 Joubu I would like a quick review before I send an email to the lists 12:33 Joubu I have added a "Are your data corrupted?" and "How Koha will behave?" section to https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix 12:17 * oleonard didn't even know the RenewalSendNotice pref existed 12:10 Joubu but I do not think there were more info 12:10 Joubu He sent a message on the list few days ago 12:07 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 minor, P5 - low, ---, oleonard, NEW , Book renewed online does not show the time of renewal 12:07 * oleonard doesn't understand Bug 18957 11:27 Joubu thanks wahanui 11:26 wahanui hi dear loon 11:26 Joubu hi oleonard 11:19 oleonard Hey. 11:14 huginn Joubu: The operation succeeded. 11:14 Joubu @later tell wizzyrea I do not recreate the DB password rejection on master. Did you open a bug report? 07:17 wahanui niihau, gaetan_B 07:17 gaetan_B hello 07:05 AndrewIsh Hi alex_a 06:58 cait bonjour alex_a 06:57 alex_a hello cait AndrewIsh 06:42 alex_a hallo magnuse 06:41 magnuse hola alex_a 06:34 alex_a bonjour 06:09 * magnuse waves 02:24 mtompset Have a great day, #koha wizzyrea 02:19 huginn wizzyrea: The operation succeeded. 02:19 wizzyrea @later tell joubu yep, I'm still seeing that even in 16.11 versions. 02:14 mtompset Not so... 02:14 mtompset No so great for running the code smoothly. :) 02:14 mtompset They are great for checking if I triggered everything. 02:13 wizzyrea hehe 02:12 mtompset *whew* No STDERRs or dies. :) 02:02 mtompset Hopefully I didn't leave any die's in there. ;) 02:01 mtompset It triggers every piece of code that was changed. 02:01 mtompset And there is a NICE full test plan. :) 01:57 wizzyrea ah neat 01:52 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 enhancement, P5 - low, ---, mtompset, Needs Signoff , Extend OpacHiddenItems to allow specifying exempt borrower categories 01:52 mtompset bug 14385 is ready for sign off. I signed off your parts. :) 01:52 mtompset Any Catalyst folks around? 01:51 huginn mtompset: aleisha was last seen in #koha 2 weeks, 0 days, 4 hours, 2 minutes, and 20 seconds ago: <aleisha> same and same 01:51 mtompset @seen aleisha 01:51 * mtompset laughs. 01:51 huginn mtompset: wizzyrea was last seen in #koha 21 hours, 51 minutes, and 16 seconds ago: <wizzyrea> \o/ 01:51 mtompset @seen wizzyrea 01:51 mtompset Greetings, #koha.