Time Nick Message
00:21 wizzyrea i just did a fresh install of Koha from 16.11.x packages, and it didn't seem to install the ligcgi-compile-perl or libcgi-emulate-psgi-perl packages as dependencies
00:22 wizzyrea this was on a debian 8
00:22 wizzyrea is that a known thing?
00:22 wizzyrea I guess I should google the question.
06:03 * magnuse waves
06:05 * cait wave
06:05 cait s
06:10 alexbuckley_ hi everyone
06:14 magnuse hiya cait and alexbuckley
06:25 magnuse bonjour BüchereiKlara und fridolin
06:27 LibraryClaire hi magnuse
06:27 wahanui kamelåså
06:27 LibraryClaire and #koha
06:28 magnuse was ist los?
06:29 LibraryClaire recovering from bank holiday weekend ;)
06:42 fridolin wahanui: hie there
06:42 wahanui fridolin: huh?
06:49 alex_a bonjour
07:20 gaetan_B hello
07:25 reiveune hello
07:25 wahanui que tal, reiveune
07:35 mtj https://jenkins.koha-community.org/computer/Debian_8/
07:35 mtj ^ hey wizzyrea, rangi, alexbuckley_, can any of you bounce the catalyst jenkins node?
07:44 magnuse bonjour sophie_m and nlegrand
07:45 sophie_m hi magnuse and #koha
08:47 oha o/
08:48 atheia o/ :-)
11:47 rsantellan good morning #koha
11:49 mveron good afternoon #koha :-)
11:50 mveron (Koha never sleeps)
11:55 oleonard Hi all
11:57 magnuse hiya o'leopard!
11:57 alexbuckley_ hi rsantellan, mveron and oleonard
11:58 mveron @wunder Allschwil
11:58 huginn_ mveron: Error: No such location could be found.
11:58 mveron @wunder Basel
11:59 huginn_ mveron: Error: No such location could be found.
11:59 * mveron looks out of the window
12:01 LibraryClaire @wunder konstanz
12:01 huginn_ LibraryClaire: Error: No such location could be found.
12:01 * LibraryClaire cries
12:02 eythian I wonder who owns huginn_
12:02 magnuse eythian: gmcharlt, according to https://wiki.koha-community.org/wiki/IRC_Regulars
12:03 eythian gmcharlt: you need to tell huginn that it's OK to talk about the weather again.
12:26 marcelr hi #koha
12:27 magnuse hiya marcelr and nengard
12:27 marcelr o/
12:28 nengard Hiya magnuse
12:40 * magnuse looks up to talljoy
12:41 magnuse (nah, not really ;-)
12:41 talljoy ha! morning!
12:41 magnuse bonjour!
12:41 * talljoy is only 1.8 meters.
12:41 oleonard Yeah, tallmagnuse doesn't need to look up
12:41 talljoy i am the short one in my family. i spend most my time looking up
12:42 * magnuse is 195cm
12:43 magnuse 6.4 feet according to teh googlz
13:09 tcohen morning
13:25 tcohen @wunder cordoba, argentina
13:25 huginn_ tcohen: Error: No such location could be found.
13:26 cait good morning tcohen
14:03 ashimema tcohen, you didn't fancy taking a look at bug 18322 did you? Should be a trivial signoff I would have thought.
14:03 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Add facets for ccode to zebra
14:57 mveron Does anybody have an idea how to fix Bug 18518 ?
14:57 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 enhancement, P5 - low, ---, oleonard, Needs Signoff , The staff interface "blink" for different actions after upgrading to Firefox 53
14:57 oleonard mveron: I plan to look but I haven't had a chance yet
14:58 mveron OK, great.
15:34 oleonard Anyone know offhand if the "| $Price" template filter only uses CurrencyFormat? Or should it show currency symbols too?
15:34 * oleonard lazywebs
15:43 Joubu oleonard: both
15:43 Joubu oleonard: logic is in Koha::Number::Price->_format_params
15:43 oleonard [% variable_name | $Price with_symbol => 1 %] ?
15:44 Joubu ha indeed, I forgot this with_symbol flag
15:49 oleonard the with_symbol flag isn't used by the template plugin?
15:50 Joubu nope
15:50 Joubu it's not used anywhere
15:51 Joubu There are several bug reports about price display
15:51 Joubu Everything should be rethink
15:51 Joubu and format details should be moved to the currency table
16:00 cait maybe we should not overcomplicate it
16:00 cait i tihnk the discussion might never end
16:01 cait or i fear it
16:13 Joubu it's not about complicate things but make them more flexible ;)
16:13 Joubu mtj: around?
16:16 Joubu @later tell mtj 18124 is in 16.05.x and breaks members/moremember.pl
16:16 huginn_ Joubu: The operation succeeded.
16:22 oleonard I would have failed QA the patron clubs patches for adding new instances of "onclick." We can do better than that.
16:30 oleonard having documentation would have been nice too
16:36 cait oleonard: you chould comment
17:47 cait thx oleonard++
17:47 CrispyBran kidclamp: what does it mean when you check something in and it says the item is consigned?
17:51 CrispyBran Or can anyone else answer? ^
17:51 kidclamp screenshot?
17:51 wahanui it has been said that screenshot is ineresting, i have no idea how this can happen
17:52 kidclamp wahanui forget screenshot
17:52 wahanui kidclamp: I forgot screenshot
17:52 kidclamp wahanui botsnack
17:52 wahanui thanks kidclamp :)
17:52 oleonard returns.tt line 442: <h3 class="audio-alert-action">Item consigned:</h3>
17:52 CrispyBran I can't. I'm trying to make it happen.
17:53 CrispyBran Yes. I'm looking at that. Trying to figure out the condition that brings that up.
17:53 oleonard CrispyBran: I think it doesn't happen. At least I've never seen it.
18:04 CrispyBran Thanks for the feedback. :)
18:12 cait what does sonsigned mean?
18:14 * cait waves at talljoy_afk and rocio_pregolive
18:16 cait if someone has time and a bit of acq knowledge
18:16 cait it would be cool to get a sign off on bug 11122
18:17 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 minor, P5 - low, ---, fridolin.somers, Needs Signoff , Fix display of publication year/copyrightdate and publishercode on various pages in acquisitions
20:29 kidclamp Joubu++
20:56 CrispyBran kidclamp: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355
20:56 huginn_ 04Bug 18355: enhancement, P5 - low, ---, cbrannon, Failed QA , Permanent location should show with cart location
20:56 CrispyBran kidclamp: sorry, wrong link. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503
20:56 huginn_ 04Bug 18503: normal, P5 - low, ---, cbrannon, Needs Signoff , Confusing hold and transfer dialog
21:35 Joubu alexbuckley_: around?
21:38 alexbuckley_ yup
21:39 Joubu The 4 bug reports have different problems:
21:40 Joubu bug 18291: it's a caching problematic. When we edit sysprefs, we would like to display the value from the DB
21:40 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 enhancement, P5 - low, ---, alexbuckley, In Discussion , Remove SQL from preferences.pl administrative script
21:40 Joubu the cache and the DB must be in sync, but we never know
21:40 Joubu So the sql query makes sense
21:41 Joubu bug 18299: Here it's different, the script does not seem very useful (I was not aware of it!). It has not been updated for a while and what it does can be done easily on another way
21:41 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 enhancement, P5 - low, ---, alexbuckley, Signed Off , Removal of SQL queries from admin/env_tz_test.pl script into a perl module
21:41 Joubu I'd suggest to simply remove the script (considering it as useless) instead of adding more code to the code
21:41 Joubu base
21:42 Joubu we do not want to maintain unused code, right? :)
21:42 alexbuckley_ agreed
21:42 alexbuckley_ I can remove that file as a patch for bug 18299?
21:43 cait hm
21:43 Joubu yes, just rename the bug report and delete the file
21:43 cait could someone quickly try adding an ordre line from an accepted suggestion?
21:43 cait Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
21:43 Joubu alexbuckley_: with bug 17944 and 18247, there is a problem of understanding with how our Koha::* modules work
21:43 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 minor, P5 - low, ---, alexbuckley, BLOCKED , Remove the sql code from itemtypes.pl administrative perl script
21:43 Joubu They should not contain SQL queries either, but use Koha::Objects CRUD methods instead
21:44 alexbuckley_ just like you suggested with 18291
21:44 Joubu You can take a look at Koha::Patron[s] and Koha::Virtualshel[f|ves] to understand how you can request the DB without writing any SQL
21:45 Joubu yep
21:45 Joubu alexbuckley_: I would suggest you to start with 17944 first, it looks easier than 18247
21:46 alexbuckley_ Will do, thanks :)
21:46 alexbuckley_ and for future reference could smart-rules.pl which I have been working through also use the Koha::Objects as that contains a lot of sql in it
21:47 Joubu alexbuckley_: ok you did some adjustements for itemtypes.pl, just looking
21:48 Joubu alexbuckley_: Koha::ItemType::is_used is trivial (and a bit wrong with the logic). The call could be Koha::ItemType->new($params)->is_used
21:49 Joubu but actually you can just call Koha::ItemTypes->find( $id ) from the pl, if it return something it means that the itemtype already exists
21:49 Joubu no need to add a new method
21:49 Joubu nope this is wrong, but you can:
21:50 Joubu ok I will comment on the bug for this one
21:50 Joubu alexbuckley_: what is the bug # for smart-rules.pl?
21:51 alexbuckley_ 17954
21:54 alexbuckley_ thank you for your help here Joubu!
22:05 Joubu cait: looks ok for me
22:05 cait hm strange
22:05 Joubu which step?
22:05 cait i will have to try with a fresh db then
22:05 cait create basket - create from suggestion - click on order
22:08 Joubu cait: I guess item-level_itypes is set to biblio?
22:08 cait hah!
22:08 cait you are right, from testing yesterday
22:08 cait it works when i set it back to item level
22:09 Joubu could you open a bug report and link it with bug 14828?
22:09 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Move the item types related code to Koha::ItemTypes
22:09 cait i filed one for the issue already
22:09 cait i will try to rewriteit a big
22:09 cait bit
22:10 Joubu cait: bug number?
22:10 cait bug 18525
22:10 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 major, P5 - low, ---, koha-bugs, NEW , Can't create order line from accepted suggestion
22:11 cait depends or blocks?
22:14 CrispyBran Can you use else with a trailing conditional statement (i.e. my $a = $b if ( CONDITION ) )?
22:15 Joubu my $a = cond ? $a : $b
22:15 cait else { ... if () }?
22:15 Joubu well, my $a = cond ? $b : $c
22:15 cait ah
22:16 CrispyBran thank you.
22:25 alexbuckley_ I have to go off to class now I've done 18299 and started 17944 and will finish the others after classes today. thanks for the help Joubu and cait seeya later
22:29 cait have fun at class :)
22:58 mtj hiya cait, Joubu... is there a fix for the 18124 bug in members/moremember.pl ?
22:58 mtj Joubu: thanks for the heads up ^
23:02 mtj haay, can anyone please kick the deb8 jenkins node -> https://jenkins.koha-community.org/computer/Debian_8/
23:29 mtj Joubu: would a workaround for 18124 be to revert the just patch (3) only?
23:29 mtj Joubu: would a workaround for 18124 be to revert just patch number 3?
23:32 mtj ..that would allow sec-bug 18019 to be applied too
23:32 huginn_ 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18019 is not accessible.