IRC Logs

Time Nick Message
23:25 tcohen otherwise QA people can get overwhelmed
23:25 tcohen baby steps
23:25 tcohen but don' tdo bit stuff all together
23:24 tcohen refactoring old pieces of code seems fun at some point
23:24 CrispyBran Thanks. I think I may do that.
23:24 tcohen and probablly get the feedback you want
23:24 tcohen attention
23:24 tcohen that way you will pick interested parties
23:24 tcohen CrispyBran: the best approach is (usually) to file a bug, and attach a proposal
23:23 CrispyBran I wish there was something to refer to as to why it would have been written this way. Oh well.
23:21 CrispyBran I'm tempted to pull the transfer logic out of there and have the hold logic just handle it.
23:20 tcohen CrispyBran: i'm not sure
23:19 CrispyBran Seems to me that if an item has a hold, it should go to where the hold is. Unless some libraries require items make it home before filling a hold. But then why wouldn't that be done through settings rather than facing two choices?
23:17 CrispyBran This particular dialog has mystified me since we joined Koha.
23:16 CrispyBran I'm looking at returns.tt. Paricularly the return2 section. Is there a scenario you can think of where an item needs to show hold buttons and transfer buttons at the same time?
23:15 tcohen shoot
23:15 tcohen hi CrispyBran
23:15 CrispyBran tcohen, do you have time for a quick question
23:05 CrispyBran cait: do you have time for a quick question?
21:54 mtompset Have a great day, #koha
20:04 huginn` Joubu: The operation succeeded.
20:04 Joubu @later tell khall bug 18459 is marked as pushed but is not actually
19:57 * magnuse sends a snack of his own choice to drojf
19:35 huginn` New commit(s) kohagit: Bug 18066: Remove warnings from translate script <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bcc04652762ff097623630432946ca9203f7519f>
18:59 oleonard Bye all
18:45 mtompset "Not filtered by..."
18:45 wahanui i guess there is one... but i don't know it
18:45 mtompset oleonard: There..
18:42 oleonard Thanks for checking Joubu
18:42 Joubu oleonard: works for me on master
18:37 * magnuse wanders off in search of edibles
18:30 mtompset Okay... I'll look at those 5 lines.
18:29 oleonard For <select>s which are optional, I'd consider also text like "None" if that better expresses the value which is being submitted.
18:29 mtompset So, you recommend putting a "Choose a {foo}" type message?
18:28 mtompset for some definitions of broken. :P
18:28 oleonard It's not broken at all. It just doesn't pass the validator.
18:28 mtompset Exactly, effectively as broken as it already is. ;)
18:27 oleonard The validator wants form controls to be clear and accessible. Adding an empty label attribute isn't really accomplishing anything.
18:27 mtompset But I had considered that too. Is that your preference?
18:26 mtompset Didn't want to force more translation work on people.
18:26 oleonard It makes more sense to add a label to the empty <option>. <option value="">Choose a day</option> Something like that.
18:25 mtompset I can do that.
18:25 mtompset So, you wish 5 errors on the page?
18:25 mtompset I like quiet validator.
18:25 mtompset Yes, but label="" and label=" " make me want to cry badly.
18:24 oleonard I don't think it's worth it to do that just to quiet the validator's complaints
18:24 oleonard 'label="&nbsp;"' makes me want to cry badly
18:24 mtompset Yes. Did 3311 make you want to cry that badly?
18:23 oleonard mtompset still here?
18:19 oleonard After using the OPAC's password recovery process I can log in to the staff client with my new password but not the OPAC.
17:46 huginn` tcohen: Error: No such location could be found.
17:46 tcohen @wunder cordoba, argentina
17:46 mtompset I guess it is broken.
17:45 huginn` mtompset: Error: No such location could be found.
17:45 mtompset @wunder 90210
17:45 huginn` mtompset: Error: No such location could be found.
17:45 mtompset @wunder toronto, ontario
17:45 huginn` mtompset: Error: No such location could be found.
17:45 mtompset @wunder toronto
17:45 huginn` mtompset: Error: No such location could be found.
17:45 mtompset @wunder l7e 5y5
17:45 huginn` mtompset: Error: No such location could be found.
17:45 mtompset @wunder l7e5y5
17:42 mtompset The hex goes that they won't win the Stanley Cup until the money is repaid.
17:42 mtompset It's called the curse of Harold Ballard, because he was the team owner who had issues with a player who supposedly placed a hex on the team, because they refused to pay him some amount of money.
17:41 magnuse and for the lore, i guess :-)
17:41 magnuse ...for the language
17:40 magnuse yay
17:40 mtompset magnuse: It's Canadian folklore, particularly amongst those who are Toronto Maple Leaf fans (a hockey team), that winter will not end until they are eliminated from the playoffs, and this curse will last until they win the Stanley Cup again.
17:39 mtompset https://esolangs.org/wiki/Gibberish_(programming_language)
17:38 magnuse did anyone ever create a programming language and name it gibberish?
17:38 * magnuse suspects mtompset of talking plain gibberish
17:37 mtompset The curse of Harold Ballard is at rest for another year.
17:37 mtompset impossible.
17:37 mtompset magnuse: That's implossible. The Toronto Maple Leafs are out of the playoffs.
17:37 magnuse and the planes are delayed
17:37 mtompset I'd appreciate your feedback on the ugliness.
17:37 magnuse well, it's snowing, if anyone wanna know
17:37 huginn` magnuse: Error: No such location could be found.
17:37 magnuse @wunder OSL
17:36 * magnuse waves from OSL
17:36 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 normal, P5 - low, ---, mtompset, Needs Signoff , Statistical reports should error if row and column aren't selected
17:36 mtompset oleonard: I have an ugly, but error free HTML patch up for bug 3311.
17:35 huginn` New commit(s) kohagit: Bug 18452: Correcting 'url' to say 'URL' in catalog detail <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=82943de12ca5170b9504044c20462542ae0e5397> / Bug 15815: Reword confirm message when removing patrons from card batch <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4ac0aab9bb8418a355e1f692e6b505500c96e0dd> / Bug 18466: article requests box outline in opac <http://git.koha-community.or
17:23 huginn` New commit(s) kohagit: Bug 15702: Recommended Counter-patch <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7fd248f3e9c80b36fb451eb90d2c34242c0cbb61> / Bug 15702: Add test cases for modified code <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=31378adbe1add83afd2ac77520a295c18ba70b72> / Bug 18457: Add tests <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=41669b45a808550088146380d534e4f3629590d9>
17:18 CrispyBran Okay. Thanks for the feedback. :)
17:18 oleonard I guess "transfer" is more consistent with existing terminology
17:16 CrispyBran I think both changes would make it a lot more obvious. Which message do you prefer? Yours or mine?
17:15 oleonard I think that would be useful
17:15 CrispyBran It doesn't show the cancel when the transfer is first triggered.
17:15 CrispyBran And last quesion. Since the transfer is already in motion, shouldn't the Cancel Transfer button ALWAY show?
17:15 oleonard That makes sense to me. Or "Item is now in transit to XYZ"
17:13 CrispyBran Perhaps the message should read "Transferring item to: XYZ"?
17:13 CrispyBran Do you think it would be better to have the message indicate that the item is already triggered for transfer?
17:12 CrispyBran So, when you check in an item that belongs to another library, I notice that it states:"Please return item to: XYZ" and then shows a button to print slip. Our library always prints a slip, but apparently this confused a library that doesn't. It appears that the transfer is set in motion upon check in, rather than having to "confirm" like you do with a hold.
17:09 oleonard Sure CrispyBran
17:08 CrispyBran oleonard, do you have a moment for me to get your opinion on some workflow?
16:42 huginn` mtompset: oleonard was last seen in #koha 6 minutes and 14 seconds ago: <oleonard> restart_all
16:42 mtompset @seen oleonard
16:41 mtompset Greetings, #koha.
16:38 CrispyBran Wait....I think I stumbled upon it
16:37 CrispyBran How about if I just wanted to look something up at http://git.koha-community.org/gitweb/?p=koha.git;a=tree?
16:35 Joubu and you will certainly need to recreate the DB
16:35 oleonard restart_all
16:35 Joubu and restart memcached + plack
16:35 Joubu git checkout -b 3.22.x origin/3.22.x
16:35 oleonard You don't need to do that as part of a specific branch, but you can.
16:34 CrispyBran Cool. Thanks. Do I do that from anywhere or within a branch?
16:33 oleonard git checkout origin/3.22.x
16:33 oleonard CrispyBran: You use git to check out a previous version
16:33 CrispyBran Or oleonard^ ?
16:32 CrispyBran tcohen: is there a way to look at previous versions of Koha in the kohadevbox?
16:10 * kidclamp_lunch realizes context is damning, is going to run, not drink
16:08 kidclamp mmm...pivo
16:07 Joubu (be care, pints cost 1â‚¬ in Prague)
16:07 oleonard cait: What is mean is making the rest of the world learn English.
16:06 * oleonard packs
16:06 oleonard Deal!
16:06 kidclamp I'll move to Prague if you will
16:06 oleonard :D
16:06 kidclamp oleonard and I should get together and work on our czech
16:05 cait nah, that woudl be mean
16:05 * cait encourages kidclamp to learn German :P
16:04 * kidclamp is always unclear on translation stuff
16:03 cait and end with one string... with both sentences, but it's a bit messier
16:03 oleonard right, of course.
16:03 cait you probably could also have the dievs outside
16:03 oleonard Okay, thanks for checking. I wasn't sure if my memory of best practices was up to date.
16:03 cait doesn't work when your language requires a different order of words
16:02 cait cheating with sentences like that is not good
16:02 cait oleonard: yours looks better
16:01 cait if the page opens, i am trying :)
16:01 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 minor, P5 - low, ---, nick, Failed QA , Fix untranslatable string from Bug 18264
16:01 oleonard Could you check to see whether I've got correct translation advice on Bug 18367?
16:00 cait waht's up?
16:00 cait on a train :)
16:00 oleonard Sounds right wahanui
16:00 wahanui i heard cait was the best friend you could ever have.
16:00 oleonard cait?
15:57 oleonard Thanks Joubu
15:56 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 enhancement, P5 - low, ---, m.de.rooy, RESOLVED FIXED, More flexible paths in debian scripts (for dev installs)
15:56 Joubu if you want it in old versions, comment on bug 16733 (which blocks16749)
15:55 Joubu but it should work with koha-translate in master (only)
15:55 Joubu if you want to be sure
15:55 Joubu cd misc/translate; perl translate LANG update
15:53 oleonard Is there a devbox-ish way to run 'translate update' ? Or should it work correctly from koha-shell?
15:49 reiveune bye
15:26 oleonard ashimema: Your Sandbox 0 OPAC seems to be broken. No CSS, no JS.
13:53 huginn` New commit(s) kohagit: Bug 18409: Make the controller for holds use Koha::Holds <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=694c09aa873973c4f55b5d90948b1027adc0f1c1>
13:52 Joubu I am not French, cannot vote
13:49 francharb nope. Haven't been able to register in time. :(
13:49 oleonard francharb and Joubu, did you get to vote in the election back in your home country?
13:47 francharb Hi oleonard !
13:44 oleonard Hi francharb
13:37 kidclamp and both are 17140
13:35 Joubu tcohen, ashimema: it is 18442!
13:35 Joubu tcohen, ashimema: it is 18442?
13:35 kidclamp yes
13:34 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18481 normal, P5 - low, ---, koha-bugs, NEW , Unable to pay full fine amount.
13:34 Joubu kidclamp: dup of bug 18481?
13:34 kidclamp joubu when you have a moment for thought take a glance at 18487?
13:32 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18842 could not be retrieved: InvalidBugId
13:32 Joubu tcohen, ashimema: could you take a look at bug 18842 please?
12:50 tcohen aynchronous answers
12:49 jcamins oleonard: heh. I like it.
12:41 tcohen LOL
12:37 eythian haha
12:36 oleonard I like this sign from one of the Marches for Science over the weekend: https://cnet2.cbsistatic.com/img/Dm9bkuxnTgmOo2TBKDiwF770uJ8=/1170x0/2017/04/23/b65ff5de-8b31-4a4a-9b1a-72a917731177/20170422-march-for-science-san-jose-26.jpg
12:29 tcohen morning
12:28 edveal Happy Monday
12:07 kidclamp thanks oleonard
11:45 wahanui hi olÃ© onard
11:45 josef_moravec hi oleonard
11:39 oleonard Hi all
10:31 LEJEUNE_FLORIAN has somebody an issue with the creation of copies in the version 16.11 ?
08:59 nlegrand bonjour
08:55 huginn` ashimema: The operation succeeded.
08:55 ashimema @later tell khall do you still use your command line patron import tool?
07:43 * mveron has a meeting
07:41 gaetan_B hello
06:45 * mveron waves
06:44 alex_a bonjour
06:40 LibraryClaire hi #koha
06:40 reiveune hello
06:40 fridolin hie tehre
05:56 josef_moravec good morning #Koha ;)
05:56 oha o/
05:42 mveron alexbuckley: I hope I can test them this morning.
05:12 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18462 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Implemented bootstrap styling on the web installer and onboarding tool
05:12 alexbuckley I have also fixed up those sql removal bugs that wouldn't apply successfully for you: bugs 18212, 18247. And I have finished integrating the improved styling of 17942 with the onboarding tool so bug 18462 is ready for signoff
05:10 mveron :-)
05:09 alexbuckley no problem mveron
05:06 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 trivial, P5 - low, ---, veron, Signed Off , Popup with searches: results hidden by language menu in footer
05:06 mveron alexbuckley++ for signing off Bug 13835
05:04 mveron Good morning / daytime #koha