Time Nick Message
03:03 mtj ping bag, barton|away ^
03:04 mtj http://www.isup.me/http://git.koha-community.org/
05:22 * magnuse waves
06:44 alex_a bonjour
06:44 wahanui salut, alex_a
06:45 reiveune hello
06:45 wahanui what's up, reiveune
06:47 marcelr hi #koha
06:55 oha o/
06:56 marcelr o/
07:07 gaetan_B hello
07:15 magnuse o/
07:16 fridolin1 hie there
07:17 fridolin1 LibraryClaire: home sweet home ?
07:18 sophie_m hi #koha
07:24 magnuse bonjour sophie_m
07:24 sophie_m hello magnuse
07:24 LibraryClaire fridolin1: yes, back home :)
07:27 fridolin1 magnuse: we missed you ;)
07:27 magnuse fridolin1: awww... i missed you too!
07:31 magnuse kia ora paul_p! finally some peace and quiet in the office, eh?
07:32 paul_p hi magnuse, yes. And I agree it's quite strange ;-)
07:32 sameeenz Kia ora, fam.
07:32 magnuse hehe
07:44 drojf hi #koha
07:50 magnuse moin drojf
07:50 drojf hei magnuse
07:53 drojf @wunder berlin, germany
07:53 huginn` drojf: The current temperature in Berlin, Berlin, Germany is 7.5°C (9:42 AM CEST on March 27, 2017). Conditions: Clear. Humidity: 73%. Dew Point: 3.0°C. Windchill: 8.0°C. Pressure: 30.33 in 1027 hPa (Steady).
07:54 magnuse @wunder enbo
07:54 huginn` magnuse: The current temperature in Bodo, Norway is 1.0°C (9:20 AM CEST on March 27, 2017). Conditions: Light Snow. Humidity: 100%. Dew Point: 1.0°C. Windchill: -3.0°C. Pressure: 29.50 in 999 hPa (Rising).
07:54 magnuse 10 cm of fresh snow on the ground
07:55 drojf congratulations!
07:57 drojf we will get 16° today and 18 later this week
07:57 drojf you can have all the snow :)
08:00 drojf oh, 20 next weekend
08:10 matts hi #koha !
08:17 drojf hi matts!
08:37 * magnuse sends some snow to drojf, just because
08:38 drojf hehe
08:38 drojf i'll just melt it with my powerful sun
08:38 drojf @latet tell eythian https://qz.com/942104/people-wont-stop-staring-at-their-phones-so-this-dutch-town-put-traffic-lights-on-the-ground/
08:38 huginn` drojf: I'll give you the answer as soon as RDA is ready
08:38 drojf @later tell eythian https://qz.com/942104/people-wont-stop-staring-at-their-phones-so-this-dutch-town-put-traffic-lights-on-the-ground/
08:38 huginn` drojf: The operation succeeded.
08:40 eythian drojf: yeah, kinda funny. Bodegraven is a pretty pokey little village that has a really good beer festival each year.
08:42 magnuse Template process failed: undef error - The method selected is not covered by tests! at /usr/share/koha/lib/C4/Templates.pm line 121.
08:42 magnuse what does that mean ^
08:51 * cait waves
08:51 cait magnuse: file a bug usually
08:55 marcelr magnuse: this error comes from a koha object
08:55 marcelr the wrong method is called
08:56 magnuse it is triggered by visiting Patrons on 16.11.05 (gitified)
08:56 marcelr it might just be a trivial error, say calling size instead of count or something
09:03 magnuse looks like onlye this one gitified install is affected
09:12 pastebot "magnuse" at 127.0.0.1 pasted "The method selected is not covered by tests!" (141 lines) at http://paste.koha-community.org/353
09:12 magnuse i do get that stacktrace every now and then
09:18 magnuse kia ora atheia
09:18 atheia Hiya magnuse!
09:18 atheia How are things?
09:19 magnuse not too bad, except i an getting some nast errors on a gitified install
09:19 magnuse after upgrading to 16.11.5
09:19 magnuse anyone want to blame cait for me?
09:28 atheia Ooh, sounds horrid!
09:28 atheia I think I'll stay outside of your dispute if you don't mind ;-)
09:30 cait huh?
09:34 magnuse just having a problem with gitified 16.11.5
09:37 eythian @wunder ams
09:37 huginn` eythian: The current temperature in Amsterdam, Netherlands is 13.0°C (11:25 AM CEST on March 27, 2017). Conditions: Clear. Humidity: 54%. Dew Point: 4.0°C. Pressure: 30.24 in 1024 hPa (Steady).
09:44 * ashimema hates that 'untested' error
09:45 * ashimema just got caught out by koha git being down :(
09:48 magnuse yeah git.koha-community.org[0: 174.143.233.17]: errno=Connection timed out
09:49 magnuse ashimema: does it mean what is says - "there are no tests for this so we die horribly". or does it cover something else?
09:51 ashimema it means 'we don't trust the dbix::class test suit.. so if it's a dbix::class method that's autoloaded into koha::objects.. don't trust it'
09:51 magnuse uh huh
09:51 ashimema if you want to use a method from dbix::class that we've not already explicitly whitelisted and added a test for.. you have to whitelist it and add a test as it's own bug
09:51 ashimema I believe
09:52 ashimema catches me out and bugs me ;)
09:52 ashimema as for what it means for your gitified.. it likely means the whitelist didnt' get updated properly in a merge somewhere
09:53 ashimema https://github.com/Koha-Community/Koha/blob/master/Koha/Object.pm#L304
09:54 ashimema and the corresponding one for plural
09:54 ashimema https://github.com/Koha-Community/Koha/blob/master/Koha/Objects.pm#L338
09:54 ashimema a 'quick fix' is to just add the method that's being thrown as an error into the whitelist
09:54 ashimema hope that helps
09:55 marcelr ashimema: it might be something else
09:55 marcelr just a wrong method name for instance
09:55 marcelr size instead of count? that kind of thing
09:55 ashimema could be.. though those are usually obvious from the error
09:55 ashimema indeed
09:55 ashimema selected
09:55 ashimema that's an odd method
09:56 ashimema 'selected' could be a column name I guess?
09:56 marcelr probably a refactoring problem
09:56 ashimema yup
09:57 marcelr selected was passed to templates for combo boxes
09:57 marcelr but if you are using an koha object now, it does not work anumore
10:02 magnuse i even read it as "The method [you] selected is not covered by tests!"
10:02 magnuse not that "selected" was a method name...
10:09 marcelr magnuse: just coincidence :)
10:13 cait hm i want to make a release today - can someone please fix git.koha-community.org?
10:13 cait :(
10:14 magnuse im also seeing "Problem = a value of activeBorrowerRelationship has been passed to param without key at /usr/share/koha/lib/C4/Templates.pm line 137"
10:14 magnuse and the same for relatives_borrowernumbers
10:14 * cait hides from magnuse
10:15 * marcelr remembers seeing too
10:15 magnuse looks like git is hosted by bywater
10:15 marcelr khall !
10:15 cait i sent them an email, kidclamp, khall, bag and jessem
10:16 cait didn't hear back
10:16 cait it was this morning, might be timezones
10:16 khall mornin marcelr!
10:16 khall cait: I'll check my email
10:16 magnuse and jetlag
10:16 marcelr hi khall
10:16 marcelr ^^
10:16 magnuse and overdosing on cheese
10:20 cait khall: our repo is down - I need it to release
10:20 cait marcelr: it seems when you shout it works .)
10:20 khall cait: I'll see if there is anything I can do
10:24 cait magnuse: do you remember when opl went live last year? the month?
10:24 cait thx khall
10:24 magnuse cait: one sec, i'll find it
10:24 magnuse it was while we were in marseille
10:24 magnuse in the fall
10:26 cait october?
10:26 magnuse yeah, guess so
10:26 khall cait: git is back up!
10:27 cait thx
10:28 magnuse khall++
10:28 magnuse cait: October 12th
10:30 cait thank you
10:30 cait khall++
10:31 magnuse looks like every page that has "activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne '')" shows an Internal Server Error message
10:32 magnuse 'borrowerRelationship' is set to "father|mother"
11:09 magnuse warn does not put anything in the plack error log? What is the equivalent for plack then?
11:13 marcelr magnuse: yes, it should
11:14 marcelr but you may need to restart plack to update the code in cache
11:18 magnuse yeah, i have done that
11:18 magnuse but this does not look right: 'ARRAY(0x8f609d0)' => 'PatronsPerPage',
11:18 marcelr yeah
11:18 marcelr an array should be on the right
11:19 vfernandes hi #koha
11:20 vfernandes there is a mappings.yaml (mappings for elasticsearch) defined for UNIMARC authorities?
11:22 magnuse there is some assignment in $template->param() that messes up those params
11:57 magnuse druthb: don't you kinda need to change your nick? :-)
11:58 druthb magnuse: I do, kinda. It's on my long list of places to change my name. :P
11:58 magnuse hehe, i can only imgaine...
11:58 magnuse or imagine
11:59 magnuse this should be one of the easier ones, though, i guess :-)
11:59 druthb Since I use bip, there's a half-dozen steps to get things switched over on four different machines, with three different IRC servers...
11:59 magnuse ah yes, forget easy then
11:59 magnuse it looks like my problem is somehow stemming from this: housebound_role => $patron->housebound_role,
11:59 marcelr magnuse: did you miss a db rev ?
12:00 druthb I had some mail to send out this morning, and as I was preparing the envelope, I had to remember my new name for the return address. Muscle memory is insidious.
12:00 magnuse hehe
12:00 magnuse marcelr: possibly
12:04 magnuse housebound tables and syspref are there
12:06 marcelr magnuse: it should be a method in Koha/Patron
12:07 magnuse marcelr: housebound_role?
12:09 magnuse i have a hunch there is a problem with the schema files, but koha-common and the gitified install are at the same version, so it should not matter where koha finds the schema files
12:17 marcelr magnuse: no it is no column. it is a sub
12:18 marcelr a method is a sub; a column may be available via a method
12:19 pastebot "magnuse" at 127.0.0.1 pasted "Digging further" (61 lines) at http://paste.koha-community.org/354
12:20 magnuse ever grateful if someone casts an eye on that.
12:21 tcohen morning #koha
12:21 marcelr magnuse: put scalar in front of $patron->housebound_role
12:21 marcelr hi tcohen
12:21 marcelr magnuse: saw this issue with plack before
12:22 tcohen Joubu++ # QAing 13757, and force me to do it better
12:23 marcelr perl seems to work on this construct and plack does not like it (so it seems)
12:23 marcelr bug 13757
12:23 wahanui bug 13757 is, like, set to 'needs signoff,' but depends on a 'NEW' bug, Bug 17767. Should 13757 be 'Blocked' instead
12:23 pastebot "magnuse" at 127.0.0.1 pasted "with scalar" (4 lines) at http://paste.koha-community.org/355
12:23 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Make patron attributes editable in the opac if set to 'editable in OPAC'
12:23 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Let Koha::Patron::Modification handle extended attributes
12:24 magnuse but the page still shows "Template process failed: undef error - The method selected is not covered by tests! at /home/magnus/hylte/kohaclone/C4/Templates.pm line 121." in the browser
12:24 magnuse and i have turned off plack now
12:24 marcelr not what we expected ?
12:25 tcohen magnuse: that error means the template is trying an accessor that is not defined
12:25 tcohen if you are not running plack, and there's no bug, then it might be a template caching issue
12:31 pastebot "magnuse" at 127.0.0.1 pasted "plenty of houseboubd_role" (29 lines) at http://paste.koha-community.org/356
12:34 tcohen magnuse: 'selected' isn't actually an accessor
12:34 marcelr ^^
12:35 marcelr 11:56
12:35 tcohen so, it seems they forgot to wrap things in a hashref
12:35 tcohen and take care of setting the selected => value
12:36 marcelr they again :)
12:36 marcelr luckily it wasnt me
12:37 * magnuse is confused
12:37 magnuse which things should be in a hashref?
12:37 marcelr tcohen: you are the patron modification expert ;)
12:37 tcohen marcelr: what do you mena?
12:37 tcohen mean?
12:37 wahanui http://web.archive.org/web/20150329232842/http://media.tumblr.com/d81c251e7bdc71ef9304f707ca669378/tumblr_mmo7n6iHxW1r0tcyxo2_250.gif
12:38 marcelr nada
12:38 tcohen is this related to patron modifications?
12:38 magnuse if i do warn Dumper $patron->can( 'housebound_role' ); i get $VAR1 = sub { "DUMMY" };
12:38 marcelr hmm might be patrons only
12:39 marcelr you re lucky too tcohen 1
12:39 marcelr s/1//
12:39 tcohen cool :-D
12:39 marcelr can we blame git bz ?
12:40 tcohen magnuse: did you file a bug for that?
12:40 magnuse no, i still have no idea what or where the problem is
12:40 marcelr magnuse: Joubu knows all about housebound stuff
12:40 tcohen i need to head to a meeting, but I'm all for reading the steps to reproduce and try to help
12:43 oha afaik, $obj->can() returns the method referene if available, or undef when it is not. can belongs to UNIVERSAL::can
12:43 oha magnuse, marcelr: ^
12:46 pastebot "magnuse" at 127.0.0.1 pasted "with $Data::Dumper::Deparse = 1" (10 lines) at http://paste.koha-community.org/357
12:46 magnuse looks like $patron actually *can* ->housebound_role
13:08 magnuse what the dickens! i only get the error "Template process failed: undef error - The method selected is not covered by tests! at /home/magnus/hylte/kohaclone/C4/Templates.pm line 121." when i select another language than english!
13:09 cait1 oh
13:09 marcelr ok magnuse: old template ?
13:09 cait1 translation error?
13:09 cait1 i am working on 16.11.06 now
13:09 magnuse i'll regenerate templates and see
13:09 marcelr we should always ask first: are you using norwegian ? :)
13:10 cait1 hopefully should be done within the hour
13:13 magnuse i was using swedish ;-)
13:15 marcelr ahh
13:19 magnuse ...and updating the templates solves it
13:19 magnuse MAN i spent ALL DAY on this
13:19 magnuse *facepalm*
13:22 marcelr magnuse: you learned more about Koha :)
13:22 magnuse sorry for wasting your time ashimema, marcelr, tcohen
13:22 marcelr and we learned more too :)
13:23 magnuse well, i learned something i already knew: if you run a gitified install you have to regenerate the templates yourself
13:23 magnuse and the first step of debugging is always: does it work in english
13:28 cait1 pushing up translations
13:28 cait1 can only take some more hours :P
13:32 tcohen @wunder cordoba, argentina
13:32 huginn` tcohen: The current temperature in Cordoba, Argentina is 21.0°C (10:00 AM -03 on March 27, 2017). Conditions: Scattered Clouds. Humidity: 94%. Dew Point: 20.0°C. Pressure: 30.04 in 1017 hPa (Steady).
14:09 cait release is done!
14:10 pastebot "tcohen" at 172.22.66.163 pasted "sub type { my $self = shift; $" (7 lines) at http://paste.koha-community.org/358
14:12 kidclamp @later tell eythian If I could pick your brain a bit on elastic that would be helpful
14:12 huginn` kidclamp: The operation succeeded.
14:15 fridolin1 Joubu: hie, thanks for Bug 18329
14:15 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 major, P5 - low, ---, fridolin.somers, Signed Off , Batch record deletion broken
14:16 fridolin1 I'm working on some other pb with transactions on manage-marc-import.pl
14:16 fridolin1 are u ?
14:44 cait slides?
14:44 wahanui get back to writing them, cait!
14:48 Joubu fridolin1: nope
14:50 fridolin1 Joubu: oki, I mail on devel to explain a bit the pb
14:50 fridolin1 i think we should give some convensions for using db transactions
14:53 Joubu fridolin1: why do you think email is useful?
14:53 Joubu I think we all know the problem
14:53 Joubu we have to use dbic transactions, not DBI ones
14:55 fridolin1 Joubu: ah ccool, is there an existing coding guide line ?
14:56 Joubu I do not think so, QA is aware of that
14:57 fridolin1 oki cool
14:58 cait Joubu: will look at your comments later this week - travelling tomorrow and a bit of time until next release to sort those out
15:00 fridolin1 Joubu: do you think "$dbh->{InactiveDestroy} = 1;" is usefull ?
15:00 Joubu cait: we talked about Hea on Friday actually
15:01 Joubu fridolin1: I think it was
15:01 Joubu did you git blame to get the bug #?
15:02 fridolin1 it has been added with the background processings
15:05 fridolin1 dbix storage has a method calling this options
15:05 fridolin1 _verify_pid
15:05 cait Joubu: i know, but i thought it was mostly about hte hea2 bug
15:06 cait not about the one changing the installer, i will take a closr look
15:13 Joubu cait: one is based on the other one. Actually the title of the 1st one is wrong, there is not change made to the installer finally
15:13 Joubu just a new page to the admin module
15:15 cait Joubu: ah, maybe change the title if you have it open right now?
15:15 cait better for release notes :)
15:39 ashimema magnuse still about?
15:39 ashimema nope
15:39 ashimema poop
15:47 Joubu ashimema: you said "it means 'we don't trust the dbix::class test suit.. so if it's a dbix::class method that's autoloaded into koha::objects.. don't trust it'"
15:47 Joubu about the Koha::Object[s] whitelist
15:47 Joubu the idea is to control what we are using (in case we want to leave DBIC at some point)
15:47 Joubu and provide test to make sure it's what we want
15:48 Joubu We do not big problems related to that, on the contrary we catch bugs when objects are trying to access columns that do not exist
15:49 Joubu (guess that would be the same without the check actually, we would get the dbic exception)
15:49 reiveune bye
15:49 Joubu anyway, timezones...
15:50 ashimema I wasn't being mean there.. just trying to tell magnus where the problem may lie
15:50 ashimema as it happened it was further down rebasing any-ways I think.
17:05 bag morning
17:06 bag bug 13757
17:06 wahanui well, bug 13757 is set to 'needs signoff,' but depends on a 'NEW' bug, Bug 17767. Should 13757 be 'Blocked' instead?
17:06 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 enhancement, P5 - low, ---, tomascohen, Pushed to Master , Make patron attributes editable in the opac if set to 'editable in OPAC'
17:06 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Let Koha::Patron::Modification handle extended attributes
20:39 Joubu @later tell tcohen take a look at the last patch on bug 15032 please
20:39 huginn` Joubu: The operation succeeded.