Time Nick Message
21:18 jenkins_koha Starting build #25 for job Koha_3.18.x_U14 (previous build: FIXED)
21:02 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Move the bookseller-related code into its own module
21:02 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 minor, P5 - low, ---, m.de.rooy, Pushed to Master , Add some hints for Host, Database and SRU search fields mappings
21:02 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 normal, P5 - low, ---, koha-bugs, Pushed to Master , A bug was introduced by 1861 - meaning borrowers sometimes cant be added
21:02 jenkins_koha * Jonathan Druart: Bug 12896: Remove 2 occurrences in comments
21:02 jenkins_koha * Jonathan Druart: Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller
21:02 jenkins_koha * Marcel de Rooy: Bug 12823: Alert about defining the SRU search field mappings
21:02 jenkins_koha * Marcel de Rooy: Bug 12823: Add some hints for Host and Database
21:02 jenkins_koha * Tomas Cohen Arazi: Bug 1861: (RM followup) DNIx updates
21:02 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 normal, P4, ---, kyle, Pushed to Master , Unique patrons logins not (totally) enforced
21:02 jenkins_koha * Jonathan Druart: Bug 13502: Add tests to highlight the problem
21:02 jenkins_koha * Chris Cormack: Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
21:02 jenkins_koha * Jonathan Druart: Bug 1861: Add 1 test to AddMember
21:02 jenkins_koha * Chris Cormack: Bug 1861: There is a problem introduced with an earlier patch, on this patchset
21:02 jenkins_koha Project Koha_Master_D7 build #279: NOW UNSTABLE in 42 min: http://jenkins.koha-community.org/job/Koha_Master_D7/279/
20:35 jenkins_koha * Jonathan Druart: Bug 13502: Add tests to highlight the problem
20:35 jenkins_koha * Chris Cormack: Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
20:35 jenkins_koha Project Koha_3.18.x_U12 build #9: FIXED in 59 min: http://jenkins.koha-community.org/job/Koha_3.18.x_U12/9/
20:35 wahanui o/ '`'`'`'`'`'`'`'`'`
20:35 jenkins_koha Yippee, build fixed!
20:31 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 normal, P5 - low, ---, koha-bugs, Pushed to Master , A bug was introduced by 1861 - meaning borrowers sometimes cant be added
20:31 jenkins_koha * Jonathan Druart: Bug 13502: Add tests to highlight the problem
20:31 jenkins_koha * Chris Cormack: Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
20:31 jenkins_koha Project Koha_3.18.x_U14 build #24: FIXED in 45 min: http://jenkins.koha-community.org/job/Koha_3.18.x_U14/24/
20:31 wahanui o/ '`'`'`'`'`'`'`'`'`
20:31 jenkins_koha Yippee, build fixed!
20:28 rangi (getting it back so that builds are happy)
20:28 rangi cait++
20:28 rangi Joubu++
20:28 rangi ashimema++
20:28 rangi tcohen++
20:25 rangi couldnt really start 2015 with a broken build :)
20:24 rangi yay
20:19 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 normal, P5 - low, ---, koha-bugs, Pushed to Master , A bug was introduced by 1861 - meaning borrowers sometimes cant be added
20:19 jenkins_koha * Jonathan Druart: Bug 13502: Add tests to highlight the problem
20:19 jenkins_koha * Chris Cormack: Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
20:19 jenkins_koha Project Koha_3.18.x_D7 build #29: FIXED in 41 min: http://jenkins.koha-community.org/job/Koha_3.18.x_D7/29/
20:19 wahanui o/ '`'`'`'`'`'`'`'`'`
20:19 jenkins_koha Yippee, build fixed!
20:07 barton can someone point me to documentation for queryparser? I don't know anything more than that it presumably parses queries ;-)
20:01 huginn New commit(s) kohagit: Bug 12896: Remove 2 occurrences in comments <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a93fd3fe06dbdea972ea8c329ae4f77335314566> / Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=469f36d38fe3ea82013d40b95892dfb7605b4e5f> / Bug 12823: Alert about defining the SRU search field mappings <http://git.koha-communi
19:46 jenkins_koha Starting build #24 for job Koha_3.18.x_U14 (previous build: STILL FAILING -- last SUCCESS #19 6 days 0 hr ago)
15:05 tcohen rangi: what are you doing awake?
14:51 barton so, back to my original question: If I don't want to queue print notices, is there a way to avoid that? If I simply blank the 'print' template for the notice in question, will I cause errors?
14:48 ashimema and found numerious bugs
14:48 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 major, P3, ---, abl, Needs Signoff , Questionable logic regarding session handling in C4::Auth::checkauth()
14:48 ashimema whilst reading through code to work on bug 12954 i realised how incomprehendible bits of that code are..
14:47 tcohen heh
14:47 ashimema I'm really hoping to tidy and document Auth.pm some time in this cycle.. after that writing tests and then refactoring may be a bit more plausable ;)
14:46 ashimema ;)
14:46 barton not that I'm volunteering to make that happen ;-)
14:46 ashimema lol.. that's another rats nest entirely barton..
14:46 barton ashimema: it would be easier if we made the distinction between 'borrowers', 'users' and 'patrons'.
14:45 tcohen ok
14:44 ashimema in which case the 'user login' being unique is no longer true..
14:44 ashimema having said that.. I wonder if we're still not actually solving the bug in terms of keeping 'user login unique'.. I need to test.. I wonder if one could create a userid that matches a cardnumber..
14:43 ashimema I don't think it does any harm for it to be mandatory, as one can still rely upon cardnumber as the alternative login machanism..
14:43 tcohen and raise the question to koha-devel
14:43 tcohen I'll attach a followup that fixes the remaining failing tests
14:42 ashimema good point, I hadn't actually comprehended that side effect.
14:41 ashimema hmmm
14:41 ashimema seeing as we allow login via other means too, then there's no reason to make it mandatory... except for possibly making our live easier in terms of reading the code.
14:40 barton cait: you're right (as usual ;-) -- gather_print_notices.pl calls C4::Letters::_set_message_status( { message_id => $message->{'message_id'}, status => 'sent' } ) for each message.
14:40 tcohen *mandatry
14:40 tcohen ok, the nature of the patch and the bug report is to make the userid andatory
14:39 ashimema I asked mysefl that very same question recently.
14:39 tcohen should we keep allowing for borrowers without userid?
14:39 ashimema go on
14:38 tcohen and one question arised
14:38 tcohen ashimema: I'm trying to fix the remaining test errors generated by 1861
14:38 tcohen thanks barton
14:38 barton tcohen: he's off until the end of the week, I think.
14:36 tcohen khall: around?
14:25 barton nod.
14:25 cait 2 waiting for sign off :)
14:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Gather print notices: send files by email
14:25 cait bug 11678
14:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Gather print notices: add csv and ods export
14:25 cait bug 11603
14:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12810 normal, P5 - low, ---, koha-bugs, NEW , After MTT gather_print_notices includes overdues
14:25 cait bug 12810
14:25 cait i tihnk it at least should do that
14:25 cait otherwise it wouldn't know which to print
14:24 cait i think
14:24 cait itdoes
14:24 barton cait: as far as I know, gather_printnotices.pl doesn't change the message status.
14:24 cait it probably says it will only deal with holds, but it's not true :)
14:24 cait yeah, look for the cronjob
14:24 barton cait: anything that's handled by misc/cronjobs/overdue_notices.pl: first, second or third overdue messages.
14:23 cait i think you want to take a look at gather_printnotices or similar
14:23 cait barton: which notices specifically?
14:23 barton heh... the benefits of being in an international forum during new years eve.
14:23 tcohen hey!
14:23 cait happy new year :)
14:22 tcohen ashimema: thanks!
14:22 ashimema Hi tcohen.. happy new your to you.
14:21 barton and is there any mechanism for getting the print notices out of the 'pending' status?
14:21 tcohen hi ashimema Joubu
14:21 barton so ... how do we control which of these options we want? If a library wants to handle the messages using the branch emails, how do I turn off the print notices?
14:19 barton I have a question about how we're handling overdue notices for patrons without email addresses: in misc/cronjobs/overdue_notices.pl, we do two things: a) we append the 'email' notice to an email to the borrower's home branch (or to the main email address if that's not defined) and b) we add a 'print' notice to message_queue...
14:17 ashimema happy new years eve all
14:17 ashimema have a great night Joubu
14:17 Joubu Have a good new year's eve #koha!
14:11 tcohen hi barton
14:10 barton morning #koha!
14:07 tcohen happy new year everyone
14:05 tcohen morning
14:03 reiveune bye
12:44 ashimema that's a cool idea
12:44 ashimema I like the htmlcomments logs
12:39 ashimema the small steps appraoch ;)
12:39 ashimema I sort of like the idea of transplating some of it into bug 8190.. or perhaps using it as a first step, then refactoring 8190 on top of it as a followup
12:38 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 enhancement, P5 - low, ---, jonathan.druart, In Discussion , Add a logging module to Koha
12:38 Joubu ashimema: Maybe it's a good (new) start. But it's not as complete as bug 8190
12:36 ashimema any thoughts on it?
12:35 Joubu ashimema: yes, I have seen it this morning, thanks to link them
12:31 ashimema i'm kinda liking parts from both bugs now
12:31 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 enhancement, P5 - low, ---, gmcharlt, Needs Signoff , Koha::Log - an attempt to have sane logging in Koha
12:31 ashimema did you see bug 13413
12:30 Joubu ashimema: yes, I completely agree, I am fighting for that for 2 years
12:06 ashimema it would be so good to have a decent logging module
12:05 ashimema cheers Joubu
12:05 Joubu ashimema: done. I didn't test, but you will be able to apply the patches
12:00 ashimema shame..
12:00 ashimema k..
12:00 Joubu ashimema: I don't think so
11:59 ashimema like a --continue or somthing..
11:59 ashimema once you've fixed the problem.. is there a commit option that takes the original commit message of the patch file?
11:58 ashimema stupid question.. as I'm attempting to elarn the --reject command..
11:50 * cait waves
11:48 ashimema thanks Joubu
11:48 wahanui That'll be $1 for the awesome jar, ashimema
11:48 ashimema awesome..
11:48 Joubu ashimema: I am rebasing it
11:47 ashimema I was wanting to try tidying up Auth in general.. and one of my top hitting bugs to converting auth.pm to use more sensible logging.. hense going back to all the logging bugs ;)
11:46 ashimema sorry dude..
11:46 ashimema yup..
11:46 Joubu outch, an old one!
11:45 ashimema so.. 8190 is the one that's caught like this for me
11:45 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 enhancement, P5 - low, ---, gmcharlt, Needs Signoff , Koha::Log - an attempt to have sane logging in Koha
11:45 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 enhancement, P5 - low, ---, jonathan.druart, In Discussion , Add a logging module to Koha
11:45 ashimema I was attempting to apply bug 8190 to test and see if I can work out if bug 13413 would fit in nicely to it.
11:45 Joubu I can try to rebase it myself
11:44 wahanui which one is that? The fixed navbar?
11:44 Joubu ashimema: which one?
11:44 Joubu ha :)
11:44 ashimema nope.. you are ;)
11:44 Joubu ashimema: Are you the author of the patch set?
11:44 Joubu because if it fails on the 2nd, it will certainly fail with the others
11:43 ashimema oh.. I see.. so I need to get out of git bz 'mode' as such.
11:43 Joubu so it's much more complicated :)
11:43 Joubu then git bz apply --abort; git apply --reject /tmp/your.patch
11:43 ashimema it's a set.. 9 patches.. the 2nd one fails in this way.
11:42 Joubu ashimema: you can skip the patch if it's the last one
11:42 Joubu ashimema: it depends on the number of patches on the bug report
11:42 ashimema so windering what I'm doing wrong
11:42 ashimema it dumps out a .patch in /tmp/ then i'm attempting 'git apply --reject /tmp/patch' but that just hangs for me :(
11:41 ashimema When I come across a sha1 type issue with applying part of a series of patches..
11:40 ashimema Joubu.. do you happen to know of any good guides to using --reject on git apply and how to fit it into the git bz workflow?
09:03 cait :)
08:41 gaetan_B hello
07:57 wahanui bonjour, alex_a
07:57 alex_a bonjour
07:29 wahanui hola, reiveune
07:29 reiveune hello
07:24 * ashimema is attempting to resurrect or kill off ancient bugs in the authentication space
07:11 ashimema i.e. setting a demo pref in koha-conf?
07:11 ashimema is anyone still using... or even aware of... 'demo mode' in koha?
06:38 ashimema morning
06:06 mtompset Happy New Years, #koha.
04:22 * dcook wanders off to his celebrations
04:22 dcook Happy new years :)
03:13 huginn mtompset: eythian was last seen in #koha 1 hour, 58 minutes, and 56 seconds ago: <eythian> http://i.imgur.com/pWdtRMv.png
03:13 mtompset @seen eythian
03:13 mtompset Greetings, #koha.
02:52 dcook So someone is doing work in the office under ours and it sounds like a heartbeat...
02:37 dcook New years should be fun :D
02:37 dcook wizzyrea: Why the quotes?
02:37 dcook eythian: O_o
01:18 wizzyrea "I love you guys."
01:18 * wizzyrea gives up and wishes everyone the best new years ever.
01:17 wizzyrea it's a... what?
01:14 eythian http://i.imgur.com/pWdtRMv.png
01:13 dcook Actually got that last one from http://old.kete.net.nz/documentation/topics/show/163-accessing-zebra-directly-with-yaz-client, and figured out the ccl one from ccl.properties...
01:12 dcook pqf=@attr 1=_ALLRECORDS @attr 2=103 ""
01:12 dcook or:
01:12 dcook ccl=allrecords,AlwaysMatches=""
01:12 dcook Ahh... this could've been handy in the past: