Time Nick Message
00:27 dcook BobB, irma, mtj: I don't know what you folks use for your LibrariesAustralia database value, but head's up that the legacy value "ANY" is no longer supported.
00:27 dcook Well, the uppercase version that is. "any" still works although I imagine you might be using the new "Bibliographic" label anyway
00:28 dcook Ah right...moving office...
00:35 dcook Argh...that moment when you can't find that code snippet that you remember writing a month or so ago...
00:35 dcook Oh wait, there it is
00:35 dcook \o/
01:48 dcook Hmm...has anyone had a case where DataTables were showing duplicate rows even though the data in the database isn't duplicated?
01:48 dcook Specifically in reports...
01:50 mtj hmm, not me dcook
01:51 mtj hay, you might like this for snippets -> http://lifehacker.com/5938721/nvpy-brings-notational-velocity-style-note-taking-to-all-platforms
01:51 dcook Hmm, I do ponder better ways of saving notes...
01:52 dcook Yeah, the DataTable thing is weird. It's only a few rows :S
01:53 dcook Ah, I mi ght have it figured..
01:54 dcook They're duplicated if they have a report_group
01:54 dcook Well that's not nice...
01:57 dcook What the ever living...
02:37 * wizzyrea gets the popcorn
02:39 eythian There's not even a movie on.
02:39 * dcook promises not to rage out in hollywood fashion
02:39 dcook Oooh I do have junk food too though...
02:46 dcook I dislike tables...
02:47 dcook (or that everyone doesn't use huge monitors :P)
02:58 dcook They don't look very good in Koha
02:59 dcook If you have a smaller screen, they'll routinely hang out over the right edge
02:59 dcook :/
02:59 dcook But...there's so much data that it's tough to do really use anything narrower
03:00 dcook I suppose the thing is to probably expand the div behind the table so it doesn't hang out...but still requires scrolling
03:01 wizzyrea that is a problem that lots of webapps struggle with
03:01 wizzyrea just hard to deal with very old/low-res monitors
03:01 dcook Well, anything with a narrower screen
03:02 dcook But I doubt that many people use a tablet with the admin interface
03:03 wizzyrea http://kohadevreactions.tumblr.com/post/68964940127/one-does-not-simply-do-acquisitions-on-an-ipad
03:03 dcook lol
03:03 dcook Yarp
03:06 pianohacker and yet someone likely does... http://xkcd.com/1172/
03:07 wizzyrea :)
03:07 dcook pianohacker: I think about that all the time...
03:07 wizzyrea https://38.media.tumblr.com/da7eaaaf0b967c78c69a6c91d54dc14c/tumblr_n8r7uylnkw1rrx588o1_400.gif < my actual response
03:07 dcook :(
03:07 dcook hehe
03:07 dcook I like that liz
03:08 dcook I suppose the issue I'm facing is more so with the tab than the table I suppose...
03:09 dcook Because scrolling isn't that bad
03:09 dcook But it hanging out over the tab is...ugly as
03:15 dcook I can't imagine sticking this in my eye: http://spectrum.ieee.org/tech-talk/biomedical/devices/google-working-on-smart-contact-lens-to-monitor-diabetes
03:16 dcook I suppose even if we did 'see' everything in our vision...we'd probably use windows and you'd have narrow windows in your vision (so you could view data tables while driving...)
03:18 wizzyrea lol wow
03:18 wizzyrea I don't even know what to do with that last
03:18 dcook hehe, which?
03:21 wizzyrea windows in your contact lenses
03:21 dcook Well, windows in the display..
03:21 dcook :P
03:22 dcook windows though...not Windows
03:22 * dcook shudders at the thought
03:28 dcook Ugh...yui...
03:34 dcook yui--
03:35 dcook web--
03:35 dcook All right. I'm done grumping about the internet :p
04:10 pianohacker bye all
05:17 dcook heya cait :)
05:18 cait morning
05:25 dcook Figured out that duplicate datatable row thing with reports
05:25 dcook Turns out if you have duplicate values in REPORT_GROUP, you also get duplicate rows in the Saved reports DataTables...
06:10 ashimema evening dcook
06:11 * cait waves
06:11 ashimema cait, you are up entirely too many hours of the day.
06:16 dcook heya ashimema
06:16 wahanui well, ashimema is on qa now .)
06:17 ashimema You've been wrangling allot of late dcook..
06:17 ashimema nice work
06:17 dcook Wrangling?
06:17 cait ashimema: hmpf?
06:17 dcook I'm not sure what you mean, but thanks :)
06:19 ashimema i've had a steady stream of bugzilla comments coming in from you of late dcook..
06:20 ashimema cait, I poped in after the pub last night at midnight.. just to turn the pc off.. and of course.. you were here talking to rangi.
06:20 ashimema your always online.. it's impressive
06:20 * cait feels guilty now
06:20 cait it just means i don't have a life i guess
06:22 cait well, or at least a weird one
06:23 cait ashimema++ thx for the link :)
06:24 dcook cait: Perhaps just a weird one, but I'm not one to point fingers :p
06:24 dcook ashimema: Ah, right. Yep, I've been a loudmouth lately :p.
06:25 ashimema haha.. all good.
06:25 ashimema though I did find your thoughts on authentication interesting..
06:25 ashimema you did an about turn in the middle
06:25 ashimema 'ack, the authentication system is awful it needs a re-write'
06:26 ashimema 'lets make a series of bugs to work toward that'
06:26 ashimema 'hang on, this code isn't so bad afterall'
06:26 ashimema 'damned if i want to do the re-write'
06:26 ashimema ;)
06:26 ashimema auth.pm does need some polishing I agree, btw.. but at least it works at the momoent ;)
06:32 dcook hahaha
06:32 dcook Yep
06:32 dcook Admittedly, I don't know if auth.pm is so bad
06:32 dcook I think checkauth() needs better documentation though
06:32 dcook Which...I might get to one of these days
06:33 dcook I actually did a local patch to add authentication via OpenID Connect
06:33 ashimema our code commenting is generally pretty aweful to be frank. ;)
06:33 cait i am more bothered that not everything is using it
06:33 cait like sip
06:33 ashimema so yeah, I'd agree that checkauth needs documenting properly
06:33 dcook I should maybe looka t SIP one day..
06:33 dcook ashimema: And a more extensible mechanism for adding new types of auth
06:34 ashimema SIP.. yuk
06:34 cait bug 9936
06:34 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 normal, P5 - low, ---, koha-bugs, NEW , SIP2 should use C4/Auth.pm for user authentication
06:34 dcook I'm thinking of adding in some of my changes, and using re-factoring Persona a bit to fit it into that model...
06:34 ashimema yeah, making it more modular from the ground up would certainly be nice..
06:34 dcook I don't know if I'll include my OpenID Connect stuff though...it's not very good
06:34 cait lol
06:35 cait you shouldn't say that with qa people in the room
06:35 ashimema but at least there are a fairly standard set of 'hacks' to plug into it.. auth_with_...
06:35 ashimema that would be good dcook.
06:35 ashimema it would be nice to see openID in..
06:36 dcook Well, OpenID Connect is a wrapper for OAuth2.0
06:36 cait bbiab
06:36 ashimema oh.. I see..
06:36 dcook When they said OpenID it threw me for a loop at first because it wasn't OpenID :S
06:36 ashimema didn't realise that.
06:36 dcook Yeah, it's a bit weird
06:36 dcook see ya, cait :)
06:36 dcook good luck!
06:36 dcook Soo with "Auth_with...", I assume that we're using Koha's login form as the main login point
06:36 ashimema i use my shibboleth work to support a cheeky pass through for openID.
06:37 dcook Then we do a remote call to the authentication server then do things in Koha?
06:37 dcook hehe
06:37 ashimema that is correct.
06:37 dcook Cool beans
06:37 dcook I suppose it would be nice to use Koha::Authen::XXX instead of C4::Auth_with_, but...
06:37 ashimema though with shibboleth, you can set the login location to pretty much any page (including the main page) in the virtualhost
06:37 ashimema so it doesn't really matter
06:38 dcook O_o
06:38 dcook You can only login from certain pages?
06:38 ashimema yeah, it would certialy be nice to have a Koha::Auth::
06:38 ashimema yeah, it would certialy be nice to have a Koha::Authen::.. your right
06:39 ashimema shibboleth is a strange thing.. you can login from anywhere.. including some website totally unrelated to koha ;).. or even not a website at all ;)
06:39 dcook I've just started doing a Koha::Prosentient::XX, so hopefully it'll be easier to keep custom code separate, plus make it a bit easier to upstream later...as I'll just need to change the package name in the module and the scripts that use it
06:39 dcook ashimema: That does sound strange :p
06:40 dcook I would do more with your patches but not having any work locally with it makes it a bit tougher
06:40 dcook My desire to improve Search is both selfish and altruistic ;)
06:40 ashimema We have a customer using shibboleth where they simply login to their computer in the morning.. and that's it.
06:40 dcook O_o
06:40 ashimema ALL other stuff they use is already althenticated.. including Koha ;)
06:40 dcook Whoa
06:41 dcook That's interesting!
06:41 ashimema indeed.. shibboleth is in fact all kinds of awesome...
06:41 ashimema when it works.
06:42 ashimema I'd love to have the time to put into search..
06:42 dcook Me too, haha
06:42 dcook I feel like I'm getting closer to understanding it though...
06:42 ashimema I still think Zebra could be awesome.. if we used it right.
06:42 dcook Not just the code but the concept
06:42 dcook Agreed
06:43 dcook As time goes on, I actually have fewer and fewer quams with Zebra
06:43 dcook qualms*
06:43 ashimema and yeah.. making search much more modular at the core.. that would also be a prime directive..
06:43 dcook Totes
06:43 ashimema but alas.. that's a massive amount of work.. and I now have a compleete re-write of a product on my plate already.
06:43 dcook At the moment though, I mostly want to fix what I see as most broken
06:43 dcook Oh?
06:43 dcook What re-write are you staring at?
06:44 dcook I think the testing, perhaps, is the most amount of work
06:44 dcook Making sure not to screw with people's sense of search reality...also a lot of work
06:44 ashimema It's a reading list solution we are punting here.. closed source for now unfortunately..
06:44 dcook Reading list?
06:44 ashimema mind you.. the current code is so bad that I wouldn't want to burden it on anyone.
06:44 dcook haha
06:44 dcook I know that feeling...
06:45 dcook If only I knew two years ago what I knew now...
06:45 dcook Mind you, I'm sure I'll feel that way in two years time
06:45 dcook I wonder if your reading list solution is similar to some code I worked on?
06:45 ashimema I'm using the original as a prototype.. even though we have loads of customers on it already.. and am re-writing the whole thing in perl from scratch.
06:45 ashimema haha.. maybe.
06:46 dcook My feature basically checks for recently catalogued books, checks against an "interest" that the patron has specified, and then emails them with a list of resources that might interest them
06:46 reiveune hello
06:46 ashimema I hope to talk the powers that be into open sourcing it once I've got some of the ground work done.. they seem mildly optimistic about doing that.
06:46 dcook Apparently the client likes it, but I'd like to improve it...
06:46 fridolin hie all
06:46 dcook yo reiveune, fridolin
06:47 dcook ashimema: That's awesome :)
06:47 fridolin hie dcook
06:47 ashimema nah.. this is a system for creating and managing reading lists.. mostly for academic libraries at the moment..
06:47 ashimema it's been really popular.
06:47 ashimema hi fridolin
06:47 dcook So reading lists as in...lists of readings that students need to do?
06:48 dcook Sorry. It's nearly 5. I'm a bit slow :p
06:48 fridolin hie ashimema
06:48 ashimema indeed.
06:48 dcook Cool beans :)
06:48 ashimema https://cumbria.rebuslist.com/
06:48 ashimema for an example.
06:50 * dcook isn't seeing the introductory guide :(
06:50 ashimema it looks nice form the user perspective.. but underneath it's like a low budget horror movie ;)
06:50 ashimema lol..
06:50 dcook haha
06:50 ashimema I hadn't noticed that..
06:50 ashimema silly customer.
06:51 dcook Something to be said for looking nice from the user perspective though
06:51 dcook I wish more of my stuff looked nice
06:51 dcook I have a friend who is a graphic designer. I should pick up some tips from him about what looks nice
06:51 dcook He's hilarious. He'll show me a piece of artwork and say "Oh, this is horrible", and it's something I could never ever possibly dream of creating
06:51 ashimema my aim is to take the visual queue from the current implimentation.. but achieve it using bootstrap or foundation or similar
06:51 dcook Creative people...
06:52 dcook Mmm, yeah, I like that visual bit
06:52 ashimema http://www.bbc.co.uk/weather/
06:52 ashimema recognise anything ;)
06:53 ashimema The guy that developed it for us shamelessly ripped off the bbc's style and claimed it as his own..
06:54 ashimema even managed to fool my boss into thinking it was all his own original thought
06:54 ashimema ;)
06:55 dcook How 'bout that...
06:55 dcook For a second, I thought you were going to say that you were the guy in the Marilyn Monroe photo ;)
06:55 dcook Took me a couple of seconds before I was pretty sure that wasn't what you meant :p
06:56 dcook I actually saw some students on the bus this morning copying each other's homework
06:56 dcook I guess some things don't change?
06:57 ashimema haha.
07:02 alex_a bonjour
07:14 fridolin1 re
07:44 cait hi #koha
07:46 dcook yo cait ;)
07:46 * dcook should run...
07:46 dcook For a bus :)
07:53 dcook I think I had a brainwave for bug 12477
07:53 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 major, P5 - low, ---, gmcharlt, NEW , We need better ways to manage MARC Frameworks
07:53 dcook Data from the MARC spec in one XML file...Koha data in an XSLT...transform the XML using the Koha XSLT to create a "Koha MARC Framework"
07:54 dcook Most of the data in the end will only need default values of blank or null... which should mean it would be easier to manage exceptions in the XSLT
07:55 dcook It would still mostly just be useful for creating frameworks for new instances...as you don't want to automatically update existing frameworks (yet)...
07:55 dcook But I can work on that update idea later
07:55 * dcook 's head buzzes
07:56 dcook Time to go drink wine!
08:41 cait ashimema: still around?
08:42 ashimema I am..
08:42 cait ..? :)
09:13 * ashimema is starting to get the hang of shibboleth... multi-tenant shibboleth upon multi-tenant koha from packages.. tick
10:23 cait matts: around?
12:07 matts cait, yep, around
12:10 * magnuse waves
12:15 oleonard Hi everyone
12:19 nengard hiya oleonard
12:20 tcohen morning!
12:20 wahanui somebody said morning was a state of the cait
12:20 tcohen hi oleonard
12:29 tcohen magnuse: have you tried changing normarc to unimarc in those lines?
12:29 tcohen sorry, in this file: normarc-retrieval-info-auth-dom.xml
12:30 tcohen it seems that there isn't a 'normarc' marc_def for authorities
12:31 tcohen which makes sense if there aren't normarc authorities
12:37 magnuse yup, there is no normarc format for authorities
12:38 magnuse i just created a brand new instance on the same server, and searching works for that instance
12:38 magnuse so now i just have to figure out what the difference between the upgraded instance and the fresh one is...
12:41 tcohen it is important to spot it
12:43 cait magnuse++ .)
12:44 magnuse well, the obvious thing is that the old one is grs1 and the new one is dom, but grs1 ought to still work, i guess?
12:44 tcohen it is deprecated, but it should work
12:45 magnuse yeah
12:45 cait hm not officially deprecated i think :)
12:46 tcohen "not default" heh
12:46 cait something we can deprecate next dev meeting heh
12:46 cait i like deprecating thigns
12:46 tcohen we can deprecate it as long as we provide some grs1->dom scripts for moving people
12:47 magnuse for the packages, there should be some way to upgrade koha-conf.xml
12:47 magnuse deprecate all the things!
12:47 cait magnuse: yep1
12:47 * tcohen fears get deprecated
12:47 ashimema +1 to depricating stuff
12:47 cait tcohen: no worries :)
12:48 cait i have added a card to the trello
12:48 magnuse the <config> part of koha-conf.xml is much shorter in the old file versus the new one
12:48 cait someone please tell me ot go make slides?
12:48 magnuse kf?
12:48 wahanui hmmm... kf is very interested in accessibility
12:48 ashimema so the trello stuff did take off then
12:48 magnuse kf?
12:48 wahanui kf is cait or really, really sweet. or <reply>she gives me memory loss or a holds expert.
12:48 magnuse kf?
12:48 wahanui it has been said that kf is very interested in accessibility
12:48 magnuse kf?
12:48 wahanui kf is cait or really, really sweet. or <reply>she gives me memory loss or a holds expert.
12:48 magnuse kf?
12:48 wahanui i think kf is very interested in accessibility
12:48 cait slides?
12:48 wahanui kf should be writing slides
12:48 cait ;)
12:48 magnuse ah!
12:48 tcohen cait: go make slides now
12:48 oleonard wahanui never said anything about cait though
12:48 wahanui oleonard: what?
12:49 magnuse true
12:49 tcohen cait?
12:49 wahanui cait: go to bed
12:49 magnuse but some of us suspect kf and cait of being one and the same person
12:49 tcohen no no
12:49 tcohen make slides
12:49 magnuse have you ever seen them in a room together?
12:51 cait lol
12:51 cait @seen kf
12:51 huginn cait: kf was last seen in #koha 21 weeks, 6 days, 19 hours, 32 minutes, and 45 seconds ago: <kf> bye all :)
12:51 ashimema tcohen.. are the trello boards public anywhere.. I'd be interested in keeping up with current development too ;)
12:51 tcohen they are
12:52 tcohen i've just addded you :-D
12:52 ashimema aha.. you just added me..
12:52 ashimema thnaks ;)
12:53 magnuse i can haz added too?
12:53 * magnuse is curious
12:53 magnuse or is it just for qa?
12:54 tcohen you're banned magnuse
12:54 tcohen magnuse: should i use your gmail address?
12:55 cait matts: still around? was at lunch
12:56 magnuse yeah, please ban my gmail address ;-)
12:57 matts hello cait
12:57 matts yep, still there
12:57 cait just wnated to ask about the cas server
12:57 cait :)
13:01 * magnuse wonders how hard it would be to create a script that can read an old koha-conf.xml and generate a new one with values from the old one + defaults or placeholders or something for the new one
13:01 druthb magnuse: Since it's in XML, that shouldn't be too hard.
13:02 matts cait, yep, I saw your email, and at first look, it's a pretty unusual error message to me
13:02 matts I didn't have a chance to look at it precisely
13:02 cait matts: unusual is not good
13:02 druthb Parse the XML into a hash, check to see if the values you need to add are already in there (do nothing if so), and then add what's needed.
13:02 cait but you saw the mail, i will just wait for you to get t it
13:02 * magnuse thinks druthb just volunteered ;-)
13:02 druthb nope.
13:02 magnuse dang :-)
13:02 matts cait, indeed, it's not :) I'll try to have a closer look at it soon
13:03 druthb I've been doing that sort of thing in JSON, here at cPanel.
13:03 cait matts: i won't have that server much longer - so was hoping to get it done soonish :)
13:04 matts cait, ok, I hopefully will be able to look at it soon
13:04 cait matts: i had rented it for aworkshop, i think maybe another 4 weeks, but have to find out the exact date
13:07 magnuse hm, is koha-conf.xml updated when you do "make upgrade" (or whatever it is called) on a dev install?
13:07 magnuse i know other config-files are updated, but maybe not koha-conf.xml?
13:08 jcamins Yes.
13:08 jcamins Rewritten, actually.
13:08 magnuse cool
13:08 jcamins So you can't change the password by hand then expect it to work after a make upgrade.
13:08 ashimema indeed
13:08 magnuse might be possible to reuse that for the packages then?
13:09 ashimema I've thought about that issue a umber of times magnuse.
13:09 magnuse cool
13:09 ashimema I'de rather not 'clobber' config really..
13:09 magnuse yeah, there is some risk involved
13:09 ashimema make upgrade copies the old config to a backup, and just writes a new one using the recorded value from first insall time.
13:09 magnuse but having lots of different versions of config files is nt good either
13:10 magnuse ah, that is not optimal
13:10 ashimema would be far better to read existing config into hash as you say, then read that back into a new default template during updated instead
13:10 magnuse yeah, sounds like a plan
13:11 ashimema should be 'relatively' straight froward I would think too..
13:11 magnuse i'll report a bug at least
13:11 ashimema though I have no idea how it would fit in with the way debian packages do upgrades..
13:12 ashimema changing config files during a debian upgrade always seems a bit hit or miss to me.. it's often pretty nasty.
13:13 ashimema for instance when we added a template koha-sites.conf file to the packages, the upgrade after it wanted to clobber my existing one..
13:13 ashimema deb's package manager didn't handle it too well really.
13:16 ashimema https://www.debian.org/doc/debian-policy/ap-pkg-conffiles.html
13:16 ashimema E.2 sounds like what we want
13:16 * ashimema scarpers before someone see's that as volunteering to do it
13:20 magnuse Bug 12584
13:20 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 normal, P5 - low, ---, koha-bugs, NEW , koha-conf.xml for package installations get out of sync
13:20 jcamins Wow, nice of ashimena to volunteer!
13:20 magnuse yeah, ashimema++
13:21 magnuse ;-)
13:21 * magnuse knows too little about debian too
13:22 magnuse oh well, time to run
13:22 ashimema ;)
13:22 magnuse later today i will try and copy the new config to the old instance, change to the proper passwords etc and see if that actually fixes things
13:22 magnuse have fun #koha!
13:41 oleonard Anyone else getting an error when searching by tag in the OPAC?
13:42 oleonard Can't locate YAML/XS.pm in @INC
13:50 jcamins oleonard: what's the new validation plugin we're using for e-mails called?
13:51 oleonard I don't know about a new e-mail specific validation plugin
13:52 jcamins oleonard: I thought you'd selected a new general-purpose jQuery validation plugin that was also being used for e-mail.
13:52 oleonard That is jquery.validate.min.js in the staff client
13:52 jcamins *addresses
13:52 jcamins Oh, just jquery.validate? I already knew about that one. Never mind!
13:53 oleonard If it's being used to validate email addresses somewhere I'm not aware of it
13:53 jcamins I guess I didn't miss anything. :)
13:56 jcamins Thanks.
14:00 tcohen the importance of LTS: http://bit.ly/1p8hh4T
14:05 oleonard Looks like tag searches in the OPAC don't work with UseQueryParser turned on.
14:07 matts cait, just replied to your email
14:09 oleonard jcamins: http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?tag=crafts&q=crafts
14:11 jcamins oleonard: that's unfortunate.
14:11 oleonard :)
14:12 jcamins Though I can't help but wonder if perhaps the problem there is that YAML::XS isn't installed.
14:13 jcamins (even though YAML is configured to use it)
14:13 Joubu jcamins: maybe you was thinking about bug 8000?
14:13 jcamins (apparently)
14:13 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 enhancement, P5 - low, ---, philippe.blouin, Needs Signoff , Test mode for notices
14:13 Joubu Email::Valid, but it's not a js plugin :)
14:13 jcamins Joubu: I was, and you're right, that doesn't help on the form input.
14:15 huginn New commit(s) needsignoff: [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536>
14:16 oleonard jcamins: Then the question is: If YAML::XS isn't installed but should be, why have I not been prompted to do so?
14:18 jcamins oleonard: no idea.
14:19 jcamins Koha doesn't use YAML::XS directly at any point.
14:22 Joubu oleonard: I don't see any place where YAML::XS would be used
14:23 jcamins Joubu: I think it's included by YAML when available.
14:26 Joubu jcamins: hum, ok.
14:27 oleonard I filed Bug 12585 if anyone has anything to add -- for instance a patch ;)
14:27 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12585 major, P5 - low, ---, gmcharlt, NEW , Tag searching broken if QueryParser is turned on
14:27 Joubu oleonard: what do you mean by "searching by tag"? If I click on a tag (opac-tags), I get results. And I don't have YAML::XS isntalled
14:27 oleonard Is QueryParser on or off Joubu?
14:27 Joubu off
14:28 Joubu oleonard: ok, got it
14:45 tcohen oleonard: grep -R "use YAML" * => no YAML::XS dependency
14:45 oleonard You'll have to tell the tag search that :P
14:46 tcohen :-P
14:51 oleonard Looks like we need a template plugin for showing patron category
14:53 Joubu oleonard: I added one yesterday :)
14:53 oleonard \o/
14:55 Joubu oleonard: bug 7380: I used it to display the category dropdown list
14:55 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Can't filter patron search on detail page
15:05 nengard I'm going blind, didn't we have a report like this for numerica call numbers? http://wiki.koha-community.org/wiki/SQL_Reports_Library#Count_of_Circ_by_Alpha_Call_Number_Prefix
15:16 oleonard everyone++ # for writing commit messages that are so much better than they were in 2007.
15:22 reiveune bye
15:43 jcamins oleonard: in fact, we don't validate e-mail addresses at all. I hadn't realized that.
15:44 oleonard "at all" meaning not on the client side or server side?
15:44 jcamins Neither.
15:44 wahanui it has been said that neither is running out of time and beeing a nolifer because of all the zebra problems...
15:44 jcamins I just saved a user with the e-mail address asdlkjsdaflkj or something like that.
15:51 oleonard Sine the jquery validation plugin is now included by default in the staff client it would be easy to add email validation
15:51 oleonard What is Email::Valid being used for if not server-side email validation?
15:56 jcamins oleonard: validating e-mails other than ones that I find myself entering, I guess. I didn't do an exhaustive search.
15:57 jcamins I was trying to figure out how I caused a regression without noticing any e-mail address validation. Answer: I didn't.
16:01 ashimema tcohen.. do you need different rights in trello to be able to comment on a card?
16:01 ashimema wonering if commenting is locked for a reason ;)
16:14 gaetan_B bye!
16:16 jcamins Oh, wow. There is a rumor that Amazon is offering a Netflix-style subscription service for Kindle ebooks.
16:19 tcohen ashimema: you need to add yourself to the board
16:19 tcohen i can do it for you, which board?
16:20 ashimema i didn't know you could add yourself..
16:20 tcohen i'm not sure actually
16:20 ashimema it's the Zebra /Search re-factoring one i'm interested in at the minute.
16:21 ashimema my feeling is that dcook hasn't got a grasp on where QP fits in ;)
16:21 ashimema Cheers
16:21 tcohen you're in
16:22 ashimema brill.. they appear under my trello more easily now too.
16:22 ashimema Thanks tcohen.
16:35 tcohen thanks to you for joining the discussion actually
16:52 tcohen cait?
16:52 wahanui cait: go to bed
17:05 tcohen I like oleonard's bug-wrangler mode
17:12 magnuse bag: HI
17:43 tcohen hi magnuse
17:52 magnuse hiya tcohen
17:57 magnuse i tried copying koha-conf.xml from a newly created instance (with working search) to an old, upgraded instance + adjusting the config to account for the instance name, passwords etc. the result was...
17:57 pastebot "magnuse" at 127.0.0.1 pasted "not quite what i was hoping for..." (288 lines) at http://paste.koha-community.org/106
18:02 tcohen try elem marcxml
18:03 tcohen base biblios; format xml ; elem marcxml
18:05 magnuse tcohen: ah yes, that works
18:05 tcohen :-D
18:06 magnuse but searching from koha still does not work
18:07 tcohen new instance + load db dump + koha-rebuild-zebra -f works?
18:07 magnuse i'll try...
18:11 magnuse tcohen: yes, that works
18:11 magnuse so some config somewhere...
18:12 tcohen so db (sysprefs, options) excluded from the checklist
18:17 magnuse huh, i tested tht on the wrong instance - the old instance works now...
18:17 magnuse woohoo!
18:17 magnuse but did i change anything between it working and not?
18:18 tcohen Koha is a box full of surprises, it seems
18:18 magnuse hehe
18:25 tcohen oh, carrie still sends me love letters :-P
18:28 oleonard Oh no I thought I was the only one!
18:28 * oleonard 's heart breaks
18:28 * tcohen heart breaks symetrically
18:45 * magnuse marks bug 12577 as a duplicate of bug 12584
18:45 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12577 major, P5 - low, ---, gmcharlt, RESOLVED DUPLICATE, Search is broken after upgrade from 3.14.7 to 3.16.1
18:45 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 normal, P5 - low, ---, koha-bugs, NEW , koha-conf.xml for package installations get out of sync
19:58 cait hola #koha
20:04 barton where is the environment set for C4::Context among the unit tests?
20:05 barton specifically, someone is asking about '$dbh->do("DELETE FROM reserves");' in t/db_dependent/Holds/RevertWaitingStatus.t -- I'm trying to prove to myself that won't delete a live reserves table :-)
20:06 cait i am not sure it has to do with the environment
20:06 cait what you are looking for is the rollback
20:06 cait we don't actually commit the changes
20:06 cait and it leeaves the database unchanged
20:07 barton aha.
20:07 cait it's a few lines at the beginning of the test file that you are looking for
20:09 barton ah, so it's the '$dbh->{AutoCommit} = 0;' that does the magic... or doesn't do the magic, as the case may be.
20:10 pianohacker another reason not to do it on a live table is that, from what I've seen, if the test fails for some internal reason, the rollback at the end won't go through
20:10 pianohacker so you're playing with fire
20:11 rangi but neither will the commit pianohacker
20:12 rangi we should be doing start transaction
20:12 rangi begin
20:12 rangi to be more explicit
20:12 rangi but setting autocommit=0 does that implicitly
20:13 rangi no changes are committed to disk, unless you do a commit;
20:13 pianohacker rangi: I've seen the changes within the test script go through if there's an internal exception. Granted, it was circ code, so who knows what was going on
20:14 rangi wont work if its a non transactional table, like myisam
20:14 pianohacker that was probably it
20:14 cait and maybe old tests? i think reserves works pretty well
20:15 cait tomas fixed suggestion.t that did leavesomething in the database yesterday
20:15 cait but it was not using the autocommit 0
20:15 rangi yeah some old tests dont to autocommit=0
20:15 rangi yeah
21:01 magnuse wip for a quick fix for bug 12584: https://github.com/MagnusEnger/fix-koha-conf - hope to get the fixmes done tomorrow
21:01 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 normal, P5 - low, ---, koha-bugs, NEW , koha-conf.xml for package installations get out of sync
21:02 rangi cool!
21:03 magnuse it's very ad hoc, but i hope to be able to upgrade my customers with it, at least
21:03 wizzyrea oh nice one
21:11 magnuse have fun #koha!
21:50 WNickC hello all
21:50 WNickC I was wondering, if I am testing patches in a git clone and run updatedatabse.pl, do I have to do something to revert those changes when moving on to a new patch?
21:51 cait WNickC: if you are testing in a clone you can do a mysqldump before running updatedatabase
21:51 cait the changes won't get undone
21:51 cait for a syspref it's not a big problem
21:51 cait but if you test something that changes tables/moves data, that can be a problem
21:52 WNickC I suspected the answer would be something like that
21:54 WNickC thanks
22:15 eythian hi
22:37 tcohen hi eythian
22:38 Dyrcona rangi: I'm working on Evergreen's handling of lookupuser and there doesn't appear to be anyway to tell if a patron is blocked in the generic NCIP::User and the main NCIP code.
22:40 rangi yeah, im having issues with that, because in Koha there is a debarrment .. thats a full you are blocked from doing everything type thing
22:40 rangi and I could pass that through easily
22:40 rangi however, there are a myriad of conditional blocks too
22:40 rangi i guess passing through something is better than nothing, even tho it might say no blocked, then you try a checkout and find out they are blocked for that itemtype
22:41 BobB mtj about
22:41 BobB ?
22:42 Dyrcona Well, Evergreen has a similar situation.
22:42 Dyrcona I was just going to say blocked if you're barred, or blocked from circ and/or holds.
22:42 rangi right
22:42 rangi that'd work
22:42 rangi and then conditional ones show up if you blocked from certain holds, or certain circ cases
22:43 Dyrcona Well, in Evergreen, you get blocked from circ (checkout), holds (placing holds), or renewals. Most blocks block all three.
22:44 Dyrcona I was just going to say blocked if anything blocked at all.
22:45 rangi right, we have that
22:45 Dyrcona We also have a "Local Use Only" patron profile in our system, so I've added configuration to allow certain profiles to come up blocked.
22:45 Dyrcona We don't want local patrons asking for ILL.
22:45 rangi but there are still cases when you are only blocked from certain itemtypes
22:45 rangi which you dont know, as at that point you dont know what the next request is going to be
22:46 Dyrcona We don't have blocks on certain items, just matchpoints that might restrict the flow of different items from one library to another.
22:46 Dyrcona What I'll do is add a way for the user data to report a blocked patron, and you can figure out the Koha implications. ;)
22:47 rangi yep
22:49 tcohen hi rangi
22:49 rangi hiya
22:50 tcohen i was thinking we should have a debian7+mariadb node
22:51 rangi gmcharlt had one going, i think the node is still there, just needs to be updated
22:52 tcohen ok, I'll talk with him
23:28 tcohen rangi: what command should be used to find cases for bug 6679?
23:28 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 minor, P1 - high, ---, mtj, ASSIGNED , Fixing code so it passes basic Perl::Critic tests
23:28 tcohen perlcritic -5 ?
23:29 rangi tcohen: look at the 00-testcritc.t file
23:29 rangi add another dir, from the all_koha_dirs ito the @dirs variable
23:30 rangi and you will find tons :)
23:33 tcohen C4 has a reasonable amount
23:34 rangi yep
23:34 rangi its a good task for someone new
23:34 rangi they learn their way around the code base, and you can google for how to fix the errors
23:35 tcohen interesting, i have a librarian interested
23:36 rangi and they dont need to have a full running koha, just a git checkout is good enough to start with on the small ones
23:36 tcohen i'll think about it
23:36 tcohen question: have you tried to use warnings on all files? is it that bad?
23:37 rangi yeah its too noisy
23:37 rangi but you can do one by one without too much hassle
23:37 rangi turn on, fix until its quiet
23:37 rangi papa was doing some work trying to quiet the log
23:38 tcohen yeah, I recall
23:38 tcohen it might be a good excercise for a hackfest
23:38 rangi yep
23:38 rangi good teaching tool
23:38 * tcohen thinks rangi is a good teacher :-P
23:39 tcohen people will enjoy it :-D
23:40 rangi :)
23:44 tcohen could anyone take a look at 11349? it is pretty trivial
23:44 eythian @later tell magnuse http://terrafab.bengler.no/
23:44 huginn eythian: The operation succeeded.
23:44 rangi yep can do
23:48 tcohen oops, my turn for making dinner
23:48 tcohen completely forgot :_D
23:48 tcohen bye rangi, eythian
23:48 eythian later
23:48 rangi cya
23:58 pianohacker bye