Time Nick Message
23:46 dcook Did get a conflict on the updatedatabase.pl, but then I noticed that my commit for that script was bad anyway...
23:46 dcook That automated gitbot is kinda handy
23:46 dcook rangi++
22:13 mtompset Bye, tcohen. :)
22:12 tcohen bye #koha
22:09 mtompset I forgot to ask her something.
22:09 mtompset NOOOO!
21:53 jcamins That and this one: http://wiki.koha-community.org/wiki/Troubleshooting_Koha_as_a_Z39.50_server
21:53 JoeLib001 Thanks.
21:52 jcamins Of course.
21:52 wahanui understanding zebra indexing is http://wiki.koha-community.org/wiki/Understanding_Zebra_indexing
21:52 jcamins understanding zebra indexing?
21:52 jcamins Apparently wahanui doesn't have the link.
21:52 wahanui yaz-client is http://www.indexdata.com/yaz/doc/yaz-client.html
21:52 jcamins yaz-client?
21:52 wahanui somebody said searching was not working
21:52 jcamins searching?
21:52 wahanui indexing is done by Zebra.
21:52 jcamins indexing?
21:52 jcamins understanding indexing?
21:52 jcamins Ummm...
21:51 jcamins understanding z39.50?
21:51 wahanui well, z39.50 is the ANSI standard of the beast.
21:51 jcamins z39.50?
21:51 wahanui zebra is a fielded free text indexing and retrieval engine with a Z39.50 front-end. You can use any compatible, commercial, or freeware Z39.50 client to access data stored in Zebra. or the search engine koha uses
21:51 jcamins zebra?
21:51 JoeLib001 Yeah.
21:51 jcamins understanding zebra?
21:51 JoeLib001 Ah, ok. Is there a document on the interwebs that I can read up on Koha's Z39.50 stuff. XD
21:50 jcamins biblioserver is going to be via a unix socket.
21:50 jcamins No, that's the publicserver.
21:50 JoeLib001 I think I connected to the biblio server. I entered: open localhost:9999/biblios
21:49 jcamins Does it work there?
21:49 jcamins Try connecting to your biblioserver instead of publicserver.
21:48 jcamins Hmm.
21:48 JoeLib001 Number of hits: 0, setno 4 SearchResult-1: term=systematic cnt=2, term=theology cnt=54, term=creation cnt=16
21:48 rangi in airports and planes
21:47 rangi so its 21 hours ish
21:47 rangi wellington 4pm is 8pm the day before
21:47 jcamins JoeLib001: odd...
21:47 JoeLib001 jcamins: That returned 0 hits too.
21:46 wahanui OK, eythian.
21:46 eythian wahanui: internet explorer is https://fbcdn-sphotos-d-a.akamaihd.net/hphotos-ak-prn2/1236471_10151582918166526_280952799_n.png
21:46 wahanui eythian: sorry...
21:46 eythian wahanui: internet explorer
21:46 wahanui salut, eythian
21:46 eythian hi wahanui
21:44 jcamins weird.
21:44 jcamins ...
21:44 mtompset Probably 24h 55m then, including any stop overs.
21:44 rangi reno time
21:44 rangi and land at 4.55pm on hte 13th
21:44 rangi i start at 4pm on the 13th nz time
21:43 jcamins From here to Ibadan is 20 hours, 13 hours flight time.
21:43 rangi the timezones make it hard to figure out
21:43 rangi yeah im not sure how much time in total it takes
21:42 jcamins From here to Cordoba is 13-14 hours. 11 hours flight time.
21:41 rangi its certainly a lot shorter than edinburgh last year
21:40 tcohen 1:30+10:15+3:30
21:40 rangi then 55 min to reno
21:40 rangi akl->sfo = 12 or 13 depending on winds
21:40 jcamins Not that I'd want to do it.
21:40 rangi wlg->akl is 1 hour
21:40 jcamins Wow. That seems surprisingly short.
21:40 rangi and some time in airports
21:40 rangi yep
21:40 jcamins rangi: really?
21:39 eythian hi
21:39 rangi and its only a 1 hour flight, then 13 hr flight, then another 1 hour one
21:39 gmcharlt :)
21:39 rangi ahh ive learnt, im arriving on the 13th
21:38 gmcharlt rangi: question is, how much of a zombie will you be by that point? ;)
21:37 jcamins Most likely it's just a matter of switching which attributes you're using over Z39.50.
21:37 JoeLib001 Ok, I will give that a try.
21:37 tcohen thats great rangi!
21:37 jcamins I think.
21:37 jcamins (in yaz-client)
21:36 jcamins This search should work: f @attr 1=1016 "systematic theology creation"
21:36 rangi ahh sweet, ill be there by then :)
21:36 JoeLib001 What is the alternative? Just searching by ISBN?
21:36 jcamins So what you're going to need to do is not use phrase searches.
21:35 JoeLib001 Hmm..., that sucks. XD
21:34 cait woohoo
21:34 cait tcohen: flights booked?
21:34 tcohen RENO, NV (TAHOE INTL) 15 OCT 10:25
21:34 jcamins So a phrase search for "Systematic theology" will work, since that's one subfield, but a phrase search for "Systematic theology creation" will not, because that's two.
21:34 tcohen DALLAS, TX (DALLAS FT WORTH INTL) 15 OCT 08:55
21:34 tcohen rangi: 10:25
21:34 jcamins Phrase searching is used for full-subfield searching.
21:33 rangi tcohen: what time do you arrive in reno?
21:33 mtompset (in terms of data)
21:33 jcamins mtompset: no idea.
21:33 mtompset What does 'd' do in yaz-client?
21:33 mtompset Oops...
21:33 JoeLib001 Why not and can I do something about it? Reasonably without days or weeks of effort. XD
21:32 jcamins Especially not with GRS-1, which I believe is what you're using.
21:32 jcamins Phrase searching will not do what you expect.
21:31 JoeLib001 Ok.
21:31 jcamins But I wanted to check that I was following along -- sort of -- before offering my two cents.
21:31 JoeLib001 Yeah, keyword search didn't come up with it when I tested with the yaz-client.
21:30 jcamins As it happens, a title search isn't going to work either.
21:30 JoeLib001 Ahh...
21:30 jcamins So, keyword search.
21:30 JoeLib001 Ok, I probably don't know the difference. XD
21:29 mtompset [off] tcohen, I think you mean Christ, not chris. Hence, rangi's comment. :)
21:29 JoeLib001 without my typos. XD
21:29 jcamins JoeLib001: but you said you tried a title search?
21:29 JoeLib001 jcamins: find "Systematic Theolgoy" comes up with a ht
21:29 rangi hmm yeah, dont do that :-)
21:29 JoeLib001 rangi: Would that mess something up, if I tried it from my production server?
21:29 jcamins JoeLib001: what search did you do in yaz-client?
21:28 tcohen are u in grs or dom setup JoeLib001 ?
21:28 rangi JoeLib001: id run zebrasrv from the commandline, and then try a title search in koha, and see the string it is using to search
21:27 JoeLib001 rangi: that would make sense.
21:27 rangi [off] it better not, im busy enough as it is
21:27 tcohen [off] touche mtompset, indeed, zebra is not matching chris with salvation :-P
21:26 JoeLib001 Yeah, I started reading the Z39.50 Standards and didn't find anything relating to subtitles and gave up. XD
21:26 rangi much more likely we have not told zebra that subtitle is part of title
21:26 tcohen i'm sorry JoeLib001, i know too little about searching algorithms inside zebra
21:26 mtompset [off] Or just not a Christian, tcohen. :P
21:25 JoeLib001 Well, zebrasrv didn't like Gettysburg either. XD
21:25 JoeLib001 Hehehe. ;-)
21:25 tcohen [off] maybe zebrasrv is an atheist
21:24 rangi back
21:24 JoeLib001 I have tried a few other titles that have subtitles and I get the same result.
21:24 mtompset Don't mind me... I'm trying to refresh my memory with this stuff. :)
21:23 JoeLib001 My bad the example shows: Example: 245#aSystematic Theology :#bcreation, Christ, salvation /
21:22 JoeLib001 I do the following searches and I get no hits. "Systematic Theology :creation", "Systematic Theology : creation", "Systematic Theology creation", "Systematic Theology :creation, Christ, salvation".
21:21 JoeLib001 I do a search for "Systematic Theology" and I get a hit.
21:21 JoeLib001 Yeah, ok. Ignore the space after the a. XD
21:20 JoeLib001 I tried using the yaz-client as well. It still comes up 0.
21:20 mtompset or was that yaz-client?
21:20 JoeLib001 Example: 245#a Systematic Theology :#bcreation, Christ, salvation
21:20 mtompset did you check that it was working with yaz first?
21:19 JoeLib001 I do not get any hits when I do a title search with subtitles when I do a title search of my Koha's Database via Z39.50.
21:18 mtompset Greetings, cait.
21:18 JoeLib001 Hehe. :-)
21:18 JoeLib001 Well, more of a Z39.50 server problem... or something...
21:18 mtompset No, but ask anyways? :) I don't guarantee I'll know. :)
21:17 * cait waves
21:17 JoeLib001 Hello. :-) I have a Z39.50 Server question. Anyone up for it?
21:13 tcohen sigh
21:12 huginn` tcohen: cait was last seen in #koha 14 hours, 33 minutes, and 29 seconds ago: <cait> bbiab
21:12 tcohen @seen cait
21:01 drojf well, unless the part where my patch needs attention :P
21:00 drojf cool
21:00 jcamins Yep.
21:00 drojf what's the gitbot? a bot checking if patches need to be rebased?
20:46 tcohen and if authid -> one else -> the other
20:45 tcohen other way could be just hardcoding those URLs in the .inc
20:45 jcamins tcohen: that seems reasonable.
20:45 tcohen and choosing inside that function?
20:45 tcohen jcamins: what do u think of passing search_link and exact_link to the authresult process?
20:38 jcamins Yeah, I think so.
20:36 tcohen is it ok if i mark failed-qa with a proper message?
20:34 tcohen networking problems
20:26 oleonard Bye #koha
20:24 tcohen ok, not complete solution i guess
20:24 tcohen my patch only made th e authid part
20:23 jcamins Yeah.
20:23 tcohen it should fallback to generic search?
20:23 jcamins It should just be a search.
20:22 tcohen what if the authority record doesn't have a RLIN for the 'see also' or 'see from' (i.e. just plain text)
20:22 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 normal, P5 - low, ---, tomascohen, Needs Signoff , 5xx not properly linked by authid in authority search result list
20:22 tcohen have a question about bug 10691
20:22 jcamins I am.
20:19 tcohen jcamins around?
20:17 rambutan [off]Interesting read: http://www.roganhamby.com/
20:15 druthb :D
20:15 drojf druthb! :)
20:13 druthb Hi, drojf!
20:12 drojf good evening #koha
20:04 rangi now time to take the kids to school
20:03 oleonard rangi++
20:03 jcamins Nice!
20:02 rangi theres the little script i hacked up, pull requests welcomed
20:01 rangi https://gitorious.org/koha-git-tester
19:32 rangi its simple, but works nicely
19:31 rangi jcamins: yup
19:31 rangi ill clean it up a little and push it
19:31 jcamins Git::Repository == wrapper around git binary?
19:30 rangi it uses www::mechanize to get the full xml of the bug too, so it can see dependencies, and could make integration branch and apply dependencies too
19:29 pastebot "rangi" at 127.0.0.1 pasted "the main logic of the bot" (21 lines) at http://paste.koha-community.org/219
19:26 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Add a counter on batch items modifications
19:26 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Uncheck on loan items on the batch item modification tool
19:26 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 normal, P5 - low, ---, m.de.rooy, Pushed to Master , Printing cart does not work under IE9
19:26 jenkins_koha * Galen Charlton: Bug 10601: (follow-up) improvements to ->set() and ->get()
19:26 jenkins_koha * Galen Charlton: Bug 10601: (follow-up) unit tests for new ->set() and ->get()
19:26 jenkins_koha * Kyle M Hall: Bug 10601 [QA Followup] fix POD error
19:26 jenkins_koha * Jonathan Druart: Bug 10601: Add a counter on batch items modifications
19:26 jenkins_koha * Galen Charlton: Bug 10599: (follow-up) fix incomplete test case
19:26 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move JavaScript out of circulation template
19:26 jenkins_koha * Jonathan Druart: Bug 10599: add option to unselect on loan items on the batch item modification tool
19:26 jenkins_koha * Marcel de Rooy: Bug 10376: fix ability to print cart from IE9 & 10
19:26 jenkins_koha * Jonathan Druart: Bug 9294: Followup : add missing lines.
19:26 jenkins_koha * Owen Leonard: Bug 9294 - Move JavaScript out of circulation template
19:26 jenkins_koha Project Koha_master build #1426: SUCCESS in 1 hr 33 min: http://jenkins.koha-community.org/job/Koha_master/1426/
19:25 jcamins So probably if I tried this on a server that I'd consider actually running in production it'd do better.
19:24 rangi ah yeah, that makes sense, it reduces the RAM overhead a lot
19:24 jcamins I have 620mb of RAM free, but CPU is stuck at 100%.
19:23 jcamins rangi: actually, I just noticed something interesting. With Starman the limiting factor is CPU not memory.
19:19 jcamins Yeah, with 1.7GB/RAM and the worst I/O performance I have ever seen, I wasn't expecting anything much from this server.
19:17 rangi its pretty much a function of ram
19:08 jcamins For anyone thinking of running 50 simultaneous connections against a small server, I'd recommend against that, too.
18:51 jcamins oleonard: no, a Windows Azure "small" instance is a baby server.
18:50 oleonard Starman = "baby server?"
18:47 jcamins And I probably would not use a baby server for a library system with that many simultaneous users.
18:47 oleonard But fewer than the number of cloned superlibrarians jcamins has growing in vats in his lab
18:47 jcamins Yes.
18:46 rambutan That would be a heck of a lot of circ terminals
18:45 jcamins However, neither Apache nor Starman can handle 100 simultaneous connections.
18:45 rambutan long live Starman!
18:44 jcamins rambutan: by a lot.
18:44 rambutan Starman wins!
18:33 jcamins If anyone is interested in seeing some performance statistics I just collected on Apache vs Plack: http://paste.koha-community.org/218
18:26 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Add a counter on batch items modifications
18:26 jenkins_koha * Galen Charlton: Bug 10601: (follow-up) improvements to ->set() and ->get()
18:26 jenkins_koha * Galen Charlton: Bug 10601: (follow-up) unit tests for new ->set() and ->get()
18:26 jenkins_koha * Kyle M Hall: Bug 10601 [QA Followup] fix POD error
18:26 jenkins_koha * Jonathan Druart: Bug 10601: Add a counter on batch items modifications
18:26 jenkins_koha Project master_maria build #109: SUCCESS in 44 min: http://jenkins.koha-community.org/job/master_maria/109/
17:53 jenkins_koha Starting build #1426 for job Koha_master (previous build: SUCCESS)
17:52 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 minor, P5 - low, ---, kyle, Pushed to Master , IntranetSlipPrinterJS is not working for hold slips
17:52 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 normal, P5 - low, ---, mtompset, Pushed to Master , Fix opac-MARCdetail.pl partial hides
17:52 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 minor, P5 - low, ---, mtompset, Pushed to Master , C4::Items GetHiddenItems fix and optimization
17:52 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 enhancement, P5 - low, ---, mtompset, Pushed to Master , Hide OPAC bibilo details if all items are hidden.
17:52 jenkins_koha * Kyle M Hall: Bug 10731: fix use of IntranetSlipPrinterJS by hold slips
17:52 jenkins_koha * Mark Tompsett: Bug 10876: Fix opac-MARCdetail.pl displaying items that are meant to be hidden
17:52 jenkins_koha * Tomas Cohen Arazi: Bug 10872: UT for GetHiddenItemnumbers and POD fix
17:52 jenkins_koha * Mark Tompsett: Bug 10872 - C4::Items GetHiddenItems fix and optimization
17:52 jenkins_koha * Mark Tompsett: Bug 10584 - Hide OPAC biblio details if all items are hidden
17:52 jenkins_koha Project Koha_master build #1425: SUCCESS in 1 hr 34 min: http://jenkins.koha-community.org/job/Koha_master/1425/
17:42 jenkins_koha Starting build #109 for job master_maria (previous build: SUCCESS)
17:42 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Uncheck on loan items on the batch item modification tool
17:42 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 normal, P5 - low, ---, m.de.rooy, Pushed to Master , Printing cart does not work under IE9
17:42 jenkins_koha * Galen Charlton: Bug 10599: (follow-up) fix incomplete test case
17:42 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 enhancement, P5 - low, ---, oleonard, Pushed to Master , Move JavaScript out of circulation template
17:42 jenkins_koha * Jonathan Druart: Bug 10599: add option to unselect on loan items on the batch item modification tool
17:42 jenkins_koha * Marcel de Rooy: Bug 10376: fix ability to print cart from IE9 & 10
17:42 jenkins_koha * Jonathan Druart: Bug 9294: Followup : add missing lines.
17:42 jenkins_koha * Owen Leonard: Bug 9294 - Move JavaScript out of circulation template
17:42 jenkins_koha Project master_maria build #108: SUCCESS in 43 min: http://jenkins.koha-community.org/job/master_maria/108/
17:34 huginn` New commit(s) kohagit: Bug 10601: (follow-up) improvements to ->set() and ->get() <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=72479fec404ebf446f53a1c290ac10139e65d418> / Bug 10601: (follow-up) unit tests for new ->set() and ->get() <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f4a30cc68bb633b6a990f87205f76728e27ae985> / Bug 10601 [QA Followup] fix POD error <http://git.koha-community.org/gitweb/?p=koha.git
17:31 jcamins For your server is small, and crunchy, and hates you terribly.
17:31 jcamins TIL: do not run siege with 200 concurrent clients on a small Koha server.
17:02 huginn` New commit(s) kohagit: Bug 10599: (follow-up) fix incomplete test case <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=304b8d7de3c75c0002528bcd4b142ed3340d452a>
16:59 * mtompset crosses fingers. :)
16:58 jenkins_koha Starting build #108 for job master_maria (previous build: SUCCESS)
16:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 minor, P5 - low, ---, kyle, Pushed to Master , IntranetSlipPrinterJS is not working for hold slips
16:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 normal, P5 - low, ---, mtompset, Pushed to Master , Fix opac-MARCdetail.pl partial hides
16:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 minor, P5 - low, ---, mtompset, Pushed to Master , C4::Items GetHiddenItems fix and optimization
16:58 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 enhancement, P5 - low, ---, mtompset, Pushed to Master , Hide OPAC bibilo details if all items are hidden.
16:58 jenkins_koha * Kyle M Hall: Bug 10731: fix use of IntranetSlipPrinterJS by hold slips
16:58 jenkins_koha * Mark Tompsett: Bug 10876: Fix opac-MARCdetail.pl displaying items that are meant to be hidden
16:58 jenkins_koha * Tomas Cohen Arazi: Bug 10872: UT for GetHiddenItemnumbers and POD fix
16:58 jenkins_koha * Mark Tompsett: Bug 10872 - C4::Items GetHiddenItems fix and optimization
16:58 jenkins_koha * Mark Tompsett: Bug 10584 - Hide OPAC biblio details if all items are hidden
16:58 jenkins_koha Project master_maria build #107: SUCCESS in 44 min: http://jenkins.koha-community.org/job/master_maria/107/
16:58 druthb I showed him my engagement ring, and he bemoaned the fact that The Swede wants the Star of Africa or some such expensive bauble on her finger.
16:58 bag tell him I saw him walking around SB the other day - with a surf board under his arm
16:57 druthb :P
16:57 bag poor guy
16:57 druthb bag: I just saw libsysguy in the lunch line, and made disparaging remarks about him.
16:52 huginn` New commit(s) kohagit: Bug 10599: add option to unselect on loan items on the batch item modification tool <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5ed940b18eddca2e4cd823afce2e9558b074158d>
16:48 bag hey owen
16:48 oleonard Hi bag
16:47 huginn` bag: libsysguy was last seen in #koha 3 weeks, 0 days, 4 hours, 47 minutes, and 53 seconds ago: <libsysguy> yo magnuse
16:47 bag @seen libsysguy
16:40 huginn` New commit(s) kohagit: Bug 10376: fix ability to print cart from IE9 & 10 <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=990eebf132fef94dfbac4d3e17fe7acd9ce7b2c6>
16:30 huginn` New commit(s) kohagit: Bug 9294: Followup : add missing lines. <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da9863f1a5225d3af7daac1e4874e42fbd7dd369> / Bug 9294 - Move JavaScript out of circulation template <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=249b37ef488d90d8cd9104c4d3d806f7a30590d8>
16:28 mtompset tcohen: I don't think it should directly link immediately, but that's my totally uninformed opinion. :)
16:27 tcohen thanks nengard
16:27 tcohen i'll gather some other opinions and use cases
16:26 nengard :)
16:26 wahanui okay, mtompset.
16:26 mtompset wahanui: nengard is also the queen of documentation.
16:26 nengard and if it can't do that then put it in the search field
16:26 nengard i think it should link the authority
16:26 tcohen heh
16:26 nengard sorry ... reading
16:25 wahanui nengard is fast
16:25 tcohen nengard?
16:24 mtompset gmcharlt++ # Thank you, gmcharlt. :)
16:23 tcohen should it link the authority?
16:23 tcohen should it directly trigger that search?
16:23 tcohen should it put it in the search field? (current)
16:22 tcohen what you expect to happen once you click?
16:22 tcohen your's is there, you click on it
16:22 tcohen the autocomplete feature shows a list
16:22 tcohen start typing something
16:21 tcohen you're cataloguing, and want to link an authority
16:21 nengard yup
16:20 tcohen nengard: quick question
16:20 huginn` New commit(s) kohagit: Bug 10731: fix use of IntranetSlipPrinterJS by hold slips <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=887900ba597886f8ed06943849be172131f12cee>
16:18 jenkins_koha Starting build #1425 for job Koha_master (previous build: FIXED)
16:16 nengard jcamins - nope just a weird human going in and screwing with it
16:14 jenkins_koha Starting build #107 for job master_maria (previous build: FIXED)
16:10 huginn` New commit(s) kohagit: Bug 10876: Fix opac-MARCdetail.pl displaying items that are meant to be hidden <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f072cbdf9bf35a44364c5374b8284c0583f4e262> / Bug 10872: UT for GetHiddenItemnumbers and POD fix <http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5d8ad739293ef8cf22a808404e52a9c74275aaf0> / Bug 10872 - C4::Items GetHiddenItems fix and optimization <http://git.koha-com
16:07 jcamins I thought it just randomly switched, which would be weird.
16:07 jcamins Ah.
16:06 nengard it's support to be commits I think - and not it didn't - I cleaned up some broken feeds and thought adding in new features would be a good thing
16:06 jcamins *did
16:06 jcamins Why did it suddenly start getting koha-patches e-mails? I don't think it used to, dit it?
16:04 nengard not sure why it's not doing them all though
16:04 nengard it's part of the yahoo pipe that feeds it
16:03 oleonard Do you have any idea why the kohails Twitter account is tweeting random koha-patches emails?
16:02 nengard yes
16:02 oleonard nengard around?
15:59 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 normal, P5 - low, ---, tomascohen, Needs Signoff , 5xx not properly linked by authid in authority search result list
15:59 tweetbot_ [off] @KohaILS: "#KohaILS [Koha-patches] [PATCH 2/2] Bug 10691: 5xx not properly linked by authid in… http://t.co/FWffrE8hUd"
15:36 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 minor, P5 - low, ---, tomascohen, Needs Signoff , Author tracings incorrect when UseAuthoritiesForTracings is turned on
15:36 tcohen bug 10905
15:33 tcohen only removes two quotation symbols from an xslt
15:32 tcohen volunteer for signing a really trivial patch so we have it fr 3.12.5?
15:23 reiveune bye
15:09 tcohen it is on the staff interface
15:09 tcohen (on the unimarc if's branch)
15:09 tcohen there's at least a call to a process called language that is not there :-D
15:08 jcamins tcohen: that seems probable to me.
15:08 tcohen jcamins: i still belive authorities search in UNIMARC is sort of broken
15:02 mtompset Looking at that link now. Thank you, Joubu.
15:02 jcamins tcohen: yeah, ideally.
15:02 Joubu mtompset: http://search.cpan.org/dist/DBI/DBI.pm#last_insert_id
15:01 tcohen jcamins: do u think 10691 should be fixed fr staff too?
15:01 Joubu mtompset: DBI provides a last_insert_id method
14:58 mtompset gmcharlt: any thoughts on 10454? LAST_INSERT_ID() is a MySQLism. khall is recommending avoiding MySQLisms.
14:49 mtompset "internet explorer prints all four pages properly." -- How scary is that, oleonard?
14:47 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 normal, P5 - low, ---, tomascohen, Needs Signoff , 5xx not properly linked by authid in authority search result list
14:47 tcohen bug 10691
14:46 mtompset " iframe printing broken when iframe height more than page height" -- "Reported: 2001-12-03 01:18 PST" -- "Status: NEW" WHAT?!
14:45 oleonard I knew I shouldn't have designed my Geocities page with a table layout. Now grandma can't print it out to show the bridge club.
14:43 mtompset But the data you REALLY need is on the first page anyways. ;)
14:43 oleonard gmcharlt: Maybe if pages past page 1 were nonexistent instead of blank :P
14:42 gmcharlt oleonard: Firefox is just trying to save trees? </lame_excuse>
14:42 mtompset print truncation bug?
14:42 mtompset Greetings, druthb, oleonard jcamins. :)
14:41 oleonard At the moment I'm looking at a web page on the subject from 2007, so yeah a long time.
14:41 * druthb waves to mtompset.
14:41 jcamins Ummm... a long time?
14:39 oleonard Firefox, get it together! How long have we had to deal with this stupid print truncation bug?!
14:37 mtompset gmcharlt++ # taking dependent patches into account. Good and necessary idea.
14:36 mtompset Greetings, #koha.
14:30 tcohen thanks oleonard
14:30 wahanui sandboxes are http://wiki.koha-community.org/wiki/Sandboxes
14:30 tcohen sandboxes?
14:29 oleonard tcohen: There is a sandbox with UNIMARC data isn't there?
14:26 tcohen unimarc sample koha?
14:14 tcohen thanks sophie_m
14:13 sophie_m tcohen : I can't find at the moment exemples with see also
14:11 jcamins sophie_m++ # for humoring me
14:10 jcamins That's the title for my dinner menu for Sunday. :)
14:10 tcohen the unimarc block only prints plain text, no URL
14:10 tcohen authorities-search-results.inc clearly has a IF (unimarc) ELSE END
14:10 jcamins Thanks!
14:10 sophie_m :)
14:10 sophie_m jcamins: it's not so bad :()
14:09 sophie_m on peut aussi dire de l'année
14:09 sophie_m Le premier jour de l'an (et non pas "du") jcamins
14:09 jcamins I read French okay, but I can't write it.
14:08 sophie_m ah opac
14:08 jcamins sophie_m: Is this grammatical for a title: "Le Premier Jour du l’An CCXXII de l’Ère Républicaine
14:08 jcamins Yay!
14:08 tcohen in the opac, you are presented links to see also and see from authorities (when searching authorities)?
14:08 sophie_m jcamins: ?
14:07 sophie_m yes it works
14:07 jcamins Oh. Heh.
14:07 tcohen just testing jcamins
14:07 tcohen hmmm, looks no one around :-P
14:07 jcamins Noooooo.
14:06 tcohen i'm about to break all unimarc-related authorities visualization
14:05 jcamins Any French speakers about?
14:05 jcamins Oh, that reminds me.
14:04 tcohen guys, any UNIMARC user?
13:54 tcohen any UNIMARC user?
13:53 tcohen looks like it only displays text, so no tracings
13:53 tcohen is displaying authorites search results in the opac working at all for unimarc?
13:51 jcamins Yeah, that functionality was there before and I kept it when I improved the authority display.
13:51 tcohen and 'other script'
13:51 tcohen the templates look for some 'notes' when in UNIMARC scenario
13:50 jcamins Yup.
13:49 tcohen its a strange coincidence
13:49 tcohen i've just googled eerie..
13:49 jcamins Yeah, you said "hi jcamins" seconds after I opened up the channel.
13:49 jcamins There is not.
13:49 tcohen eerie?
13:48 tcohen a question for u: is there a semantic difference between MARC and UNIMARC see also and see from fields?
13:48 jcamins Also, hi.
13:48 jcamins tcohen: that's really eerie. Does my client indicate when I open the channel?
13:48 tcohen hi jcamins
13:45 huginn` tcohen: The operation succeeded.
13:45 tcohen @later tell cait take a look at this gift http://snag.gy/6qrpz.jpg
13:12 oleonard Hi tcohen
13:11 tcohen morning #koha
12:45 Joubu :)
12:44 oleonard Joubu: rangi's bot is almost as bad as me about noticing bug dependencies ;)
12:38 magnuse "not yet" would be my guess
12:36 oleonard I wonder if the patch-doesn't-apply bot knows about bug dependencies?
12:34 magnuse ah, Data::Dumper was messing with my output...
12:31 magnuse hiya oleonard
12:26 oleonard Hi #koha
11:57 * magnuse wonders what he is doing wrong when he gets output like "Sx{f8}r-Trx{f8}ndelag"
11:21 * magnuse needs lunch
11:12 magnuse gah, encoding problems!
10:54 magnuse rangi++
10:46 rangi ill train anyone who volunteers
10:45 magnuse any plans for training more people to sign off during kohacon2013?
10:38 magnuse hehe
10:35 rangi oh wait we do have 4000 libraries
10:35 rangi if only there were about 4000 libraries using koha, maybe 1% of them could get involved in signoffs and that would be 40
10:33 kf kivilahtio_: IRC is important.
10:32 kivilahtio_ luckliy we have time to hang around in the IRC!
10:31 * kf too
10:31 rangi i know that feeling
10:31 magnuse if only i had the time...
10:20 rangi it is just the 4 qa follow ups that need signoff, so if someone wanted to do that that would be cool
10:19 rangi the original big patch ive signed off a while ago
10:19 rangi fixed
10:14 magnuse yay
10:10 rangi its not a bad one, just the updatedatabase.pl i can fix that easily enough
10:10 magnuse does anyone know if there are known problems with opening the value builder popups in ie?
10:09 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 new feature, P5 - low, ---, jcamins, Patch doesn't apply , Offline circulation using HTML5 and IndexedDB
10:09 magnuse ohnoes, poor bug 10240
09:58 tweetbot_ [off] @FredRiondet: "@27point7 Oui, au presta. Réponse: bug connu de la communauté. Jamais modifié car trop complexe. #KohaILS"
09:55 kf wish us luck :)
09:55 magnuse have fun kf!
09:55 magnuse w00t!
09:55 kf will be gone later... we have our first koha user meeting today :)
09:55 rangi make that 7
09:54 kf ok... tiem for lunch :)
09:54 rangi that dont apply
09:54 rangi its found 6 so far
09:54 magnuse next step: automatic signoff for the patches that do not make the tests fail ;-)
09:53 kf :)
09:53 kf seems to be working awesome
09:53 rangi thats the idea
09:53 magnuse automate all the things!
09:52 magnuse rangi++ !!!
09:52 rangi seems to be working fine
09:52 huginn` 04Bug 8918: normal, P3, ---, julian.maurice, Patch doesn't apply , ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
09:52 rangi http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918#c23
09:51 rangi next step it will test all those apply with the tests, and set fail qa any that make tests fail
09:50 rangi my bot is now testing all bugs in need signoff state, if they dont apply cleanly they get updated
09:49 tweetbot_ [off] @FredRiondet: "@27point7 Tu n'as pas encore vu le thésaurus skos et la compatibilité 100% Zotero #KohaILS #CHU #Lyon #Teaser"
09:49 huginn` 04Bug 9163: new feature, P1 - high, ---, fridolyn.somers, Patch doesn't apply , Cataloguing validation workflow
09:49 rangi http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163#c19
09:49 rangi w00t
09:48 rangi i wonder if this will work
09:40 tweetbot_ [off] @FredRiondet: "@27point7 La faute à Zebra j'ai envie de dire. #KohaILS"
09:37 tweetbot_ [off] @27point7: "@FredRiondet facette par type de doc, ça aussi ne n'est pas du standard. on a du bidouiller le code pour la faire apparaître... #KohaILS"
09:35 kf Oak: much appreciated - thx :)
09:34 tweetbot_ [off] @27point7: "@FredRiondet et une utilisation bien pensée (normalisée?) des tags http://t.co/q49scHzui4 #KohaILS"
09:32 * Oak sends kf cookies and tea
09:31 Oak :)
09:31 magnuse :-)
09:31 Oak \o/
09:31 magnuse Oak
09:31 Oak magnuse
09:31 Oak kia ora #koha
09:25 tweetbot_ [off] @27point7: "@FredRiondet Yep, #KohaILS. on utilise pas les tags. mais si c'est le cas c embettant. Je vais essayer d'en faire un correctif vite fait"
09:13 tweetbot_ [off] @FredRiondet: "@27point7 Je suppose qu'il s'agit de #KohaILS? La supp d'un compte lecteur supprime également ses tags. Ce qui peut poser problème parfois."
08:42 drojf hi kf
08:42 kf hi drojf, hi rangi
08:40 drojf hi rangi
08:40 drojf hei magnuse
08:40 rangi hi drojf
08:40 drojf :(
08:40 huginn` drojf: The current temperature in Prenzlauer Berg, Berlin, Germany is 10.2°C (10:13 AM CEST on September 18, 2013). Conditions: Rain. Humidity: 73%. Dew Point: 6.0°C. Pressure: 29.39 in 995 hPa (Steady).
08:40 drojf @wunder berlin, germany
08:40 magnuse moin drojf
08:40 drojf good morning #koha
08:39 huginn` magnuse: The current temperature in Bodo, Norway is 14.0°C (10:20 AM CEST on September 18, 2013). Conditions: Mostly Cloudy. Humidity: 67%. Dew Point: 8.0°C. Pressure: 29.56 in 1001 hPa (Steady).
08:39 magnuse @wunder boo
08:28 huginn` rangi: The current temperature in Wellington, New Zealand is 10.0°C (8:00 PM NZST on September 18, 2013). Conditions: Partly Cloudy. Humidity: 66%. Dew Point: 4.0°C. Pressure: 30.24 in 1024 hPa (Steady).
08:28 rangi @wunder nzwn
08:14 huginn` kf: The current temperature in Konstanz, Germany is 15.0°C (10:00 AM CEST on September 18, 2013). Conditions: Light Rain. Humidity: 79%. Dew Point: 12.0°C. Pressure: 29.60 in 1002 hPa (Rising).
08:14 kf @wunder Konstanz
08:11 kf morning #koha
07:53 dcook Have a good day/night :)
07:53 dcook Ok. Actually leaving now.
07:50 dcook git branch -v -v
07:50 magnuse cd?
07:49 rangi heh
07:49 rangi ls
07:42 dcook In fact, that might be a remote instance as well..
07:42 dcook Otherwise, I'd be all over that
07:42 dcook I think we only have one LDAP instance and I'm not familiar with it at all :/
07:42 dcook Thanks, rangi :)
07:42 rangi heh have fun dcook
07:42 dcook Ahh, no problem with the matching rules. I'm just an idiot who needs to leave work and head to the gym...
07:40 rangi i can't obviously
07:40 rangi would be great if someone could sign that off
07:40 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 blocker, P1 - high, ---, robin, Needs Signoff , Fix broken auth_by_bind LDAP mode
07:40 rangi bug 10908
07:39 rangi the problem with an open data set, you can construct all sorts of queries, but without context they dont mean a lot
07:39 dcook Hmmm...
07:37 kivilahtio_ magnuse: no worries. That clarifies a lot
07:36 magnuse sorry for the huge url
07:36 kivilahtio_ I can see your logic
07:36 magnuse this table might be of interest: http://bugs.koha-community.org/bugzilla3/report.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=REOPENED&bug_status=ASSIGNED&bug_status=In%20Discussion&bug_status=Needs%20Signoff&bug_status=Signed%20Off&bug_status=Passed%20QA&bug_status=Pushed%20for%20QA&bug_status=Failed%20QA&bug_status=Patch%20doesn%27t%20apply&x_axis_field=bug_severity&y_axis_field=bug_status&format=table&action=wrap&saved_report_id=1
07:36 rangi 0 blockers
07:36 rangi one in discussion, 1 with a patch that needs testing and one new
07:36 rangi there are 3 critical
07:35 rangi they got that figure
07:35 rangi yep, and since they dont realise that pushed to master and pushed to stable aren't open
07:34 kivilahtio_ rangi: sorry I take my previous comment back
07:33 kivilahtio_ no they just stated that there are 2800 open bugs :)
07:33 rangi for examply they assumed that 2800 bugizlla requests not in closed state = 2800 bugs
07:33 kivilahtio_ rangi: thanks for the clarification
07:33 rangi and with mostly badly researched conclusions, a wrong one
07:32 rangi i think someone just queried bugzilla, and jumped to some conclusions
07:32 kivilahtio_ rangi: no I don't. This is not mu discovery but I would like to hear your version of it
07:32 rangi and i bet of those 208, only about 10 are actually critical
07:32 rangi you realise we use bugzilla for all feature and enhancement requests too
07:31 magnuse rangi++
07:31 kivilahtio_ rangi: :D
07:31 rangi would you rather we hid them? :)
07:31 dcook O_o
07:31 kivilahtio_ we just found out that Koha has ~2800 open bugs, of which 208 are critical/major. I have to say that is troublesome
07:30 dcook Ugh...why don't the record matching rules seem to work now...
07:29 kivilahtio_ I'll bookamrk that
07:29 magnuse :-)
07:29 kivilahtio_ phew
07:29 kivilahtio_ magnuse: thanks!
07:29 magnuse http://perldoc.koha-community.org/
07:29 kivilahtio_ rangi: Documenting C4::Auth for starters
07:29 kivilahtio_ rangi: The perldocs were published as a web page.
07:27 magnuse we did use dokuwiki a long time ago?
07:22 rangi you mean http://wiki.koha-community.org/wiki/APIs_and_protocols_supported_by_Koha ?
07:21 rangi we dont use dokuwiki
07:12 kivilahtio_ paul_p: good. I hope you have time to answer
07:11 paul_p hi kivilahtio_ i've seen your email
07:10 kivilahtio_ mysterious...
07:10 kivilahtio_ I just can't find the Koha API docs anywhere? I saw it in the dokuwiki and now it is gone?
06:51 dcook hey ya reiveune :)
06:51 reiveune salut magnuse kathryn dcook rangi :)
06:50 huginn` magnuse: The current temperature in Marseille, France is 17.0°C (8:30 AM CEST on September 18, 2013). Conditions: Clear. Humidity: 68%. Dew Point: 11.0°C. Pressure: 29.86 in 1011 hPa (Rising).
06:50 magnuse @wunder marseille
06:50 magnuse bonjour reiveune
06:49 magnuse tcohen++ for updating http://wiki.koha-community.org/wiki/Commands_provided_by_the_Debian_packages
06:49 reiveune hello
06:39 cait bbiab
06:39 * dcook isn't sure what sounds reasonable anymore
06:38 dcook I'm glad to hear it :)
06:38 wahanui http://i.imgur.com/hVVuP.jpg
06:38 dcook No?
06:38 mtompset Well, have a great day, #koha.
06:37 magnuse i don't think expecting people to write xslt in a particular way for a particular feature is asking too much...
06:36 dcook Well, not impossible, but supremely spotty
06:35 dcook I think matching would be impossible without them though..
06:35 dcook Although it might be a bit much to expect people to remember to include my parameters..
06:35 mtompset Exactly why I mentioned it. :)
06:34 dcook That last paragraph seems particularly apt
06:34 mtompset http://en.wikipedia.org/wiki/Idiot_proof
06:32 dcook If I don't want to risk people making XSLTs that don't fit my scheme...I should make a more foolproof scheme...
06:32 magnuse cait++
06:30 dcook Right now, I'm pondering a new matching scheme...
06:30 dcook Neato. I might take a look later.
06:30 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764 normal, P5 - low, ---, mtompset, Needs Signoff , INSTALL.ubuntu needs to be updated
06:30 dcook bug 7764
06:29 dcook \o/
06:29 mtompset It's there now.
06:28 dcook :o*
06:28 dcook "o
06:28 mtompset dcook: Turns out that I hadn't put up my documentation patch for INSTALL.ubuntu
06:20 cait i figured something out
06:20 cait ah, it's ok
06:19 * cait needs a nice quote for showing the quote of the day feature
06:19 cait hm
06:19 dcook :/
06:19 dcook The safest thing is to not process updates...but then you don't have updates
06:18 dcook Or if your matching works...it'll override your local changes with the remote changes...which people might not realize
06:17 dcook But...if people craft XSLTs that don't insert the biblionumber parameter...then matching doesn't work. Although that just means that you'll potentially have duplicate records...
06:17 dcook Of course, I figured out a solution that searches a table for the OAI-PMH identifier and sees if it has been imported before...and if it is has...I grab the biblionumber, and stick that in our incoming record via the XSLT so that the standard import matching can work
06:12 dcook Actually, that's probably a Koha thing rather than a Zebra one
06:11 dcook Due to the colons, me thinks
06:11 dcook Since Koha/Zebra don't cope so well with OAI-PMH identifiers
06:10 dcook Of course, matching becomes the main issue...
06:10 dcook Either automatically or manually, your choice
06:10 dcook Load them into a batch import and import
06:09 dcook Transform them to MARCXML using XSLT
06:09 dcook The core is simple. Plug in a URL and a metadataPrefix, and harvest all the records.
06:09 dcook Actually, they're likely irrelevant
06:08 dcook Not even a little a bit
06:08 dcook Hmm, but now that I've broken it by changing naming conventions, perhaps I should go and fix it again..
06:08 mtompset Does it respect OpacHiddenItems and OpacSuppression?
06:07 dcook Or rather..."must predict all the ways people can use and abuse this thing"
06:07 dcook Jcamins' comment reminds me of this OAI-PMH harvester...
06:07 mtompset dcook's comment reminded me of jcamins' comment. :)
06:07 dcook hehe
06:07 mtompset Thank you.
06:06 huginn` rangi: Quote #278: "jcamins: ... OMGOMGOMG MUST FIX ALL THE THINGS." (added by mtompset at 03:50 AM, September 17, 2013)
06:06 rangi @quote get 278
06:06 huginn` mtompset: downloading the Perl source
06:06 mtompset @quote #278
06:06 huginn` mtompset: downloading the Perl source
06:06 mtompset @quote 278
06:06 huginn` mtompset: downloading the Perl source
06:06 mtompset @quote 277
06:06 dcook I've been meaning to look at ElasticSearch since Access 2011. Maybe I'll have to poke around a bit more before hackfest..
06:06 huginn` mtompset: Quote #193: "<libsysguy> I don't always reterminate....but when I do the terminator is near a stud // * wizzyrea considers if this is a real statement or something to do with the movie." (added by slef at 02:56 PM, March 22, 2012)
06:06 mtompset @quote random
06:05 * cait requests a seat at that table too
06:05 dcook Done
06:04 rangi dcook: come sit by me and jcamins and the hackfest
06:04 rangi magnuse did it
06:04 * dcook would love to see someone do OMGWTFBBQ!
06:04 dcook Hmm, that is slick
06:03 rangi {{DevBook}}
06:03 rangi you can add that block to any page by putting
06:03 rangi http://wiki.koha-community.org/wiki/I_want_to_help if you scroll to the bottom you can see it here
06:01 rangi probably in the developers handbook
06:01 mtj- paxed, the wiki is probably the best place for that missing info
06:00 dcook There's that too
05:59 cait dcook: i think another reason is that it needs constant effort - things changing a lot
05:59 dcook But it's a collective effort. While we love Koha, I don't know if any of us really market it.
05:59 mtompset Which reminds me... did I put up that patch...
05:59 dcook Not that the instructions shouldn't be perfect. mtompset has been doing a lot of great work on fixing up the Ubuntu instructions.
05:58 dcook Many of those who contribute the most to Koha work for companies that provide hosting options. As a result, they often have other things on their lists of things to do than to make sure the instructions are perfect, since they're already quite familiar with instructions.
05:58 cait the docs is in the readme currently I think - we could link to it
05:58 wahanui i guess gitify is at https://github.com/mkfifo/koha-gitify
05:58 cait gitify?
05:57 mtj- mtompset, cool ^^
05:57 dcook We're a quite loosely organized bottom-up community.
05:56 dcook paxed: I believe that the website has a Git repo as well. If that's a suggestion, perhaps you could write a bug report for it or submit a patch.
05:56 mtompset paxed: Good point, but there isn't even a gitify page.
05:51 paxed packages*
05:51 paxed if packaged + gitify is the way to go, shouldn't the "For Developers" section on the website mention it?
05:49 dcook Mmm spring
05:48 huginn` dcook: The current temperature in Sydney, New South Wales is 25.0°C (3:30 PM EST on September 18, 2013). Conditions: Clear. Humidity: 21%. Dew Point: 1.0°C. Pressure: 29.53 in 1000 hPa (Rising).
05:48 dcook @wunder SYD
05:48 * magnuse wanders off to make breakfast
05:48 magnuse so hot!
05:47 huginn` magnuse: The current temperature in Bodo, Norway is 14.0°C (7:20 AM CEST on September 18, 2013). Conditions: Mostly Cloudy. Humidity: 63%. Dew Point: 7.0°C. Pressure: 29.56 in 1001 hPa (Steady).
05:47 magnuse @wunder boo
05:29 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908 blocker, P1 - high, ---, robin, Needs Signoff , Fix broken auth_by_bind LDAP mode
05:29 eythian bug 10908
05:29 eythian Signoffs welcome on 10908
05:11 mtompset Or should I say mtj, I figured out how to trigger all the code points?
05:10 mtompset YAY!
05:10 mtompset mtj-: I figured out how to trigger all the code points.
04:56 cait and rain.
04:56 cait 12 degrees is not very cozy
04:54 huginn` eythian: The current temperature in Wellington, New Zealand is 11.0°C (4:00 PM NZST on September 18, 2013). Conditions: Clear. Humidity: 62%. Dew Point: 4.0°C. Pressure: 30.21 in 1023 hPa (Steady).
04:54 eythian @wunder nzwn
04:54 huginn` eythian: I suck
04:54 eythian huginn` doesn't know about wind
04:52 huginn` cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 12.1°C (6:50 AM CEST on September 18, 2013). Conditions: Rain. Humidity: 94%. Dew Point: 11.0°C. Pressure: 29.62 in 1003 hPa (Steady).
04:52 cait @wunder Konstanz
04:52 cait sounds crazy windy outside
04:49 cait true
04:48 eythian that's fine, but "$debug and warn "LDAP bind failed"" isn't something you should do. That's a warning you _want_ to see in production.
04:47 cait having different kinds of log levels?
04:47 cait i think that's where the idea of the logging module comes from?
04:47 cait hm
04:46 eythian I don't like this thing of only outputting diagnostic errors if debug is set. That's a bad thing to do.
04:44 cait meh.
04:44 wahanui kf should be writing slides
04:44 eythian slides?
04:42 cait yeah
04:42 eythian annoying.
04:42 cait still in the queue, annoyingly
04:42 eythian ah really
04:42 cait nope
04:42 * cait can't find someone to QA ldap patches it seems :(
04:42 eythian yeah, that's hopefully fixed. I haven't actually had a chance to check.
04:41 cait seems he already ran into the other with extended attributes causing problems
04:41 eythian heh, well if he encounters this, he'll have a lot more struggling to do :)
04:40 cait it might make u buy you more beer - he has to struggle with ldap these days
04:40 cait :)
04:40 cait good
04:40 eythian cait: I'm thinking on that now.
04:40 cait eythian: so how to fix it?
04:36 mtompset Wild! I didn't know you could use a cardnumber to log in to koha.
04:34 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 new feature, P5 - low, ---, gmcharlt, RESOLVED FIXED, Allow for new type of LDAP authentication
04:34 eythian bug 7973 is a terribly bad regression that will break LDAP for many people. If you have LDAP with auth_by_bind, you should be aware of it.
04:32 mtompset anyone know how to trigger check_api_auth?
04:31 mtompset 3,4,5 and 7... how to triggger.
04:30 mtompset logging in triggers set_userenv 1,2, and 6.
04:16 mtj- hmm, good point - only some changes are tested, not all… :/
04:15 mtompset Now to fix my other test.
04:14 mtompset Yes, but for complete thoroughness, the other changed code points need to be triggered too.
04:13 mtj- mtompset, i think a pass of ./t/db_dependent/Circulation.t - is a valid test of the C4::Context->set_userenv changes
04:05 * dcook scurries away
04:05 dcook ...
04:05 dcook Laksa time!
04:04 eythian that makes sense.
04:04 eythian oh, I see
04:04 rangi naw, it just wasnt updated on master
04:04 eythian not updating is fine, I'm just surprised it went backwards.
04:04 rangi master didnt have that happening
04:04 rangi back in the day when i was rmainting i used to update the versions for each release
04:03 mtj- to test, i logged in and changed my branch
04:03 eythian so $VERSION in Auth_with_ldap.pm from 3.8 is "3.08.01.002". In 3.12 it's "3.07.00.049". That's quite strange.
04:02 huginn` 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 normal, P5 - low, ---, gmcharlt, NEW , Incorrect calling conventions accessing C4::Context
04:02 mtompset I was planning on putting the patch on bug 10900
04:02 mtompset So, I can properly test them. Unless you already did that, mtj-
04:02 mtompset Now to figure out how to trigger the other pieces of code.
04:01 mtompset I just tested the Circulation.t test
04:01 mtj- mtompset, some good news - the 'C4::Context->set_userenv' search/replace suggestion from rangi, looks to work just fine for me
03:59 mtompset *whew* A data problem, not a code problem.
03:58 mtompset That's probably it.
03:57 wizzyrea the db_dependent tests all more or less require the sample data
03:57 mtj- do you have an 'MPL' branch?
03:56 mtompset I can't get it to run in master, it's failing on foreign constraints.
03:51 mtompset Could someone please tell me that they can run: prove t/db_dependent/Circulation.t
03:50 * mtompset sighs.
03:32 mtj- (grep says theres 8 of them)
03:30 mtj- mtompset ^^
03:29 mtj- , then make in a blocker to your current bug
03:29 mtj- follow rangi's advice - fix the inconsistent 'C4::Context::set_userenv' calls first as a seperate bug
03:26 mtompset I just want to write tests to make sure my stuff gets in. :)
03:25 mtompset Of course, if we aren't supposed to treat C4::Context as an object, then ::set_userenv makes more sense.
03:23 mtompset 10895 is the test set I wrote for 10589.
03:20 mtompset or even ->new, $context->set_userenv.
03:20 mtompset properly being defined as C4::Context->set_userenv.
03:19 mtompset In order to write the test properly (which I didn't, just to get it to work), I need to go down this C4::Context::set_userenv hole.
03:18 gmcharlt mtompset: one question -- is it possible that, for you, C4::Context represents essentially a rabbit-hole that you don't need to go down in order to accomplish your larger project?
03:17 mtompset Exactly, cjh. :)
03:17 cjh hmmm $_[0] eq 'C4::Context' implies it can be called as a static method too, cute.
03:17 cjh die 'NOPE' unless ref($_[0]) eq 'C4::Context';
03:16 eythian oh, so they're not respecting the contract presented to them and should be fixed.
03:16 mtompset The simplest solution is to change everything to -> and add the shift.
03:16 cjh eythian: oh of course, I failed to consider later arguments.
03:15 mtompset Some are busted, because there is no shift.
03:15 mtompset There are C4::Context::set_userenv calls and C4::Context->set_userenv calls.
03:15 eythian cjh: you still need to do the shift though
03:15 mtompset cjh: The scenario is this.
03:14 cjh mtompset: since $self is never used would it matter if we 'missed one' ?
03:14 mtompset I am learning doing this.
03:12 eythian they probably did mean that.
03:12 cjh eythian: heh when I first wrote it I put 'unless they really meant `defined $_[0]`' but for some reason removed that
03:11 eythian cjh: it'd throw warnings if it was undef.
03:11 rangi but i said that yesterday, so i guess it's not compelling
03:11 cjh eythian: unless we are talking about difference points, wouldn't that just be caught by the later part of the and?
03:10 rangi you're just piling on more technical debt
03:10 eythian yeah, having the code allow inconsistent notation is worse than making everything consistent.
03:10 rangi we fix that
03:10 mtompset and if we miss one?
03:10 rangi and we would be far better off to just fix all calls to be ->
03:10 rangi personally i think this is a massive make work project
03:09 mtompset so: shift @_ if ($_[0] && ($_[0] eq 'C4::Context' || ref($_[0]) eq 'C4::Context'));
03:09 eythian cjh: if you're calling it in a non-OO way and giving no args, I guess.
03:09 cjh but usually not with such a horrid condition.
03:09 mtompset ah...
03:09 eythian although, it is a standard pattern in OO code to define it.
03:09 eythian if $self is never used, then it should never be defined.
03:08 cjh heh nice mtompset
03:08 cjh I dont think the first $_[0] is needed as 'C4::Context' is truthy and I struggle to think of a reference that would yield false.
03:08 mtompset Also, $self is not referenced at all in the routine, so the semantic difference is irrelevant.
03:07 mtompset The lengthy expression does make this hard to read.
03:06 eythian too much separation between the verb and the accusative, this isn't German :)
03:05 jcamins I can see what your first one-liner did, but your second one-liner is nearly unreadable.
03:04 eythian "Don't write code that's hard to read."
03:04 eythian it's a general guideline.
03:04 jcamins That's worse, for the record.
03:04 mtompset Not mentioned in the coding guidelines.
03:04 eythian yeah
03:03 cjh would be the same if you changed '' to undef, but as mentioned ternary isnt nice.
03:02 eythian also, the purpose might be only assign to $self if there's something to assign there, whereas you assign no matter what now.
03:02 eythian ternary notation should be avoided unless it stops something becoming unclear.
03:02 mtompset the point was shift only if I am supposed to shift.
03:02 mtompset well, I get the conditional declaration difference.
03:01 eythian also, it's semantically different
03:01 eythian it's not a whole lot better really
03:01 mtompset passes qa-tool: my $self = ($_[0] && ($_[0] eq 'C4::Context' || ref($_[0]) eq 'C4::Context')) ? shift @_ : '';
02:59 mtj- }
02:59 mtj- $self = shift;
02:59 eythian that's pretty terrible, yeah
02:59 mtj- if ($_[0] && ($_[0] eq 'C4::Context' || ref($_[0]) eq 'C4::Context')) {
02:59 mtj- my $self;
02:57 rangi it just makes it harder for whoever has to debug that in the future
02:57 rangi you dont win points by being compact
02:57 rangi if i was perlcritic id hate that too
02:57 rangi yeah thats pretty foul
02:56 mtompset It didn't like that code.
02:56 mtompset my $self = shift @_ if ($_[0] && ($_[0] eq 'C4::Context' || ref($_[0]) eq 'C4::Context'));
02:56 mtompset I think I have a rewrite for that one liner.
02:56 mtj- ooh, thats a new one
02:56 mtompset # Variables::ProhibitConditionalDeclarations: Got 1 violation(s).
02:55 mtompset GAH! fails qa tool!
02:52 dcook I've been thinking that I shouldn't try adding features. Or if I do...to add them locally first and then once the kinks are ironed out...then maybe add them here...
02:52 dcook mtompset: I feel a bit of your pain
02:51 mtompset Because I'll be writing tests all day.
02:51 mtompset Remind me to not find bugs in core libraries that tick me off.
02:50 mtj- yep, me too… but my 5th test, 10 mins :)
02:50 mtompset -- second. And that still took a day.
02:49 jcamins mtompset: that's because it's your first test.
02:48 mtompset Spending multiple days to get a single test written well given 2-4 hours of coding and debugging time... I don't think so.
02:48 mtompset Writing tests is worthy.
02:46 mtj- mtompset, keep at it - its a worthy hump to overcome :)
02:45 mtompset I am too new to tests to even touch that mess.
02:45 mtompset or not...
02:39 mtompset (as per a bug report I saw on bugzilla)
02:39 mtompset This will lend itself to splitting, if and when C4::Context does.
02:39 mtompset I think I'll take a page from tcohen's test he wrote on my behalf and create sub tests.
02:38 jcamins mtompset: right, but what I was saying was "if the module needs to be split, you should reflect the logical structure in your tests.
02:38 mtompset And if I recall, rangi suggested that all tests should generally be in one test file per library, and you, jcamins, suggest except if the file is exceptionally crazy large.
02:38 tcohen why not assume every test is db-dependet, unlesswe want to test something is db-independent specifically?
02:34 gmcharlt and it's not a problem to just stick it into db_dependent
02:34 jcamins Okay, you can either figure out how to mock the needed bits, or you can move it to db-dependent.
02:34 mtompset C4::Context->new;
02:33 mtompset because the third method bombed.
02:33 mtompset No, it failed to complete the test.
02:33 jcamins If any tests failed, it has to go into db-dependent.
02:33 jcamins But check with gmcharlt about his policy on that.
02:33 jcamins If it gave you an error message but all tests passed, you're probably fine.
02:33 mtompset Hmmm...
02:32 mtompset unable to locate Koha configuration file koha-conf.xml at /home/mtompset/kohaclone/C4/Context.pm line 373.
02:30 jcamins You have to unset KOHA_CONF.
02:30 jcamins Nah, that's not enough.
02:30 jcamins No, it empties the environment variable for that single test run.
02:30 mtompset I dropped the DB.
02:30 jcamins If it doesn't fail, you're good.
02:30 mtompset That just sets an environment variable to a string?
02:29 jcamins After you write your DB-free test, run it in an environment with no DB access.
02:29 jcamins It ensures that DB access is not required.
02:27 mtompset I don't understand what that is to accomplish.
02:26 jcamins You'll need to test that by running: KOHA_CONF= perl t/Context.t
02:25 mtompset set_userenv does not require DB access at all, as far as I can tell. :)
02:24 jcamins Provided you mock all the parts that *do* require DB access.
02:24 jcamins Yes.
02:21 mtompset Would this mean there could be a t/Context.t and a t/db_dependent/Context.t?
02:21 mtompset C4::Context has functions which do not require DB access.
02:20 mtompset next question related to tests...
02:20 mtompset okay, long crazy day... back to coding tests.
01:31 tcohen heh
01:10 jcamins (part of the interview)
01:09 jcamins You'll be glad to know that they got him all his shots and got him a passport.
01:09 rangi heh
01:05 jcamins This is who we need to promote Koha: http://www.buzzfeed.com/ryanhatesthis/oh-my-god-theres-a-cat-in-russia-that-wears-a-bow-tie-and-wo
00:27 dcook Positive reinforcement?
00:26 tcohen bribing?
00:22 dcook Something like that ;)
00:21 cjh half now, half later? :p
00:21 dcook It's encouragement :)
00:20 cjh ooohhh I havent done that yet.
00:20 cjh what did I do?
00:15 dcook cjh++
00:15 dcook wizzyrea++
00:14 tweetbot_ [off] @sallyheroes: "A chance to become a #KohaILS developer for librarians attending #lianza2013 http://t.co/NMtXMPhlcT"
00:05 eythian Yeah, I just tried it on a 3.12 and it didn't work.