Time Nick Message
00:55 jcamins_away wajasu: example on the bug
01:46 wajasu thx
02:32 wajasu jacamins_away: when adding an authority GEOGRAHPIC NAME record, my 551 $a field is locked. Is there any syspref other than BiblioAddsAuthories = allow that I can set?
02:33 wajasu jcamins_away: when adding an authority GEOGRAHPIC NAME record, my 551 $a field is locked. Is there any syspref other than BiblioAddsAuthories = allow that I can set?
03:20 idreambooks hello. anybody online?
04:37 wajasu ya
04:51 mtompset Greetings, #koha.
06:15 mtompset Greetings, cait.
06:15 cait morning mtompset
08:16 mtompset Hmmm... someone needs to update the subject line.
08:16 mtompset I mean topic.
08:16 cait yeah, but I can't
08:16 cait rangi or wizzyrea maybe
08:25 * mtompset is trying figure out best solution to bug 8742 he just posted.
08:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 trivial, P5 - low, ---, gmcharlt, NEW , Example uses perl 5.8 in Makefile.PL
08:26 mtompset I figure a grep of @INC is a good start.
08:26 mtompset But I need a fallback if the grep fails.
08:27 mtompset finding a good explanation of @array in a logical test isn't available?
08:28 mtompset Ah well, I'll use it and let someone tell me it is the wrong way to do it.
08:43 mtompset There... something submitted.
08:43 mtompset bug 8742
08:43 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 trivial, P5 - low, ---, mtompset, Needs Signoff , Example uses perl 5.8 in Makefile.PL
08:44 mtompset Funny thing is, with packages, this output fix will reduce in visibility.
10:33 mib_5eyxci Hello Sir
10:34 mib_5eyxci hello are u there?
11:34 jcamins_away wajasu: are you sure you can't type 551$a? The lock icon just indicates that it is authority controlled.
11:39 jcamins mtj++
11:44 Oak guys, any idea about this error when database upgrade from 3.6.4 to 3.6.8:
11:44 Oak updatedatabase.pl: DBD::mysql::db do failed: Duplicate key name 'items_location' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 4710.
11:44 Oak pdatedatabase.pl: DBD::mysql::db do failed: Duplicate key name 'items_ccode' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 4711.
11:45 cait HM
11:45 cait can you find the updatedatabase part that is cuasing this and paste it?
11:45 cait I am surrounded by green beans right now
11:46 Oak :) okay
11:48 Oak paste?
11:48 wahanui well, paste is found at http://paste.koha-community.org
11:49 pastebot "Oak" at 127.0.0.1 pasted "$DBversion = "3.06.07.001"; if" (7 lines) at http://paste.koha-community.org/159
11:52 jcamins Oak: you can ignore that.
11:52 cait green beans cleaned - but jcamins was faster :)
11:52 cait jcamins++
11:52 Oak okay cool :)
11:52 Oak http://tinypic.com/r/sfjioj/6
11:53 jcamins Nothing to worry about. :)
11:53 Oak cool then. thank you!
11:53 Oak jcamins++
11:53 Oak cait++
11:57 jcamins Oooooh... I *like* bug 8304.
11:57 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 enhancement, P5 - low, ---, matthias.meusburger, Needs Signoff , composed authorities Rameau management
11:57 jcamins Just think of the possibilities.
11:58 jcamins Also, merge is broken as of 3.8.0.
11:59 jcamins I don't know why.
11:59 Oak jcamins, one more thing, echo $PERL5LIB says /usr/share/koha/lib/, and here is /etc/koha/sites/aridkoha/koha-conf.xml. I do PERL5LIB=/usr/share/koha/lib/ and KOHA_CONF=/etc/koha/sites/aridkoha/koha-conf.xml. and when i run /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -a -b -z -v as root I get:
11:59 Oak Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 6.
11:59 Oak BEGIN failed--compilation aborted at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 6.
12:00 Oak i isntalled oldstable, 3.6.8 using Debian package...
12:00 jcamins That's easy to solve, but before I tell you the solution, aren't you using packages?
12:00 cait ew
12:00 cait about the broken merge
12:00 Oak i did jcamins
12:00 jcamins Use `sudo koha-rebuild-zebra aridkoha`
12:01 cait but die you run Makefile or did you use the koha-common commands to create your instance?
12:01 jcamins Don't run rebuild_zebra directly.
12:02 jcamins And for future reference, you need to put 'export' before the variable name.
12:02 Oak okay, i ran that earlier, problem with it is that it says nothing (which is okay I guess), but i also don't get any search results in OPAc and in staff client
12:02 jcamins So, `export PERL5LIB...` and `export KOHA_CONF...`
12:02 jcamins Oak: in that case, run koha-rebuild-zebra -f -v aridkoha
12:03 Oak oh cool now it is doing stuff!!!
12:03 Oak jcamins++
12:04 Oak great. now search works!
12:05 * Oak goes to check fo rmanual of rebuild_zebra to find what -f does
12:05 jcamins It's the equivalent of -r
12:05 jcamins It's a full rebuild.
12:05 jcamins cait: the failed merge can result in data loss.
12:05 jcamins However, only in very specific situations.
12:05 cait double ew
12:05 jcamins major or critical?
12:05 cait major
12:05 cait that's the higher one?
12:06 jcamins critical is higher.
12:06 cait then critical
12:06 cait data loss even makes blocker valid
12:06 Oak okay got it.
12:07 Oak now i have my notebook in my lap, and i'll note these things down NOW, so I won't ask these embarrassing questions again.
12:07 jcamins You know, with bug 8304, merge becomes an attractive feature for me.
12:07 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 enhancement, P5 - low, ---, matthias.meusburger, Needs Signoff , composed authorities Rameau management
12:10 cait sorry, I can't follow
12:10 cait can you sum up what the bug does?
12:10 jcamins Well, two things.
12:10 jcamins One: it doesn't change headings that don't match anymore.
12:11 jcamins I guess in a follow-up I should make that switchable.
12:11 jcamins Two: it allows us to use multiple authorities in one subject (i.e. free-floating subdivisions).
12:13 cait ?
12:13 cait ok, I still can't follow :)
12:14 cait Oak++
12:14 cait jcamins: why does that make merge not needed?
12:15 jcamins What?
12:15 jcamins Merge is still needed.
12:15 cait ah
12:15 cait thought you said you liked it even better or something
12:16 cait but now I can't find it in the logs
12:16 jcamins Yes, I like merge even better post-8304.
12:17 cait hm
12:17 cait hope you have testing plans on those bugs :)
12:17 cait our subject structure with rswk is a lot simpler than loc
12:17 jcamins 8304 isn't my bug.
12:17 cait meant the other bugs i am supposed to test :) and the bug fix
12:17 jcamins paul_p asked me to confirm that it doesn't change MARC21 at all.
12:27 jcamins Hm. Unfortunately, it does.
12:30 cait :(
12:30 cait why is it failed qa?
12:30 jcamins I'm writing that up now.
12:34 * jcamins finished writing it up.
12:35 jcamins I wanted to make sure I posted the rebased patch, since I had spent a while reconciling changes.
12:38 Oak jcamins+
12:38 Oak oho
12:38 Oak jcamins++
12:38 Oak cait++
12:45 wajasu jcamins: yes 551a has a lock icon in it. and i can't type in it
12:46 cait jcamins++ indeed :)
12:47 jcamins wajasu: that's odd, because the authority editor does not have any locking functionality.
12:47 jcamins To confirm, you *are* in the authority editor, right?
12:47 wajasu my breadcrumbs: Home › Authorities › Adding authority Geographic Name
12:47 jcamins Okay, that sounds right.
12:48 wajasu caching of javascript or something?
12:48 jcamins Maybe. I'm trying to replicate.
12:49 * jcamins manages.
12:49 jcamins Now that is *weird*.
12:50 jcamins Oh, I just signed off on a bug that did some work here.
12:50 jcamins Reconciling things.
12:51 jcamins Patch coming momentarily.
12:52 wajasu i'm going to have to leave. but will check later today.
12:55 jcamins I was too busy looking at the 0xx and 1xx tabs, apparently.
13:01 jcamins @later tell wajasu The patch on bug 8744 fixes the problem.
13:01 huginn jcamins: The operation succeeded.
14:16 mtompset Greetings, #koha.
14:25 tcohen hi mtompset
14:26 tcohen jcamins, i cannot reproduce bug 8743 in our 3.8.x setup, do I need to use DOM for authorities to test it?
14:26 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 critical, P3, ---, jcamins, Needs Signoff , ZOOM error when merging authority change to biblios
14:27 jcamins tcohen: I don't think so.
14:28 jcamins I ran into the problem with both GRS-1 and DOM.
14:30 jcamins And once I ran into it, I had the problem as far back as 3.7.something.
14:30 jcamins But not in 3.6.x.
14:30 tcohen so, having dontmerge set to Do, editing the 100$a of an authority linked to a biblio, it should raise an error
14:31 jcamins Right.
14:42 tcohen i cannot reproduce jcamins sorry, leaving to have lunch!
14:43 jcamins tcohen: no problem. I imagine Doug will be willing to test.
14:43 tcohen ok!
14:45 cait hm not daniel?
14:46 * jcamins doesn't know who Daniel is, but if he's having the problem too, he'd probably be willing to sign off, too.
15:06 Oak can i help with this bug cait ?
15:07 Oak to sign off...
15:07 Oak i mean you'd know if i should or should not
15:10 cait Oak: better ask jcamins - authorities are a bit complicated but he often does great test plans :)
15:11 Oak okie
15:13 jcamins Oak: you're on 3.6.8, which doesn't have this bug.
15:13 Oak ah. okay. i was just checking http://catalogue.test6.biblibre.com/cgi-bin/koha/opac-main.pl
15:15 jcamins Oh, if you're using a sandbox, you may be able to replicate the bug by linking a bib heading to an authority, setting dontmerge to "Do," and trying to edit the authority.
15:18 Oak don't know about how to link bib heading to authorities... that's why asked katrin :) this one's 440 a is already linked ot an authority i guess: http://catalogue.test6.biblibre.com/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=2
15:18 Oak never used authorities myself
15:19 jcamins Oak: that's not linked. $v is the volume number.
15:26 Oak what does that 'Link' field does in there: http://tinypic.com/r/e6ez4w/6
15:27 jcamins Link is not used at all anymore.
15:28 Oak okay.
15:28 jcamins When I said "link," I meant in the cataloging module.
15:29 jcamins Oak: http://manual.koha-community.org/3.8/en/cataloging.html#catbibs <-- scroll down to where it says "Sometimes fields may not be editable due to the value in your BiblioAddsAuthorities system preference"
15:29 Oak okay on it
15:29 jcamins That shows how to link authorities.
15:30 jcamins (but don't take what it says too seriously, the authority plugin works without BiblioAddsAuthorities too)
15:34 cait I can't load the unimarc sample database :(
16:10 jcamins bug 8523
16:10 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 enhancement, P5 - low, ---, jcamins, Needs Signoff , Authority hierarchies only support UNIMARC
16:16 Oak this one also is above me :)
16:16 Oak someday...
16:17 jcamins :)
16:21 Oak by "you may be able to replicate the bug by linking a bib heading to an authority" you meant << by linking a bib field to an authority >> ?
16:22 jcamins Right.
16:23 Oak and by "and trying to edit the authority." you meant << edit the authority record at the backend >> or << edit the authority... change, say, personal name to some other name >> ?
16:25 Oak wait
16:25 jcamins Change the authority from "Smith, John" to "Smith, James.
16:25 wahanui jcamins: that doesn't look right
16:25 jcamins (for example)
16:25 Oak okay got it.
16:26 Oak but when i search for something like, "nicole" or some other name in the popped up window it says no result found...
16:26 Oak let me check
16:28 jcamins There probably aren't any authorities.
16:28 Oak hmm
16:29 Oak then when i click 'Create New' button an pop-up windows opens with things that don't make much sense to me. and so there i gave up.
16:30 jcamins You'd have to create an authority record.
16:30 Oak :)
16:30 Oak two records actually?
16:30 Oak set one, then edit and choose another...?
16:31 Oak to reproduce the bug
16:31 jcamins No.
16:31 jcamins Just one.
16:31 jcamins You create an authority.
16:31 jcamins Link a field in a bib to that authority.
16:31 jcamins Then you edit the authority.
16:32 Oak ah okay
16:32 Oak let me try that
16:33 cait Oak++ :)
16:33 Oak okay authority added with name Smith, John
16:33 cait jcamins++
16:33 cait Oak: remember it needs to be indexed before you can use it :)
16:34 Oak hmm. yes i read something about ask your administrator to run some command... let me see
16:37 Oak okay without the indexed thing cait said, I just went and edited the authority, from 'Smith, John' to 'Smith, Johnny'. No error!
16:39 Oak i had already set dontmerge to "Do" before creating the authority and editing it though
16:40 jcamins Oak: tcohen wasn't able to recreate the problem either.
16:40 jcamins You followed the test plan properly. :)
16:40 Oak hmm
16:40 Oak okay good :)
16:42 Oak and the bib record is also showing 'Smith, Johnny' now that i searched for it and viewed it again.
16:43 jcamins We'll wait for Doug to check his e-mail and test it.
16:43 Oak cool.
17:49 mbalmer evening
17:50 mbalmer so, is software written in e.g. C accepted in the Koha source tree?
17:51 jcamins mbalmer: only if it is core to Koha.
17:51 cait there is a contribs repo too
17:51 cait for other things
17:51 mbalmer what does that mean (core to Koha)?
17:52 Brooke o/
17:53 jcamins mbalmer: it is something that represents basic functionality in the area of circulation, cataloging, acquisitions, serials, or OPAC.
17:53 jcamins Also, of course, there would have to be an *incredibly* compelling reason why we needed to add code in a different language.
17:54 jcamins (that list of modules not guaranteed to be complete)
17:55 mbalmer examples coulx be a SIP2 server in C, a Lua binding do Koha etc. Would any of these qualify? Or system tools e.g. to make a locally attached printer accessible over the network on port 9100.
17:55 mbalmer s/coulx/could/
17:56 jcamins If there were a reason why the SIP2 server in Perl couldn't be fixed to do whatever was needed, perhaps.
17:56 jcamins I'm not sure about the Lua binding, because I don't know what that entails.
17:56 jcamins System tools would belong in contribs.
17:57 jcamins Also, why don't you use CUPS or LPD?
17:57 mbalmer for obvious reasons.
17:57 mbalmer perl does not support IPv6, iirc.
17:59 jcamins I'd say probably the best thing to do with the SIP2 server would be to keep it separate either way, so that Evergreen (for example) could use it.
18:02 Brooke howdy mveron :)
18:02 mveron Hi Brooke :-)
18:05 mbalmer sali marc
18:05 mveron sali marc :-)
19:25 cait bug 7455
19:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 normal, P4, ---, fridolyn.somers, Signed Off , Authority subfields are cloned in the wrong field
19:40 mbalmer jcamins, we (my company) made a decision. we will not opensource our Koha related software that is written C.
19:41 jcamins mbalmer: well, that answers the question about whether it belongs in Koha.
19:41 mbalmer I did not expect a smarter reply...
19:49 rangi perl does not support ipv6?
19:50 jcamins It does, but who cares?
19:51 rangi i was just boggling, you can't really take any of the rest of the argument seriously after a statement like that
19:51 rangi ah well, that solves that conundrum then
19:52 jcamins That clearly wasn't the deciding factor, since Google "perl ipv6" explains how to use IPv6 in Perl, so I focused on writing epic (and I mean EPIC) unit tests.
19:52 rangi yep
19:52 rangi sounds to me like a reason looking for an excuse
19:52 jcamins Alas, the unit tests are for Evergreen and not Koha, at the moment.
19:53 jcamins 80.3% statement coverage on the EG QueryParser! :D
19:53 jcamins And... five bugs fixed.
19:54 rangi cool
20:11 wajasu i'm tsting 8211 now
20:11 jcamins Yay!
20:11 jcamins wajasu++
20:14 cait good morning kathryn :)
20:14 kathryn hi cait! it's beautiful morning
20:14 rambutan ?
20:14 rambutan cccccccccccccccccc
20:14 rambutan ?
20:14 cait it was a nice day here too
20:15 rangi why is rambutan dancing on his keyboard?
20:15 rambutan yea, got some gobbleygook in there
20:15 jcamins rambutan: cat?
20:15 rambutan no, I'm actually at work for a sec
20:33 wajasu jcamins: pre 8211 patch. BiblioAddsAuthorities =don't allow. I have the authority heirarchy saved as in 8211 comment. I am adding biblio/items by doing z3950 search (Subject Heading:United States) and i saved no problem. i am testing that your search doesn't work first. so i want to be sure i am configured correctly.
20:34 wajasu must i use the advanced search screen? or can i use the generaal staff search for things like: su-br:Arizona
20:35 jcamins wajasu: you can just use the simple search and enter su-br:Arizona
20:35 wajasu ok
20:35 jcamins It won't work.
20:36 wajasu what won't work.
20:36 jcamins The search.
20:36 wahanui the search is for the patrons not the librarians
20:36 wajasu ok. good to know. then use the opac
20:36 jcamins Without the patch, I honestly have no idea what it's going to do.
20:37 wajasu ok. i'll let you know then.
20:37 jcamins Probably look for the literal string "su-br:Arizona" :)
20:38 wajasu once i add the half dozen records, do all i have to do is "rebuild-zebra" and things should be linked? or use a linker?
20:38 jcamins You'll need to either use the linker, or use the authority plugin in cataloguing.
20:39 jcamins I'd recommend using the authority plugin 'cause it'll be faster.
20:39 wajasu gotcha
20:40 wajasu you know. by the way when i use that auth plugin, when i click cancel, nothing happens. (windows stays open)
20:41 jcamins Hm. I should fix that.
20:41 wajasu if you patch that, i'll test it later as well.
20:41 jcamins First I have to fix the patch for bug 8523.
20:41 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 enhancement, P5 - low, ---, jcamins, Needs Signoff , Authority hierarchies only support UNIMARC
20:41 wajasu no hurry. i'll work on 8726 after 8211
20:43 jcamins Well, this is... hmph.
20:43 jcamins cait: I have good news, and I have bad news.
20:43 jcamins The good news: Konstanz is showing up.
20:43 jcamins The bad news: it's showing up twice.
20:46 cait lol
20:52 jcamins This is really weird.
20:53 cait i am sorry
20:53 cait but I catalogued it correctly?
20:53 jcamins I'm experimenting now.
20:54 jcamins It looks right to me, but...
20:55 cait it doesn't work.
20:55 rangi https://i.chzbgr.com/completestore/12/9/5/8dUvGazUDECf1xOCZPJ9FQ2.jpg
20:55 rangi that will fix it
20:56 jcamins lol
20:58 jcamins Okay. It's an issue with the link to Baden-Wurtemberg.
20:58 jcamins No link = happy system.
20:58 jcamins Link = unhappy system.
20:58 jcamins But why?
20:59 jcamins I see no difference between this and what I have.
21:00 cait the minus?
21:00 cait thelink from konstanz to baden-württemberg? or up-to-down?
21:01 jcamins The link from Konstanz up to Baden-Wurttemberg.
21:01 jcamins The link in the other direction makes no difference at all.
21:02 jcamins (I mean, other than in the display)
21:04 cait funny
21:04 cait well.. not really
21:04 cait but...
21:18 wajasu jcamins: started to apply 8211. git am -i -u -3 ~/Downloads/Bug-8211-Add-exploded-search-options.patch and got ==> fatal: sha1 information is lacking or useless (C4/Search.pm)
21:18 jcamins wajasu: I will rebase and reattache.
21:18 wajasu thx
21:19 jcamins wajasu: and to confirm, you applied all the dependencies first?
21:21 wajasu oh. 7818. let me do that
21:22 wajasu wait. that shows in my git log.
21:22 jcamins Also bug 8209.
21:22 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 enhancement, P5 - low, ---, jcamins, Passed QA , "Did you mean?" suggestions based on authorities
21:24 wajasu so that should have been in the dependsOn?
21:24 jcamins Oh.
21:24 jcamins No.
21:24 jcamins Sorry.
21:25 jcamins Bug 8726 requires it.
21:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 enhancement, P5 - low, ---, jcamins, Needs Signoff , Did you mean? plugin for broader/narrower/related terms
21:25 * jcamins is distracted by bug 8523 still. ;)
21:25 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 enhancement, P5 - low, ---, jcamins, Needs Signoff , Authority hierarchies only support UNIMARC
21:25 jcamins Okay, updated it.
21:25 wajasu ok.
21:37 |Lupin| hello there !
21:37 rangi |Lupin|: !!!! hello!
21:37 cait hello!
21:37 cait nice to see you!
21:38 * jcamins bangs his head on the desk.
21:38 |Lupin| hey cait ! nice to see you too !
21:38 cait and ignore jcamins - I broke his feature
21:38 jcamins I got Konstanz to show up, and Furstenberg is missing.
21:38 cait jcamins: you are getting closer... it will be all ok
21:39 * cait hands jcamins a cookie and puts a pillow on the desk
21:39 |Lupin| hello rangi ! changed nick ? :)
21:39 cait you can't break your head over this, you are our only candidate for rm
21:40 |Lupin| just a quick question: does anyone here know something about perl's sourcefilters, please ?
21:40 |Lupin| I'm wondering how to see a script after the filters have been applied...
21:40 wajasu jcamins: i pulled a fresh master and tried the new 8211 -> sha1 information is lacking or useless (t/db_dependent/Search.t)
21:40 jcamins Oh.
21:40 jcamins Right.
21:41 jcamins I forgot to mark the dependency on the Search.t bug.
21:41 jcamins bug 8649
21:41 huginn 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Signed Off , C4::Search needs a unit test
21:42 jcamins I'll mark the dependency now.
21:42 jcamins Marked.
21:42 cait |Lupin|: sorry, i don't
21:42 jcamins Sorry about that.
21:42 |Lupin| cait: np :)
21:42 jcamins I feel like it was so long ago that it *must* have been pushed.
21:43 wajasu not in my git log
21:43 jcamins No, it wasn't.
21:43 jcamins Definitely wasn't.
21:43 jcamins I just feel like it was. ;)
21:44 wajasu i wonder if you should specify 8744 as well, so when QA goes to add heirarchical geonames that can.
21:44 jcamins Good call.
21:44 jcamins Done. :)
21:45 wajasu i see em. trying again.
21:46 jcamins I bet you're going to get the same error on account of the patches not having been signed off when I branched.
21:47 wajasu hmm. we'll see.
21:47 wajasu 8649 has 5 patches. oh well.
21:49 jcamins Just apply them all, then apply 8211.
21:50 wajasu ok
21:53 jcamins Fixed it!
21:53 jcamins There is only one problem:
21:53 jcamins push @{$branch->{children}}, $nextBranch unless grep {$_->{authid} == $nextAuthid and $_ = $nextBranch} @{$branch->{children}};
21:53 jcamins rangi: could you please tell me how to make that line not the most horrible thing everevereverever?
21:54 rangi well for a start don't make it one line
21:54 jcamins Maybe I can use a map instead.
21:55 jcamins It used to be a much shorter line.
21:55 rangi laziness in typing is never an excuse for writing obfusticated code
21:55 jcamins It used to be push array, value;
21:55 * jcamins liked that.
21:55 jcamins It was brief.
21:55 cait heh
21:55 cjh jcamins: move the unless out of the line
21:55 jcamins To the point.
21:55 * gmcharlt doesn't mind the construct, but does think that sort of thing needs a comment to explain the intent
21:55 jcamins Clear.
21:55 cait make it nicer again?
21:56 jcamins Okay, so far everyone has missed the real problem with it, I think.
21:56 jcamins You should be out with pitchforks!
21:56 rangi no one can see the real problem cos its a code barf
21:56 jcamins " and $_ = $nextBranch"
21:56 rangi yep
21:56 jcamins The grep is kind of okay.
21:56 rangi grep is fine unless in that is horrible
21:56 rangi like cjh said, move it out
21:57 pastebot "gmcharlt" at 127.0.0.1 pasted "how I like to format stacks of maps and greps" (4 lines) at http://paste.koha-community.org/161
21:57 jcamins Ooh, I could put a map following a grep?
21:57 jcamins That would be more... no, it wouldn't, never mind.
21:57 cjh you can easily make it `unless(grep stuff){\n push stuff\n }
21:58 gmcharlt yep - you can stack them as much as you want (at least until whoever has to read the code starts throwing things at you)
21:58 cjh heh
21:58 jcamins gmcharlt: but I'd still end up with the same horrid half-test, half-assignment thing.
21:58 gmcharlt yeah - use greps only for testing, maps for mapping
21:59 jcamins What if I turned the grep into an if, put a map in the "found" branch and the push in the not found branch?
21:59 wajasu if you can comment it in english, then the intent is expressed. then later, someone like me can write a test.
21:59 cjh gmcharlt++
21:59 gmcharlt although thinking about the "unless grep" construct -- you're mixing somethign that produces a list with something that looks for a (scalarish) boolean value
22:00 rangi yeah
22:00 gmcharlt so I suppose one way to make ones intent clear is to do
22:00 rangi unless grep just feels wrong
22:00 gmcharlt ... unless scalar( grep { ... } ...);
22:00 jcamins wajasu: describing what I want to do in English is easy: "Replace the stub currently in children with a fully-realized branch, or add the fully-realized branch if there's no stub."
22:01 jcamins Then my knowledge of Perl refuses to tell me how to A) find out if there's a stub or B) replace said stub.
22:02 jcamins What is the idiomatic way to check if an item exists in an array?
22:03 * rangi is trying to help the pasifika koha users group install koha over in another window
22:03 rangi so not paying much attention
22:04 jcamins for?
22:04 rangi if you want to do it more than once
22:05 rangi map it to create a hash, then exists
22:05 gmcharlt jcamins: List::MoreUtil any, perhaps
22:05 rangi if once, iterating
22:05 rangi both methods iterate, but the map makes the iteration prettier, and once its mapped you can do as many exists as you want
22:06 gmcharlt both of rangi's ideas will work too
22:06 jcamins Yeah, I think iterating is the way to go. The order of elements is significant, and we only have to check once per recursion.
22:06 gmcharlt but List::MoreUtil::any *might* be faster since it's a C routine, at least if you only need to check the existance once
22:09 * jcamins thinks perhaps going with a for loop that he can definitely understand is probably superior in this case.
22:11 jcamins Ha!
22:11 jcamins It works!
22:11 jcamins cait: new squashed patch?
22:11 jcamins Or do you want another follow-up?
22:11 cait hm yeah
22:11 cait let me sqash it all
22:12 cait later
22:13 jcamins Okay.
22:13 jcamins Attached.
22:13 cait i will only take a quick look and continue tesitng tomorrow
22:13 cait getting late here
22:14 jcamins You should see how beautiful it is, though. All four levels showing up. :)
22:14 cait I hope for you they do this time ;)
22:14 gmcharlt |Lupin|: there's probably no general way -- source filters (among other things) are used for decrypting obfuscated source code; so if there was an easy way to do what you want without having to dig into the guts of the interpreter, source encryption modules would be useless
22:15 gmcharlt (not, of course, that I'm a fan of encrypting source code!)
22:17 jcamins wajasu: were you able to apply the patch?
22:17 cait 4 levels!!!
22:18 rangi well that was a lot harder than having a usable internet connection that can hold up audio would have been
22:19 |Lupin| gmcharlt: yeah I think encryption is what the authors had in mind... I got help on "perl actually. The script was first uu-encoded and then Compressed...
22:19 wajasu jcamins: nope. everything but 8211. sha1 information is lacking or useless (t/db_dependent/Search.t)
22:19 jcamins wajasu: okay, I will try a new branch.
22:20 wajasu thx
22:21 jcamins wajasu: okay, tried again.
22:22 jcamins See if this one will apply.
22:22 wajasu is see it. tries again.
22:30 wajasu jcamins: it applied. testing now.
22:30 * jcamins breathes a sigh of relief.
22:31 * wajasu the suspense is killing me
22:31 jcamins wajasu: you're going to be disappointed once you test it. You're not going to have enough data for it to be particularly useful.
22:32 * jcamins optimistically hopes it works.
22:46 cait night all :)
23:03 wajasu jcamins: somewhat working. but lets verify my config. i added the three authorities as per 8211 comment #2. does the rlin# in subtag 9 need to match the authority record# ?
23:03 wajasu search number #3 and #4 worked.
23:04 wajasu comment #3
23:04 jcamins wajasu: no, shouldn't be necessary.
23:04 wajasu search #2 (su-br: gave me united states, arizona, and phoenix
23:05 jcamins The records that come up when you search "su:Phoenix" don't come up when you just search "su:United States" or "su:Arizona" right?
23:07 wajasu su:Arizona returned the Arizona and the Phoenix
23:08 jcamins Okay, that means that the record for Phoenix has a subject you want to remove.
23:08 wajasu Su:Phoenix just gave me Phonenix.
23:08 jcamins Right.
23:08 wajasu ok let me check
23:08 jcamins I had this problem too.
23:09 * jcamins originally had a record with the subjects "Phoenix" and "Arizona--Cities."
23:09 jcamins I should have mentioned this restriction.
23:09 wajasu it s a book, 100 best restaurants in the Valley of the Sun, and had a restaurant arizona in subject. let me reomve it
23:09 jcamins (that it's hard to test if more than one term appears in a record)
23:11 wajasu it was in 650 a topical term
23:11 jcamins Yep.
23:11 jcamins That'll do it.
23:12 wajasu that did it. after i rebuild-zebra. Hooray !!!!
23:12 jcamins Yay!
23:12 jcamins And don't forget the unit tests.
23:13 |Lupin| time for sleeping
23:13 |Lupin| goodbye all !
23:13 wajasu did you right some for this bug specificially, or just run em all.
23:13 jcamins Search.t has tests specifically for that bug, but I like running them all.
23:14 wajasu ok.
23:14 jcamins (any that failed in the past for you will still fail, of course)
23:14 wajasu right.
23:14 jcamins Myshkin (our cat) likes running all the tests too.
23:33 wajasu jcamins: just a heads up. when i do a rebuild-zebra -a -b -r i get -> zebraidx(25864) [warn] Unknown register type:
23:33 jcamins wajasu: yeah, there's a patch for that.
23:33 jcamins Nothing to do with this.
23:34 jcamins cait has been complaining of it for about a month.
23:36 wajasu i am doing prove/t prove t/db_dependent prove/xt
23:46 wajasu waiting on db_dependent.
23:55 pastebot "wajasu" at 127.0.0.1 pasted "result of my prove t/db_dependent after 8211 patch test" (379 lines) at http://paste.koha-community.org/163
23:57 jcamins Yup, those were all failing before.
23:57 wajasu t and xt were all succcessful.
23:58 wajasu i'm doing format-patch -s master now
23:58 wajasu after commit --amend