Time Nick Message 00:25 oleonard-away Wainui: You can upload tool plugins via the Admin page can't you? 00:26 oleonard-away Yeah. I think the assumption is that only admins should be installing plugins anyway. 00:26 * oleonard-away really away 02:58 * dcook waves 02:59 dcook Bugzilla broken for anyone else or just me? heh 03:00 dcook rangi: Just sending you an email now about my account being locked out 04:47 * dcook blinks 06:17 reiveune hello 06:51 alex_a Bonjour 06:52 magnuse \o/ 07:11 ashimema Good Morning #koha 07:28 magnuse kia ora ashimema 08:00 nlegrand Hey 08:01 ashimema hi nlegrand 08:02 nlegrand o/ ashimema 08:59 severine_q Hi #koha ! 09:01 nlegrand Salut severine_q. 09:01 Joubu postponing last dev meeting 09:02 severine_q bonjour nlegrand :) 09:02 Joubu #startmeeting Development IRC meeting 24 March 2021 09:02 huginn Meeting started Tue Apr 6 09:02:06 2021 UTC. The chair is Joubu. Information about MeetBot at http://wiki.debian.org/MeetBot. 09:02 huginn Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 09:02 huginn The meeting name has been set to 'development_irc_meeting_24_march_2021' 09:02 severine_q et bonjour Joubu ! 09:02 Joubu #info Next meeting: 7 April 2021, 15 UTC 09:02 Joubu #endmeeting 09:02 huginn Meeting ended Tue Apr 6 09:02:55 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 09:02 huginn Minutes: https://meetings.koha-community.org/2021/development_irc_meeting_24_march_2021.2021-04-06-09.02.html 09:02 huginn Minutes (text): https://meetings.koha-community.org/2021/development_irc_meeting_24_march_2021.2021-04-06-09.02.txt 09:02 huginn Log: https://meetings.koha-community.org/2021/development_irc_meeting_24_march_2021.2021-04-06-09.02.log.html 09:02 Joubu tomorrow then 09:03 Joubu and hi #koha :) 09:23 Joubu fridolin: you forgot to adjust the "latest" tar.gz, they are still pointing to 20.11.03 09:28 fridolin Joubu: ah oups i'm on it 09:30 fridolin done 09:36 Joubu thx frido 09:51 ashimema morning 09:53 cait1 oh 09:53 cait1 morning and wb Joubu 09:54 ashimema Hope the move went smoothly Joubu :) 09:55 Joubu still a lot of mess everywhere but it's starting to be livable :) 10:39 thd Welcome back Joubu 10:40 oleonard Hi all 10:40 thd hello oleonard 10:41 thd https://koha-mw-pg-test01.agogme.com/wiki/Main_Page # 2 week old copy in Postgres 10:41 thd https://koha-mw-my-test01.agogme.com/wiki/Main_Page # converted to MySQL binary properly 10:42 thd Joubu are you available for a moment? 10:45 Joubu Hi thd, yes I am 10:45 thd https://koha-mw-my-test01.agogme.com/wiki/Main_Page # converted to MySQL binary properly 10:46 thd that instance can be upgraded to MediaWiki 1.35 10:47 thd I think that it will be easier to mark everything as old_content with a global change and then mark selected things current thus searching with embedded code in the search can distinguish. 10:48 thd Joubu: I am having two problems. 10:49 thd One is that it should be possible to insert NULL into MySQL int columns which have a NULL default. Am I missing something about NULLs with MySQL int data type? 10:52 thd The other is that this fails with a warning colconv.append( lambda x: ( str( x )[:300] if len( str( x ) ) > 300 else x ) if x else '' ) # truncating for varbinary(300) not NULL 10:52 thd maybe I need to set it for 299 10:54 thd While this works: colconv.append( lambda x: ( str( x )[:254] if len( str( x ) ) > 254 else x ) if x else '' ) # truncating for tinyblob not NULL 10:56 thd Joubu: If you ran http://www.winterrodeln.org/trac/browser/servermediawiki/trunk/pgsqltomysql/pgsqltomysql.py without making very many modification you would have had warnings about many columns for which the data was not converted. 10:59 thd Joubu: Any thoughts about inserting NULLs in MySQL int columns? 11:00 thd {some condition} else "NULL" raises a warning 11:02 Joubu yes it's possible to have NULL for integers 11:02 thd I will publish the code I have tomorrow with or without solving those two problems. 11:02 Joubu which warning to you get? 11:02 Joubu do* 11:03 thd A python Warning about incorrect data type. 11:04 thd Maybe I should try {some condition} else "IS NULL" 11:05 thd Joubu I had no warnings in Nov. 2019 when I considered the work nearly finished before COVID etc. happened. 11:06 Joubu I got an error about integers 11:06 Joubu cannot remember which one however 11:06 Joubu I am searching for the patch I wrote 11:06 thd However, I had not tested putting up a live system and I had double quoted everything which was not good. 11:13 thd I had used {condition} else "NULL" for some non-integer columns with no problem 11:15 Joubu I have a 1.16.tables.sql file that I retrieved from their src 11:15 Joubu and a commit that modifies it 11:15 Joubu - ar_user int unsigned NOT NULL default 0, 11:15 Joubu + ar_user int unsigned NULL default 0, 11:15 Joubu stuffs like that 11:15 Joubu looks related to your problem 11:16 Joubu do you want me to share the patch? 11:16 thd ... but maybe the else had never been reached for the non-integer columns. 11:16 thd Yes. 11:17 Joubu http://paste.koha-community.org/217 11:18 Joubu I generated the 1.16 schema with: 11:18 Joubu git show 50c5cd7c32138237407a6d622598cce7a8b951e3:maintenance/tables.sql > 1.16.tables.sql 11:18 thd default 0 is the most common default but some from 1.16 are of the form int(10) DEFAULT NULL 11:18 tcohen morning 11:19 tcohen Joubu welcome back! 11:19 tcohen follow-up on bug 28017 11:19 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28017 normal, P5 - low, ---, tomascohen, Pushed to master , Allow non-FQDN and IP addresses in emails 11:20 Joubu thx, Tomas! 11:23 thd Joubu: That patch would not change the int(XX) DEFAULT NULL columns which I identified from building 1.16 with my Debian time machine. 11:26 thd Joubu: What it does change is to eliminate some default not NULLs and substitutes default '' or 0 as appropriate for the data type but in a small number of cases. 11:30 Joubu IIRC it fixes the postgres to mysql script. Without the changes the exec crashes with a python error 11:30 Joubu but I didn't note the exact error unfortunately 11:33 thd Joubu: Yet, the code which you posted seems to be designed to change the SQL structure to be loaded, not the python script itself. 11:34 Joubu yes but I assume the mysql python lib uses the datatype from the DB to validate the data 11:34 thd Yes, exactly 11:35 thd However, I would be concerned that the MediaWiki PHP code would not be expecting your changes. 11:36 Joubu my goal was to migrate the DB to dokuwiki so I didn't care about that 11:37 thd I was very conservative about DB alterations and only extended 4 textual columns to allow for the slightly larger size we have for some legitimate textual data in the Koha wiki. 11:37 thd Whatever we do for the wiki the archive of old stuff should run something current. 11:39 thd I still think it will be less work to manage everything in one wiki as the archive will always need to grow over time and finding old content would merely be a special search. 11:40 thd That is over time we will always be finding that many pages become out of date or loose relevance. 11:41 thd s/loose/lose/ 11:43 thd It takes 5 min or so to drop everything and regenerate a working version for testing on my VPS. 11:44 thd Off to drop things and try regenerating with "IS NULL" instead of "NULL" for int data type. 13:01 magnuse if anyone has a hunch about Bug 28094 i'm all ears... 13:01 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28094 normal, P5 - low, ---, koha-bugs, NEW , Fix bad encoding of OVERRIDE_SYSPREF_LibraryName 13:18 Joubu oleonard: Hi Owen, is that correct to remove "html" for on-site_checkouts.tt on bug 27974? 13:18 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 enhancement, P5 - low, ---, oleonard, Passed QA , Replace obsolete title-string sorting: Circulation templates 14:01 huginn News from kohagit: Bug 28047: (QA follow-up) Fix a few more Callnumber entries <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=fd42e891862861d1d79629635b4d96ebbba8fb9a> 14:01 huginn News from kohagit: Bug 28066: Remove select tag's size attribute where it is 1 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=58446226657c6dd32e15c7e1e98fb0d2155f003a> 14:01 huginn News from kohagit: Bug 28055: Convert DataTables option names to current version <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=627897857cd493324ae875e0763cb20a961f919c> 14:01 huginn News from kohagit: Bug 28066: (QA follow-up) Fix some single quote occurences <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f50897bd2539cd27412f680c23e29d306de9b542> 14:01 huginn News from kohagit: Bug 28047: Standardize: Call number, callnumber, Call no. etc. <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7b33ad0bd4f32276b761620da8e10ca87414315e> 14:01 huginn News from kohagit: Bug 28046: Add "Additional fields" link on acquisition navigation menu <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b258a0684473da3f04c3b0835c821de3a03b1ad3> 14:01 huginn News from kohagit: Bug 28006: Restore "Additional fields" on navigation menu <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9fae22c77efa15ced2dc05c07cdfcfeef401cd94> 14:01 huginn News from kohagit: Bug 28041: Improve breadcrumbs and headings on label creator pages <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8a3392bbbe16f50a9f6e42d2166fca5016effaa8> 14:01 huginn News from kohagit: Bug 28037: Improve breadcrumbs of CSV profiles page <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=18bbf42b33cc1872bd9fea5c495abf0b97df7b04> 14:01 huginn News from kohagit: Bug 28036: Improve breadcrumbs of serial claims page <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1fc05de2ef183541abbeb5b022c4311227af81bd> 14:01 huginn News from kohagit: Bug 28035: Improve breadcrumbs of cataloging search page <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dc13552ddc2dc548bfeedf31444e595b34766e4d> 14:01 huginn News from kohagit: Bug 28007: (follow-up) Address missing instances <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c96821861be4692487278aeb23c200f593cd2494> 14:01 huginn News from kohagit: Bug 27998: (follow-up) Address missing instances <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=769556b42a8ad2aadf89318094a5e828909e7991> 14:01 huginn News from kohagit: Bug 27994: (follow-up) Address missing instance <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e0c2ee57adbfe729dc7779fd47f8a1d3b77bd5bd> 14:01 huginn News from kohagit: Bug 28018: Replace obsolete title-string sorting: OPAC templates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=da2d583591b0896367b81374725cefa4e1719d7d> 14:01 huginn News from kohagit: Bug 28016: Replace obsolete title-string sorting: Assorted templates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=565591f649835da69d7f05032cd3064ed8266890> 14:01 huginn News from kohagit: Bug 28007: Replace obsolete title-string sorting: Tools templates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=78d504eb06c326e14c8a2202bac198353b5f0568> 14:01 huginn News from kohagit: Bug 27998: Replace obsolete title-string sorting: Serials templates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e44b187b4720bb419c00e8afd50b80b4bca07958> 14:01 huginn News from kohagit: Bug 27994: Replace obsolete title-string sorting: Reports templates <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=67a60c24a3e42980d62ba3272478f387ce5514a5> 14:01 huginn News from kohagit: Bug 27991: Message field for OPAC problem reporting should have a maxlength set <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8bb9cb649bf36a650d3b84c29c5c9ddd3b01caa5> 14:36 koha-jenkins Yippee, build fixed! 14:36 koha-jenkins Project Koha_Master_D9_MDB_Latest build #554: FIXED in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D9_MDB_Latest/554/ 15:07 koha-jenkins Yippee, build fixed! 15:07 koha-jenkins Project Koha_Master_D11 build #251: FIXED in 1 hr 6 min: https://jenkins.koha-community.org/job/Koha_Master_D11/251/ 15:09 koha-jenkins Project Koha_Master_U2010 build #138: STILL UNSTABLE in 1 hr 8 min: https://jenkins.koha-community.org/job/Koha_Master_U2010/138/ 15:09 koha-jenkins Yippee, build fixed! 15:09 koha-jenkins Project Koha_Master build #1606: FIXED in 33 min: https://jenkins.koha-community.org/job/Koha_Master/1606/ 15:13 koha-jenkins Yippee, build fixed! 15:13 koha-jenkins Project Koha_Master_D9 build #1606: FIXED in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1606/ 15:13 koha-jenkins Yippee, build fixed! 15:13 koha-jenkins Project Koha_Master_D9_My8 build #537: FIXED in 1 hr 11 min: https://jenkins.koha-community.org/job/Koha_Master_D9_My8/537/ 15:47 reiveune bye 15:52 severine_q bye "koha ! 15:55 pastebot "tcohen" at 127.0.0.1 pasted "Joubu, ashimema" (12 lines) at http://paste.koha-community.org/224 15:56 ashimema hmm, seems reasonable tcohen.. will try to wrap my head around the related bug soon 15:57 tcohen oops 15:58 pastebot "tcohen" at 127.0.0.1 pasted "=head3 extended_subfields my $" (40 lines) at http://paste.koha-community.org/225 15:58 tcohen I intended to paste it all, not just the POD LOL 16:02 ashimema hehe 16:02 tcohen Joubu thoughts? 16:04 Joubu what's the context? 16:05 tcohen messing with your work on bug 27526 16:05 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Remove Mod/AddItemFromMarc from additem.pl 16:07 tcohen I think it is wrong, as it should be respecting subfield appearance order, right 16:07 tcohen ? 16:08 tcohen you added that feature, right, Joubu? 16:08 Joubu yes, bug 8976 16:08 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 enhancement, P1 - high, ---, jonathan.druart, Pushed to master , Default sequence of subfields in cataloguing editor 16:09 Joubu but I wouldn't care about the order 16:10 tcohen would you accept a polished version of bug 26635? (i.e. having a _authorised_values attribute containing them) 16:10 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 enhancement, P5 - low, ---, agustinmoyano, Signed Off , Expand authorised values in REST API call 16:10 Joubu your sub makes sense, to make it clear we don't deal with the order you could return a hashref :D 16:10 tcohen I want it all to fit together 16:10 tcohen shouldn't we care about the order? 16:11 ashimema hum, I could imagine people wanting to care about order 16:11 Joubu I don't know, it depends on how you want to call it 16:11 tcohen that code is missing the av_expand parameter handling 16:13 Joubu I'm afraid my head is full for today, not sure I could help much tonight 16:14 Joubu I don't think I understand what's the question exactly 16:14 Joubu if you are asking me if you can improve something, my answer will always be yes :D 16:14 Joubu (well, almost always) 16:16 koha-jenkins Yippee, build fixed! 16:16 koha-jenkins Project Koha_Master_D10_CPAN build #280: FIXED in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_Master_D10_CPAN/280/ 20:09 magnuse @karma 20:09 huginn magnuse: Highest karma: "Joubu" (965), "cait" (840), and "ashimema" (620). Lowest karma: "-" (-68), "failed" (-47), and "ie" (-40). You (magnuse) are ranked 16 out of 1091. 21:12 rangi hey all, currently upgrading the OS on the linode running bugs (and other stuff) it shouldn't take long 21:13 * cait waves 21:13 cait hi rangi 21:28 rangi right should be all done 21:32 cait a behind the scenes updaes or new things to discover? 21:34 rangi xenial -> bionic 21:34 rangi so nothing should change 21:34 rangi just xenial is out of support in a couple of months 21:34 cait ok and thanks for updating :) 21:34 cait rangi++ 21:46 rangi @later tell magnuse i should be around on irc a little more in the future 21:46 huginn rangi: The operation succeeded. 21:47 oleonard rangi++