Time Nick Message 00:02 dcook bug 36261 00:02 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36261 normal, P5 - low, ---, dcook, NEW , Calculating OpacHiddenItems is too slow in OPAC search 00:03 dcook I think I've solved the OpacHiddenItems problem. Weeeee. Patch will be posted in due course though >_> 06:39 reiveune hello 07:31 magnuse \o/ 08:58 ashimema dcook++ 09:00 marcelr o/ 09:01 magnuse shouldn't "koha-translate -l -a" give some output on kohadevbox? 09:04 cait hm maybe you need --dev? 09:09 fridolin hi 09:13 magnuse cait++ 09:14 cait glad it worked 09:36 magnuse anyone had problems with changing the language in 23.11? 09:37 cait hm saving hte preferences or switching langauge? 09:37 cait if the latter, check your base urls 09:38 magnuse we have one instance that was installed as 23.05 and then upgraded to 23.11 where changing the language works. but then we have an instance that was installed as 23.11 directly where changing the language does not work... 09:38 magnuse switching the language 09:39 magnuse base urls are ok 09:43 Joubu restarted the services? Language list is cached 09:45 cait what does "does not work" mean 09:46 cait are the links there, but clicking doesn't work? or does it work, but language remains english? 09:49 magnuse Joubu: restarting the whole server has been tested 09:50 cait magnuse: what about my question :) 09:51 magnuse cait: yes the links are there, but clicking them does nothing 09:52 magnuse logs show normal behaviour: 302 redirect from changelanguage.pl to the page i was on 09:59 cait hm 09:59 cait did you reisntall the language? maybe something went wrong there? 10:00 magnuse the translated template files are missing! 10:01 magnuse "koha-translate -i sv-SE" says the language is installed 10:02 magnuse "koha-translate -u -v sv-SE" says the translated files are being created, but they are not there afterwards 10:03 cait i woudl try removing and readding 10:03 cait i think we had some reports about a problem where that helped the issue 10:04 magnuse uninstall the language and the reinstall? i think we have tested that too 10:05 magnuse *then 10:07 paulderscheid[m] morning #koha 10:07 Joubu a language is assumed "installed" if the lang dir exists in staff/prog or opac/bootstrap 10:07 Joubu it should not be 'or' but 'and' 10:07 paulderscheid[m] just read the emails concerning letters. Didn't you already deprecate the old syntax in factor of TT ashimema? Or do I remember that wrong? 10:07 paulderscheid[m] in *favor 10:07 Joubu magnuse: if still possible, please confirm that the lang dir exists in at least staff or opac 10:08 ashimema I've been trying to for years 10:08 ashimema But it requires updating all existing default notices 10:08 ashimema Improving the UI 10:08 ashimema And some other steps 10:09 ashimema And the support just hadn't been there to do all that 10:09 paulderscheid[m] Ok, in my head I thought that was already done for some reason 10:09 paulderscheid[m] Not sure why :D 10:09 ashimema The UI still puts <<>> params in.. well never remove the use of that whilst the UI encourages it's use 10:10 Joubu bug 17961 was the hard part 10:10 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 enhancement, P5 - low, ---, jonathan.druart, CLOSED FIXED, TT syntax for notices - Prove we have an equivalent for our historical custom syntax 10:10 ashimema There also some really funky logic around some special placeholders that use the old syntax.. things that are not trivial to replace 10:10 Joubu now, if we don't have nothing new to adjust, it should be trivial to move the existing notice templates 10:10 Joubu I don't underestand what's blocking you ;) 10:10 Joubu bugs related to bug 15278 don't have patches 10:10 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 enhancement, P5 - low, ---, kyle, NEW , [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit 10:11 ashimema Lack of support 10:11 paulderscheid[m] Alright thanks for the clarification 10:11 ashimema Lack of people bothering to test 10:11 ashimema Years between patch submission and test and QA and push 10:11 Joubu yes, I can imagine, I didn't get any when I worked on it... in 2017 10:11 ashimema I gave up basically.. it was a roadmap project for cycle after cycle after cycle 10:11 ashimema yup 10:11 Joubu if we all say "I don't get support", it's... sync problem then 10:12 Joubu but it's still on the roadmap 10:12 paulderscheid[m] Is this very time consuming to test? 10:13 ashimema my motivation for Koha is at an all time low I'm afraid so I'm not likely to pick this up again any time soon 10:13 paulderscheid[m] Ok 10:13 Joubu it's time consuming to write patches, and they are very boring 10:13 ashimema I had a whole plan mapped out but so much time has passed that I have no idea what that plan was any more 10:13 paulderscheid[m] Time is the only thing I don't really have. 10:14 Joubu bug 36260 - looks like Emily is working on it? 10:14 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36260 enhancement, P5 - low, ---, koha-bugs, NEW , Port default PROBLEM_REPORT notice to Template Toolkit syntax 10:14 Joubu Reported 2024-03-06 22:25 CET by Emily Lamancusa 10:14 domm[m] Search question: It seems that in the default ES Mappings, pl (publisher location) maps to 008/15-17. Wouldn't 264$a make more sense? (as 3 letters for a location seems a bit terse..)? Or is this one of these cases where nobody agrees and different countries/cultures use different fiels, and we should just NOT use the default mappings? 10:15 magnuse Joubu: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/sv-SE/ exists, but permissions are "drwxr-x---" 10:15 magnuse Joubu: for languages that work on another server, permissions are "drwxr-xr-x" 10:16 Joubu magnuse: guess you chmod after they have been installed, or umask is not the default on this server 10:19 magnuse Joubu: we have not chmod'ed after installing the language, but umask could be a thing 10:19 ashimema it's not just about converting the existing notices though.. it's also about preventing end users from using the old syntax.. and encouraging them to use the new. 10:19 ashimema we need a solution for previews and a solution for the editor 10:19 ashimema bug 15277 10:19 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 enhancement, P5 - low, ---, kyle, NEW , Add Template Toolkit syntax for slips and notices to editor 10:19 ashimema bug 31510 10:19 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 enhancement, P5 - low, ---, martin.renvoize, NEW , The notice template tag helper still uses <<>> sytnax.. we should move to TT instead 10:20 ashimema bug 35268 10:20 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35268 enhancement, P5 - low, ---, koha-bugs, NEW , Add CodeMirror editor as an option for html notices 10:20 ashimema bug 35285 10:20 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Centralise notice content wrapping for html output 10:20 magnuse Joubu: we set the right permisson on /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/sv-SE/, but after "koha-translate -u sv-SE" the permissions were wrong again 10:20 ashimema bug 24793 10:20 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24793 enhancement, P5 - low, ---, koha-bugs, NEW , TinyMCE for HTML notices 10:20 ashimema all those need people to discus an approach and code on 10:22 ashimema Joubu: OK.. this isn't as trivial as it looks as we do special cases for 'borrower-attribute:CODE' replacements and possibly others.. as such we can't just change <<>> into [%%]. 10:22 ashimema that was one thing holding me back 10:23 * ashimema needs coffee 10:23 cait domm[m]: 008 is normalized, $a is not 10:23 cait oh, I misread that as the year, ignore please 10:24 cait I believe we do have another mapping, let me check 10:25 Joubu is there a bug for 'borrower-attribute:CODE'? 10:25 Joubu ashimema: is there a bug for 'borrower-attribute:CODE'? 10:26 ashimema Don't think so 10:26 ashimema It was something I spotted and commented on somewhere 10:26 ashimema Bug 31510 10:26 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510 enhancement, P5 - low, ---, martin.renvoize, NEW , The notice template tag helper still uses <<>> sytnax.. we should move to TT instead 10:26 ashimema That's where I commented 10:27 Joubu never seen that borrower-attribute:CODE, is that advertised somewhere? used? 10:27 Joubu if not we can remove 10:27 Joubu and people can implement/pay to get it back 10:28 Joubu (yes, that's not a popular opinion, but we will need to get there at some point...) 10:29 Joubu now we are getting hit by critical security bugs because refactoring is hanged by those silly old and unadvertised hidden features, just cut them and move on :D 10:29 ashimema it's not in any of the default templates by the looks 10:29 ashimema I'm sure it used to be so maybe I already managed to removed it from those 10:29 ashimema but it's certainly in letter.pl and Letters.pm 10:30 ashimema totally agree 10:33 cait domm[m]: Zebra has an index pl on 264/260 a: https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml#L463 - I wonder if that was missed in Elasticsearch 10:33 domm[m] seems so :-) 10:34 cait can you remind me where we put the config file for elastic? 10:34 Joubu admin/searchengine/elasticsearch/mappings.yaml 10:34 domm[m] huh, I always look at the web view /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl 10:34 Joubu 3110 marc_field: 264b 10:34 Joubu 3111 marc_type: marc21 10:34 Joubu not a 10:35 domm[m] This remindes me: Is there a way to overwrite admin/searchengine/elasticsearch/mappings.yaml with the current ES mappings? So reset-mappings does not destroy all the custom config? 10:36 Joubu domm[m]: the yaml file is picked at install time and inserted in DB 10:36 cait a = place, b = publisher, c = year 10:36 cait talking about place it should be a 10:36 Joubu the UI is the view of the DB 10:36 Joubu you cn reset the DB with the yaml content, using the "reset" button on the UI 10:37 Joubu cait: yes, 264b is used for 'publisher' 10:37 domm[m] yes, but I need it the other way round. we have quite a few fixes / improvments in the DB mappings. But clicking on the reset-button replaces those with the default (which are (as we're seeing now) not 100% correct and in addition not a perfect fit for everybody)) 10:38 cait https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678 10:38 huginn` 04Bug 24678: enhancement, P5 - low, ---, koha-bugs, RESOLVED FIXED, Add missing search fields to Elasticsearch mappings 10:38 cait it looks like it was noted there that a was still missing - we shoud fix it 10:38 cait domm[m]: we don't update defalt for existing installations, but we should improve the default for new ones at least - could you maybe patch? 10:38 cait on a new bug 10:38 ashimema we could really do with a diff tool there 10:39 ashimema rather than just a reset we should be able to see default vs changes 10:39 domm[m] I might be able to work in this during the hack fest 10:39 cait i mean we don#t update what is in the db, but we do update the default file 10:39 ashimema ineed 10:39 Joubu domm[m]: misc/search_tools/export_elasticsearch_mappings.pl 10:39 domm[m] ok, I'll create a bug for pl=>264$a 10:40 domm[m] Joubu: ah, nice, perfect! 10:43 cait still worth fixing the default :) 10:43 domm[m] cait: but using 008/15-17 for publisher-location is wrong? According to https://www.loc.gov/marc/bibliographic/bd008.html it seems to make sense, but I would assume that using a proper field which can contain more than 3 letters makes more sense? 10:43 magnuse Joubu: looks like you were right about umask. now we only need to figure out why it was changed and how to fix it. thanks a ton! 10:43 magnuse cait++ Joubu++ 10:44 cait domm[m]: maybe having the index broader is not a bad thing, I am not sure if it's confusing or not 10:45 cait like put 260a (non-RDA), 264 (RDA) and 008 15-17 in it? 10:45 cait magnuse: did you fix it? 10:47 magnuse cait: not yet, it's on a customer server, so we need to make sure we don't mess anything up :-) 10:47 domm[m] cait: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 10:47 huginn` 04Bug 36269: enhancement, P5 - low, ---, koha-bugs, NEW , ElasticSearch: publisher-location (pl) index should use 264a 10:48 cait magnuse: fingers crossed then 10:48 magnuse :-) 10:58 ashimema ack 10:59 ashimema borrower-attribute:code isn't documented.. but it IS in the picklist we display at the left of the notice editor.. hence why I felt we couldn't just drop it Joubu âšī¸ 11:00 ashimema it's a mess of chicken/egg problems the notices stuff.. we really need to replace the editor before we can drop the syntax 11:31 mtj hey #koha 11:32 mtj hi fredericd, did you want me to push the new 22.11.15 pkg now? 11:44 cait not sure if he is around -do we expect a problem with making it available? 11:50 mtj hi cait, he email me 'yes' :) 11:54 cait just aw it :) 11:54 cait saw 11:55 asymar[m] hi, I added a comment to this BUG 33898: I was curious to know if anyone else had experienced the same issue. 11:55 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 minor, P5 - low, ---, kyle, Failed QA , background_jobs_worker.pl may leave defunct children processes for extended periods of time 12:06 tcohen hola #koha o/ 12:07 ashimema hi tcohen 12:08 ashimema \o 12:16 cait hola tcohen 12:23 tcohen hey cait 12:34 PedroAmorim[m] o7 12:34 PedroAmorim[m] tcohen++ 12:41 cait I am gearing up to push things - I'll start with the easier bug fixes, but I'll definitely aim for daily pushes from today again 12:41 tcohen cait: count on me if you need a backup 12:41 tcohen and YAY! 12:41 cait heh, ask me again in an hour :) 12:41 cait but going in 12:43 ashimema +1 13:10 cait ahs someone had a look at the Jenkins failiure yet? https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/(root)/Should%20correctly%20display%20labels/Infinite_scroll_Should_correctly_display_labels/ 13:12 cait ok, looks like thisis bug 36012 13:12 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 normal, P5 - low, ---, chris, NEW , ERM/Agreements_spec.ts is failing if run too slow (?) 13:18 tcohen hola wizzyrea !!! 13:20 magnuse cait\\ 13:20 magnuse heia, wizzyrea! 13:21 magnuse gah 13:21 magnuse cait++ 13:21 cait :) 13:21 cait can someone confirm suggestion form in OPAC is not coming up? 13:21 cait I only get an empty page when clicking "new suggestion" 13:23 cait nothing in logs 13:25 tadzik hello #koha 13:25 cait kidclamp: bug 36274 - shoudl this go on the pad? 13:25 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36274 major, P5 - low, ---, oleonard, NEW , OPAC suggestions form doesn't display 13:25 tadzik it seems to me that https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655 from ~6 years ago is either doing too much, or has regressed somehow, and I'm not sure what the author's original intent was there 13:25 huginn` 04Bug 19655: critical, P5 - low, ---, kyle, CLOSED FIXED, To.json doesn't escape newlines which can create invalid JSON 13:26 cait if it was 6 years ago a lot can have happened in between - let's start with the issue you see now? 13:26 tadzik the patch (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69326&action=diff) does extra escaping after JSON->encode is done, but JSON already escapes newlines, and this leads to double encoding 13:26 cait our codebase moves somewhat fast 13:26 cait I'd suggest to file a new bug, linked with depends on to the old one for reference 13:27 tadzik the issue I see now is that passing a struct with newlines in it to To.json causes double-escaping, so I end up with \\n instead of regular encoded newlines 13:27 tadzik but it seems a bit obvious and also my desired behaviour is something that someone decided to solve, so I wonder if I'm doing something stupid and is this a bug at all :) 13:28 puphaus[m] <cait> "can someone confirm suggestion..." <- hi, yes i got the same behaviour in my ktd on master 13:28 cait puphaus[m]: thanks! 13:28 cait puphaus++ 13:32 cait not a 'me' problem then 13:36 puphaus[m] <cait> "nothing in logs" <- its really strange but i got something in my logs :D 13:37 puphaus[m] [2024/03/07 13:35:52] [WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt line 372. 13:37 puphaus[m] [2024/03/07 13:35:52] [WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt line 527. 13:40 cait hmI think these should be only warns 13:40 cait not breaking failure 13:42 puphaus[m] oh yes sorry written faster than I thought :D 13:43 cait all good, thanks for helping out! 13:44 puphaus[m] no problem, happy to help :) 13:50 cait hm, do bugzila emails work for you all? 13:50 cait my newest ist from yesterday, but I just made some changes 13:51 cait oh I see - i got disabled 13:52 cait not sure how that happened, but should hopefully be fixed now 14:03 cait ok, first 20 bugs incoming :) 14:04 ashimema đ 14:07 cait I'll do another sprint after making a fresh pot of tea 14:27 magnuse choose your preferred dates for the next gbsd, please! https://terminplaner6.dfn.de/en/p/4939a0075ab483d3d337f955859f824f-633050 14:41 cait PedroAmorim++ providing great test plans 14:54 magnuse PedroAmorim++ 14:54 magnuse @karma 14:54 huginn` magnuse: Highest karma: "Joubu" (1314), "cait" (1107), and "ashimema" (929). Lowest karma: "-" (-86), "failed" (-53), and "ie" (-41). You (magnuse) are ranked 19 out of 1332. 15:00 cait PedroAmorim[m]++ # never sure if we shoudl keep the [m] or not 15:09 cait ashimema: around? 15:10 ashimema yup 15:10 cait I am testing bug 36100, verified problem, applied patches, restart all, still get the error 15:10 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100 major, P5 - low, ---, martin.renvoize, Passed QA , Regression in bookings edit 15:10 cait what could I be doing wrong? 15:11 ashimema restart plack? 15:11 cait restart_all does that, but I can do it again 15:11 cait oh iteresting 15:12 ashimema ? 15:12 cait I can save a change to the patron 15:12 cait but when i change the barcode do any item it's failure 15:12 ashimema interesting.. I've never thought to try and go that way around 15:12 ashimema that's likely an entirely different bug 15:13 cait yeah, maybe also realted to only have 1 item out of 3 being bookable? 15:13 ashimema trying to unset the item should just re-assign.. you can't have a booking without an item 15:13 ashimema nah 15:13 ashimema well.. I don't know without investigating 15:13 cait i thought it worked like holds = any item is not care 15:13 cait it#s ok 15:13 ashimema i can take a look on a new bug 15:13 ashimema no 15:13 cait I can update the booking dates and author 15:13 ashimema it tried to 15:13 cait not author, booking person? 15:14 cait so the patch seems to work 15:14 ashimema but doing just in time for bookings was too much of a brain melt for me in the end 15:14 ashimema yeah.. you should be able to change item or patron.. but the any item is a special case 15:14 ashimema should be dealt with separately I reckon 15:14 ashimema also, dates.. those can be changed too 15:14 cait yeah that also works 15:15 cait I'll leave a not eon the bug for now, so we don#t forget 15:17 ashimema thanks 15:17 cait also got the error from the logs there 15:34 ashimema âšī¸ 15:36 cait second batch of bugs incoming... 15:37 ashimema đ 15:37 ashimema 30 bugs to go, not bad cait 15:37 ashimema I can't remember what we started on at the beggining of the day. but it was a lot more than that 15:38 cait 35 bugs pushed exactly 15:38 cait I keep tabs 15:38 ashimema my word 15:38 ashimema we're orange again 15:38 cait the update bz script is still going 15:38 ashimema not seen orange in ages.. it's been red for so long that i forgot orange existed 15:38 cait wait a moment 15:39 cait the bookings tests have some complicated dependencies - i had a conflict there earlier 15:39 cait i might work through the depdencies (which are enh) first one by one 15:40 ashimema personally.. I'd just apply the tip and it'll pull all the rest 15:40 cait i tried that, but it doesn't work right now 15:40 ashimema they've been applying perfectly for months (and are all in live use on ptfs-e customers) 15:40 ashimema ok 15:40 cait maybe csrf 15:40 ashimema so something you pushed since messed it 15:40 cait a lotof those are template relatd 15:40 ashimema it applied this morning 15:40 ashimema so not csrf 15:40 ashimema I can rebase again 15:40 cait I am just letting you know, I will get back to that 15:40 ashimema ok 15:41 cait all the red is gone - ILL patches for CSRF mostly 15:41 cait and the runtime condition for rabbitmq - I hope that one goes well, fingers crossed 15:42 cait I'll do a bit more in a bit 16:02 reiveune bye 16:05 cait @later tell fridolin please grab bug 36176 out of the RM queue - it's for stable branches only 16:05 huginn` cait: The operation succeeded. 16:28 oleonard Hi #koha 16:28 cait hi oleonard :) 16:44 cait 9 bugs remaining in RM queue - back tomorrow 16:44 ashimema wow.. GREEN! 16:44 ashimema nice one cait 16:44 ashimema cait++ 16:44 cait on the bugs side at least 16:46 cait keeping an eye on the Jenkis failures and fixing them will allow me to keep pushing fast - so best place to help with right now :) 16:46 cait cya tomorrow 16:46 oleonard Anyone else having trouble with KTD lately? It keeps failing 16:47 cait I had to ktd down and ktd up a second time earlier today, but then it worked ok 16:47 cait using --es7 and --selenium 16:48 cait I moved some enh to be bugs, so we are yellow again, but tomorrow is another day 16:54 oleonard I never know what to look for when KTD fails like this 17:01 domm[m] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 now with a patch :-) 17:01 huginn` 04Bug 36269: enhancement, P5 - low, ---, koha-bugs, Needs Signoff , ElasticSearch: publisher-location (pl) index should use 264a 17:02 domm[m] I found it rather hard to test this in KTD, mostly because I "reset mappings" had no effect, and manually changing the mappings in the UI biblio tab also did nothing 17:02 domm[m] but shutting down KTD, applying the patch and starting it again, worked 17:17 puphaus[m] Maybe a slightly stupid question but do you always have to rebuild the zebra index after upgrades? I always did it but im not sure if it is always needed 19:40 marcosjuarez hola 19:41 marcosjuarez tengo un eror 500 en mi pagina de inicio 19:41 marcosjuarez soy nuevo en koha 19:42 caroline marcosjuarez, do you have access to the logs? 500 error can mean any number of things... 19:45 marcosjuarez hola me aparece el error 500 19:45 marcosjuarez soy nuevo en koha 19:45 marcosjuarez recientemente hice la instalacion 19:46 marcosjuarez cuando quiero acceder a apartado "bibliotecas" o "usuarios" me aparece el error 19:50 marcosjuarez hola