Time Nick Message
07:07 marcelr o/
07:19 marcelr Joubu: Use of uninitialized value $fileID in bitwise and (&) at /kohadevbox/koha/tools/upload-cover-image.pl line 101 - this was trivial
07:19 marcelr & instead of &&
07:21 Joubu heh I was having a look at the last changes on the branch and saw it yes
07:21 Joubu thanks
07:21 Joubu the solution was written in the warning...
07:24 marcelr these are the good ones
07:32 reiveune hello
07:36 fridolin le bonjour
08:35 paulderscheid[m] morning #koha
08:43 magnuse \i/
08:43 magnuse huh
08:43 magnuse \o/
08:43 Joubu so many wrong things in the recalls code
08:50 krimsonkharne[m] morning #koha :) anybody using a tablet instead of a pc for Koha?
08:50 krimsonkharne[m] (for staff interface use, that is - not for the server)
08:52 Joubu oleonard: could you test the recall area (if you are familiar with it) on the _svc branch?
09:19 paulderscheid[m] Hey Joubu, are we already using a library in Koha for URL validation?
09:20 Joubu I don't think so
09:20 magnuse paulderscheid[m]: looks like URI::Escape is the closest in this list: https://git.koha-community.org/Koha-community/Koha/src/branch/master/cpanfile
09:21 paulderscheid[m] Thanks magnuse
09:22 paulderscheid[m] Yeah, that just escapes stuff as the name suggests.
09:22 paulderscheid[m] Thanks anyway.
09:26 paulderscheid[m] I think this one is alright: Data::Validate::URI
09:27 magnuse sounds promising :-)
09:43 Joubu I need confirmation. On the checkouts table (circ/circulation.pl) we don't allow checkin if there are holds on the items.
09:43 Joubu We did it because the code is terrible and we don't manage that properly from this view
09:43 Joubu we now have "On hold" and the checkbox is not displayed
09:44 Joubu there is still JS code related to this feature, but I think it should be removed
09:44 Joubu hacking a bit the code I managed to get this input:
09:44 Joubu https://snipboard.io/haileC.jpg
09:45 Joubu "On hold due date"
09:45 Joubu Can you confirm that we should never see it? (and that I can remove the related code)
09:48 Joubu renew, not checkin
09:50 Joubu AllowRenewalOnHoldOverride
09:50 Joubu what's that?
09:50 Joubu the pref is off and I am seeing that: https://snipboard.io/1AprPK.jpg
09:53 Joubu all this is crazy, or I am missing something
09:54 Joubu my conclusion is that the pref is useless and the code related to "renew on hold" that is on the circ table can be removed
09:54 Joubu please confirm..
10:23 Joubu ashimema: around?
10:28 Joubu everything single piece of code I am looking at is broken... that's crazy
10:34 paulderscheid[m] I think you could have the possibility to renew something on hold for whatever reason.
10:34 paulderscheid[m] Although it's not a good patron experience™️.
10:35 paulderscheid[m] ' AllowRenewalOnHoldOverride ' This is just for the option to override default behaviour that a hold can NOT be renewed while it's on hold, right?
10:35 paulderscheid[m] * a checkout
10:36 Joubu @later tell ashimema 25261#211 please
10:36 huginn` Joubu: The operation succeeded.
10:37 Joubu in my testing, AllowRenewalOnHoldOverride is not taken into account
10:37 paulderscheid[m] Ok, that makes no sense then.
10:38 paulderscheid[m] If the Override is not enabled, you shouldn't be able to override.
10:39 ashimema sorry, was in a call
10:39 ashimema reading
10:40 Joubu paulderscheid[m]: we have 2 places to renew. on the checkouts table and the dedicated renew page. For historical reasons (ie. dirty code) we do not allow checkin or renew from the checkouts table if there are holds (and some other reasons).
10:40 Joubu There is code to deal with AllowRenewalOnHoldOverride on the checkouts table. BUT we do not allow renewal from this view!
10:41 Joubu And the syspref is not used for the regular "renew" page
10:41 Joubu but all this needs to be confirmed, the code is really confusing
10:42 ashimema the confirm parts stuff was never meant to touch renewals
10:42 ashimema only returns
10:42 paulderscheid[m] Can confirm: really confusing!
10:43 Joubu ashimema: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:629
10:43 Joubu $("#RenewChecked").on("click",function(){
10:43 Joubu - $(".confirm:checked:visible").each(function() {
10:43 Joubu - materials = $(this).data('materials');
10:43 Joubu this code is not at the right place then ;)
10:44 Joubu and not working when moved to the right place anyway (because of the refresh)
10:44 ashimema to me, it sounds like either a re-base issue, or a change since that's altered the end result
10:44 ashimema >The issues table allows for checkins and was not appropriately
10:44 ashimema requireing confirmation for the multi-part confirmation added in this
10:44 ashimema bug.
10:44 Joubu I am trying to adjust the code for the CSRF work. And finding bugs every 5 minutes is... hard
10:44 ashimema the commit message is clear regards intentions
10:44 Joubu at this point I just want to remove all the code that is not working
10:46 Joubu bug 30519
10:46 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 normal, P5 - low, ---, koha-bugs, NEW , Using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl
10:47 Joubu ok, I am removing the code
10:47 ashimema it should be tied to the 'Check in' checkbox
10:48 Joubu yes but it's not working anyway, the table is refreshed and we don't see the "Confirm" text
10:49 ashimema it was pushed in 2020 and it worked at the time
10:51 ashimema just removing it will create another regression for the functionality that it introduced
10:51 ashimema mwah
10:51 Joubu pretty sure it never worked
10:51 Joubu git show e4fa2eafda0575c39ca6deb7e00dc887921f77b3:koha-tmpl/intranet-tmpl/prog/js/checkouts.js
10:51 Joubu 100 $("#RenewCheckinChecked").on("click",function(){
10:51 Joubu 133 $(".confirm:checked:visible").each(function() {
10:51 Joubu same code as current master
10:52 marcelr ashimema: we will face a few regressions :)
10:52 Joubu bug reported one year ago
10:52 Joubu I won't fix it now
10:52 marcelr older ones first lol
10:53 Joubu I let a FIXME, at least it's less confusing that code that is not working
10:53 marcelr documentation++
10:53 Joubu Same for AllowRenewalOnHoldOverride, I am removing all the related code
10:53 marcelr the longer the pref name, the worse is the code
10:54 marcelr can i remove the patroncards feature btw ?
10:55 Joubu git rm -r labels patroncards
10:55 marcelr force push
10:55 Joubu then rewrite it
10:56 marcelr in vue !
10:56 Joubu #action marcelr rewrite patron cards in Vue.js
10:57 marcelr haha
10:58 marcelr is the R in csrf stand for refactoring?
10:58 ashimema bug 11703
10:58 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 enhancement, P5 - low, ---, kyle, CLOSED FIXED, Convert checkouts table to ajax datatable
10:58 ashimema that one splits RenewCheckinChecked and converts to ajax table
10:58 marcelr ashimema++
10:59 Joubu it's 10y old
10:59 ashimema I'm baffled
11:00 Joubu the "check all" does not check the one with material, but you can still check it manually
11:00 ashimema bug 35068
11:00 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35068 enhancement, P5 - low, ---, lucas, RESOLVED FIXED, Split 'Renew or check in selected items' button in issues table into separate buttons
11:00 ashimema sorry.. I mean that one
11:00 marcelr better just be amazed ashimema
11:00 ashimema I have a meeting
11:00 ashimema bbiab
11:00 marcelr bbl too
11:00 ashimema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35068
11:00 huginn` 04Bug 35068: enhancement, P5 - low, ---, lucas, RESOLVED FIXED, Split 'Renew or check in selected items' button in issues table into separate buttons
11:00 ashimema that split the functionality
11:01 ashimema and looks like it moved the parts check into the wrong side of the split
11:01 ashimema prior to that patch both sets were handled together
11:01 ashimema anywho..
11:01 ashimema meeting
11:01 Joubu ashimema: do you agree with replacing the checkbox with a "link", like what we have for "On hold"?
11:01 ashimema sure
11:01 Joubu ok, that's much less code and seems more reliable
11:02 ashimema I just felt like I was being told off for putting in completely broken code
11:02 ashimema trying to prove it did work once upon a time 😜
11:03 ashimema thankyou for looking into it anyways
11:03 Joubu not playing that game, just trying to fix what's broken
11:03 Joubu or remove code if it's uselss
11:03 * ashimema is, as usual, juggling too much at the minute
11:04 Joubu What would be a short replacement "hint" to tell "there is no checkbox, you cannot checkin because the item has materials and you need to checkin using the checkin module"
11:04 Joubu this one is too long
11:04 Joubu "Has materials"?
11:05 Joubu ok, it's supposed to display "Confirm ($materials)"
11:19 Joubu ashimema: see "svc - renew" on the svc branch. Please test if you have a minute.
11:23 oleonard o/
12:20 tcohen hola #koha o/
12:20 magnuse Joubu++ marcelr++ ashimema++
12:20 * magnuse wanders off for a bit of winter holidays
12:55 hammat Hi everyone, I have an old z3950 server for the authorities search using zebra and i wanted to move on a new server using elasticsearch. I'm using yaz-client for the tests and i can do some search on the new server but when i do a pqf querie with attibutes it doesn't work properly for example «Z> f jean » and «Z> f @attr 1=4 jean » return the same number of hits: 18391 can soneone tell me what can i do to make attributes work on the new z3950 ser
12:55 hammat ver Currently the only attributes thats work properly is 1=1, 1=9, 1=12
12:59 hammat please :)
13:08 tcohen sorry hammat I have no experience with the z3950 responder and PQF
13:19 tcohen can you clarify what you're doing?
13:47 hammat I want to use Elasticsearch instead Zebra for authority search from Z3950 server. The main goal is to be able in my Koha to search authority from Z3950 server that uses elasticsearch
13:47 hammat By now, I have a working Z3950 server that elasticsearch but it doesn't consider search with @attr
13:48 hammat In the authorities server i've launched z3950_responder.pl /usr/bin/perl misc/z3950_responder.pl --config-dir=/etc/koha/sites/authorities/z3950
13:53 hammat In the z3950 folder i've a attribute_mappings.yaml file that is use by yaz-client but in that file for authorities where is only «1: personal-name» «2: Heading» «3: Heading» «9: LC-card-number» «12: Local-number»
13:54 hammat i think that's what's why only those attribut work but i want to be able to search by title for exameple (1=4) or subject @attr 1=21
14:00 paulderscheid[m] Hey tcohen, quick question if you're still there: Why do we use $c->validation->param after we already did $c->openapi->valid_input or return? (I will just look it up if you're busy)
14:00 paulderscheid[m] Do they check different things?
14:01 tcohen we don't do that anymore
14:01 tcohen a new guideline was proposed I think
14:01 paulderscheid[m] Ok
14:01 paulderscheid[m] Where?
14:01 tcohen and we removed all those from the code
14:02 paulderscheid[m] Thanks tcohen++
14:03 tcohen OTOH, $c->validation returns an internal data structure with the (already) validated things. So it is not triggering validation again
14:03 tcohen the OpenAPI plugin author told us that data structure was not safe to use
14:03 tcohen and so recommended we just use ->param
14:04 tcohen safe==stable through versions
14:05 paulderscheid[m] Ah, alright. Thanks for the info.
14:52 tcohen is anyone having issues attaching patches to Bugzilla today?
14:52 tcohen (I am heh)
15:40 caroline anyone around uses the "rental discount" column in the circ rules? What is the value I should enter in there?
15:41 caroline I thought if I wanted the patron to get a 98% discount (pay only 2%), I entered "98", but it seems to give a rebate of 99.96%
15:42 caroline I'm not the best at math, but I calculated that on a piece of 1200$, they should pay 24$ with the 98% rebate, but Koha charges 0.48$
15:42 caroline (it's a library that loans works of art, hence the staggering prices)
15:53 fridolin have a nice weekend
15:53 aude_c[m] caroline I've just tried also using a 98% discount by entering 98 in the circ rules column as you did. On my 5.00 rental charge, I was only charged 0.10 - which is correct.
15:56 caroline ok thanks. I think I found my problem
15:57 aude_c[m] What was it?
15:58 caroline I'm not sure yet, but my version has an extra line when I compare it to master, and I think it passes the price through the rebate twice
15:58 caroline so it returns 24$ which is correct, then the 98% rebate is applied again, giving me 0.48
15:59 aude_c[m] oh
16:00 reiveune bye
16:25 JasonGreene[m] caroline: do you have some time to TeamViewer to my desktop? I'm stuck agai
16:26 JasonGreene[m] agin
16:26 caroline stuck on what?
16:28 JasonGreene[m] It worked before so I rebuilt the server to get rid of everything and get a fresh server.... now I can't import again... no matter what I try to import .. the data wont get it
16:29 caroline I can take a look, I'm not sure I have Team Viewer on my computer though, let me check
16:29 JasonGreene[m] ok
16:39 caroline I have errors installing it :/
16:44 JasonGreene[m] bummer
16:44 caroline got it now :)
16:44 JasonGreene[m] 1 665 382 044 t9qyigsh
16:46 caroline ok wait it's asking me to create an account or something, might be a few minutes more
16:46 JasonGreene[m] :-) ok
16:51 caroline Sorry JasonGreene! It's taking longer than I thought, it wont send me the password recovery email
16:52 JasonGreene[m] hmmm, ok
16:53 JasonGreene[m] no problem
16:54 JasonGreene[m] check the spam folder
16:54 caroline it might have to wait this afternoon, the team is about to leave for lunch (we all have lunch together on fridays). Will you be there later?
16:55 JasonGreene[m] sure, I'll be out from 1 to 4 and be back after that
16:56 JasonGreene[m] my time is Central it is 10:55 now
16:57 JasonGreene[m] thanks
16:57 caroline I think I'd be able to connect, just ping me when you're back
16:57 JasonGreene[m] will do
16:59 caroline The whole thing reminded me of this video https://www.youtube.com/watch?v=5t15a0im-_4 about a guy trying to connect to a website
17:33 JasonGreene[m] 🙃
20:53 blawlor[m] somewhere out there is there a collection of scripts or SQL examples for putting things into the database like overdues and holds and other useful things for testing purposes
20:54 blawlor[m] * testing purposes?
21:21 JasonGreene[m] <caroline> "I think I'd be able to connect..." <- I'm back at my desk
21:21 caroline ok! I'm ready
21:22 JasonGreene[m] 1 665 382 044 6khfwhr3
21:58 caroline JasonGreene[m], It was frozen on my side so I closed the connection
22:01 JasonGreene[m] ok me too.. it is back up
22:01 JasonGreene[m] What do you thnk
22:01 JasonGreene[m] rebuild with an older version?
22:01 JasonGreene[m] Should I show you the MarcEdit steps I use?
22:01 caroline Found the commands https://lists.katipo.co.nz/public/koha/2022-October/058547.html
22:03 caroline there are a lot of entries in the mailing list about jobs stuck at 0% https://lists.katipo.co.nz/public/koha/2023-May/059433.html
22:03 JasonGreene[m] I'll look and try
22:04 caroline https://lists.katipo.co.nz/public/koha/2023-June/059555.html
22:05 caroline I'm about to leave for the weekend, but check back on monday with the devs around, they may have the commands to jump start the workers
22:06 JasonGreene[m] ok, Thanks for your help. Have a good weekend
22:06 caroline sorry I couldn't help more :(
22:07 JasonGreene[m] That's ok
22:17 JasonGreene[m] is anyone using Koha 23.11.02.000 and its RabbitMQ
22:17 JasonGreene[m] or are all on older versions of Koha