Time Nick Message
22:29 davidnind I think it is probably too late now, but no harm in adding if you have worked out what the bug does!
22:16 caroline It seems too late now?
22:16 caroline are "release-notes-needed" keyword still valid for 23.11? If I come across one, should I remove it, or try to come up with a release note text?
16:23 reiveune bye
15:57 ashimema that cleans up plugin_data
15:57 ashimema marcelr.. should we use Koha::Plugins::Handler->delete instead here maybe?
15:45 ashimema looking
15:45 ashimema nightmare
15:40 marcelr htg
15:39 marcelr i even added a methods->delete to get it working again??
15:39 marcelr but skipping that makes the test fail
15:38 marcelr it does remove all plugin data btw there
15:38 marcelr ashimema: isubmitted a third patch on 35507 for PluginRoutes and I dont understand why it works but it does ;)
15:38 ashimema khall should know
15:38 ashimema I've always found it weird.. but there was a reason.. I just can't remember what it was
15:37 ashimema that's what Emily's patch starts to do
15:37 ashimema totally
15:37 marcelr i know that i wont write that for now :)
15:37 marcelr ashimema: we should have individual installs; InstallPlugins is a bit weird when you have a lot of plugins
15:36 * ashimema is thinking plugins
15:36 ashimema how do you want those recorded
15:36 ashimema some of the things on the roadmap don't really have or want a collector bug.. but rather just have a bunch of bugs loosely linked
15:36 ashimema cait
15:35 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 enhancement, P5 - low, ---, emily-rose.francoeur, Needs Signoff , Add --include and --exclude options to install_plugins.pl to choose the plugins to install
15:35 ashimema bug 34978 is interesting marcelr.. might help with some of the plugins fun
15:32 cait I'll catch up Monday latest
15:32 cait been a bit of a typically chaotic day
15:31 cait and I pushed some patches, not as much as I wanted
15:31 cait done
15:28 ashimema thanks cait
15:26 cait ashimema: I'll do it
15:24 gveranis any though ?
15:24 gveranis hi , on unimarc 23.11 when trying to load opac-MARCdetail i get The method Koha::Item->stocknumber is not covered by tests! can anyone help me to where to look ? on Koha/Schema/Result/Item.pm the column is ok
15:07 ashimema I've not recently to be honest
15:05 cait ashimema: usually rangi updated it, did you try emailing him?
14:55 aude_c[m] Thanks ashimema
14:52 ashimema those sites really need a more cenralised hosting solution with more access so more than one person on each can action issues
14:51 ashimema same with POD
14:51 ashimema and I think i've tried to get it regenerated few times recently ☹️
14:51 ashimema it's all manual aude_c
14:49 gveranis I search the code and I check the trace but even if I remove the connection on Koha mapping the error still be there
14:48 gveranis hi , on unimarc 23.11 when trying to load opac-MARCdetail i get The method Koha::Item->stocknumber is not covered by tests! can anyone help me to where to look ?
14:44 aude_c[m] Hello, how is the Koha database schema generated? There isn't one for 23.11 yet or is it just missing a link? https://schema.koha-community.org/
14:39 AnkeB Sorry for not participating in the patch testing session today, we had meetings and no time to attend :-(
14:31 krimsonkharne[m] and cait++ for organizing :)
14:31 krimsonkharne[m] great patch testing session, sorry I couldn't stay longer! tuxayo++
14:26 marcelr running those tests 100 times makes you feel safe ;)
14:25 marcelr 35536
14:25 marcelr nice rebase :)
14:25 marcelr i did a lot more already on 36536
14:24 ashimema no worries.. hopefully I'd didn't come across too negative
14:24 ashimema it totally is confusing.. thanks for digging as far as you have so far
14:24 marcelr thx for feedback
14:24 marcelr right we need to adjust there, but it is kind of confusing setup
14:23 ashimema it's data that worries me.. plugins store config and things in there.. end user editable data
14:23 ashimema so we always used to leave data
14:23 marcelr right
14:23 ashimema you chain data into it
14:23 ashimema yes, but only for methods
14:23 marcelr what is extra, is touching plugin_data
14:22 marcelr the delete was always there
14:22 ashimema i didn't spot where it reinserts.. reviewing form phone right now
14:22 ashimema indeed
14:22 marcelr and it is not reinserting plugin_data now?
14:22 ashimema I also think we need to be careful not to delete this stuff always.. sometimes you want config to stay through an upgrade for instance
14:21 marcelr ah i get where you're going it is removing and reinserting
14:21 ashimema so it will get called for every plugin on the system
14:21 ashimema but in InstallPlugins we call delete in a loop
14:14 cait you are very welcome
14:10 tuxayo cait++ saved the day by providing a backup chatroom for the patch testing session with the German speaking community.
14:08 marcelr we actually now delete an attached record in plugins_data too when deleting one in plugin_methods; which is more consistent
14:07 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 normal, P5 - low, ---, m.de.rooy, Signed Off , Fix handling plugins in unit tests causing random failures on Jenkins
14:07 marcelr ashimema: added comment on bug 35507 - we are not wiping all data !
14:06 marcelr o/
14:06 Joubu the server is overloaded today, it's creating 23.11 and it seems there is a bottleneck at disk access level
14:05 cait Joubu: trying to fix, but saving takes forever
14:03 cait it's just treated as text
14:03 Joubu I didn't
14:03 cait did you happen to fix that one above or do I still have to?
14:02 cait I wanted to talk to you about that one
14:02 cait so it doesn't catch any error
14:02 cait I think it doesn't recognize it a sa placeholder at all
14:02 Joubu then see what we should do
14:02 Joubu caroline: nope, I will wait for Weblate's maintainer to tell me if it's a bug or not
14:01 caroline do you need to test it again Joubu? I corrected the string
14:01 Joubu the UI should at least catch the error
14:01 cait the support for {} is not ideal
14:01 cait Joubu: the problem is, you need to type it, you can't copy by click anymore :(
13:59 Joubu this is enabled ;)
13:59 Joubu https://docs.weblate.org/en/latest/admin/continuous.html#keeping-translations-same-across-components
13:59 caroline neither, just that sometimes it told me I had 5 things to correct, I correct one and then nothing else shows up, I was confused
13:58 Joubu good or bad?
13:58 caroline ah that explains things :)
13:57 Joubu it should fix the other components/versions automatically
13:57 Joubu remember that with Weblate you should need to fix only one of them
13:56 Joubu master, but certainly 23.11 as well
13:56 caroline this is for 23.11 correct?
13:55 Joubu Italian, Japanese? :D erk there are a lot :-/
13:54 Joubu Finish people around?
13:52 caroline_catlady thanks Joubu, I will check this right away
13:52 Joubu reported: https://github.com/WeblateOrg/weblate/issues/10626
13:52 Joubu 7735 msgstr "CSV-Profil '{csv_provile_name}' löschen?"
13:52 Joubu cait: 7734 msgid "Delete CSV profile '{csv_profile_name}'?"
13:52 Joubu 5706 msgstr "Server {servertype]-Server '{servername}'"
13:52 Joubu 5705 msgid "Modify {servertype} server '{servername}'"
13:52 Joubu de-DE-messages.po:7735: a format specification for argument 'csv_profile_name' doesn't exist in 'msgstr'
13:52 Joubu <failure message="msgfmt failure">de-DE-messages.po:5706: a format specification for argument 'servertype' doesn't exist in 'msgstr'
13:51 Joubu cait:
13:51 Joubu 6519 msgstr "Exemplaires en retard en date du"
13:51 Joubu 6518 msgid "Items overdue as of {date}"
13:51 Joubu <failure message="msgfmt failure">fr-CA-messages.po:6519: a format specification for argument 'date' doesn't exist in 'msgstr'
13:51 Joubu caroline_catlady:
13:33 ashimema https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Plugins.pm#L259
13:32 ashimema I might be missing something.. need to test my hypothesis
13:31 ashimema so it'll call for all plugins present in the system
13:31 ashimema InstallPlugins iterates all plugins
13:31 Joubu it's not all plugin data, it's the ones linked with the plugin. Am I missing something else?
13:31 Joubu ashimema: + my $cond = { plugin_class => $self->plugin_class };
13:09 ashimema every time one calls InstallPlugins, we'll wipe out all plugins Data.. thus all configs will go down the pan any time any plugin is installed or upgraded
13:08 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 normal, P5 - low, ---, m.de.rooy, Signed Off , Fix handling plugins in unit tests causing random failures on Jenkins
13:08 ashimema isn't the introduction of the delete stuff bug 35507 really destructive in production..
13:08 ashimema marcelr around?
12:00 tcohen Joubu I can take care this morning
11:35 cait it happens soemtimes
11:35 cait we have the "add a record and see if it#s indexed" as part of our update check list
11:35 cait np
11:32 tcohen Buen día #koha!
11:30 davewood helped ... i expected an error message somewhere at some point. thanks for all the pointers.
11:29 Joubu koha-indexer --start $INSTANCE
11:29 Joubu start it
11:28 davewood Indexer not running for hdnbib: failed!
11:28 davewood root@hdnbiblio:~# koha-indexer --status hdnbib
11:28 davewood Zebra running for hdnbib:.
11:28 davewood root@hdnbiblio:~# koha-zebra --status hdnbib
11:28 Joubu koha-indexer --status $INSTANCE
11:27 cait not zebrasrv but the indexer daemon
11:27 cait I think it#s something like sudo koha-indexer --start instance or so
11:27 davewood i did. => Zebra running for hdnbib:.
11:26 cait might just need a kick
11:26 cait have you checked if the indexer deamon is ok?
11:26 davewood yes there were 3 entries. one for each biblio i added manually via cataloguing
11:26 cait you might just need to restart the indexer
11:26 ashimema I jsut send with each line
11:26 cait how does it look? does it have entries with 0?
11:26 davewood zebraqueue
11:26 cait yes
11:26 davewood cait: without the underscore
11:25 cait Not message_queue zebra_queue
11:25 Joubu davewood: maybe try a restart of koha-zebra?
11:24 ashimema for me.. it works perfectly every time
11:24 Joubu ashimema: if you "send" it does not actually send?
11:22 ashimema Sounds like I can't send more than one message in a row for you Joubu.. I have to have someone say something between each message... Which is just silly
11:22 davewood Joubu: 3 rows with 'done=0'
11:20 Joubu davewood: the table is zebraqueue
11:19 huginn` Joubu: The operation succeeded.
11:19 Joubu @later tell oleonard ping me when you are around please (35329 - move_to_modal)
11:19 ashimema I do return after each line
11:18 davewood Empty set (0.001 sec)
11:18 davewood MariaDB [koha_hdnbib]> select * from message_queue;
11:17 davewood s/i/it/
11:17 davewood i stopped working today after update shenanigans yesterday.
11:16 davewood Zebra running for hdnbib:.
11:15 cait did you check if they were indexed? (entries in message_queue tabel with done = 0)
11:15 Joubu koha-zebra --status mybib
11:15 cait did it just stop working?d
11:14 davewood hmm ... the zebra index doesnt find new books (neither importing via bulkmarcinport.pl nor via catalogueing) ... a manuel reindex with rebuild_zebra.pl helps. the logs dont show anything ( tail -f /var/log/koha/mybib/*error*log)
11:00 huginn` Joubu: The operation succeeded.
11:00 Joubu @later tell tcohen we need the new jenkins builds, will you do it? https://tree.taiga.io/project/koha-ils/task/28
10:37 Joubu [off] nugged re 33568 - I know that Bohdan Pasternak from Ukraine had interest in it. They contacted me end 2021 to implement it.
10:35 marcelr sure
10:34 cait I hope I do pay attention... :)
10:33 cait hm if we turn of finesmode, that shoudl freezee existing fines, shouldn't it?
10:33 Joubu adjusted the wiki
10:32 marcelr the patch
10:32 marcelr i will change it
10:32 marcelr haha
10:32 Joubu indeed :D
10:32 marcelr fix typo first
10:32 Joubu this is where it should be caught
10:32 marcelr typo Comit
10:32 Joubu }
10:32 Joubu colored( "Comit contains DO NOT PUSH - $commit", 'red');
10:32 Joubu push @errors,
10:32 Joubu if ( $commit_message =~ m|DO NOT PUSH| ) {
10:32 Joubu https://wiki.koha-community.org/wiki/Tips_and_tricks#pre-push
10:31 marcelr it was a requirement :)
10:31 marcelr MR works at RM
10:31 marcelr MarcelR => MR
10:31 Joubu TestRM?
10:31 Joubu TestMR?
10:30 marcelr if the RM does not pay attention..
10:30 marcelr it would be nice to introduce TestMR to Koha
10:30 marcelr should i adjust it :)
10:27 Joubu "DO NOT PUSH" is caught by the RM script
10:27 marcelr cait: what about: Subject: [PATCH] Bug 35536: DONT PUSH !!! - Example plugin
10:25 marcelr if you like nice greps and mocks, please go 35536 :)
10:23 cait always the goal
10:23 cait good_communication++
10:23 marcelr good_communication++
10:23 Joubu but please try to keep a good communication between us :)
10:23 paulderscheid[m] Saw it, nice work!
10:22 Joubu use the tool you want, I use the one I want
10:22 cait I tried but failed - we have an Element server, but they won't install the bridge
10:22 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Improve removal of Koha plugins in unit tests
10:22 marcelr paulderscheid[m]: please see bug 35536 too :)
10:22 cait pleas ekeep messages shorter :)
10:22 cait yeah, that's true
10:22 PedroAmorim[m] =D
10:22 PedroAmorim[m] non-matrix people, hop over to matrix
10:21 Joubu We need to click to see the other lines, and it is broken for some of us!
10:21 PedroAmorim[m] o/
10:21 Joubu or we are getting the HTML link
10:21 Joubu Matrix people, you should type "enter" on every lines
10:16 Joubu I am getting tired of clicking on links to know what people said
10:16 marcelr i do not see matrix error outside matrix
10:16 Joubu is this just me, or everybody outside of matrix see that?
10:16 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 major, P5 - low, ---, m.de.rooy, Failed QA , Circulation rule dates are being overwritten
10:16 Joubu 10:52 < ashimema> sorry marcelr.. failing bug 35341... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/VDIriPmwGlRYcOxfiMKnCiww>)
10:10 paulderscheid[m] Thanks for prioritising 35507 marcelr++
10:10 paulderscheid[m] Hi #koha
10:03 marcelr will fix the repeated x after finishing 35536
10:02 marcelr you shouldbe sure btw that the browser cache is not cheating
10:01 marcelr i struggled with flatpickr there
09:56 cait better to catch problems than to not find them
09:53 ashimema sorry to be the bearer of bad new 😜
09:53 marcelr will have a look soon; thx
09:52 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 major, P5 - low, ---, m.de.rooy, Failed QA , Circulation rule dates are being overwritten
09:52 ashimema sorry marcelr.. failing bug 35341... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/VDIriPmwGlRYcOxfiMKnCiww>)
09:51 saa after installing latest 23.05.05 on a server kohaadmin page logs out automatically often what could be the reason is there any configuration required so that it wont logout automatically
09:39 cait like anything that is not present in the form...b ut haven't been able to dig into that really
09:38 cait and it could be more than the invoice_id
09:38 cait I THINK, but haven't confirmed, that changing the order data is missing some fields that then get set to empty/null
09:38 cait but to fix it, maybe we'd just need to make the update better - I think it just overwrites everything you don't send or so, but it's a suspicion
09:38 ashimema i'm having a call about it today
09:37 ashimema exactly
09:37 cait I believe we need to improve the workflows... having to change an order's data after receiving is not ideal - if it's required for a workflow we probably have a deeper issue
09:36 cait happy to help when I can
09:36 ashimema I need to understand the overall workflow.. which I'm struggling with right now
09:36 cait but we don't want the underlying bug
09:36 cait you can undo an dtest, I am not stuck to my solution
09:36 cait maybe it broke in between their version before the update and the fix
09:36 ashimema this is a standing order
09:36 cait s
09:36 cait i verified the problem multiple time
09:35 cait maybe it's the combination with a standing order?
09:35 ashimema it's always worked fine for them
09:35 ashimema thats what's really pissing them off
09:35 cait and possible other fields
09:35 ashimema they never have
09:35 cait becuase you don#t want to lose the invoice numbers
09:35 aw-bib[m] hi! I'd like to migrate hold requests from our old system. usually, I'd add that to my replay-script that migrates loans, however, the perldoc sounds complex. is it enough to AddReserve() and resolve this with the subsequent loan? (iow sorting in the holds before the issues and process it that way?) or am I even overthinking and its actually way easier...
09:35 cait as I told you, you can unbreak it, but make sure it doesn't bring the erorr back
09:34 ashimema and they're getting irate about it ☹️
09:34 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 blocker, P5 - low, ---, katrin.fischer, Pushed to oldstable , Modifying an order line of a standing order will delete linked invoice ID
09:34 ashimema bug 34469 fundamentally breaks a customers workflow
09:33 ashimema though I also have a support call that's getting a bit nasty.. ☹️
09:33 marcelr marked normal with RM priority
09:33 ashimema ah yes.. that's also on my list for this morning 🙂
09:33 marcelr Jenkins and plugin tests
09:33 marcelr haha
09:32 marcelr i also have 35507 btw :)
09:32 marcelr cool
09:32 ashimema on it now
09:32 ashimema yeah
09:32 marcelr well there are always more bugs but this bugfix is major
09:31 ashimema aha.. it was a later.. I see it now
09:31 marcelr yes i did a later but some dont see them
09:31 * ashimema is just checking he hasn't missed something
09:31 ashimema was there two bugs you wanted me to QA.. I only see the one above now.
09:31 ashimema did you send a similar message earlier marcelr.. could have swarn I saw a notification on the phone whilst swimming about an hour ago but I can't see it now
09:29 ashimema certainly 🙂
09:29 marcelr work from matthew
09:29 marcelr hi ashimema could you qa 35341 please ?
09:27 ashimema oai is open to polling i believe
09:27 ashimema my brain hasn't woken up yet
09:27 ashimema push -> subscribe
09:26 ashimema feel free to open a bug on bugzilla for it and submit some code
09:26 ashimema We don't support any push type updates like webhooks
08:42 ammarspv[m] Yes that's what I am trying to use
08:39 Joubu ammarspv[m]: use the Koha REST API?
08:26 ammarspv[m] hmmm - let me try to explain,... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/MzhLucGcQlBNCqRvtYWSNbna>)
07:58 cait and use API etc. to check on availability
07:58 cait usually for a custom opac you'd use something like OAI-PMH for building/updating your index
07:57 cait I think I don't understand what you are trying to do
07:56 ammarspv[m] If webhooks are not feasible - what other method do you recommend me to research and consider?
07:56 ammarspv[m] I am creating custom OPAC that is reading Biblio data through API. Is there a method that I can do in order to reflect the biblio data instantly? Such as webhook end point (Biblio Create, Biblio Update), also webhooks to update items based on availability
07:56 ammarspv[m] Hi,
07:54 reiveune hello
07:54 cait and glad we didn't miss an instance of the bug
07:54 cait at least there is a logical reason
07:54 cait oh
07:53 davewood field 000 and field 001 had the same valuebuilder by accident
07:53 davewood everything alright ... the framework i was using had the same valuebuilder configured, of course it gets called twice.
07:51 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 enhancement, P5 - low, ---, m.de.rooy, ASSIGNED , Improve cleanup/uninstall of Koha plugins
07:51 marcelr Joubu: thx, now working on bug 35536
07:50 davewood wait a minute
07:50 cait I wonder why it happens now, but maybe a similar fix would work?
07:50 cait hm when I tested the bug I posted yesterday I didn't see that - because I had tested the normal form first by accident
07:49 davewood cait: for the record, even with koha-common 23.05.06-1 the valuebuilder runs twice when requesting /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=TST
07:49 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 normal, P5 - low, ---, m.de.rooy, Signed Off , Fix handling plugins in unit tests causing random failures on Jenkins
07:48 cait Can I have QA on bug 35507 please? hopefully to get our Jenkins happier
07:47 cait fingers crossed for you - we are also doing an update this morning
07:47 cait true
07:46 davewood a bit mysterious
07:46 davewood i just repeated the DB installer process and this time I got no error
07:45 cait davewood: restarting everything? I am afraid we haven#t run into that one (yet)
07:44 Joubu upgrading weblate, expect downtime
07:44 cait good morning
07:38 davewood my koha installation is still broken
07:38 davewood No tables with rows size too large found.
07:38 davewood ran the rowsize.sh script that checks for tables with wrong settings
07:38 davewood i follwed this link https://wiki.koha-community.org/wiki/Database_row_format
07:37 davewood hmm .. I updated koha (debian package from 23.05.05-1 to 23.05.06-1) after that it asked for a DB upgrade. i entered the mysql credentials and next i got this error."Datenbanktabellen mit einem anderen Zeilenformat als 'DYNAMIC': 1"
07:17 davewood https://koha-community.org/manual/latest/en/html/administration.html#marc-bibliographic-frameworks
07:16 davewood mjkerpan[m]: you need to adjust the framework.
07:14 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Fix handling plugins in unit tests causing random failures on Jenkins
07:14 marcelr i need a signoff on bug 35507 for Jenkins
07:13 huginn` marcelr: The operation succeeded.
07:13 marcelr @later tell ashimema could you qa 35341 please ?
07:13 marcelr o/
02:02 mjkerpan[m] I'm trying to make sure that people dont create new items that lack Shelving Locations, Collection Codes, or Barcodes
01:00 mjkerpan[m] Can I set fields as required
01:00 mjkerpan[m] Can
00:59 mjkerpan[m] Does anybody know if there's a way go s