Time Nick Message
07:47 reiveune hello
08:01 Joubu davidnind: around? Did you fix your .po files problem in ktd?
08:01 schnydszch Good day! I am trying out again Koha development. I tried pushing my commit for Bug no. 35238, git log is: commit 0c8cf6d6c507f946da3deff493044c394096ee6b (HEAD -> master)
08:01 schnydszch Author: Eugene Jose Espinoza <eugenegf@yahoo.com>
08:01 schnydszch Date: Tue Dec 5 07:51:08 2023 +0000
08:01 schnydszch Bug 35238: Incorrect label markup in patron card creator printer profile edit form
08:01 schnydszch The label for "template_name" doesn't match any form field, so it is edited to a span with "label" class.
08:01 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 minor, P5 - low, ---, oleonard, NEW , Incorrect label markup in patron card creator printer profile edit form
08:02 schnydszch Was my patched pushed for this bug? I am not seeing it in the koha bugzilla website
08:02 Joubu how did you "push" it?
08:03 Joubu Not related to your question, but the commit title should describe what the patch does, not what the problem is.
08:08 schnydszch git commit -a
08:09 Joubu if you want to edit the last commit: git commit --amend
08:10 Joubu if you want to attach the last commit to the bugzilla bug report: git bz attach -e 35238 HEAD
08:13 schnydszch oh, i missed that part. thanks Joubu!
08:57 Joubu restarting weblate
09:14 cait if someone wants to join us - German Koha User meeting is live :) https://koha-dach.eu
09:14 davidnind cait++
09:16 cait zoom link is on the website
09:19 davidnind Joubu: it may just be because I tried fr-FR first (other languages seem OK) - with fr-FR I get an error when installing on a MARC21 instance
09:19 davidnind perl misc/translator/translate update fr-FR... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/LUTyEWIjzQEozkAWAaSpISaG>)
09:19 cait in de-DE there is also an error
09:20 Joubu davidnind: go to misc/translator/po
09:21 Joubu and `ls fr-FR-*`
09:21 Joubu what to you see? nothing?
09:22 davidnind drwxr-xr-x 3 kohadev-koha kohadev-koha 4096 Nov 19 20:09 fr_FR... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/ILVsHaVrnNfPqiuQoFtGeuld>)
09:24 Joubu git pull
09:24 Joubu in misc/translator/po
09:24 Joubu from outside ktd
09:26 davidnind david@david-thinkpad-t14:~/git-koha/koha/misc/translator/po$ git pull... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/EFBbVeOyPvwGeAaCaIsMxrNS>)
09:27 cait Joubu: could we get notes on how to test tranlsations with ktd somewhere?
09:27 cait or maybe we have, but didn't find them
09:27 davidnind I created a branch in KTD called test, the git pull was done outside
09:27 Joubu davidnind: do you have ktd startup log?
09:27 Joubu you should see "koha-koha-1 | Install Koha-how-to"
09:28 Joubu cait: nothing to do, for the first time. For second time you need to understand what's going on. I have written a lot of info already. Please ask specific questions and I will answer.
09:29 cait hm I had to clone the repo
09:29 cait it wa snot in my ktd and i had created a fresh one
09:29 cait i did not find steps on this
09:29 Joubu there are 2 commmon mistakes: 1. Permission in misc/translator/po is not correct, ktd startup won't manage to adjust the directory content
09:29 cait the files were not there
09:29 cait i checked that
09:30 ashimema have you recently done a ktd pul
09:30 Joubu 2. You have played with translations, and misc/translator/po has modified files. You need to reset --hard manually before starting ktd, or do the pull after you have started it
09:30 cait yes, I did that before... i can do it again if it's uspposed to work
09:30 Joubu it is supposed to work
09:30 cait ah maybe becuase i had translations installed before
09:30 cait i will test that
09:30 cait i noticed in po directory where some .mo files
09:31 pastebot "davidnind" at 127.0.0.1 pasted "KTD startup log" (575 lines) at https://paste.koha-community.org/31673
09:31 Joubu that's not expected
09:31 cait I'll clean up my repo and try again
09:31 davidnind I will try again with everything fresh
09:31 cait I was not sure if ti was supposed to just work or not yet
09:31 Joubu davidnind: you are in the second situation I described before. The error in the log is:
09:31 Joubu koha-koha-1 | error: Your local changes to the following files would be overwritten by checkout:
09:32 Joubu so go to misc/translator/po and `git reset --hard HEAD` then pull again
09:32 Joubu ktd startup does not do it because I don't think a script should reset --hard
09:33 Joubu we can reconsider it if it causes too much trouble, but I would prefer if people to understand what's happening.
09:33 cait we just reached 135 participants :) (German speaking user meeting)
09:33 davidnind so do that outside KTD?
09:33 davidnind excellent!
09:35 Joubu yes, outside ktd, so that you don't do FS manipulation under root (that would cause permission issue next time you start ktd!)
09:38 davidnind before or after starting up KTD?
09:39 davidnind have read back - before starting KTD...
09:40 Joubu as you want
09:41 Joubu misc/translator/po is a git repo tracking koha-l10n. When ktd starts it will update this repo
09:41 Joubu but will fail if there are modified files
09:41 Joubu however it won't stop ktd startup
09:42 Joubu so, if ktd is started and you want to pull l10n: cd misc/translator/po && git fetch origin && git reset --hard HEAD && git rebase origin/master
09:42 Joubu if ktd is not started: cd misc/translator/po && git reset --hard HEAD
09:43 Joubu this is destructive! it will remove local changes from misc/translator/po (but you certainly do not care about them)
09:43 davidnind outside KTD - git reset --hard HEAD gives me:
09:43 davidnind Updating files: 100% (925/925), done.
09:43 davidnind HEAD is now at 0fe3484c Translated using Weblate (Swedish)
09:44 davidnind git pull gives me:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/iIufptwxDDZtODqOikfwmffc>)
09:44 Joubu git checkout master
09:44 davidnind git branch gives me:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/CuSilwnhordqUTHyJINOMyUk>)
09:45 davidnind right, so now under po everything is up-to-date
09:46 ashimema mine was in a detactch head a moment ago.. Joubu and I talking in PM to see if we can narrow it further between us a bit.
09:46 Joubu 168 git -C $BUILD_DIR/koha/misc/translator/po checkout origin/${l10n_branch}
09:46 Joubu we should create the branch
09:48 pastebot "davidnind" at 127.0.0.1 pasted "KTD startup - section after Koha-how-to" (33 lines) at https://paste.koha-community.org/31674
09:49 ashimema Chowing po files.. hehe.. that made my brain leap to 'Chowing down'.. which had pictures of koha munching on po files 😜
09:49 Joubu davidnind: that's okish
09:50 davidnind so, now that I'm in KTD, how do I install a language? perl misc/translator/translate install xx-XX ? I don
09:50 Joubu you should be good to run the po:update commands
09:50 Joubu davidnind: yes, I think so
09:51 davidnind I've not used them before - so just: gulp po:update ?
09:51 ashimema aren't install and update different
09:51 Joubu yes
09:52 Joubu wait
09:52 ashimema koha-translate --install, the packaged command should work
09:52 ashimema I can't remember what it now calls in the background
09:53 ashimema I think ./misc/translator/translate install uses the gulp stuff internally
09:53 ashimema 'create'
09:54 ashimema oh.. not
09:54 Joubu `gulp po:update --lang xx-XX` will extract the new strings from Koha and merge them with the existing .po files (in misc/translator/po) This is needed when you want to see if string becomes translatable
09:54 ashimema install looks like it's still as it was in the misc script
09:55 ashimema install uses the po's to generate the templates.. update pulls the latest po from the translation server.. that's it isn't it
09:55 davidnind I haven't been able to get the koha-translate package commands to work for a while
09:55 ashimema oh
09:55 ashimema not good
09:55 ashimema did you submit a bug?
09:56 Joubu to have the translated templates for a given languages (so pick the English templates and add the translations from the .po files) you need `perl misc/translator/translate install xx-XX`
09:56 ashimema brill,
09:56 ashimema my understanding is back in sync.. thanks Joubu
09:56 davidnind in KTD I normally create a branch to test things, so for example: git checkout -B test
09:57 Joubu or, indeed, koha-translate --install fr-FR, always forgot that one
09:57 Joubu but it fails now
09:57 davidnind if I go to the misc/translator/po directory (in KTD), git branch shows:
09:57 davidnind * (HEAD detached at origin/master)
09:57 davidnind master
09:58 davidnind git status shows:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/tGWpxzHjxMaRTwKDTtPDrfEz>)
09:59 Joubu ha!
10:00 Joubu ha! for koha-translate, it's indeed totally broken, looking now
10:00 Joubu (only for ktd I think)
10:00 Joubu davidnind: did you try to checkout master?
10:00 Joubu git checkout -B master origin/master
10:01 Joubu you should not have those directories there
10:01 Joubu do you really have misc/translator/po/de_DE?
10:01 ashimema running the gulp update adds those for me
10:02 davidnind maybe that was from before - although I thought I had cleared everything - will start fresh again...
10:04 Joubu ashimema: indeed, it creates Koha.mo there
10:05 Joubu guess it was the behaviour prior to last month changes, but we should remove them
10:07 ashimema makes sense
10:12 paulderscheid[m] Hi #koha
10:13 paulderscheid[m] Question: how do you update plugins in prod? Manually? Wanted to write an ansible playbook yesterday until I realized that install_plugins.pl can't be used :D
10:13 ashimema can it not?
10:14 paulderscheid[m] I don't think so. How would the script determine which tenant to update?
10:14 ashimema environment?
10:14 paulderscheid[m] Or am I stupid :D
10:14 paulderscheid[m] ?
10:15 ashimema it uses C4::Context
10:16 ashimema koha-shell -c /usr/share/koha/...
10:16 ashimema that should do the trick I would think
10:16 paulderscheid[m] Whoa, what is that? :D
10:16 paulderscheid[m] Wasn't aware of that.
10:16 ashimema koha-shell is a command from the debian packages
10:16 ashimema it'll give you a shell with all the correct environment for that koha instance
10:17 ashimema koha-shell instancename
10:17 ashimema that'll just give you the interactive shell
10:17 ashimema -c "command" instancename will run the passed command under the right instances environment
10:17 paulderscheid[m] Cool, problem solved. Thanks ashimema++
10:17 ashimema https://wiki.koha-community.org/wiki/Commands_provided_by_the_Debian_packages#koha-shell
10:17 ashimema no worries
10:17 ashimema 🙂
10:18 ashimema koha-foreach may also be helpful.. I think that may support the same but loops for you
10:18 ashimema might be wrong there.. it's been a while since i used it
10:18 paulderscheid[m] I should look into the wiki more often ^^
10:18 paulderscheid[m] Anyway, that's great!
10:20 ashimema the main problem with the wiki is that you kinda have to know what your looking for to find it.. which isn't great
10:21 paulderscheid[m] Yeah, but thankfully you are here :D
10:26 paulderscheid[m] <ashimema> "the main problem with the wiki..." <- That was also my problem when I started out with perl ^^
10:27 Joubu update - mo files cannot be removed, it's used by I18N TT plugin, they are not temporary files at all (thanks jajm!)
10:28 pastebot "davidnind" at 127.0.0.1 pasted "Workflow so far for working with translations using KTD" (41 lines) at https://paste.koha-community.org/31678
10:29 Joubu davidnind: - update po files: STILL VERY CONFUSED HERE
10:30 Joubu only "gulp po:update --lang xx-XX"
10:30 Joubu do not list other commands
10:30 Joubu (they are deprecated)
10:30 davidnind so that installs the language as well?
10:30 Joubu no
10:31 Joubu I think people are expected to use koha-translate
10:31 Joubu I am having a look right now
10:31 Joubu koha-translate --install xx-XX
10:31 Joubu koha-translate --update xx-XX
10:31 Joubu that's all you should need if you don't want to go deeper
10:31 Joubu maybe the other things to list is the different possible errors
10:32 davidnind thanks Joubu, I'll test it out now
10:32 Joubu like "if something is wrong, look at ktd startup log"
10:32 Joubu locate "Install Koha-how-to"
10:32 Joubu "fatal: detected dubious ownership in repository at '/kohadevbox/koha/misc/translator/po'"
10:32 Joubu is one of them, it (certainly) means that misc/translator/po/.git is owned by root
10:33 Joubu you got another one with the "detached HEAD", it should be fixed now (I've pushed a commit to ktd)
10:33 davidnind Joubu++
10:35 Joubu thanks to you, davidnind!
10:41 Joubu @later tell mtj ktd's focal-arm64v8 still failing "git was not found in the system"
10:41 huginn` Joubu: The operation succeeded.
10:43 davidnind so I've done a gulp po:update --lang es-ES (just to test, looks good, no errors)
10:43 davidnind then koha-translate --install es-ES
10:43 davidnind I get: Error: the selected language is not currently available.
10:43 Joubu yes, koha-translate is broken
10:44 Joubu use `perl misc/translator/translate install es-ES`
10:44 Joubu for now
10:44 davidnind thanks!
10:48 Joubu davidnind: use koha-translate with --dev!
10:48 Joubu I totally forgot that
10:48 Joubu koha-translate --install es-ES --dev kohadev
10:48 Joubu (as root)
10:48 Joubu koha-translate --update es-ES --dev kohadev
10:48 Joubu that's all you need
10:50 davidnind does the update command need to come before the install?
10:50 Joubu yes, the workflow is:
10:50 Joubu 1. update: pick new strings
10:51 Joubu 2. Edit .po manually (to translate!)
10:51 Joubu 3. install: create translated templates
10:52 davidnind Thanks! (I'm getting there! 🙂)
11:16 oleonard Hi #koha
11:48 * cait waves
11:58 pastebot "davidnind" at 127.0.0.1 pasted "My workflow notes for testing bugs with translation changes when using KTD (such as they are)" (65 lines) at https://paste.koha-community.org/31689
11:58 davidnind ^^ still some work to do, so far these have worked for me - just need to test with a real bug (tomorrow....)
11:59 davidnind Note, for de-DE there is an warning when you install:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/ilAssTAJcBOfzAMeBKghKVTs>)
12:08 cait in know :(
12:08 cait I'll fix it once I can locate the string
12:08 cait it's on my list
12:08 cait it mostly works ok still, but one bookings related page isn't translated
12:10 magnuse anyone want some snow? we have some left overs
12:10 cait I am glad ours is just melting
12:11 cait university had to close 2 days because the paths were all blocked (too much snow on trees etc.) and coworkers can't come in beacuase of damage on the train track
12:12 oleonard magnuse: My kids would love some snow if it'll close school
12:13 oleonard (Norway amounts of snow here would shut down *everything*)
12:13 magnuse oleonard: i'll check how much we can spare ;-)
12:13 magnuse sounds like cait hs been hit pretty hard too
12:14 cait too much for us, would not be too much for Norway is my guess :)
12:14 schnydszch while trying to work on koha docker for adding some patch 4 hours ago, an earthquake occurred in the office. And so now I am back on trying again.
12:14 oleonard :O
12:14 cait ok, earthquake beats snow
12:15 schnydszch ..here in the Pacific Ring of Fire
12:15 tcohen[m] Hola #koha
12:16 schnydszch earthquake beats momentum
12:18 cait hola tcohen
12:21 schnydszch hola tcohen, magnuse, cait, oleonard, davidnind
12:22 magnuse hiya schnydszch
12:22 magnuse yeah, i would choose snow over earthquakes
13:11 cait kidclamp: question about bug 8838: does ist work like the CHECKIN/CHECKOUT email - so woud you send emails for already picked up items or does it pull the info when the letter is created?
13:11 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 enhancement, P1 - high, ---, kyle, Needs documenting , Digest option for HOLD notice
13:11 cait it looks like the first...
13:11 cait becaue it looks like there is no cron?
13:12 kidclamp Yes, I think that is correct
13:13 cait or maybe it recreates the letter each time a new pickup is added...
13:13 cait trying to understand the code
13:13 cait do you thnk that's right?
13:13 cait https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157456
13:13 cait hm $message->append($letter);
13:14 cait ok, it's works like CHECKOUT
13:15 cait i love that we have that now, but I was hoping it was implemented a little differently
13:17 cait more like the advance_notices
13:23 cait 105 participants for our more technical afternoon session currently :) (German speaking Koha users meeting)
13:26 cait paulderscheid[m]: around?
13:26 paulderscheid[m] Yes
13:26 paulderscheid[m] Damn the meeting
13:26 cait PM
13:30 ashimema I always found the Message->apend stuff weird
13:32 cait yeah, it has certain disadvantages
13:34 ashimema In fact.. I'd outright get rid of C4::Message
13:34 ashimema it's sole purpose is this "interesting" append stuff
13:34 ashimema it's not even append.. it's insert
13:35 ashimema it puts stuff in the middle of the message
13:36 tcohen[m] ashimema: what are we going to refactor this cycle?
13:36 tcohen[m] holds table? letters?
13:37 ashimema I proposed pushing your holds table bug forward yes
13:37 cait wahtever, put it in the road map please ;)
13:37 ashimema slip printing/notices in tt/etc is another on my to hit list if I can get support there
13:38 ashimema Pedro is focusing hard on ILL
13:38 ashimema I need to continue to polish bookings.. get all those tests fully written and pushed before expanding and polishing what's there now
13:38 cait oh right: when I showed the new features today bookings was getting the most comments
13:38 ashimema and I'm also super keen (with ILL as the "excuse") to move the plugin system forward a few steps
13:38 cait and questions
13:39 cait so big interest from German speaking users :)
13:39 ashimema Centralised plugin store with ratings, author authenticity etc etc
13:39 tcohen[m] ashimema count me in on moving the backends into plugins
13:40 ashimema bookings is certainly 'foundation level' at the moment cait
13:40 cait i told them that
13:40 ashimema the core all works, but it's certainly needs the rest of the house building on top of it to make it really functional
13:40 cait i just thought it might make you happy to know that you hit a nerve there
13:40 ashimema I just couldn't keep it all in my head.. needed those foundations in so I could break the next steps into smaller more manageable chunks
13:40 ashimema yeah, I'm happy
13:41 ashimema so you have any particular targets of your own tcohen?
13:42 ashimema I'm so keen to get moving again on bug 15279
13:42 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 enhancement, P1 - high, ---, gmcharlt, NEW , Deprecate bespoke syntax for Slips and Notices
13:42 ashimema but there's a lot of steps to get there.. the TT side needs to be first class before we can even start to consider dropping the bespoke option
13:43 ashimema TT is certainly not that in the slip editor yet.. it's decidedly hidden and undocumented..
13:43 cait I'll try to send out an official rodmap mail this week - hopefully tomorrow
13:43 cait but no reason not to use your time advantage now :)
13:55 tcohen[m] I'll be out until thursday, I can join a group reviewing the roadmap items after that
13:59 cait ah good to know
13:59 cait i was aiming for something around next dev meeting maybe - still got to check the calendar
14:44 tuxayo german-speaking-community++ There were 80 people attending my demo on how to signoff patches. And there will be a follow-up patch testing session the 14th :)
14:52 ashimema nice
15:02 cait tuxayo++
15:02 cait thanks for the great presentation
15:06 aw-bib[m] +1
15:14 reiveune bye
16:57 oleonard Is it expected that one can't change the hold date of a waiting hold?
16:58 oleonard If an item is on the list of holds waiting past their expiration date how else could you extend the wait?
16:59 caroline I don't think you can
16:59 caroline if you have the cron, it will disappear, if not, then you can leave it there until the date you want
17:01 oleonard *I* can decide to leave it on the list, but the next person to look at the list won't know I intended to keep it
17:16 cait hm i thought there was a patch to make it possible to change the date
17:16 cait but i might be confusing it
17:16 cait bye all!
17:30 caroline there was a patch to cancel waiting holds, but I haven't seen one for extending the waiting period... that being said, I don't look at all the bugs...
17:38 caroline maybe cait was thinking of bug 8367?
17:38 huginn` 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 enhancement, P5 - low, ---, aleisha, Needs documenting , How long is a hold waiting for pickup at a more granular level
17:39 caroline it doesn't seem to allow to modify the waiting date for a specific hold, but adds a column in the circ rules
17:44 caroline Is there a way in bugzilla to change the width of the columns? The Status column is very narrow and it's impossible to know if the status is Needs Signoff or Needs Documenting just from the results list
17:51 aude_c[m] Haha! I asked the same question not so long ago
17:52 aude_c[m] I think the answer was something like: "people tried in the past; but it's not easy"
17:53 aude_c[m] Would it be easier to change the wording so there aren't two statuses that start with "Needs"?
17:53 caroline Maybe "Documentation needed"?
17:55 aude_c[m] "ashimema... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/ocKDQtnzqCjEPQBnDrNGHwUe>)
17:55 aude_c[m] (from 17th November)
17:58 caroline so it's too hard to change the column width, and too hard to change the status name is what I understand
17:59 aude_c[m] I didn't have a lot of time to dig further when I asked... May be worth asking again earlier in the day (in Western European time)
18:00 aude_c[m] (off now, see you tomorrow!)
18:00 caroline bye!
21:02 ashimema I found when I looked that it's not just column width
21:02 ashimema But actually the data being sent back
21:04 ashimema It's limited at the server.. the string sent back is limited down
21:07 caroline Interesting
21:41 ashimema I'm sure it's doable
21:41 ashimema And agree it's a good idea
21:42 ashimema But as I don't host or maintain bugzilla, it's something we'd need to sell to rangi and work out how to impliment
22:17 dcook Whoa people are still around