Time Nick Message
20:38 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
20:38 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 enhancement, P5 - low, ---, oleonard, Needs Signoff , Convert OpacSuppressionMessage system preference to HTML customization
20:38 davidnind oleonard: still getting database update errors for bug 34894, after follow-ups pushed for bug 31383 - I don't get an error if there is no content, I do get an error if there is existing content
19:54 davidnind cait++ Thanks for replying to the email with an SQL query
17:16 tcohen[m] thanks
17:16 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35136 major, P5 - low, ---, koha-bugs, NEW , Error during database update after Bug 31383
17:16 oleonard tcohen[m]: I think I found the root of my problem, described in Bug 35136. I'm curious whether davidnind has the same data issue since he said he had a problem with the upgrade too
16:59 caroline thanks! It's mostly to send notices to spanish-speaking patients
16:57 tcohen[m] Feel free to ask, or point them to me. Theke maintains it, mostly
16:56 caroline ok thanks! We have a client who wants to add spanish and I was looking for a "latin american" spanish and couldn't find it heh
16:55 tcohen[m] Most differences would be found within Latin America actually
16:55 tcohen[m] There's only one. We try to make it neutral
16:52 caroline is there only one spanish translation? it's similar enough between latin america and spain?
16:45 oleonard I will try to narrow it down
16:45 tcohen[m] ?
16:45 tcohen[m] oleonard: can you put some 'steps to reproduce' on a separate bug so we keep track of it
16:44 tcohen[m] and upgrade tests weren't failing anymore
16:44 tcohen[m] right, I saw the patch, noticed he pushed it
16:44 reiveune bye
16:39 ashimema and asked kidclamp to take a look
16:39 ashimema I just stopped when I realised he'd put a patch up
16:39 ashimema I'm not sure how far Joubu got to be honest
16:35 oleonard tcohen[m]: I ask because it didn't fix it for me
16:33 tcohen[m] oleonard why so?
16:33 ashimema aha.. it's a tiny line under "Patron permissions defined"
16:26 ashimema how that hole area works?
16:26 ashimema does he manual talk about what patrons staff should be able to see anywhere?
16:09 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
16:09 oleonard I take it the follow-up on Bug 31383 was not intended to address the db upgrade problem?
16:04 paulderscheid[m] Thanks ashimema, then i can keep the test :D
16:02 ashimema Joonas did a bunch of work on it
16:01 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 enhancement, P5 - low, ---, joonas.kylmala, CLOSED FIXED, SelfCheck machine starts the hold instantly with an email sent out
16:01 ashimema Bug 12556
15:58 ashimema Maybe not made it into the docs yet
15:58 ashimema It's fairly new
15:58 ashimema I think it's the other way around if memory serves
15:52 paulderscheid[m] But it's not listed in the manual.
15:51 paulderscheid[m] There's still the method is_in_processing in 22.11.
15:51 paulderscheid[m] To anyone still out there: Is the 'P' code in reserves retired?
15:50 cait later #koha
14:52 MichaelaSieberBIB[m] <PedroAmorim[m]> "hi, was to thank you for testing..." <- ok, thanks, I'll try later
14:42 ashimema I've gone from 4 tests to 235 for you on that embedding bug now
14:42 ashimema lol
14:41 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 new feature, P5 - low, ---, matt.blenkinsop, Signed Off , Add a Usage Statistics module to ERM
14:41 PedroAmorim[m] hi, was to thank you for testing bug 34587 and if you could take a 2nd look, we've followed up with your feedback (was great btw!)
14:40 MichaelaSieberBIB[m] <PedroAmorim[m]> "Michaela Sieber (BIB): around?" <- Hey Pedro, not really, in meetings
14:07 ashimema boolean stuff seems a little out of kilter too
14:07 ashimema and
14:07 ashimema like converting to json rfc dates
14:07 ashimema but of course.. what I didn't consider before were the additional effects at a bit of a distance..
14:06 ashimema in my case I'm extending the tests I did write.. to cover all columns
14:06 ashimema lol
14:06 tcohen[m] Anytime I write tests for old stuffs, I notice why they avoided doing it in the first place haha
14:05 ashimema they always highlight oddities in code.. haha
14:05 ashimema writing tests is fun
14:00 paulderscheid[m] Can't wait for our migration to finish.
14:00 paulderscheid[m] I think the last few releases really speak for themselves. Lots of great features!
13:38 * ashimema wants to volunteer pedro at some point.. but not quite yet
13:37 tcohen[m] it's been a bunch of interesting cycles for me, in terms of features added, etc. I'm generally happy
13:37 ashimema but I think some fresh blood would do the project good right now
13:37 ashimema I'd love to do it again 'one day'
13:37 ashimema agreed
13:37 tcohen[m] New people, new ideas, that's always good for the project
13:36 tcohen[m] LOL
13:36 oleonard How long has it been since rangi did it... maybe he forgot :D
13:35 oleonard It's a shame the job burns people out
13:34 oleonard I understand tcohen but :(
13:34 tcohen[m] haha
13:34 tcohen[m] of not signing for a long time
13:34 tcohen[m] I'm thinking
13:31 * ashimema wonders if there's anyone thinking about RM role?
13:30 magnuse_ matts++
13:28 matts Thanks :)
13:28 ashimema I'm confident you'd do well there 😛
13:28 ashimema go for it matts
13:28 matts Hey ! I'd like to apply as Topic Expert for 24.05 regarding SIP2 and CAS. Should I just add my name to https://wiki.koha-community.org/wiki/Roles_for_24.05 ?
13:26 PedroAmorim[m] Michaela Sieber (BIB): around?
13:25 marcelr htg
13:25 marcelr ok, please put it on the report; thx
13:24 ashimema those should all respect this (thus it should unblock the two bugs that depend on it.. and improve the situation in a few other places too I think from memory)
13:24 PedroAmorim[m] <caroline> "I don't really know kbart, but I..." <- definitely would help, yes, thank you.
13:23 ashimema ok.. pretty much any of the api endpoints using embed: patron
13:22 ashimema gah.. instead of a stream of consciousness here.. I'll stick it in the bug once I've worked it out 😜
13:21 ashimema so
13:21 ashimema that's one clear place I think...
13:21 ashimema Joubu is using it in the items by ajax bug
13:21 ashimema I'll look at the history to remind myself on that one
13:21 ashimema as for real life use case...
13:21 ashimema yeah.. those unit tests are really lacking.. i will work on embellishing them now
13:20 ashimema coolios
13:20 tcohen[m] ashimema++
13:20 tcohen[m] marcelr++
13:18 ashimema ok.. will take a look at the comment now
13:18 marcelr happy to ignore
13:18 marcelr 5 lines on qa tools
13:18 marcelr will not talk about tidying the unit test scripts btw
13:17 marcelr ashimema: please look at my last comment on 29523, i will finish qa after that
13:12 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
13:12 ashimema sorry.. I meant bug 31383
13:11 ashimema but came to basically the same conclusion
13:11 ashimema I missed it and have been cleaning up
13:11 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 enhancement, P5 - low, ---, nick, Needs documenting , Use template plugins to display OPAC news on homepage
13:11 ashimema did you see Joubu's patch on bug 29691 already tcohen
13:11 ashimema ho..
13:10 ashimema grr
13:09 marcelr posting on the report now
13:09 marcelr the last patch is not very intensively tested
13:09 marcelr well i think that i want still some additional unit testing there
13:07 tcohen[m] marcelr: awesome
12:56 caroline I don't really know kbart, but I can look at the fields in the interface and let you know which fields in biblio/biblioitems maybe? would that help?
12:56 caroline Ok I thought it was MARC because the manual mentions marc fields
12:55 PedroAmorim[m] I guess we could convert KBART to MARC instead, but I'm not sure how much more work that would be.
12:55 PedroAmorim[m] What I'm trying to do here is convert KBART to Koha, because at that point we have a eHolding local title (KBART) but we want to add a corresponding biblio.
12:55 PedroAmorim[m] caroline: hi! I think the answer to that is "sort of, but not really".
12:49 marcelr yes that one
12:49 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 major, P5 - low, ---, martin.renvoize, BLOCKED , Add a way to prevent embedding objects that should not be allowed
12:49 marcelr bug 29523
12:49 marcelr tcohen[m]: i came here in the context of qaing 29523
12:49 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Bibliographic record from local title only has 245$a
12:49 caroline PedroAmorim[m], bug 35095 are the missing mappings marc mappings? I can help with those
12:45 paulderscheid[m] Hmm, thanks cait
12:44 tcohen[m] that is not working as expected
12:44 tcohen[m] in Koha::AdditionalContents->search_for_display
12:44 tcohen[m] but there's something on the query
12:44 cait it might be nice, if you add something with jQuery it 'half works' because it loses the setting after the search
12:43 cait ah
12:43 tcohen[m] ashimema: it is obvious that the tests cannot generate a Koha::AdditionalContent object with the 'lang' paramenter, which was moved
12:43 paulderscheid[m] I pointed him here and said: "I bet there's a built-in way for that" :P
12:43 cait2 i haven't checked if CSS could work too
12:43 cait2 i think there is no pref or similar
12:42 paulderscheid[m] yeah
12:42 cait2 paulderscheid[m]:did you mean the list of search options? (network disconnect) then no
12:41 marcelr yeah i will not finish this in 5 mins tcohen
12:41 ashimema half term here.. so took longer for lunhch 😜
12:40 paulderscheid[m] cait2
12:40 ashimema looking at tests now tcohen
12:40 paulderscheid[m] So there's no built-in way for that?
12:37 cait2 PriyanshuSoni[m]: you can with jquery, check the jquery library in the wiki for examples
12:37 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
12:37 tcohen[m] marcelr: the breakage in tests caused by bug 31383 seems far more urgent
12:35 PriyanshuSoni[m] can i hide all these and keep only title and author?
12:35 PriyanshuSoni[m] https://prnt.sc/JrjezC7UluM9
12:32 marcelr kind of stupid
12:31 marcelr in 2.0 you should list them all etc / it seems not possible
12:31 marcelr yes, we also use -1 stuff in paging
12:31 tcohen[m] we should move to OpenAPI3 damn, we always reach the same comment lately
12:30 * tcohen[m] uploaded an image: (76KiB) < https://matrix.org/_matrix/media/v3/download/matrix.org/YFymhOqjeinxZlVfseZHdgQE/image.png >
12:30 marcelr openapi 3.0
12:28 marcelr looking at it from every side :)
12:28 tcohen[m] ok, I thought you were still exploring your initial idea
12:27 marcelr if swagger rejects it, you will not reach Pagination
12:27 tcohen[m] yeah, it gets creepy
12:27 tcohen[m] you would return NaN or similar for 'pages'
12:27 marcelr but it currently results in 404 Page not found
12:27 tcohen[m] if you did it the wa y you proposed
12:27 marcelr using not:
12:26 tcohen[m] Pagination.pm:106
12:26 marcelr i am looking at not allowing it completely in the general spec file
12:26 tcohen[m] how would you solve it
12:26 tcohen[m] marcelr
12:22 marcelr if i just solve the division, i will get the first page now
12:22 tcohen[m] the quesiton is then wether let the query and the eventual joins, etc move forward, or just return $resultset->empty in objects.search_rs
12:22 marcelr for the purists
12:21 marcelr its a bad road in rest api terms
12:20 tcohen[m] marcelr: well, doing a COUNT vs actually retrieving the data
12:20 tcohen[m] I guess the pages count would be inifinite heh
12:19 marcelr they say it makes no real difference; you fetched the data already
12:19 paulderscheid[m] That's also not bad but seems a bit unintuitive
12:19 marcelr yeah it is a bit "restless"
12:19 tcohen[m] so a feature
12:19 tcohen[m] withtout getting the results
12:18 tcohen[m] I think Joubu once mentioned using _per_page=0 for getting the totals and stuff
12:18 marcelr haha
12:18 paulderscheid[m] marcelr: I was immediately swayed by this :D
12:18 tcohen[m] well
12:18 paulderscheid[m] Yeah, has it's charme but in the end we maintain a case that serves no purpose.
12:17 tcohen[m] but I of course see the point of returning [] and think it is more consistent
12:17 tcohen[m] I said a 400, because we could bake the validation on the spec, in a single place
12:16 paulderscheid[m] tcohen has a point
12:16 marcelr at least more changes for no value
12:16 marcelr yeah that might be harder
12:16 tcohen[m] also, I wouldn't like to hit the DB at all
12:16 marcelr why?
12:16 paulderscheid[m] True
12:15 tcohen[m] we can decide not to accept it
12:15 paulderscheid[m] just []
12:15 paulderscheid[m] Seems more logical
12:15 marcelr you get what you ask for ?
12:15 marcelr tcohen[m]: or 200 with no data ?
12:14 oleonard For what it's worth, if I removed notices from the letters table which had a branchcode the updatedatabase completed without error
12:14 tcohen[m] make it return a 400 marcelr
12:11 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 normal, P5 - low, ---, koha-bugs, NEW , REST API: _per_page=0 crashes on Illegal division by zero
12:11 marcelr bug 35129
12:10 ashimema dang
12:10 marcelr [ERROR] GET /api/v1/patrons: unhandled exception (Mojo::Exception)<<Illegal division by zero at /usr/share/koha/Koha/REST/Plugin/Pagination.pm line 106.>>
12:09 marcelr not tested yet :)
12:08 marcelr Nice /api/v1/patrons?_page=1&_per_page=0 just returns me a 500 (ISE)
11:59 ashimema let me have some lunch and then my brain might be in the right place to take a stab 😜
11:59 ashimema not yet I wasn't
11:57 tcohen[m] Joubu, ashimema any of you looking at the failures on additional_contents?
11:54 cait oleonard++
11:52 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 enhancement, P5 - low, ---, agustinmoyano, Needs Signoff , Add import sources CRUD
11:52 tcohen[m] bug 32607 is using Vue ✌️
11:51 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
11:51 tcohen[m] anyone working on bug 31383 ramifications?
11:46 tcohen[m] marcelr: ok
11:39 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 enhancement, P5 - low, ---, m.de.rooy, Failed QA , Move domain limits from koha-conf to staff SMTP configuration
11:39 marcelr tcohen: hi, i postponed the work on bug 33537 to a next version for now
11:23 oleonard Shouldn't I still have an additional_contents table? :|
11:18 oleonard Commenting out the 'if (@$notice_templates) {'... section at least lets the update finish
11:15 tcohen[m] hola #koha o/
11:00 marcelr aarg that sounds bad
10:59 oleonard ERROR - {UNKNOWN}: Not a HASH reference at /kohadevbox/koha/installer/data/mysql/db_revs/230600041.pl line 130. at /kohadevbox/koha/C4/Installer.pm line 741
10:58 marcelr which error ?
10:57 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
10:57 oleonard I see an error from updatedatabase after bug 31383
10:51 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Additional contents: We need a parent and child table
10:51 oleonard I guess I should have been paying attention to Bug 31383...
10:36 ashimema haha
10:36 oleonard I think we should have them in an exotic locations and offer free travel.
10:31 ashimema help give devs a leg up
10:31 ashimema I think we should have a few vue workshops during the next cycle
10:31 ashimema sorry dude.. i'm slow today
10:31 ashimema more coffe needed.. those are versions!
10:31 marcelr no Koha versions
10:30 ashimema blah
10:30 ashimema really really old ones
10:30 ashimema are those bugs?
10:30 ashimema 2405 and 2411 ?
10:30 oleonard I would be pushing for Vue if I knew Vue ;)
10:30 ashimema whilst I think it would be great for more developments to start going the vue route.. I don't think we should be blocking things for it yet.. we need more of a stable base and examples for that first
10:29 marcelr just one did :)
10:29 ashimema yeah.. I'm not pushing for vue at all yet
10:28 marcelr i did not even mention the argument "it should be in vue" -- wondering how many devs are already up to date for vue patches
10:27 marcelr ashimema: thx for your feedback, i will revisit the report for 2405 or 2411
10:26 marcelr hi oleonard
10:25 oleonard o/
10:23 ashimema so it's would "just" be switching the navigation elements (i.e. adding it to the admin home page, sidebar and breadcrumb more appropriately... but I wasn't 100% comfortable that assumption was right without remembering how it interlinks.. i.e. does it actually need some link to SMTP Servers or is it entirely independent.. all be it related by the field it's working in "email")
10:21 ashimema I was going to let the JS stuff through if that makes a difference to your thoughts?
10:18 marcelr too bad
10:17 ashimema OK, that makes sense
10:17 marcelr i want to change it myself but thats not gonna happen before friday
10:17 ashimema I was a little confused by the UI in terms of how you navigate around (I can't remember enough how the feature works to really understand the link between SMTP Servers and these Limits
10:17 marcelr i would appreciate a bit more specific feedback on the report if any
10:16 ashimema yeah..
10:16 ashimema I had two things I wanted to understand better first though
10:16 marcelr it does nt meet standards
10:16 ashimema in fact.. I'd love to see it move
10:16 ashimema I wasn't against that bug
10:16 ashimema well
10:15 ashimema that was an aside
10:15 marcelr ashimema: i think that i should pull 33537 out of the race for now ?
10:15 * ashimema really wants more questions answered on the style guide discussion
10:15 marcelr np
10:15 ashimema reading back
10:15 ashimema sory.. just got out of a meeting
10:15 ashimema hi
10:14 marcelr ashimema: around ?
09:52 marcelr adding Joubu in cc
09:52 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35127 normal, P5 - low, ---, koha-bugs, NEW , Patron search ignores searchtype from the context menu
09:52 marcelr bug 35127
09:50 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 enhancement, P5 - low, ---, nick, Patch doesn't apply , Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes
09:50 marcelr yes but this is even without those..
09:50 cait bug 34519
09:49 cait look for extended patron attribute plugin
09:49 cait but that was for extended patron attributes I believe
09:49 cait I removed some from the queue because the dependent bug is blocked
09:48 marcelr i though there were a lot of followup fixes
09:48 marcelr weird
09:47 cait who did QA? ;)
09:47 cait that's bad
09:47 cait DefaultPatronSearchMethod
09:47 marcelr yes cait i saw the pref but you cannot overrule it
09:47 cait but it should also show correctly selected filters...
09:47 marcelr i am opening an bugzilla report
09:47 cait there is a system preference that shoudl do the default
09:46 marcelr i do not understand; does nobody use that?
09:46 krimsonkharne[m] np
09:46 krimsonkharne[m] btw the same thing for check out, not just patron search...
09:46 marcelr thx for confirming krimsonkharne[m]
09:46 krimsonkharne[m] (also did a git pull this morning)
09:45 krimsonkharne[m] on master (ktd)
09:45 krimsonkharne[m] hi marcelr, can confirm, choosing searchtype "Contains" instead of "Starts with" doesn't work for me either
09:32 marcelr I am seeing this in 22,11 and master ??
09:29 marcelr Can anyone confirm if Patron search just ignores the searchtype from the context menu at the right? Or am I doing something wrong?
09:28 marcelr hi #koha
08:37 davidnind it was a long weekend here in NZ, so maybe got too much sun, or stuck in traffic returning from wherever they went on holiday to...
08:27 * ashimema had a picture of a hung over robot slouched in a corner there.. thanks magnuse 😛
08:26 * magnuse_ suspects wahanui of sleeping in some quiet corner
08:13 cait wahanui is missing
08:13 cait3 only if around
08:13 cait3 Next meeting?
08:02 PedroAmorim[m] o/
08:01 krimsonkharne[m] (wasn't that something that wahanui / huginn could do?)
08:01 krimsonkharne[m] next meeting?
07:52 magnuse_ not me :-)
07:52 cait magnuse_: i had already done those last week heh :)
07:48 magnuse_ ...and for 23.05
07:46 paulderscheid[m] morning #koha
07:45 krimsonkharne[m] morning #koha
07:40 cait new strings for 22.11 have appeared :)
07:40 cait1 hi matt, ashimema, magnuse_, good morning #koha
07:31 ashimema morning
07:31 matts hello !
07:12 magnuse_ \o/