Time Nick Message 04:05 * Oak waves 04:05 Oak magnuse 05:28 Joubu cait: yes I guess we can adjust the script, you can report the problem there https://gitlab.com/koha-community/koha-meetings/-/issues 05:33 Joubu kidclamp: yes, we have a test, and it's failing :D 05:34 Joubu kidclamp: t/db_dependent/selenium/regressions.t 06:04 dcook__ Sorry for all the emails folks.. 06:10 magnuse \o/ 06:10 magnuse Oak 06:40 reiveune hello 07:28 cait good morning #koha 07:54 cait2 Joubu: did you see my comment about IRC being removed from wiki title because it's no longer IRC? 07:56 Joubu yes, I replied 07:56 Joubu cait: yes I guess we can adjust the script, you can report the problem there https://gitlab.com/koha-community/koha-meetings/-/issues 08:08 cait ah missed that 08:08 cait i didn't want to add the wiki page without talking to you 08:11 cait Joubu: https://gitlab.com/koha-community/koha-meetings/-/issues/6 08:11 cait should I create the wiki page manually now or rather wait? 08:35 Joubu please create it 08:42 ashimema bug 35099 now has a patch 08:42 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099 normal, P5 - low, ---, martin.renvoize, Needs Signoff , Cannot load records with invalid marcxml 08:42 ashimema and this is the challenge with a tree bug taking so long to work through.. all the fixes that went into it's sibling never made it to this bug in the interim 08:42 ashimema oh well 08:44 Joubu ashimema: why not keep the current pattern? 08:44 ashimema what do you mean? 08:44 ashimema I cloned the pattern from the sub that does almost the same directly above it 08:44 Joubu right, nevermind 08:44 ashimema is there a different pattern U'm unaware of? 08:45 Joubu you can get an explosion from get_marc_volumes even when you looking at the problematic record, that's it? 08:45 ashimema happy to be told there's a better pattern.. it's been a while since I fixed one of these 08:46 Joubu I thought the problem was a missing check to $invalid_marc_record in catalogue/detail.pl 08:46 ashimema correct.. because it searches for and may find a bad related record.. 08:46 ashimema I think 08:46 ashimema nah.. we weren't catching and passing it.. in this case.. i think 08:46 ashimema honestly.. I'm mid resetting ktd to test it 08:46 ashimema just wanted to get the patch up there 😜 08:50 ashimema ha, syntax error 08:50 ashimema will upload a fixed patch.. 08:50 ashimema typo in 'error' 08:52 Joubu Can I get a QA stamp on bug 35024 please? 08:52 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35024 normal, P5 - low, ---, jonathan.druart+koha, Signed Off , Do no wrap PO files 08:54 ashimema on it 09:04 Joubu thanks! 09:06 Joubu aude_c[m], first contributor to the translations using Weblate \o/ 09:06 Joubu https://gitlab.com/koha-community/koha-l10n/-/commits/master?ref_type=heads 09:07 magnuse aude_c++ 09:09 ashimema oh cool 09:40 cait Joubu: page created, hope I did it right: https://wiki.koha-community.org/wiki/Development_Meeting_1_November_2023 09:41 Joubu if you used the template it should be good 09:41 cait tempalte? 09:42 cait i copied and adapted the old one... (you should not let me do these things...) 09:42 Joubu https://wiki.koha-community.org/wiki/Development_IRC_meeting_Template 09:42 Joubu nobody should do these things, that's why there is a script... 09:43 Joubu @later tell marcelr you are not supposed to be on bugzilla without being on IRC! ;) 09:43 cait I've fixed the placeholders at the bottom to match the tempalte 09:43 huginn Joubu: The operation succeeded. 09:44 Joubu categories is used when the page is created 09:44 Joubu you have created it already, so it won't be replaced 09:45 Joubu __MINUTES__ and __NEXT_MEETING__ are replaced when the meeting is done and we create a the next one 09:49 cait ok 09:50 cait CATEGORIES removed 09:51 Joubu bug 33568 is ready for QA <3 09:51 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Use the REST API to display items on the biblio detail view 09:52 ashimema awesome 09:54 paulderscheid[m] Morning #koha 09:55 paulderscheid[m] Hey ashimema, do I remember that right.. you still use 22.11 a lot in prod, right? 09:55 ashimema correct 09:55 ashimema we're a .11 house here 09:56 ashimema Joubu 09:57 ashimema are you happy for the datatables upgrade to go through before 33568.. i.e. I predict that will mean a rebase is required right? 09:57 paulderscheid[m] Do you know your way around reserves? I'm pretty much copying stuff from the REST api for my 3rd party integration but I stumbled over C4::Reserves::* stuff. 09:57 paulderscheid[m] It seems that C4::Reserves::* uses Koha::Objects and the the api, using Koha::Objects, uses C4::Reserves::* stuff. 09:58 Joubu ashimema: yes, it needs to be tested on top, I haven't 09:58 ashimema haha... it's certainly one of the more involved area's of Koha 09:58 ashimema ok.. 09:58 paulderscheid[m] My question essentially is, if a 3rd party integration makes reserves what do I need to look out for to not break the system ;D 09:58 ashimema I will happily QA asap 09:59 ashimema well.. the API "should" handle all that for you 09:59 ashimema and I believe it's pretty well tested as Aspen uses it I think 10:00 paulderscheid[m] Ok that's good to know. The reason I ask is that I want to reduce the code as much as possible. So I just wanted to know what I can toss out. 10:01 ashimema 😄 10:02 paulderscheid[m] Thanks for the help, ashimema++ 10:09 Joubu ashimema: rebased on top of the DT upgrade 10:20 ashimema nice one 10:20 ashimema just building a package and installing it on a customers test system, then I'll focus on this QA 🙂 10:20 ashimema great work Joubu 10:20 ashimema and oleonard for testing 🙂 10:25 oleonard Hi all 10:46 magnuse kia ora oleonard 11:35 marcelr o/ 11:35 marcelr Joubu: you are misusing later :) 11:41 marcelr can someone qa bug 32305 please ? 11:41 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305 major, P5 - low, ---, m.de.rooy, Signed Off , Background worker doesn't check job status when received from rabbitmq 13:16 caroline oleonard-away, around? 14:12 ashimema marcelr I'm more than happy to squash a bunch of things on the embedding bug btw.. I kept them disperate to show the thought flows.. but I think at this stage we should probably squash a bunch of them before pushing it 14:12 ashimema I will look at bug 32305 in a few minutes btw 14:12 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305 major, P5 - low, ---, m.de.rooy, Signed Off , Background worker doesn't check job status when received from rabbitmq 14:12 ashimema unless anyone's beaten me to it 14:12 marcelr ashimema: what do want to squash exactly ? 14:14 ashimema bug 29523 14:14 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 major, P5 - low, ---, martin.renvoize, Signed Off , Add a way to prevent embedding objects that should not be allowed 14:14 ashimema there's a load of history on the bug.. lots of commits doing and then undoing things 14:14 ashimema I'm happy for it to go as is.. but also happy to squash a bunch 14:15 ashimema I'll let you do that final QA though and you can let me know if you think we should squish it 14:15 marcelr ok np did not have the context rightaway 14:16 marcelr @later tell tcohen submitted 33608 again 14:16 huginn marcelr: The operation succeeded. 14:17 ashimema yeah.. sorry.. juggling calls 14:22 marcelr htg 14:43 oleonard I'm around now caroline 14:44 caroline hi! I wanted you opinion on this, there are two links and a button that do the same thing https://snipboard.io/2YDbq7.jpg 14:44 caroline is there a guideline for link vs button? 14:45 oleonard There's not a firm guideline. 14:46 oleonard I think the dialog should probably contain link buttons and the other controls should not appear. 14:47 oleonard Kind of like this: https://snipboard.io/hvl6QY.jpg 14:47 * oleonard noticing the "Delete" button has the wrong icon... 14:56 cait true 15:28 cait byeeee :) 16:11 paulderscheid[m] For anyone who needs laughs and wisdom: https://grugbrain.dev/ :D 16:16 caroline cdg 16:16 caroline oops sorry wrong window :) 21:26 tuxayo Hi :) Does anyone know about self check in and can give some more details about how to test this? bug 34946 21:26 tuxayo https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946#c2 21:26 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 minor, P5 - low, ---, oleonard, Needs Signoff , Remove the use of event attributes from self checkout and check-in 21:26 huginn 04Bug 34946: minor, P5 - low, ---, oleonard, Needs Signoff , Remove the use of event attributes from self checkout and check-in 21:52 tuxayo thanks for checking davidnind , sco-main.pl works for me but it's sci-main.pl that I don't know how to access. 21:53 angelic @later tell oleonard : hi oleonard In fact In this picture I need to put related HTML link here where I marc with red. ( https://snipboard.io/Otnwyj.jpg) 21:53 huginn angelic: The operation succeeded. 21:56 nikkom Hi koha. I am new in perl and Ihave met this line in perl codes several times. [% XSLTBloc | $raw %] I couldnt understand how it is working. Could anyone explain it to me please. Sample codes: intranet/htdocs/intranet-tmpl/prog/en/modules/catalogue/detail.tt and opac/htdocs/opac-tmpl/bootstrap/tr-TR/modules/opac-detail.tt 21:56 nikkom Thanks a lot 22:42 tuxayo nikkom: This is from a template. The part to build HTML responses. This is how to print a variable in the HTML. And | $raw is to not escape it. https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_template_variables 23:59 dcook Is there anything more satisfying than uncovering the root cause of a bug and fixing it?