Time Nick Message
20:37 cait Shane-NP[m]: well done :)
19:31 caroline you too, take care!
19:28 Shane-NP[m] Have a nice weekend!
19:28 Shane-NP[m] at least the core server is up, and I know how easy the migration is now
19:27 Shane-NP[m] Well wait...scratch that, I need to move the other library I host...doh
19:27 Shane-NP[m] I can put the v18.11.05 to bed next week once I verify everything :)
19:27 caroline Shane-NP++ awesome!
19:27 Shane-NP[m] cait caroline Thank you guys for the help, I got my data onto a new 4CPU, 16Gb server running 23.05.03
19:27 cait fridolin++
18:11 caroline the "black magic" is probably somewhere in that bug fix
18:10 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 normal, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, Standardize how OPAC and staff determine requestability
18:10 caroline It was in a 5 year-old ticket, and the original table had a LOT of red (button should be there but is not or button is there when it should not) bug 3142 helped a lot
18:09 caroline re: hold button, I finally found the table, it was deep in our ticketing system. This is the result for 21.05 https://snipboard.io/OVUHn1.jpg
18:01 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23650 enhancement, P5 - low, ---, koha-bugs, NEW , Restrict access to pages by home library or patron category
18:01 caroline I put our conversation from yesterday (a summary of) in bug 23650
18:01 oleonard A predefined page? We don't really have a system for designating via the pages system something which is a "system" page
18:00 caroline oleonard, should it be an HTML customization or a page?
17:48 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34892 enhancement, P5 - low, ---, oleonard, ASSIGNED , Convert RestrictedPageContent system preference to HTML customization
17:48 oleonard I pose a question on Bug 34892
16:52 oleonard davidnind++
16:47 davidnind oleonard++
16:32 cait have a nice weekend all!
16:32 * cait waves
16:30 oleonard Thanks davidnind!
16:29 davidnind jalway: LOL
16:29 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 minor, P5 - low, ---, koha-bugs, NEW , View restrictions button (patrons page) doesn't link to tab
16:29 davidnind oleonard: Bug 34891
16:12 jalway davidnind: But, then you couldn't have the fall of autumn.
16:12 MichaelaSieberBIB[m] <caroline> "I did a mega table at one..." <- sounds helpful, I am interested ;-)
16:11 oleonard davidnind: i would be grateful if you could create the bug
16:10 davidnind [Off topic] Is it 'autumn' or 'fall'? Why does this season have two vastly different names? https://www.merriam-webster.com/grammar/autumn-vs-fall
16:10 davidnind Shall I create a bug for it?
16:08 oleonard The link is incorrect, probably my fault from Bootstrap tabs work
16:04 oleonard Yeah I know what you're talking about
16:03 davidnind oleonard: is there a way to link to a tab (like a bookmark) and have the tab open as well. For example: patron check out and details pages - when you have restrictions there is a 'View restrictions' button, it opens the tab, but doesn't move down the page to the tab. Hope that makes sense!
15:59 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 enhancement, P5 - low, ---, oleonard, Needs Signoff , Convert OPACResultsSidebar system preference to HTML customization
15:59 oleonard Sheesh... Maybe I'll get the patch for Bug 34869 right on my *fourth* try...
15:58 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 enhancement, P5 - low, ---, hammat.wele, Failed QA , OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
15:58 caroline that button is finnicky... we have bug 30556 going, but it's failed QA right now
15:56 cait I won't be around much much longe rtoday
15:56 cait I just commented on the bug, if you could leave it there?
15:55 caroline I did a mega table at one point on what could and could not trigger the button... let me check if I can find it
15:55 caroline ok if you already checked the easy cases, it's probably beyond my comprehension also
15:53 cait did I mention there is not test plan?
15:53 cait I though I#d check the easy case first...
15:52 cait yes
15:52 caroline maybe it doesn't know your patron category
15:52 caroline are you logged in?
15:52 cait I still got the button...
15:52 cait my itemtype is 'not for loan', my circulation rule says zero holds and I set the itemtype to 'no holds allowed'
15:51 cait i am just trying to see if it does anything
15:50 tcohen[m] are you trying to understand the black magic taking place inside CheckReserves?
15:45 cait what is actually checked there?
15:45 cait although I did everything I could to not allow holds...
15:44 cait and my button si ssitll there
15:44 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34686 enhancement, P5 - low, ---, koha-bugs, NEW , reserve_id should be linked in tmp_holdsqueue
15:44 cait I am looking at bug 34686
15:44 cait hm question
15:30 cait lol
15:07 tcohen[m] smoke bomb?
15:06 * Joubu disappears
15:05 tcohen[m] ?
15:00 Joubu "my $patron_borrower", really?
14:52 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34686 enhancement, P5 - low, ---, koha-bugs, NEW , reserves_id should be linked in tmp_holdsqueue
14:52 cait bug 34686 - any opinon?
14:51 reiveune bye
14:50 tcohen[m] /names
14:49 cait jalway: the best bug - already resolved :D
14:48 jalway Joubu, cait: Thanks!
14:46 jalway Oh, I see it now!
14:46 Joubu the green tabs, you can move them
14:46 cait go to edit subfields, then drag and drop the tabs
14:46 Joubu jalway: /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=245&frameworkcode=
14:46 cait it's not super obvious
14:46 cait 22.11
14:46 cait try it
14:46 jalway Joubu: Is that a 23.+ feature? I'm not seeing it.
14:45 cait jalway: you need to drag and drop the tabs in the framework editor
14:44 Joubu Selenium is Perl, Cypress is Javascript, nothing is similar
14:44 Joubu jalway: you can, when editing the framework's structure
14:44 tcohen[m] I get that
14:44 Joubu which makes things way harder
14:44 jalway Joubu: I realize that, but you have to do that every time. Instead of having it setup in the correct order for a particular field.
14:43 tcohen[m] if we can on Selenium, we should be able to on cypress
14:43 Joubu and we are missing transactions, and TestBuilder, etc.
14:43 Joubu no we cannot, or I didn't try enough
14:43 tcohen[m] Not my friday mood to discuss about that
14:43 tcohen[m] anyway
14:43 tcohen[m] Joubu: I recall our conversation, but I still think we can do the same we do with selenium, in the interim
14:42 Joubu you can order subfields already (drag en drop)
14:42 huginn 04Bug 34888: enhancement, P5 - low, ---, koha-bugs, NEW , Enhance MARC Frameworks to allow ordering of subfields
14:42 jalway Does this make sense or am I missing a feature in Koha? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34888
14:41 ashimema brb
14:41 ashimema sorry.. jumping into a support call for a few mins..
14:41 ashimema at the moment, I think that's our best option
14:40 Joubu ashimema: could it then be: if patron is logged we call the "real" holdability calculation (IsAvailableForItemLevelRequest) otherwise we call get_onshelfholds_policy to get an idea of the holdability (circ rules)
14:37 cait ... hm, but even for some ofther it woudl depend on CircControl
14:36 Joubu please read our log from yesterday..
14:36 cait like all items for reference/ unholdable item types
14:36 tcohen[m] what is the difference with selenium tests?
14:36 cait I thin you can for a few cases, but you can't cover all
14:36 ashimema I can't really see how we can work out the holdability without a patron.. that's why the button appeared before.. we didn't check it based on aptron at all
14:36 Joubu so it's hard to require them :D
14:35 Joubu tcohen[m]: I told you yesterday, we are not ready for cypress test in Koha outside of Vue
14:35 ashimema I'm not sure.. just trying to understand the code
14:35 Joubu ashimema: should we revert?
14:35 cait Joubu: tests are up (amended second patch)
14:33 tcohen[m] should we start requiring cypress tests?
14:33 cait testing the gui was ok
14:33 cait Joubu: just writign the tests - hope you'll approve :)
14:31 ashimema they swapped out one routine for another.. so as much as the original patch that causes this looks trivial.. it actually completely changes the logic
14:31 ashimema doesn't look entirely trivial..
14:31 ashimema well.. I'm having a quick look
14:28 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 normal, P5 - low, ---, martin.renvoize, NEW , Regression in when reservation button appears
14:28 Joubu ashimema: are you working on bug 34886?
14:28 Joubu cait: hum yes, could work. A test is missing however ;)
14:16 cait patches uploaded... in case someone wants to have a look... Joubu?
14:15 cait I think it works, less lines and all - I'll try to add a unit test too
14:12 cait but ok :) I'll take more time testing it then
14:12 cait i just got it ifnished :(
14:12 cait oh no
14:11 marcelr have a nice weekend #koha
14:10 marcelr i am actually not here anymore
14:10 marcelr i should have been gone already
14:10 marcelr in cc now
14:09 marcelr but i will follow the report
14:09 marcelr :)
14:09 marcelr no
14:09 cait that's my other suggestion... I'll try it - are you around a little longer?
14:08 marcelr just a dumb question without diving deep
14:08 marcelr or do you actually need to correct something in GetHistory ?
14:07 cait less smelly?
14:06 cait GetHistory that is
14:06 cait I change get history to check for ordertatus = any and then not add the condition on orderstatus?
14:06 cait I leave the orderstatus= any
14:06 cait status is any = we set the get_canceled_order falg
14:06 cait waht about this:
14:06 cait I might have one more idea
14:05 cait I agree
14:05 marcelr change hash key, add it back later, does not look so good
14:05 cait it works, I was not sure how to do better - actually I asked you about it that day Joubu :)
14:04 cait yeah, I tried different approaches
14:04 marcelr sorry
14:04 marcelr yes
14:04 cait are we still talking about my patch or something else? :)
14:04 marcelr a bit fiddling with statuses
14:04 marcelr Joubu i agree that this code doesnt look nice
14:04 cait I admit it's not super clean... the problem is that value ="" is already taken by "all but cancelled"
14:03 cait i remove orderstatus from the search as I want to search for 'all' - but I need to add it back tot he filters, so my pull down gets set to 'any'
14:03 cait and they need to keep the search you made
14:03 cait and on the serach results you have the filters on the left
14:03 cait teh filters hash is sent to the template
14:03 marcelr you can clean that code !
14:03 marcelr yes I noticed Joubu, just persevere
14:02 Joubu I just mistyped
14:02 Joubu it's *reset*
14:02 marcelr so i dont know
14:02 Joubu and, not sure if you noticed, but I spent years trying to clean our code :D
14:02 marcelr cait Joubu referred to revert
14:02 Joubu yes but this one is not pushed!
14:02 marcelr we have a few other places in the codebase where the code is not as clean as it could be :)
14:02 cait marcelr: did you mean reset issue?
14:01 marcelr i wont , distracted
14:01 cait .. or the patch
14:01 cait or mentioned on the bug
14:01 marcelr tcohen should stay RM until 2030
14:01 Joubu marcelr: it's not an issue, it's just that the code is not very clean IMO, but we can live with it if you don't find something better in less than 10min
14:01 cait revert is not in the test plan
14:01 marcelr ok Joubu should
14:00 cait I want to explain
14:00 marcelr Joubu 24092 ^^
14:00 cait yes, but I need to understand the question first :)
14:00 marcelr no i need explanation
14:00 cait marcelr: can you explain?
14:00 marcelr Joubu always takes revenge
13:59 * Joubu votes marcelr 24.05 RM
13:59 cait let me see
13:59 cait revert issue?
13:59 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 enhancement, P5 - low, ---, katrin.fischer, Signed Off , Order search doesn't allow to search for 'all statuses'
13:59 cait NQA is finally below NSO again... but still too full
13:59 marcelr cait whats the revert issue on bug 14092
13:59 cait yes! :)
13:59 marcelr no
13:59 cait marcelr++ :)
13:58 marcelr yeah he gets too many already lol
13:58 cait Joubu++ .)
13:58 marcelr anyone else?
13:58 marcelr cait++ tcohen[m]++
13:57 cait otherwise you can't receive any order thta was created with 'in cataloguing'
13:57 cait I hope we can have it still for .04
13:57 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 critical, P5 - low, ---, katrin.fischer, Pushed to master , Receive impossible if items created 'in cataloguing'
13:57 cait tcohen: coudl you please push bug 34880? broken receives
13:57 marcelr wondering why tests with build_object and without txn are still passing qa ?
13:56 cait marcelr: done
13:56 huginn Joubu: The operation succeeded.
13:56 Joubu @later tell lukeG please take care of bug 33137 comment 21
13:56 huginn Joubu: I suck
13:56 Joubu @later lukeG please take care of bug 33137 comment 21
13:53 Joubu "reset" - + # Reset order status for 'all status'
13:51 marcelr Joubu: which revert ?
13:51 cait but my ktd pull and all is done... time to really start late
13:50 cait sorry, I got pulled away again :(
13:50 cait Joubu: missing columsn - haven't seen a report
13:44 Joubu marcelr: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156093 - can you try to improve that code? I failed. The "revert" smells..
13:41 * ashimema wonders if there's a way to sort by when status changed to pqa
13:41 marcelr so we can catch whatever was missed;)
13:41 marcelr tcohen[m]: 32496 should get a quick push?
13:40 ashimema 82 in PQA.. blimey
13:40 marcelr you can multitask
13:39 ashimema woop, woop
13:39 tcohen[m] should I push things first? or should I QA?
13:39 tcohen[m] yes sir
13:38 marcelr qa my patches please tcohen
13:38 marcelr hola tcohen
13:38 tcohen[m] ✌️
13:38 tcohen[m] wow 32496 is finally PQA
13:37 tcohen[m] the car was asking for a service heh
13:36 tcohen[m] I'm sorry I got in late today, QA day for me
13:36 tcohen[m] hola caroline
13:36 caroline hola tcohen!
13:36 tcohen[m] Joubu: fail
13:35 tcohen[m] hola #koha o/
13:25 Joubu https://snipboard.io/vyBt2F.jpg - missing columns there, reported already?
13:21 Joubu abandonned*
13:21 Joubu gonna fail incomplete commit titles or we abandon this rule?
13:15 marcelr two liner
13:15 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34885 minor, P5 - low, ---, m.de.rooy, Signed Off , Improve confusing pref description for OPACHoldsIfAvailableAtPickup
13:15 cait bug 34885
13:11 huginn marcelr: The operation succeeded.
13:11 marcelr @later tell cait could you qa 34885
13:00 Joubu ashimema: I've added a patch on 34842
12:59 Joubu I can explain more, but I complained already too much today..
12:58 Joubu ;)
12:58 Joubu they are trivial patches making jenkins not happy
12:57 marcelr lol
12:57 marcelr yes i do not like people to bother with my patches at all, but i cant push them yet !!
12:56 Joubu thanks, marcelr. I didn't want to bother people will silly patches so I PQA them directly.. :D
12:55 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 normal, P5 - low, ---, pedro.amorim, ASSIGNED , t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded
12:55 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 enhancement, P5 - low, ---, pedro.amorim, Pushed to master , Remove ILL partner_code config from koha-conf.xml and turn it into a system preference
12:55 Joubu ashimema: can you clarify bug 32911 on bug 34842 please?
12:53 marcelr you got one
12:51 marcelr do you still need a signoff line there
12:50 marcelr so Search.t works again, so lets sleep further
12:50 Joubu it works with "today" and "tomorrow" as well
12:49 Joubu lazy yesterday, bothered today
12:49 marcelr i must have been very tired :)
12:49 Joubu you wrote that :D
12:49 Joubu "It does NOT include a database revision for existing installations. You never know if someone used the field somehow ;)"
12:49 marcelr this starts with a 2
12:48 marcelr my memory goes back about 3 reports
12:48 marcelr cool
12:48 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 normal, P5 - low, ---, m.de.rooy, CLOSED FIXED, New installations should not contain field 01e Coded field error (RLIN)
12:48 Joubu bug 24274
12:48 marcelr did I ? :)
12:48 Joubu or you would have done it when you removed 01e ;)
12:48 Joubu we don't want to remove them from upgraded installs
12:47 marcelr why not add a dbrev ?
12:47 Joubu and IIRC wa cannot have one
12:47 Joubu we cannot remove from the DB there is no transaction in this file*
12:47 Joubu we cannot there is no transaction.
12:46 marcelr "we are not in the transaction" means ?
12:46 Joubu but actually the fix is as easy as surrounding with quote
12:46 marcelr was thinking that, yes
12:45 Joubu I first wanted to remove from the DB, but we are not in the transaction
12:45 marcelr yeah i saw it passing by
12:45 Joubu yes marc_subfield_structure
12:45 marcelr yes it should be marc_subfield_structure
12:45 Joubu marcelr: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156083
12:44 Joubu hum, or the subfield structure
12:44 Joubu tagfield from marc_tag_structure
12:44 marcelr where exactly?
12:43 Joubu not upgraded ones
12:43 marcelr which field
12:43 Joubu we removed it for new installs
12:43 marcelr yeah
12:43 Joubu from the DB
12:43 marcelr come
12:43 marcelr Joubu where did the 01e came from on the Search.t report ?
12:42 Joubu Yes, I did too, when I signed off
12:42 marcelr if we push today, we could find what is remaining..
12:41 marcelr i grepped all subs he is changing, i think it looks very good
12:40 marcelr yeah
12:40 Joubu 2023-06-08 "This one should be pushed early in the release cycle."
12:40 marcelr so queue has been over 180 close to 200
12:40 Joubu otoh we should not have waited 3.5 months :D
12:40 marcelr he should not wait 6 weeks to push
12:39 marcelr two months
12:38 Joubu marcelr: do you think we still have time?
12:35 huginn marcelr: The operation succeeded.
12:34 marcelr @later tell tcohen please have a look at 32496; thx
12:04 oleonard Looks good to me!
12:01 cait I did test, but easy to get confused sometimes
12:00 cait oleonard: if you want to double check that woudl be good
11:59 marcelr o/
11:59 cait I stole it from the other similar bug - I had figured it out there
11:56 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33911 enhancement, P5 - low, ---, oleonard, Passed QA , Improve translation of title tags: Catalog, basket, and lists
11:56 oleonard cait: I'm glad you added the follow-up to Bug 33911. I thought I'd tried that method without success but I must have had something wrong
11:54 ashimema problem is.. I don't think I'm at all close enough to that code again at the moment to spot further regressions we might introduce.. that area keeps flip/flopping!
11:53 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 major, P5 - low, ---, dcook, Signed Off , Automatic renewal errors should come before many other renewal errors
11:53 ashimema I'm escalating bug 31427 from enhancement to major btw.. it's a regression as far as I'm concerned
11:53 cait ok
11:52 * ashimema has a meeting in a few minutes, but can join after
11:43 cait shoudl finish reviewing bugs first
11:37 cait ok, tol late there :) marcelr++
11:33 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34720 major, P5 - low, ---, emmi.takkinen, Passed QA , UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout
11:33 cait I'll start with bug 34720
11:33 cait let's qa! :)
11:30 ashimema hi
11:29 cait anyone still around for QA talk? :)
11:16 * cait sends cookies to ashimema
11:16 cait what did I miss? (just coming back from lunch)
11:02 oleonard cait++
10:24 Joubu https://packages.ubuntu.com/focal/mariadb-server-10.3
10:23 Joubu On Ubuntu 20.04 the latest version of mariadb-server is 10.3.38, can you upgrade it please and try again?
10:22 saa can we go back till 22.05 and rerun upgrade
10:22 saa and threw above error
10:22 saa while upgrading it stopped with 22.06
10:22 saa mariadb Ver 15.1 Distrib 10.1.48-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
10:21 Joubu mysql --version
10:21 saa no mariadb-server
10:21 Joubu Are you using MySQL 5.7?
10:21 saa but while upgrading it did not work hence we tried stable main and upgraded ubuntu
10:21 Joubu can you confirm the version of MySQL/MariaDB?
10:20 saa we had initially 18.04 with koha 20.11
10:20 saa ubuntu 20.04
10:20 Joubu saa: which OS are you using?
10:19 saa for us same 31162 on screen
10:19 huginn Joubu: The operation succeeded.
10:19 Joubu @later tell tcohen[m] installer/data/mysql/atomicupdate/bug_32162.pl has a wrong bug number 31162 vs 32162
10:18 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 normal, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, erm_eholdings_packages_agreements does not have a primary key
10:18 Joubu saa: there is a typo in the bug number, it must be bug 32162
10:15 saa can any one help
10:15 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 enhancement, P5 - low, ---, martin.renvoize, CLOSED FIXED, Add a clear cataloguing module home page
10:15 saa while upgrading koha we have error and it is mentioning bug 31162 add primary key to erm_eholdings_packages_agreements ERROR UNKOWN DBI Exception:DBD::mysql::db do failed : you have an error in your sql syntax check the manual corresponds to your mariadb server version for the right syntax to use near CONSTRAINT erm_eholdings_packages_agreements_uniq, ADD PRIMARY k' at line 3 at /usr/share/koha/lib/c4/Installler.pm line 741
10:10 marcelr bbl
10:10 marcelr i still think that a reference in the old bug is correct, and obviously opening a new bug etc is the way forward to resolve issues
10:01 paulderscheid[m] I understand that
10:01 Joubu that's bad behaviour, I plead culprit
10:00 Joubu it's definitelly more friendly, and it's what needs to be done. BUT when you are facing dozens of bugs, keep reporting them, and finally people do not care of them... lack of motivation happens.. and you just log the problem in a comment
09:59 paulderscheid[m] Reading back, ashimema is right imo. Some bugs are extremely bloated, the "new bug for a new issue" approach seems more friendly for dev.
09:57 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 enhancement, P5 - low, ---, glasklas, Signed Off , Reduce unnecessary unblessings of objects in Circulation.pm
09:57 Joubu amazing, bug 32496 still not pushed... 23.11 early push we said... let's wait for feature freeze, much more fun!
09:55 Joubu What do you suggest?
09:51 ashimema I've had a lot of things to follwo-up lately
09:51 ashimema moving on.. I'm clearly grumpy today.
09:51 ashimema I just find comments like "this clearly still needs a lot of work" years after really hard.. it's like saying.. drop whatever your doing now because I couldn't be bothered looking 2 years ago
09:50 ashimema devs all do
09:50 ashimema lol
09:49 Joubu be brave
09:49 Joubu track master :D
09:49 ashimema having a feature hit a version then getting feedback about it 12 months later is a massive massive killer
09:49 * ashimema so wants a rolling release branch and people using it
09:41 marcelr ashimema++
09:40 ashimema so
09:40 ashimema well.. I completely missed comment 514 too
09:40 ashimema ok
09:38 marcelr yeah but we were talking comments
09:38 ashimema I've create a new major bug and submitted a fix to it for that final comment
09:38 ashimema but changing and ENHANCEMENT to MAJOR doesn't make sense after it's pushed
09:38 ashimema a fix to major breakage on a new enhancement should be a MAJOR..
09:38 marcelr lets have the best of both worlds
09:38 ashimema it gets it's own status
09:38 ashimema and..
09:36 ashimema fresh branch, process being followed etc etc
09:36 ashimema it's so much easier to work on that way
09:36 ashimema generally though.. I'd always prefer a new bug linked to the original
09:36 ashimema pushed on it's own isn't soo soo bad.. but RESOLVED FIXED and onwards
09:34 marcelr ashimema: a pushed report without further comments gives the impression that a dev was fine, not causing trouble etc. but things could be differetn
09:33 marcelr responsible authorship
09:32 Joubu same when I ask questions on already pushed bugs, people don't reply
09:31 Joubu so why would I bother to open a bug? :D
09:31 Joubu I used to open new bug, but now I tend to just let a comment, because... people just don't follow-up..
09:30 marcelr a fix should go on a new repo
09:30 marcelr if a pushed bug did something wrong, we should note that on the report too imo
09:27 ashimema could we get into the habbit of opening new bugs for feedback on anything past PUSHED please.. it's really hard to keep on top of things if comments keep getting added to old bugs
09:12 cait Bug 34880 - Receive impossible if items created 'in cataloguing' is ready
09:05 cait i'll write up my tests and submit witht he follow-up
09:05 cait I thin it works
08:50 cait I'll also test subscriptions and 'not a standing order'
08:49 Joubu yup, sounds good
08:48 cait for my 2 test cases, I am working on "item on order"
08:48 cait Joubu: that seems to do the trick: https://paste.koha-community.org/26552
08:42 cait the probelm there was it was mixing up data between different order lines
08:41 Joubu I mean, the change from 34736
08:41 Joubu it feels like its what the JS code was trying to do
08:39 cait + if(row.subscription_id || row.basket.standing === true) { - shoudl we try || effective_create_items == 'cataloguing instead?
08:35 cait ok, when on Receive = we need the quantity received to say 0, when on cataloguing = 1
08:34 cait i have to verify if it's the same without your patch, sec
08:34 cait for standing order
08:34 cait Joubu: can't receive items with "on receive" :(
08:33 ashimema right.. I see.. the DB update needs a bit of a fix
08:32 cait more so as I still don#t see the advantage of the new feature
08:32 cait yeah, I am not a fan still :(
08:32 Joubu we will keep having bugs on this form, it's too fragile
08:31 Joubu yes that's seem related
08:31 cait I did a git bisect as it must have been a recent change
08:31 Joubu in the case of subscription we don't change that, so we need to set it when we load the form
08:31 cait it was a change in that JS
08:30 cait did you see I linked Nick's bug?
08:30 Joubu what's happening: row.quantity_received is set when the input is modified (there is an on change event somewhere)
08:30 cait oook... I'll still ty different things
08:29 Joubu no idea!
08:28 cait anything I should look out for?
08:28 cait i'll try to run the other item scenarios too
08:27 Joubu it fixes what you are describing, but maybe it's not enough
08:27 cait I'll test it right away
08:27 cait Joubu++
08:27 cait ...
08:27 cait any idea?
08:27 cait I was staring at this JS code without much idea
08:27 cait Joubu: you're my hero
08:27 Joubu cait: added a patch
08:26 marcelr yeah focus
08:25 ashimema just trying to understand what exactly I'm looking at
08:25 marcelr in context of the db upgrade twice stuff
08:25 marcelr looks like you should not run that twice ashimema
08:24 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 new feature, P5 - low, ---, martin.renvoize, RESOLVED FIXED, Add ability to create bundles of items for circulation
08:24 ashimema bug 28854
08:24 marcelr broken--
08:23 marcelr hmm
08:11 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 critical, P5 - low, ---, koha-bugs, NEW , Receive impossible if items created 'in cataloguing'
08:11 cait bug 34880
07:56 cait on the sandbox it's definitely broken, now to test in my local env
07:56 cait hm it could be a real bad bug :(
07:53 marcelr cait++
07:53 cait working towards QA but got some reported possible acq bugs to test first - also kind of QA
07:52 marcelr hi cait
07:52 cait :)
07:51 aw-bib[m] good morning :)
07:51 cait morning all
07:08 huginn marcelr: The operation succeeded.
07:08 marcelr @later tell ashimema please check bug 28854
06:50 huginn Joubu: The operation succeeded.
06:50 Joubu @later tell fridolin Can you have a look ASAP at 34845 please?
06:35 reiveune hello
06:13 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 enhancement, P5 - low, ---, martin.renvoize, Passed QA , Add customizable areas to intranet home pages
06:13 marcelr bug 6419
06:13 marcelr o/
06:09 Joubu kivilahtio: yarn install && yarn js:build (or yarn js:watch)
00:52 Fiza Yet when i try to search another barcode (00000102214) that attached to the record, the result promtp the same as i search using the title. May I know from where do i troubleshoot this issue. Please assist
00:52 Fiza you can see from the link below : https://hikmahlib.iium.edu.my/cgi-bin/koha/opac-detail.pl?biblionumber=519783
00:52 Fiza Hello its me Fiza. i want to enquire, i have added 1 catalog record into KOHA by using cataloging module. I also added dummy item into the records, i try to search in OPAC by using the title the error promt like this :No results found! You did not specify any search criteria. Error: Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 763. Then, i try to search a dummy barcode (78954621) that i created and the result was foun
00:16 kivilahtio The official Vue.js create-vue script uses Vite to run the app in dev-mode. But I am having trouble running the ERM-code standalone, because of various typescript problems. Implementing a plugin, and porting the ERM-Vue-code as a baseline, but need to turn it into Typescript first.
00:14 kivilahtio Also how is it supposed to be ran? package.json doesnt define a "dev" script or something similar. Still vite is included in the package.json dependencies.
00:14 kivilahtio Joubu: PedroAmorim[m]: Was there some reason why typescript was not fully embraced with Vue 3 ? First-class Typescript integration with Vue imho was kinda the whole point of Vue 3, atleast I waited for it for soo long. The ERM implementation has many .js files in the source.