Time Nick Message 06:01 marcelr hi #koha 06:30 reiveune hello 06:31 NikolayGospodinov[m] Hello 06:31 NikolayGospodinov[m] may i ask a question 06:32 NikolayGospodinov[m] I am working with a legacy Koha and have no connection to the previous system administrator. The problem is that my user doesn't have all the rights and the Set Permissions option is locked. How can I deal with this problem? 06:45 marcelr NikolayGospodinov[m]: change your borrowers.flags to 1 then you are system librarian 06:45 wahanui marcelr: that doesn't look right 06:46 marcelr wahanui 06:46 wahanui yes, marcelr? 06:51 alex_ Bonjour 06:51 wahanui what's up, alex_ 07:07 dcook [off] All right. I'm outta here. See you in a week folks. 07:14 magnuse [off] have fun dcook! 07:21 * cait waves 07:21 cait good morning all 07:32 ashimema morning cait 07:34 cait morning 07:34 cait hm no frido 07:44 marcelr hi cait alex_ magnuse 07:44 marcelr and ashimema 07:44 wahanui ashimema is probably back on security bugs today.. sorry, it's been a bit of a crazy week 07:44 cait hi marcelr 07:44 cait it's true 07:44 cait today is CSRF day 07:44 cait ashimema: ? heh 07:44 magnuse hiya marcelr et al 07:44 marcelr oh i just did some major bugs :) 07:46 cait i jumped right into the acq one 07:46 cait but filing 2 new ones I found while testing :( 07:47 marcelr that pattern I know 07:48 marcelr i am not sure how we could do csrf together now with one bug 07:48 marcelr which needs rebasing etc 07:49 cait I am nto sure what tcohen had in mind there - but it sounded like some kind of framwork bug that needed feedback probably? 07:55 marcelr looks like another postpone :) 07:57 ashimema Just on school run 07:57 ashimema Back shortly and will explain 07:59 ashimema I'll rebase once home, there a script in it for identifying possible issues. We need to work through them all 07:59 ashimema I'm royally fed up of this bug.. 08:02 cait today is the chance :) 08:02 cait I probably can't help much witht he main one, but when you need me for the smaller ones let me know, I'll be around for QA today 08:17 ashimema hmm 08:18 ashimema the issue is.. it's a huge job.. I need more than just me coding on it 08:18 ashimema if we're going to refuse to push it unless it's 100% coverage then we still have 80% of the work to do 08:20 cait maybe talking it through with marcelr would help? (just think I won't understand much) 08:23 marcelr ashimema: we probably split stuff into patches of a decent size ? 08:24 ashimema I tried that 08:24 ashimema and will try again 08:24 ashimema just opening up the bugs now to remind myself where it's got 08:25 ashimema even split.. there's been a refusal to push any of it without all of it. 08:25 ashimema that's the core issue 08:25 * ashimema is tired 08:26 marcelr hmm i opt for breaking it up and just push incremental 08:26 marcelr better than noting 08:26 marcelr nothing 08:26 marcelr if we would have done so, it would have been ready? 08:27 ashimema bug 30524 discussion is a good starting place 08:27 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30524 is not accessible. 08:34 marcelr ok ashimema it applies, will have a look now 08:34 marcelr lets get that further 08:35 marcelr april 2022 08:35 marcelr and june 2021 08:35 ashimema ho, it still applies 08:35 marcelr yes 08:35 marcelr good work 08:35 ashimema I just went to rebase my local branches and it had conflicts.. haha 08:36 ashimema excellent, David has maintained it ๐ 08:38 marcelr only 397 missing templates 08:38 marcelr we're almost there 08:39 marcelr there is no module test? 08:39 marcelr for Auth or Output ? 08:40 ashimema darn.. you're right 08:40 ashimema I could have swarn I'd written those.. maybe that got lost in the split 08:40 ashimema either way.. your right.. then need writing 08:43 marcelr is there a small follow-up patch for testing this on a staff page 08:43 marcelr > 08:43 marcelr ? 08:43 marcelr i understand we need to probably add output_exit calls ? 08:45 marcelr i am only seeing NEW reports nothing more? 08:46 ashimema 30502 is the one with most of the existing fixes to date 08:46 ashimema it's a bit of a mess โน๏ธ 08:48 ashimema sorry.. I meant but 22990 08:49 marcelr let me try that one 08:49 marcelr are you writing a test now ? 08:50 ashimema I was just going to check if 22990 actually applies 08:50 ashimema and of course.. it doesn't 08:51 marcelr no but let me rebase the first patch or try 08:52 ashimema sure.. I'll get to writing a test then ๐ 08:52 ashimema thanks 09:28 marcelr ashimema: i am going to squash a bit to get more organized on 22990 09:28 ashimema sounds like a plan 09:39 marcelr ok ashimema 22990 is ready 09:39 ashimema nice one 09:40 marcelr whats next 09:40 wahanui i guess next is Koha bibliography in Zotero 09:40 ashimema still working on the tests here 09:40 ashimema output_and_exit_if_error has no tests at all right now ! ๐ 09:40 marcelr so nice :) 09:40 marcelr dont make it to hard now 09:40 marcelr too 09:40 ashimema it's not too bad 09:41 ashimema just rminding myself how it works.. it's been a while 09:41 marcelr there is no other reports with csrf patches yet ? 09:41 marcelr only new entries 09:42 ashimema I think that's the case 09:43 ashimema I have a nagging feeling the script to help identify the issues isn't perfect.. not sure why I have that feeling 09:43 ashimema might be worth a little look to see if you agree with the logic in it 09:44 marcelr ok 09:44 ashimema cheers 09:47 PedroAmorim[m] marcelr: I can give bug 33404 a look if no one else is already looking at it 09:47 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 major, P5 - low, ---, m.de.rooy, Signed Off , Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted 09:47 marcelr that would be very nice PedroAmorim[m] 09:56 * cait waves - sorry got pulled away, but iwll be back after a quick lunch break now 09:57 marcelr ashimema: algorithm looks reasonable; add small followup 09:58 marcelr ashimema: should we add a omnibus for those patches since 22990 was meant for that but includes patches itself ? 10:02 ashimema seems sensible to me 10:03 ashimema this test is proving 'fun' to write 10:03 marcelr ok bug 34410 is the new omnibus 10:03 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34410 could not be retrieved: InvalidBugId 10:03 ashimema I misread the code a bit to start with.. seems I need to mock a Template 10:03 marcelr yeah i would expect some advanced mocking with Auth and Output 10:04 marcelr but you can do it :) 10:10 marcelr htg, see your test later ashimema; feel free to change status to PQA on 30524 10:11 ashimema ๐ 10:34 ashimema ok.. trapping exit's is 'hard' to do manually 10:34 ashimema this test may actually require a new test module too 10:34 ashimema Test::Trap 10:41 PedroAmorim[m] marcelr: around? 11:01 cait marcelr++ # just catching up on your morning's work 11:02 ashimema unit test uploaded 11:02 ashimema I'm sure we could cover more.. but it's a basic start 11:37 oleonard o/ 11:40 cait hi oleonard 11:40 wahanui hi oleopard 12:00 tcohen hola #koha o/ 12:01 tcohen CSRF day ~o~ 12:02 oleonard Oh no I forgot to wear my CSRF hat to work 12:02 tcohen bad oleonard 12:03 * tcohen says while putting his styrofoam crown in his head 12:05 oleonard :D 12:06 tcohen [off] where are we at with the patches? 12:06 tcohen cait: did fridolin mention anything about the multi-receive patches and the 23.05 point release? 12:14 cait he was not around earlier when I looked for him 12:14 cait but I alerted him, maybe he'll realease to night and grab them if you push 12:14 tcohen so I'll push then 12:15 tcohen ashimema, marcelr about the CSRF base bug, are you working on having it PQA? I noticed it got FQA 12:15 * ashimema is failing to write tests 12:15 ashimema well.. i wrote tests.. but the introduced a new test dependancy 12:15 ashimema marcelr came up with an idea on using a mock instrad 12:15 tcohen marcelr: can you help? 12:15 ashimema but my attempts thus far have failed 12:16 tcohen I can bring alfajores to Helsinki if it helps 12:18 ashimema I'm in the middle of an audit here.. and we need to role the release 12:18 tcohen khall, marcelr: about 33847 aren't we supposed to not rely on Koha::* on dbrevs, as they can change in the future and break older dbrevs? 12:18 ashimema so I'm struggling for time again โน๏ธ 12:18 tcohen ashimema: you're gonna do good 12:19 ashimema the audit is going fine so far.. not long until the results 12:19 ashimema I'm just struggling to balance stuff at the minute.. as usual 12:19 ashimema need to step back away from csrf.. we need more team still.. marcelr has been great.. but there's still lots to be done. 12:24 tcohen +1 13:00 PedroAmorim[m] cait++ 13:00 PedroAmorim[m] thanks for amazing input on bug 30719 I'll follow-up with it in the next couple days I hope 13:00 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 enhancement, P5 - low, ---, pedro.amorim, Failed QA , ILL should provide the ability to create batch requests 13:02 cait I didn't dare too test much more because of failing tests etc. will start witht he GUI side with the follow-ups 13:08 tcohen oleonard: around? 13:08 oleonard yep 13:09 tcohen what is the fa-edit replacement in v6? 13:09 tcohen if any 13:10 ashimema yikes: https://fontawesome.com/search?q=edit&o=r 13:11 ashimema pen maybe? 13:12 tcohen I'm looking at a pre v6 bug 13:12 ashimema fa fa-pencil is being used for some other Edit buttons 13:12 tcohen that introduces fa fa-edit 13:12 tcohen and trying to help them 13:12 oleonard In the upgrade patch we switched to fa-pencil-alt, but it looks like the 'alt' might be unnecessary 13:13 tcohen ashimema++ 13:13 tcohen oleonard++ 13:14 oleonard Looks like fa-pencil-alt may have been a 5.x name only 13:14 * ashimema wonders waht the 'alt' is? 13:14 ashimema hehe 13:14 ashimema makes sense 13:14 tcohen I would expect "fa-alt fa-pencil" with the new style 13:15 tcohen git grep 'fa\-pencil' 13:15 tcohen suspiciously doesn't return anything but the fontawesome css 13:15 tcohen ah no 13:15 tcohen nevermind 13:15 tcohen thanks! 13:19 tcohen https://fontawesome.com/v5/icons/edit?f=classic&s=solid 13:19 tcohen when you click on 'latest' it takes you to 13:19 tcohen https://fontawesome.com/icons/edit?f=classic&s=solid 13:20 oleonard I think .fa-solid.fa-pencil is correct, and I'm preparing a patch 13:21 tcohen aweosme 13:21 tcohen there are still a bunch of "fa fa-edit" in the intranet 13:21 tcohen will you take care of those? 13:22 oleonard Yes 13:22 tcohen oleonard++ 13:22 tcohen cc me please 13:22 ashimema is our git down 13:23 tcohen I pushed a couple times 13:23 tcohen maybe it is overloaded by jenkins 13:23 tcohen worked for me 13:24 ashimema oh.. back up now 13:24 ashimema weird 13:27 ashimema it's just very very slow 13:28 tcohen ashimema: .... 13:28 tcohen some old decisions will hit us back 13:29 ashimema ? 13:29 tcohen git grep ui_method_icon 13:29 ashimema wow 13:29 ashimema I don't remember that stuff at all 13:29 ashimema yikes 13:29 tcohen the ILL status graph 13:30 tcohen includes a way to specify the icon to be used 13:30 ashimema indeed 13:30 ashimema oop.. meeting time 13:30 ashimema brb 13:30 tcohen and we assume the initial 'fa ' will always be fa 13:36 PedroAmorim[m] https://git.koha-community.org/Koha-community/Koha 13:36 PedroAmorim[m] this is not opening for me, anyone else? 13:37 tcohen I iwll check the server 13:37 tcohen it has a load of 13 13:38 tcohen :-D 13:38 ashimema interesting 13:38 tcohen something is hitting the web interface 13:38 ashimema doesn't load for me either 13:39 oleonard Maybe Facebook is trying to assimilate us into the Metaverseยฎ 13:39 ashimema lol 13:39 caroline_crazycatlady lol! 13:41 tcohen will do an upgrade of the docker tools 13:41 tcohen and reboot 13:42 ashimema thanks tcohen 13:44 tcohen back up 13:44 PedroAmorim[m] ๐ 13:44 PedroAmorim[m] tyvm 13:45 ashimema nice one 13:54 cait2 back 13:59 ashimema anyone here played with 'Plane' 14:00 ashimema the OSS Jira alternative? 14:01 cait first time I hear about it :( 14:01 cait but sounds interesting in general 14:01 ashimema it's very new as far as I can tell 14:01 ashimema I'm wondering if it might fit community well.. 14:02 cait if it#s very new we might want to let it settle a bit :) 14:02 cait but something to watch maybe? 14:20 ashimema indeed 14:46 oleonard ashimema: Did you ever experiment with Select2 for patron search autocomplete? 14:46 ashimema well 14:47 ashimema I didn't move any further yet 14:47 cait oleonard: there is something partial in our ILL backend maybe 14:47 ashimema but I do have a select2 one in the bookings submission 14:47 cait hm but it might be too specific to our use case, so not as helpful (thinking about it) 14:47 ashimema not added the further adaptations yet 14:47 oleonard it would be so nice to use an asset we already have 14:48 ashimema just discovered more and more issues with our other patron searches though ๐ 14:48 oleonard Luckily I only care how it looks ;) 14:48 ashimema yeah 14:48 ashimema it would be nice 14:48 ashimema maybe I can swing back around to it again next week 14:51 cait what's the state of the C... bugs now? 14:51 ashimema ? 14:52 caroline C... sounds like you're swearing XD 14:52 oleonard ashimema: Remember, our plan to rewrite Koha in C? 14:52 ashimema lol 14:52 cait I just never get the sequence right 14:52 cait CSRF? 14:52 ashimema lol 14:53 ashimema I moved on to release 14:55 cait oleonard: shoudl we add the remove of jquery ui to the roadmap? 14:56 oleonard It wouldn't hurt, though it's been a long road already XD 15:06 cait oleonard: I've added it https://wiki.koha-community.org/wiki/Roadmap_for_23.11 15:07 oleonard Thanks cait! 15:08 cait kidclamp: kidclamp kidclamp 15:10 oleonard :D 15:10 reiveune bye 15:10 cait felt worth trying :) 15:16 cait oleonard: found 2 small issues witht he tabs for frameworks - filed 34115 15:20 ashimema cait 15:20 ashimema do you have the power to add users to the website? 15:20 ashimema Pedro has been rolling his release and is at the stage of adding the post to the website in a minute 15:21 ashimema I may just save the announcement for Monday.. running out of work day here 15:21 cait I believe i might not - but I can check 15:21 ashimema I'll ask Liz Monday 15:22 cait i think i can 15:22 cait let me see 15:22 cait PM? 15:28 PedroAmorim[m] cait++ 15:28 cait yay karma! 15:28 cait @karma 15:28 huginn cait: Highest karma: "Joubu" (1206), "cait" (1015), and "ashimema" (832). Lowest karma: "-" (-84), "failed" (-53), and "ie" (-41). You (cait) are ranked 2 out of 1248. 15:28 cait PedroAmorim++ 15:47 oleonard cait: I had no idea you could search a framework with a subfield and get straight to the subfield edit form! 15:49 cait I QA'd it when Joubu added it I think 15:49 cait it is very helpful 15:49 cait maybe we should add a hint :) 15:50 lukeg Hi 15:50 cait hi lukeg :) 16:26 cait have a nice weekend #koha!