Time  Nick                  Message
00:45 davidnind             kidclamp: I tested bug 33887 but have Failed QA (there is an error in the database update)
00:45 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887 enhancement, P5 - low, ---, samalau, Failed QA , Automatic checkin should be able to optionally fill the next hold with the returned item
05:22 paxed                 i wonder if there'll be a slot for koha lightning talks at perlkohacon
05:24 paxed                 nugged: ^?
06:03 marcelr               o/
06:06 dcook                 Patch incoming for bug 34028..
06:06 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 major, P5 - low, ---, koha-bugs, NEW , Two factor authentication (2FA) shows the wrong values for manual entry
06:06 dcook                 Maybe it's not major. It's just very wrong...
06:12 marcelr               hi dcook
06:12 wahanui               hi dcook are you around?
06:12 dcook                 heya marcelr
06:12 marcelr               2fa patches are welcome
06:12 dcook                 :D
06:13 dcook                 Just attached one for that one
06:13 marcelr               will *try* to have a look
06:13 dcook                 Planning to implement the 2fa more widely so will be a bit more of my focus coming up I think
06:13 dcook                 <3
06:13 dcook                 It's a very simple change
06:13 dcook                 Just display really
06:13 marcelr               i am thinking about using it too in 22.11
06:14 dcook                 We've had a few libraries start using it in 22.11 and so far so good
06:14 marcelr               great
06:14 dcook                 The most annoying part has been the missing encryption key in koha-conf.xml but I'll be working more on that later..
06:15 dcook                 [off] just about to play with a tool called "oathtool" as well for CLI based TOTPs..
06:16 marcelr               did you ever hear about mysql/mariadb locking itself in the same transaction ?
06:17 dcook                 Doesn't sound too familiar
06:17 marcelr               bug 33972
06:17 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33972 blocker, P5 - low, ---, nick, Needs Signoff , Possible deadlock in C4::ImportBatch::SetimportBatchStatus from BatchCommitRecords
06:18 marcelr               two calls to change status in import table
06:18 marcelr               very weird
06:18 marcelr               occurs sometimes and for specific versions i guess
06:21 dcook                 Let's see..
06:22 dcook                 Reading through the comments and I was just thinking the same thing as you: "are you sure that there was no second process involved"
06:23 dcook                 Gotta hate those issues that are difficult to reproduce
06:23 marcelr               right
06:23 dcook                 I've only had deadlocks happen when two separate processes are trying to competing for the lock
06:23 marcelr               that would be normal but could be a maria bug or so?
06:24 dcook                 You never know..
06:24 marcelr               he is convinced that it is no second process
06:25 dcook                 I think we need more information
06:27 marcelr               yeah
06:28 dcook                 I'm more familiar troubleshooting locks with Postgres but it would be good to get some more data..
06:30 dcook                 "Enabling the InnoDB Lock Monitor"
06:30 dcook                 https://dev.mysql.com/doc/refman/5.7/en/innodb-enabling-monitors.html
06:30 dcook                 That sounds useful
06:30 Joubu                 marcelr: there is also bug 33987
06:30 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33987 normal, P5 - low, ---, kyle, Signed Off , Combine multiple db updates in C4::ImportBatch::BatchCommitRecords for efficiency/avoiding possible deadlocks
06:30 Joubu                 one from Nick, one from Kyle
06:30 marcelr               yes i saw it
06:30 Joubu                 I think they came up with a different fix for the same problem
06:30 marcelr               or similar problem
06:30 Joubu                 yes
06:31 marcelr               i would like to know the exact sql version here; is it a sql bug
06:31 dcook                 Who employs Sam Lau again? Is it Bywater?
06:31 Joubu                 both seem correct, but hard to tell which one really fixes the problem
06:31 dcook                 Kyle's sounds a bit more interesting
06:31 dcook                 Three different queries..
06:31 marcelr               yeah 33987 looks better
06:32 Joubu                 yes but then we should apply it to the other occurrences...
06:32 dcook                 If one process used different database connections maybe it could deadlock itself..
06:33 dcook                 Although I would think they'd all re-use the same connection..
06:33 marcelr               yes but is it another connection? or same connection, new handle, or ?
06:33 dcook                 Haven't looked (yet)
06:33 marcelr               they're calling Context->dbh again
06:33 marcelr               to change status
06:33 marcelr               but i would expect the same connection
06:34 marcelr               depends on the caching in Koha::Database
06:34 dcook                 In theory it should be the same connection yeah
06:34 marcelr               and we would be better if we do this via txn_do (as recommended)
06:35 dcook                 Might be trying to do too many things in 1 transaction as well
06:35 dcook                 That's something I've encountered a lot on a different project with lots of legacy code
06:35 marcelr               but this code allows for commits in the meantime but this is disabled with a flag
06:35 dcook                 hard to keep track of things when you have a million function calls ostensibly in the same transaction..
06:36 dcook                 But I need to squeeze in a wee bit more of work in the next few minutes
06:36 dcook                 My Friday ends in 24 minutes O_O
06:36 marcelr               ok thx
06:37 dcook                 Have quite a few holidays over the next month or so, so I probably won't be around heaps :S
06:37 dcook                 And it's winter here. What am I thinking..
06:37 marcelr               ok
06:37 marcelr               just come back :)
06:38 dcook                 Aww thanks
06:44 Joubu                 marcelr: would like to have a look at approve this merge request? https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/53
06:45 Joubu                 and*
06:48 Joubu                 marcelr: about the deadlock, I guess they are forking in the worker (the --max-processes parameter)
06:49 marcelr               ok still looking at both reports
06:53 marcelr               Joubu: just glanced thru the perltidy patches, push it, we will find the errors anyway and they dont hurt
06:54 marcelr               and you tested :)
07:01 magnuse               \o/
07:01 marcelr               hi magnuse
07:01 Joubu                 click the approve button then :D
07:01 magnuse               hi marcelr
07:02 marcelr               go ahead Joubu and click it
07:02 Joubu                 we killed C4::BackgroundJob \o/
07:02 marcelr               good
07:02 Joubu                 marcelr: I wrote the merge request, somebody else should approve
07:02 marcelr               Joubu: just give me time to switch to if ( instead of if( :)
07:03 marcelr               i'm not sure if we had *no* rules
07:05 Joubu                 marcelr: the rule was "default perltidyrc"
07:06 marcelr               well i better dont discuss it, but just get used to the new thing ;)
07:07 Joubu                 https://wiki.koha-community.org/w/index.php?title=Perltidy&type=revision&diff=32164&oldid=32163
07:07 Joubu                 "The offical perltidy style for perl code in Koha is the perltidy 'default' or  'larry-wall' style. There was a customised perltidy style in Koha for a while, but it was never official or enforced and later removed."
07:07 marcelr               lesson learned: new coding guidelines can be implemented best during a warm summer :)
07:07 Joubu                 that what was on the wiki, but never enforced as a rule
07:08 marcelr               somehow i feel that 'we' agreed on if(
07:09 Joubu                 tcohen: git-bz switch to python 3 merged? Why that? Did you test it? The bug I raised 6 months ago is still not fixed..
07:14 cait                  good morning #koha
07:15 Joubu                 'if ( ' # git grep -P 'if \(\s' **/*.pm **/*.pl | wc -l # 6763
07:15 Joubu                 'if ('  # git grep -P 'if \(\S' **/*.pm **/*.pl | wc -l # 5001
07:15 Joubu                 'if( '  # git grep -P 'if\(\s' **/*.pm **/*.pl | wc -l  # 1194
07:15 Joubu                 'if('   # git grep -P 'if\(\S' **/*.pm **/*.pl | wc -l  # 422
07:16 marcelr               hi cait
07:16 marcelr               Joubu get to work
07:16 marcelr               haha
07:17 marcelr               those 1500 are mine'
07:51 cait                  you are already confusing me
07:52 marcelr               cait you should click the Approve button for Joubu in order to have a tidy qa tools
07:58 Joubu                 marcelr: please put bug 17427 back onto your todo list (or move it up :D)
07:58 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 normal, P5 - low, ---, koha-bugs, NEW , Replace CGI::Session with Data::Session
07:59 marcelr               yeah
08:07 Joubu                 added my stuffs to https://wiki.koha-community.org/wiki/Roadmap_for_23.11#Refactorings
08:07 cait                  so... are we working on bad bugs today... or are we working on bad bugs?
08:07 cait                  it's QA Friday!
08:07 marcelr               Joubu i am signing off on 33972 with a  follow-up; still a workaround for me, could you have a look ?
08:08 marcelr               cait 33972 is a bad byg
08:08 marcelr               bug
08:08 cait                  bug 33972
08:08 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33972 blocker, P5 - low, ---, nick, Signed Off , Possible deadlock in C4::ImportBatch::SetimportBatchStatus from BatchCommitRecords
08:08 marcelr               ah roadmap, i was still waiting for tcohen
08:09 cait                  yes, I could do some regression testing there, I have some nicer data sets to test with
08:09 marcelr               go ahead
08:09 cait                  marcelr: not annouced yet I think officially - so you didn't miss it
08:09 cait                  I was jsut not sure where your discussion ended up earlier
08:09 cait                  waht I can tell is that we had a workshop with 22.11.05 and the imports didn't work :(
08:10 cait                  that's was not the best workshop experience and also left me worried, so have a keen interest here
08:10 marcelr               well all testing helps us further
08:10 Joubu                 shouldn't we replace txn_begin txn_end with txn_do?
08:10 Joubu                 _end/_commit
08:10 marcelr               that would be good but note that we have some inline commits there too (enabled disabled with a flag)
08:10 cait                  I'll update my env and come back
08:11 marcelr               those intermediate commits are used in other scripts
08:14 Joubu                 yep, I forgot the context , I was just reading the diff..
08:16 marcelr               it might be somehting with large imports, and too much new db handles or so ?
08:17 Joubu                 marcelr: the algorithm is bad. IMO we should : select from DB with the limit ('interval'), then loop over those inside a txn, then select the next ones, and so on
08:17 cait                  fwiw we saw issues with mulitple instances, but imports were rather small >1000 recors
08:17 cait                  I woudl run tests with the same dataset now
08:17 cait                  wiating for ktd pull
08:18 cait                  and I am not sure how the problems manifest, for us the jobs all remained in new
08:18 cait                  never getting started/finished
08:24 cait                  can i start testing bug 33972 or are you still working on it?
08:24 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33972 blocker, P5 - low, ---, nick, Signed Off , Possible deadlock in C4::ImportBatch::SetimportBatchStatus from BatchCommitRecords
08:24 marcelr               no please do
08:25 marcelr               Joubu: problem is a failure after you would have committed a few times
08:27 cait                  something specific I should try?
08:29 marcelr               larger data sets and perhaps enable the forking stuff
08:29 Joubu                 I am not on it, and certainly won't tody
08:29 Joubu                 today
08:30 marcelr               well i dont think the small change on 33972 would hurt anyway
08:30 marcelr               but we need a larger solution
08:30 cait                  i am not sure what the forking stuff is, but testing without the patch already encountered some oddness
08:30 marcelr               and know exactly why things fail
08:30 marcelr               hey whats that
08:31 marcelr               the max-processes option is the forking stuff
08:31 marcelr               it controls if background worker forks
08:31 cait                  https://snipboard.io/herE7k.jpg
08:32 marcelr               and with the patch?
08:32 cait                  that's the next thing I'll do
08:32 marcelr               could you check your logs too ?
08:32 cait                  sure
08:32 marcelr               whats the error ? and the line ?
08:33 cait                  no error in the gui, I'll go digging
08:33 marcelr               plack-error probably
08:33 marcelr               no
08:33 marcelr               no plack
08:33 marcelr               worker-error
08:33 marcelr               or worker-output
08:33 Joubu                 `tail -f /var/log/koha/kohadev/*` :)
08:34 cait                  yes already there
08:35 cait                  https://paste.koha-community.org/18223
08:36 marcelr               no timestamps..
08:36 marcelr               the last two lines are odd
08:36 marcelr               data problems?
08:36 cait                  not sure, they loaded fine on our 20.11.05
08:36 cait                  but... I can redo that there right now
08:37 marcelr               try 33987 and 33792 on top at the same time
08:37 cait                  not so many things at once please :)
08:37 marcelr               see if it makes a difference
08:38 marcelr               yes it is warm
08:38 cait                  I am testing in 22.11.05 with the data now, then back to master with the patches
08:38 marcelr               great
08:39 cait                  ok, the data set imports without problems in 22.11.05
08:39 cait                  I can give you access to it if you want
08:39 cait                  now setting upt he branch with the patches
08:41 cait                  hm I can't put 33792 on top
08:41 cait                  wrong bug number marcel :)
08:41 cait                  33972
08:44 marcelr               every time i mix those
08:44 marcelr               bug 33972
08:44 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33972 blocker, P5 - low, ---, nick, Signed Off , Possible deadlock in C4::ImportBatch::SetimportBatchStatus from BatchCommitRecords
08:44 marcelr               bug 33792
08:44 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 normal, P5 - low, ---, m.de.rooy, Pushed to stable , reserves_stats.pl ignores filled holds without itemnumber
08:45 marcelr               yeah it is one of mine too :)
08:58 cait                  got distracted by a coworker putting cake in the kitchen, testing continues now
08:58 marcelr               cake is a nice distraction
08:59 marcelr               i am testing updates to batch_commits in a test script looping 100.000 times, so far so good
08:59 cait                  it was very good cake too
08:59 marcelr               hmm
08:59 cait                  i have another failed... so waht could it be..
09:00 cait                  oh, no restart_all... I'll repeat
09:00 cait                  the weird thing is: the job is failed, but hte data has been imported
09:01 cait                  https://snipboard.io/VOJwZD.jpg
09:01 cait                  now all my jobs are fialed, even the ones that said finished earlier...
09:01 cait                  help?
09:01 wahanui               i heard help was appreciated for bugs and keeping jenkins happy
09:02 marcelr               quite interesting.. nothing in the logs still ?
09:02 cait                  looks like the same as before
09:03 cait                  pondering a reset_all and starting over
09:03 marcelr               you restarted and you have both those patches ?
09:03 cait                  that's from before restarting...
09:03 cait                  I think I'll go back to clean state and start over
09:03 cait                  but it's way too easy to break stuff, something is going on
09:03 marcelr               right
09:07 marcelr               check the import_status of the batch please too; does it get to imported or is it still staged?
09:07 cait                  will do
09:08 cait                  the smaller data set had no issues, staged and imported, both jobs set to finished, status is imported
09:08 cait                  now trying the other set
09:08 marcelr               and what import are you exactly doing: biblios and create/replace/.. ?
09:08 cait                  i am doing a records with items
09:08 cait                  no matching rule
09:08 cait                  so simple
09:08 marcelr               yes it might make a difference, other if then else branches in the loop
09:11 cait                  the second set shows the same problem again, but it worked nicely in our 22.11.05 - so not sure what's going on there
09:12 cait                  and: the job failed, but the batch is "imported"
09:56 marcelr               bye #koha
09:57 cait                  hm no kidclamp
09:59 cait                  does longtext sound ok to you all? willing to patch...
09:59 cait                  https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029
09:59 huginn                04Bug 34029: normal, P5 - low, ---, koha-bugs, NEW , Import breaks on too long publishercode
10:42 oleonard              o/
10:58 cait                  ... I'll take the quiet as agreement
10:58 cait                  hi oleonard :)
11:01 TriveniChandriki[m]   Auto barcode not working in placing order in acquisition multiple items
11:03 TriveniChandriki[m]   Any setup i have to do.
11:13 cait                  which Autobarcode setting do you use and which version?
11:14 cait                  (of Koha)
11:18 kidclamp              marcelr++
11:25 cait                  hi kidclamp
11:25 cait                  we could not really reproduce the issue... but I found new issues :(
11:25 cait                  oh and git bz is broken on latest ktd
11:25 kidclamp              Oh, what did you find?
11:25 cait                  give me a moment to sort
11:26 cait                  https://paste.koha-community.org/18241 < broken git bz apply on latest ktd
11:26 cait                  is that the pyhton3 change?
11:28 cait                  i'd really like to upload my patch :(
11:29 cait                  kidclamp: Bug 34029        - Import breaks when data exceeds size of mapped database columns
11:30 cait                  so I have 2 data sets, one imports nicely (600 records) always, the other never imports nicely, with or without the patches (1600 records)
11:30 tcohen                Joubu: I thought it was not that bad and better merging that lagging forever
11:30 cait                  I end up with import status "imported" and a job that is failed
11:30 cait                  kidclamp: i can give you the data sets if you want?
11:30 cait                  but I never could reproduce the deadlock
11:30 kidclamp              sure
11:31 kidclamp              those data sets would be nice just for testing generaly
11:31 cait                  tcohen: how can I fix my git bz? it looks like it#s only the files in ktd, not the repo
11:31 kidclamp              we saw the deadlock occur in a patron import too - we are looking a bit deeper
11:32 kidclamp              but the patches all seem to help, so it is something weird about hitting same row
11:32 kidclamp              our imports are all one big transaction, which is not ideal likely
11:38 Joubu                 tcohen: it is buggy..
11:38 tcohen                I've been using it with no issues for a hwile
11:38 tcohen                on macos and linux
11:39 tcohen                how can I repproduce the error?
11:39 tcohen                maybe we should just fix it
11:39 Joubu                 I didn't manage to fix it
11:39 Joubu                 see above from cait, + mine on the merge request I let the command to recreate
11:39 cait                  are we talking git bz now?
11:40 cait                  i just did a git bz attach -e bugnumber HEAD
11:40 cait                  it doesn't work without -e
11:40 cait                  either
11:40 cait                  new ktd, ktd pull and everything fromt his morning
11:41 cait                  tcohen: are you using it within ktd?
11:41 tcohen                I never used it on ktd before
11:41 pastebot              "tcohen" at 127.0.0.1 pasted "kohadev-koha@kohadevbox:koha(b" (18 lines) at https://paste.koha-community.org/18244
11:41 tcohen                but it works?
11:42 tcohen                I'll re-read your comments
11:43 cait                  it doesn't work in ktd
11:43 tcohen                I'm in KTD
11:44 tcohen                kohadev-koha user?
11:44 Joubu                 34029 vs 32029
11:44 Joubu                 there is a typo
11:44 Joubu                 it's the problem I raised in my comment 6 months ago
11:44 tcohen                so, if there's a typo it fails
11:44 cait                  just in ktd --shell yes
11:44 Joubu                 if you typo the bug number you get the bytes vs str python error
11:44 cait                  Joubu: I'll double check that
11:45 tcohen                it didn't sound like a blocker for me
11:45 tcohen                but I get it
11:45 tcohen                don't typo
11:45 tcohen                haha
11:45 Joubu                 uncaught exceptions are (almost) always bad ;)
11:46 cait                  you were right, thank you :)
11:46 tcohen                I'll try to make it say 'You have a typo'
11:49 cait                  Joubu++ tcohen++
11:50 cait                  so what is a good next step for the import patches? I didn't find a regression, so could sign them... but i also couldn't see the error
12:00 cait                  hm I only tested on master so far, I'll now try to test on 22.11.x branch
12:08 TriveniChandriki[m]   <cait> "which Autobarcode setting do you..." <- 21.05
12:09 cait                  21.05 is the koha version, not the barcode setting
12:09 cait                  Autobarcode is a system preference
12:09 cait                  but 21.05 is quite old, if it doesn't work, it's more likly a bug than a configuration issue and youshoudl consider updating
12:10 cait                  re import: no issues found with 22.11.x :(
12:10 TriveniChandriki[m]   cait: I will try this version
12:11 * TriveniChandriki[m] uploaded an image: (3833KiB) < https://matrix.org/_matrix/media/v3/download/matrix.org/YhpIozslYeypXtBUKpdfHqZQ/20230616_174132_1334231859104791493.jpg >
12:12 TriveniChandriki[m]   When placing an order. Giving barcodes one item it's coming. Multiple items not coming
12:26 cait                  tcohen: Joubu: bug number matches, what's wrong this time? https://paste.koha-community.org/18250
12:31 kidclamp              you did apply
12:31 kidclamp              you meant attach
12:31 kidclamp              cait ^
12:32 cait                  and... you are right. thank you
12:32 Joubu                 kidclamp: 34033 - did you notice that the last patch from 30649 is not pushed?
12:32 cait                  y
12:33 Joubu                 kidclamp: ok, forget that!
12:36 tcohen                we have a problem with exception handling in python
12:37 tcohen                heh
13:03 Joubu                 home icon top left is broken?
13:03 Joubu                 https://snipboard.io/fY7jlN.jpg
13:04 oleonard              And the stars for OPAC star ratings
13:05 oleonard              Actually now that I look again, the home icon isn't broken for me at the moment??
13:06 Joubu                 navigation first last <, > in DT not displayed
13:06 Joubu                 Agreement (ERM) lost the icon
13:07 Joubu                 https://snipboard.io/SfOamw.jpg
13:08 Joubu                 hum...
13:09 oleonard              Joubu I saw those issues yesterday but today it looks okay.
13:09 * Joubu               deep breathes
13:10 Joubu                 yes, all good!
13:10 Joubu                 only the agreement fa-check-circle-o is wrong
13:10 Joubu                 I guess it's the '-o'
13:14 * tcohen              breathes normally once he figures it was Joubu this time :P
13:16 Joubu                 tcohen: I've added a follow-up to the FA icon bug
13:16 tcohen                Joubu++
13:17 tcohen                Joubu, cait: doing QA on bug 33885 with the new git-bz...
13:17 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33885 critical, P5 - low, ---, jonathan.druart+koha, Signed Off , Get HTTP 500 when retrieving orders created by a non-existent (deleted) user
13:18 tcohen                if I don't pass a range to attach
13:18 tcohen                it explodes => bad
13:20 cait                  it explodes a lot heh
13:20 cait                  what was your command?
13:21 cait                  I am updating severity on bug 34006
13:21 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34006 major, P5 - low, ---, koha-bugs, NEW , Keep the current option for funds in receiving returns an error 500
13:21 cait                  it's bad
13:35 * ashimema            catches up
13:36 ashimema              so, you've merged the python3 branch
13:36 ashimema              I've been using that branch for months now without any real issues
13:36 ashimema              what's going on?
13:44 cait                  patch for 34006 :)
13:44 cait                  it changed a . to an _
13:53 pastebot              "tcohen" at 127.0.0.1 pasted "kohadev-koha@kohadevbox:koha(q" (39 lines) at https://paste.koha-community.org/18258
13:53 tcohen                I mean, that's noisy, but correct
14:03 Joubu                 oleonard: I am confused by bug 33983, what am I missing?
14:03 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33983 enhancement, P5 - low, ---, oleonard, Needs Signoff , Move translatable strings out of OPAC's datatables.inc into JavaScript
14:04 oleonard              Are you confused about the purpose of it Joubu?
14:05 Joubu                 oleonard: I let a comment
14:05 Joubu                 you are adding a TT include file that is using the I18N TT plugin, but you are using the i18n JS function __()
14:06 Joubu                 that is defined in i18n.js, and accessible from everywhere: doc-head-close.inc:[% Asset.js('js/i18n.js') | $raw %]
14:09 oleonard              I will rework it, thanks
14:16 * oleonard            had his head stuck in title i18n
14:18 caroline              should strings in html_helpers.inc be translated? Is it just something for devs or is it actually used in Koha?
14:18 cait                  pretty sure it's used in Koha, but .inc are translated
14:18 cait                  usually
14:19 Joubu                 yes, strings from html_helpers should be translatable
14:20 caroline              thanks! I wanted to make sure it didn't break anything... there have been cases where translated html would break the actual html
14:21 caroline              like in "[ END ] %%] [%% # [ WRAPPER tab_item tabname= "tab_name_2" ]" I should translate only "tab_name_2"? or nothing at all?
14:22 cait                  nothing at all
14:22 cait                  just copy it
14:22 cait                  [%% - it's a comment actually
14:22 oleonard              I thought i'd fixed those comments ending up in translation
14:23 cait                  I thought the same, but ran into 2 of those earlier as well
14:23 caroline              yes 2 appeared with the new strings I think
14:24 caroline              I had another one, but it didn't have ambiguous words (just WRAPPER and a bunch of %) so I simply copied that one
14:30 oleonard              caroline if you could file a bug I will try to fix
14:30 caroline              ok!
14:37 caroline              oleonard, not sure what info you needed, but if anything is missing, let me know bug 34039
14:37 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34039 enhancement, P5 - low, ---, koha-bugs, NEW , TT comments in translated strings
14:37 oleonard              Thanks caroline
15:07 oleonard              The translation script just *really* wants to translate anything inside HTML tags even if it's a Template::Toolkit comment :(
15:19 kikiko[m]             Hey everyone! Could someone give some insight as to what goes on here/frequently talked about topics and such? I'm trying to determine whether if this support group will be of enough help by itself for support in my system, or if i should venture out and explore other options. Thank you!
15:21 caroline              Hi kikiko[m], this channel is mostly used by Koha developers to discuss bugs and such
15:21 Joubu                 If you are search for koha related topics and questions, you are at the right place
15:21 Joubu                 *ing
15:22 caroline              sometimes random people will come and ask questions, and we do our best to help and answer, but it's not a guarantee you will get an answer
15:26 kikiko[m]             ahha i see! im trying to figure out and explore support options as my team doesn't have technical support and it sometimes gets hard to find resolutions for bugs and other queries. Do you know of any other places where i could get technical support for KOHA from?
15:26 caroline              probably the dev mailing list would be best for technical questions
15:27 caroline              https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
15:28 caroline              Sometimes people come here to ask their question and if they don't get an answer they write to the mailing list
15:28 caroline              it reaches more people, but it's not as instantaneous (is that a word?)
15:30 kikiko[m]             ooh i didnt know of that, KOHA's website is a little overwhelming i feel so its gets harder to find stuff, but ill def check this out!
15:30 kikiko[m]             haha yup instantaneous is a word! 😃
15:31 caroline              don't hesitate to come back here and lurk too, I find it's one of the best ways to learn, to just read what other people say
15:36 kikiko[m]             yup i agree with that!
15:40 tcohen                laters
17:15 cait                  Any help on bug 33028 much appreciated, I tried to push it further, but need help to the finish line
17:15 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 major, P5 - low, ---, thibaud.guillot, Failed QA , Wrongly formatted monetary amounts in circulation rules break scripts and calculations
18:09 oleonard_             Anyone else getting an error from item search?
18:09 oleonard_             Template process failed: undef error - The method Koha::Patron->can_edit_item is not covered by tests!
18:14 oleonard_             Hm... a little regression from the Font Awesome patch...
18:23 oleonard_             Bug 34042
18:23 huginn                04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 major, P5 - low, ---, oleonard, Needs Signoff , Item search broken by FontAwesome upgrade