Time  Nick               Message
04:23 RafaelFernandes[m] Hi
05:45 Joubu              https://www.youtube.com/watch?v=rY0WxgSXdEE
06:31 reiveune           hello
06:38 marcelr            hi #koha
06:38 marcelr            tcohen++ # release time
06:39 fridolin           tcohen++ what a joy to see v23.05.00 :D
08:06 cait               good morning #koha
08:07 marcelr            hi cait
08:13 cait               day after release... how does everyone feel?
08:17 * fridolin         warming up for RMaint
08:17 fridolin           i need to recreate a fresh KTD :)
08:17 fridolin           and check credencials
08:19 fridolin           Joubu: Bug 22802 comment 10, wrong bug maybe
08:19 huginn             04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 blocker, P5 - low, ---, nick, CLOSED FIXED, When ordering from a staged file, if funds are populated per item order level fund should not be required
08:32 Joubu              nope, correct bug
09:31 marcelr            Joubu: would you include the perltidy thing in qa tools ?
09:31 marcelr            somehow i dont like to fail qa just for spaces and so ?
09:40 Joubu              https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/50
09:41 Joubu              and https://gitlab.com/joubu/qa-test-tools/-/commits/check-tidiness
09:41 Joubu              and especifically "Check tidiness - consider failure as warning" I have implemented less than 20 min ago :D
09:41 Joubu              marcelr: we need to teach people to tidy their code
09:42 Joubu              it's fine for code submitted prior to a possible decision
09:42 jajm               Joubu: "The file must be as much tidy after (ARRAY(0x555d38534da8)) than before (ARRAY(0x555d339791a0))" :D
09:42 Joubu              but then we will opt for a perltidyrc config people will have to adjust their editor
09:42 Joubu              jajm: with or without "prevent the tests to explode".
09:42 Joubu              ?
09:43 jajm               Joubu: with
09:43 marcelr            will have a look, Joubu; thx
09:44 Joubu              erk I forgot to add a file to the commit!
09:44 Joubu              306     return $full_buf->[0];
09:44 Joubu              in QohA/File/Perl.pm
09:44 Joubu              adjusting the commit
09:44 marcelr            fix it !
09:45 Joubu              jajm: refetch!
09:45 marcelr            @later tell khall could you comment on bug 33878 ?
09:45 huginn             marcelr: The operation succeeded.
09:47 jajm               Joubu: no more warn message, i need to find another commit
09:48 jajm               Joubu: it's ok now, thanks
09:49 jajm               but i find the message confusing "The file must be as much tidy after (2) than before (1)"
09:49 Joubu              feel free to adjust
09:49 Joubu              it's a POC for now
09:49 Joubu              still more to do
09:50 Joubu              * replace xt/perltidyrc with .perltidyrc in the command
09:50 Joubu              * fix the qa-test-tools test (how do we locate the good .perltidyrc from Koha? Do we want that?)
09:50 Joubu              * empty lines are caught and warning is raised when it shouldn't
09:52 jajm               suggestion: "The file is less tidy than before (bad/messy lines before: 1, now: 2)"
09:54 Joubu              done, thanks
09:55 nugged             Joubu cait ashimema: what do you think about that - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371#c5
09:55 huginn             04Bug 33371: normal, P5 - low, ---, mtj, Pushed to master , Add 'koha-common.service' systemd service
09:55 nugged             it might affect the release
09:55 nugged             at least I patched my productions
09:57 Joubu              absolutely no idea!
10:00 cait               not quite my area of expertise either :(
10:01 mtj                hi folks
10:02 mtj                nugged: it seems like a good idea :)
10:04 mtj                let me test the reboot
10:51 nugged             mtj: 🙏
11:21 tcohen             hola #koha o/
11:23 tcohen             mtj: can you spin up a -1 package?
11:24 mtj                hi tcohen, yep, i just poking this systemd thing ^
11:24 tcohen             exqctly
11:29 marcelr            o/
11:45 tcohen             bbiab
12:14 marcelr            @later tell oleonard added followup on 33608
12:14 huginn             marcelr: The operation succeeded.
12:14 oleonard           👍🏻
12:19 Joubu              tcohen: see https://tree.taiga.io/project/koha-ils/task/117
12:23 Joubu              tcohen: installer/data/mysql/db_revs/221200026.pl
12:23 Joubu              it must be *unless* fk exists!
12:24 Joubu              there is also a typo in the description endopoint
12:32 marcelr            thx oleonard++
12:47 * khall_           waves
12:53 oleonard           Hi khall_
12:56 mtj                hi tcohen, nugged, i tested the systemd patch, and it seems to work well
12:57 mtj                i added a follow-up patch to bug 33371
12:57 huginn             04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 normal, P5 - low, ---, mtj, Needs Signoff , Add 'koha-common.service' systemd service
13:13 tcohen             Joubu: there seems to be only one difference
13:13 tcohen             the column comments are...
13:13 nugged             but before the patch the issue is there, right?
13:14 nugged             this to say - it means release will ruin reboots for those who upgrade so this is "blocker/critical" patch?
13:25 mtj                nugged: yes and yes
13:26 nugged             mtj: thanks!
13:26 nugged             tcohen: ALARM! ALARM!!! :)... 🤷‍♂️
13:27 mtj                tcohen: we can either remove the *.service file - or add the follow-up patch
13:28 mtj                we could revert, and plan to re-add file in next release, after further testing
13:28 marcelr            it fits with the Disaster release name :)
13:29 mtj                23.05 titanic
13:29 marcelr            great
13:30 mtj                lets no go there team :)
13:30 mtj                revert might be the safer option?
13:37 mtj                ill build a 23.05 pkg now
13:40 nugged             Did we manage to slip into that tiny sliver of time before we presented the .deb to the world?
13:43 cait               we are not naming it Titanic!
13:53 marcelr            ah cait
13:53 marcelr            kate :)
13:56 marcelr            for the fans of Auth.pm bug 33879
13:56 huginn             04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Check_cookie_auth overwrites interface set by get_template_and_user
13:59 mtj                hi nugged, yep, we havent pushed the 23.05 pkgs yet
14:01 marcelr            always wait a bit :)
14:03 mtj                we need to add a 23.05 branch to ktd
14:10 cait               marcelr: it took me a while, but: lol
14:13 marcelr            np
14:21 PedroAmorim[m]     marcelr: around? we have a 22.11.06 installation with the same issue describe in bug 32011
14:21 huginn             04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011 major, P5 - low, ---, jonathan.druart+koha, Pushed to stable , 2FA - Problem with qr_code generation
14:21 PedroAmorim[m]     I have not dabbed in 2FA before and I'm a bit confused with the discussion in the bug!
14:21 PedroAmorim[m]     it's only that specific installation, other 22.11.06 are not suffering from it, my understanding is the secret length is the cause?
14:21 PedroAmorim[m]     what secret is this and where can I spot it? =D
14:25 marcelr            hi PedroAmorim[m]
14:26 marcelr            that bug is a bit far in my mind currently
14:26 PedroAmorim[m]     hey! no worries!
14:26 marcelr            you should be able to find it quickly in the module for 2FA
14:26 tcohen             Joubu: the DBIC difference is when you rebuild against an updated db. right?
14:28 tcohen             mtj: what have you done for the build? reverted the unit file?
14:28 tcohen             I need to get updated on where we are at so I can fix things
14:29 mtj                hi tcohen, ive make a build, with the 2nd patch of bz 33371 applied
14:29 tcohen             mtj: don't publish packages yet
14:29 tcohen             we need a fix on a db_rev as well
14:30 tcohen             ok?
14:30 mtj                ...pushed to master and 23.05 dists, on koha-staging repo
14:30 mtj                yep, ok :)
14:32 tcohen             I'll revert the unit file for now
14:32 tcohen             in master and in 23.05
14:32 tcohen             or... have you tested the follow-up?
14:33 nugged             tcohen: I am using that .service on production in my beta-build as made in 33371
14:35 tcohen             ok, nugged and mtj tested and agreed the follow-up is good to go then
14:35 nugged             that's why I signed off that patch in 33371 - at least mine 4 servers now confirmed after koha-common update with this patch started to reboot OKey=ley
14:36 nugged             > is good to go then
14:36 nugged             ... at least "a little" better with follow-up than without anyway :)
14:37 tcohen             can we roll back and add a codename?
14:37 mtj                tcohen: you can do whatever you want :)
14:40 cait               .. but not titanic.
14:44 nugged             Colossal
14:44 nugged             Monumental
14:44 nugged             Herculean
14:44 nugged             Olympian
14:44 nugged             Majestic
14:44 nugged             Grand
14:44 nugged             Epic
14:44 nugged             Mighty
14:44 nugged             Noble
14:45 nugged             Illustrious
14:45 nugged             Monumental
14:45 nugged             Imperial
14:45 nugged             Regal
14:45 nugged             Sublime
14:45 nugged             🤭
14:46 nugged             "Koha goes to Helsinki" :P
14:46 nugged             btw, there is the Finnish word you should learn -
14:46 nugged             Sisu
14:48 nugged             this word doesn't have direct translation to other languages, somewhat Finnish-courage-stubbornness-resilience
14:48 nugged             (it's not to say it for us but meaning... ha! it fits instead of Titanic :) )
14:49 nugged             "Sisu" is a Finnish concept that can be roughly translated as strength of will, determination, perseverance, and acting rationally in the face of adversity. It's a form of courage that's typically about taking action against the odds and displaying courage and resoluteness in the face of adversity. In essence, it's the power that enables individuals to push through significant challenges, no matter how insurmountable they seem.
14:50 nugged             ok, ok,
14:50 caroline           sounds like "grit"
14:50 * nugged           fell silent
14:51 * nugged           fell silent with proposals :), but not in replies
14:52 nugged             caroline: very very close, right
14:53 nugged             Quoting (my own) another chat –
14:53 nugged             "sisu" goes beyond that, incorporating a sense of acting rationally against the odds, continuing when success seems unlikely, and even a form of transformative resilience that can change the course of events.
14:53 nugged             While "grit" often refers to long-term goals and consistency of effort, "sisu" is more about short-term bursts of extraordinary courage and determination in extreme situations. It is often described as a reserve of power which enables extraordinary action when normal mental or physical capacities have been exceeded.
14:53 nugged             So, while they have overlapping meanings, "sisu" contains elements that go beyond the concept of "grit".
14:54 caroline           language is so cool
14:55 cait               it's a lot better than Titanic for sure :)
14:55 cait               or yesterday's proposal of Apocalypse
15:00 nugged             "Apocalypse"... Ukraine fighting against that right now 💪 ... But it's very close, right. Let's have a resilience and courage, as well with Koha. So right to get to more 'we have a change to survive / we will' name :)
15:03 * nugged           brought itching topic, wrapping it. Oss!
15:15 reiveune           bye
15:19 tcohen             We will definitely start using codenames for next releaes
15:19 tcohen             afk for a while, cya!
15:25 mtj                hi tcohen, can you set 23.05 branch on KTD to 'protected'
15:29 Joubu              [off] it's late and I am tired but isn't 33879 a security bug?
15:42 oleonard-away      Is Library Thing for Libraries still a thing?
15:42 caroline           oleonard, I recently had someone migrate from that to Koha, so I would say yes?
15:45 oleonard           I wonder if the LTFL features still work in the OPAC
15:47 caroline           Maybe I'm not thinking of the same thing then... They were using it as an ILS
15:48 oleonard           Maybe it was TinyCat?
15:51 caroline           I don't have their old catalog anymore obviously, but the file of records they sent me has "Librarything" in the filename
15:53 caroline           might have been tinycat, I'm surprised I don't remember since there is a cat :)
16:10 oleonard           kidclamp, khall_ do you know of any libraries using LTFL integration in Koha?
16:11 * khall_           is afraid to ask what LTFL is
16:12 cait               library thing for libraries
16:12 cait               (I don't know why I know this)
17:41 kidclamp           I suspect we do, I have heard of it, but educators may know
17:41 kidclamp           What prompted the question oleonard?
17:58 oleonard           kidclamp: I wasn't able to get it to work while testing a patch, so I wondered if it was broken
19:36 davidnind          tcohen: what day and time would you like set for the next development meeting?
19:37 tcohen             Next wednesday, the usual time
19:37 tcohen             davidnind++
19:53 cait               davidnind++ thx for the sign and fix :)
21:17 davidnind          Agenda for next development IRC meeting and calendar entry added: https://wiki.koha-community.org/wiki/Development_IRC_meeting_7_June_2023