Time Nick Message
02:47 jenneen[m] Hi, I am in the process of migrating the data from our old LMS, but unfortunately koha does not recogise the data in the 952 tag. I have edited the tag to ensure the subfields match to Koha's but the records once imported state no items attached. Any suggestions as to why this is occurring?
02:49 dcook Hey jenneen, there's a few options for processing items in the incoming 952
02:50 dcook You'll want to make sure you're using "Yes" and "Always add items" under "Check for embedded item record data?"
02:50 dcook Oops I should've said jenneen[m]
02:51 jenneen[m] Yes I have made sure the import settings are set to always add
02:51 jenneen[m] items - sorry
02:52 dcook Which version of Koha are you running?
02:52 jenneen[m] Yes is also ticked
02:52 jenneen[m] 22.11
02:52 dcook Do you know the point release? Is it an up-to-date version? I've noticed 22.11 seems to have quite a few bugs
02:53 jenneen[m] what is the "point release"?
02:53 dcook If you go to /cgi-bin/koha/about.pl you'll see a few more numbers after 22.11
02:53 dcook Like 22.11.03.000 or 22.11.04.000 or whatever
02:53 jenneen[m] I'll have a look
02:55 jenneen[m] 22.11.05.000 Rosalie
02:55 dcook Ok I think that's pretty up-to-date
02:55 dcook I don't typically add items via this mechanism, but I'll try one out on my local test system to see if anything jumps out at me
02:56 jenneen[m] Thanks. I'll go grab a quick bit to eat and be back shortly
03:04 dcook Hmmm I notice that no information is provided for the items during the staging process, and then it says "Number of items ignored: 1" when I do import the record...
03:04 dcook Looks like a bug
03:06 dcook Now the question is... is this bug already reported...
03:08 dcook Looks like the background job for the staging was OK..
03:09 dcook Mmm I see an error reported in the import_items table..
03:09 dcook Oh I think I know what this one will be about..
03:13 dcook Found a different bug that will be fixed in 22.11.06...
03:15 dcook Ok maybe not a bug. My problem was that I was trying to add an item with a duplicate barcode. Once I fixed the barcode, then I had no problem
03:16 dcook Unfortunately, when there is an error like that, Koha isn't saying why the item is being ignored. Not in the UI, database, or logs... I actually already reported that problem back in January..
03:17 dcook bug 32638
03:17 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32638 minor, P5 - low, ---, koha-bugs, NEW , No reason given for why items ignored during MARC import
03:29 dcook jenneen[m] After some testing overall it actually looks OK to me. Feel free to share one of your 952 elements though via https://paste.koha-community.org/ and I could take another look to see if anything obvious jumps out
03:30 dcook You might also want to check the log file /var/log/koha/<the name of your Koha instance goes here>/worker-output.log
03:36 jenneen[m] Thanks, dcook. I copy one of the records that was just in the last import file and if you could test it on your system that would be great. I'll also take a look at the log file to see if I can find anything there.
03:39 jenneen[m] I've just copied the record into the paste option.
03:39 jenneen[m] Please let me know if you are unable to access it. Or you need it converted back to .mrc
03:46 jenneen[m] I'm not too sure how to find the /var/log/koha/<the name of your Koha instance goes here>/worker-output.log. I don't see anything listed as worker-output.log?
04:03 dcook You need to choose "#koha" for the channel, and to click "Paste it" for the link to show up
04:03 dcook You do need to replace <the name of your Koha instance goes here> with the name of your instance
04:04 dcook jenneen[m] ^
04:23 jenneen[m] Is it worth waiting for the new version 23.05 to be launched and upgrading to it? If it is an issue with the import function could it have been fixed in the new version?
05:15 dcook jenneen[m] It's looking like it's not an issue with Koha after all
05:16 dcook jenneen[m] You haven't posted in your 952 though. If you do, I could take a look and see if there's something that pops up
05:28 davidnind jenneen: I would recommend sticking with 22.11.x (stable), generally:
05:30 davidnind If you want to run the **most bug-free** release of Koha at any given time, you should track the **oldoldstable** branch. (Currently 21.11.x)
05:30 davidnind If you want the **most feature rich** release of Koha and don't mind dealing with a few bugs every few months, then track the **stable** branch. (Currently 22.11.x)
05:30 davidnind The **happy middle ground** of **oldstable** will get new features six months later than stable, but should be considerably more tried and tested, and as such more bug free. (Currently 22.05.x)
05:31 davidnind ^^ My thoughts only, I'm sure others will have different views!
06:00 ashimema David described it well there
06:01 ashimema Generally if you have the backup of a support company and/or are happy to put up with a few rough edges I'd track 'stable'.. otherwise I'd go for 'oldstable' where most of the right edges should have been smoothed out by 6 months of others running stable and smoothing out the edges for you.
06:03 ashimema Many if the support companies actually don't follow that however.. at ptfs-e we run the .11 releases.. to reduce the number of feature changing upgrades to one a year for our customers (at their general request).. we test the .11 for a month or two before starting a set up upgrades.
06:12 dcook TIL that Alma apparently is using YAZ 2.1.32 from 2006 for Z39.50...
06:14 dcook Also good morning ashimema and evening davidnind :)
06:27 davidnind hi dcook
06:29 ashimema Morning
06:30 ashimema Fair warning, I'm already a bit grumpy this morning
06:30 dcook You and me both. You and me both.
06:30 * dcook will keep in some of his grump
06:55 dcook Trying to remember how to generate the encryption keys for koha-conf.xml...
06:55 dcook I did it just the other day...
06:56 dcook It'll be in koha-create probably..
07:00 dcook Hmm nope. Weird.
07:02 dcook Ahhhh https://lists.katipo.co.nz/public/koha/2022-June/058016.html
07:02 dcook I think tcohen recommended just use "pwgen 32"
07:03 dcook One day we'll need to do something more automated for the encryption key stuff, but not this day heh
07:45 JanHitSamAchar[m] From the university
08:06 cait hello all
08:32 cait noone here?
08:32 ashimema morning
08:32 cait tcohen: saw your later, but missing context - link what to what?
08:44 PedroAmorim[m] o/
08:45 cait hi PedroAmorim[m]
08:50 PedroAmorim[m] looking for feedback for bug 33716 from any interested ILL enjoyer!
08:50 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 new feature, P5 - low, ---, koha-bugs, Needs Signoff , ILL - Allow for a disclaimer stage per request type
08:51 PedroAmorim[m] can look at a bug or 2 in return!
08:56 cait Hi PedroAmorim[m] :)
08:57 cait having a koha day today, I can try to have a look after some breakfast
09:21 ashimema cait++
09:35 cait ook, trying to get back into ILL
09:36 cait PedroAmorim[m]: if you want to help with something... i have 2 things I got stuck with where a fresh set of eyes might help
09:36 cait bug 31585
09:36 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 minor, P5 - low, ---, katrin.fischer, NEW , "ACQUISITION ORDER" action missing from log viewer search form
09:36 cait bug 14261
09:36 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 trivial, P5 - low, ---, katrin.fischer, ASSIGNED , Switch 'ask for a discharge' to 'download discharge confirmation' when patron was discharge in OPAC user account
09:37 cait not expecting anything, but maybe something stands out to you having a look
09:54 cait PedroAmorim[m]: nice diagram!
09:55 ashimema he's been working hard to bring sanity to ILL and documented processes as he goes!
09:55 ashimema Pedro Amorim: is awesome
09:56 cait I wonder if we could put that into the wiki or manual
09:56 cait would be sad to have it lost on the bug
09:56 cait PedroAmorim++
09:56 cait something I have been missing is a cancelled stage when we started figuring ours out
09:57 cait I fully appreaciate more sanity :)
09:58 ashimema Yeah.. we deffo need to put these diagrams somewhere.. we've just not worked out where yet 😜
10:10 cait hi khall
10:10 * khall waves
10:10 cait surprised it's so quiet today :)
10:12 cait is the pipe there correct?
10:12 cait PedroAmorim[m]: text: |
10:12 ashimema yes
10:13 ashimema it means 'This is a block of text with linebreaks included'
10:13 ashimema it's a yaml ism
10:14 cait ah! thx
10:14 cait i ownder if we could maybe use <code> there to make the exmaple courier
10:14 cait that might improve readability a little
10:14 cait i'll test it
10:14 * ashimema may have reviewed a bit of this work during the coding and submission process ;P
10:15 ashimema yeah.. we weren't entirely sure how best to do the example to be honest
10:15 ashimema it could also have been placeholder text
10:15 ashimema above or below the entry box..
10:15 cait i wonder if the text might have been better in a separate pref with the html editor
10:15 ashimema or in the manual with more explanation instead of in the prefs page itself.
10:16 cait yeah, because it's a bit cryptic now
10:16 cait I don't know what the options each do
10:16 cait and what will be valid options/mandatory etc
10:17 cait this is probably the most advanced YAML pref so far - It could be a little much for librarians
10:17 PedroAmorim[m] hey yeah, the example provided is there up for discussion really. It contains all a valid YAML with all considered options
10:19 PedroAmorim[m] for each request type, you can have 3 configs: text, av_cat and bypass... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/ELKKDIZqhbRwqARyoJkqIzoY>)
10:19 PedroAmorim[m] there is also a special "all" request type at the top, this is the fallback configuration for every request type not specified
10:20 cait I think i migh twant to put that into the pref descr for now - what do you think?
10:20 cait Ill make a suggestion
10:28 PedroAmorim[m] cait: added a patch to 31585
10:29 PedroAmorim[m] Yes, thank you. Yeah honestly I just left the sys pref example there as sort of a self-documenting workaround (to help myself in the development, and have a working YAML out of the box that anyone can use)
10:29 PedroAmorim[m] but that can 100% be improved
10:29 cait PedroAmorim[m]: https://snipboard.io/1DgKf0.jpg ?
10:30 cait oh i hope we didn't overlap now
10:30 cait ah different bug phew
10:30 PedroAmorim[m] yeah it's one of the 2 you mentioned xD
10:31 PedroAmorim[m] yes that is much better I think (re 33716)
10:31 cait i rephrased the description a little - is it correct?
10:31 cait how i describe the options
10:32 cait PedroAmorim[m]: did you test it? because I feel like i tried that, but it's really been a while and this template is really confuing (to me - still talking log viwer)
10:32 PedroAmorim[m] yeah, except av_cat should be av_category_code (I said av_cat previously from the top of my head)
10:32 cait aah fixing
10:33 PedroAmorim[m] yes
10:33 PedroAmorim[m] https://snipboard.io/TjqVgN.jpg
10:33 cait ok, yeah fresh eyes, helps :)
10:34 PedroAmorim[m] I just didn't test with actual logs in the database for those types
10:34 cait I tihk we should be ok, but will check :)
10:34 PedroAmorim[m] 👍️
10:34 cait but first... trying to test your ill etup script next
10:34 PedroAmorim[m] sure, let me know if any help is required
10:35 PedroAmorim[m] I didn't provide a test plan for the CheckAvailability stage because that requires at least one plugin and credentials
10:35 PedroAmorim[m] and I figured just the TypeDisclaimer for this test should suffice, but we can go through that if you decide that
10:35 PedroAmorim[m] (referring a bit back to the diagram, and how this new stage interacts with already existing workflow stages)
10:36 cait still digging in, give me a few more minutes to get there
10:39 cait huh
10:39 cait didn't we fix that already?
10:39 cait Warning The ILL module is enabled, but the configured 'partner_code' (ILLLIBS) is not defined on the system.
10:41 cait oh not pushed ok
10:41 cait hm or not
10:41 cait bug 30820 is in
10:41 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30820 enhancement, P5 - low, ---, koha-bugs, NEW , Standardize sample patron category for ILL libraries
10:42 cait hm i guess maybe my koha-conf.xml is too old, ignore me
10:49 PedroAmorim[m] <cait> "Warning..." <- that's weird, after bug 21548 this should not happen
10:49 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 enhancement, P5 - low, ---, pedro.amorim, Needs documenting , Make ILL patron category in koha-conf.xml match with ILL patron category in sample data
10:49 cait PedroAmorim[m]: it's ok, old koha-conf.xml
10:50 cait i believe
10:50 cait i guess we only need to check that after a ktd down up it's set correctly next time
10:50 cait ashimema: do you remember the style fix we did for the request detail page? I am not finding the bug, but still see the formatting issues
10:51 PedroAmorim[m] oh yes, I was confusing with bug 32911
10:51 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 enhancement, P5 - low, ---, pedro.amorim, Passed QA , Remove ILL partner_code config from koha-conf.xml and turn it into a system preference
10:51 PedroAmorim[m] that has not yet been pushed
10:51 PedroAmorim[m] with 32911, even with old koha-conf.xml, that message should not show
10:52 cait it showed becaues i have not category type ILLLIBS
10:52 PedroAmorim[m] because it's supposed to retrieve partner_code from the new sys pref instead of koha-conf.xml, old or not
10:52 cait i think it was correct as an error
10:52 ashimema Yeah.. we spotted that
10:52 ashimema it got broken again with 24400
10:52 cait oh
10:52 PedroAmorim[m] 22440
10:53 ashimema Pedro Amorim: did we not do a follow-up or something to fix that display again?
10:53 PedroAmorim[m] we didn't, had a chat with Tomas about it but I didn't follow-up on it
10:53 PedroAmorim[m] but can do
10:53 cait at least file a bug maybe
10:53 cait the green hover thing drives me crazy
10:53 cait (yes,probably too sensitive there)
10:54 cait sorry for binging up so many oher things :) QA problem
10:54 cait PedroAmorim[m]: the pref is not pushed yet, it's in PQA
10:54 cait for patron category
10:54 PedroAmorim[m] yes, I know
10:54 cait so the error I had was ok
10:54 PedroAmorim[m] yep
10:58 cait workflow question
10:59 cait the disclaimre is used for something like: agree to not use this commercially or so?
10:59 cait but whatever I reply/choose in the options, the request is still added?
11:00 cait We only have a "next" button... Maybe we should have a submit an dcancel?
11:00 PedroAmorim[m] yes, that is correct
11:00 PedroAmorim[m] that is a valid point, we could have a cancel yes
11:01 cait https://snipboard.io/tJucQ0.jpg
11:01 cait it does not look quite right with the headings too
11:01 PedroAmorim[m] the request is only created after that form is submitted, if the user clicks away or visits a different page before submitting the form the ILL request is never created
11:01 PedroAmorim[m] cait: it can be whatever comes from the av_category, it may be different options than YES_NO
11:02 cait true
11:02 cait but i think we should get rid of <h3>Displaying typedisclaimer results</h3>
11:03 PedroAmorim[m] yes, we should, I must've overlooked that
11:03 cait and the button should be yellow
11:03 cait let me try
11:04 PedroAmorim[m] yep!
11:07 cait https://snipboard.io/RQqjnU.jpg
11:07 cait green in opac, yellow in staff
11:08 cait using the same mark-up as other opac-forms now - specifically 'new suggestion'
11:11 PedroAmorim[m] this is great
11:13 PedroAmorim[m] cait: did you use https://github.com/ammopt/koha-ill-dev/blob/master/start-ill-dev.sh
11:13 PedroAmorim[m] or no need? I added that to the test plan to help people who don't have ILL already set up
11:14 cait i used it :)
11:15 PedroAmorim[m] awesome!
11:15 cait and i like it, i should have written one when we started developing our backend
11:15 cait https://snipboard.io/v45a0r.jpg
11:15 cait i added cancel to staff and fixed the breadcrumbs
11:15 ashimema I've suggested we add it to ktd somehow..
11:15 ashimema just getting feedback on the best way to go about it.
11:16 ashimema the data faker stuff is also great for loading up a tonne of ILL's fast.. though it need some refinement before it ready for other devs really
11:16 PedroAmorim[m] cait: this is phenomenal tyvm
11:17 PedroAmorim[m] yes improving the data faker is on my list, it shouldn't be too troublesome really famous last words
11:18 cait the crumbs still need a littl ework, but almost there
11:24 cait uplodating patches and signing off
11:27 cait hope I didn't go too far with changing stuff :)
11:27 ashimema cait++
11:30 PedroAmorim[m] cait++
11:30 PedroAmorim[m] amazing, tyvm
11:35 cait awww
11:35 cait so what are we doing next?
11:36 cait PedroAmorim[m]: hm bug 31585 doesn't apply, coudl you check?
11:36 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31585 minor, P5 - low, ---, katrin.fischer, Needs Signoff , "ACQUISITION ORDER" action missing from log viewer search form
11:36 cait I am on latest master
11:38 PedroAmorim[m] yes, checking
11:38 cait taking the chance to refresh my ktd
11:38 cait ktd pull might take a while it looks like
11:38 ashimema has anyone else noticed that we return 'messages' from CanBookBeIssued and even pass them to the template
11:38 ashimema but promptly don't appear to ever do anything with them?
11:39 cait I am not sure I am following
11:39 ashimema don't worry cait.. I'm digressing
11:42 PedroAmorim[m] cait: 31585 should be cool now, no idea what happened
11:43 cait ok, still waiting for the pull - I will be back :)
11:51 PedroAmorim[m] cait: your patch https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33716&attachment=151393
11:51 PedroAmorim[m] is still referring to the "bold" text but it's not bold anymore
11:52 PedroAmorim[m] also, in the ILL sysprefs, do you think we should move ILLModuleCopyrightClearance, ILLCheckAvailability, and ILLModuleDisclaimerByType into a new category "Workflow"
11:53 PedroAmorim[m] these 3 sysprefs are distinctly different from the others in the way that they will prompt the user with a screen either before or after submitting the create form
11:56 cait good catch
11:57 cait i like the idea with the new sub heading a lot
11:57 cait do you want to have a go at it and I SO?
11:59 cait doing log viewer right now, then will re-setup ILL
12:00 PedroAmorim[m] cait: yes, I can do that.
12:00 PedroAmorim[m] One other thing we could add to the documentation, something like:
12:00 PedroAmorim[m] "supported request types depend on installed backends, contact your system administrator for all supported request types"
12:01 PedroAmorim[m] because, in the case of FreeForm, the request type 'article' shows up in the dropdown interface as 'Journal article'
12:01 PedroAmorim[m] just a thought, not sure if this is required or not
12:02 cait it might be good I think
12:02 cait ours would be totally different too
12:02 cait copy and loan
12:03 cait ddi you delete MODCIRCMESSAGE intentionally?
12:04 PedroAmorim[m] oops, nope, I could swear I only added the other 2 missing ones
12:04 PedroAmorim[m] I can correct that
12:04 PedroAmorim[m] (it's silly to have that list duplicated in 2 places in that .tt file but I'm sure there's a reason for it)
12:04 cait i can do too
12:04 cait don't ask me, as I said, I got totally stuck there :)
12:07 cait we should clean up the display too... wayyyy too many checkboxes nowadays :)
12:11 cait ok back to ILL
12:12 cait PedroAmorim[m]: hm we might still have a hidden ILLLIBS somewhere, I started over and my koha-conf.xml still has it
12:13 PedroAmorim[m] because bug 32911 hasn't been pushed yet
12:13 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 enhancement, P5 - low, ---, pedro.amorim, Passed QA , Remove ILL partner_code config from koha-conf.xml and turn it into a system preference
12:13 cait maybe - but the one standardizing on IL has been
12:15 PedroAmorim[m] yes
12:15 PedroAmorim[m] ktd is placing ILLLIBS in /etc/koha/sites/kohadev/koha-conf.xml because it requires 32911
12:16 PedroAmorim[m] but kohadevbox/koha/etc/koha-conf.xml is correct
12:16 cait ok
12:17 PedroAmorim[m] wait, actually, no. 32911 should not be required
12:17 PedroAmorim[m] it might have something to do with how ktd is setting it up
12:17 PedroAmorim[m] because 21548 is already changing it from debian/templates/koha-conf-site.xml.in
12:18 PedroAmorim[m] need help from a ktd expert here :D
12:19 tcohen hola #koha o/
12:22 cait maybe we can just wait it out :)
12:22 cait hola tcohen
12:22 cait we are having bug talk! :)
12:22 PedroAmorim[m] \o
12:22 cait PedroAmorim[m]: back on 33716 for your follow-up
12:23 cait tcohen: can we help with anything?
12:23 cait PedroAmorim[m]: you forgot th ebold :D
12:24 tcohen I've got a branch in which Im trying to fix something on order receive
12:24 tcohen it has two strings
12:24 cait we could do another update run maybe - we are not far into string freeze
12:24 tcohen that might be an option
12:24 cait bug 33314 would be maybe nice too
12:24 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 minor, P5 - low, ---, katrin.fischer, BLOCKED , Link to bibliographic record incomplete in default TICKET_NOTIFY notice
12:25 cait i am kind of thinkig it won't cause a string update now... but not 100%
12:25 tcohen why is it blocked?
12:25 cait I am not sure, I'll check
12:25 cait ook
12:26 cait because i had the wrong number
12:26 cait it's bug 33313
12:26 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 normal, P5 - low, ---, katrin.fischer, Signed Off , TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice
12:26 cait but i guess... both would be nice for the new feature to work right
12:27 cait not sure why they split, I think because Caroline fied them like that
12:27 tcohen get them ready
12:27 tcohen and I'll start the string extraction after we push
12:27 ashimema let me commit my current bookings work and then I can lend a hand with QA's
12:28 cait ashimema: I worked on those 2 so I am out right now - but they shoudl be easy
12:28 ashimema exactly
12:28 ashimema 😉
12:28 tcohen ashimema: we need the release notes
12:28 ashimema they're building a few times a day at the moment tcohen 😜
12:28 cait tcohen: I can work on writing up some if that helps? (on bugzilla)
12:29 tcohen cait++
12:29 ashimema every time I update our internal rmaint queue I also build the notes
12:29 cait or going through them at least checking for stuff
12:29 tcohen ashimema++
12:29 cait PedroAmorim[m]: you need to warn me about follow-ups heh
12:29 ashimema I'll build them again at next master push 🙂
12:29 ashimema and any time anyone asks
12:30 cait are they current now? then I'll tackle them next
12:33 ashimema I think they are.. but I'll run the script for good measure
12:36 cait ashimema: ready?
12:36 ashimema the script takes a little while to run 😜
12:37 ashimema it's building notes for all versions with changes and then publishes them
12:37 ashimema done
12:38 ashimema https://gitlab.com/koha-community/koha-release-notes/-/blob/master/release_notes_22_12_00.md
12:38 ashimema 14 new features, 162 enhancements, 647 bugfixes.
12:38 ashimema not bad
12:41 cait do we have someone for checking the installation instructions actually?
12:41 cait https://wiki.koha-community.org/wiki/Installation_Documentation
12:42 cait in the debian instrucntions newest version listed appears to b 21.11
12:51 ashimema if you fancy a fun one cait you could take a look at bug 29002 for me
12:51 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 enhancement, P1 - high, ---, martin.renvoize, Needs Signoff , Add ability to book items ahead of time
12:51 ashimema http://sandboxes.ptfs-europe.co.uk
12:51 ashimema there's even a sandbox ready and running
12:52 cait it's tempting, but I think release notes right now
12:52 cait maybe caroline? :)
12:52 caroline hello?
12:53 caroline what am I volunteered for?
12:54 ashimema testing bookings
12:55 caroline which bug? (sorry I just connected so I don't have the previous messages)
12:56 ashimema 29002
12:56 ashimema there's a test plan in the final comment
12:56 ashimema and a sandbox up and running with it freshly applied
12:57 ashimema http://sandboxes.ptfs-europe.co.uk
12:57 caroline you're doing all the work for me, it's hard to say no lol!
12:57 cait sorry caroline :)
12:57 cait looking at [31123] Add a simple way to add 'Harmful content warnings' to catalogue records and [31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
12:57 cait the second has no written up notes yet
12:58 cait but for terminology... concerns are harmful content warnings?
12:58 caroline I don't think they're the same
12:58 caroline One is in the record (harmful thing) and the other is like report a problem on the opac
12:59 cait it's not hte existing report a problem thing
12:59 caroline no it's a new one
12:59 cait which poses another question on hwo we want to differentiate maybe?
12:59 caroline honestly, in translations I made them the same
12:59 ashimema so...
12:59 ashimema I hoped to merge them at some point.. and turn the concerns stuff into a more generic ticketing system
13:00 ashimema but that's middle to long term goals seeking time
13:00 ashimema but the features as they stand are closely linked but not tied together
13:00 cait ok, so maybe I was wrong then, it hought they are relating to each other more directly
13:01 cait caroline: it's a good point.. i migh tneed to go over my translations again
13:01 cait caroline: to explain, trying to pretty up release notes :)
13:01 ashimema the original sponsor of the work for them wanted a workflow where patrons could report an issue with a catalog record and then staff could put something into the catalog record to display about it
13:01 caroline from what I understand one is specifically for records (concern) and the other is specifically for the opac (problem)
13:01 ashimema in our case.. it's a hospital learning library and was all about adding warnings to books about their content..
13:01 caroline concerns are also in the opac, but problem are not in staff
13:02 ashimema like 'this is good, but contains some outdated information'
13:02 ashimema or 'this book contained images that may upset some people'
13:02 ashimema that sort of thing
13:03 cait how do I do the code markup in release notes?
13:03 ashimema markdown
13:03 ashimema in the 'text for release notes' box
13:03 cait i was hoping you'd tell me lol
13:03 cait I'll go look it up
13:04 ashimema what would you like to know
13:04 ashimema the basics of markdown are simple enough.. but without knowing what your trying to achieve it's hard to guide
13:04 cait `
13:05 cait formatting a plugin hook name nicel
13:05 cait x
13:05 cait y
13:05 ashimema https://www.markdownguide.org/basic-syntax/
13:05 cait This adds a new plugin hook `patron_generate_userid` that allows to have a custom method for generating the userid on a patron record.
13:06 cait yeah alrady found it in German Wikipedia
13:06 ashimema surround with single * for italic, double ** for bold, trippled *** for both
13:06 ashimema use ` for code strings
13:06 ashimema and ``` for code blocks
13:06 ashimema and > for single line quotes
13:06 ashimema and >>> for multi-line quotes
13:06 ashimema I think that covers all the big ones
13:09 cait yep; I am good, thx
13:09 cait caroline: would oy umind writing some release notes for bug 31028?
13:09 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 new feature, P5 - low, ---, martin.renvoize, RESOLVED FIXED, Add 'Report a concern' feature for patrons to report concerns about catalog records
13:09 cait or I can try, but maybe proof read later?
13:09 caroline sure
13:11 cait ashimema: the first step of the test plan says: OpacCatalogConcerns... typo if this is the staff bug?
13:12 cait hm i think the tst plan is confusing, we are in the OPAC
13:13 ashimema sorry
13:14 ashimema what comment
13:14 ashimema that bug went through a lot of iterations
13:14 ashimema best documentation is in the attached spec
13:14 caroline cait I can do it if you want, I did it for the manual
13:14 ashimema https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147797
13:15 cait i think it's both... I put something in the box, but please check :)
13:19 caroline seems good to me
13:20 caroline ashimema, re my comment on bookings https://snipboard.io/EDpzBr.jpg
13:20 ashimema hmm
13:20 ashimema I don't see that
13:20 ashimema wonder if there's a caching thing going on
13:20 ashimema odd though.
13:21 caroline given that I've never been to that page, I doubt it?
13:22 caroline maybe cait can confirm? If you click "Place booking" on this page, can you select a patron? http://staff-bug29002.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=285&itemnumber=631#item631
13:22 cait one sec
13:22 cait while I do that: update bug 8179 to new feature?
13:22 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 enhancement, P5 - low, ---, agustinmoyano, Pushed to master , Receiving multiple order lines at once
13:23 ashimema ahh,..
13:23 ashimema I know what it is
13:23 ashimema try it on the Normal view
13:24 ashimema that is a bug though.. I miss the javascript loading on the different tabs it seems
13:24 ashimema thanks Caroline
13:24 cait that appears to be it yes
13:24 caroline ah yes, it works on normal view
13:25 ashimema I'll fix that shortly.. thanks.. already really helpful 🙂
13:25 caroline is this a new way of looking for patrons? we don't use patron search anymore?
13:26 ashimema so.. that's up for debate as it happens
13:26 ashimema I wrote all this long before we did the patron search rewrite
13:26 ashimema and I wanted to introduce what I felt was a cleaner way to do it
13:26 ashimema however.. things have moved on since I wrote it and I've not updated this patch..
13:26 ashimema but.. I'd be interested in feedback
13:27 caroline +1
13:27 ashimema Nick suggested he liked the look of the select2 but wanted a button to allow for the full new window based patron search stuff too
13:27 ashimema which seems like a happy middle ground to me?
13:28 caroline I don't really mind either way, but for usability I think it should be the same everywhere if that makes sense?
13:28 ashimema yup
13:28 ashimema I can't remember what it was before.. but I hated it
13:28 ashimema and it really didn't work with modal workflows
13:29 caroline lol!
13:29 caroline I agree, it opens new windows etc
13:34 cait i tihnk the argument as that select lists don't work so well for something like miller or smith in a big databas
13:34 cait so having a more complex search option additionally would be good
13:34 cait so you can also limit to patron category/library if necessary
13:34 ashimema yup
13:35 ashimema I'd like to remind myself what our other patron searches do and revisit this version
13:35 ashimema it would be food to modernise them all if we can agree on an approach
13:36 ashimema QA'd the two cat concerns follow-ups
13:36 ashimema thanks for those Katrin
13:38 cait yw :)
13:42 cait hm vendor aliases and vendor interfaces - enh or new feature?
13:42 caroline new feature I'd say
13:43 ashimema New Feature
13:45 cait vote accepted
13:45 caroline :)
13:54 cait ok I am in Architecture section now
13:54 cait bug 30642 - shoudl we move to circulation?
13:54 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 enhancement, P5 - low, ---, matt.blenkinsop, RESOLVED FIXED, We should record the renewal type (automatic/manual)
13:55 cait i almost always skip over architecture heh
13:55 ashimema yeah
13:55 ashimema I think so
13:55 ashimema let me know if you want a rebuild to see what you've already done 🙂
13:56 cait i was about to ask you :)
13:56 cait to check my formatting works as expected
13:57 ashimema fireing
13:59 ashimema ./syncgit.pl
13:59 ashimema ./asana.pl
13:59 ashimema ./notes.pl
13:59 ashimema oops
14:02 cait cool, looks like the `` and the list I did worked
14:04 ashimema excellent
14:09 caroline this message made me lol https://snipboard.io/0KNJzp.jpg
14:09 ashimema lol
14:09 ashimema I thought I'd removed that!
14:09 ashimema my bad
14:09 cait bug 20256 - new feature?
14:09 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 enhancement, P5 - low, ---, kyle, Pushed to master , Add ability to limit editing of items to home library or library group
14:09 caroline it's ok, it made me smile :)
14:09 ashimema though it does beg the question.. what sort of feedback do you think we should give/how
14:09 caroline Ok I'll add that to my comments
14:10 ashimema hmm.. that one is more difficult
14:10 ashimema could be either really
14:10 ashimema I like it though..
14:10 ashimema maybe new feature
14:10 ashimema it's certainly at the top end of enhancement
14:12 cait it's quite big too and i tihnk we have onthing cataloguing yet, we can still downgrade
14:13 cait about this bug too: was there a trick to format a forgotten sponsored by line nicely from the release notes?
14:13 cait I guess i could mak eit bold and italic, but wondered if there was a trick to it
14:14 ashimema Sponsored by Virginia Polytechnic Institute and State University
14:14 ashimema Sponsored by Virginia Polytechnic Institute and State University
14:14 ashimema lol
14:14 ashimema my irc client uses mardown..
14:14 ashimema did you see that in plaintext?
14:15 ashimema https://gitlab.com/koha-community/koha-release-notes/-/blob/master/release_notes_22_12_00.md?plain=1
14:15 ashimema if you look at the plaintext of the existing notes.. you can see the markdown it produces.. so you can copy it
14:16 ashimema I think if you want it consistent with the one's that were added 'properly' using the commit message you need to put it at the top of the 'Text for release notes' block and lease an empty line after
14:16 ashimema hope that helps cait
14:19 cait cool, got it right by accident :)
14:26 ashimema 🙂
14:34 cait I am still at C
14:34 cait circulation now... we really need to push devs to do this
14:35 caroline I should also think to do it when I'm writing for the manual... I'm just like "on to the next one!!" and forget
14:35 ashimema I tried
14:35 ashimema but it would be good to try again
14:36 cait btw caroline++ aude_c++ - you are doing amazing work on the manual
14:37 cait ashimema: you did it again :) 'Warning: Item {barcode} is reserved'
14:37 cait GB vs AE
14:37 cait or... BE vs AE
14:41 cait hi oleonard in the background :)
14:41 oleonard :)
14:41 lukeg good morning, afternoon, or evening Koha :)
14:47 cait and lukeg :)
14:47 cait anyone wants to join me writing release notes?
14:49 caroline Is the release still on schedule for ~22?
14:50 ashimema for feature release.. I sort of imagine not.. though maybe
14:50 ashimema for maint release.. also not 100% sure..
14:51 ashimema 22.11 is ready.. but I'm not sure I've seen the others say they are.. and it's a security releae
14:51 cait * May 31st - Final release
14:51 cait from tcohen's mail :)
14:51 caroline ok I was just curious, I've seen some frantic chatter on here, so I thought it might-ve been pushed back
14:52 tcohen I shifted one week or so, from the original/usual dates
14:52 tcohen because of the tidy that is needed for bug 8179
14:52 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 new feature, P5 - low, ---, agustinmoyano, Pushed to master , Receiving multiple order lines at once
14:53 tcohen Asked ByWater to help me with the remaining details
14:53 tcohen https://gitlab.com/thekesolutions/Koha/-/commits/fix_8179
14:54 tcohen ^^ that's where the current patch is (restoring funds dropdown, etc)
14:54 tcohen I cannot spend time on it right now
14:54 ashimema ho.. bug 29046 didn't make it
14:54 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 enhancement, P5 - low, ---, martin.renvoize, Passed QA , Allow libraries to specify email order for "AutoEmailPrimaryAddress"
14:54 ashimema thought I'd seen that go in..
14:54 ashimema oh well
14:54 tcohen any help is welcome
14:54 ashimema I can take a look tcohen
14:54 tcohen Jonathan made a couple comment
14:55 tcohen s
14:55 tcohen while you look at it
14:55 tcohen I can push 29046
14:56 ashimema Jonathans comments on BZ or your gitlab somewhere?
14:56 tcohen bz
14:56 ashimema ta
14:57 ashimema notes refresh inbound cait.. I spotted more pusing from tomas 🙂
14:57 tcohen regenerate in 2 minutes?
14:57 tcohen :-P
14:57 ashimema haha
14:57 ashimema started glowing already tcohen 🙂
15:00 cait if we are still accepting small string changes, bug 33769 could be a maybe
15:00 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 minor, P5 - low, ---, oleonard, Passed QA , Terminology: 'Warning: Item {barcode} is reserved'
15:00 ashimema poor tcohen
15:00 ashimema love you tomas
15:00 cait interesting... all routes under REST API or under their modules?
15:00 cait ah, never mind,
15:01 cait some are new features and other enh... tat's nother issue
15:01 ashimema I wondered about the API stuff.. there's a mix of new routes as 'new feature' and 'enhancements'..
15:01 ashimema lol
15:01 ashimema yes
15:01 tcohen new endpoints => new feature
15:03 cait ok
15:03 tcohen that's at least my opinion
15:03 tcohen also
15:04 tcohen I think we should reorganize the release notes by 'module'
15:04 tcohen instead of 'severity'
15:04 tcohen API:
15:04 tcohen - New features
15:04 tcohen - Enhancements
15:04 tcohen - Bug fixes
15:04 tcohen Cataloguinf:
15:04 tcohen ...
15:04 tcohen this is all a matter of taste
15:05 tcohen but I always feel we should be selling our new releases
15:05 cait I think the idea was to have some highlights visible right away
15:05 tcohen and that's not what the release notes transmit
15:05 cait but maybe there could be an additional 'highlights' that could be linked to multiple bugs?
15:05 cait Extensive work on API with lots of new endpoints...
15:10 ashimema I could easily make that change in the notes generator if we agree it's a good idea
15:10 tcohen I think we should have such structure
15:10 tcohen and maybe have some editorial work
15:10 tcohen to highlight things
15:12 tcohen ashimema: had to fix some tests, minor thing
15:12 ashimema thanks 🙂
15:13 cait in order to be able to use them for advertising I tihnk we need a short 'highlights' section - but I agree that the new features are no longer covering that need well
15:14 tcohen Honestly, I'd ask jzairo or sales people from other companies on what to highlight
15:14 tcohen I have my opinions and preferences, but probably not the best selling things :-D
15:15 tcohen 'yeah, we got this pretty cool refactoring that will help us write better code' <- no one cares about that
15:15 tcohen haha
15:15 cait See from (non-preferred form) headings are included < feel like we might want to rephrase that for the OPAC
15:16 tcohen update them ashimema
15:19 ashimema okies
15:21 cait I think I have spent all my words for today
15:21 cait running out of steam
15:24 cait caroline++
15:30 caroline cait++ <3
15:31 cait tcohen++ too - low queue :)
15:31 tcohen ashimema: cait: bernardo says strings just got updated
15:31 ashimema nice one
15:31 tcohen I'll ask for an update on 23.05 later today
15:31 cait I hadn't finished translating yet, but there wer emore this morning, that's true :)
15:32 tcohen cait++
16:37 ashimema just pushed a minor fix to the release notes generation cait
16:37 ashimema Sponsored by lines added by BZ now match those that are added by commits
16:37 ashimema commits is still better as they go into other stats.. but this is a nice little improvement none the less
16:38 ashimema time for me to cook dinner.. byeeee koha
16:48 cait ashimema++
19:04 caroline Is there already a bug report for the clubs table loading everywhere? I can't find it, but I find it hard to believe I'm the first to notice https://snipboard.io/0tBYLM.jpg
19:14 davidnind caroline: Good spotting! I can't see a bug for it, just going to check whether it is doing the same in 22.11.x
19:15 caroline davidnind, I just created bug 33774...
19:15 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774 enhancement, P5 - low, ---, oleonard, NEW , Loading club table in every tab in patron details
19:15 caroline If you want to add your 22.11 findings
19:50 oleonard :(
19:50 oleonard I had that problem during testing but I thought I'd fixed it.
19:50 oleonard caroline: are you sure you cleared your browser cache?
19:51 caroline It was in a fresh sandbox, does that change something?
19:52 caroline https://staff-caroline.sandbox.bywatersolutions.com/cgi-bin/koha/members/moremember.pl?borrowernumber=21
19:52 caroline The "Loading..." is still there after Ctrl+F5
22:58 aleisha hello all
22:59 aleisha random question - when i restart koha-common in ktd it restarts a bunch of services like koha-plack etc. how come when i restart koha-common everywhere else it doesn't print all of the service starts and stops? is it doing them or is that special about ktd?
23:04 jenneen[m] Thanks, davidnind. I think 'll try to download 22.05 and try uploading the import file there.
23:15 Locutus Is there a way to integrate openlibrary.org as a search option for adding items to the catalog? I have several Z39.50/SRU options activated, but would like to use OpenLibrary as well.
23:19 aleisha Locutus: you can add more z39.50 servers under Koha Administration
23:21 Locutus Is this where I integrate openlibrary.org?
23:22 davidnind jenneen: 22.11.x should be OK, if you can share some examples of records with items that you are using someone can have a look (paste.koha-community.org) and see if they can spot something (note that the code you use for your libraries you have set up under administration)
23:26 davidnind aleisha: in KTD I normally go flush_memcached and then restart_all - I've not done it any other way before (maybe tcohen knows 8-))
23:30 davidnind Locutus: If you want to copy catalog from the OpenLibrary (like you can with the Library of Congress), then they need to provide a Z39.50 service and these details are added to Administration > Additional parameters > Z39.50/SRU servers administration
23:31 Locutus Ok. Thank you.
23:35 davidnind Locutus: I couldn't find any details that they offer this, but I only did a quick search
23:36 davidnind Locutus: see also OpenLibrarySearch system preference
23:46 aleisha davidnind: me too! we've been having lots of problems with rabbitmq and koha-worker recently and noticed it seems to work better when we restart all services in exactly the order ktd does it. and then i realised that restarting koha-common also restarts all those services. but it doesnt print it nicely when we do it anywhere like it does in ktd
23:49 dcook A number of the koha* scripts behave a bit differently for dev installs, so that's probably it