Time  Nick      Message
00:03 davidnind aleisha: good thanks!
00:16 tuxayo    davidnind: hi :)
00:17 davidnind hi tuxayo!
00:17 tuxayo    We have something funny on the wiki. When banning LeandroRuffin11 for "Suspected SPAM account", is also banned it's IP. Unfortunately, our wiki doesn't see the external IP so it just banned an internal IP
00:18 tuxayo    which is likely used by all traffic
00:18 tuxayo    So I'm blocked for edditing XD
00:18 tuxayo    Do you see on the admin side how to disable IP block for now?
00:19 tuxayo    I hope that didn't block your account to do admin stuff
00:19 tuxayo    ^^
00:21 davidnind I've changed the block, so hopefully it should work now for you... let me know
00:22 tuxayo    davidnind++
00:23 tuxayo    Thanks :)
00:23 tuxayo    Good thing you could change it, what a mess if everyone would have been blocked outside ^^"
00:26 davidnind When blocking the suspected SPAM accounts, I just accepted the defaults (including this option: Automatically block the last IP address used by this user, and any subsequent IP addresses they try to edit from)
00:28 davidnind Hopefully this doesn't cause problems for others, otherwise I may need to go and edit all the blocks...🙃
00:32 tuxayo    Weird that other blocks didn't cause this
00:37 davidnind keeping my fingers crossed....
06:02 cait      caroline: I tihnk they just set it always, leaving it to docs to decide, but it's better than forgetting to set the status maybe :)
06:06 Joubu     I will play with ktd:22.11 today, docker image might be instable!
06:15 magnuse   \o/
06:32 reiveune  hello
06:59 marcelr   o/
07:29 ashimema  @later tell caroline the idea was that rmaints would help at least a little on the filtering by picking needs documentation vs resolved fixed appropriately but erring on the cautious side to let you guys make the final decision when we're not sure... seems they're more often just setting it for you to make the decision.. apologies about that.
07:29 huginn    ashimema: The operation succeeded.
07:30 ashimema  @later tell caroline it's perfectly fine to just switch the status if you agree it's nothing to document.. needs docs is only really intended for the user facing docs.. (we need to work on a different tact for highlighting dev documentation required.. we're not at all good at that yet honestly)
07:30 huginn    ashimema: The operation succeeded.
07:31 * cait    waves
07:31 ashimema  morning cait
07:31 ashimema  ooh.. you got D11 passing Joubu.. I had that on my list to look at this morning
07:32 Joubu     nope, cypress tests are not running
07:32 Joubu     09:23:41 koha_1       | /bin/sh: 1: cypress: not found
07:32 ashimema  sorry.. I meant I thought it was yellow after my last push yesterday even without the cypress stuff not happening
07:33 ashimema  maybe I imagined it
07:33 ashimema  so.. how can I help on the ktd/cypress front?
07:34 Joubu     it was failing yesterday because of a random failure
07:34 Joubu     I am pulling the image to investigate
07:35 Joubu     I am on it ;)
07:35 ashimema  🙂
07:35 Joubu     don't push to 22.11 for now
07:44 marcelr   Joubu: there is never a last try :)
07:45 Joubu     yes there is
07:45 marcelr   haha
07:46 marcelr   qaers 33718 and 33719 are very small and nice
07:58 Joubu     mtj: did you disconnect docker 3?
08:07 mtj       hi Joubu, its online from 10pm to 7am NZDT
08:09 mtj       hmm, i'll change it to 8pm now
09:01 Joubu     thanks mtj!
09:02 Joubu     tcohen: do you agree with https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/64 ?
09:07 Joubu     marcelr: "but we still depend on an object!" what do you mean?
09:09 marcelr   the result is an object and we fill the combo in a loop, no definitive guarantee that js will keep the current sort order since it is no array that we are looping on later
09:10 ashimema  is there a typo in that merge request above Joubu?
09:10 ashimema  cypress vs cyprxess
09:10 ashimema  is the x deliberate?
09:21 Joubu     nope!
09:21 Joubu     It was for testing!
09:22 ashimema  I thought it might be..
09:22 ashimema  i.e. to make it fail to show the junit stuff gets generated
09:22 ashimema  so for actual merge we would fix it back
09:22 Joubu     yep, will resubmit right now
09:22 ashimema  well.. i tested and am happy it makes sense
09:23 ashimema  I'd be happy for it to be merged (without the x of course)
09:23 Joubu     updated!
09:42 Joubu     it's wrong!
11:14 tcohen    hola #koha o/
11:14 tcohen    Joubu: looking
11:16 tcohen    can anyone dig at the Koha_Master_My8 failure?
11:42 tcohen    happy friday everyone
11:42 tcohen    will be pushing a lot today
11:43 tcohen    please keep an eye on jenkins please
11:46 ashimema  🥳
11:48 cait      fingers crossed
12:00 * cait    waits for the sound of patches being pushed
12:02 Joubu     tcohen, ashimema: 22.11_D11 run the cypress tests - https://jenkins.koha-community.org/job/Koha_22.11_D11/164/console
12:03 Joubu     FYI ES jobs were all wrong, fixed for master and 22.11 now
12:03 Joubu     22.11 jobs are all using the misc4dev:run_tests scripts, lot of things (cypress, PATH, NODE_PATH, etc.) backported into ktd:22.11
12:04 Joubu     tcohen: I've also suggested a patch to trick jenkins when the cypress command is not found - see the related PR
12:04 ashimema  thanks dude 🙂
12:04 Joubu     (I didn't test it actually, we will need to wait for another failure...)
12:09 Joubu     My8 failure is a random one
12:10 Joubu     bug 32648
12:10 huginn    04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 minor, P5 - low, ---, nick, Pushed to stable , Search.t is failing randomly
12:10 Joubu     looks like it didn't work...
12:11 cait      I'll keep fingres crossed... it's getting a little uncomfortable, but the things you do for #koha ;)
12:15 Joubu     tcohen, ashimema: Koha_22.11_D11_OS1 is failing, there is no 22.11/docker-compose.os1.yml
12:15 Joubu     (I let somebody else deal with that)
12:16 Joubu     ashimema: seems like you have hard failures on Koha_22.11_D10/143
12:16 ashimema  Yeah
12:17 ashimema  Judy about to dig on those
12:17 ashimema  22440 related
12:18 ashimema  I have a feeling there's some follow-ups upstream I'm missing
12:18 ashimema  It's been a battle getting back on top of the queue
12:37 caroline  ashimema, thanks! I just wanted to make sure I didn't step on anyone's toes and messed up everything
12:37 caroline  (re needs documenting)
12:37 caroline  I'l just continue as I'm doing now then
13:03 magnuse   caroline++
15:09 reiveune  bye
15:45 tcohen    I need to leave for school drop. CAn anyone look at why Koha_Master is not launching? Is it related to KTD changes of late
15:45 tcohen    thanks in advance
15:45 ashimema  no launching.. oh dear
15:46 ashimema  I'll try to take a look now
15:48 ashimema  hmm.. is it not just that the queue is full
15:48 ashimema  and Docker 3 is offline
15:48 ashimema  the Docker 8 build isn't far off.. I'll watch for that one to complete and hopefully Koha_Master will get picked next
15:51 ashimema  Oh, I see what you mean now
15:51 ashimema  last two failed
17:10 tcohen    back
17:18 tcohen    has anyone tried master?
17:18 tcohen    I've pushed bug 31375
17:18 huginn    04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31375 enhancement, P5 - low, ---, koha-bugs, NEW , Account Expiration Date Auto-updates
17:18 tcohen    no
17:18 tcohen    bug 31735
17:18 huginn    04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 enhancement, P5 - low, ---, glasklas, Pushed to master , Avoid re-fetching objects from database by passing them down instead of object ids
17:18 tcohen    which is awesome but with a big surface area to cover
17:25 ashimema  Not today I'm afraid
17:25 tcohen    np
17:25 ashimema  Been working like mad to try and catch you up
17:25 tcohen    and thanks ashimema for all you do
17:25 tcohen    :-D
17:25 tcohen    ashimema++
17:26 tcohen    Just noting to y'all, that please let me know of any breakages in master