Time Nick Message 21:38 caroline Thanks! I can't guarantee it will be done quick though ;) 21:37 cait caroline: it might work for your interns, i highlighted the test plan in red 21:36 cait also: Bug 19249 21:19 cait trying to keep my QA token :) 21:19 cait it's not super hard to test, but you need to know how to create an order in acq 21:19 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33653 major, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Search for late orders can show received order lines 21:19 cait could we I get a sign-off on bug 33653? 21:02 emlam anyway, time for me to head out. Bye all! 20:58 emlam oh, looks like they may need to apply the 2 patches on it one at a time, though 20:58 emlam no problem :) 20:57 caroline cool thanks! 20:56 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 normal, P5 - low, ---, koha-bugs, Needs Signoff , Reservedate becomes expirationdate in some cases 20:56 emlam I think I found a bug for your interns - bug 32563 has pretty detailed test plans 20:55 caroline yes 20:55 emlam caroline around? 20:19 emlam hi cait! 20:17 * cait waves 19:16 tcohen oleonard: ? 18:54 tcohen \o 18:54 tcohen hey 17:56 oleonard tcohen around? 17:09 cait bye 17:09 cait same 17:08 ashimema Anywho, I need to clock out... Brain is mush 17:08 ashimema For me, my balance is out because I've been trying hard to keep others Devs moving forward and neglecting my own for a few weeks.. it happens 16:38 cait too many rebases, too many devs to look after in parallel 16:35 cait I feel if we are in inbalance with testing/submitting too much it just gets frustrating for everyone 16:32 cait not only pushing, but also please don't throw out new stuff... help take care of what is waiting first 16:32 cait maybe we should have a stop on submitting new stuff for a few weeks (despite bug fixes) 16:32 cait yeah and good things too, I just saw :( 16:30 ashimema I have soooo much that's missed deadlines this cycle :-( 16:29 cait maybe it will be a busier summer, we did have some kind of slowness this winter too 16:29 cait ashimema: yes we did, included lin in QA email twice already ;) 16:25 * ashimema is behind on email too 16:25 ashimema Have we started looking for the next team yet.. I've probably just missed an email.. 16:24 ashimema After release 16:23 ashimema And momentum will drop like a stone for summer 16:10 cait it's the same pain every cycle :) 16:09 caroline sorry! 16:09 cait Now I want to many of those... and we are close to deadline 16:09 cait I shouldn't have looked 16:09 caroline That's actually why my test plan are monstruous... since we get new interns every 4 months, I make them super detailed so they know where to go, what to click, etc 16:09 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132 enhancement, P5 - low, ---, aleisha, Needs Signoff , Add button to clear the cataloguing authority plugin form 16:09 cait bug 31132? 16:09 cait if you leave a comment, i might remember later 16:08 cait I can't write up one right now 16:08 caroline For someone who has never worked in Koha, it's not easy 16:07 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 major, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Cannot merge bibliographic records 16:07 caroline bug 33591 seems straightforward, but no test plan 16:07 caroline that's what I found too hehe 16:07 cait tons of great stuff, but mostly not 'easy to test' 16:06 cait Bug 32335 16:05 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 enhancement, P5 - low, ---, emmi.takkinen, Needs Signoff , Self-checkin module should provide for automatic logins (like self-checkout) 16:05 cait bug 22322 16:03 cait I'll have a look at NSO 16:03 caroline yes they are not at the point of patching yet... we try to have them work in Koha with a goal (a good test plan is necessary) 16:00 cait well 2 bugs actually :) 16:00 cait i filed an easy capitalization and typo one 16:00 cait caroline: do you need a patch too? 15:59 cait emlam++ 15:58 reiveune bye 15:57 cait reading back 15:28 caroline Does anyone have easy signoffs for our new interns who started only yesterday? I'm looking through the Needs signoff list, but if you have suggestions, let me know! 15:05 MarkHofstetter1 thx to all of you, I'll leave and mow the lawn 15:03 Joubu "Signed off" 15:03 Joubu depends on the QA failures, here you are only removing useless code, back to "Signoff" is ok 15:02 MarkHofstetter1 and change the status to "needs sign off" again? 15:02 emlam squashing is mostly only needed if there are many patches for small changes and the commit history is getting messy and hard to follow 15:02 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 enhancement, P5 - low, ---, koha, Failed QA , Optionally add MARC fields to authority search 15:02 Joubu the only problem is that your commit title must start with "Bug 28166: ", which will fail the QA script (which you should have run :D) 15:01 Joubu the first patch has been signed off already, so better to add the changes on the separate patch 15:01 emlam two patchfiles is usually fine, especially if one is a follow-up to QA comments 15:00 MarkHofstetter1 ok, what is recommanded? 15:00 emlam if you wanted them all in the same patch file, you would need to squash the commits into one 15:00 emlam 1 patch = 1 commit 15:00 Joubu what is on the bug is now correct, you have the first patch and the follow-up 15:00 emlam MarkHofstetter1: It looks right to me. If you go to the bug on bugzilla, it now shows two patch files - the one you just changed, which has the Breeding.pm changes, and the original patch, which has the others 14:59 Joubu with or without -e, depends on if you want to edit the status, etc. 14:58 MarkHofstetter1 still only contains the new changes to Breeding.pm (as I would have suspected) 14:56 MarkHofstetter1 witth -e or not? 14:55 Joubu cait: please confirm on 33591 we are talking about the same problem 14:53 Joubu then you attach the 2 commits with `git bz attach 28166 HEAD~2..` 14:53 Joubu to make them different 14:52 Joubu run `git commit --amend` and provide a better commit title for your last one 14:51 MarkHofstetter1 yes 14:50 Joubu (except the commit ids ofc) 14:49 Joubu so `git log --oneline -2` should show you twice the same line? 14:46 MarkHofstetter1 yes 14:44 Joubu with the second(last) commit modifying C4::Breeding only? 14:44 Joubu are they the 2 commits you are trying to attach to the bug? 14:44 Joubu https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150590 14:43 Joubu https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148778 14:43 MarkHofstetter1 and this has nothing to do with the name of the commit 14:43 MarkHofstetter1 but i can't add/commit it 14:43 Joubu git-bz will attach the commit, what you see with git diff is not part of a commit yet 14:42 Joubu and it won't happen 14:42 MarkHofstetter1 because git diff shows the correct differences, put git-bz only takes the one changed file 14:41 Joubu nope you should write better commit titles ;) 14:41 MarkHofstetter1 thx git-bz is weird 14:40 Joubu you should have a follow-up commit with a different commit title 14:39 Joubu MarkHofstetter1: I had a look at your patches. I think what happened is that you attached a patch *with the same title*, and so it automatically obsoleted the existing patch 14:33 Joubu git bz attach BUG_NUMBER HEAD~2.. # To attach the last 2 commits 14:32 Joubu either you amend the patch and you submit it, or you create a separate commit and you attach the 2 patches to the bug 14:32 Joubu MarkHofstetter1: try again, what are you trying to do? 14:29 huginn 04Bug 28166: enhancement, P5 - low, ---, koha, Failed QA , Optionally add MARC fields to authority search 14:29 MarkHofstetter1 hi, I'm working on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166, and only one of the files of the patch needed changes how to add the changes of the other files to the patchfile? (add git-bz rant here) 14:20 ashimema thanks mtj 14:07 cait mtj++ ashimema++ 14:01 mtj hi team... ashimema, ive pushed a new 22.11 pkg 14:00 Joubu tcohen: can you let a comment on the bug please? 13:58 tcohen too many email 13:57 tcohen I didn't notice that bug had submissions to it, on my inbox 13:57 tcohen I need to start removing myself from soem bugs 13:57 tcohen instead of the plain syspref 13:57 tcohen I'd prefer something like enabled: true 13:56 tcohen I like /config/:module_name 13:53 Joubu tcohen: do you agree with the idea? Do you have opinion on ashimema's questions? 13:53 cait generated from items.itemcallnumber and cn_source - it might give you an explanation 13:52 cait items.cn_sort 13:52 cait davewood: maybe start with looking at the db, if it gets too dark in there 13:51 * magnuse hopes davewood brought the machete and the mosquito repellent 13:50 davewood magnuse: I suppose in elastic search (we dont use zebra here) but i just started reading the opac-search.pl code. 13:46 tcohen how do we move it forward? 13:45 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 blocker, P5 - low, ---, jonathan.druart+koha, In Discussion , Access to ERM requires parameters => 'manage_sysprefs' 13:45 Joubu tcohen: we need to move bug 33606 forward 13:42 davewood /cgi-bin/koha/opac-search.pl?idx=&q=*&sort_by=call_number_asc&count=50&limit=location:ArbR 13:23 cait domm: could it be sorting by cn_sort maybe? 13:21 * cait1 waves 13:18 magnuse davewood: where is the sorting done? 12:59 davewood i display items sorted by callnumber and for some reason i get 0010|0010,5|0108|0014 when I expect 0010|0010,5|0014|0108 12:50 Joubu just discovered the existence of the DBIC_TRACE_PROFILE env var that will pretty print the queries 12:36 magnuse it seems like i clicked a bit too many times now, but it worked for 22.11 12:36 magnuse i think 12:36 magnuse 100 works for me 12:25 ashimema it was taking hours and hours to select 50 suggestions to accept wait for painfully unreliable pootle to accept it and move to the next 50 12:24 ashimema I gave up trying to get en-GB to 100% 12:24 ashimema still annoying about them being suggestions 12:24 ashimema that's worth knowing 12:24 ashimema ah, nice 12:24 magnuse after changing 22.11 to 23.05 in those two strings, the po file is accepted when i upload it to pootle. changes are still seen as suggestions 12:23 magnuse :-) 12:22 ashimema not guilty 12:22 magnuse so the wrong version 12:22 magnuse hm, it looks like the 23.05 po files have things like "Project-Id-Version: Koha 22.11\n" and "X-Pootle-Path: /nb/22.11/nb-NO-staff-prog.po\n" 11:59 ashimema tarballs updated 11:57 huginn ashimema: The operation succeeded. 11:57 ashimema @later tell mtj when you come to build 22.11.05 could you build it of the v22.11.05-1 tag.. there's a couple of extra fixes in there that we only caught after I rolled 11:57 huginn ashimema: I suck 11:57 ashimema @later when you come to build 22.11.05 could you build it of the v22.11.05-1 tag.. there's a couple of extra fixes in there that we only caught after I rolled 11:56 ashimema mtj around? 10:36 magnuse sweden has a group working on it 10:36 magnuse i'm the only one doing norwegian now 10:26 cait1 for German we do have some group work 10:26 ashimema how many of our translations end up as group work vs one person doing it all 10:25 magnuse but pootle is slooow (compared to offline) ;-) 10:10 cait1 if you can 10:10 cait1 me neither, but i'd recommend not translating offline right now 10:10 ashimema finally out of meetings for the morning.. one hour to do my whole days work now ☹️ 10:09 ashimema not guilty 10:04 magnuse also i'm trying to upload a .po after translating offline, but nothing happens. they are not even seen as suggestions 10:03 magnuse i was thinking the same thing... 08:44 cait1 but it really stands out, usually it's not a good sign if that happens 08:44 cait1 it is possible it' due to backporting some changes, so the strings were already translated (thinking of page titles/breadcrumbs) 08:43 cait1 more worried 08:42 Joubu sad? :) 08:41 cait1 hm 8.000 (one less zero) 08:41 cait1 about 1.200 new strings for major release - usually it's up to 80000 06:59 cait1 we don't have a lot of stirngs, it's very unusual 06:59 cait1 translating 06:59 cait1 ok thanks 06:58 Joubu we are creating a new agreement, and one of the "Agreement user" entries has an empty "user" 06:57 Joubu cait1: https://snipboard.io/QXFwps.jpg 06:56 alex_ Bonjour 06:56 Joubu It's "Agreement user" 06:50 cait1 is this correct or should it be Agreement %s is missing a user? 06:50 cait1 Agreement user %s is missing a user ? 06:48 Joubu we need a new release however I'd say (ping mtj?) 06:48 Joubu ashimema: I've attached a patch on 33648, cypress tests are all passing on 22.11.x with this patch 06:45 Joubu magnuse: add a sleep? 06:40 magnuse perhaps i should just submit it and say "look at the code" 06:40 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 enhancement, P5 - low, ---, magnus, NEW , Fix use of cronlogaction in process_message_queue.pl 06:40 magnuse fixing bug 33649 is easy enough. to test it properly i need to make lock_exec fail in process_message_queue.pl, but i can't seem to do it. anyone got any tips? i tried commenting out lock_dir and tmp_path in koha-conf.xml but still no failure 06:33 ashimema 😢 06:25 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 normal, P5 - low, ---, jonathan.druart+koha, NEW , Errors when enabling ERM in 22.11 06:25 Joubu ashimema: did you finally release without a fix for bug 33648? 05:54 reiveune hello 04:34 dcook I don't use build-git-snapshot myself, so that's just an educated guess 04:34 dcook Then yeah I'd say outdated basetgz 04:32 aleisha yes it does 04:32 dcook Does it use the build-git-snapshot? 04:32 aleisha ill see if i can update the image, thanks! 04:31 aleisha i 04:31 aleisha it's a gitlab runner 04:31 dcook aleisha: Depending on how you're doing it... sounds like an outdated base image 04:30 aleisha `Can't exec "yarn": No such file or directory at build-resources.PL ` 04:30 aleisha hello, one of my builds is failing and wondering if anyone has seen this error? 03:56 huginn tuxayo: The operation succeeded. 03:56 tuxayo @later tell caroline sorry I can't at all keep up with meetings and their scheduling and wikipages for now :( 03:55 huginn tuxayo: The operation succeeded. 03:55 tuxayo @later tell thd sorry I can't at all keep up with meeting and their scheduling and wikipages for now :( 03:55 huginn tuxayo: The operation succeeded. 03:55 tuxayo @later tell cait sorry I can't at all keep up with meeting and their scheduling and wikipages for now :(