Time  Nick               Message
06:35 reiveune           hello
06:35 marcelr            o/
07:14 marcelr            @later tell cait 30352 is yours
07:14 huginn             marcelr: The operation succeeded.
07:16 cait               giving trainign this and next week - I'll try to do QA as soon as I can
07:28 marcelr            a signoff would be nice too
07:30 magnuse__          anyone know what "Bankable" means, in the context of the point of sale/cash register thingies? ashimema?
07:33 ashimema           cash that can be taken out of the register and taken to the bank
07:34 ashimema           so it's real money as apposed to credit card payments and it excludes the float that's assigned to the register
07:34 ashimema           school run time, brb
07:38 magnuse__          ok, thanks!
08:52 Joubu              I have submitted patches on bug 33568 to replace the items table on the biblio detail page with to make it use the REST API
08:52 huginn             04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Use the REST API to display items on the biblio detail view
08:53 Joubu              catalogue/detail.[pl,tt] are modified significantly, so please it in mind for new submissions
08:53 Joubu              help and feedback welcome!
08:56 ashimema           nice!
08:56 ashimema           I need to focus on some features and enhancements I'm still keen to get into 23.05 I'm afraid.. i've been far too distracted the last months.
09:00 marcelr            ashimema: i am digging a bit into refactor db translations; what are your plans there ?
09:03 ashimema           I have none for the moment
09:03 ashimema           I'll happily lend a hand if asked..
09:03 ashimema           but at this time I'm behind and can't really remember all the details
09:04 * ashimema         needs to get bookings all working again.. so much changed in master that a lot of it is plain broken and we have multiple customers and partners crying out for it
09:04 marcelr            ok
09:05 marcelr            there was a lot of changed ideas during the way on that report..
09:05 marcelr            24975
09:05 ashimema           yeah
09:05 ashimema           we kept refining it
09:05 ashimema           I lost the plot by the end ☚ī¸
09:06 ashimema           jajm and joubu did most of the heavy lifting
09:07 marcelr            yeah and it feels too heavy to me somehow
09:08 marcelr            but maybe i didnt get the whole picture yet
09:09 Joubu              how too heavy?
09:12 marcelr            too many changes
09:12 marcelr            actually we only did this for itemtypes, and we started programming before we got all ideas what we wanted
09:12 ashimema           it's because we were trying to simplify it and make it as flexible as possible I believe
09:13 liliputech         hi koha
09:13 marcelr            o/
09:18 Joubu              marcelr: I don't understand the problem you are trying to raise
09:18 Joubu              we started with somethign simple, itemtypes
09:18 Joubu              then AVs is a bit more complex, so I extended what existed
09:18 Joubu              but discussions appeared, and alternative approaches
09:20 marcelr            the problem is: we got stuck, and I would like to see it move again
09:21 marcelr            so maybe a simpler approach could help?
09:21 ashimema           my memory is that we kept trying to simplify it and that was the challenge.. simplifying lead to complication 😜
09:21 ashimema           but my memory is vague
09:22 Joubu              marcelr: ok then submit a third version :D
09:23 marcelr            thats always the end of the game :)
09:23 Joubu              maybe you have not spent enough time on it yet
09:24 Joubu              and that's why you think it can be simplified
09:24 marcelr            sure
09:24 Joubu              24975 is already the simple version
09:25 ashimema           I was there.. I spent a long time trying to see a simpler way and discussing it with Joubu and jajm.. we simplified it between us as far as we could then got stuck at the last hurdle from memory.. the key construction?  that was the last part of the debate to resolve wasn't it?
09:25 ashimema           it's been ages.. i really can't remember enough ☚ī¸
09:25 Joubu              it's a naive approach, not in the sense that it is bad. It would work, but IMO there are edge cases, see the comment I pointed you to yesterday
09:28 marcelr            where is that comment?
09:28 Joubu              at this point I guess the sync between us (on it at the time) is the key, because I guess the rebase won't be trivial and it will be again a lot energy to put there
09:28 ashimema           agreed
09:29 ashimema           that's why I said we need to get at least the three of us in a room and lock the door until we come out with a solution 😜
09:29 Joubu              same I gave you yesterday - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975#c16
09:29 huginn             04Bug 24975: enhancement, P5 - low, ---, julian.maurice, Patch doesn't apply , Refactor database translations
09:29 ashimema           it was on my hackfest list.. but there was already a lot on that list 😜
09:32 marcelr            yeah i understand that is an example of the whole discussion about going via key or description
09:32 marcelr            Books or BK2
09:42 Joubu              marcelr, ashimema: do you have a rebased version, or the patches on the bug are the most recent ones?
09:43 marcelr            it seems there is no
09:45 ashimema           I tihnk the bug is probably the most recent work
09:46 ashimema           On branch bug_24975... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/ZPRmKxeIUrBmwncLWFKIXtuA>)
09:46 ashimema           that's the branch I have
09:47 Joubu              ok, I will try to rebase it
09:47 ashimema           do you have a branch to rebase on.. or are you trying to apply the patches and fix on apply?
09:47 ashimema           I can push that branch if it helps.. it's probably cloned on gitlab/github already
09:48 Joubu              I will be using your branch
09:48 Joubu              there is a "lost" patch on the bug, the first one "fix bug"
09:50 ashimema           https://github.com/PTFS-Europe/koha/tree/bug_24975
09:51 ashimema           our master on github is behind btw.. that's why the numbers are different.. my local tracks upstream properly and I read those numbers from the local
09:53 Joubu              ok, on it
09:59 marcelr            brb
09:59 Joubu              I wish I would not need to spend time to rebase stuffs I already spent a lot of time 4 years ago... :D
10:46 ashimema           marcelr
10:46 ashimema           I've lost track a bit on DB consistency
11:32 marcelr            o/
11:33 ashimema           the final bug on 31028.. is it actually needed
11:33 ashimema           you seem to have added a catch for such statements in another bug
11:33 ashimema           which has been pushed since
11:33 ashimema           I think it's still a good cleanup
11:51 ashimema           Joubu still around?
11:54 Joubu              yes
12:47 anpu26[m]          Hello
12:48 anpu26[m]          I have a question, what about the new RDA Marc field(336,337,338) Koha automatically add those or I need to edit the cataloging frameworks and add those fields and subfields?
12:49 marcelr            Joubu: will have a try on 24975; hope that I like what I see :)
12:53 Josephu            Hello, I
13:05 marcelr            Joubu: main form does not load; 500 errror with DataTables
13:07 Joubu              main form?
13:08 marcelr            admin/localization
13:08 Joubu              works for me
13:09 Joubu              what error do you get?
13:10 marcelr            cache problem
13:11 marcelr            resolved
13:12 Joubu              marcelr: regarding the last patch - I think we should clean all the item types code, in pl and tt. The mix between db_t calls and ItemTypes.t() TT plugin is confusing
13:13 Joubu              I haven't finished, I think I am introducing perf regression. We should do that better. The Koha::ItemTypes set could be unblessed (with the translation_key in it) and cache in the TT plugin
13:14 Joubu              then we always send the code to the template (or the translation_key?)
13:14 marcelr            yes, how to cache is an interesting topic
13:15 Joubu              the strings are cached in L1, in the I18N module
13:15 Joubu              but here I am talking about caching the Itemtype objects
13:15 marcelr            yes thats interesting
13:15 Joubu              image_url could then be cached as well
13:16 Joubu              could even be in L2 actually, it's easy to clear
13:17 Joubu              to preserve my mental health I need to stay away of this topic for today, I may have a look at that again tomorrow
13:18 Joubu              let me know if you catch 500s!
13:25 marcelr            ok
13:32 magnuse            did someone say pootle was updated with new files? or did i dream it? cait?
13:32 ashimema           cait did
13:32 ashimema           but not for 22.11
13:32 magnuse            ah, ok
13:33 ashimema           not sure why though
13:33 caroline           I received an email yesterday though
13:33 caroline           from Jacob
13:33 ashimema           yeah.. we announced last night
13:33 ashimema           I have no idea what actually triggers bernardo to build them
13:33 caroline           not sure either
13:35 caroline           this maybe? https://wiki.koha-community.org/wiki/Release_maintenance#Request_the_URL_of_the_form_that_prepares_the_translations_for_the_release
13:36 magnuse            the announcement was string freeze, not new files on pootle?
13:36 ashimema           correct
13:36 caroline           It's usually the same though no?
13:36 ashimema           nope
13:37 ashimema           that url is when we grab the translated po files and merge them
13:37 ashimema           not when pootle grabs the latest strings
13:37 caroline           oh ok
13:37 ashimema           as for announce.. I've never totally tied it all together
13:37 ashimema           we announce when we're ready.. as if by magic the strings get updated some time
13:38 caroline           cait and I have had trouble getting in touch with bernardo for the 22.11 manual too
13:38 magnuse            ah magic, that explains it ;-)
13:38 caroline           lol!
13:38 ashimema           I've been trying to wrap my head around i for literally years..
13:38 ashimema           there are so many issues with our translations workflow that need fixing
13:41 magnuse            i think string freeze means no more patches that affect strings are accepted? then po files should be updated from the code and pootle should be updated, so there is time for translating before the release? but not sure how things *actually* work...
13:42 magnuse            but now i have some moules to frit :-)
13:45 ashimema           exactly magnuse
13:45 ashimema           that how it all should work
13:49 tcohen             hi all
13:49 marcelr            o/
13:49 tcohen             hola marcelr
13:49 tcohen             mtj: have you tried koha-dpkg-docker? we are having an issue with 22.11 builds
13:50 tcohen             the command is: docker run --volume=/home/tcohen/git/koha:/koha --volume=/home/tcohen/tmp/debs:/debs --volume /proc:/proc --privileged --env VERSION="22.11.04" --env RELEASE="22.11" koha/koha-dpkg:master
14:10 cait               sorry, not really here today, if it was something important please repeat :)
14:44 kohaio[m]          Hello there !
14:45 cait               hi kohaio
14:47 kohaio[m]          We're currently migrating our OPAC solution to KOHA, and i'm a bit stuck with the API usage. Is someone familiar with the koha api endpoints?
14:47 cait               if you ask a more specific question someone might jump in
14:47 cait               (not me probably... but maybe)
14:48 kohaio[m]          :)
14:49 kohaio[m]          I'm trying to use the items api endpoint so that we can search in the KOHA library from another solution, but the expected params are pretty unclear to me
14:49 kohaio[m]          especially the q (query) one, not sure about the format expected
14:50 cait               tcohen: paulderscheid[m] kidclamp maybe?
14:51 paulderscheid[m]   The query param is pretty well explained here
14:51 paulderscheid[m]   https://api.koha-community.org/ kohaio
14:51 cait               there is al little bit here, but no example I think; https://api.koha-community.org/#section/Filtering-responses
14:51 cait               ah sorry, there is one :)
14:51 paulderscheid[m]   What exactly are you trying to achieve kohaio ?
14:52 kohaio[m]          i have tried, based on the documentation but it keep returning some "malformated query string"
14:52 kidclamp           https://wiki.koha-community.org/wiki/Koha_REST_API_Users_Guide
14:52 paulderscheid[m]   What's your query?
14:52 kohaio[m]          not sure how to build properly the array format expected :D
14:52 paulderscheid[m]   Can you give us an example you tried?
14:53 kohaio[m]          sure, for example this one : /api/v1/items?q[field]=title&q[value]=xxx&q[type]=contains&_per_page=10&_order_by=relevance&fields=id,title,author
14:53 cait               it#s not working like the OPAC
14:53 kohaio[m]          also tried with q[0][field]=title
14:54 paulderscheid[m]   You have to restructure that like a JSON object.
14:54 cait               i mean the relevenace sorting
14:55 kohaio[m]          also tried using body json format, but still stuck, do you have a simple example of expected json structure?
14:55 paulderscheid[m]   No, in the query itself
14:55 * paulderscheid[m] sent a code block: https://matrix.org/_matrix/media/v3/download/matrix.org/wFWpoRArSbVAwuiBKhCtbZfX
14:56 paulderscheid[m]   * ````... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/jJYKaOYyPolPFBRvpubqMSst>)
14:57 paulderscheid[m]   or... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/SpqaoyLucvFoTkInnZDjKAkI>)
14:58 paulderscheid[m]   Although I think the "type":"contains" doesn't belong in there
15:00 kohaio[m]          Thanks Paul for your proposals, i have tried the two solutions from the URL parameters and using raw json but it gives me an error, but that should be something like that :)
15:01 paulderscheid[m]   Yeah, sorry I just blindly converted it
15:05 paulderscheid[m]   Here's a super simple example for an OR query... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/LizEJwCkFzBbpANNwgwidvHf>)
15:05 paulderscheid[m]   I have to relearn this every time I use it ^^
15:08 paulderscheid[m]   And of course you can also use that in the request body
15:09 kohaio[m]          Thanks for your clear example :) I'll try in the body to see i can go with more complicated ones :)
15:09 paulderscheid[m]   Always happy to help.
15:10 paulderscheid[m]   and spread fake news sometimes :D
15:10 kohaio[m]          :D
15:18 reiveune           bye
15:19 tcohen             paulderscheid[m]: did you make any progress with the q_ccl bug?
15:19 tcohen             that would make the endpoint more useful
15:20 paulderscheid[m]   I had no time to work on it so caroline  and her devs took over
15:20 caroline           tcohen, hammat tried but I think he had questions
15:20 caroline           https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870#c34
15:20 huginn             04Bug 25870: enhancement, P5 - low, ---, paul.derscheid, ASSIGNED , Add a q_ccl query parameter to /biblios
15:24 tcohen             Joubu: do you know why Selenium auth is fragile?
15:24 tcohen             what breaks it
15:42 cait               tcohen: and I put it in the QA email this week that Hammat had questions...
15:43 cait               just noone has replied to his questions yet I think?
15:47 tcohen             cait: see? I asked about selenium and got no answer either
15:48 cait               true true..
15:48 cait               but I don't know the answer
16:06 liliputech         bye
16:11 ashimema           cait
16:11 ashimema           bug 33574 has a patch now
16:11 huginn             04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 major, P5 - low, ---, martin.renvoize, Needs Signoff , Restriction type is not stored, all restrictions fall back to MANUAL
16:14 oleonard           tcohen++
16:35 Nathan             Hi. We're planning on setting up Koha on cloud based server. What cloud based server provider is recommendable?
17:58 paulderscheid[m]   Depends where your live Nathan
17:59 paulderscheid[m]   s/your/you/
18:08 caroline           cait are you around?
18:49 cait               kind of
18:49 cait               caroline:
18:50 caroline           cait, it's not urgent... I was just wondering how you handled translations when stuff is added in database updates
18:51 caroline           The installation file is translated, but if something is put directly in the DB, it doesn't go through the installation file
18:56 cait               what we do is run an sQL script with updates
18:57 cait               so I translate these and then we run our own SQL statements after Koha is done with the update
18:57 cait               not integrated into the web installer just as an additional step to our upgrade process
18:58 cait               at least for the one s that will appear as changes directly after update - for features libraries need to activate separately we can still fix later
19:01 caroline           ok thanks... I'm going through all the dv_revs right now to find all the letters, authorized values, etc. and adding them to a separate sql file
19:01 caroline           it's the first time I do this, we usually catch them afterwards when clients complain
20:12 cait               caroline: I like to avoid the compaints when I can :)
20:18 caroline           definitely a better course of action :)
22:21 Nathan             I'm in the Philippines Paul
23:00 aleisha            hello
23:52 thomas63[m]        hi there... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/VDguguzaYCRXyQIJCpNaXJxA>)