Time Nick Message
06:00 reiveune hello
07:00 magnuse \o/
07:04 liliputech hi koha
07:35 tuxayo mtj around? I think you had ideas about the naming scheme of opensearch in koha-elasticsearch-icu
07:35 tuxayo so can you check this? https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/merge_requests/6
07:35 tuxayo To see if the proposal is okay
07:38 mtj hi tuxayo, perhaps we make a new koha-opensearchsearch-icu repo?
07:38 mtj hi tuxayo, perhaps we make a new koha-opensearch-icu repo?
07:40 Joubu PedroAmorim[m]: first thing for this morning, have a look at bug 32807 follow-up please
07:40 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , No need to fetch all if we need to know if one exist
07:41 Joubu tcohen: ^^ that fixes the cypress teste
07:41 tuxayo mtj: https://ilbot3.kohaaloha.com/koha/2022-09-02#i_2321174
07:41 Joubu tests*
07:42 tuxayo mtj: I don't know if we have more benefits in creating a new project compared to last september
07:43 fridolin hi there, I'd like some feedbacks on Bug 33334
07:43 mtj agree
07:43 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33334 enhancement, P5 - low, ---, koha-bugs, NEW , koha-worker.service need update for background job queues
07:45 tuxayo mtj: ok so same project. How about 7.x-os => opensearch-1.x for the branch and thus docker image name?
07:45 tuxayo I couldn't find the past discussion about that
07:50 mtj tuxayo: looks good to me :)
07:54 mtj tuxayo: do you need me to do anything else, to make change happen?
07:54 tuxayo mtj: thanks! Do you have the rights to create a branch on the repo? Or should I get someone else at hackfest
07:57 aude_c Hello! For Koha Documentation, it's all at https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual
07:58 aude_c Today for screenshots we're going to use this https://wiki.koha-community.org/wiki/Koha_Manual_Screenshot_Update_Extravaganza_2023
07:58 aude_c Sorry, sending this again https://wiki.koha-community.org/wiki/Koha_Manual_Screenshot_Update_Extravaganza_2023
07:59 mtj hi fridolin: re: 33334 - are you going to upload a patch?
08:00 fridolin mtj: i first need to discuss solutions
08:00 fridolin i change bug status
08:01 fridolin Bug 33334 chagned
08:01 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33334 enhancement, P5 - low, ---, koha-bugs, In Discussion , koha-worker.service need update for background job queues
08:01 aude_c For documentation: here is the development version of the manual https://koha-community.org/manual/23.05/en/html/index.html
08:04 fridolin Bug 21330 back on tracks
08:04 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 enhancement, P5 - low, ---, fridolin.somers, Needs Signoff , Add XSLT for authority detail page in OPAC
08:11 tuxayo kidclamp: "opensearch-1.x" and "opensearch-2.x"
08:18 tuxayo mtj: branches are done, can you merge https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/merge_requests/6 and https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/merge_requests/7 ?
08:18 tuxayo kidclamp++
08:32 tuxayo mtj++
08:37 aude_c Koha manual on GitLab https://gitlab.com/koha-community/koha-manual
08:38 ashimema aude_c++
08:38 ashimema loving seeing the docs group working here.. go documentation! 🙂
08:38 ashimema I merged your submission aude_c
08:56 fridolin Bug 32127 back on tracks
08:56 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 normal, P5 - low, ---, fridolin.somers, Needs Signoff , Sort patron categories by description in templates
09:00 fridolin More important is Bug 33300
09:00 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 major, P5 - low, ---, fridolin.somers, Needs Signoff , Wrong system preference name AutomaticWrongTransfer
09:04 fridolin nearly midnight here, have fun, see u tomorrow
09:18 aude_c Koha Doc images to delete https://mensuel.framapad.org/p/hackfest29mar-a03l?lang=en
10:21 astyles Hi All, quick question, IF I am serching tickets to sign off and the last update for a ticket is 2013, can I safely assume it a zombie?
10:22 astyles Is there on occasional a process where super old tickets with no recent traction are removed annualy?
10:25 astyles All good I will trawl docs. Have a good one 8-)
10:39 oleonard Hi #koha
10:54 tuxayo astyles: hi :) Maybe (likely) it's a zombie or maybe not. First try to apply the patch to not waste time on the beginning of the test plan only to in the middle give up because the patch conflicts
10:58 astyles Hi All I was thinking on submitting a patch to enhance log view output naming conventions, as this is my third patch to date, to you suggest I would need to create a sys pref as a general rule? or perhaps an additional tick box to enable added data in file output? thanks
10:59 oleonard astyles: A good first step might be to ask for opinions on the bug report, describing what you want to do
10:59 astyles ok cool, so hold off on patch and simply imply output change
11:00 astyles create new feature ticket and ask for feedback essentially?
11:00 oleonard Yes
11:00 tuxayo +1
11:00 astyles cool thanks will do
11:00 oleonard You can attach a patch if you already have one, asking for feedback, but it's not a necessary first step
11:03 astyles hmm well I have created in local branch, so I might attach to assist in understanding my feature. 8-)
11:03 oleonard astyles did you see tuxayo's answer to your question about zombie tickets?
11:04 astyles ahh I was using different irc client before, so missed it.
11:04 oleonard "<tuxayo> astyles: hi 😊 Maybe (likely) it's a zombie or maybe not. First try to apply the patch to not waste time on the beginning of the test plan only to in the middle give up because the patch conflicts"
11:05 astyles thanks
11:05 astyles cool so IF patch does not apply then perhaps it's no longer relevant to code base?
11:06 oleonard If the change is appealing you can either ask for it to be rebased in a comment on the bug or try to rebase it yourself if you're feeling motivated
11:07 astyles good to know. thanks
11:10 tuxayo astyles: if the bug is relevant for you, you can try to reproduce it
11:11 tuxayo astyles: Because yes the patch might not be relevant. Either the bug doesn't happen anymore or the fix now has to be fundamentally different.
11:12 astyles In my case I was wondering if there is a clear flag or filer I can use to identify tickets that have 'needs sign off' etc but are still revelvant to current stack/
11:13 astyles I suppose I can use common sense for older tickets 8-)
11:13 tuxayo It's still good to get them out of the queue
11:14 tuxayo And checking if the patch still applies to the code is quick. If so, I would say that it's likely that the patch is still relevant.
11:17 astyles 8-)
11:19 tuxayo mtj tcohen do you know what should be done on the koha-elasticsearch-icu to have an image built after a new branch was added to the repo?
11:21 mtj hi tuxayo, have a look at https://gitlab.com/mjames/koha-elasticsearch-icu-arm-64
11:21 mtj https://gitlab.com/mjames/koha-elasticsearch-icu-arm-64/-/blob/master/.gitlab-ci.yml
11:22 mtj https://gitlab.com/mjames/koha-elasticsearch-icu-arm-64/-/jobs/2888972707
11:23 mtj aah oops, wrong branch
11:23 mtj https://gitlab.com/mjames/koha-elasticsearch-icu-arm-64/-/commits/7.x-arm64
11:25 mtj https://gitlab.com/mjames/koha-elasticsearch-icu-arm-64/-/blob/7.x-os/.gitlab-ci.yml
11:26 mtj aah, the .gitlab-ci.yml files need to be updated, for the OS branches
11:29 oleonard astyles: RESOLVED - FIXED would be for bugs which aren't relevant anymore because the issue has been corrected elsewhere, RESOLVED -WONTFIX would be if the bug isn't relevant for some other reason. However, WONTFIX is a subjective call and should probably be avoided for those who aren't QA Team or Topic experts.
11:29 mtj tuxayo: 1 tic, i can fix
11:40 marcelr o/
11:43 tuxayo hi marcelr :)
11:44 tuxayo mtj: I have internet again, I can submit a patch for opensearch if you want
11:44 tuxayo Or I do 2.x while you do 1.X if you haven't do yet
11:45 tuxayo ok you did opensearch-1.x
11:46 tuxayo It's not clear why the build failed: https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/jobs/4023065982#L108
11:46 tuxayo Meanwhile I'm submitting a patch for 2.x
11:54 oleonard magnuse++
11:55 tuxayo mtj: MR here: https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/merge_requests/8
12:09 mtj tuxayo: thanks
12:10 mtj tcohen: can you take a look at the failing build, i dont have 'settings' access ^
12:11 tcohen which build?
12:11 tcohen marcelr++
12:11 tcohen Joubu++
12:11 tcohen PedroAmorim[m]++
12:11 tcohen kidclamp++
12:11 tcohen cait++
12:11 tcohen ashimema++
12:11 magnuse tcohen++
12:11 mtj https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/jobs/4023065982#L108
12:12 tcohen magnuse++
12:12 * mtj hasnt used a $PATOKEN before
12:13 tcohen that's a variable that is set at the organization level
12:13 tcohen and is only available for protected branches
12:14 tcohen that not many people should be able to set
12:14 tcohen because it could leak credentials
12:14 tcohen PATOKEN is a credential in a variable
12:14 tcohen so
12:14 tcohen I marked the opensearch-1.x branch as protected
12:14 tcohen and relaunched the pipeline
12:14 tcohen crossing fingers
12:16 mtj ah yep, thats the fix ^ :)
12:19 mtj tcohen: can you do the same for opensearch-2.x branch too, pweese?
12:19 tcohen did already :-D
12:19 tcohen but after you pushed
12:20 tcohen so you will need to relaunch
12:38 tkero[m] https://zenodo.org/record/7559159
12:39 tkero[m] Le travail d'Étienne Cavalié: https://zenodo.org/record/7642548
12:43 ashimema @later tell caroline I added aude to the people who can merge docs so she could manage the images group here.
12:43 huginn ashimema: The operation succeeded.
12:53 caroline good morning!
12:54 caroline not sure if hackfest ppl are around but THANK YOU for the screenshots!
12:59 oleonard Hi caroline
12:59 caroline Hi oleonard!
13:10 magnuse yay for bug 32426!
13:10 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426 new feature, P5 - low, ---, m.de.rooy, Pushed to master , Make userid generation pluggable
13:11 magnuse caroline: we are around :-)
13:11 ashimema hola
13:11 ashimema aude ran a great session caroline
13:11 caroline audec++++
13:13 marcelr hi caroline did you see my comment/follow-up on the xslt syspref description report
13:13 marcelr ?
13:13 marcelr OpacResultsMax etc
13:15 caroline I had 100+ emails in my inbox this morning (I've been training out the office), but I'll get to it
13:20 caroline marcelr, the diff looks good to me, I'll sign off
13:20 caroline thanks for taking a look at it
13:26 tuxayo mtj++
13:26 tuxayo tcohen++
13:26 tuxayo We have not OpenSearch 2.x images (and 1.x with a clearer name et version)
13:26 tuxayo ^^
13:26 tuxayo *we have now
13:28 marcelr ok caroline++ thx
13:35 tuxayo Has anyone got when starting KTD "error: could not lock config file /var/lib/koha/kohadev/.gitconfig: Permission denied"
13:35 tuxayo last images, up to date koha and ktd code, chown done on koha and ktd code to ensure permissions are good
13:35 tuxayo No more ideas
13:54 tuxayo it starts if I start also opensearch (elasticsearch) with it, how???!
13:54 tuxayo I'm getting trolled
13:57 tuxayo ok, I think what did it was that in the meantime I ran "docker system prune --volumes"
13:57 tuxayo It removes
13:57 tuxayo - all stopped containers
13:57 tuxayo - all networks not used by at least one container
13:57 tuxayo - all volumes not used by at least one container
13:57 tuxayo - all dangling images
13:57 tuxayo - all dangling build cache
13:58 tuxayo It still makes no sense in how that helps. 🤷
13:59 tuxayo (warning, to use this command, if you use docker to other things than koha, you need to know what you are doing because you can loose persistent data)
14:00 tuxayo It might also be bad when using koha persistence
14:08 marcelr tuxayo: removing volumes is exciting at least :)
14:12 tuxayo Just need to be sure they are the right one :)
14:12 tuxayo But otherwise it's needed, each start of ktd, it creates a new 130 MiB volume if I recall correctly
14:15 marie-luce Did someone record aude documentation session?
14:15 marie-luce I've be curious to watch it and learn.
14:17 tuxayo aude_c ↑↑↑
14:20 tuxayo mtj: still have the same opinion on this? https://ilbot3.kohaaloha.com/koha/2022-11-28#i_2337481
14:25 tuxayo tcohen or Joubu or mtj: MR to add OpenSearch 2 to ktd :) https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/423
14:25 tuxayo So we can test it alongside ES 8
14:26 tuxayo jajm: when starting KTD, with OpenSearch 2.x, I get "Can't use string ("no handler found for uri [/koha_"...) as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 281."
14:27 tuxayo I don't know if you have something similar with ES 8. Likely not since the projects diverged and ES license doesn't allow OpenSearch to backport changes.
14:30 jajm tuxayo: this is exactly the same error with ES 8, have you tried with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 ?
14:30 huginn 04Bug 33353: enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add compatibility with Elasticsearch 8
14:33 tuxayo jajm: ok, I'll try, maybe it something deprecated in ES 7.x so both ES 8 and OS 2 removed it.
14:37 tuxayo jajm: it starts and search works :)
14:37 tuxayo I'll restart with ES8 and see the other steps for signoff
14:38 jajm \o/
14:42 marcelr it is a value_builder party
14:47 tuxayo jes lol
14:48 tuxayo jajm: here are all the automated test that seem relevant to ES and OS: https://wtf.roflcopter.fr/paste/?4b5fe820b4a04b0f#36fQ5mHxfGDj2X65v8ZqRBqjiyEUH2biyhN9ZxMZ6Fw6
14:49 tuxayo with ES8 and you patch, all pass but with on warning
14:50 magnuse does anyone have overdrive credentials to test bug 32995? i don't, but i could sign it off as "looks harmless"
14:50 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 normal, P5 - low, ---, nick, Needs Signoff , Koha agent string not sent for OverDrive fulfillment requests
15:22 reiveune bye
16:41 ashimema Sorry, I ended up overwhelmed today oleonard. Will try to catch you for a chat around style guide tomorrow
16:46 oleonard No problem ashimema, I've been in and out myself all morning