Time Nick Message 18:00 caroline biblibre's is giving me 503 error... the universe does not want me to have a sandbox lol! 17:59 caroline Have a good weekend! 17:59 caroline oop sorry! 17:59 ashimema Will take another look on Monday . I've clocked out for the weekend now 17:55 caroline ashimema ^^ problem with the sandbox system? 17:54 caroline ok, good to know I'm not going crazy... I feel like I'm only working with half a brain these days 17:54 oleonard Biblibre's worked: https://sandboxes.biblibre.eu/ 17:54 oleonard-away caroline: I found the same thing when I tried it a couple of days ago. 17:52 caroline It just brings me back to the sandbox page 17:52 caroline I don't use sandboxes that often, but I fell like I'm hallucinating... Does anyone have access to http://staff-caroline.sandboxes.ptfs-europe.co.uk/ ? 17:17 reiveune bye 17:04 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 enhancement, P5 - low, ---, tomascohen, Signed Off , Add Koha::Suggestions->search_limited 17:04 ashimema damn it.. bug 29886 just keeps making me ask more questions. 16:54 ashimema enjoy 16:49 Joubu weekend time for me, see you on Monday ;) 16:44 ashimema oh yeah.. it is still missing Mojo::JWT 16:41 ashimema just trying to start again and watching the logs in more detail this time 16:41 Joubu :) 16:41 Joubu 28 use Koha::SearchEngine::Elasticsearch; 16:41 ashimema now it appears to be the populate_db stuff 16:41 Joubu what's the real error? 16:40 ashimema I saw that initially.. but I pulled and pruned 16:40 Joubu Mojo::JWT? 16:39 ashimema yup 16:39 Joubu maybe you are missing the new dep 16:39 Joubu ashimema: did you pull? 16:38 ashimema BEGIN failed--compilation aborted at /kohadevbox/misc4dev/populate_db.pl line 28 16:38 ashimema anyone else having issues starting k-t-d? 16:38 ashimema hmm 16:24 ashimema cait1 around 15:56 Brooke o/ 15:41 Joubu that should work, yes 15:37 * ashimema is trying to understand the code in the library limits base class now 15:37 ashimema we have search_with_library_limits in Koha::Objects::Limit::Library.. could we add a search_with_patron_limits in a new Koha::Objects::Limit::Patron base class? 15:36 ashimema instead of adding search_limited subs all over the place 15:36 ashimema the other half is whether we should be adding a new base class like we have for library limits 15:36 ashimema wording is half of it 15:36 ashimema nope 15:35 Joubu is the question about wording only? 15:35 Joubu yes, could be anything better than "search_limited" 15:31 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 enhancement, P5 - low, ---, tomascohen, Signed Off , Add Koha::Suggestions->search_limited 15:31 ashimema and one getting added to Suggestions.pm in bug 29886 15:31 ashimema one in Patrons.pm, Reviews.pm and ArticleRequests.pm so far.. 15:30 ashimema Joubu ^ 15:30 ashimema these search_limited methods we're introducing to a few Koha::Plural objects.. should they be search_with_patron_limits or something.. and should they be another Koha::Objects::Limits:: parent class instead? 15:23 cait1 good :) 15:21 ashimema it's up there with my thinking 15:21 ashimema yup 15:20 cait1 please keep in mind coding guidelines and such... thinking of new devs learning the ways we do things 15:02 ashimema magic 15:02 ashimema haha 15:02 Joubu it just knows 15:01 ashimema oh.. is it this stuff: http://www.template-toolkit.org/docs/manual/VMethods.html#section_Automagic_Promotion_of_Scalar_to_List_for_Virtual_Methods 15:01 ashimema Joubu.. can you remember how tt knows to iterate our scalar resultsets?.. i.e. why/how we don't have to switch out [% FOREACH thing IN things %] for [% WHILE ( thing = things.next ) %] 14:43 Joubu and thanks :) 14:43 ashimema okies 🙂 14:42 Joubu please do 14:42 ashimema I'm happy to do the get_columns fix as a follow-up here whilst I QA if you like.. or would you prefer to fix it ? 14:41 Joubu I didn't think about anything when I wrote that patch, just not to introduce regressions :) 14:40 ashimema it won't work in all cases of course.. but for the simple one's it might be a nice little thing 14:40 ashimema what did you think about using the first iteration of the iterator to set up the boilerplate stuff instead of calling a count then iterator like we do now? 14:40 ashimema I like iterators 14:39 ashimema hard call 14:39 ashimema yeah 14:38 Joubu of perf* 14:38 Joubu negligible* 14:38 Joubu certainly longer than having the count in a variable, but it should be negligeable in term of erf 14:37 Joubu The result should be cached at DBMS level anyway, I am not expecting to have a direct DB access 14:37 Joubu maybe it's wrong 14:36 Joubu ashimema: Yes, I don't know. Tomas noted that on another bug as well. I've always prefered iterator over the full list 14:31 huginn Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Favor iterators over as_list 14:31 ashimema Joubu, I just reviewed bug 29859.. one minor typo fix needed and a question regards performance thoughts for you 14:31 ashimema making developers lives easier long term.. and reducing likelyhood of bugs 14:31 ashimema code tidying cait1 14:27 cait1 i need some happy 14:27 cait1 waht are we happy about? :) 14:22 ashimema but otherwise it's looking good 14:21 ashimema found one typo so far 14:21 ashimema just reviewing the 'Use iterator' bug now 14:21 ashimema so nice to see this stuff happening 🙂 14:20 Joubu khall, ashimema, tcohen: thanks! <3 12:22 magnuse tcohen: :-) 12:15 tcohen magnuse: YAY! 12:15 tcohen hola #koha 11:55 magnuse \o/ 11:55 magnuse ooh, we passed 30000 bugs 11:12 oleonard o/ 08:24 koha-jenkins Project Koha_Master_D9 build #1866: SUCCESS in 1 hr 14 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1866/ 07:55 reiveune hello 07:54 alex_a Bonjour 07:53 koha-jenkins Project Koha_Master_D10 build #522: SUCCESS in 41 min: https://jenkins.koha-community.org/job/Koha_Master_D10/522/ 07:23 koha-jenkins Project Koha_Master build #1904: FAILURE in 8 min 43 sec: https://jenkins.koha-community.org/job/Koha_Master/1904/ 07:14 koha-jenkins Project Koha_Master_U21 build #80: FAILURE in 6 min 34 sec: https://jenkins.koha-community.org/job/Koha_Master_U21/80/ 07:13 koha-jenkins Project Koha_Master_U20 build #294: FAILURE in 3 min 12 sec: https://jenkins.koha-community.org/job/Koha_Master_U20/294/ 07:12 koha-jenkins Project Koha_Master_D11_My8 build #739: FAILURE in 4 min 15 sec: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/739/ 07:11 koha-jenkins Project Koha_Master_D11_CPAN build #524: FAILURE in 3 min 15 sec: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/524/ 07:10 koha-jenkins Project Koha_Master_U_Stable build #370: FAILURE in 3 min 29 sec: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/370/ 07:10 koha-jenkins Project Koha_Master_D11_MDB_Latest build #786: FAILURE in 4 min 2 sec: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/786/ 07:06 huginn News from kohagit: Bug 28735: Self-checkout users can access opac-user.pl for sco user when not using... <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2e5d59d902be82cebd80d016eefaac531f8c118e> 07:06 huginn News from kohagit: Bug 29540: Raise flagsrequired in modrequest <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b8088051e9fb56ec0fbab0decf912f6f0fb29926> 07:06 huginn News from kohagit: Bug 29544: Ensure logged in user is allowed to modify checkout note <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=e4a402cd50b2f118ec2d7917d39b7310d5c0f1a5> 07:06 huginn News from kohagit: Bug 29541: Restrict access to patron's image to borrowers => * and circulate => * <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=7f50439cb2cf7d9a6d84e49eaf1cd8330b0995f0> 07:06 huginn News from kohagit: Bug 29544: Fix opac-issue-note.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c967a4e9c2b3a29047fd56c43257b4e0bf2b5e07> 07:06 huginn News from kohagit: Bug 29541: Prevent users from another group to access patron's images <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2c3a11f138247c53df306667f421857ef2a3977a> 07:06 huginn News from kohagit: Bug 29543: Enforce authentication for self-checkout <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=78815e97774a101f1108950249ff10ba3a3f9898> 07:06 huginn News from kohagit: Bug 29543: Prevent user to checkin or renew items they don't own <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b80fda78d9d5affe3b9beb4ede49d5ab4e73cf38> 07:06 huginn News from kohagit: Bug 29542: Prevent access to private list to non authorized users <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ef85122b1dad86637b652460ee898f6cc2931669> 07:06 huginn News from kohagit: Bug 29543: (follow-up) Add a warning to SelfCheckoutByLogin <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b11619cb52976ac49db524adc60c229a46e13e78> 07:06 huginn News from kohagit: Bug 29543: Add Mojo::JWT dependency <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8336634aa14e76a4390fd5e01419a5bbe73c5279> 07:06 huginn News from kohagit: Bug 29543: Set autocomplete off for SCO login fields <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c55d2a205c75186520d562884dcef378d4a695b6> 07:06 huginn News from kohagit: Bug 29544: (QA follow-up) Simplify code <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=09e02476773c181fcd4009f59c19c7ac1f46d775> 07:06 huginn News from kohagit: Bug 29903: Prevent messages to be deleted from unauthorised users <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=dd4800f08d688de940f61d50085ff178992f0628> 07:06 huginn News from kohagit: Bug 29914: Make check_cookie_auth compare the userid <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=95097d1cc2752715fea099940face25949d3b204> 07:06 huginn News from kohagit: Bug 29914: Add tests <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=408b7164c3c468ebafda6763253b06b403faf707> 07:06 huginn News from kohagit: Bug 29914: (QA follow-up) Remove warn on timeout <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=939ccaf5c48cd3d4d0886e9b2feef8ecb9e6af91> 07:06 huginn News from kohagit: Bug 29914: (QA follow-up) Expand tests to cover failure case before patches <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b3d8cb6ff736a209e67773b6dc24661103b4ea4a> 07:06 huginn News from kohagit: Bug 29914: (QA follow-up) Add comment to explain last case <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=393efc7b736add1534e4b3cc90784eb2891be2b5> 07:06 huginn News from kohagit: Bug 29914: Remove 'Use of uninitialized value ' warnings <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=ecd4b91334a6e9b125bb8ed72f6ac0f307a148d8> 05:26 koha-jenkins Project Koha_Master build #1903: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community.org/job/Koha_Master/1903/ 04:17 koha-jenkins Project Koha_19.11_U16 build #117: FIXED in 44 min: https://jenkins.koha-community.org/job/Koha_19.11_U16/117/ 04:17 koha-jenkins Yippee, build fixed!