Time Nick Message
05:10 koha-jenkins Yippee, build fixed!
05:10 wahanui Congratulations!
05:10 koha-jenkins Project Koha_21.05_D12 build #40: FIXED in 49 min: https://jenkins.koha-community.org/job/Koha_21.05_D12/40/
06:19 reiveune hello
06:56 enkidu good morning all
07:29 ashimema morning
07:31 marcelr hi #koha
07:48 Joubu magnuse: around?
07:49 Joubu 179 msgid "There is one archived suggestion."
07:49 Joubu 180 msgid_plural "There are {count} archived suggestions."
07:49 Joubu 181 msgstr[0] "Det er ett arkivert forslag."
07:49 Joubu 182 msgstr[1] "Det er flere arkiverte forslag."
07:49 Joubu plural version is wrong, it needs a {count}, can you provide it me please?
07:54 alex_a Bonjour
07:54 wahanui hey, alex_a
07:55 Joubu enkidu: around?
07:55 Joubu 178 msgid "There is one archived suggestion."
07:55 Joubu 179 msgid_plural "There are {count} archived suggestions."
07:55 Joubu 180 msgstr[0] "Arşivlenmiş öneri var."
07:55 Joubu 181 msgstr[1] "Arşivlenmiş öneriler var."
07:55 Joubu The plural version is wrong
07:55 * ashimema we have waaaay too many classes
07:55 Joubu a format specification for argument 'count' doesn't exist in 'msgstr[1]'
07:56 cait1 the problem is taht pootle doesn't like it
07:56 cait1 the people don't know how to get around the error .(
07:56 cait1 if you enter { } it complains on saving and everything goes red
07:56 cait1 you need to manually deactivate the warning and it sporadically comes back
07:57 Joubu I sent several times an email to the translate list
07:57 Joubu about that specific error
07:57 Joubu but yeah, it sucks
08:00 marcelr Joubu 29457 is ready
08:00 Joubu lol
08:00 marcelr last in your queue
08:00 marcelr give me a bug number
08:01 Joubu I will include it, but nothing else will be part of 21.11
08:01 marcelr no?!
08:01 ashimema today is release day isn't it?
08:01 marcelr black friday
08:01 marcelr no good day for a release lol
08:02 Joubu marcelr: what about backport?
08:02 Joubu you are going to warn several times
08:02 marcelr might not be needed to backport the second patch ?
08:02 marcelr we can even remove it and put something in release notes
08:02 Joubu do we want people to fix the value?
08:03 marcelr no
08:03 marcelr if you delete a user, it will be null too
08:03 marcelr it is just a deleted staff member
08:03 marcelr he was cancelled himself :)
08:04 * ashimema looks at bug 29457
08:04 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 critical, P5 - low, ---, martin.renvoize, Passed QA , Fee Cancellation records the wrong manager_id
08:04 ashimema thanks for picking it up marcelr
08:04 * ashimema has been a bit overwhelmed of late
08:04 marcelr np
08:06 ashimema hmm
08:07 ashimema I'd be tempted to set all manager_id for CANCELLATION to null
08:07 ashimema we have a few customers where userid happens to fall within int(11) format.. and thus the data is just wrong/confusing
08:08 ashimema but I do like your warning too
08:08 marcelr do they really clash ?
08:08 ashimema yup
08:08 ashimema it's entirely random luck
08:08 ashimema example
08:08 marcelr does the interface actyally show the manager somewhere
08:08 ashimema we have a customer who adds userid using ldap
08:09 marcelr it is really exceptional
08:09 ashimema all their users have borrowernumber that Koha gives them + userid that ldap gives them..
08:09 marcelr bad plan
08:09 ashimema not for us it's not..
08:09 ashimema it entirely depends on how your library decides to format their userids
08:10 marcelr userid on itself is already confusing
08:10 ashimema I'm not too worried personally
08:10 ashimema yeah.. it totally is
08:10 marcelr username or usercode
08:10 ashimema hense my mistake in the first place ☹ï¸
08:10 * ashimema puts his hands up.. this was definitely a bug I introduced ☹ï¸
08:10 marcelr even you can make tiny mistakes
08:10 ashimema perhaps go with it as is..
08:11 ashimema clever people can restore the data themselves if they are so inclined 😉
08:11 * ashimema goes back to wondering why we don't just use bootstraps native a
08:11 ashimema 'alert' rather than have our own 'dialog' set
08:11 marcelr Joubu i would not really mind warning multiple times when backporting but we could also skip it; no strong opninion
08:12 marcelr ashimema: you might wanna write a nice test still in order to get another patch in 21.11 ? heh
08:12 marcelr with clashing numbers
08:13 ashimema lol
08:13 * Joubu goes to the mecanic, back in ~1h
08:14 marcelr hope that goes well on release day :)
08:16 Joubu [off] I know it does not, I am picking the vehicule up, the bill is bad
08:54 marcelr Joubu: bug 29556
08:54 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 normal, P5 - low, ---, oleonard, Passed QA , MARC21slim2MODS.xsl broken by duplicate template name "part"
09:55 cait1 marcelr: yes, manager is shown in GUI
09:55 cait1 the cash report for example, but I think also in the patron account
09:55 cait1 i know because we recently had that discussion
09:55 cait1 definitely in the report
09:56 marcelr ok
10:07 Joubu marcelr: 29556 - I don't understand, can you explain?
10:11 marcelr nice patch to release
10:11 marcelr :)
10:11 Joubu yes but I don't undertstand the change
10:11 Joubu t
10:12 marcelr there was duplicate code
10:12 Joubu the others MODS xsl has the template defined
10:12 marcelr the code is in Utils too
10:12 marcelr is the other one broken too?
10:14 Joubu marcelr: http://paste.koha-community.org/6295
10:16 Joubu that is too late for 21.11.00, sorry
10:16 Joubu it's not that trivial
10:16 Joubu ashimema: are you ok with marcelr's follow-up on bug 29457?
10:16 huginn` Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 critical, P5 - low, ---, martin.renvoize, Passed QA , Fee Cancellation records the wrong manager_id
10:17 ashimema I think so.. I still wonder whether we should be nuking the bad data
10:18 ashimema but that brings me straight back to the idem-potency issue
10:19 ashimema any and all manager_ids that are stored prior to this patch will be wrong for the Cancellation lines
10:19 ashimema perhaps we should add that into the warning so people are told to act
10:19 ashimema also..
10:19 ashimema the 'say' is missing $out 😉
10:19 Joubu should we then have an update to set null on 21.11 that won't be backported?
10:20 ashimema we could do
10:20 ashimema no
10:20 ashimema we couldn't
10:20 Joubu ha no
10:20 Joubu or wwe won't be able to backport the fix
10:20 ashimema aint simple is it..
10:20 ashimema I will improve the message only
10:20 ashimema give me 2 mins to grab the current patch and add a bit on top
10:22 Joubu k
10:24 cait1 tcohen: around?
10:30 ashimema OK.. another follow-up attached to add additional details to the warning.
10:31 ashimema it still doesn't touch the lines themselves.. but gives more detail and a couple of options to solve any caught errors.
10:51 marcelr ashimema: will have a look again
10:52 Joubu please let me know, I am about to push it
10:53 Joubu - say $out "Prior to this patch a users 'userid' was being passed into the manager_id field where borrowernumber is expected";
10:53 Joubu + say $out "Prior to this patch a user's 'userid' was being passed into the manager_id field where borrowernumber is expected";
10:53 Joubu and I've added at the end:
10:53 Joubu + say $out "Nothing to worry about" unless $count_bad || $count_empty
10:54 marcelr SELECT COUNT(*) FROM accountlines WHERE credit_type_code = 'CANCELLATION' AND manager_id IS NOT NULL
10:54 marcelr ashimema: are they really all bad ?
10:54 marcelr no older cancellations before the bug ?
10:55 marcelr not sure if we should push it like this
10:58 marcelr btw I would probably refer to Bugzilla or another source for finding the possible sql fixes instead of printing them here?
10:59 ashimema they are most likely bad
10:59 marcelr no older ones ?
10:59 ashimema if you happen to have userid's that match borrowernumbers your OK
10:59 ashimema it's been an issue since the feature was first introduced
10:59 marcelr before this bug ?
10:59 ashimema yes
11:00 marcelr but we already had accountlines?
11:00 ashimema it was highlighted by adding a FK constraint.. but it was already an issue
11:00 ashimema we did
11:00 ashimema but it's ONLY the CANCELLATION type
11:00 marcelr yeah did we convert to that type ?
11:00 ashimema nope
11:00 ashimema it's a pretty new feature being able to cancel
11:00 ashimema I believe
11:00 marcelr hmm
11:00 marcelr i believe, most likely, ..
11:01 marcelr that not enough assurance
11:01 ashimema only added after the changes to accounts that did all those type code changes
11:01 marcelr if you are not sure, we should not say to people run an update to null
11:01 marcelr they would delete data that might be ok?
11:02 * ashimema steps into meeting
11:03 marcelr Joubu: ^^ i am not convinced, but maybe ashimema convinced you now?
11:03 marcelr add info to release notes too
11:03 Joubu CANCELLATION has been added by 24603
11:03 Joubu which added the bad userid
11:04 marcelr no conversion there, it seems
11:05 marcelr i would move the sql somewhere else personally
11:05 marcelr it might only confuse people
11:05 marcelr in most cases we have NULLs
11:10 tcohen bonjour
11:10 tcohen bonjour
11:16 Joubu marcel, ashimema: I think I will keep this one for 21.11.01..
11:16 tcohen hola Joubu
11:16 Joubu o/
11:18 huginn` News from kohagit: Bug 28959: Fix occurrence in tools/batch_delete_records.pl <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=0a59ab278e0824f924b2adaa9dda1b2e17552697>
11:40 koha-jenkins Project Koha_Master_D12 build #35: FAILURE in 20 min: https://jenkins.koha-community.org/job/Koha_Master_D12/35/
11:56 koha-jenkins Project Koha_Master_D9 build #1831: SUCCESS in 37 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1831/
12:09 koha-jenkins Project Koha_Master_U20 build #251: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_Master_U20/251/
12:20 koha-jenkins Project Koha_Master_D11 build #462: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D11/462/
12:24 koha-jenkins Project Koha_Master_U21 build #37: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master_U21/37/
12:32 koha-jenkins Project Koha_Master build #1839: SUCCESS in 1 hr 13 min: https://jenkins.koha-community.org/job/Koha_Master/1839/
12:33 koha-jenkins Project Koha_Master_D11_MDB_Latest build #741: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/741/
13:00 koha-jenkins Project Koha_Master_D11_CPAN build #483: SUCCESS in 50 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/483/
13:03 koha-jenkins Project Koha_Master_U_Stable build #329: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/329/
13:06 koha-jenkins Project Koha_Master_D11 build #463: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_D11/463/
13:22 koha-jenkins Project Koha_Master_D11_My8 build #704: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/704/
13:22 huginn` News from kohagit: 21.11.00 - Fix translation issues <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=1e52c2a2fc287d2c4d2d2fc75b70d038e7727742>
13:22 huginn` News from kohagit: Translation updates for Koha 21.11.00 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=bb1bcc411e2d580251f22036cebe8b10b2f43954>
13:22 huginn` News from kohagit: Add release notes for Koha 21.11.00 <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f8088f4e57622a476c97fa36f19bab5d83f5a32>
13:23 huginn` News from kohagit: Koha 21.11.00 is here! <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5b9902487b76d0adcd2e40442165171b5942af46>
13:23 huginn` News from kohagit: 21.11.00 - Update .mailmap <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=84fc62289b4fcc417e4342305e78e94624198c68>
13:23 huginn` News from kohagit: 21.11.00 - Update kohastructure.sql <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8df3116760bdf1b889dc6f78e4605e231c4d7d6d>
13:23 huginn` News from kohagit: 21.11.00 - Update history.txt <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=4ea52f0efee9739e7e4d3b340643f1942d87375e>
13:23 huginn` News from kohagit: 21.11.00 - Update contributors.yaml <https://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=5b7a0418bf6a2abba6f14842d2be975cad5775de>
13:24 koha-jenkins Yippee, build fixed!
13:24 wahanui Congratulations!
13:24 koha-jenkins Project Koha_Master_D12 build #36: FIXED in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_Master_D12/36/
13:30 koha-jenkins Project Koha_21.05_U16 build #114: STILL FAILING in 7 min 23 sec: https://jenkins.koha-community.org/job/Koha_21.05_U16/114/
13:33 koha-jenkins Project Koha_21.05_D10 build #153: SUCCESS in 1 hr 0 min: https://jenkins.koha-community.org/job/Koha_21.05_D10/153/
13:38 koha-jenkins Project Koha_21.05_U21 build #34: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_21.05_U21/34/
13:40 Joubu @later tell fridolin master is yours, enjoy!
13:40 huginn` Joubu: The operation succeeded.
13:41 Joubu What I was talking about yesterday, during the dev meeting: https://wiki.koha-community.org/wiki/Development_Community_Statistics
13:41 magnuse Joubu++ fridolin++
13:44 koha-jenkins Project Koha_21.05_U18 build #104: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/104/
13:49 koha-jenkins Project Koha_21.05_U20 build #115: SUCCESS in 48 min: https://jenkins.koha-community.org/job/Koha_21.05_U20/115/
13:53 ashimema Joubu++
13:59 tcohen Joubu++
14:15 koha-jenkins Project Koha_21.05_D9 build #109: SUCCESS in 36 min: https://jenkins.koha-community.org/job/Koha_21.05_D9/109/
14:19 koha-jenkins Project Koha_21.05_U_Stable build #105: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/105/
14:21 cait1 did I miss the confetti moment?
14:22 cait1 is it there yet?
14:22 cait1 Joubu++
14:23 koha-jenkins Project Koha_21.05_D11 build #129: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_21.05_D11/129/
14:25 cait1 oh no... i DID miss it
14:26 cait1 confetti!
14:26 wahanui o/`'`'`'`'`'`'`'`'`'`'`'`
14:26 koha-jenkins Project Koha_21.05_D12 build #41: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_21.05_D12/41/
14:29 koha-jenkins Project Koha_Master_D12 build #37: SUCCESS in 56 min: https://jenkins.koha-community.org/job/Koha_Master_D12/37/
14:40 koha-jenkins Project Koha_Master_D11_MDB_Latest build #742: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/742/
14:47 Joubu Thank you all #koha :)
14:47 Joubu you did the hard part
14:47 Joubu Enjoy the weekend!
14:47 cait1 you too :)
14:48 koha-jenkins Project Koha_Master_U_Stable build #330: SUCCESS in 33 min: https://jenkins.koha-community.org/job/Koha_Master_U_Stable/330/
14:54 ashimema 🙂
15:04 koha-jenkins Project Koha_Master_D11_CPAN build #484: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_D11_CPAN/484/
15:11 nugged yaaaay!!!!!!! :)))))))
15:11 nugged 🎊
15:19 koha-jenkins Project Koha_21.05_U18 build #105: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_21.05_U18/105/
15:22 koha-jenkins Project Koha_Master_U20 build #252: SUCCESS in 34 min: https://jenkins.koha-community.org/job/Koha_Master_U20/252/
15:24 koha-jenkins Project Koha_Master_U21 build #38: SUCCESS in 54 min: https://jenkins.koha-community.org/job/Koha_Master_U21/38/
15:25 koha-jenkins Project Koha_Master_D11_My8 build #705: SUCCESS in 59 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/705/
15:29 nugged doing confetti alone :)... get late to the party :P
15:29 * nugged went to prepare Monday's build for the customers to upgrade theirs Kohas... 🤞
15:34 reiveune bye
15:55 koha-jenkins Project Koha_Master_D11 build #464: SUCCESS in 32 min: https://jenkins.koha-community.org/job/Koha_Master_D11/464/
15:56 koha-jenkins Project Koha_Master_D9 build #1832: SUCCESS in 1 hr 16 min: https://jenkins.koha-community.org/job/Koha_Master_D9/1832/
16:05 koha-jenkins Project Koha_Master build #1840: UNSTABLE in 40 min: https://jenkins.koha-community.org/job/Koha_Master/1840/
16:15 koha-jenkins Project Koha_21.05_D12 build #42: SUCCESS in 55 min: https://jenkins.koha-community.org/job/Koha_21.05_D12/42/
16:24 koha-jenkins Project Koha_Master_D11_MDB_Latest build #743: SUCCESS in 58 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/743/
16:27 koha-jenkins Project Koha_Master_U20 build #253: SUCCESS in 40 min: https://jenkins.koha-community.org/job/Koha_Master_U20/253/
17:06 tcohen Joubu++
17:06 tcohen Joubu++
17:06 tcohen Koha++
17:06 tcohen cait++
17:06 tcohen ashimema++
17:06 tcohen oleonard++
17:07 tcohen nugged++
17:07 koha-jenkins Project Koha_21.05_U_Stable build #106: SUCCESS in 51 min: https://jenkins.koha-community.org/job/Koha_21.05_U_Stable/106/
17:07 tcohen tuxayo++
17:07 tcohen mtj++
17:42 ashimema Community++
17:42 ashimema tcohen++
17:43 tcohen community++
17:43 tcohen always
18:55 koha-jenkins Yippee, build fixed!
18:55 wahanui Congratulations!
18:55 koha-jenkins Project Koha_Master build #1841: FIXED in 1 hr 4 min: https://jenkins.koha-community.org/job/Koha_Master/1841/
18:59 nugged tcohen++, 2U2! :)
19:27 tuxayo oh there was a party :D
19:28 tuxayo community++
20:34 fridolin whooooo release is out
20:35 fridolin a new cycle begins ... and the wheel of time is turning ...
22:19 nugged party hard :) ... community++
23:33 mtj hi tcohen, can you create a 21.11 branch on ktd repo please
23:35 mtj aah, im ok :)